1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
|
From c8c0c7e922fde83640118bf19fe0c78cb8ce2f79 Mon Sep 17 00:00:00 2001
From: Ralph Castain <rhc@pmix.org>
Date: Sun, 9 Nov 2025 11:02:53 -0700
Subject: [PATCH] Enable use of loopback interface
We used to have support for both Unix sockets and TCP interfaces, so we explicitly
ignored all loopback devices (leaving local operations to the Unix sockets).
However, at some point years back we removed the Unix socket support, transitioning
solely over to TCP interfaces. Nobody remembered the TCP support ignoring loopbacks,
and we always picked up public interfaces - so nobody realized the limitation.
Now that we have a directive to not allow remote connections, translating into wanting
a loopback device, we cannot continue to reject loopbacks. So we need to fix that bug
to enable selection of the loopback.
Signed-off-by: Ralph Castain <rhc@pmix.org>
---
src/mca/pif/base/pif_base_components.c | 9 +--------
src/mca/pif/bsdx_ipv4/pif_bsdx.c | 7 +------
src/mca/pif/bsdx_ipv6/pif_bsdx_ipv6.c | 9 +--------
src/mca/pif/pif.h | 3 +--
src/mca/pif/posix_ipv4/pif_posix.c | 5 -----
src/util/pmix_if.h | 3 +--
6 files changed, 5 insertions(+), 31 deletions(-)
Index: pmix/src/mca/pif/base/pif_base_components.c
===================================================================
--- pmix.orig/src/mca/pif/base/pif_base_components.c 2025-11-09 21:45:04.557091406 +0100
+++ pmix/src/mca/pif/base/pif_base_components.c 2025-11-09 21:45:04.550659240 +0100
@@ -3,7 +3,7 @@
* Copyright (c) 2015-2020 Intel, Inc. All rights reserved.
* Copyright (c) 2015-2016 Research Organization for Information Science
* and Technology (RIST). All rights reserved.
- * Copyright (c) 2021-2022 Nanook Consulting. All rights reserved.
+ * Copyright (c) 2021-2025 Nanook Consulting All rights reserved.
* $COPYRIGHT$
*
* Additional copyrights may follow
@@ -24,7 +24,6 @@
/* instantiate the global list of interfaces */
pmix_list_t pmix_if_list = PMIX_LIST_STATIC_INIT;
bool pmix_if_do_not_resolve = false;
-bool pmix_if_retain_loopback = false;
static int pmix_pif_base_register(pmix_mca_base_register_flag_t flags);
static int pmix_pif_base_open(pmix_mca_base_open_flag_t flags);
@@ -49,12 +48,6 @@
PMIX_MCA_BASE_VAR_TYPE_BOOL,
&pmix_if_do_not_resolve);
- pmix_if_retain_loopback = false;
- (void) pmix_mca_base_framework_var_register(&pmix_pif_base_framework, "retain_loopback",
- "If nonzero, retain loopback interfaces",
- PMIX_MCA_BASE_VAR_TYPE_BOOL,
- &pmix_if_retain_loopback);
-
return PMIX_SUCCESS;
}
Index: pmix/src/mca/pif/bsdx_ipv4/pif_bsdx.c
===================================================================
--- pmix.orig/src/mca/pif/bsdx_ipv4/pif_bsdx.c 2025-11-09 21:45:04.557091406 +0100
+++ pmix/src/mca/pif/bsdx_ipv4/pif_bsdx.c 2025-11-09 21:45:04.550971748 +0100
@@ -125,12 +125,7 @@
continue;
}
- /* skip interface if it is a loopback device (IFF_LOOPBACK set) */
- if (!pmix_if_retain_loopback && 0 != (cur_ifaddrs->ifa_flags & IFF_LOOPBACK)) {
- continue;
- }
-
- /* or if it is a point-to-point interface */
+ /* skip if it is a point-to-point interface */
/* TODO: do we really skip p2p? */
if (0 != (cur_ifaddrs->ifa_flags & IFF_POINTOPOINT)) {
continue;
Index: pmix/src/mca/pif/bsdx_ipv6/pif_bsdx_ipv6.c
===================================================================
--- pmix.orig/src/mca/pif/bsdx_ipv6/pif_bsdx_ipv6.c 2025-11-09 21:45:04.557091406 +0100
+++ pmix/src/mca/pif/bsdx_ipv6/pif_bsdx_ipv6.c 2025-11-09 21:45:04.551238508 +0100
@@ -119,14 +119,7 @@
continue;
}
- /* skip interface if it is a loopback device (IFF_LOOPBACK set) */
- if (!pmix_if_retain_loopback && 0 != (cur_ifaddrs->ifa_flags & IFF_LOOPBACK)) {
- pmix_output_verbose(1, pmix_pif_base_framework.framework_output,
- "skipping loopback interface %s.\n", cur_ifaddrs->ifa_name);
- continue;
- }
-
- /* or if it is a point-to-point interface */
+ /* skip if it is a point-to-point interface */
/* TODO: do we really skip p2p? */
if (0 != (cur_ifaddrs->ifa_flags & IFF_POINTOPOINT)) {
pmix_output_verbose(1, pmix_pif_base_framework.framework_output,
Index: pmix/src/mca/pif/pif.h
===================================================================
--- pmix.orig/src/mca/pif/pif.h 2025-11-09 21:45:04.557091406 +0100
+++ pmix/src/mca/pif/pif.h 2025-11-09 21:45:04.551463280 +0100
@@ -4,7 +4,7 @@
* Copyright (c) 2015 Los Alamos National Security, LLC. All rights
* reserved.
* Copyright (c) 2016-2019 Intel, Inc. All rights reserved.
- * Copyright (c) 2021-2022 Nanook Consulting. All rights reserved.
+ * Copyright (c) 2021-2025 Nanook Consulting All rights reserved.
* $COPYRIGHT$
*
* Additional copyrights may follow
@@ -76,7 +76,6 @@
/* global flags */
extern bool pmix_if_do_not_resolve;
-extern bool pmix_if_retain_loopback;
/**
* Structure for if components.
Index: pmix/src/mca/pif/posix_ipv4/pif_posix.c
===================================================================
--- pmix.orig/src/mca/pif/posix_ipv4/pif_posix.c 2025-11-09 21:45:04.557091406 +0100
+++ pmix/src/mca/pif/posix_ipv4/pif_posix.c 2025-11-09 21:45:04.551707097 +0100
@@ -226,11 +226,6 @@
continue;
}
#endif
-#if 0
- if (!pmix_if_retain_loopback && (ifr->ifr_flags & IFF_LOOPBACK) != 0) {
- continue;
- }
-#endif
intf = PMIX_NEW(pmix_pif_t);
if (NULL == intf) {
Index: pmix/src/util/pmix_if.h
===================================================================
--- pmix.orig/src/util/pmix_if.h 2025-11-09 21:45:04.557091406 +0100
+++ pmix/src/util/pmix_if.h 2025-11-09 21:45:04.552020382 +0100
@@ -14,7 +14,7 @@
* Copyright (c) 2008 Sun Microsystems, Inc. All rights reserved.
* Copyright (c) 2013 Cisco Systems, Inc. All rights reserved.
* Copyright (c) 2016-2020 Intel, Inc. All rights reserved.
- * Copyright (c) 2021-2023 Nanook Consulting. All rights reserved.
+ * Copyright (c) 2021-2025 Nanook Consulting All rights reserved.
* $COPYRIGHT$
*
* Additional copyrights may follow
@@ -77,7 +77,6 @@
/* global flags */
PMIX_EXPORT extern bool pmix_if_do_not_resolve;
-PMIX_EXPORT extern bool pmix_if_retain_loopback;
/**
* Lookup an interface by address and return its name.
|
