File: analogsignal.cpp

package info (click to toggle)
pulseview 0.4.2-5
  • links: PTS, VCS
  • area: main
  • in suites: forky, sid
  • size: 5,092 kB
  • sloc: cpp: 25,958; xml: 215; java: 42; makefile: 2
file content (1342 lines) | stat: -rw-r--r-- 41,969 bytes parent folder | download | duplicates (3)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
/*
 * This file is part of the PulseView project.
 *
 * Copyright (C) 2012 Joel Holdsworth <joel@airwebreathe.org.uk>
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, see <http://www.gnu.org/licenses/>.
 */

#include <extdef.h>

#include <cassert>
#include <cmath>
#include <cstdlib>
#include <limits>
#include <vector>

#include <QApplication>
#include <QCheckBox>
#include <QComboBox>
#include <QDebug>
#include <QFormLayout>
#include <QGridLayout>
#include <QLabel>
#include <QString>

#include "analogsignal.hpp"
#include "logicsignal.hpp"
#include "view.hpp"

#include "pv/util.hpp"
#include "pv/data/analog.hpp"
#include "pv/data/analogsegment.hpp"
#include "pv/data/logic.hpp"
#include "pv/data/logicsegment.hpp"
#include "pv/data/signalbase.hpp"
#include "pv/globalsettings.hpp"

#include <libsigrokcxx/libsigrokcxx.hpp>

using std::deque;
using std::div;
using std::div_t;
// Note that "using std::isnan;" is _not_ put here since that would break
// compilation on some platforms. Use "std::isnan()" instead in checks below.
using std::max;
using std::make_pair;
using std::min;
using std::numeric_limits;
using std::out_of_range;
using std::pair;
using std::shared_ptr;
using std::vector;

using pv::data::LogicSegment;
using pv::data::SignalBase;
using pv::util::SIPrefix;

namespace pv {
namespace views {
namespace trace {

const QColor AnalogSignal::SignalColors[4] = {
	QColor(0xC4, 0xA0, 0x00),	// Yellow
	QColor(0x87, 0x20, 0x7A),	// Magenta
	QColor(0x20, 0x4A, 0x87),	// Blue
	QColor(0x4E, 0x9A, 0x06)	// Green
};

const QPen AnalogSignal::AxisPen(QColor(0, 0, 0, 30 * 256 / 100), 2);
const QColor AnalogSignal::GridMajorColor = QColor(0, 0, 0, 40 * 256 / 100);
const QColor AnalogSignal::GridMinorColor = QColor(0, 0, 0, 20 * 256 / 100);

const QColor AnalogSignal::SamplingPointColor(0x77, 0x77, 0x77);
const QColor AnalogSignal::SamplingPointColorLo = QColor(200, 0, 0, 80 * 256 / 100);
const QColor AnalogSignal::SamplingPointColorNe = QColor(0,   0, 0, 80 * 256 / 100);
const QColor AnalogSignal::SamplingPointColorHi = QColor(0, 200, 0, 80 * 256 / 100);

const QColor AnalogSignal::ThresholdColor = QColor(0, 0, 0, 30 * 256 / 100);
const QColor AnalogSignal::ThresholdColorLo = QColor(255, 0, 0, 8 * 256 / 100);
const QColor AnalogSignal::ThresholdColorNe = QColor(0,   0, 0, 10 * 256 / 100);
const QColor AnalogSignal::ThresholdColorHi = QColor(0, 255, 0, 8 * 256 / 100);

const int64_t AnalogSignal::TracePaintBlockSize = 1024 * 1024;  // 4 MiB (due to float)
const float AnalogSignal::EnvelopeThreshold = 64.0f;

const int AnalogSignal::MaximumVDivs = 10;
const int AnalogSignal::MinScaleIndex = -6;  // 0.01 units/div
const int AnalogSignal::MaxScaleIndex = 10;  // 1000 units/div

const int AnalogSignal::InfoTextMarginRight = 20;
const int AnalogSignal::InfoTextMarginBottom = 5;

AnalogSignal::AnalogSignal(
	pv::Session &session,
	shared_ptr<data::SignalBase> base) :
	Signal(session, base),
	value_at_hover_pos_(std::numeric_limits<float>::quiet_NaN()),
	scale_index_(4), // 20 per div
	pos_vdivs_(1),
	neg_vdivs_(1),
	resolution_(0),
	display_type_(DisplayBoth),
	autoranging_(true)
{
	axis_pen_ = AxisPen;

	pv::data::Analog* analog_data =
		dynamic_cast<pv::data::Analog*>(data().get());

	connect(analog_data, SIGNAL(min_max_changed(float, float)),
		this, SLOT(on_min_max_changed(float, float)));

	GlobalSettings settings;
	show_sampling_points_ =
		settings.value(GlobalSettings::Key_View_ShowSamplingPoints).toBool();
	fill_high_areas_ =
		settings.value(GlobalSettings::Key_View_FillSignalHighAreas).toBool();
	high_fill_color_ = QColor::fromRgba(settings.value(
		GlobalSettings::Key_View_FillSignalHighAreaColor).value<uint32_t>());
	show_analog_minor_grid_ =
		settings.value(GlobalSettings::Key_View_ShowAnalogMinorGrid).toBool();
	conversion_threshold_disp_mode_ =
		settings.value(GlobalSettings::Key_View_ConversionThresholdDispMode).toInt();
	div_height_ = settings.value(GlobalSettings::Key_View_DefaultDivHeight).toInt();

	base_->set_color(SignalColors[base_->index() % countof(SignalColors)]);
	update_scale();
}

shared_ptr<pv::data::SignalData> AnalogSignal::data() const
{
	return base_->analog_data();
}

std::map<QString, QVariant> AnalogSignal::save_settings() const
{
	std::map<QString, QVariant> result;

	result["pos_vdivs"] = pos_vdivs_;
	result["neg_vdivs"] = neg_vdivs_;
	result["scale_index"] = scale_index_;
	result["display_type"] = display_type_;
	result["autoranging"] = pos_vdivs_;
	result["div_height"] = div_height_;

	return result;
}

void AnalogSignal::restore_settings(std::map<QString, QVariant> settings)
{
	auto entry = settings.find("pos_vdivs");
	if (entry != settings.end())
		pos_vdivs_ = settings["pos_vdivs"].toInt();

	entry = settings.find("neg_vdivs");
	if (entry != settings.end())
		neg_vdivs_ = settings["neg_vdivs"].toInt();

	entry = settings.find("scale_index");
	if (entry != settings.end()) {
		scale_index_ = settings["scale_index"].toInt();
		update_scale();
	}

	entry = settings.find("display_type");
	if (entry != settings.end())
		display_type_ = (DisplayType)(settings["display_type"].toInt());

	entry = settings.find("autoranging");
	if (entry != settings.end())
		autoranging_ = settings["autoranging"].toBool();

	entry = settings.find("div_height");
	if (entry != settings.end()) {
		const int old_height = div_height_;
		div_height_ = settings["div_height"].toInt();

		if ((div_height_ != old_height) && owner_) {
			// Call order is important, otherwise the lazy event handler won't work
			owner_->extents_changed(false, true);
			owner_->row_item_appearance_changed(false, true);
		}
	}
}

pair<int, int> AnalogSignal::v_extents() const
{
	const int ph = pos_vdivs_ * div_height_;
	const int nh = neg_vdivs_ * div_height_;
	return make_pair(-ph, nh);
}

void AnalogSignal::paint_back(QPainter &p, ViewItemPaintParams &pp)
{
	if (!base_->enabled())
		return;

	bool paint_thr_bg =
		conversion_threshold_disp_mode_ == GlobalSettings::ConvThrDispMode_Background;

	const vector<double> thresholds = base_->get_conversion_thresholds();

	// Only display thresholds if we have some and we show analog samples
	if ((thresholds.size() > 0) && paint_thr_bg &&
		((display_type_ == DisplayAnalog) || (display_type_ == DisplayBoth))) {

		const int visual_y = get_visual_y();
		const pair<int, int> extents = v_extents();
		const int top = visual_y + extents.first;
		const int btm = visual_y + extents.second;

		// Draw high/neutral/low areas
		if (thresholds.size() == 2) {
			int thr_lo = visual_y - thresholds[0] * scale_;
			int thr_hi = visual_y - thresholds[1] * scale_;
			thr_lo = min(max(thr_lo, top), btm);
			thr_hi = min(max(thr_hi, top), btm);

			p.fillRect(QRectF(pp.left(), top, pp.width(), thr_hi - top),
				QBrush(ThresholdColorHi));
			p.fillRect(QRectF(pp.left(), thr_hi, pp.width(), thr_lo - thr_hi),
				QBrush(ThresholdColorNe));
			p.fillRect(QRectF(pp.left(), thr_lo, pp.width(), btm - thr_lo),
				QBrush(ThresholdColorLo));
		} else {
			int thr = visual_y - thresholds[0] * scale_;
			thr = min(max(thr, top), btm);

			p.fillRect(QRectF(pp.left(), top, pp.width(), thr - top),
				QBrush(ThresholdColorHi));
			p.fillRect(QRectF(pp.left(), thr, pp.width(), btm - thr),
				QBrush(ThresholdColorLo));
		}

		paint_axis(p, pp, get_visual_y());
	} else {
		Signal::paint_back(p, pp);
		paint_axis(p, pp, get_visual_y());
	}
}

void AnalogSignal::paint_mid(QPainter &p, ViewItemPaintParams &pp)
{
	assert(base_->analog_data());
	assert(owner_);

	const int y = get_visual_y();

	if (!base_->enabled())
		return;

	if ((display_type_ == DisplayAnalog) || (display_type_ == DisplayBoth)) {
		paint_grid(p, y, pp.left(), pp.right());

		shared_ptr<pv::data::AnalogSegment> segment = get_analog_segment_to_paint();
		if (!segment || (segment->get_sample_count() == 0))
			return;

		const double pixels_offset = pp.pixels_offset();
		const double samplerate = max(1.0, segment->samplerate());
		const pv::util::Timestamp& start_time = segment->start_time();
		const int64_t last_sample = (int64_t)segment->get_sample_count() - 1;
		const double samples_per_pixel = samplerate * pp.scale();
		const pv::util::Timestamp start = samplerate * (pp.offset() - start_time);
		const pv::util::Timestamp end = start + samples_per_pixel * pp.width();

		const int64_t start_sample = min(max(floor(start).convert_to<int64_t>(),
			(int64_t)0), last_sample);
		const int64_t end_sample = min(max((ceil(end) + 1).convert_to<int64_t>(),
			(int64_t)0), last_sample);

		if (samples_per_pixel < EnvelopeThreshold)
			paint_trace(p, segment, y, pp.left(), start_sample, end_sample,
				pixels_offset, samples_per_pixel);
		else
			paint_envelope(p, segment, y, pp.left(), start_sample, end_sample,
				pixels_offset, samples_per_pixel);
	}

	if ((display_type_ == DisplayConverted) || (display_type_ == DisplayBoth))
		paint_logic_mid(p, pp);
}

void AnalogSignal::paint_fore(QPainter &p, ViewItemPaintParams &pp)
{
	if (!enabled())
		return;

	if ((display_type_ == DisplayAnalog) || (display_type_ == DisplayBoth)) {
		const int y = get_visual_y();

		QString infotext;

		// Show the info section on the right side of the trace, including
		// the value at the hover point when the hover marker is enabled
		// and we have corresponding data available
		if (show_hover_marker_ && !std::isnan(value_at_hover_pos_)) {
			infotext = QString("[%1] %2 V/div")
				.arg(format_value_si(value_at_hover_pos_, SIPrefix::unspecified, 2, "V", false))
				.arg(resolution_);
		} else
			infotext = QString("%1 V/div").arg(resolution_);

		p.setPen(base_->color());
		p.setFont(QApplication::font());

		const QRectF bounding_rect = QRectF(pp.left(),
				y + v_extents().first,
				pp.width() - InfoTextMarginRight,
				v_extents().second - v_extents().first - InfoTextMarginBottom);

		p.drawText(bounding_rect, Qt::AlignRight | Qt::AlignBottom, infotext);
	}

	if (show_hover_marker_)
		paint_hover_marker(p);
}

void AnalogSignal::paint_grid(QPainter &p, int y, int left, int right)
{
	bool was_antialiased = p.testRenderHint(QPainter::Antialiasing);
	p.setRenderHint(QPainter::Antialiasing, false);

	if (pos_vdivs_ > 0) {
		p.setPen(QPen(GridMajorColor, 1, Qt::DashLine));
		for (int i = 1; i <= pos_vdivs_; i++) {
			const float dy = i * div_height_;
			p.drawLine(QLineF(left, y - dy, right, y - dy));
		}
	}

	if ((pos_vdivs_ > 0) && show_analog_minor_grid_) {
		p.setPen(QPen(GridMinorColor, 1, Qt::DashLine));
		for (int i = 0; i < pos_vdivs_; i++) {
			const float dy = i * div_height_;
			const float dy25 = dy + (0.25 * div_height_);
			const float dy50 = dy + (0.50 * div_height_);
			const float dy75 = dy + (0.75 * div_height_);
			p.drawLine(QLineF(left, y - dy25, right, y - dy25));
			p.drawLine(QLineF(left, y - dy50, right, y - dy50));
			p.drawLine(QLineF(left, y - dy75, right, y - dy75));
		}
	}

	if (neg_vdivs_ > 0) {
		p.setPen(QPen(GridMajorColor, 1, Qt::DashLine));
		for (int i = 1; i <= neg_vdivs_; i++) {
			const float dy = i * div_height_;
			p.drawLine(QLineF(left, y + dy, right, y + dy));
		}
	}

	if ((pos_vdivs_ > 0) && show_analog_minor_grid_) {
		p.setPen(QPen(GridMinorColor, 1, Qt::DashLine));
		for (int i = 0; i < neg_vdivs_; i++) {
			const float dy = i * div_height_;
			const float dy25 = dy + (0.25 * div_height_);
			const float dy50 = dy + (0.50 * div_height_);
			const float dy75 = dy + (0.75 * div_height_);
			p.drawLine(QLineF(left, y + dy25, right, y + dy25));
			p.drawLine(QLineF(left, y + dy50, right, y + dy50));
			p.drawLine(QLineF(left, y + dy75, right, y + dy75));
		}
	}

	p.setRenderHint(QPainter::Antialiasing, was_antialiased);
}

void AnalogSignal::paint_trace(QPainter &p,
	const shared_ptr<pv::data::AnalogSegment> &segment,
	int y, int left, const int64_t start, const int64_t end,
	const double pixels_offset, const double samples_per_pixel)
{
	if (end <= start)
		return;

	bool paint_thr_dots =
		(base_->get_conversion_type() != data::SignalBase::NoConversion) &&
		(conversion_threshold_disp_mode_ == GlobalSettings::ConvThrDispMode_Dots);

	vector<double> thresholds;
	if (paint_thr_dots)
		thresholds = base_->get_conversion_thresholds();

	// Calculate and paint the sampling points if enabled and useful
	GlobalSettings settings;
	const bool show_sampling_points =
		(show_sampling_points_ || paint_thr_dots) && (samples_per_pixel < 0.25);

	p.setPen(base_->color());

	const int64_t points_count = end - start + 1;

	QPointF *points = new QPointF[points_count];
	QPointF *point = points;

	vector<QRectF> sampling_points[3];

	int64_t sample_count = min(points_count, TracePaintBlockSize);
	int64_t block_sample = 0;
	float *sample_block = new float[TracePaintBlockSize];
	segment->get_samples(start, start + sample_count, sample_block);

	if (show_hover_marker_)
		reset_pixel_values();

	const int w = 2;
	for (int64_t sample = start; sample <= end; sample++, block_sample++) {

		// Fetch next block of samples if we finished the current one
		if (block_sample == TracePaintBlockSize) {
			block_sample = 0;
			sample_count = min(points_count - sample, TracePaintBlockSize);
			segment->get_samples(sample, sample + sample_count, sample_block);
		}

		const float abs_x = sample / samples_per_pixel - pixels_offset;
		const float x = left + abs_x;

		*point++ = QPointF(x, y - sample_block[block_sample] * scale_);

		// Generate the pixel<->value lookup table for the mouse hover
		if (show_hover_marker_)
			process_next_sample_value(abs_x, sample_block[block_sample]);

		// Create the sampling points if needed
		if (show_sampling_points) {
			int idx = 0;  // Neutral

			if (paint_thr_dots) {
				if (thresholds.size() == 1)
					idx = (sample_block[block_sample] >= thresholds[0]) ? 2 : 1;
				else if (thresholds.size() == 2) {
					if (sample_block[block_sample] > thresholds[1])
						idx = 2;  // High
					else if (sample_block[block_sample] < thresholds[0])
						idx = 1;  // Low
				}
			}

			sampling_points[idx].emplace_back(x - (w / 2), y - sample_block[block_sample] * scale_ - (w / 2), w, w);
		}
	}
	delete[] sample_block;

	// QPainter::drawPolyline() is slow, let's paint the lines ourselves
	for (int64_t i = 1; i < points_count; i++)
		p.drawLine(points[i - 1], points[i]);

	if (show_sampling_points) {
		if (paint_thr_dots) {
			p.setPen(SamplingPointColorNe);
			p.drawRects(sampling_points[0].data(), sampling_points[0].size());
			p.setPen(SamplingPointColorLo);
			p.drawRects(sampling_points[1].data(), sampling_points[1].size());
			p.setPen(SamplingPointColorHi);
			p.drawRects(sampling_points[2].data(), sampling_points[2].size());
		} else {
			p.setPen(SamplingPointColor);
			p.drawRects(sampling_points[0].data(), sampling_points[0].size());
		}
	}

	delete[] points;
}

void AnalogSignal::paint_envelope(QPainter &p,
	const shared_ptr<pv::data::AnalogSegment> &segment,
	int y, int left, const int64_t start, const int64_t end,
	const double pixels_offset, const double samples_per_pixel)
{
	using pv::data::AnalogSegment;

	// Note: Envelope painting currently doesn't generate a pixel<->value lookup table
	if (show_hover_marker_)
		reset_pixel_values();

	AnalogSegment::EnvelopeSection e;
	segment->get_envelope_section(e, start, end, samples_per_pixel);

	if (e.length < 2)
		return;

	p.setPen(QPen(Qt::NoPen));
	p.setBrush(base_->color());

	QRectF *const rects = new QRectF[e.length];
	QRectF *rect = rects;

	for (uint64_t sample = 0; sample < e.length - 1; sample++) {
		const float x = ((e.scale * sample + e.start) /
			samples_per_pixel - pixels_offset) + left;

		const AnalogSegment::EnvelopeSample *const s = e.samples + sample;

		// We overlap this sample with the next so that vertical
		// gaps do not appear during steep rising or falling edges
		const float b = y - max(s->max, (s + 1)->min) * scale_;
		const float t = y - min(s->min, (s + 1)->max) * scale_;

		float h = b - t;
		if (h >= 0.0f && h <= 1.0f)
			h = 1.0f;
		if (h <= 0.0f && h >= -1.0f)
			h = -1.0f;

		*rect++ = QRectF(x, t, 1.0f, h);
	}

	p.drawRects(rects, e.length);

	delete[] rects;
	delete[] e.samples;
}

void AnalogSignal::paint_logic_mid(QPainter &p, ViewItemPaintParams &pp)
{
	QLineF *line;

	vector< pair<int64_t, bool> > edges;

	assert(base_);

	const int y = get_visual_y();

	if (!base_->enabled() || !base_->logic_data())
		return;

	const int signal_margin =
		QFontMetrics(QApplication::font()).height() / 2;

	const int ph = min(pos_vdivs_, 1) * div_height_;
	const int nh = min(neg_vdivs_, 1) * div_height_;
	const float high_offset = y - ph + signal_margin + 0.5f;
	const float low_offset = y + nh - signal_margin - 0.5f;
	const float signal_height = low_offset - high_offset;

	shared_ptr<pv::data::LogicSegment> segment = get_logic_segment_to_paint();
	if (!segment || (segment->get_sample_count() == 0))
		return;

	double samplerate = segment->samplerate();

	// Show sample rate as 1Hz when it is unknown
	if (samplerate == 0.0)
		samplerate = 1.0;

	const double pixels_offset = pp.pixels_offset();
	const pv::util::Timestamp& start_time = segment->start_time();
	const int64_t last_sample = (int64_t)segment->get_sample_count() - 1;
	const double samples_per_pixel = samplerate * pp.scale();
	const double pixels_per_sample = 1 / samples_per_pixel;
	const pv::util::Timestamp start = samplerate * (pp.offset() - start_time);
	const pv::util::Timestamp end = start + samples_per_pixel * pp.width();

	const int64_t start_sample = min(max(floor(start).convert_to<int64_t>(),
		(int64_t)0), last_sample);
	const uint64_t end_sample = min(max(ceil(end).convert_to<int64_t>(),
		(int64_t)0), last_sample);

	segment->get_subsampled_edges(edges, start_sample, end_sample,
		samples_per_pixel / LogicSignal::Oversampling, 0);
	assert(edges.size() >= 2);

	const float first_sample_x =
		pp.left() + (edges.front().first / samples_per_pixel - pixels_offset);
	const float last_sample_x =
		pp.left() + (edges.back().first / samples_per_pixel - pixels_offset);

	// Check whether we need to paint the sampling points
	const bool show_sampling_points = show_sampling_points_ && (samples_per_pixel < 0.25);
	vector<QRectF> sampling_points;
	float sampling_point_x = first_sample_x;
	int64_t sampling_point_sample = start_sample;
	const int w = 2;

	if (show_sampling_points)
		sampling_points.reserve(end_sample - start_sample + 1);

	vector<QRectF> high_rects;
	float rising_edge_x;
	bool rising_edge_seen = false;

	// Paint the edges
	const unsigned int edge_count = edges.size() - 2;
	QLineF *const edge_lines = new QLineF[edge_count];
	line = edge_lines;

	if (edges.front().second) {
		// Beginning of trace is high
		rising_edge_x = first_sample_x;
		rising_edge_seen = true;
	}

	for (auto i = edges.cbegin() + 1; i != edges.cend() - 1; i++) {
		// Note: multiple edges occupying a single pixel are represented by an edge
		// with undefined logic level. This means that only the first falling edge
		// after a rising edge corresponds to said rising edge - and vice versa. If
		// more edges with the same logic level follow, they denote multiple edges.

		const float x = pp.left() + ((*i).first / samples_per_pixel - pixels_offset);
		*line++ = QLineF(x, high_offset, x, low_offset);

		if (fill_high_areas_) {
			// Any edge terminates a high area
			if (rising_edge_seen) {
				const int width = x - rising_edge_x;
				if (width > 0)
					high_rects.emplace_back(rising_edge_x, high_offset,
						width, signal_height);
				rising_edge_seen = false;
			}

			// Only rising edges start high areas
			if ((*i).second) {
				rising_edge_x = x;
				rising_edge_seen = true;
			}
		}

		if (show_sampling_points)
			while (sampling_point_sample < (*i).first) {
				const float y = (*i).second ? low_offset : high_offset;
				sampling_points.emplace_back(
					QRectF(sampling_point_x - (w / 2), y - (w / 2), w, w));
				sampling_point_sample++;
				sampling_point_x += pixels_per_sample;
			};
	}

	// Calculate the sample points from the last edge to the end of the trace
	if (show_sampling_points)
		while ((uint64_t)sampling_point_sample <= end_sample) {
			// Signal changed after the last edge, so the level is inverted
			const float y = (edges.cend() - 1)->second ? high_offset : low_offset;
			sampling_points.emplace_back(
				QRectF(sampling_point_x - (w / 2), y - (w / 2), w, w));
			sampling_point_sample++;
			sampling_point_x += pixels_per_sample;
		};

	if (fill_high_areas_) {
		// Add last high rectangle if the signal is still high at the end of the trace
		if (rising_edge_seen && (edges.cend() - 1)->second)
			high_rects.emplace_back(rising_edge_x, high_offset,
				last_sample_x - rising_edge_x, signal_height);

		p.setPen(high_fill_color_);
		p.setBrush(high_fill_color_);
		p.drawRects((const QRectF*)(high_rects.data()), high_rects.size());
	}

	p.setPen(LogicSignal::EdgeColor);
	p.drawLines(edge_lines, edge_count);
	delete[] edge_lines;

	// Paint the caps
	const unsigned int max_cap_line_count = edges.size();
	QLineF *const cap_lines = new QLineF[max_cap_line_count];

	p.setPen(LogicSignal::HighColor);
	paint_logic_caps(p, cap_lines, edges, true, samples_per_pixel,
		pixels_offset, pp.left(), high_offset);
	p.setPen(LogicSignal::LowColor);
	paint_logic_caps(p, cap_lines, edges, false, samples_per_pixel,
		pixels_offset, pp.left(), low_offset);

	delete[] cap_lines;

	// Paint the sampling points
	if (show_sampling_points) {
		p.setPen(SamplingPointColor);
		p.drawRects(sampling_points.data(), sampling_points.size());
	}
}

void AnalogSignal::paint_logic_caps(QPainter &p, QLineF *const lines,
	vector< pair<int64_t, bool> > &edges, bool level,
	double samples_per_pixel, double pixels_offset, float x_offset,
	float y_offset)
{
	QLineF *line = lines;

	for (auto i = edges.begin(); i != (edges.end() - 1); i++)
		if ((*i).second == level) {
			*line++ = QLineF(
				((*i).first / samples_per_pixel -
					pixels_offset) + x_offset, y_offset,
				((*(i+1)).first / samples_per_pixel -
					pixels_offset) + x_offset, y_offset);
		}

	p.drawLines(lines, line - lines);
}

shared_ptr<pv::data::AnalogSegment> AnalogSignal::get_analog_segment_to_paint() const
{
	shared_ptr<pv::data::AnalogSegment> segment;

	const deque< shared_ptr<pv::data::AnalogSegment> > &segments =
		base_->analog_data()->analog_segments();

	if (!segments.empty()) {
		if (segment_display_mode_ == ShowLastSegmentOnly)
			segment = segments.back();

		if ((segment_display_mode_ == ShowSingleSegmentOnly) ||
				(segment_display_mode_ == ShowLastCompleteSegmentOnly)) {
			try {
				segment = segments.at(current_segment_);
			} catch (out_of_range&) {
				qDebug() << "Current analog segment out of range for signal" << base_->name() << ":" << current_segment_;
			}
		}
	}

	return segment;
}

shared_ptr<pv::data::LogicSegment> AnalogSignal::get_logic_segment_to_paint() const
{
	shared_ptr<pv::data::LogicSegment> segment;

	const deque< shared_ptr<pv::data::LogicSegment> > &segments =
		base_->logic_data()->logic_segments();

	if (!segments.empty()) {
		if (segment_display_mode_ == ShowLastSegmentOnly)
			segment = segments.back();

		if ((segment_display_mode_ == ShowSingleSegmentOnly) ||
				(segment_display_mode_ == ShowLastCompleteSegmentOnly)) {
			try {
				segment = segments.at(current_segment_);
			} catch (out_of_range&) {
				qDebug() << "Current logic segment out of range for signal" << base_->name() << ":" << current_segment_;
			}
		}
	}

	return segment;
}

float AnalogSignal::get_resolution(int scale_index)
{
	const float seq[] = {1.0f, 2.0f, 5.0f};

	const int offset = numeric_limits<int>::max() / (2 * countof(seq));
	const div_t d = div((int)(scale_index + countof(seq) * offset),
		countof(seq));

	return powf(10.0f, d.quot - offset) * seq[d.rem];
}

void AnalogSignal::update_scale()
{
	resolution_ = get_resolution(scale_index_);
	scale_ = div_height_ / resolution_;
}

void AnalogSignal::update_conversion_widgets()
{
	SignalBase::ConversionType conv_type = base_->get_conversion_type();

	// Enable or disable widgets depending on conversion state
	conv_threshold_cb_->setEnabled(conv_type != SignalBase::NoConversion);
	display_type_cb_->setEnabled(conv_type != SignalBase::NoConversion);

	conv_threshold_cb_->clear();

	vector < pair<QString, int> > presets = base_->get_conversion_presets();

	// Prevent the combo box from firing the "edit text changed" signal
	// as that would involuntarily select the first entry
	conv_threshold_cb_->blockSignals(true);

	// Set available options depending on chosen conversion
	for (pair<QString, int>& preset : presets)
		conv_threshold_cb_->addItem(preset.first, preset.second);

	map < QString, QVariant > options = base_->get_conversion_options();

	if (conv_type == SignalBase::A2LConversionByThreshold) {
		const vector<double> thresholds = base_->get_conversion_thresholds(
				SignalBase::A2LConversionByThreshold, true);
		conv_threshold_cb_->addItem(
				QString("%1V").arg(QString::number(thresholds[0], 'f', 1)), -1);
	}

	if (conv_type == SignalBase::A2LConversionBySchmittTrigger) {
		const vector<double> thresholds = base_->get_conversion_thresholds(
				SignalBase::A2LConversionBySchmittTrigger, true);
		conv_threshold_cb_->addItem(QString("%1V/%2V").arg(
				QString::number(thresholds[0], 'f', 1),
				QString::number(thresholds[1], 'f', 1)), -1);
	}

	int preset_id = base_->get_current_conversion_preset();
	conv_threshold_cb_->setCurrentIndex(
			conv_threshold_cb_->findData(preset_id));

	conv_threshold_cb_->blockSignals(false);
}

vector<data::LogicSegment::EdgePair> AnalogSignal::get_nearest_level_changes(uint64_t sample_pos)
{
	assert(base_);
	assert(owner_);

	// Return if there's no logic data or we're showing only the analog trace
	if (!base_->logic_data() || (display_type_ == DisplayAnalog))
		return vector<data::LogicSegment::EdgePair>();

	if (sample_pos == 0)
		return vector<LogicSegment::EdgePair>();

	shared_ptr<LogicSegment> segment = get_logic_segment_to_paint();
	if (!segment || (segment->get_sample_count() == 0))
		return vector<LogicSegment::EdgePair>();

	const View *view = owner_->view();
	assert(view);
	const double samples_per_pixel = base_->get_samplerate() * view->scale();

	vector<LogicSegment::EdgePair> edges;

	segment->get_surrounding_edges(edges, sample_pos,
		samples_per_pixel / LogicSignal::Oversampling, 0);

	if (edges.empty())
		return vector<LogicSegment::EdgePair>();

	return edges;
}

void AnalogSignal::perform_autoranging(bool keep_divs, bool force_update)
{
	const deque< shared_ptr<pv::data::AnalogSegment> > &segments =
		base_->analog_data()->analog_segments();

	if (segments.empty())
		return;

	double signal_min_ = 0, signal_max_ = 0;
	double min = 0, max = 0;

	for (const shared_ptr<pv::data::AnalogSegment>& segment : segments) {
		pair<double, double> mm = segment->get_min_max();
		min = std::min(min, mm.first);
		max = std::max(max, mm.second);
	}

	if ((min == signal_min_) && (max == signal_max_) && !force_update)
		return;

	signal_min_ = min;
	signal_max_ = max;

	// If we're allowed to alter the div assignment...
	if (!keep_divs) {
		// Use all divs for the positive range if there are no negative values
		if ((min == 0) && (neg_vdivs_ > 0)) {
			pos_vdivs_ += neg_vdivs_;
			neg_vdivs_ = 0;
		}

		// Split up the divs if there are negative values but no negative divs
		if ((min < 0) && (neg_vdivs_ == 0)) {
			neg_vdivs_ = pos_vdivs_ / 2;
			pos_vdivs_ -= neg_vdivs_;
		}
	}

 	// If there is still no positive div when we need it, add one
	// (this can happen when pos_vdivs==neg_vdivs==0)
	if ((max > 0) && (pos_vdivs_ == 0)) {
		pos_vdivs_ = 1;
		owner_->extents_changed(false, true);
	}

	// If there is still no negative div when we need it, add one
	// (this can happen when pos_vdivs was 0 or 1 when trying to split)
	if ((min < 0) && (neg_vdivs_ == 0)) {
		neg_vdivs_ = 1;
		owner_->extents_changed(false, true);
	}

	double min_value_per_div;
	if ((pos_vdivs_ > 0) && (neg_vdivs_ >  0))
		min_value_per_div = std::max(max / pos_vdivs_, -min / neg_vdivs_);
	else if (pos_vdivs_ > 0)
		min_value_per_div = max / pos_vdivs_;
	else
		min_value_per_div = -min / neg_vdivs_;

	// Find first scale value that is bigger than the value we need
	for (int i = MinScaleIndex; i < MaxScaleIndex; i++)
		if (get_resolution(i) > min_value_per_div) {
			scale_index_ = i;
			break;
		}

	update_scale();
}

void AnalogSignal::reset_pixel_values()
{
	value_at_pixel_pos_.clear();
	current_pixel_pos_ = -1;
	prev_value_at_pixel_ = std::numeric_limits<float>::quiet_NaN();
}

void AnalogSignal::process_next_sample_value(float x, float value)
{
	// Note: NAN is used to indicate the non-existance of a value at this pixel

	if (std::isnan(prev_value_at_pixel_)) {
		if (x < 0) {
			min_value_at_pixel_ = value;
			max_value_at_pixel_ = value;
			prev_value_at_pixel_ = value;
			current_pixel_pos_ = x;
		} else
			prev_value_at_pixel_ = std::numeric_limits<float>::quiet_NaN();
	}

	const int pixel_pos = (int)(x + 0.5);

	if (pixel_pos > current_pixel_pos_) {
		if (pixel_pos - current_pixel_pos_ == 1) {
			if (std::isnan(prev_value_at_pixel_)) {
				value_at_pixel_pos_.push_back(prev_value_at_pixel_);
			} else {
				// Average the min/max range to create one value for the previous pixel
				const float avg = (min_value_at_pixel_ + max_value_at_pixel_) / 2;
				value_at_pixel_pos_.push_back(avg);
			}
		} else {
			// Interpolate values to create values for the intermediate pixels
			const float start_value = prev_value_at_pixel_;
			const float end_value = value;
			const int steps = fabs(pixel_pos - current_pixel_pos_);
			const double gradient = (end_value - start_value) / steps;
			for (int i = 0; i < steps; i++) {
				if (current_pixel_pos_ + i < 0)
					continue;
				value_at_pixel_pos_.push_back(start_value + i * gradient);
			}
		}

		min_value_at_pixel_ = value;
		max_value_at_pixel_ = value;
		prev_value_at_pixel_ = value;
		current_pixel_pos_ = pixel_pos;
	} else {
		// Another sample for the same pixel
		if (value < min_value_at_pixel_)
			min_value_at_pixel_ = value;
		if (value > max_value_at_pixel_)
			max_value_at_pixel_ = value;
	}
}

void AnalogSignal::populate_popup_form(QWidget *parent, QFormLayout *form)
{
	// Add the standard options
	Signal::populate_popup_form(parent, form);

	QFormLayout *const layout = new QFormLayout;

	// Add div-related settings
	pvdiv_sb_ = new QSpinBox(parent);
	pvdiv_sb_->setRange(0, MaximumVDivs);
	pvdiv_sb_->setValue(pos_vdivs_);
	connect(pvdiv_sb_, SIGNAL(valueChanged(int)),
		this, SLOT(on_pos_vdivs_changed(int)));
	layout->addRow(tr("Number of pos vertical divs"), pvdiv_sb_);

	nvdiv_sb_ = new QSpinBox(parent);
	nvdiv_sb_->setRange(0, MaximumVDivs);
	nvdiv_sb_->setValue(neg_vdivs_);
	connect(nvdiv_sb_, SIGNAL(valueChanged(int)),
		this, SLOT(on_neg_vdivs_changed(int)));
	layout->addRow(tr("Number of neg vertical divs"), nvdiv_sb_);

	div_height_sb_ = new QSpinBox(parent);
	div_height_sb_->setRange(20, 1000);
	div_height_sb_->setSingleStep(5);
	div_height_sb_->setSuffix(tr(" pixels"));
	div_height_sb_->setValue(div_height_);
	connect(div_height_sb_, SIGNAL(valueChanged(int)),
		this, SLOT(on_div_height_changed(int)));
	layout->addRow(tr("Div height"), div_height_sb_);

	// Add the vertical resolution
	resolution_cb_ = new QComboBox(parent);

	for (int i = MinScaleIndex; i < MaxScaleIndex; i++) {
		const QString label = QString("%1").arg(get_resolution(i));
		resolution_cb_->insertItem(0, label, QVariant(i));
	}

	int cur_idx = resolution_cb_->findData(QVariant(scale_index_));
	resolution_cb_->setCurrentIndex(cur_idx);

	connect(resolution_cb_, SIGNAL(currentIndexChanged(int)),
		this, SLOT(on_resolution_changed(int)));

	QGridLayout *const vdiv_layout = new QGridLayout;
	QLabel *const vdiv_unit = new QLabel(tr("V/div"));
	vdiv_layout->addWidget(resolution_cb_, 0, 0);
	vdiv_layout->addWidget(vdiv_unit, 0, 1);

	layout->addRow(tr("Vertical resolution"), vdiv_layout);

	// Add the autoranging checkbox
	QCheckBox* autoranging_cb = new QCheckBox();
	autoranging_cb->setCheckState(autoranging_ ? Qt::Checked : Qt::Unchecked);

	connect(autoranging_cb, SIGNAL(stateChanged(int)),
		this, SLOT(on_autoranging_changed(int)));

	layout->addRow(tr("Autoranging"), autoranging_cb);

	// Add the conversion type dropdown
	conversion_cb_ = new QComboBox();

	conversion_cb_->addItem(tr("none"),
		SignalBase::NoConversion);
	conversion_cb_->addItem(tr("to logic via threshold"),
		SignalBase::A2LConversionByThreshold);
	conversion_cb_->addItem(tr("to logic via schmitt-trigger"),
		SignalBase::A2LConversionBySchmittTrigger);

	cur_idx = conversion_cb_->findData(QVariant(base_->get_conversion_type()));
	conversion_cb_->setCurrentIndex(cur_idx);

	layout->addRow(tr("Conversion"), conversion_cb_);

	connect(conversion_cb_, SIGNAL(currentIndexChanged(int)),
		this, SLOT(on_conversion_changed(int)));

    // Add the conversion threshold settings
    conv_threshold_cb_ = new QComboBox();
    conv_threshold_cb_->setEditable(true);

    layout->addRow(tr("Conversion threshold(s)"), conv_threshold_cb_);

    connect(conv_threshold_cb_, SIGNAL(currentIndexChanged(int)),
            this, SLOT(on_conv_threshold_changed(int)));
    connect(conv_threshold_cb_, SIGNAL(editTextChanged(const QString&)),
            this, SLOT(on_conv_threshold_changed()));  // index will be -1

	// Add the display type dropdown
	display_type_cb_ = new QComboBox();

	display_type_cb_->addItem(tr("analog"), DisplayAnalog);
	display_type_cb_->addItem(tr("converted"), DisplayConverted);
	display_type_cb_->addItem(tr("analog+converted"), DisplayBoth);

	cur_idx = display_type_cb_->findData(QVariant(display_type_));
	display_type_cb_->setCurrentIndex(cur_idx);

	layout->addRow(tr("Show traces for"), display_type_cb_);

	connect(display_type_cb_, SIGNAL(currentIndexChanged(int)),
		this, SLOT(on_display_type_changed(int)));

	// Update the conversion widget contents and states
	update_conversion_widgets();

	form->addRow(layout);
}

void AnalogSignal::hover_point_changed(const QPoint &hp)
{
	Signal::hover_point_changed(hp);

	// Note: Even though the view area begins at 0, we exclude 0 because
	// that's also the value given when the cursor is over the header to the
	// left of the trace paint area
	if (hp.x() <= 0) {
		value_at_hover_pos_ = std::numeric_limits<float>::quiet_NaN();
	} else {
		if ((size_t)hp.x() < value_at_pixel_pos_.size())
			value_at_hover_pos_ = value_at_pixel_pos_.at(hp.x());
		else
			value_at_hover_pos_ = std::numeric_limits<float>::quiet_NaN();
	}
}

void AnalogSignal::on_setting_changed(const QString &key, const QVariant &value)
{
	Signal::on_setting_changed(key, value);

	if (key == GlobalSettings::Key_View_ShowSamplingPoints)
		show_sampling_points_ = value.toBool();

	if (key == GlobalSettings::Key_View_FillSignalHighAreas)
		fill_high_areas_ = value.toBool();

	if (key == GlobalSettings::Key_View_FillSignalHighAreaColor)
		high_fill_color_ = QColor::fromRgba(value.value<uint32_t>());

	if (key == GlobalSettings::Key_View_ShowAnalogMinorGrid)
		show_analog_minor_grid_ = value.toBool();

	if (key == GlobalSettings::Key_View_ConversionThresholdDispMode) {
		conversion_threshold_disp_mode_ = value.toInt();

		if (owner_)
			owner_->row_item_appearance_changed(false, true);
	}
}

void AnalogSignal::on_min_max_changed(float min, float max)
{
	(void)min;
	(void)max;

	if (autoranging_)
		perform_autoranging(false, false);
}

void AnalogSignal::on_pos_vdivs_changed(int vdivs)
{
	if (vdivs == pos_vdivs_)
		return;

	pos_vdivs_ = vdivs;

	// There has to be at least one div, positive or negative
	if ((neg_vdivs_ == 0) && (pos_vdivs_ == 0)) {
		pos_vdivs_ = 1;
		if (pvdiv_sb_)
			pvdiv_sb_->setValue(pos_vdivs_);
	}

	if (autoranging_) {
		perform_autoranging(true, true);

		// It could be that a positive or negative div was added, so update
		if (pvdiv_sb_) {
			pvdiv_sb_->setValue(pos_vdivs_);
			nvdiv_sb_->setValue(neg_vdivs_);
		}
	}

	if (owner_) {
		// Call order is important, otherwise the lazy event handler won't work
		owner_->extents_changed(false, true);
		owner_->row_item_appearance_changed(false, true);
	}
}

void AnalogSignal::on_neg_vdivs_changed(int vdivs)
{
	if (vdivs == neg_vdivs_)
		return;

	neg_vdivs_ = vdivs;

	// There has to be at least one div, positive or negative
	if ((neg_vdivs_ == 0) && (pos_vdivs_ == 0)) {
		pos_vdivs_ = 1;
		if (pvdiv_sb_)
			pvdiv_sb_->setValue(pos_vdivs_);
	}

	if (autoranging_) {
		perform_autoranging(true, true);

		// It could be that a positive or negative div was added, so update
		if (pvdiv_sb_) {
			pvdiv_sb_->setValue(pos_vdivs_);
			nvdiv_sb_->setValue(neg_vdivs_);
		}
	}

	if (owner_) {
		// Call order is important, otherwise the lazy event handler won't work
		owner_->extents_changed(false, true);
		owner_->row_item_appearance_changed(false, true);
	}
}

void AnalogSignal::on_div_height_changed(int height)
{
	div_height_ = height;
	update_scale();

	if (owner_) {
		// Call order is important, otherwise the lazy event handler won't work
		owner_->extents_changed(false, true);
		owner_->row_item_appearance_changed(false, true);
	}
}

void AnalogSignal::on_resolution_changed(int index)
{
	scale_index_ = resolution_cb_->itemData(index).toInt();
	update_scale();

	if (owner_)
		owner_->row_item_appearance_changed(false, true);
}

void AnalogSignal::on_autoranging_changed(int state)
{
	autoranging_ = (state == Qt::Checked);

	if (autoranging_)
		perform_autoranging(false, true);

	if (owner_) {
		// Call order is important, otherwise the lazy event handler won't work
		owner_->extents_changed(false, true);
		owner_->row_item_appearance_changed(false, true);
	}
}

void AnalogSignal::on_conversion_changed(int index)
{
	SignalBase::ConversionType old_conv_type = base_->get_conversion_type();

	SignalBase::ConversionType conv_type =
		(SignalBase::ConversionType)(conversion_cb_->itemData(index).toInt());

	if (conv_type != old_conv_type) {
		base_->set_conversion_type(conv_type);
		update_conversion_widgets();

		if (owner_)
			owner_->row_item_appearance_changed(false, true);
	}
}

void AnalogSignal::on_conv_threshold_changed(int index)
{
	SignalBase::ConversionType conv_type = base_->get_conversion_type();

	// Note: index is set to -1 if the text in the combo box matches none of
	// the entries in the combo box

	if ((index == -1) && (conv_threshold_cb_->currentText().length() == 0))
		return;

	// The combo box entry with the custom value has user_data set to -1
	const int user_data = conv_threshold_cb_->findText(
			conv_threshold_cb_->currentText());

	const bool use_custom_thr = (index == -1) || (user_data == -1);

	if (conv_type == SignalBase::A2LConversionByThreshold && use_custom_thr) {
		// Not one of the preset values, try to parse the combo box text
		// Note: Regex loosely based on
		// https://txt2re.com/index-c++.php3?s=0.1V&1&-13
		QString re1 = "([+-]?\\d*[\\.,]?\\d*)"; // Float value
		QString re2 = "([a-zA-Z]*)"; // SI unit
		QRegExp regex(re1 + re2);

		const QString text = conv_threshold_cb_->currentText();
		if (!regex.exactMatch(text))
			return;  // String doesn't match the regex

		QStringList tokens = regex.capturedTexts();

		// For now, we simply assume that the unit is volt without modifiers
		const double thr = tokens.at(1).toDouble();

		// Only restart the conversion if the threshold was updated.
		// We're starting a delayed conversion because the user may still be
		// typing and the UI would lag if we kept on restarting it immediately
		if (base_->set_conversion_option("threshold_value", thr))
			base_->start_conversion(true);
	}

	if (conv_type == SignalBase::A2LConversionBySchmittTrigger && use_custom_thr) {
		// Not one of the preset values, try to parse the combo box text
		// Note: Regex loosely based on
		// https://txt2re.com/index-c++.php3?s=0.1V/0.2V&2&14&-22&3&15
		QString re1 = "([+-]?\\d*[\\.,]?\\d*)"; // Float value
		QString re2 = "([a-zA-Z]*)"; // SI unit
		QString re3 = "\\/"; // Forward slash, not captured
		QString re4 = "([+-]?\\d*[\\.,]?\\d*)"; // Float value
		QString re5 = "([a-zA-Z]*)"; // SI unit
		QRegExp regex(re1 + re2 + re3 + re4 + re5);

		const QString text = conv_threshold_cb_->currentText();
		if (!regex.exactMatch(text))
			return;  // String doesn't match the regex

		QStringList tokens = regex.capturedTexts();

		// For now, we simply assume that the unit is volt without modifiers
		const double low_thr = tokens.at(1).toDouble();
		const double high_thr = tokens.at(3).toDouble();

		// Only restart the conversion if one of the options was updated.
		// We're starting a delayed conversion because the user may still be
		// typing and the UI would lag if we kept on restarting it immediately
		bool o1 = base_->set_conversion_option("threshold_value_low", low_thr);
		bool o2 = base_->set_conversion_option("threshold_value_high", high_thr);
		if (o1 || o2)
			base_->start_conversion(true);  // Start delayed conversion
	}

	base_->set_conversion_preset((SignalBase::ConversionPreset)index);

	// Immediately start the conversion if we're not using custom values
	// (i.e. we're using one of the presets)
	if (!use_custom_thr)
		base_->start_conversion();
}

void AnalogSignal::on_delayed_conversion_starter()
{
	base_->start_conversion();
}

void AnalogSignal::on_display_type_changed(int index)
{
	display_type_ = (DisplayType)(display_type_cb_->itemData(index).toInt());

	if (owner_)
		owner_->row_item_appearance_changed(false, true);
}

} // namespace trace
} // namespace views
} // namespace pv