1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
|
require 'spec_helper'
require 'spec_helper'
require 'net/http'
require 'puppet/forge'
require 'puppet/module_tool'
describe Puppet::Forge do
let(:http_response) do
File.read(my_fixture('bacula.json'))
end
let(:search_results) do
JSON.parse(http_response)['results'].map do |hash|
hash.merge(
"author" => "puppetlabs",
"name" => "bacula",
"tag_list" => ["backup", "bacula"],
"full_name" => "puppetlabs/bacula",
"version" => "0.0.2",
"project_url" => "https://github.com/puppetlabs/puppetlabs-bacula",
"desc" => "bacula"
)
end
end
let(:release_response) do
releases = JSON.parse(http_response)
releases['results'] = []
JSON.dump(releases)
end
let(:forge) { Puppet::Forge.new }
it "returns a list of matches from the forge when there are matches for the search term" do
stub_request(:get, "https://forgeapi.puppet.com/v3/modules?query=bacula").to_return(status: 200, body: http_response)
expect(forge.search('bacula')).to eq(search_results)
end
context "when module_groups are defined" do
before :each do
Puppet[:module_groups] = "foo"
end
it "passes module_groups with search" do
stub_request(:get, "https://forgeapi.puppet.com/v3/modules")
.with(query: hash_including("module_groups" => "foo"))
.to_return(status: 200, body: release_response)
forge.search('bacula')
end
it "passes module_groups with fetch" do
stub_request(:get, "https://forgeapi.puppet.com/v3/releases")
.with(query: hash_including("module_groups" => "foo"))
.to_return(status: 200, body: release_response)
forge.fetch('puppetlabs-bacula')
end
end
# See PUP-8008
context "when multiple module_groups are defined" do
context "with space seperator" do
before :each do
Puppet[:module_groups] = "foo bar"
end
it "passes module_groups with search" do
stub_request(:get, %r{forgeapi.puppet.com/v3/modules}).with do |req|
expect(req.uri.query).to match(/module_groups=foo%20bar/)
end.to_return(status: 200, body: release_response)
forge.search('bacula')
end
it "passes module_groups with fetch" do
stub_request(:get, %r{forgeapi.puppet.com/v3/releases}).with do |req|
expect(req.uri.query).to match(/module_groups=foo%20bar/)
end.to_return(status: 200, body: release_response)
forge.fetch('puppetlabs-bacula')
end
end
context "with plus seperator" do
before :each do
Puppet[:module_groups] = "foo+bar"
end
it "passes module_groups with search" do
stub_request(:get, %r{forgeapi.puppet.com/v3/modules}).with do |req|
expect(req.uri.query).to match(/module_groups=foo%20bar/)
end.to_return(status: 200, body: release_response)
forge.search('bacula')
end
it "passes module_groups with fetch" do
stub_request(:get, %r{forgeapi.puppet.com/v3/releases}).with do |req|
expect(req.uri.query).to match(/module_groups=foo%20bar/)
end.to_return(status: 200, body: release_response)
forge.fetch('puppetlabs-bacula')
end
end
# See PUP-8008
context "when there are multiple pages of results" do
before(:each) do
stub_request(:get, %r{forgeapi.puppet.com}).with do |req|
expect(req.uri.query).to match(/module_groups=foo%20bar/)
end.to_return(status: 200, body: first_page)
.to_return(status: 200, body: last_page)
end
context "with space seperator" do
before(:each) do
Puppet[:module_groups] = "foo bar"
end
let(:first_page) do
resp = JSON.parse(http_response)
resp['results'] = []
resp['pagination']['next'] = "/v3/modules?limit=1&offset=1&module_groups=foo%20bar"
JSON.dump(resp)
end
let(:last_page) do
resp = JSON.parse(http_response)
resp['results'] = []
resp['pagination']['current'] = "/v3/modules?limit=1&offset=1&module_groups=foo%20bar"
JSON.dump(resp)
end
it "traverses pages during search" do
forge.search('bacula')
end
it "traverses pages during fetch" do
forge.fetch('puppetlabs-bacula')
end
end
context "with plus seperator" do
before(:each) do
Puppet[:module_groups] = "foo+bar"
end
let(:first_page) do
resp = JSON.parse(http_response)
resp['results'] = []
resp['pagination']['next'] = "/v3/modules?limit=1&offset=1&module_groups=foo+bar"
JSON.dump(resp)
end
let(:last_page) do
resp = JSON.parse(http_response)
resp['results'] = []
resp['pagination']['current'] = "/v3/modules?limit=1&offset=1&module_groups=foo+bar"
JSON.dump(resp)
end
it "traverses pages during search" do
forge.search('bacula')
end
it "traverses pages during fetch" do
forge.fetch('puppetlabs-bacula')
end
end
end
end
context "when the connection to the forge fails" do
before :each do
stub_request(:get, /forgeapi.puppet.com/).to_return(status: [404, 'not found'])
end
it "raises an error for search" do
expect { forge.search('bacula') }.to raise_error Puppet::Forge::Errors::ResponseError, "Request to Puppet Forge failed. Detail: 404 not found."
end
it "raises an error for fetch" do
expect { forge.fetch('puppetlabs/bacula') }.to raise_error Puppet::Forge::Errors::ResponseError, "Request to Puppet Forge failed. Detail: 404 not found."
end
end
context "when the API responds with an error" do
it "raises an error for fetch" do
stub_request(:get, /forgeapi.puppet.com/).to_return(status: [410, 'Gone'], body: '{"error":"invalid module"}')
expect { forge.fetch('puppetlabs/bacula') }.to raise_error Puppet::Forge::Errors::ResponseError, "Request to Puppet Forge failed. Detail: 410 Gone."
end
end
context "when the forge returns a module with unparseable dependencies" do
it "ignores modules with unparseable dependencies" do
response = JSON.parse(http_response)
release = response['results'][0]['current_release']
release['metadata']['dependencies'] = [{'name' => 'broken-garbage >= 1.0.0', 'version_requirement' => 'banana'}]
response['results'] = [release]
stub_request(:get, /forgeapi.puppet.com/).to_return(status: 200, body: JSON.dump(response))
expect(forge.fetch('puppetlabs/bacula')).to be_empty
end
end
end
|
