1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547
|
#!/usr/bin/env ruby
require File.dirname(__FILE__) + '/../spec_helper'
describe Puppet::Module do
before do
# This is necessary because of the extra checks we have for the deprecated
# 'plugins' directory
FileTest.stubs(:exist?).returns false
end
it "should have a class method that returns a named module from a given environment" do
env = mock 'module'
env.expects(:module).with("mymod").returns "yep"
Puppet::Node::Environment.expects(:new).with("myenv").returns env
Puppet::Module.find("mymod", "myenv").should == "yep"
end
it "should return nil if asked for a named module that doesn't exist" do
env = mock 'module'
env.expects(:module).with("mymod").returns nil
Puppet::Node::Environment.expects(:new).with("myenv").returns env
Puppet::Module.find("mymod", "myenv").should be_nil
end
it "should support a 'version' attribute" do
mod = Puppet::Module.new("mymod")
mod.version = 1.09
mod.version.should == 1.09
end
it "should support a 'source' attribute" do
mod = Puppet::Module.new("mymod")
mod.source = "http://foo/bar"
mod.source.should == "http://foo/bar"
end
it "should support a 'project_page' attribute" do
mod = Puppet::Module.new("mymod")
mod.project_page = "http://foo/bar"
mod.project_page.should == "http://foo/bar"
end
it "should support an 'author' attribute" do
mod = Puppet::Module.new("mymod")
mod.author = "Luke Kanies <luke@madstop.com>"
mod.author.should == "Luke Kanies <luke@madstop.com>"
end
it "should support a 'license' attribute" do
mod = Puppet::Module.new("mymod")
mod.license = "GPL2"
mod.license.should == "GPL2"
end
it "should support a 'summary' attribute" do
mod = Puppet::Module.new("mymod")
mod.summary = "GPL2"
mod.summary.should == "GPL2"
end
it "should support a 'description' attribute" do
mod = Puppet::Module.new("mymod")
mod.description = "GPL2"
mod.description.should == "GPL2"
end
it "should support specifying a compatible puppet version" do
mod = Puppet::Module.new("mymod")
mod.puppetversion = "0.25"
mod.puppetversion.should == "0.25"
end
it "should validate that the puppet version is compatible" do
mod = Puppet::Module.new("mymod")
mod.puppetversion = "0.25"
Puppet.expects(:version).returns "0.25"
mod.validate_puppet_version
end
it "should fail if the specified puppet version is not compatible" do
mod = Puppet::Module.new("mymod")
mod.puppetversion = "0.25"
Puppet.stubs(:version).returns "0.24"
lambda { mod.validate_puppet_version }.should raise_error(Puppet::Module::IncompatibleModule)
end
describe "when specifying required modules" do
it "should support specifying a required module" do
mod = Puppet::Module.new("mymod")
mod.requires "foobar"
end
it "should support specifying multiple required modules" do
mod = Puppet::Module.new("mymod")
mod.requires "foobar"
mod.requires "baz"
end
it "should support specifying a required module and version" do
mod = Puppet::Module.new("mymod")
mod.requires "foobar", 1.0
end
it "should fail when required modules are missing" do
mod = Puppet::Module.new("mymod")
mod.requires "foobar"
mod.environment.expects(:module).with("foobar").returns nil
lambda { mod.validate_dependencies }.should raise_error(Puppet::Module::MissingModule)
end
it "should fail when required modules are present but of the wrong version" do
mod = Puppet::Module.new("mymod")
mod.requires "foobar", 1.0
foobar = Puppet::Module.new("foobar")
foobar.version = 2.0
mod.environment.expects(:module).with("foobar").returns foobar
lambda { mod.validate_dependencies }.should raise_error(Puppet::Module::IncompatibleModule)
end
it "should have valid dependencies when no dependencies have been specified" do
mod = Puppet::Module.new("mymod")
lambda { mod.validate_dependencies }.should_not raise_error
end
it "should fail when some dependencies are present but others aren't" do
mod = Puppet::Module.new("mymod")
mod.requires "foobar"
mod.requires "baz"
mod.environment.expects(:module).with("foobar").returns Puppet::Module.new("foobar")
mod.environment.expects(:module).with("baz").returns nil
lambda { mod.validate_dependencies }.should raise_error(Puppet::Module::MissingModule)
end
it "should have valid dependencies when all dependencies are met" do
mod = Puppet::Module.new("mymod")
mod.requires "foobar", 1.0
mod.requires "baz"
foobar = Puppet::Module.new("foobar")
foobar.version = 1.0
baz = Puppet::Module.new("baz")
mod.environment.expects(:module).with("foobar").returns foobar
mod.environment.expects(:module).with("baz").returns baz
lambda { mod.validate_dependencies }.should_not raise_error
end
it "should validate its dependendencies on initialization" do
Puppet::Module.any_instance.expects(:validate_dependencies)
Puppet::Module.new("mymod")
end
end
describe "when managing supported platforms" do
it "should support specifying a supported platform" do
mod = Puppet::Module.new("mymod")
mod.supports "solaris"
end
it "should support specifying a supported platform and version" do
mod = Puppet::Module.new("mymod")
mod.supports "solaris", 1.0
end
it "should fail when not running on a supported platform" do
pending "Not sure how to send client platform to the module"
mod = Puppet::Module.new("mymod")
Facter.expects(:value).with("operatingsystem").returns "Solaris"
mod.supports "hpux"
lambda { mod.validate_supported_platform }.should raise_error(Puppet::Module::UnsupportedPlatform)
end
it "should fail when supported platforms are present but of the wrong version" do
pending "Not sure how to send client platform to the module"
mod = Puppet::Module.new("mymod")
Facter.expects(:value).with("operatingsystem").returns "Solaris"
Facter.expects(:value).with("operatingsystemrelease").returns 2.0
mod.supports "Solaris", 1.0
lambda { mod.validate_supported_platform }.should raise_error(Puppet::Module::IncompatiblePlatform)
end
it "should be considered supported when no supported platforms have been specified" do
pending "Not sure how to send client platform to the module"
mod = Puppet::Module.new("mymod")
lambda { mod.validate_supported_platform }.should_not raise_error
end
it "should be considered supported when running on a supported platform" do
pending "Not sure how to send client platform to the module"
mod = Puppet::Module.new("mymod")
Facter.expects(:value).with("operatingsystem").returns "Solaris"
Facter.expects(:value).with("operatingsystemrelease").returns 2.0
mod.supports "Solaris", 1.0
lambda { mod.validate_supported_platform }.should raise_error(Puppet::Module::IncompatiblePlatform)
end
it "should be considered supported when running on any of multiple supported platforms" do
pending "Not sure how to send client platform to the module"
end
it "should validate its platform support on initialization" do
pending "Not sure how to send client platform to the module"
end
end
it "should return nil if asked for a module whose name is 'nil'" do
Puppet::Module.find(nil, "myenv").should be_nil
end
it "should provide support for logging" do
Puppet::Module.ancestors.should be_include(Puppet::Util::Logging)
end
it "should be able to be converted to a string" do
Puppet::Module.new("foo").to_s.should == "Module foo"
end
it "should add the path to its string form if the module is found" do
mod = Puppet::Module.new("foo")
mod.stubs(:path).returns "/a"
mod.to_s.should == "Module foo(/a)"
end
it "should fail if its name is not alphanumeric" do
lambda { Puppet::Module.new(".something") }.should raise_error(Puppet::Module::InvalidName)
end
it "should require a name at initialization" do
lambda { Puppet::Module.new }.should raise_error(ArgumentError)
end
it "should convert an environment name into an Environment instance" do
Puppet::Module.new("foo", "prod").environment.should be_instance_of(Puppet::Node::Environment)
end
it "should accept an environment at initialization" do
Puppet::Module.new("foo", :prod).environment.name.should == :prod
end
it "should use the default environment if none is provided" do
env = Puppet::Node::Environment.new
Puppet::Module.new("foo").environment.should equal(env)
end
it "should use any provided Environment instance" do
env = Puppet::Node::Environment.new
Puppet::Module.new("foo", env).environment.should equal(env)
end
it "should return the path to the first found instance in its environment's module paths as its path" do
mod = Puppet::Module.new("foo")
env = mock 'environment'
mod.stubs(:environment).returns env
env.expects(:modulepath).returns %w{/a /b /c}
FileTest.expects(:exist?).with("/a/foo").returns false
FileTest.expects(:exist?).with("/b/foo").returns true
FileTest.expects(:exist?).with("/c/foo").never
mod.path.should == "/b/foo"
end
it "should be considered existent if it exists in at least one module path" do
mod = Puppet::Module.new("foo")
mod.expects(:path).returns "/a/foo"
mod.should be_exist
end
it "should be considered nonexistent if it does not exist in any of the module paths" do
mod = Puppet::Module.new("foo")
mod.expects(:path).returns nil
mod.should_not be_exist
end
[:plugins, :templates, :files, :manifests].each do |filetype|
dirname = filetype == :plugins ? "lib" : filetype.to_s
it "should be able to return individual #{filetype}" do
mod = Puppet::Module.new("foo")
mod.stubs(:path).returns "/a/foo"
path = File.join("/a/foo", dirname, "my/file")
FileTest.expects(:exist?).with(path).returns true
mod.send(filetype.to_s.sub(/s$/, ''), "my/file").should == path
end
it "should consider #{filetype} to be present if their base directory exists" do
mod = Puppet::Module.new("foo")
mod.stubs(:path).returns "/a/foo"
path = File.join("/a/foo", dirname)
FileTest.expects(:exist?).with(path).returns true
mod.send(filetype.to_s + "?").should be_true
end
it "should consider #{filetype} to be absent if their base directory does not exist" do
mod = Puppet::Module.new("foo")
mod.stubs(:path).returns "/a/foo"
path = File.join("/a/foo", dirname)
FileTest.expects(:exist?).with(path).returns false
mod.send(filetype.to_s + "?").should be_false
end
it "should consider #{filetype} to be absent if the module base directory does not exist" do
mod = Puppet::Module.new("foo")
mod.stubs(:path).returns nil
mod.send(filetype.to_s + "?").should be_false
end
it "should return nil if asked to return individual #{filetype} that don't exist" do
mod = Puppet::Module.new("foo")
mod.stubs(:path).returns "/a/foo"
path = File.join("/a/foo", dirname, "my/file")
FileTest.expects(:exist?).with(path).returns false
mod.send(filetype.to_s.sub(/s$/, ''), "my/file").should be_nil
end
it "should return nil when asked for individual #{filetype} if the module does not exist" do
mod = Puppet::Module.new("foo")
mod.stubs(:path).returns nil
mod.send(filetype.to_s.sub(/s$/, ''), "my/file").should be_nil
end
it "should return the base directory if asked for a nil path" do
mod = Puppet::Module.new("foo")
mod.stubs(:path).returns "/a/foo"
base = File.join("/a/foo", dirname)
FileTest.expects(:exist?).with(base).returns true
mod.send(filetype.to_s.sub(/s$/, ''), nil).should == base
end
end
%w{plugins files}.each do |filetype|
short = filetype.sub(/s$/, '')
dirname = filetype == "plugins" ? "lib" : filetype.to_s
it "should be able to return the #{short} directory" do
Puppet::Module.new("foo").should respond_to(short + "_directory")
end
it "should return the path to the #{short} directory" do
mod = Puppet::Module.new("foo")
mod.stubs(:path).returns "/a/foo"
mod.send(short + "_directory").should == "/a/foo/#{dirname}"
end
end
it "should throw a warning if plugins are in a 'plugins' directory rather than a 'lib' directory" do
mod = Puppet::Module.new("foo")
mod.stubs(:path).returns "/a/foo"
FileTest.expects(:exist?).with("/a/foo/plugins").returns true
mod.expects(:warning)
mod.plugin_directory.should == "/a/foo/plugins"
end
it "should default to 'lib' for the plugins directory" do
mod = Puppet::Module.new("foo")
mod.stubs(:path).returns "/a/foo"
mod.plugin_directory.should == "/a/foo/lib"
end
end
describe Puppet::Module, " when building its search path" do
it "should use the current environment's search path if no environment is specified" do
env = mock 'env'
env.expects(:modulepath).returns "eh"
Puppet::Node::Environment.expects(:new).with(nil).returns env
Puppet::Module.modulepath.should == "eh"
end
it "should use the specified environment's search path if an environment is specified" do
env = mock 'env'
env.expects(:modulepath).returns "eh"
Puppet::Node::Environment.expects(:new).with("foo").returns env
Puppet::Module.modulepath("foo").should == "eh"
end
end
describe Puppet::Module, "when finding matching manifests" do
before do
@mod = Puppet::Module.new("mymod")
@mod.stubs(:path).returns "/a"
@pq_glob_with_extension = "yay/*.xx"
@fq_glob_with_extension = "/a/manifests/#{@pq_glob_with_extension}"
end
it "should return all manifests matching the glob pattern" do
Dir.expects(:glob).with(@fq_glob_with_extension).returns(%w{foo bar})
FileTest.stubs(:directory?).returns false
@mod.match_manifests(@pq_glob_with_extension).should == %w{foo bar}
end
it "should not return directories" do
Dir.expects(:glob).with(@fq_glob_with_extension).returns(%w{foo bar})
FileTest.expects(:directory?).with("foo").returns false
FileTest.expects(:directory?).with("bar").returns true
@mod.match_manifests(@pq_glob_with_extension).should == %w{foo}
end
it "should default to the 'init' file if no glob pattern is specified" do
Dir.expects(:glob).with("/a/manifests/init.{pp,rb}").returns(%w{/a/manifests/init.pp})
@mod.match_manifests(nil).should == %w{/a/manifests/init.pp}
end
it "should return all manifests matching the glob pattern in all existing paths" do
Dir.expects(:glob).with(@fq_glob_with_extension).returns(%w{a b})
@mod.match_manifests(@pq_glob_with_extension).should == %w{a b}
end
it "should match the glob pattern plus '.{pp,rb}' if no extention is specified" do
Dir.expects(:glob).with("/a/manifests/yay/foo.{pp,rb}").returns(%w{yay})
@mod.match_manifests("yay/foo").should == %w{yay}
end
it "should return an empty array if no manifests matched" do
Dir.expects(:glob).with(@fq_glob_with_extension).returns([])
@mod.match_manifests(@pq_glob_with_extension).should == []
end
end
describe Puppet::Module do
before do
Puppet::Module.any_instance.stubs(:path).returns "/my/mod/path"
@module = Puppet::Module.new("foo")
end
it "should use 'License' in its current path as its metadata file" do
@module.license_file.should == "/my/mod/path/License"
end
it "should return nil as its license file when the module has no path" do
Puppet::Module.any_instance.stubs(:path).returns nil
Puppet::Module.new("foo").license_file.should be_nil
end
it "should cache the license file" do
Puppet::Module.any_instance.expects(:path).once.returns nil
mod = Puppet::Module.new("foo")
mod.license_file.should == mod.license_file
end
it "should use 'metadata.json' in its current path as its metadata file" do
@module.metadata_file.should == "/my/mod/path/metadata.json"
end
it "should return nil as its metadata file when the module has no path" do
Puppet::Module.any_instance.stubs(:path).returns nil
Puppet::Module.new("foo").metadata_file.should be_nil
end
it "should cache the metadata file" do
Puppet::Module.any_instance.expects(:path).once.returns nil
mod = Puppet::Module.new("foo")
mod.metadata_file.should == mod.metadata_file
end
it "should know if it has a metadata file" do
FileTest.expects(:exist?).with(@module.metadata_file).returns true
@module.should be_has_metadata
end
it "should know if it is missing a metadata file" do
FileTest.expects(:exist?).with(@module.metadata_file).returns false
@module.should_not be_has_metadata
end
it "should be able to parse its metadata file" do
@module.should respond_to(:load_metadata)
end
it "should parse its metadata file on initialization if it is present" do
Puppet::Module.any_instance.expects(:has_metadata?).returns true
Puppet::Module.any_instance.expects(:load_metadata)
Puppet::Module.new("yay")
end
describe "when loading the medatada file" do
confine "Cannot test module metadata without json" => Puppet.features.json?
before do
@data = {
:license => "GPL2",
:author => "luke",
:version => "1.0",
:source => "http://foo/",
:puppetversion => "0.25"
}
@text = @data.to_json
@module = Puppet::Module.new("foo")
@module.stubs(:metadata_file).returns "/my/file"
File.stubs(:read).with("/my/file").returns @text
end
%w{source author version license}.each do |attr|
it "should set #{attr} if present in the metadata file" do
@module.load_metadata
@module.send(attr).should == @data[attr.to_sym]
end
it "should fail if #{attr} is not present in the metadata file" do
@data.delete(attr.to_sym)
@text = @data.to_json
File.stubs(:read).with("/my/file").returns @text
lambda { @module.load_metadata }.should raise_error(Puppet::Module::MissingMetadata)
end
end
it "should set puppetversion if present in the metadata file" do
@module.load_metadata
@module.puppetversion.should == @data[:puppetversion]
end
it "should fail if the discovered name is different than the metadata name"
end
end
|