1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728
|
require 'spec_helper'
require 'puppet_spec/compiler'
describe "Two step scoping for variables" do
include PuppetSpec::Compiler
def expect_the_message_to_be(message, node = Puppet::Node.new('the node'))
catalog = compile_to_catalog(yield, node)
expect(catalog.resource('Notify', 'something')[:message]).to eq(message)
end
def expect_the_message_not_to_be(message, node = Puppet::Node.new('the node'))
catalog = compile_to_catalog(yield, node)
expect(catalog.resource('Notify', 'something')[:message]).to_not eq(message)
end
before :each do
expect(Puppet).not_to receive(:deprecation_warning)
end
describe "using unsupported operators" do
it "issues an error for +=" do
expect do
compile_to_catalog(<<-MANIFEST)
$var = ["top_msg"]
node default {
$var += ["override"]
}
MANIFEST
end.to raise_error(/The operator '\+=' is no longer supported/)
end
it "issues an error for -=" do
expect do
compile_to_catalog(<<-MANIFEST)
$var = ["top_msg"]
node default {
$var -= ["top_msg"]
}
MANIFEST
end.to raise_error(/The operator '-=' is no longer supported/)
end
it "issues error about built-in variable when reassigning to name" do
enc_node = Puppet::Node.new("the_node", { :parameters => { } })
expect {
compile_to_catalog("$name = 'never in a 0xF4240 years'", enc_node)
}.to raise_error(
Puppet::Error,
/Cannot reassign built in \(or already assigned\) variable '\$name' \(line: 1(, column: 7)?\) on node the_node/
)
end
it "issues error about built-in variable when reassigning to title" do
enc_node = Puppet::Node.new("the_node", { :parameters => { } })
expect {
compile_to_catalog("$title = 'never in a 0xF4240 years'", enc_node)
}.to raise_error(
Puppet::Error,
/Cannot reassign built in \(or already assigned\) variable '\$title' \(line: 1(, column: 8)?\) on node the_node/
)
end
it "when using a template ignores the dynamic value of the var when using the @varname syntax" do
expect_the_message_to_be('node_msg') do <<-MANIFEST
node default {
$var = "node_msg"
include foo
}
class foo {
$var = "foo_msg"
include bar
}
class bar {
notify { 'something': message => inline_template("<%= @var %>"), }
}
MANIFEST
end
end
it "when using a template gets the var from an inherited class when using the @varname syntax" do
expect_the_message_to_be('Barbamama') do <<-MANIFEST
node default {
$var = "node_msg"
include bar_bamama
include foo
}
class bar_bamama {
$var = "Barbamama"
}
class foo {
$var = "foo_msg"
include bar
}
class bar inherits bar_bamama {
notify { 'something': message => inline_template("<%= @var %>"), }
}
MANIFEST
end
end
it "when using a template ignores the dynamic var when it is not present in an inherited class" do
expect_the_message_to_be('node_msg') do <<-MANIFEST
node default {
$var = "node_msg"
include bar_bamama
include foo
}
class bar_bamama {
}
class foo {
$var = "foo_msg"
include bar
}
class bar inherits bar_bamama {
notify { 'something': message => inline_template("<%= @var %>"), }
}
MANIFEST
end
end
describe 'handles 3.x/4.x functions' do
it 'can call a 3.x function via call_function' do
expect_the_message_to_be('yes') do <<-MANIFEST
$msg = inline_template('<%= scope().call_function("fqdn_rand", [30]).to_i <= 30 ? "yes" : "no" %>')
notify { 'something': message => $msg }
MANIFEST
end
end
it 'it can call a 4.x function via call_function' do
expect_the_message_to_be('yes') do <<-MANIFEST
$msg = inline_template('<%= scope().call_function("with", ["yes"]) { |x| x } %>')
notify { 'something': message => $msg }
MANIFEST
end
end
end
end
describe "fully qualified variable names" do
it "keeps nodescope separate from topscope" do
expect_the_message_to_be('topscope') do <<-MANIFEST
$c = "topscope"
node default {
$c = "nodescope"
notify { 'something': message => $::c }
}
MANIFEST
end
end
end
describe "when colliding class and variable names" do
it "finds a topscope variable with the same name as a class" do
expect_the_message_to_be('topscope') do <<-MANIFEST
$c = "topscope"
class c { }
node default {
include c
notify { 'something': message => $c }
}
MANIFEST
end
end
it "finds a node scope variable with the same name as a class" do
expect_the_message_to_be('nodescope') do <<-MANIFEST
class c { }
node default {
$c = "nodescope"
include c
notify { 'something': message => $c }
}
MANIFEST
end
end
it "finds a class variable when the class collides with a nodescope variable" do
expect_the_message_to_be('class') do <<-MANIFEST
class c { $b = "class" }
node default {
$c = "nodescope"
include c
notify { 'something': message => $c::b }
}
MANIFEST
end
end
it "finds a class variable when the class collides with a topscope variable" do
expect_the_message_to_be('class') do <<-MANIFEST
$c = "topscope"
class c { $b = "class" }
node default {
include c
notify { 'something': message => $::c::b }
}
MANIFEST
end
end
end
describe "when using shadowing and inheritance" do
it "finds values in its local scope" do
expect_the_message_to_be('local_msg') do <<-MANIFEST
node default {
include baz
}
class foo {
}
class bar inherits foo {
$var = "local_msg"
notify { 'something': message => $var, }
}
class baz {
include bar
}
MANIFEST
end
end
it "finds values in its inherited scope" do
expect_the_message_to_be('foo_msg') do <<-MANIFEST
node default {
include baz
}
class foo {
$var = "foo_msg"
}
class bar inherits foo {
notify { 'something': message => $var, }
}
class baz {
include bar
}
MANIFEST
end
end
it "prefers values in its local scope over values in the inherited scope" do
expect_the_message_to_be('local_msg') do <<-MANIFEST
include bar
class foo {
$var = "inherited"
}
class bar inherits foo {
$var = "local_msg"
notify { 'something': message => $var, }
}
MANIFEST
end
end
it "finds a qualified variable by following inherited scope of the specified scope" do
expect_the_message_to_be("from parent") do <<-MANIFEST
class c {
notify { 'something': message => "$a::b" }
}
class parent {
$b = 'from parent'
}
class a inherits parent { }
node default {
$b = "from node"
include a
include c
}
MANIFEST
end
end
['a:.b', '::a::b'].each do |ref|
it "does not resolve a qualified name on the form #{ref} against top scope" do
expect_the_message_not_to_be("from topscope") do <<-"MANIFEST"
class c {
notify { 'something': message => "$#{ref}" }
}
class parent {
$not_b = 'from parent'
}
class a inherits parent { }
$b = "from topscope"
node default {
include a
include c
}
MANIFEST
end
end
end
['a:.b', '::a::b'].each do |ref|
it "does not resolve a qualified name on the form #{ref} against node scope" do
expect_the_message_not_to_be("from node") do <<-MANIFEST
class c {
notify { 'something': message => "$a::b" }
}
class parent {
$not_b = 'from parent'
}
class a inherits parent { }
node default {
$b = "from node"
include a
include c
}
MANIFEST
end
end
end
it 'resolves a qualified name in class parameter scope' do
expect_the_message_to_be('Does it work? Yes!') do <<-PUPPET
class a (
$var1 = 'Does it work?',
$var2 = "${a::var1} Yes!"
) {
notify { 'something': message => $var2 }
}
include a
PUPPET
end
end
it "finds values in its inherited scope when the inherited class is qualified to the top" do
expect_the_message_to_be('foo_msg') do <<-MANIFEST
node default {
include baz
}
class foo {
$var = "foo_msg"
}
class bar inherits ::foo {
notify { 'something': message => $var, }
}
class baz {
include bar
}
MANIFEST
end
end
it "prefers values in its local scope over values in the inherited scope when the inherited class is fully qualified" do
expect_the_message_to_be('local_msg') do <<-MANIFEST
include bar
class foo {
$var = "inherited"
}
class bar inherits ::foo {
$var = "local_msg"
notify { 'something': message => $var, }
}
MANIFEST
end
end
it "finds values in top scope when the inherited class is qualified to the top" do
expect_the_message_to_be('top msg') do <<-MANIFEST
$var = "top msg"
class foo {
}
class bar inherits ::foo {
notify { 'something': message => $var, }
}
include bar
MANIFEST
end
end
it "finds values in its inherited scope when the inherited class is a nested class that shadows another class at the top" do
expect_the_message_to_be('inner baz') do <<-MANIFEST
node default {
include foo::bar
}
class baz {
$var = "top baz"
}
class foo {
class baz {
$var = "inner baz"
}
class bar inherits foo::baz {
notify { 'something': message => $var, }
}
}
MANIFEST
end
end
it "finds values in its inherited scope when the inherited class is qualified to a nested class and qualified to the top" do
expect_the_message_to_be('top baz') do <<-MANIFEST
node default {
include foo::bar
}
class baz {
$var = "top baz"
}
class foo {
class baz {
$var = "inner baz"
}
class bar inherits ::baz {
notify { 'something': message => $var, }
}
}
MANIFEST
end
end
it "finds values in its inherited scope when the inherited class is qualified" do
expect_the_message_to_be('foo_msg') do <<-MANIFEST
node default {
include bar
}
class foo {
class baz {
$var = "foo_msg"
}
}
class bar inherits foo::baz {
notify { 'something': message => $var, }
}
MANIFEST
end
end
it "prefers values in its inherited scope over those in the node (with intermediate inclusion)" do
expect_the_message_to_be('foo_msg') do <<-MANIFEST
node default {
$var = "node_msg"
include baz
}
class foo {
$var = "foo_msg"
}
class bar inherits foo {
notify { 'something': message => $var, }
}
class baz {
include bar
}
MANIFEST
end
end
it "prefers values in its inherited scope over those in the node (without intermediate inclusion)" do
expect_the_message_to_be('foo_msg') do <<-MANIFEST
node default {
$var = "node_msg"
include bar
}
class foo {
$var = "foo_msg"
}
class bar inherits foo {
notify { 'something': message => $var, }
}
MANIFEST
end
end
it "prefers values in its inherited scope over those from where it is included" do
expect_the_message_to_be('foo_msg') do <<-MANIFEST
node default {
include baz
}
class foo {
$var = "foo_msg"
}
class bar inherits foo {
notify { 'something': message => $var, }
}
class baz {
$var = "baz_msg"
include bar
}
MANIFEST
end
end
it "does not used variables from classes included in the inherited scope" do
expect_the_message_to_be('node_msg') do <<-MANIFEST
node default {
$var = "node_msg"
include bar
}
class quux {
$var = "quux_msg"
}
class foo inherits quux {
}
class baz {
include foo
}
class bar inherits baz {
notify { 'something': message => $var, }
}
MANIFEST
end
end
it "does not use a variable from a scope lexically enclosing it" do
expect_the_message_to_be('node_msg') do <<-MANIFEST
node default {
$var = "node_msg"
include other::bar
}
class other {
$var = "other_msg"
class bar {
notify { 'something': message => $var, }
}
}
MANIFEST
end
end
it "finds values in its node scope" do
expect_the_message_to_be('node_msg') do <<-MANIFEST
node default {
$var = "node_msg"
include baz
}
class foo {
}
class bar inherits foo {
notify { 'something': message => $var, }
}
class baz {
include bar
}
MANIFEST
end
end
it "finds values in its top scope" do
expect_the_message_to_be('top_msg') do <<-MANIFEST
$var = "top_msg"
node default {
include baz
}
class foo {
}
class bar inherits foo {
notify { 'something': message => $var, }
}
class baz {
include bar
}
MANIFEST
end
end
it "prefers variables from the node over those in the top scope" do
expect_the_message_to_be('node_msg') do <<-MANIFEST
$var = "top_msg"
node default {
$var = "node_msg"
include foo
}
class foo {
notify { 'something': message => $var, }
}
MANIFEST
end
end
it "finds top scope variables referenced inside a defined type" do
expect_the_message_to_be('top_msg') do <<-MANIFEST
$var = "top_msg"
node default {
foo { "testing": }
}
define foo() {
notify { 'something': message => $var, }
}
MANIFEST
end
end
it "finds node scope variables referenced inside a defined type" do
expect_the_message_to_be('node_msg') do <<-MANIFEST
$var = "top_msg"
node default {
$var = "node_msg"
foo { "testing": }
}
define foo() {
notify { 'something': message => $var, }
}
MANIFEST
end
end
end
describe "in situations that used to have dynamic lookup" do
it "ignores the dynamic value of the var" do
expect_the_message_to_be('node_msg') do <<-MANIFEST
node default {
$var = "node_msg"
include foo
}
class baz {
$var = "baz_msg"
include bar
}
class foo inherits baz {
}
class bar {
notify { 'something': message => $var, }
}
MANIFEST
end
end
it "finds nil when the only set variable is in the dynamic scope" do
expect_the_message_to_be(nil) do <<-MANIFEST
node default {
include baz
}
class foo {
}
class bar inherits foo {
notify { 'something': message => $var, }
}
class baz {
$var = "baz_msg"
include bar
}
MANIFEST
end
end
it "ignores the value in the dynamic scope for a defined type" do
expect_the_message_to_be('node_msg') do <<-MANIFEST
node default {
$var = "node_msg"
include foo
}
class foo {
$var = "foo_msg"
bar { "testing": }
}
define bar() {
notify { 'something': message => $var, }
}
MANIFEST
end
end
it "when using a template ignores the dynamic value of the var when using scope.lookupvar" do
expect_the_message_to_be('node_msg') do <<-MANIFEST
node default {
$var = "node_msg"
include foo
}
class foo {
$var = "foo_msg"
include bar
}
class bar {
notify { 'something': message => inline_template("<%= scope.lookupvar('var') %>"), }
}
MANIFEST
end
end
end
describe "when using an enc" do
it "places enc parameters in top scope" do
enc_node = Puppet::Node.new("the node", { :parameters => { "var" => 'from_enc' } })
expect_the_message_to_be('from_enc', enc_node) do <<-MANIFEST
notify { 'something': message => $var, }
MANIFEST
end
end
it "does not allow the enc to specify an existing top scope var" do
enc_node = Puppet::Node.new("the_node", { :parameters => { "var" => 'from_enc' } })
expect {
compile_to_catalog("$var = 'top scope'", enc_node)
}.to raise_error(
Puppet::Error,
/Cannot reassign variable '\$var' \(line: 1(, column: 6)?\) on node the_node/
)
end
it "evaluates enc classes in top scope when there is no node" do
enc_node = Puppet::Node.new("the node", { :classes => ['foo'], :parameters => { "var" => 'from_enc' } })
expect_the_message_to_be('from_enc', enc_node) do <<-MANIFEST
class foo {
notify { 'something': message => $var, }
}
MANIFEST
end
end
it "overrides enc variables from a node scope var" do
enc_node = Puppet::Node.new("the_node", { :classes => ['foo'], :parameters => { 'enc_var' => 'Set from ENC.' } })
expect_the_message_to_be('ENC overridden in node', enc_node) do <<-MANIFEST
node the_node {
$enc_var = "ENC overridden in node"
}
class foo {
notify { 'something': message => $enc_var, }
}
MANIFEST
end
end
end
end
|