1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524
|
require 'spec_helper'
require 'puppet/application/apply'
require 'puppet/file_bucket/dipper'
require 'puppet/configurer'
require 'fileutils'
describe Puppet::Application::Apply do
include PuppetSpec::Files
before :each do
@apply = Puppet::Application[:apply]
allow(Puppet::Util::Log).to receive(:newdestination)
Puppet[:reports] = "none"
end
[:debug,:loadclasses,:test,:verbose,:use_nodes,:detailed_exitcodes,:catalog, :write_catalog_summary].each do |option|
it "should declare handle_#{option} method" do
expect(@apply).to respond_to("handle_#{option}".to_sym)
end
it "should store argument value when calling handle_#{option}" do
expect(@apply.options).to receive(:[]=).with(option, 'arg')
@apply.send("handle_#{option}".to_sym, 'arg')
end
end
it "should set the code to the provided code when :execute is used" do
expect(@apply.options).to receive(:[]=).with(:code, 'arg')
@apply.send("handle_execute".to_sym, 'arg')
end
describe "when applying options" do
it "should set the log destination with --logdest" do
expect(Puppet::Log).to receive(:newdestination).with("console")
@apply.handle_logdest("console")
end
it "should set the setdest options to true" do
expect(@apply.options).to receive(:[]=).with(:setdest,true)
@apply.handle_logdest("console")
end
end
describe "during setup" do
before :each do
allow(Puppet::Log).to receive(:newdestination)
allow(Puppet::FileBucket::Dipper).to receive(:new)
allow(STDIN).to receive(:read)
allow(Puppet::Transaction::Report.indirection).to receive(:cache_class=)
end
describe "with --test" do
it "should call setup_test" do
@apply.options[:test] = true
expect(@apply).to receive(:setup_test)
@apply.setup
end
it "should set options[:verbose] to true" do
@apply.setup_test
expect(@apply.options[:verbose]).to eq(true)
end
it "should set options[:show_diff] to true" do
Puppet.settings.override_default(:show_diff, false)
@apply.setup_test
expect(Puppet[:show_diff]).to eq(true)
end
it "should set options[:detailed_exitcodes] to true" do
@apply.setup_test
expect(@apply.options[:detailed_exitcodes]).to eq(true)
end
end
it "should set console as the log destination if logdest option wasn't provided" do
expect(Puppet::Log).to receive(:newdestination).with(:console)
@apply.setup
end
it "sets the log destination if logdest is provided via settings" do
expect(Puppet::Log).to receive(:newdestination).with("set_via_config")
Puppet[:logdest] = "set_via_config"
@apply.setup
end
it "should set INT trap" do
expect(Signal).to receive(:trap).with(:INT)
@apply.setup
end
it "should set log level to debug if --debug was passed" do
@apply.options[:debug] = true
@apply.setup
expect(Puppet::Log.level).to eq(:debug)
end
it "should set log level to info if --verbose was passed" do
@apply.options[:verbose] = true
@apply.setup
expect(Puppet::Log.level).to eq(:info)
end
it "should print puppet config if asked to in Puppet config" do
allow(Puppet.settings).to receive(:print_configs?).and_return(true)
expect(Puppet.settings).to receive(:print_configs).and_return(true)
expect { @apply.setup }.to exit_with 0
end
it "should exit after printing puppet config if asked to in Puppet config" do
allow(Puppet.settings).to receive(:print_configs?).and_return(true)
expect { @apply.setup }.to exit_with 1
end
it "should use :main, :puppetd, and :ssl" do
expect(Puppet.settings).to receive(:use).with(:main, :agent, :ssl)
@apply.setup
end
it "should tell the report handler to cache locally as yaml" do
expect(Puppet::Transaction::Report.indirection).to receive(:cache_class=).with(:yaml)
@apply.setup
end
it "configures a profiler when profiling is enabled" do
Puppet[:profile] = true
@apply.setup
expect(Puppet::Util::Profiler.current).to satisfy do |ps|
ps.any? {|p| p.is_a? Puppet::Util::Profiler::WallClock }
end
end
it "does not have a profiler if profiling is disabled" do
Puppet[:profile] = false
@apply.setup
expect(Puppet::Util::Profiler.current.length).to be 0
end
it "should set default_file_terminus to `file_server` to be local" do
expect(@apply.app_defaults[:default_file_terminus]).to eq(:file_server)
end
end
describe "when executing" do
it "should dispatch to 'apply' if it was called with 'apply'" do
@apply.options[:catalog] = "foo"
expect(@apply).to receive(:apply)
@apply.run_command
end
it "should dispatch to main otherwise" do
allow(@apply).to receive(:options).and_return({})
expect(@apply).to receive(:main)
@apply.run_command
end
describe "the main command" do
before :each do
Puppet[:prerun_command] = ''
Puppet[:postrun_command] = ''
Puppet::Node.indirection.terminus_class = :memory
Puppet::Node.indirection.cache_class = :memory
facts = Puppet::Node::Facts.new(Puppet[:node_name_value])
Puppet::Node::Facts.indirection.save(facts)
@node = Puppet::Node.new(Puppet[:node_name_value])
Puppet::Node.indirection.save(@node)
@catalog = Puppet::Resource::Catalog.new("testing", Puppet.lookup(:environments).get(Puppet[:environment]))
allow(@catalog).to receive(:to_ral).and_return(@catalog)
allow(Puppet::Resource::Catalog.indirection).to receive(:find).and_return(@catalog)
allow(STDIN).to receive(:read)
@transaction = double('transaction')
allow(@catalog).to receive(:apply).and_return(@transaction)
allow(Puppet::Util::Storage).to receive(:load)
allow_any_instance_of(Puppet::Configurer).to receive(:save_last_run_summary) # to prevent it from trying to write files
end
after :each do
Puppet::Node::Facts.indirection.reset_terminus_class
Puppet::Node::Facts.indirection.cache_class = nil
end
around :each do |example|
Puppet.override(:current_environment =>
Puppet::Node::Environment.create(:production, [])) do
example.run
end
end
it "should set the code to run from --code" do
@apply.options[:code] = "code to run"
expect(Puppet).to receive(:[]=).with(:code,"code to run")
expect { @apply.main }.to exit_with 0
end
it "should set the code to run from STDIN if no arguments" do
allow(@apply.command_line).to receive(:args).and_return([])
allow(STDIN).to receive(:read).and_return("code to run")
expect(Puppet).to receive(:[]=).with(:code,"code to run")
expect { @apply.main }.to exit_with 0
end
it "should raise an error if a file is passed on command line and the file does not exist" do
noexist = tmpfile('noexist.pp')
allow(@apply.command_line).to receive(:args).and_return([noexist])
expect { @apply.main }.to raise_error(RuntimeError, "Could not find file #{noexist}")
end
it "should set the manifest to the first file and warn other files will be skipped" do
manifest = tmpfile('starwarsIV')
FileUtils.touch(manifest)
allow(@apply.command_line).to receive(:args).and_return([manifest, 'starwarsI', 'starwarsII'])
expect { @apply.main }.to exit_with 0
msg = @logs.find {|m| m.message =~ /Only one file can be applied per run/ }
expect(msg.message).to eq('Only one file can be applied per run. Skipping starwarsI, starwarsII')
expect(msg.level).to eq(:warning)
end
it "should splay" do
expect(@apply).to receive(:splay)
expect { @apply.main }.to exit_with 0
end
it "should raise an error if we can't find the node" do
expect(Puppet::Node.indirection).to receive(:find).and_return(nil)
expect { @apply.main }.to raise_error(RuntimeError, /Could not find node/)
end
it "should load custom classes if loadclasses" do
@apply.options[:loadclasses] = true
classfile = tmpfile('classfile')
File.open(classfile, 'w') { |c| c.puts 'class' }
Puppet[:classfile] = classfile
expect(@node).to receive(:classes=).with(['class'])
expect { @apply.main }.to exit_with 0
end
it "should compile the catalog" do
expect(Puppet::Resource::Catalog.indirection).to receive(:find).and_return(@catalog)
expect { @apply.main }.to exit_with 0
end
it 'should make the Puppet::Pops::Loaders available when applying the compiled catalog' do
expect(Puppet::Resource::Catalog.indirection).to receive(:find).and_return(@catalog)
expect(@apply).to receive(:apply_catalog) do |catalog|
expect(@catalog).to eq(@catalog)
fail('Loaders not found') unless Puppet.lookup(:loaders) { nil }.is_a?(Puppet::Pops::Loaders)
true
end.and_return(0)
expect { @apply.main }.to exit_with 0
end
it "should transform the catalog to ral" do
expect(@catalog).to receive(:to_ral).and_return(@catalog)
expect { @apply.main }.to exit_with 0
end
it "should finalize the catalog" do
expect(@catalog).to receive(:finalize)
expect { @apply.main }.to exit_with 0
end
it "should not save the classes or resource file by default" do
expect(@catalog).not_to receive(:write_class_file)
expect(@catalog).not_to receive(:write_resource_file)
expect { @apply.main }.to exit_with 0
end
it "should save the classes and resources files when requested" do
@apply.options[:write_catalog_summary] = true
expect(@catalog).to receive(:write_class_file).once
expect(@catalog).to receive(:write_resource_file).once
expect { @apply.main }.to exit_with 0
end
it "should call the prerun and postrun commands on a Configurer instance" do
expect_any_instance_of(Puppet::Configurer).to receive(:execute_prerun_command).and_return(true)
expect_any_instance_of(Puppet::Configurer).to receive(:execute_postrun_command).and_return(true)
expect { @apply.main }.to exit_with 0
end
it "should apply the catalog" do
expect(@catalog).to receive(:apply).and_return(double('transaction'))
expect { @apply.main }.to exit_with 0
end
it "should save the last run summary" do
Puppet[:noop] = false
report = Puppet::Transaction::Report.new
allow(Puppet::Transaction::Report).to receive(:new).and_return(report)
expect_any_instance_of(Puppet::Configurer).to receive(:save_last_run_summary).with(report)
expect { @apply.main }.to exit_with 0
end
describe "when using node_name_fact" do
before :each do
@facts = Puppet::Node::Facts.new(Puppet[:node_name_value], 'my_name_fact' => 'other_node_name')
Puppet::Node::Facts.indirection.save(@facts)
@node = Puppet::Node.new('other_node_name')
Puppet::Node.indirection.save(@node)
Puppet[:node_name_fact] = 'my_name_fact'
end
it "should set the facts name based on the node_name_fact" do
expect { @apply.main }.to exit_with 0
expect(@facts.name).to eq('other_node_name')
end
it "should set the node_name_value based on the node_name_fact" do
expect { @apply.main }.to exit_with 0
expect(Puppet[:node_name_value]).to eq('other_node_name')
end
it "should merge in our node the loaded facts" do
@facts.values.merge!('key' => 'value')
expect { @apply.main }.to exit_with 0
expect(@node.parameters['key']).to eq('value')
end
it "should raise an error if we can't find the facts" do
expect(Puppet::Node::Facts.indirection).to receive(:find).and_return(nil)
expect { @apply.main }.to raise_error(RuntimeError, /Could not find facts/)
end
end
describe "with detailed_exitcodes" do
before :each do
@apply.options[:detailed_exitcodes] = true
end
it "should exit with report's computed exit status" do
Puppet[:noop] = false
allow_any_instance_of(Puppet::Transaction::Report).to receive(:exit_status).and_return(666)
expect { @apply.main }.to exit_with 666
end
it "should exit with report's computed exit status, even if --noop is set" do
Puppet[:noop] = true
allow_any_instance_of(Puppet::Transaction::Report).to receive(:exit_status).and_return(666)
expect { @apply.main }.to exit_with 666
end
it "should always exit with 0 if option is disabled" do
Puppet[:noop] = false
report = double('report', :exit_status => 666)
allow(@transaction).to receive(:report).and_return(report)
expect { @apply.main }.to exit_with 0
end
it "should always exit with 0 if --noop" do
Puppet[:noop] = true
report = double('report', :exit_status => 666)
allow(@transaction).to receive(:report).and_return(report)
expect { @apply.main }.to exit_with 0
end
end
end
describe "the 'apply' command" do
# We want this memoized, and to be able to adjust the content, so we
# have to do it ourselves.
def temporary_catalog(content = '"something"')
@tempfile = Tempfile.new('catalog.json')
@tempfile.write(content)
@tempfile.close
@tempfile.path
end
it "should read the catalog in from disk if a file name is provided" do
@apply.options[:catalog] = temporary_catalog
catalog = Puppet::Resource::Catalog.new("testing", Puppet::Node::Environment::NONE)
allow(Puppet::Resource::Catalog).to receive(:convert_from).with(:json,'"something"').and_return(catalog)
@apply.apply
end
it "should read the catalog in from stdin if '-' is provided" do
@apply.options[:catalog] = "-"
expect($stdin).to receive(:read).and_return('"something"')
catalog = Puppet::Resource::Catalog.new("testing", Puppet::Node::Environment::NONE)
allow(Puppet::Resource::Catalog).to receive(:convert_from).with(:json,'"something"').and_return(catalog)
@apply.apply
end
it "should deserialize the catalog from the default format" do
@apply.options[:catalog] = temporary_catalog
allow(Puppet::Resource::Catalog).to receive(:default_format).and_return(:rot13_piglatin)
catalog = Puppet::Resource::Catalog.new("testing", Puppet::Node::Environment::NONE)
allow(Puppet::Resource::Catalog).to receive(:convert_from).with(:rot13_piglatin,'"something"').and_return(catalog)
@apply.apply
end
it "should fail helpfully if deserializing fails" do
@apply.options[:catalog] = temporary_catalog('something syntactically invalid')
expect { @apply.apply }.to raise_error(Puppet::Error)
end
it "should convert the catalog to a RAL catalog and use a Configurer instance to apply it" do
@apply.options[:catalog] = temporary_catalog
catalog = Puppet::Resource::Catalog.new("testing", Puppet::Node::Environment::NONE)
allow(Puppet::Resource::Catalog).to receive(:convert_from).with(:json,'"something"').and_return(catalog)
expect(catalog).to receive(:to_ral).and_return("mycatalog")
configurer = double('configurer')
expect(Puppet::Configurer).to receive(:new).and_return(configurer)
expect(configurer).to receive(:run).
with(:catalog => "mycatalog", :pluginsync => false)
@apply.apply
end
it 'should make the Puppet::Pops::Loaders available when applying a catalog' do
@apply.options[:catalog] = temporary_catalog
catalog = Puppet::Resource::Catalog.new("testing", Puppet::Node::Environment::NONE)
expect(@apply).to receive(:read_catalog) do |arg|
expect(arg).to eq('"something"')
fail('Loaders not found') unless Puppet.lookup(:loaders) { nil }.is_a?(Puppet::Pops::Loaders)
true
end.and_return(catalog)
expect(@apply).to receive(:apply_catalog) do |cat|
expect(cat).to eq(catalog)
fail('Loaders not found') unless Puppet.lookup(:loaders) { nil }.is_a?(Puppet::Pops::Loaders)
true
end
expect { @apply.apply }.not_to raise_error
end
end
end
describe "when really executing" do
let(:testfile) { tmpfile('secret_file_name') }
let(:resourcefile) { tmpfile('resourcefile') }
let(:classfile) { tmpfile('classfile') }
it "should not expose sensitive data in the relationship file" do
@apply.options[:code] = <<-CODE
$secret = Sensitive('cat #{testfile}')
exec { 'do it':
command => $secret,
path => '/bin/'
}
CODE
@apply.options[:write_catalog_summary] = true
Puppet.settings[:resourcefile] = resourcefile
Puppet.settings[:classfile] = classfile
#We don't actually need the resource to do anything, we are using it's properties in other parts of the workflow.
allow(Puppet::Util::Execution).to receive(:execute)
expect { @apply.main }.to exit_with 0
result = File.read(resourcefile)
expect(result).not_to match(/secret_file_name/)
expect(result).to match(/do it/)
end
end
describe "apply_catalog" do
it "should call the configurer with the catalog" do
catalog = "I am a catalog"
expect_any_instance_of(Puppet::Configurer).to receive(:run).
with(:catalog => catalog, :pluginsync => false)
@apply.send(:apply_catalog, catalog)
end
end
it "should honor the catalog_cache_terminus setting" do
Puppet.settings[:catalog_cache_terminus] = "json"
expect(Puppet::Resource::Catalog.indirection).to receive(:cache_class=).with(:json)
@apply.initialize_app_defaults
@apply.setup
end
end
|