1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659
|
require 'spec_helper'
require 'puppet/application'
require 'puppet'
require 'getoptlong'
require 'timeout'
describe Puppet::Application do
before(:each) do
@app = Class.new(Puppet::Application).new
@appclass = @app.class
allow(@app).to receive(:name).and_return("test_app")
end
describe "application commandline" do
it "should not pick up changes to the array of arguments" do
args = %w{subcommand --arg}
command_line = Puppet::Util::CommandLine.new('puppet', args)
app = Puppet::Application.new(command_line)
args[0] = 'different_subcommand'
args[1] = '--other-arg'
expect(app.command_line.subcommand_name).to eq('subcommand')
expect(app.command_line.args).to eq(['--arg'])
end
end
describe "application defaults" do
it "should fail if required app default values are missing" do
allow(@app).to receive(:app_defaults).and_return({ :foo => 'bar' })
expect(Puppet).to receive(:err).with(/missing required app default setting/)
expect {
@app.run
}.to exit_with(1)
end
end
describe "finding" do
before do
@klass = Puppet::Application
allow(@klass).to receive(:puts)
end
it "should find classes in the namespace" do
expect(@klass.find("Agent")).to eq(@klass::Agent)
end
it "should not find classes outside the namespace" do
expect { @klass.find("String") }.to raise_error(LoadError)
end
it "should error if it can't find a class" do
expect(Puppet).to receive(:err) do |value|
expect(value).to match(/Unable to find application 'ThisShallNeverEverEverExist'/)
expect(value).to match(/puppet\/application\/thisshallneverevereverexist/)
expect(value).to match(/no such file to load|cannot load such file/)
end
expect {
@klass.find("ThisShallNeverEverEverExist")
}.to raise_error(LoadError)
end
end
describe "#available_application_names" do
it 'should be able to find available application names' do
apps = %w{describe filebucket kick queue resource agent cert apply doc master}
expect(Puppet::Util::Autoload).to receive(:files_to_load).and_return(apps)
expect(Puppet::Application.available_application_names).to match_array(apps)
end
it 'should find applications from multiple paths' do
expect(Puppet::Util::Autoload).to receive(:files_to_load).with('puppet/application').and_return(%w{ /a/foo.rb /b/bar.rb })
expect(Puppet::Application.available_application_names).to match_array(%w{ foo bar })
end
it 'should return unique application names' do
expect(Puppet::Util::Autoload).to receive(:files_to_load).with('puppet/application').and_return(%w{ /a/foo.rb /b/foo.rb })
expect(Puppet::Application.available_application_names).to eq(%w{ foo })
end
end
describe ".run_mode" do
it "should default to user" do
expect(@appclass.run_mode.name).to eq(:user)
end
it "should set and get a value" do
@appclass.run_mode :agent
expect(@appclass.run_mode.name).to eq(:agent)
end
end
describe ".environment_mode" do
it "should default to :local" do
expect(@appclass.get_environment_mode).to eq(:local)
end
it "should set and get a value" do
@appclass.environment_mode :remote
expect(@appclass.get_environment_mode).to eq(:remote)
end
it "should error if given a random symbol" do
expect{@appclass.environment_mode :foo}.to raise_error(/Invalid environment mode/)
end
it "should error if given a string" do
expect{@appclass.environment_mode 'local'}.to raise_error(/Invalid environment mode/)
end
end
# These tests may look a little weird and repetative in its current state;
# it used to illustrate several ways that the run_mode could be changed
# at run time; there are fewer ways now, but it would still be nice to
# get to a point where it was entirely impossible.
describe "when dealing with run_mode" do
class TestApp < Puppet::Application
run_mode :master
def run_command
# no-op
end
end
it "should sadly and frighteningly allow run_mode to change at runtime via #initialize_app_defaults" do
allow(Puppet.features).to receive(:syslog?).and_return(true)
app = TestApp.new
app.initialize_app_defaults
expect(Puppet.run_mode).to be_master
end
it "should sadly and frighteningly allow run_mode to change at runtime via #run" do
app = TestApp.new
app.run
expect(app.class.run_mode.name).to eq(:master)
expect(Puppet.run_mode).to be_master
end
end
it "should explode when an invalid run mode is set at runtime, for great victory" do
expect {
class InvalidRunModeTestApp < Puppet::Application
run_mode :abracadabra
def run_command
# no-op
end
end
}.to raise_error(Puppet::Settings::ValidationError, /Invalid run mode/)
end
it "should have a run entry-point" do
expect(@app).to respond_to(:run)
end
it "should have a read accessor to options" do
expect(@app).to respond_to(:options)
end
it "should include a default setup method" do
expect(@app).to respond_to(:setup)
end
it "should include a default preinit method" do
expect(@app).to respond_to(:preinit)
end
it "should include a default run_command method" do
expect(@app).to respond_to(:run_command)
end
it "should invoke main as the default" do
expect(@app).to receive(:main)
@app.run_command
end
describe 'when invoking clear!' do
before :each do
Puppet::Application.run_status = :stop_requested
Puppet::Application.clear!
end
it 'should have nil run_status' do
expect(Puppet::Application.run_status).to be_nil
end
it 'should return false for restart_requested?' do
expect(Puppet::Application.restart_requested?).to be_falsey
end
it 'should return false for stop_requested?' do
expect(Puppet::Application.stop_requested?).to be_falsey
end
it 'should return false for interrupted?' do
expect(Puppet::Application.interrupted?).to be_falsey
end
it 'should return true for clear?' do
expect(Puppet::Application.clear?).to be_truthy
end
end
describe 'after invoking stop!' do
before :each do
Puppet::Application.run_status = nil
Puppet::Application.stop!
end
after :each do
Puppet::Application.run_status = nil
end
it 'should have run_status of :stop_requested' do
expect(Puppet::Application.run_status).to eq(:stop_requested)
end
it 'should return true for stop_requested?' do
expect(Puppet::Application.stop_requested?).to be_truthy
end
it 'should return false for restart_requested?' do
expect(Puppet::Application.restart_requested?).to be_falsey
end
it 'should return true for interrupted?' do
expect(Puppet::Application.interrupted?).to be_truthy
end
it 'should return false for clear?' do
expect(Puppet::Application.clear?).to be_falsey
end
end
describe 'when invoking restart!' do
before :each do
Puppet::Application.run_status = nil
Puppet::Application.restart!
end
after :each do
Puppet::Application.run_status = nil
end
it 'should have run_status of :restart_requested' do
expect(Puppet::Application.run_status).to eq(:restart_requested)
end
it 'should return true for restart_requested?' do
expect(Puppet::Application.restart_requested?).to be_truthy
end
it 'should return false for stop_requested?' do
expect(Puppet::Application.stop_requested?).to be_falsey
end
it 'should return true for interrupted?' do
expect(Puppet::Application.interrupted?).to be_truthy
end
it 'should return false for clear?' do
expect(Puppet::Application.clear?).to be_falsey
end
end
describe 'when performing a controlled_run' do
it 'should not execute block if not :clear?' do
Puppet::Application.run_status = :stop_requested
target = double('target')
expect(target).not_to receive(:some_method)
Puppet::Application.controlled_run do
target.some_method
end
end
it 'should execute block if :clear?' do
Puppet::Application.run_status = nil
target = double('target')
expect(target).to receive(:some_method).once
Puppet::Application.controlled_run do
target.some_method
end
end
describe 'on POSIX systems', :if => Puppet.features.posix? do
it 'should signal process with HUP after block if restart requested during block execution' do
Timeout::timeout(3) do # if the signal doesn't fire, this causes failure.
has_run = false
old_handler = trap('HUP') { has_run = true }
begin
Puppet::Application.controlled_run do
Puppet::Application.run_status = :restart_requested
end
# Ruby 1.9 uses a separate OS level thread to run the signal
# handler, so we have to poll - ideally, in a way that will kick
# the OS into running other threads - for a while.
#
# You can't just use the Ruby Thread yield thing either, because
# that is just an OS hint, and Linux ... doesn't take that
# seriously. --daniel 2012-03-22
sleep 0.001 while not has_run
ensure
trap('HUP', old_handler)
end
end
end
end
after :each do
Puppet::Application.run_status = nil
end
end
describe "when parsing command-line options" do
before :each do
allow(@app.command_line).to receive(:args).and_return([])
allow(Puppet.settings).to receive(:optparse_addargs).and_return([])
end
it "should pass the banner to the option parser" do
option_parser = double("option parser")
allow(option_parser).to receive(:on)
allow(option_parser).to receive(:parse!)
@app.class.instance_eval do
banner "banner"
end
expect(OptionParser).to receive(:new).with("banner").and_return(option_parser)
@app.parse_options
end
it "should ask OptionParser to parse the command-line argument" do
allow(@app.command_line).to receive(:args).and_return(%w{ fake args })
expect_any_instance_of(OptionParser).to receive(:parse!).with(%w{ fake args })
@app.parse_options
end
describe "when using --help" do
it "should call exit" do
allow(@app).to receive(:puts)
expect { @app.handle_help(nil) }.to exit_with 0
end
end
describe "when using --version" do
it "should declare a version option" do
expect(@app).to respond_to(:handle_version)
end
it "should exit after printing the version" do
allow(@app).to receive(:puts)
expect { @app.handle_version(nil) }.to exit_with 0
end
end
describe "when dealing with an argument not declared directly by the application" do
it "should pass it to handle_unknown if this method exists" do
allow(Puppet.settings).to receive(:optparse_addargs).and_return([["--not-handled", :REQUIRED]])
expect(@app).to receive(:handle_unknown).with("--not-handled", "value").and_return(true)
allow(@app.command_line).to receive(:args).and_return(["--not-handled", "value"])
@app.parse_options
end
it "should transform boolean option to normal form for Puppet.settings" do
expect(@app).to receive(:handle_unknown).with("--option", true)
@app.send(:handlearg, "--[no-]option", true)
end
it "should transform boolean option to no- form for Puppet.settings" do
expect(@app).to receive(:handle_unknown).with("--no-option", false)
@app.send(:handlearg, "--[no-]option", false)
end
end
end
describe "when calling default setup" do
before :each do
allow(@app.options).to receive(:[])
end
[ :debug, :verbose ].each do |level|
it "should honor option #{level}" do
allow(@app.options).to receive(:[]).with(level).and_return(true)
allow(Puppet::Util::Log).to receive(:newdestination)
@app.setup
expect(Puppet::Util::Log.level).to eq(level == :verbose ? :info : :debug)
end
end
it "should honor setdest option" do
allow(@app.options).to receive(:[]).with(:setdest).and_return(false)
expect(Puppet::Util::Log).to receive(:setup_default)
@app.setup
end
it "sets the log destination if provided via settings" do
allow(@app.options).to receive(:[]).and_call_original
Puppet[:logdest] = "set_via_config"
expect(Puppet::Util::Log).to receive(:newdestination).with("set_via_config")
@app.setup
end
it "does not downgrade the loglevel when --verbose is specified" do
Puppet[:log_level] = :debug
allow(@app.options).to receive(:[]).with(:verbose).and_return(true)
@app.setup_logs
expect(Puppet::Util::Log.level).to eq(:debug)
end
it "allows the loglevel to be specified as an argument" do
@app.set_log_level(:debug => true)
expect(Puppet::Util::Log.level).to eq(:debug)
end
end
describe "when configuring routes" do
include PuppetSpec::Files
before :each do
Puppet::Node.indirection.reset_terminus_class
end
after :each do
Puppet::Node.indirection.reset_terminus_class
end
it "should use the routes specified for only the active application" do
Puppet[:route_file] = tmpfile('routes')
File.open(Puppet[:route_file], 'w') do |f|
f.print <<-ROUTES
test_app:
node:
terminus: exec
other_app:
node:
terminus: plain
catalog:
terminus: invalid
ROUTES
end
@app.configure_indirector_routes
expect(Puppet::Node.indirection.terminus_class).to eq('exec')
end
it "should not fail if the route file doesn't exist" do
Puppet[:route_file] = "/dev/null/non-existent"
expect { @app.configure_indirector_routes }.to_not raise_error
end
it "should raise an error if the routes file is invalid" do
Puppet[:route_file] = tmpfile('routes')
File.open(Puppet[:route_file], 'w') do |f|
f.print <<-ROUTES
invalid : : yaml
ROUTES
end
expect { @app.configure_indirector_routes }.to raise_error(Psych::SyntaxError, /mapping values are not allowed in this context/)
end
end
describe "when running" do
before :each do
allow(@app).to receive(:preinit)
allow(@app).to receive(:setup)
allow(@app).to receive(:parse_options)
end
it "should call preinit" do
allow(@app).to receive(:run_command)
expect(@app).to receive(:preinit)
@app.run
end
it "should call parse_options" do
allow(@app).to receive(:run_command)
expect(@app).to receive(:parse_options)
@app.run
end
it "should call run_command" do
expect(@app).to receive(:run_command)
@app.run
end
it "should call run_command" do
expect(@app).to receive(:run_command)
@app.run
end
it "should call main as the default command" do
expect(@app).to receive(:main)
@app.run
end
it "should warn and exit if no command can be called" do
expect(Puppet).to receive(:err)
expect { @app.run }.to exit_with 1
end
it "should raise an error if dispatch returns no command" do
allow(@app).to receive(:get_command).and_return(nil)
expect(Puppet).to receive(:err)
expect { @app.run }.to exit_with 1
end
it "should raise an error if dispatch returns an invalid command" do
allow(@app).to receive(:get_command).and_return(:this_function_doesnt_exist)
expect(Puppet).to receive(:err)
expect { @app.run }.to exit_with 1
end
end
describe "when metaprogramming" do
describe "when calling option" do
it "should create a new method named after the option" do
@app.class.option("--test1","-t") do
end
expect(@app).to respond_to(:handle_test1)
end
it "should transpose in option name any '-' into '_'" do
@app.class.option("--test-dashes-again","-t") do
end
expect(@app).to respond_to(:handle_test_dashes_again)
end
it "should create a new method called handle_test2 with option(\"--[no-]test2\")" do
@app.class.option("--[no-]test2","-t") do
end
expect(@app).to respond_to(:handle_test2)
end
describe "when a block is passed" do
it "should create a new method with it" do
@app.class.option("--[no-]test2","-t") do
raise "I can't believe it, it works!"
end
expect { @app.handle_test2 }.to raise_error(RuntimeError, /I can't believe it, it works!/)
end
it "should declare the option to OptionParser" do
allow_any_instance_of(OptionParser).to receive(:on)
expect_any_instance_of(OptionParser).to receive(:on).with("--[no-]test3", anything)
@app.class.option("--[no-]test3","-t") do
end
@app.parse_options
end
it "should pass a block that calls our defined method" do
allow_any_instance_of(OptionParser).to receive(:on)
allow_any_instance_of(OptionParser).to receive(:on).with('--test4', '-t').and_yield(nil)
expect(@app).to receive(:send).with(:handle_test4, nil)
@app.class.option("--test4","-t") do
end
@app.parse_options
end
end
describe "when no block is given" do
it "should declare the option to OptionParser" do
allow_any_instance_of(OptionParser).to receive(:on)
expect_any_instance_of(OptionParser).to receive(:on).with("--test4", "-t")
@app.class.option("--test4","-t")
@app.parse_options
end
it "should give to OptionParser a block that adds the value to the options array" do
allow_any_instance_of(OptionParser).to receive(:on)
allow_any_instance_of(OptionParser).to receive(:on).with("--test4", "-t").and_yield(nil)
expect(@app.options).to receive(:[]=).with(:test4, nil)
@app.class.option("--test4","-t")
@app.parse_options
end
end
end
end
describe "#handle_logdest_arg" do
let(:test_arg) { "arg_test_logdest" }
it "should log an exception that is raised" do
our_exception = Puppet::DevError.new("test exception")
expect(Puppet::Util::Log).to receive(:newdestination).with(test_arg).and_raise(our_exception)
expect(Puppet).to receive(:log_and_raise).with(our_exception, anything)
@app.handle_logdest_arg(test_arg)
end
it "should exit when an exception is raised" do
our_exception = Puppet::DevError.new("test exception")
expect(Puppet::Util::Log).to receive(:newdestination).with(test_arg).and_raise(our_exception)
expect(Puppet).to receive(:log_and_raise).with(our_exception, anything).and_raise(our_exception)
expect { @app.handle_logdest_arg(test_arg) }.to raise_error(Puppet::DevError)
end
it "should set the new log destination" do
expect(Puppet::Util::Log).to receive(:newdestination).with(test_arg)
@app.handle_logdest_arg(test_arg)
end
it "should set the flag that a destination is set in the options hash" do
allow(Puppet::Util::Log).to receive(:newdestination).with(test_arg)
@app.handle_logdest_arg(test_arg)
expect(@app.options[:setdest]).to be_truthy
end
it "does not set the log destination if arg is nil" do
expect(Puppet::Util::Log).not_to receive(:newdestination)
@app.handle_logdest_arg(nil)
end
end
end
|