1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
|
require 'spec_helper'
require 'puppet/forge'
require 'net/http'
require 'puppet/module_tool'
describe Puppet::Forge do
let(:http_response) do
<<-EOF
{
"pagination": {
"limit": 1,
"offset": 0,
"first": "/v3/modules?limit=1&offset=0",
"previous": null,
"current": "/v3/modules?limit=1&offset=0",
"next": null,
"total": 1832
},
"results": [
{
"uri": "/v3/modules/puppetlabs-bacula",
"name": "bacula",
"downloads": 640274,
"created_at": "2011-05-24 18:34:58 -0700",
"updated_at": "2013-12-03 15:24:20 -0800",
"owner": {
"uri": "/v3/users/puppetlabs",
"username": "puppetlabs",
"gravatar_id": "fdd009b7c1ec96e088b389f773e87aec"
},
"current_release": {
"uri": "/v3/releases/puppetlabs-bacula-0.0.2",
"module": {
"uri": "/v3/modules/puppetlabs-bacula",
"name": "bacula",
"owner": {
"uri": "/v3/users/puppetlabs",
"username": "puppetlabs",
"gravatar_id": "fdd009b7c1ec96e088b389f773e87aec"
}
},
"version": "0.0.2",
"metadata": {
"types": [],
"license": "Apache 2.0",
"checksums": { },
"version": "0.0.2",
"source": "git://github.com/puppetlabs/puppetlabs-bacula.git",
"project_page": "https://github.com/puppetlabs/puppetlabs-bacula",
"summary": "bacula",
"dependencies": [ ],
"author": "puppetlabs",
"name": "puppetlabs-bacula"
},
"tags": [
"backup",
"bacula"
],
"file_uri": "/v3/files/puppetlabs-bacula-0.0.2.tar.gz",
"file_size": 67586,
"file_md5": "bbf919d7ee9d278d2facf39c25578bf8",
"downloads": 565041,
"readme": "",
"changelog": "",
"license": "",
"created_at": "2013-05-13 08:31:19 -0700",
"updated_at": "2013-05-13 08:31:19 -0700",
"deleted_at": null
},
"releases": [
{
"uri": "/v3/releases/puppetlabs-bacula-0.0.2",
"version": "0.0.2"
},
{
"uri": "/v3/releases/puppetlabs-bacula-0.0.1",
"version": "0.0.1"
}
],
"homepage_url": "https://github.com/puppetlabs/puppetlabs-bacula",
"issues_url": "https://projects.puppetlabs.com/projects/bacula/issues"
}
]
}
EOF
end
let(:search_results) do
JSON.parse(http_response)['results'].map do |hash|
hash.merge(
"author" => "puppetlabs",
"name" => "bacula",
"tag_list" => ["backup", "bacula"],
"full_name" => "puppetlabs/bacula",
"version" => "0.0.2",
"project_url" => "https://github.com/puppetlabs/puppetlabs-bacula",
"desc" => "bacula"
)
end
end
let(:forge) { Puppet::Forge.new }
def repository_responds_with(response, &block)
if block_given?
allow_any_instance_of(Puppet::Forge::Repository).to receive(:make_http_request, &block).and_return(response)
else
allow_any_instance_of(Puppet::Forge::Repository).to receive(:make_http_request).and_return(response)
end
end
it "returns a list of matches from the forge when there are matches for the search term" do
repository_responds_with(double(:body => http_response, :code => '200'))
expect(forge.search('bacula')).to eq(search_results)
end
context "when module_groups are defined" do
let(:release_response) do
releases = JSON.parse(http_response)
releases['results'] = []
JSON.dump(releases)
end
before :each do
repository_responds_with(double(:body => release_response, :code => '200')) {|uri| uri =~ /module_groups=foo/}
Puppet[:module_groups] = "foo"
end
it "passes module_groups with search" do
forge.search('bacula')
end
it "passes module_groups with fetch" do
forge.fetch('puppetlabs-bacula')
end
end
# See PUP-8008
context "when multiple module_groups are defined" do
let(:release_response) do
releases = JSON.parse(http_response)
releases['results'] = []
JSON.dump(releases)
end
context "with space seperator" do
before :each do
repository_responds_with(double(:body => release_response, :code => '200')) {|uri| uri =~ /module_groups=foo bar/}
Puppet[:module_groups] = "foo bar"
end
it "passes module_groups with search" do
forge.search('bacula')
end
it "passes module_groups with fetch" do
forge.fetch('puppetlabs-bacula')
end
end
context "with plus seperator" do
before :each do
repository_responds_with(double(:body => release_response, :code => '200')) {|uri| uri =~ /module_groups=foo bar/}
Puppet[:module_groups] = "foo+bar"
end
it "passes module_groups with search" do
forge.search('bacula')
end
it "passes module_groups with fetch" do
forge.fetch('puppetlabs-bacula')
end
end
# See PUP-8008
context "when there are multiple pages of results" do
before(:each) do
expect_any_instance_of(Puppet::Forge::Repository).to receive(:make_http_request) {|_, uri| uri =~ /module_groups=foo bar/ && uri !=~ /offset/ }.and_return(double(:body => first_page, :code => '200'))
# Request for second page should not have module_groups already encoded
expect_any_instance_of(Puppet::Forge::Repository).to receive(:make_http_request) {|_, uri| uri =~ /module_groups=foo bar/ && uri =~ /offset=1/ }.and_return(double(:body => last_page, :code => '200'))
end
context "with space seperator" do
before(:each) do
Puppet[:module_groups] = "foo bar"
end
let(:first_page) do
resp = JSON.parse(http_response)
resp['results'] = []
resp['pagination']['next'] = "/v3/modules?limit=1&offset=1&module_groups=foo%20bar"
JSON.dump(resp)
end
let(:last_page) do
resp = JSON.parse(http_response)
resp['results'] = []
resp['pagination']['current'] = "/v3/modules?limit=1&offset=1&module_groups=foo%20bar"
JSON.dump(resp)
end
it "traverses pages during search" do
forge.search('bacula')
end
it "traverses pages during fetch" do
forge.fetch('puppetlabs-bacula')
end
end
context "with plus seperator" do
before(:each) do
Puppet[:module_groups] = "foo+bar"
end
let(:first_page) do
resp = JSON.parse(http_response)
resp['results'] = []
resp['pagination']['next'] = "/v3/modules?limit=1&offset=1&module_groups=foo+bar"
JSON.dump(resp)
end
let(:last_page) do
resp = JSON.parse(http_response)
resp['results'] = []
resp['pagination']['current'] = "/v3/modules?limit=1&offset=1&module_groups=foo+bar"
JSON.dump(resp)
end
it "traverses pages during search" do
forge.search('bacula')
end
it "traverses pages during fetch" do
forge.fetch('puppetlabs-bacula')
end
end
end
end
context "when the connection to the forge fails" do
before :each do
repository_responds_with(double(:body => '{}', :code => '404', :message => "not found"))
end
it "raises an error for search" do
expect { forge.search('bacula') }.to raise_error Puppet::Forge::Errors::ResponseError, "Request to Puppet Forge failed. Detail: 404 not found."
end
it "raises an error for fetch" do
expect { forge.fetch('puppetlabs/bacula') }.to raise_error Puppet::Forge::Errors::ResponseError, "Request to Puppet Forge failed. Detail: 404 not found."
end
end
context "when the API responds with an error" do
before :each do
repository_responds_with(double(:body => '{"error":"invalid module"}', :code => '410', :message => "Gone"))
end
it "raises an error for fetch" do
expect { forge.fetch('puppetlabs/bacula') }.to raise_error Puppet::Forge::Errors::ResponseError, "Request to Puppet Forge failed. Detail: 410 Gone."
end
end
context "when the forge returns a module with unparseable dependencies" do
before :each do
response = JSON.parse(http_response)
release = response['results'][0]['current_release']
release['metadata']['dependencies'] = [{'name' => 'broken-garbage >= 1.0.0', 'version_requirement' => 'banana'}]
response['results'] = [release]
repository_responds_with(double(:body => JSON.dump(response), :code => '200'))
end
it "ignores modules with unparseable dependencies" do
expect(forge.fetch('puppetlabs/bacula')).to be_empty
end
end
end
|
