File: hiera_spec.rb

package info (click to toggle)
puppet 5.5.22-2
  • links: PTS, VCS
  • area: main
  • in suites: bullseye
  • size: 21,316 kB
  • sloc: ruby: 254,925; sh: 1,608; xml: 219; makefile: 153; sql: 103
file content (529 lines) | stat: -rw-r--r-- 16,187 bytes parent folder | download | duplicates (2)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
require 'spec_helper'
require 'puppet_spec/compiler'
require 'puppet/pops'

describe 'when calling' do
  include PuppetSpec::Compiler
  include PuppetSpec::Files

  let(:global_dir) { tmpdir('global') }
  let(:env_config) { {} }
  let(:hiera_yaml) { <<-YAML.unindent }
    ---
    :backends:
      - yaml
      - custom
    :yaml:
      :datadir: #{global_dir}/hieradata
    :hierarchy:
      - first
      - second
    YAML

  let(:ruby_stuff_files) do
    {
      'hiera' => {
        'backend' => {
          'custom_backend.rb' => <<-RUBY.unindent
            class Hiera::Backend::Custom_backend
              def initialize(cache = nil)
                Hiera.debug('Custom_backend starting')
              end

              def lookup(key, scope, order_override, resolution_type, context)
                case key
                when 'datasources'
                  Hiera::Backend.datasources(scope, order_override) { |source| source }
                when 'resolution_type'
                  if resolution_type == :hash
                    { key => resolution_type.to_s }
                  elsif resolution_type == :array
                    [ key, resolution_type.to_s ]
                  else
                    "resolution_type=\#{resolution_type}"
                  end
                else
                  throw :no_such_key
                end
              end
            end
            RUBY
        }
      }
    }
  end

  let(:hieradata_files) do
    {
      'first.yaml' => <<-YAML.unindent,
        ---
        a: first a
        class_name: "-- %{calling_class} --"
        class_path: "-- %{calling_class_path} --"
        module: "-- %{calling_module} --"
        mod_name: "-- %{module_name} --"
        database_user:
          name: postgres
          uid: 500
          gid: 500
          groups:
            db: 520
        b:
          b1: first b1
          b2: first b2
        fbb:
          - mod::foo
          - mod::bar
          - mod::baz
        empty_array: []
        nested_array:
          first:
            - 10
            - 11
          second:
            - 21
            - 22
        dotted.key:
          a: dotted.key a
          b: dotted.key b
        dotted.array:
          - a
          - b
        YAML
      'second.yaml' => <<-YAML.unindent,
        ---
        a: second a
        b:
          b1: second b1
          b3: second b3
        YAML
      'the_override.yaml' => <<-YAML.unindent
        ---
        key: foo_result
        YAML
    }
  end

  let(:environment_files) do
    {
      'test' => {
        'modules' => {
          'mod' => {
            'manifests' => {
              'foo.pp' => <<-PUPPET.unindent,
                class mod::foo {
                  notice(hiera('class_name'))
                  notice(hiera('class_path'))
                  notice(hiera('module'))
                  notice(hiera('mod_name'))
                }
                PUPPET
              'bar.pp' => <<-PUPPET.unindent,
                class mod::bar {}
                PUPPET
              'baz.pp' => <<-PUPPET.unindent
                class mod::baz {}
                PUPPET
              },
            'hiera.yaml' => <<-YAML.unindent,
              ---
              version: 5
              YAML
            'data' => {
              'common.yaml' => <<-YAML.unindent
                mod::c: mod::c (from module)
                YAML
            }
          }
        }
      }.merge(env_config)
    }
  end

  let(:global_files) do
    {
      'hiera.yaml' => hiera_yaml,
      'ruby_stuff' => ruby_stuff_files,
      'hieradata' => hieradata_files,
      'environments' => environment_files
    }
  end

  let(:logs) { [] }
  let(:warnings) { logs.select { |log| log.level == :warning }.map { |log| log.message } }
  let(:env_dir) { File.join(global_dir, 'environments') }
  let(:env) { Puppet::Node::Environment.create(:test, [File.join(env_dir, 'test', 'modules')]) }
  let(:environments) { Puppet::Environments::Directories.new(env_dir, []) }
  let(:node) { Puppet::Node.new('test_hiera', :environment => env) }
  let(:compiler) { Puppet::Parser::Compiler.new(node) }
  let(:the_func) { Puppet.lookup(:loaders).puppet_system_loader.load(:function, 'hiera') }

  before(:each) do
    Puppet.settings[:codedir] = global_dir
    Puppet.settings[:hiera_config] = File.join(global_dir, 'hiera.yaml')
  end

  around(:each) do |example|
    # Faking the load path to enable 'require' to load from 'ruby_stuff'. It removes the need for a static fixture
    # for the custom backend
    dir_contained_in(global_dir, global_files)
    $LOAD_PATH.unshift(File.join(global_dir, 'ruby_stuff'))
    begin
      Puppet.override(:environments => environments, :current_environment => env) do
        example.run
      end
    ensure
      Hiera::Backend.send(:remove_const, :Custom_backend) if Hiera::Backend.const_defined?(:Custom_backend)
      $LOAD_PATH.shift
    end
  end

  def with_scope(code = 'undef')
    result = nil
    Puppet[:code] = 'undef'
    Puppet::Util::Log.with_destination(Puppet::Test::LogCollector.new(logs)) do
      compiler.compile do |catalog|
        result = yield(compiler.topscope)
        catalog
      end
    end
    result
  end

  def func(*args, &block)
    with_scope { |scope| the_func.call(scope, *args, &block) }
  end

  context 'hiera' do
    it 'should require a key argument' do
      expect { func([]) }.to raise_error(ArgumentError)
    end

    it 'should raise a useful error when nil is returned' do
      expect { func('badkey') }.to raise_error(Puppet::DataBinding::LookupError, /did not find a value for the name 'badkey'/)
    end

    it 'should use the "first" merge strategy' do
      expect(func('a')).to eql('first a')
    end

    it 'should allow lookup with quoted dotted key' do
      expect(func("'dotted.key'")).to eql({'a' => 'dotted.key a', 'b' => 'dotted.key b'})
    end

    it 'should allow lookup with dotted key' do
      expect(func('database_user.groups.db')).to eql(520)
    end

    it 'should not find data in module' do
      expect(func('mod::c', 'default mod::c')).to eql('default mod::c')
    end

    it 'should propagate optional override' do
      ovr = 'the_override'
      expect(func('key', nil, ovr)).to eql('foo_result')
    end

    it 'backend data sources, including optional overrides, are propagated to custom backend' do
      expect(func('datasources', nil, 'the_override')).to eql(['the_override', 'first', 'second'])
    end

    it 'a hiera v3 scope is used' do
      expect(eval_and_collect_notices(<<-PUPPET, node)).to eql(['-- testing --', '-- mod::foo --', '-- mod/foo --', '-- mod --', '-- mod --'])
      class testing () {
         notice(hiera('class_name'))
      }
      include testing
      include mod::foo
      PUPPET
    end

    it 'should return default value nil when key is not found' do
       expect(func('foo', nil)).to be_nil
    end

    it "should return default value '' when key is not found" do
      expect(func('foo', '')).to eq('')
    end

    it 'should use default block' do
      expect(func('foo') { |k| "default for key '#{k}'" }).to eql("default for key 'foo'")
    end

    it 'should propagate optional override when combined with default block' do
      ovr = 'the_override'
      with_scope do |scope|
        expect(the_func.call(scope, 'key', ovr) { |k| "default for key '#{k}'" }).to eql('foo_result')
        expect(the_func.call(scope, 'foo.bar', ovr) { |k| "default for key '#{k}'" }).to eql("default for key 'foo.bar'")
      end
    end

    it 'should log deprecation errors' do
      func('a')
      expect(warnings).to include(/The function 'hiera' is deprecated in favor of using 'lookup'. See https:/)
    end

    context 'with environment with configured data provider' do
      let(:env_config) {
        {
          'hiera.yaml' => <<-YAML.unindent,
             ---
             version: 5
             YAML
          'data' => {
            'common.yaml' => <<-YAML.unindent
              ---
              a: a (from environment)
              e: e (from environment)
              YAML
          }
        }
      }

      it 'should find data globally' do
        expect(func('a')).to eql('first a')
      end

      it 'should find data in the environment' do
        expect(func('e')).to eql('e (from environment)')
      end

      it 'should find data in module' do
        expect(func('mod::c')).to eql('mod::c (from module)')
      end
    end

    it 'should not be disabled by data_binding_terminus setting' do
      Puppet[:data_binding_terminus] = 'none'
      expect(func('a')).to eql('first a')
    end
  end

  context 'hiera_array' do
    let(:the_func) { Puppet.lookup(:loaders).puppet_system_loader.load(:function, 'hiera_array') }

    it 'should require a key argument' do
      expect { func([]) }.to raise_error(ArgumentError)
    end

    it 'should raise a useful error when nil is returned' do
      expect { func('badkey') }.to raise_error(Puppet::DataBinding::LookupError, /did not find a value for the name 'badkey'/)
    end

    it 'should log deprecation errors' do
      func('fbb')
      expect(warnings).to include(/The function 'hiera_array' is deprecated in favor of using 'lookup'/)
    end

    it 'should use the array resolution_type' do
      expect(func('fbb', {'fbb' => 'foo_result'})).to eql(%w[mod::foo mod::bar mod::baz])
    end

    it 'should allow lookup with quoted dotted key' do
      expect(func("'dotted.array'")).to eql(['a', 'b'])
    end

    it 'should fail lookup with dotted key' do
      expect{ func('nested_array.0.first') }.to raise_error(/Resolution type :array is illegal when accessing values using dotted keys. Offending key was 'nested_array.0.first'/)
    end

    it 'should use default block' do
      expect(func('foo') { |k| ['key', k] }).to eql(%w[key foo])
    end
  end

  context 'hiera_hash' do
    let(:the_func) { Puppet.lookup(:loaders).puppet_system_loader.load(:function, 'hiera_hash') }

    it 'should require a key argument' do
      expect { func([]) }.to raise_error(ArgumentError)
    end

    it 'should raise a useful error when nil is returned' do
      expect { func('badkey') }.to raise_error(Puppet::DataBinding::LookupError, /did not find a value for the name 'badkey'/)
    end

    it 'should use the hash resolution_type' do
      expect(func('b', {'b' => 'foo_result'})).to eql({ 'b1' => 'first b1', 'b2' => 'first b2', 'b3' => 'second b3'})
    end

    it 'should lookup and return a hash' do
      expect(func('database_user')).to eql({ 'name' => 'postgres', 'uid' => 500, 'gid' => 500, 'groups' => { 'db' => 520 }})
    end

    it 'should allow lookup with quoted dotted key' do
      expect(func("'dotted.key'")).to eql({'a' => 'dotted.key a', 'b' => 'dotted.key b'})
    end

    it 'should fail lookup with dotted key' do
      expect{ func('database_user.groups') }.to raise_error(/Resolution type :hash is illegal when accessing values using dotted keys. Offending key was 'database_user.groups'/)
    end

    it 'should log deprecation errors' do
      func('b')
      expect(warnings).to include(/The function 'hiera_hash' is deprecated in favor of using 'lookup'. See https:/)
    end

    it 'should use default block' do
      expect(func('foo') { |k| {'key' => k} }).to eql({'key' => 'foo'})
    end
  end

  context 'hiera_include' do
    let(:the_func) { Puppet.lookup(:loaders).puppet_system_loader.load(:function, 'hiera_include') }

    it 'should require a key argument' do
      expect { func([]) }.to raise_error(ArgumentError)
    end

    it 'should raise a useful error when nil is returned' do
      expect { func('badkey') }.to raise_error(Puppet::DataBinding::LookupError, /did not find a value for the name 'badkey'/)
    end

    it 'should use the array resolution_type to include classes' do
      expect(func('fbb').map { |c| c.class_name }).to eql(%w[mod::foo mod::bar mod::baz])
    end

    it 'should log deprecation errors' do
      func('fbb')
      expect(warnings).to include(/The function 'hiera_include' is deprecated in favor of using 'lookup'. See https:/)
    end

    it 'should not raise an error if the resulting hiera lookup returns an empty array' do
      expect { func('empty_array') }.to_not raise_error
    end

    it 'should use default block array to include classes' do
      expect(func('foo') { |k| ['mod::bar', "mod::#{k}"] }.map { |c| c.class_name }).to eql(%w[mod::bar mod::foo])
    end
  end

  context 'with custom backend and merge_behavior declared in hiera.yaml' do
    let(:merge_behavior) { 'deeper' }

    let(:hiera_yaml) do
      <<-YAML.unindent
        ---
        :backends:
          - yaml
          - custom
        :yaml:
          :datadir: #{global_dir}/hieradata
        :hierarchy:
          - common
          - other
        :merge_behavior: #{merge_behavior}
        :deep_merge_options:
          :unpack_arrays: ','
        YAML
    end

    let(:global_files) do
      {
        'hiera.yaml' => hiera_yaml,
        'hieradata' => {
          'common.yaml' => <<-YAML.unindent,
            da:
              - da 0
              - da 1
            dm:
              dm1:
                dm11: value of dm11 (from common)
                dm12: value of dm12 (from common)
              dm2:
                dm21: value of dm21 (from common)
            hash:
              array:
                - x1,x2
            array:
              - x1,x2
            YAML
          'other.yaml' => <<-YAML.unindent,
            da:
              - da 2,da 3
            dm:
              dm1:
                dm11: value of dm11 (from other)
                dm13: value of dm13 (from other)
              dm3:
                dm31: value of dm31 (from other)
            hash:
              array:
                - x3
                - x4
            array:
              - x3
              - x4
            YAML
        },
        'ruby_stuff' => ruby_stuff_files
      }
    end

    context 'hiera_hash' do
      let(:the_func) { Puppet.lookup(:loaders).puppet_system_loader.load(:function, 'hiera_hash') }

      context "using 'deeper'" do
        it 'declared merge_behavior is honored' do
          expect(func('dm')).to eql({
            'dm1' => {
              'dm11' => 'value of dm11 (from common)',
              'dm12' => 'value of dm12 (from common)',
              'dm13' => 'value of dm13 (from other)'
            },
            'dm2' => {
              'dm21' => 'value of dm21 (from common)'
            },
            'dm3' => {
              'dm31' => 'value of dm31 (from other)'
            }
          })
        end

        it "merge behavior is propagated to a custom backend as 'hash'" do
          expect(func('resolution_type')).to eql({ 'resolution_type' => 'hash' })
        end

        it 'fails on attempts to merge an array' do
          expect {func('da')}.to raise_error(/expects a Hash value/)
        end

        it 'honors option :unpack_arrays: (unsupported by puppet)' do
          expect(func('hash')).to eql({'array' => %w(x3 x4 x1 x2)})
        end
      end

      context "using 'deep'" do
        let(:merge_behavior) { 'deep' }

        it 'honors option :unpack_arrays: (unsupported by puppet)' do
          expect(func('hash')).to eql({'array' => %w(x1 x2 x3 x4)})
        end
      end
    end

    context 'hiera_array' do
      let(:the_func) { Puppet.lookup(:loaders).puppet_system_loader.load(:function, 'hiera_array') }

      it 'declared merge_behavior is ignored' do
        expect(func('da')).to eql(['da 0', 'da 1', 'da 2,da 3'])
      end

      it "merge behavior is propagated to a custom backend as 'array'" do
        expect(func('resolution_type')).to eql(['resolution_type', 'array'])
      end
    end

    context 'hiera' do
      let(:the_func) { Puppet.lookup(:loaders).puppet_system_loader.load(:function, 'hiera') }

      it 'declared merge_behavior is ignored' do
        expect(func('da')).to eql(['da 0', 'da 1'])
      end

      it "no merge behavior is propagated to a custom backend" do
        expect(func('resolution_type')).to eql('resolution_type=')
      end
    end
  end
end