1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558
|
require 'spec_helper'
require 'matchers/json'
require 'puppet/indirector/request'
describe Puppet::Indirector::Request do
include JSONMatchers
describe "when initializing" do
it "should always convert the indirection name to a symbol" do
expect(Puppet::Indirector::Request.new("ind", :method, "mykey", nil).indirection_name).to eq(:ind)
end
it "should use provided value as the key if it is a string" do
expect(Puppet::Indirector::Request.new(:ind, :method, "mykey", nil).key).to eq("mykey")
end
it "should use provided value as the key if it is a symbol" do
expect(Puppet::Indirector::Request.new(:ind, :method, :mykey, nil).key).to eq(:mykey)
end
it "should use the name of the provided instance as its key if an instance is provided as the key instead of a string" do
instance = double('instance', :name => "mykey")
request = Puppet::Indirector::Request.new(:ind, :method, nil, instance)
expect(request.key).to eq("mykey")
expect(request.instance).to equal(instance)
end
it "should support options specified as a hash" do
expect { Puppet::Indirector::Request.new(:ind, :method, :key, nil, :one => :two) }.to_not raise_error
end
it "should support nil options" do
expect { Puppet::Indirector::Request.new(:ind, :method, :key, nil, nil) }.to_not raise_error
end
it "should support unspecified options" do
expect { Puppet::Indirector::Request.new(:ind, :method, :key, nil) }.to_not raise_error
end
it "should use an empty options hash if nil was provided" do
expect(Puppet::Indirector::Request.new(:ind, :method, :key, nil, nil).options).to eq({})
end
it "should default to a nil node" do
expect(Puppet::Indirector::Request.new(:ind, :method, :key, nil).node).to be_nil
end
it "should set its node attribute if provided in the options" do
expect(Puppet::Indirector::Request.new(:ind, :method, :key, nil, :node => "foo.com").node).to eq("foo.com")
end
it "should default to a nil ip" do
expect(Puppet::Indirector::Request.new(:ind, :method, :key, nil).ip).to be_nil
end
it "should set its ip attribute if provided in the options" do
expect(Puppet::Indirector::Request.new(:ind, :method, :key, nil, :ip => "192.168.0.1").ip).to eq("192.168.0.1")
end
it "should default to being unauthenticated" do
expect(Puppet::Indirector::Request.new(:ind, :method, :key, nil)).not_to be_authenticated
end
it "should set be marked authenticated if configured in the options" do
expect(Puppet::Indirector::Request.new(:ind, :method, :key, nil, :authenticated => "eh")).to be_authenticated
end
it "should keep its options as a hash even if a node is specified" do
expect(Puppet::Indirector::Request.new(:ind, :method, :key, nil, :node => "eh").options).to be_instance_of(Hash)
end
it "should keep its options as a hash even if another option is specified" do
expect(Puppet::Indirector::Request.new(:ind, :method, :key, nil, :foo => "bar").options).to be_instance_of(Hash)
end
it "should treat options other than :ip, :node, and :authenticated as options rather than attributes" do
expect(Puppet::Indirector::Request.new(:ind, :method, :key, nil, :server => "bar").options[:server]).to eq("bar")
end
it "should normalize options to use symbols as keys" do
expect(Puppet::Indirector::Request.new(:ind, :method, :key, nil, "foo" => "bar").options[:foo]).to eq("bar")
end
describe "and the request key is a URI" do
let(:file) { File.expand_path("/my/file with spaces") }
let(:an_environment) { Puppet::Node::Environment.create(:an_environment, []) }
let(:env_loaders) { Puppet::Environments::Static.new(an_environment) }
around(:each) do |example|
Puppet.override({ :environments => env_loaders }, "Static environment loader for specs") do
example.run
end
end
describe "and the URI is a 'file' URI" do
before do
@request = Puppet::Indirector::Request.new(:ind, :method, "#{Puppet::Util.uri_unescape(Puppet::Util.path_to_uri(file).to_s)}", nil)
end
it "should set the request key to the unescaped full file path" do
expect(@request.key).to eq(file)
end
it "should not set the protocol" do
expect(@request.protocol).to be_nil
end
it "should not set the port" do
expect(@request.port).to be_nil
end
it "should not set the server" do
expect(@request.server).to be_nil
end
end
it "should set the protocol to the URI scheme" do
expect(Puppet::Indirector::Request.new(:ind, :method, "http://host/", nil).protocol).to eq("http")
end
it "should set the server if a server is provided" do
expect(Puppet::Indirector::Request.new(:ind, :method, "http://host/", nil).server).to eq("host")
end
it "should set the server and port if both are provided" do
expect(Puppet::Indirector::Request.new(:ind, :method, "http://host:543/", nil).port).to eq(543)
end
it "should default to the masterport if the URI scheme is 'puppet'" do
Puppet[:masterport] = "321"
expect(Puppet::Indirector::Request.new(:ind, :method, "puppet://host/", nil).port).to eq(321)
end
it "should use the provided port if the URI scheme is not 'puppet'" do
expect(Puppet::Indirector::Request.new(:ind, :method, "http://host/", nil).port).to eq(80)
end
it "should set the request key to the unescaped path from the URI" do
expect(Puppet::Indirector::Request.new(:ind, :method, "http://host/stuff with spaces", nil).key).to eq("stuff with spaces")
end
it "should set the request key to the unescaped path from the URI, in UTF-8 encoding" do
path = "\u4e07"
uri = "http://host/#{path}"
request = Puppet::Indirector::Request.new(:ind, :method, uri, nil)
expect(request.key).to eq(path)
expect(request.key.encoding).to eq(Encoding::UTF_8)
end
it "should set the request key properly given a UTF-8 URI" do
# different UTF-8 widths
# 1-byte A
# 2-byte ۿ - http://www.fileformat.info/info/unicode/char/06ff/index.htm - 0xDB 0xBF / 219 191
# 3-byte ᚠ - http://www.fileformat.info/info/unicode/char/16A0/index.htm - 0xE1 0x9A 0xA0 / 225 154 160
# 4-byte <U+070E> - http://www.fileformat.info/info/unicode/char/2070E/index.htm - 0xF0 0xA0 0x9C 0x8E / 240 160 156 142
mixed_utf8 = "A\u06FF\u16A0\u{2070E}" # Aۿᚠ<U+070E>
key = "a/path/stu ff/#{mixed_utf8}"
req = Puppet::Indirector::Request.new(:ind, :method, "http:///#{key}", nil)
expect(req.key).to eq(key)
expect(req.key.encoding).to eq(Encoding::UTF_8)
expect(req.uri).to eq("http:///#{key}")
end
it "should set the :uri attribute to the full URI" do
expect(Puppet::Indirector::Request.new(:ind, :method, "http:///a/path/stu ff", nil).uri).to eq('http:///a/path/stu ff')
end
it "should not parse relative URI" do
expect(Puppet::Indirector::Request.new(:ind, :method, "foo/bar", nil).uri).to be_nil
end
it "should not parse opaque URI" do
expect(Puppet::Indirector::Request.new(:ind, :method, "mailto:joe", nil).uri).to be_nil
end
end
it "should allow indication that it should not read a cached instance" do
expect(Puppet::Indirector::Request.new(:ind, :method, :key, nil, :ignore_cache => true)).to be_ignore_cache
end
it "should default to not ignoring the cache" do
expect(Puppet::Indirector::Request.new(:ind, :method, :key, nil)).not_to be_ignore_cache
end
it "should allow indication that it should not not read an instance from the terminus" do
expect(Puppet::Indirector::Request.new(:ind, :method, :key, nil, :ignore_terminus => true)).to be_ignore_terminus
end
it "should default to not ignoring the terminus" do
expect(Puppet::Indirector::Request.new(:ind, :method, :key, nil)).not_to be_ignore_terminus
end
end
it "should look use the Indirection class to return the appropriate indirection" do
ind = double('indirection')
expect(Puppet::Indirector::Indirection).to receive(:instance).with(:myind).and_return(ind)
request = Puppet::Indirector::Request.new(:myind, :method, :key, nil)
expect(request.indirection).to equal(ind)
end
it "should use its indirection to look up the appropriate model" do
ind = double('indirection')
expect(Puppet::Indirector::Indirection).to receive(:instance).with(:myind).and_return(ind)
request = Puppet::Indirector::Request.new(:myind, :method, :key, nil)
expect(ind).to receive(:model).and_return("mymodel")
expect(request.model).to eq("mymodel")
end
it "should fail intelligently when asked to find a model but the indirection cannot be found" do
expect(Puppet::Indirector::Indirection).to receive(:instance).with(:myind).and_return(nil)
request = Puppet::Indirector::Request.new(:myind, :method, :key, nil)
expect { request.model }.to raise_error(ArgumentError)
end
it "should have a method for determining if the request is plural or singular" do
expect(Puppet::Indirector::Request.new(:myind, :method, :key, nil)).to respond_to(:plural?)
end
it "should be considered plural if the method is 'search'" do
expect(Puppet::Indirector::Request.new(:myind, :search, :key, nil)).to be_plural
end
it "should not be considered plural if the method is not 'search'" do
expect(Puppet::Indirector::Request.new(:myind, :find, :key, nil)).not_to be_plural
end
it "should use its uri, if it has one, as its description" do
Puppet.override({
:environments => Puppet::Environments::Static.new(
Puppet::Node::Environment.create(:baz, [])
)},
"Static loader for spec") do
expect(Puppet::Indirector::Request.new(:myind, :find, "foo://bar/baz", nil).description).to eq("foo://bar/baz")
end
end
it "should use its indirection name and key, if it has no uri, as its description" do
expect(Puppet::Indirector::Request.new(:myind, :find, "key", nil).description).to eq("/myind/key")
end
it "should set its environment to an environment instance when a string is specified as its environment" do
env = Puppet::Node::Environment.create(:foo, [])
Puppet.override(:environments => Puppet::Environments::Static.new(env)) do
expect(Puppet::Indirector::Request.new(:myind, :find, "my key", nil, :environment => "foo").environment).to eq(env)
end
end
it "should use any passed in environment instances as its environment" do
env = Puppet::Node::Environment.create(:foo, [])
expect(Puppet::Indirector::Request.new(:myind, :find, "my key", nil, :environment => env).environment).to equal(env)
end
it "should use the current environment when none is provided" do
Puppet[:environment] = "foo"
expect(Puppet::Indirector::Request.new(:myind, :find, "my key", nil).environment).to eq(Puppet.lookup(:current_environment))
end
it "should support converting its options to a hash" do
expect(Puppet::Indirector::Request.new(:myind, :find, "my key", nil )).to respond_to(:to_hash)
end
it "should include all of its attributes when its options are converted to a hash" do
expect(Puppet::Indirector::Request.new(:myind, :find, "my key", nil, :node => 'foo').to_hash[:node]).to eq('foo')
end
describe "when building a query string from its options" do
def a_request_with_options(options)
Puppet::Indirector::Request.new(:myind, :find, "my key", nil, options)
end
def the_parsed_query_string_from(request)
CGI.parse(request.query_string.sub(/^\?/, ''))
end
it "should return an empty query string if there are no options" do
request = a_request_with_options(nil)
expect(request.query_string).to eq("")
end
it "should return an empty query string if the options are empty" do
request = a_request_with_options({})
expect(request.query_string).to eq("")
end
it "should include all options in the query string, separated by '&'" do
request = a_request_with_options(:one => "two", :three => "four")
expect(the_parsed_query_string_from(request)).to eq({
"one" => ["two"],
"three" => ["four"]
})
end
it "should ignore nil options" do
request = a_request_with_options(:one => "two", :three => nil)
expect(the_parsed_query_string_from(request)).to eq({
"one" => ["two"]
})
end
it "should convert 'true' option values into strings" do
request = a_request_with_options(:one => true)
expect(the_parsed_query_string_from(request)).to eq({
"one" => ["true"]
})
end
it "should convert 'false' option values into strings" do
request = a_request_with_options(:one => false)
expect(the_parsed_query_string_from(request)).to eq({
"one" => ["false"]
})
end
it "should convert to a string all option values that are integers" do
request = a_request_with_options(:one => 50)
expect(the_parsed_query_string_from(request)).to eq({
"one" => ["50"]
})
end
it "should convert to a string all option values that are floating point numbers" do
request = a_request_with_options(:one => 1.2)
expect(the_parsed_query_string_from(request)).to eq({
"one" => ["1.2"]
})
end
it "should CGI-escape all option values that are strings" do
request = a_request_with_options(:one => "one two")
expect(the_parsed_query_string_from(request)).to eq({
"one" => ["one two"]
})
end
it "should convert an array of values into multiple entries for the same key" do
request = a_request_with_options(:one => %w{one two})
expect(the_parsed_query_string_from(request)).to eq({
"one" => ["one", "two"]
})
end
it "should stringify simple data types inside an array" do
request = a_request_with_options(:one => ['one', nil])
expect(the_parsed_query_string_from(request)).to eq({
"one" => ["one"]
})
end
it "should error if an array contains another array" do
request = a_request_with_options(:one => ['one', ["not allowed"]])
expect { request.query_string }.to raise_error(ArgumentError)
end
it "should error if an array contains illegal data" do
request = a_request_with_options(:one => ['one', { :not => "allowed" }])
expect { request.query_string }.to raise_error(ArgumentError)
end
it "should convert to a string and CGI-escape all option values that are symbols" do
request = a_request_with_options(:one => :"sym bol")
expect(the_parsed_query_string_from(request)).to eq({
"one" => ["sym bol"]
})
end
it "should fail if options other than booleans or strings are provided" do
request = a_request_with_options(:one => { :one => :two })
expect { request.query_string }.to raise_error(ArgumentError)
end
end
context '#do_request' do
before :each do
@request = Puppet::Indirector::Request.new(:myind, :find, "my key", nil)
end
context 'when not using SRV records' do
before :each do
Puppet.settings[:use_srv_records] = false
end
it "yields the request with the default server and port when no server or port were specified on the original request" do
count = 0
rval = @request.do_request(:puppet, 'puppet.example.com', '90210') do |got|
count += 1
expect(got.server).to eq('puppet.example.com')
expect(got.port).to eq('90210')
'Block return value'
end
expect(count).to eq(1)
expect(rval).to eq('Block return value')
end
end
context 'when using SRV records' do
before :each do
Puppet.settings[:use_srv_records] = true
Puppet.settings[:srv_domain] = 'example.com'
end
it "yields the request with the original server and port unmodified" do
@request.server = 'puppet.example.com'
@request.port = '90210'
count = 0
rval = @request.do_request do |got|
count += 1
expect(got.server).to eq('puppet.example.com')
expect(got.port).to eq('90210')
'Block return value'
end
expect(count).to eq(1)
expect(rval).to eq('Block return value')
end
context "when SRV returns servers" do
before :each do
@dns_mock = double('dns')
expect(Resolv::DNS).to receive(:new).and_return(@dns_mock)
@port = 7205
@host = '_x-puppet._tcp.example.com'
@srv_records = [Resolv::DNS::Resource::IN::SRV.new(0, 0, @port, @host)]
expect(@dns_mock).to receive(:getresources).
with("_x-puppet._tcp.#{Puppet.settings[:srv_domain]}", Resolv::DNS::Resource::IN::SRV).
and_return(@srv_records)
end
it "yields a request using the server and port from the SRV record" do
count = 0
rval = @request.do_request do |got|
count += 1
expect(got.server).to eq('_x-puppet._tcp.example.com')
expect(got.port).to eq(7205)
@block_return
end
expect(count).to eq(1)
expect(rval).to eq(@block_return)
end
it "should fall back to the default server when the block raises a SystemCallError" do
count = 0
second_pass = nil
rval = @request.do_request(:puppet, 'puppet', 8140) do |got|
count += 1
if got.server == '_x-puppet._tcp.example.com' then
raise SystemCallError, "example failure"
else
second_pass = got
end
@block_return
end
expect(second_pass.server).to eq('puppet')
expect(second_pass.port).to eq(8140)
expect(count).to eq(2)
expect(rval).to eq(@block_return)
end
end
end
end
describe "#remote?" do
def request(options = {})
Puppet::Indirector::Request.new('node', 'find', 'localhost', nil, options)
end
it "should not be unless node or ip is set" do
expect(request).not_to be_remote
end
it "should be remote if node is set" do
expect(request(:node => 'example.com')).to be_remote
end
it "should be remote if ip is set" do
expect(request(:ip => '127.0.0.1')).to be_remote
end
it "should be remote if node and ip are set" do
expect(request(:node => 'example.com', :ip => '127.0.0.1')).to be_remote
end
end
describe "failover" do
it "should use the provided failover host and port" do
Puppet.override(:server => 'myhost', :serverport => 666) do
req = Puppet::Indirector::Request.new('node', 'find', 'localhost', nil)
req.do_request() do |request|
expect(request.server).to eq('myhost')
expect(request.port).to eq(666)
end
end
end
it "should not use raw settings when failover fails" do
Puppet.override(:server => nil, :serverport => nil) do
req = Puppet::Indirector::Request.new('node', 'find', 'localhost', nil)
req.do_request() do |request|
expect(request.server).to be_nil
expect(request.port).to be_nil
expect(Puppet.settings[:server]).not_to be_nil
expect(Puppet.settings[:masterport]).not_to be_nil
end
end
end
it "should use server_list when set and failover has not occured" do
Puppet.settings[:server_list] = [['myhost',666]]
req = Puppet::Indirector::Request.new('node', 'find', 'localhost', nil)
req.do_request() do |request|
expect(request.server).to eq('myhost')
expect(request.port).to eq(666)
end
end
it "should use server when server_list is not set" do
req = Puppet::Indirector::Request.new('node', 'find', 'localhost', nil)
req.do_request() do |request|
expect(request.server).to eq(Puppet.settings[:server])
expect(request.port).to eq(Puppet.settings[:masterport])
end
end
end
end
|