1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337
|
require 'spec_helper'
require 'puppet/module_tool/applications'
require 'puppet_spec/module_tool/shared_functions'
require 'puppet_spec/module_tool/stub_source'
require 'tmpdir'
describe Puppet::ModuleTool::Applications::Upgrader do
include PuppetSpec::ModuleTool::SharedFunctions
include PuppetSpec::Files
before do
FileUtils.mkdir_p(primary_dir)
FileUtils.mkdir_p(secondary_dir)
end
let(:vardir) { tmpdir('upgrader') }
let(:primary_dir) { File.join(vardir, "primary") }
let(:secondary_dir) { File.join(vardir, "secondary") }
let(:remote_source) { PuppetSpec::ModuleTool::StubSource.new }
let(:environment) do
Puppet.lookup(:current_environment).override_with(
:vardir => vardir,
:modulepath => [ primary_dir, secondary_dir ]
)
end
before do
SemanticPuppet::Dependency.clear_sources
allow_any_instance_of(Puppet::ModuleTool::Applications::Upgrader).to receive(:module_repository).and_return(remote_source)
end
if Puppet.features.microsoft_windows?
before :each do
allow(Puppet.settings).to receive(:[])
allow(Puppet.settings).to receive(:[]).with(:module_working_dir).and_return(Dir.mktmpdir('upgradertmp'))
end
end
def upgrader(name, options = {})
Puppet::ModuleTool.set_option_defaults(options)
Puppet::ModuleTool::Applications::Upgrader.new(name, options)
end
describe '#run' do
let(:module) { 'pmtacceptance-stdlib' }
def options
{ :environment => environment }
end
let(:application) { upgrader(self.module, options) }
subject { application.run }
it 'fails if the module is not already installed' do
expect(subject).to include :result => :failure
expect(subject[:error]).to include :oneline => "Could not upgrade '#{self.module}'; module is not installed"
end
context 'for an installed module' do
context 'with only one version' do
before { preinstall('puppetlabs-oneversion', '0.0.1') }
let(:module) { 'puppetlabs-oneversion' }
it 'declines to upgrade' do
expect(subject).to include :result => :noop
expect(subject[:error][:multiline]).to match(/already the latest version/)
end
end
context 'without dependencies' do
before { preinstall('pmtacceptance-stdlib', '1.0.0') }
context 'without options' do
it 'properly upgrades the module to the greatest version' do
expect(subject).to include :result => :success
graph_should_include 'pmtacceptance-stdlib', v('1.0.0') => v('4.1.0')
end
end
context 'with version range' do
def options
super.merge(:version => '3.x')
end
context 'not matching the installed version' do
it 'properly upgrades the module to the greatest version within that range' do
expect(subject).to include :result => :success
graph_should_include 'pmtacceptance-stdlib', v('1.0.0') => v('3.2.0')
end
end
context 'matching the installed version' do
context 'with more recent version' do
before { preinstall('pmtacceptance-stdlib', '3.0.0')}
it 'properly upgrades the module to the greatest version within that range' do
expect(subject).to include :result => :success
graph_should_include 'pmtacceptance-stdlib', v('3.0.0') => v('3.2.0')
end
end
context 'without more recent version' do
before { preinstall('pmtacceptance-stdlib', '3.2.0')}
context 'without options' do
it 'declines to upgrade' do
expect(subject).to include :result => :noop
expect(subject[:error][:multiline]).to match(/already the latest version/)
end
end
context 'with --force' do
def options
super.merge(:force => true)
end
it 'overwrites the installed module with the greatest version matching that range' do
expect(subject).to include :result => :success
graph_should_include 'pmtacceptance-stdlib', v('3.2.0') => v('3.2.0')
end
end
end
end
end
end
context 'that is depended upon' do
# pmtacceptance-keystone depends on pmtacceptance-mysql >=0.6.1 <1.0.0
before { preinstall('pmtacceptance-keystone', '2.1.0') }
before { preinstall('pmtacceptance-mysql', '0.9.0') }
let(:module) { 'pmtacceptance-mysql' }
context 'and out of date' do
before { preinstall('pmtacceptance-mysql', '0.8.0') }
it 'properly upgrades to the greatest version matching the dependency' do
expect(subject).to include :result => :success
graph_should_include 'pmtacceptance-mysql', v('0.8.0') => v('0.9.0')
end
end
context 'and up to date' do
it 'declines to upgrade' do
expect(subject).to include :result => :failure
end
end
context 'when specifying a violating version range' do
def options
super.merge(:version => '2.1.0')
end
it 'fails to upgrade the module' do
# TODO: More helpful error message?
expect(subject).to include :result => :failure
expect(subject[:error]).to include :oneline => "Could not upgrade '#{self.module}' (v0.9.0 -> v2.1.0); no version satisfies all dependencies"
end
context 'using --force' do
def options
super.merge(:force => true)
end
it 'overwrites the installed module with the specified version' do
expect(subject).to include :result => :success
graph_should_include 'pmtacceptance-mysql', v('0.9.0') => v('2.1.0')
end
end
end
end
context 'with local changes' do
before { preinstall('pmtacceptance-stdlib', '1.0.0') }
before do
release = application.send(:installed_modules)['pmtacceptance-stdlib']
mark_changed(release.mod.path)
end
it 'fails to upgrade' do
expect(subject).to include :result => :failure
expect(subject[:error]).to include :oneline => "Could not upgrade '#{self.module}'; module has had changes made locally"
end
context 'with --ignore-changes' do
def options
super.merge(:ignore_changes => true)
end
it 'overwrites the installed module with the greatest version matching that range' do
expect(subject).to include :result => :success
graph_should_include 'pmtacceptance-stdlib', v('1.0.0') => v('4.1.0')
end
end
end
context 'with dependencies' do
context 'that are unsatisfied' do
def options
super.merge(:version => '0.1.1')
end
before { preinstall('pmtacceptance-apache', '0.0.3') }
let(:module) { 'pmtacceptance-apache' }
it 'upgrades the module and installs the missing dependencies' do
expect(subject).to include :result => :success
graph_should_include 'pmtacceptance-apache', v('0.0.3') => v('0.1.1')
graph_should_include 'pmtacceptance-stdlib', nil => v('4.1.0'), :action => :install
end
end
context 'with older major versions' do
# pmtacceptance-apache 0.0.4 has no dependency on pmtacceptance-stdlib
# the next available version (0.1.1) and all subsequent versions depend on pmtacceptance-stdlib >= 2.2.1
before { preinstall('pmtacceptance-apache', '0.0.3') }
before { preinstall('pmtacceptance-stdlib', '1.0.0') }
let(:module) { 'pmtacceptance-apache' }
it 'refuses to upgrade the installed dependency to a new major version, but upgrades the module to the greatest compatible version' do
expect(subject).to include :result => :success
graph_should_include 'pmtacceptance-apache', v('0.0.3') => v('0.0.4')
end
context 'using --ignore_dependencies' do
def options
super.merge(:ignore_dependencies => true)
end
it 'upgrades the module to the greatest available version' do
expect(subject).to include :result => :success
graph_should_include 'pmtacceptance-apache', v('0.0.3') => v('0.10.0')
end
end
end
context 'with satisfying major versions' do
before { preinstall('pmtacceptance-apache', '0.0.3') }
before { preinstall('pmtacceptance-stdlib', '2.0.0') }
let(:module) { 'pmtacceptance-apache' }
it 'upgrades the module and its dependencies to their greatest compatible versions' do
expect(subject).to include :result => :success
graph_should_include 'pmtacceptance-apache', v('0.0.3') => v('0.10.0')
graph_should_include 'pmtacceptance-stdlib', v('2.0.0') => v('2.6.0')
end
end
context 'with satisfying versions' do
before { preinstall('pmtacceptance-apache', '0.0.3') }
before { preinstall('pmtacceptance-stdlib', '2.4.0') }
let(:module) { 'pmtacceptance-apache' }
it 'upgrades the module to the greatest available version' do
expect(subject).to include :result => :success
graph_should_include 'pmtacceptance-apache', v('0.0.3') => v('0.10.0')
graph_should_include 'pmtacceptance-stdlib', nil
end
end
context 'with current versions' do
before { preinstall('pmtacceptance-apache', '0.0.3') }
before { preinstall('pmtacceptance-stdlib', '2.6.0') }
let(:module) { 'pmtacceptance-apache' }
it 'upgrades the module to the greatest available version' do
expect(subject).to include :result => :success
graph_should_include 'pmtacceptance-apache', v('0.0.3') => v('0.10.0')
graph_should_include 'pmtacceptance-stdlib', nil
end
end
context 'with shared dependencies' do
# bacula 0.0.3 depends on stdlib >= 2.2.0 and pmtacceptance/mysql >= 1.0.0
# bacula 0.0.2 depends on stdlib >= 2.2.0 and pmtacceptance/mysql >= 0.0.1
# bacula 0.0.1 depends on stdlib >= 2.2.0
# keystone 2.1.0 depends on pmtacceptance/stdlib >= 2.5.0 and pmtacceptance/mysql >=0.6.1 <1.0.0
before { preinstall('pmtacceptance-bacula', '0.0.1') }
before { preinstall('pmtacceptance-mysql', '0.9.0') }
before { preinstall('pmtacceptance-keystone', '2.1.0') }
let(:module) { 'pmtacceptance-bacula' }
it 'upgrades the module to the greatest version compatible with all other installed modules' do
expect(subject).to include :result => :success
graph_should_include 'pmtacceptance-bacula', v('0.0.1') => v('0.0.2')
end
context 'using --force' do
def options
super.merge(:force => true)
end
it 'upgrades the module to the greatest version available' do
expect(subject).to include :result => :success
graph_should_include 'pmtacceptance-bacula', v('0.0.1') => v('0.0.3')
end
end
end
context 'in other modulepath directories' do
before { preinstall('pmtacceptance-apache', '0.0.3') }
before { preinstall('pmtacceptance-stdlib', '1.0.0', :into => secondary_dir) }
let(:module) { 'pmtacceptance-apache' }
context 'with older major versions' do
it 'upgrades the module to the greatest version compatible with the installed modules' do
expect(subject).to include :result => :success
graph_should_include 'pmtacceptance-apache', v('0.0.3') => v('0.0.4')
graph_should_include 'pmtacceptance-stdlib', nil
end
end
context 'with satisfying major versions' do
before { preinstall('pmtacceptance-stdlib', '2.0.0', :into => secondary_dir) }
it 'upgrades the module and its dependencies to their greatest compatible versions, in-place' do
expect(subject).to include :result => :success
graph_should_include 'pmtacceptance-apache', v('0.0.3') => v('0.10.0')
graph_should_include 'pmtacceptance-stdlib', v('2.0.0') => v('2.6.0'), :path => secondary_dir
end
end
end
end
end
context 'when in FIPS mode...' do
it 'module unpgrader refuses to run' do
allow(Facter).to receive(:value).with(:fips_enabled).and_return(true)
expect { application.run }.to raise_error(/Module upgrade is prohibited in FIPS mode/)
end
end
end
end
|