1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477
|
require 'spec_helper'
require 'matchers/json'
require 'puppet_spec/files'
describe Puppet::Node do
include JSONMatchers
include PuppetSpec::Files
let(:environment) { Puppet::Node::Environment.create(:bar, []) }
let(:env_loader) { Puppet::Environments::Static.new(environment) }
describe "when managing its environment" do
it "provides an environment instance" do
expect(Puppet::Node.new("foo", :environment => environment).environment.name).to eq(:bar)
end
context "present in a loader" do
around do |example|
Puppet.override(:environments => env_loader) do
example.run
end
end
it "uses any set environment" do
expect(Puppet::Node.new("foo", :environment => "bar").environment).to eq(environment)
end
it "determines its environment from its parameters if no environment is set" do
expect(Puppet::Node.new("foo", :parameters => {"environment" => :bar}).environment).to eq(environment)
end
it "uses the configured environment if no environment is provided" do
Puppet[:environment] = environment.name.to_s
expect(Puppet::Node.new("foo").environment).to eq(environment)
end
it "allows the environment to be set after initialization" do
node = Puppet::Node.new("foo")
node.environment = :bar
expect(node.environment.name).to eq(:bar)
end
it "allows its environment to be set by parameters after initialization" do
node = Puppet::Node.new("foo")
node.parameters["environment"] = :bar
expect(node.environment.name).to eq(:bar)
end
end
end
describe "serialization" do
around do |example|
Puppet.override(:environments => env_loader) do
example.run
end
end
it "can round-trip through json" do
Puppet::Node::Facts.new("hello", "one" => "c", "two" => "b")
node = Puppet::Node.new("hello",
:environment => 'bar',
:classes => ['erth', 'aiu'],
:parameters => {"hostname"=>"food"}
)
new_node = Puppet::Node.convert_from('json', node.render('json'))
expect(new_node.environment).to eq(node.environment)
expect(new_node.parameters).to eq(node.parameters)
expect(new_node.classes).to eq(node.classes)
expect(new_node.name).to eq(node.name)
end
it "validates against the node json schema", :unless => Puppet.features.microsoft_windows? do
Puppet::Node::Facts.new("hello", "one" => "c", "two" => "b")
node = Puppet::Node.new("hello",
:environment => 'bar',
:classes => ['erth', 'aiu'],
:parameters => {"hostname"=>"food"}
)
expect(node.to_json).to validate_against('api/schemas/node.json')
end
it "when missing optional parameters validates against the node json schema", :unless => Puppet.features.microsoft_windows? do
Puppet::Node::Facts.new("hello", "one" => "c", "two" => "b")
node = Puppet::Node.new("hello",
:environment => 'bar'
)
expect(node.to_json).to validate_against('api/schemas/node.json')
end
it "should allow its environment parameter to be set by attribute after initialization" do
node = Puppet::Node.new("foo", { :parameters => { 'environment' => :foo } })
node.environment_name = :foo
node.environment = :bar
expect(node.environment_name).to eq(:bar)
expect(node.parameters['environment']).to eq('bar')
end
it 'to_data_hash returns value that is instance of to Data' do
node = Puppet::Node.new("hello",
:environment => 'bar',
:classes => ['erth', 'aiu'],
:parameters => {"hostname"=>"food"}
)
expect(Puppet::Pops::Types::TypeFactory.data.instance?(node.to_data_hash)).to be_truthy
end
end
describe "when serializing using yaml" do
before do
@node = Puppet::Node.new("mynode")
end
it "a node can roundtrip" do
expect(YAML.load(@node.to_yaml).name).to eql("mynode")
end
it "limits the serialization of environment to be just the name" do
yaml_file = file_containing("temp_yaml", @node.to_yaml)
node_yaml = Puppet::Util::Yaml.load_file(yaml_file, false, true)
expect(node_yaml['environment']).to eq('production')
end
end
describe "when serializing using yaml and values classes and parameters are missing in deserialized hash" do
it "a node can roundtrip" do
@node = Puppet::Node.from_data_hash({'name' => "mynode"})
expect(YAML.load(@node.to_yaml).name).to eql("mynode")
end
it "errors if name is nil" do
expect { Puppet::Node.from_data_hash({ })}.to raise_error(ArgumentError, /No name provided in serialized data/)
end
end
describe "when converting to json" do
before do
@node = Puppet::Node.new("mynode")
end
it "provide its name" do
expect(@node).to set_json_attribute('name').to("mynode")
end
it "includes the classes if set" do
@node.classes = %w{a b c}
expect(@node).to set_json_attribute("classes").to(%w{a b c})
end
it "does not include the classes if there are none" do
expect(@node).to_not set_json_attribute('classes')
end
it "includes parameters if set" do
@node.parameters = {"a" => "b", "c" => "d"}
expect(@node).to set_json_attribute('parameters').to({"a" => "b", "c" => "d"})
end
it "does not include the environment parameter in the json" do
@node.parameters = {"a" => "b", "c" => "d"}
@node.environment = environment
expect(@node.parameters).to eq({"a"=>"b", "c"=>"d", "environment"=>"bar"})
expect(@node).to set_json_attribute('parameters').to({"a" => "b", "c" => "d"})
end
it "does not include the parameters if there are none" do
expect(@node).to_not set_json_attribute('parameters')
end
it "includes the environment" do
@node.environment = "production"
expect(@node).to set_json_attribute('environment').to('production')
end
end
describe "when converting from json" do
before do
@node = Puppet::Node.new("mynode")
@format = Puppet::Network::FormatHandler.format('json')
end
def from_json(json)
@format.intern(Puppet::Node, json)
end
it "sets its name" do
expect(Puppet::Node).to read_json_attribute('name').from(@node.to_json).as("mynode")
end
it "includes the classes if set" do
@node.classes = %w{a b c}
expect(Puppet::Node).to read_json_attribute('classes').from(@node.to_json).as(%w{a b c})
end
it "includes parameters if set" do
@node.parameters = {"a" => "b", "c" => "d"}
expect(Puppet::Node).to read_json_attribute('parameters').from(@node.to_json).as({"a" => "b", "c" => "d", "environment" => "production"})
end
it "deserializes environment to environment_name as a symbol" do
Puppet.override(:environments => env_loader) do
@node.environment = environment
expect(Puppet::Node).to read_json_attribute('environment_name').from(@node.to_json).as(:bar)
end
end
it "does not immediately populate the environment instance" do
node = described_class.from_data_hash("name" => "foo", "environment" => "production")
expect(node.environment_name).to eq(:production)
expect(node).not_to be_has_environment_instance
node.environment
expect(node).to be_has_environment_instance
end
end
end
describe Puppet::Node, "when initializing" do
before do
@node = Puppet::Node.new("testnode")
end
it "sets the node name" do
expect(@node.name).to eq("testnode")
end
it "does not allow nil node names" do
expect { Puppet::Node.new(nil) }.to raise_error(ArgumentError)
end
it "defaults to an empty parameter hash" do
expect(@node.parameters).to eq({})
end
it "defaults to an empty class array" do
expect(@node.classes).to eq([])
end
it "notes its creation time" do
expect(@node.time).to be_instance_of(Time)
end
it "accepts parameters passed in during initialization" do
params = {"a" => "b"}
@node = Puppet::Node.new("testing", :parameters => params)
expect(@node.parameters).to eq(params)
end
it "accepts classes passed in during initialization" do
classes = %w{one two}
@node = Puppet::Node.new("testing", :classes => classes)
expect(@node.classes).to eq(classes)
end
it "always returns classes as an array" do
@node = Puppet::Node.new("testing", :classes => "myclass")
expect(@node.classes).to eq(["myclass"])
end
end
describe Puppet::Node, "when merging facts" do
before do
@node = Puppet::Node.new("testnode")
Puppet[:facts_terminus] = :memory
Puppet::Node::Facts.indirection.save(Puppet::Node::Facts.new(@node.name, "one" => "c", "two" => "b"))
end
context "when supplied facts as a parameter" do
let(:facts) { Puppet::Node::Facts.new(@node.name, "foo" => "bar") }
it "accepts facts to merge with the node" do
expect(@node).to receive(:merge).with({ 'foo' => 'bar' })
@node.fact_merge(facts)
end
it "will not query the facts indirection if facts are supplied" do
expect(Puppet::Node::Facts.indirection).not_to receive(:find)
@node.fact_merge(facts)
end
end
it "recovers with a Puppet::Error if something is thrown from the facts indirection" do
expect(Puppet::Node::Facts.indirection).to receive(:find).and_raise("something bad happened in the indirector")
expect { @node.fact_merge }.to raise_error(Puppet::Error, /Could not retrieve facts for testnode: something bad happened in the indirector/)
end
it "prefers parameters already set on the node over facts from the node" do
@node = Puppet::Node.new("testnode", :parameters => {"one" => "a"})
@node.fact_merge
expect(@node.parameters["one"]).to eq("a")
end
it "adds passed parameters to the parameter list" do
@node = Puppet::Node.new("testnode", :parameters => {"one" => "a"})
@node.fact_merge
expect(@node.parameters["two"]).to eq("b")
end
it "warns when a parameter value is not updated" do
@node = Puppet::Node.new("testnode", :parameters => {"one" => "a"})
expect(Puppet).to receive(:warning).with('The node parameter \'one\' for node \'testnode\' was already set to \'a\'. It could not be set to \'b\'')
@node.merge "one" => "b"
end
it "accepts arbitrary parameters to merge into its parameters" do
@node = Puppet::Node.new("testnode", :parameters => {"one" => "a"})
@node.merge "two" => "three"
expect(@node.parameters["two"]).to eq("three")
end
context "with an env loader" do
let(:environment) { Puppet::Node::Environment.create(:one, []) }
let(:environment_two) { Puppet::Node::Environment.create(:two, []) }
let(:environment_three) { Puppet::Node::Environment.create(:three, []) }
let(:environment_prod) { Puppet::Node::Environment.create(:production, []) }
let(:env_loader) { Puppet::Environments::Static.new(environment, environment_two, environment_three, environment_prod) }
around do |example|
Puppet.override(:environments => env_loader) do
example.run
end
end
context "when a node is initialized from a data hash" do
context "when a node is initialzed with an environment" do
it "uses 'environment' when provided" do
my_node = Puppet::Node.from_data_hash("environment" => "one", "name" => "my_node")
expect(my_node.environment.name).to eq(:one)
end
it "uses the environment parameter when provided" do
my_node = Puppet::Node.from_data_hash("parameters" => {"environment" => "one"}, "name" => "my_node")
expect(my_node.environment.name).to eq(:one)
end
it "uses the environment when also given an environment parameter" do
my_node = Puppet::Node.from_data_hash("parameters" => {"environment" => "one"}, "name" => "my_node", "environment" => "two")
expect(my_node.environment.name).to eq(:two)
end
it "uses 'environment' when an environment fact has been merged" do
my_node = Puppet::Node.from_data_hash("environment" => "one", "name" => "my_node")
my_node.fact_merge Puppet::Node::Facts.new "my_node", "environment" => "two"
expect(my_node.environment.name).to eq(:one)
end
it "uses an environment parameter when an environment fact has been merged" do
my_node = Puppet::Node.from_data_hash("parameters" => {"environment" => "one"}, "name" => "my_node")
my_node.fact_merge Puppet::Node::Facts.new "my_node", "environment" => "two"
expect(my_node.environment.name).to eq(:one)
end
it "uses an environment when an environment parameter has been given and an environment fact has been merged" do
my_node = Puppet::Node.from_data_hash("parameters" => {"environment" => "two"}, "name" => "my_node", "environment" => "one")
my_node.fact_merge Puppet::Node::Facts.new "my_node", "environment" => "three"
expect(my_node.environment.name).to eq(:one)
end
end
context "when a node is initialized without an environment" do
it "should use the server's default environment" do
my_node = Puppet::Node.from_data_hash("name" => "my_node")
expect(my_node.environment.name).to eq(:production)
end
it "should use the server's default when an environment fact has been merged" do
my_node = Puppet::Node.from_data_hash("name" => "my_node")
my_node.fact_merge Puppet::Node::Facts.new "my_node", "environment" => "two"
expect(my_node.environment.name).to eq(:production)
end
end
end
context "when a node is initialized from new" do
context "when a node is initialzed with an environment" do
it "adds the environment to the list of parameters" do
Puppet[:environment] = "one"
@node = Puppet::Node.new("testnode", :environment => "one")
@node.merge "two" => "three"
expect(@node.parameters["environment"]).to eq("one")
end
it "when merging, syncs the environment parameter to a node's existing environment" do
@node = Puppet::Node.new("testnode", :environment => "one")
@node.merge "environment" => "two"
expect(@node.parameters["environment"]).to eq("one")
end
it "merging facts does not override that environment" do
@node = Puppet::Node.new("testnode", :environment => "one")
@node.fact_merge Puppet::Node::Facts.new "testnode", "environment" => "two"
expect(@node.environment.name.to_s).to eq("one")
end
end
context "when a node is initialized without an environment" do
it "it perfers an environment name to an environment fact" do
@node = Puppet::Node.new("testnode")
@node.environment_name = "one"
@node.fact_merge Puppet::Node::Facts.new "testnode", "environment" => "two"
expect(@node.environment.name.to_s).to eq("one")
end
end
end
end
end
describe Puppet::Node, "when indirecting" do
it "defaults to the 'plain' node terminus" do
Puppet::Node.indirection.reset_terminus_class
expect(Puppet::Node.indirection.terminus_class).to eq(:plain)
end
end
describe Puppet::Node, "when generating the list of names to search through" do
before do
Puppet[:strict_hostname_checking] = false
@node = Puppet::Node.new("foo.domain.com",
:parameters => {"hostname" => "yay", "domain" => "domain.com"})
end
it "returns an array of names" do
expect(@node.names).to be_instance_of(Array)
end
describe "and the node name is fully qualified" do
it "contains an entry for each part of the node name" do
expect(@node.names).to include("foo.domain.com")
expect(@node.names).to include("foo.domain")
expect(@node.names).to include("foo")
end
end
it "includes the node's fqdn" do
expect(@node.names).to include("yay.domain.com")
end
it "combines and include the node's hostname and domain if no fqdn is available" do
expect(@node.names).to include("yay.domain.com")
end
it "contains an entry for each name available by stripping a segment of the fqdn" do
@node.parameters["fqdn"] = "foo.deep.sub.domain.com"
expect(@node.names).to include("foo.deep.sub.domain")
expect(@node.names).to include("foo.deep.sub")
end
describe "and :node_name is set to 'cert'" do
before do
Puppet[:node_name] = "cert"
end
it "uses the passed-in key as the first value" do
expect(@node.names[0]).to eq("foo.domain.com")
end
describe "and strict hostname checking is enabled" do
before do
Puppet[:strict_hostname_checking] = true
end
it "only uses the passed-in key" do
expect(@node.names).to eq(["foo.domain.com"])
end
end
end
describe "and :node_name is set to 'facter'" do
before do
Puppet[:node_name] = "facter"
end
it "uses the node's 'hostname' fact as the first value" do
expect(@node.names[0]).to eq("yay")
end
end
end
|