1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770
|
require 'spec_helper'
def existing_command
Puppet.features.microsoft_windows? ? "cmd" : "echo"
end
describe Puppet::Provider do
before :each do
Puppet::Type.newtype(:test) do
newparam(:name) { isnamevar }
end
end
after :each do
Puppet::Type.rmtype(:test)
end
let :type do Puppet::Type.type(:test) end
let :provider do type.provide(:default) {} end
subject { provider }
describe "has command" do
it "installs a method to run the command specified by the path" do
echo_command = expect_command_executed(:echo, "/bin/echo", "an argument")
allow_creation_of(echo_command)
provider = provider_of do
has_command(:echo, "/bin/echo")
end
provider.echo("an argument")
end
it "installs a command that is run with a given environment" do
echo_command = expect_command_executed(:echo, "/bin/echo", "an argument")
allow_creation_of(echo_command, {
:EV => "value",
:OTHER => "different"
})
provider = provider_of do
has_command(:echo, "/bin/echo") do
environment :EV => "value", :OTHER => "different"
end
end
provider.echo("an argument")
end
it "is required by default" do
provider = provider_of do
has_command(:does_not_exist, "/does/not/exist")
end
expect(provider).not_to be_suitable
end
it "is required by default" do
provider = provider_of do
has_command(:does_exist, File.expand_path("/exists/somewhere"))
end
file_exists_and_is_executable(File.expand_path("/exists/somewhere"))
expect(provider).to be_suitable
end
it "can be specified as optional" do
provider = provider_of do
has_command(:does_not_exist, "/does/not/exist") do
is_optional
end
end
expect(provider).to be_suitable
end
end
describe "has required commands" do
it "installs methods to run executables by path" do
echo_command = expect_command_executed(:echo, "/bin/echo", "an argument")
ls_command = expect_command_executed(:ls, "/bin/ls")
allow_creation_of(echo_command)
allow_creation_of(ls_command)
provider = provider_of do
commands :echo => "/bin/echo", :ls => "/bin/ls"
end
provider.echo("an argument")
provider.ls
end
it "allows the provider to be suitable if the executable is present" do
provider = provider_of do
commands :always_exists => File.expand_path("/this/command/exists")
end
file_exists_and_is_executable(File.expand_path("/this/command/exists"))
expect(provider).to be_suitable
end
it "does not allow the provider to be suitable if the executable is not present" do
provider = provider_of do
commands :does_not_exist => "/this/command/does/not/exist"
end
expect(provider).not_to be_suitable
end
end
describe "has optional commands" do
it "installs methods to run executables" do
echo_command = expect_command_executed(:echo, "/bin/echo", "an argument")
ls_command = expect_command_executed(:ls, "/bin/ls")
allow_creation_of(echo_command)
allow_creation_of(ls_command)
provider = provider_of do
optional_commands :echo => "/bin/echo", :ls => "/bin/ls"
end
provider.echo("an argument")
provider.ls
end
it "allows the provider to be suitable even if the executable is not present" do
provider = provider_of do
optional_commands :does_not_exist => "/this/command/does/not/exist"
end
expect(provider).to be_suitable
end
end
it "should have a specifity class method" do
expect(Puppet::Provider).to respond_to(:specificity)
end
it "should be Comparable" do
res = Puppet::Type.type(:notify).new(:name => "res")
# Normally I wouldn't like the stubs, but the only way to name a class
# otherwise is to assign it to a constant, and that hurts more here in
# testing world. --daniel 2012-01-29
a = Class.new(Puppet::Provider).new(res)
allow(a.class).to receive(:name).and_return("Puppet::Provider::Notify::A")
b = Class.new(Puppet::Provider).new(res)
allow(b.class).to receive(:name).and_return("Puppet::Provider::Notify::B")
c = Class.new(Puppet::Provider).new(res)
allow(c.class).to receive(:name).and_return("Puppet::Provider::Notify::C")
[[a, b, c], [a, c, b], [b, a, c], [b, c, a], [c, a, b], [c, b, a]].each do |this|
expect(this.sort).to eq([a, b, c])
end
expect(a).to be < b
expect(a).to be < c
expect(b).to be > a
expect(b).to be < c
expect(c).to be > a
expect(c).to be > b
[a, b, c].each {|x| expect(a).to be <= x }
[a, b, c].each {|x| expect(c).to be >= x }
expect(b).to be_between(a, c)
end
context "when creating instances" do
context "with a resource" do
let :resource do type.new(:name => "fred") end
subject { provider.new(resource) }
it "should set the resource correctly" do
expect(subject.resource).to equal resource
end
it "should set the name from the resource" do
expect(subject.name).to eq(resource.name)
end
end
context "with a hash" do
subject { provider.new(:name => "fred") }
it "should set the name" do
expect(subject.name).to eq("fred")
end
it "should not have a resource" do expect(subject.resource).to be_nil end
end
context "with no arguments" do
subject { provider.new }
it "should raise an internal error if asked for the name" do
expect { subject.name }.to raise_error Puppet::DevError
end
it "should not have a resource" do expect(subject.resource).to be_nil end
end
end
context "when confining" do
it "should be suitable by default" do
expect(subject).to be_suitable
end
it "should not be default by default" do
expect(subject).not_to be_default
end
{ { :true => true } => true,
{ :true => false } => false,
{ :false => false } => true,
{ :false => true } => false,
{ :operatingsystem => Facter.value(:operatingsystem) } => true,
{ :operatingsystem => :yayness } => false,
{ :nothing => :yayness } => false,
{ :exists => Puppet::Util.which(existing_command) } => true,
{ :exists => "/this/file/does/not/exist" } => false,
{ :true => true, :exists => Puppet::Util.which(existing_command) } => true,
{ :true => true, :exists => "/this/file/does/not/exist" } => false,
{ :operatingsystem => Facter.value(:operatingsystem),
:exists => Puppet::Util.which(existing_command) } => true,
{ :operatingsystem => :yayness,
:exists => Puppet::Util.which(existing_command) } => false,
{ :operatingsystem => Facter.value(:operatingsystem),
:exists => "/this/file/does/not/exist" } => false,
{ :operatingsystem => :yayness,
:exists => "/this/file/does/not/exist" } => false,
}.each do |confines, result|
it "should confine #{confines.inspect} to #{result}" do
confines.each {|test, value| subject.confine test => value }
if result
expect(subject).to be_suitable
else
expect(subject).to_not be_suitable
end
end
end
it "should not override a confine even if a second has the same type" do
subject.confine :true => false
expect(subject).not_to be_suitable
subject.confine :true => true
expect(subject).not_to be_suitable
end
it "should not be suitable if any confine fails" do
subject.confine :true => false
expect(subject).not_to be_suitable
10.times do
subject.confine :true => true
expect(subject).not_to be_suitable
end
end
end
context "default providers" do
let :os do Facter.value(:operatingsystem) end
it { is_expected.to respond_to :specificity }
it "should find the default provider" do
type.provide(:nondefault) {}
subject.defaultfor :operatingsystem => os
expect(subject.name).to eq(type.defaultprovider.name)
end
describe "regex matches" do
it "should match a singular regex" do
expect(Facter).to receive(:value).with(:osfamily).at_least(:once).and_return("solaris")
one = type.provide(:one) do
defaultfor :osfamily => /solaris/
end
expect(one).to be_default
end
it "should not match a non-matching regex " do
expect(Facter).to receive(:value).with(:osfamily).at_least(:once).and_return("redhat")
one = type.provide(:one) do
defaultfor :osfamily => /solaris/
end
expect(one).to_not be_default
end
it "should allow a mix of regex and string" do
expect(Facter).to receive(:value).with(:operatingsystem).at_least(:once).and_return("fedora")
expect(Facter).to receive(:value).with(:operatingsystemmajrelease).at_least(:once).and_return("24")
one = type.provide(:one) do
defaultfor :operatingsystem => "fedora", :operatingsystemmajrelease => /^2[2-9]$/
end
two = type.provide(:two) do
defaultfor :operatingsystem => /fedora/, :operatingsystemmajrelease => '24'
end
expect(one).to be_default
expect(two).to be_default
end
end
describe "when there are multiple defaultfor's of equal specificity" do
before :each do
subject.defaultfor :operatingsystem => :os1
subject.defaultfor :operatingsystem => :os2
end
let(:alternate) { type.provide(:alternate) {} }
it "should be default for the first defaultfor" do
expect(Facter).to receive(:value).with(:operatingsystem).at_least(:once).and_return(:os1)
expect(provider).to be_default
expect(alternate).not_to be_default
end
it "should be default for the last defaultfor" do
expect(Facter).to receive(:value).with(:operatingsystem).at_least(:once).and_return(:os2)
expect(provider).to be_default
expect(alternate).not_to be_default
end
end
describe "when there are multiple defaultfor's with different specificity" do
before :each do
subject.defaultfor :operatingsystem => :os1
subject.defaultfor :operatingsystem => :os2, :operatingsystemmajrelease => "42"
subject.defaultfor :operatingsystem => :os3, :operatingsystemmajrelease => /^4[2-9]$/
end
let(:alternate) { type.provide(:alternate) {} }
it "should be default for a more specific, but matching, defaultfor" do
expect(Facter).to receive(:value).with(:operatingsystem).at_least(:once).and_return(:os2)
expect(Facter).to receive(:value).with(:operatingsystemmajrelease).at_least(:once).and_return("42")
expect(provider).to be_default
expect(alternate).not_to be_default
end
it "should be default for a more specific, but matching, defaultfor with regex" do
expect(Facter).to receive(:value).with(:operatingsystem).at_least(:once).and_return(:os3)
expect(Facter).to receive(:value).with(:operatingsystemmajrelease).at_least(:once).and_return("42")
expect(provider).to be_default
expect(alternate).not_to be_default
end
it "should be default for a less specific, but matching, defaultfor" do
expect(Facter).to receive(:value).with(:operatingsystem).at_least(:once).and_return(:os1)
expect(provider).to be_default
expect(alternate).not_to be_default
end
end
it "should consider any true value enough to be default" do
alternate = type.provide(:alternate) {}
subject.defaultfor :operatingsystem => [:one, :two, :three, os]
expect(subject.name).to eq(type.defaultprovider.name)
expect(subject).to be_default
expect(alternate).not_to be_default
end
it "should not be default if the defaultfor doesn't match" do
expect(subject).not_to be_default
subject.defaultfor :operatingsystem => :one
expect(subject).not_to be_default
end
it "should consider two defaults to be higher specificity than one default" do
expect(Facter).to receive(:value).with(:osfamily).at_least(:once).and_return("solaris")
expect(Facter).to receive(:value).with(:operatingsystemrelease).at_least(:once).and_return("5.10")
one = type.provide(:one) do
defaultfor :osfamily => "solaris"
end
two = type.provide(:two) do
defaultfor :osfamily => "solaris", :operatingsystemrelease => "5.10"
end
expect(two.specificity).to be > one.specificity
end
it "should consider a subclass more specific than its parent class" do
parent = type.provide(:parent)
child = type.provide(:child, :parent => parent)
expect(child.specificity).to be > parent.specificity
end
describe "using a :feature key" do
before :each do
Puppet.features.add(:yay) do true end
Puppet.features.add(:boo) do false end
end
it "is default for an available feature" do
one = type.provide(:one) do
defaultfor :feature => :yay
end
expect(one).to be_default
end
it "is not default for a missing feature" do
two = type.provide(:two) do
defaultfor :feature => :boo
end
expect(two).not_to be_default
end
end
end
context "provider commands" do
it "should raise for unknown commands" do
expect { subject.command(:something) }.to raise_error(Puppet::DevError)
end
it "should handle command inheritance" do
parent = type.provide("parent")
child = type.provide("child", :parent => parent.name)
command = Puppet::Util.which('sh') || Puppet::Util.which('cmd.exe')
parent.commands :sh => command
expect(Puppet::FileSystem.exist?(parent.command(:sh))).to be_truthy
expect(parent.command(:sh)).to match(/#{Regexp.escape(command)}$/)
expect(Puppet::FileSystem.exist?(child.command(:sh))).to be_truthy
expect(child.command(:sh)).to match(/#{Regexp.escape(command)}$/)
end
it "#1197: should find commands added in the same run" do
subject.commands :testing => "puppet-bug-1197"
expect(subject.command(:testing)).to be_nil
allow(subject).to receive(:which).with("puppet-bug-1197").and_return("/puppet-bug-1197")
expect(subject.command(:testing)).to eq("/puppet-bug-1197")
# Ideally, we would also test that `suitable?` returned the right thing
# here, but it is impossible to get access to the methods that do that
# without digging way down into the implementation. --daniel 2012-03-20
end
context "with optional commands" do
before :each do
subject.optional_commands :cmd => "/no/such/binary/exists"
end
it { is_expected.to be_suitable }
it "should not be suitable if a mandatory command is also missing" do
subject.commands :foo => "/no/such/binary/either"
expect(subject).not_to be_suitable
end
it "should define a wrapper for the command" do
expect(subject).to respond_to(:cmd)
end
it "should return nil if the command is requested" do
expect(subject.command(:cmd)).to be_nil
end
it "should raise if the command is invoked" do
expect { subject.cmd }.to raise_error(Puppet::Error, /Command cmd is missing/)
end
end
end
context "execution" do
before :each do
expect(Puppet).not_to receive(:deprecation_warning)
end
it "delegates instance execute to Puppet::Util::Execution" do
expect(Puppet::Util::Execution).to receive(:execute).with("a_command", { :option => "value" })
provider.new.send(:execute, "a_command", { :option => "value" })
end
it "delegates class execute to Puppet::Util::Execution" do
expect(Puppet::Util::Execution).to receive(:execute).with("a_command", { :option => "value" })
provider.send(:execute, "a_command", { :option => "value" })
end
it "delegates instance execpipe to Puppet::Util::Execution" do
block = Proc.new { }
expect(Puppet::Util::Execution).to receive(:execpipe).with("a_command", true, block)
provider.new.send(:execpipe, "a_command", true, block)
end
it "delegates class execpipe to Puppet::Util::Execution" do
block = Proc.new { }
expect(Puppet::Util::Execution).to receive(:execpipe).with("a_command", true, block)
provider.send(:execpipe, "a_command", true, block)
end
it "delegates instance execfail to Puppet::Util::Execution" do
expect(Puppet::Util::Execution).to receive(:execfail).with("a_command", "an exception to raise")
provider.new.send(:execfail, "a_command", "an exception to raise")
end
it "delegates class execfail to Puppet::Util::Execution" do
expect(Puppet::Util::Execution).to receive(:execfail).with("a_command", "an exception to raise")
provider.send(:execfail, "a_command", "an exception to raise")
end
end
context "mk_resource_methods" do
before :each do
type.newproperty(:prop)
type.newparam(:param)
provider.mk_resource_methods
end
let(:instance) { provider.new(nil) }
it "defaults to :absent" do
expect(instance.prop).to eq(:absent)
expect(instance.param).to eq(:absent)
end
it "should update when set" do
instance.prop = 'hello'
instance.param = 'goodbye'
expect(instance.prop).to eq('hello')
expect(instance.param).to eq('goodbye')
end
it "treats nil the same as absent" do
instance.prop = "value"
instance.param = "value"
instance.prop = nil
instance.param = nil
expect(instance.prop).to eq(:absent)
expect(instance.param).to eq(:absent)
end
it "preserves false as false" do
instance.prop = false
instance.param = false
expect(instance.prop).to eq(false)
expect(instance.param).to eq(false)
end
end
context "source" do
it "should default to the provider name" do
expect(subject.source).to eq(:default)
end
it "should default to the provider name for a child provider" do
expect(type.provide(:sub, :parent => subject.name).source).to eq(:sub)
end
it "should override if requested" do
provider = type.provide(:sub, :parent => subject.name, :source => subject.source)
expect(provider.source).to eq(subject.source)
end
it "should override to anything you want" do
expect { subject.source = :banana }.to change { subject.source }.
from(:default).to(:banana)
end
end
context "features" do
before :each do
type.feature :numeric, '', :methods => [:one, :two]
type.feature :alpha, '', :methods => [:a, :b]
type.feature :nomethods, ''
end
{ :no => { :alpha => false, :numeric => false, :methods => [] },
:numeric => { :alpha => false, :numeric => true, :methods => [:one, :two] },
:alpha => { :alpha => true, :numeric => false, :methods => [:a, :b] },
:all => {
:alpha => true, :numeric => true,
:methods => [:a, :b, :one, :two]
},
:alpha_and_partial => {
:alpha => true, :numeric => false,
:methods => [:a, :b, :one]
},
:numeric_and_partial => {
:alpha => false, :numeric => true,
:methods => [:a, :one, :two]
},
:all_partial => { :alpha => false, :numeric => false, :methods => [:a, :one] },
:other_and_none => { :alpha => false, :numeric => false, :methods => [:foo, :bar] },
:other_and_alpha => {
:alpha => true, :numeric => false,
:methods => [:foo, :bar, :a, :b]
},
}.each do |name, setup|
context "with #{name.to_s.gsub('_', ' ')} features" do
let :provider do
provider = type.provide(name)
setup[:methods].map do |method|
provider.send(:define_method, method) do true end
end
type.provider(name)
end
context "provider class" do
subject { provider }
it { is_expected.to respond_to(:has_features) }
it { is_expected.to respond_to(:has_feature) }
it { is_expected.to respond_to(:nomethods?) }
it { is_expected.not_to be_nomethods }
it { is_expected.to respond_to(:numeric?) }
if setup[:numeric]
it { is_expected.to be_numeric }
it { is_expected.to be_satisfies(:numeric) }
else
it { is_expected.not_to be_numeric }
it { is_expected.not_to be_satisfies(:numeric) }
end
it { is_expected.to respond_to(:alpha?) }
if setup[:alpha]
it { is_expected.to be_alpha }
it { is_expected.to be_satisfies(:alpha) }
else
it { is_expected.not_to be_alpha }
it { is_expected.not_to be_satisfies(:alpha) }
end
end
context "provider instance" do
subject { provider.new }
it { is_expected.to respond_to(:numeric?) }
if setup[:numeric]
it { is_expected.to be_numeric }
it { is_expected.to be_satisfies(:numeric) }
else
it { is_expected.not_to be_numeric }
it { is_expected.not_to be_satisfies(:numeric) }
end
it { is_expected.to respond_to(:alpha?) }
if setup[:alpha]
it { is_expected.to be_alpha }
it { is_expected.to be_satisfies(:alpha) }
else
it { is_expected.not_to be_alpha }
it { is_expected.not_to be_satisfies(:alpha) }
end
end
end
end
context "feature with no methods" do
before :each do
type.feature :undemanding, ''
end
it { is_expected.to respond_to(:undemanding?) }
context "when the feature is not declared" do
it { is_expected.not_to be_undemanding }
it { is_expected.not_to be_satisfies(:undemanding) }
end
context "when the feature is declared" do
before :each do
subject.has_feature :undemanding
end
it { is_expected.to be_undemanding }
it { is_expected.to be_satisfies(:undemanding) }
end
end
context "supports_parameter?" do
before :each do
type.newparam(:no_feature)
type.newparam(:one_feature, :required_features => :alpha)
type.newparam(:two_features, :required_features => [:alpha, :numeric])
end
let :providers do
{
:zero => type.provide(:zero),
:one => type.provide(:one) do has_features :alpha end,
:two => type.provide(:two) do has_features :alpha, :numeric end
}
end
{ :zero => { :yes => [:no_feature], :no => [:one_feature, :two_features] },
:one => { :yes => [:no_feature, :one_feature], :no => [:two_features] },
:two => { :yes => [:no_feature, :one_feature, :two_features], :no => [] }
}.each do |name, data|
data[:yes].each do |param|
it "should support #{param} with provider #{name}" do
expect(providers[name]).to be_supports_parameter(param)
end
end
data[:no].each do |param|
it "should not support #{param} with provider #{name}" do
expect(providers[name]).not_to be_supports_parameter(param)
end
end
end
end
end
def provider_of(options = {}, &block)
type = Puppet::Type.newtype(:dummy) do
provide(:dummy, options, &block)
end
type.provider(:dummy)
end
def expect_command_executed(name, path, *args)
command = Puppet::Provider::Command.new(name, path, Puppet::Util, Puppet::Util::Execution)
args = [no_args] if args.empty?
expect(command).to receive(:execute).with(*args)
command
end
def allow_creation_of(command, environment = {})
allow(Puppet::Provider::Command).to receive(:new).with(command.name, command.executable, Puppet::Util, Puppet::Util::Execution, { :failonfail => true, :combine => true, :custom_environment => environment }).and_return(command)
end
def file_exists_and_is_executable(path)
expect(FileTest).to receive(:file?).with(path).and_return(true)
expect(FileTest).to receive(:executable?).with(path).and_return(true)
end
end
|