1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580
|
# encoding: utf-8
require 'spec_helper'
describe Puppet::Type.type(:user) do
before :each do
@provider_class = described_class.provide(:simple) do
has_features :manages_expiry, :manages_password_age, :manages_passwords, :manages_solaris_rbac, :manages_shell
mk_resource_methods
def create; end
def delete; end
def exists?; get(:ensure) != :absent; end
def flush; end
def self.instances; []; end
end
allow(described_class).to receive(:defaultprovider).and_return(@provider_class)
end
it "should be able to create an instance" do
expect(described_class.new(:name => "foo")).not_to be_nil
end
it "should have an allows_duplicates feature" do
expect(described_class.provider_feature(:allows_duplicates)).not_to be_nil
end
it "should have a manages_homedir feature" do
expect(described_class.provider_feature(:manages_homedir)).not_to be_nil
end
it "should have a manages_passwords feature" do
expect(described_class.provider_feature(:manages_passwords)).not_to be_nil
end
it "should have a manages_solaris_rbac feature" do
expect(described_class.provider_feature(:manages_solaris_rbac)).not_to be_nil
end
it "should have a manages_expiry feature" do
expect(described_class.provider_feature(:manages_expiry)).not_to be_nil
end
it "should have a manages_password_age feature" do
expect(described_class.provider_feature(:manages_password_age)).not_to be_nil
end
it "should have a system_users feature" do
expect(described_class.provider_feature(:system_users)).not_to be_nil
end
it "should have a manages_shell feature" do
expect(described_class.provider_feature(:manages_shell)).not_to be_nil
end
context "managehome" do
let (:provider) { @provider_class.new(:name => 'foo', :ensure => :absent) }
let (:instance) { described_class.new(:name => 'foo', :provider => provider) }
it "defaults to false" do
expect(instance[:managehome]).to be_falsey
end
it "can be set to false" do
instance[:managehome] = 'false'
end
it "cannot be set to true for a provider that does not manage homedirs" do
allow(provider.class).to receive(:manages_homedir?).and_return(false)
expect { instance[:managehome] = 'yes' }.to raise_error(Puppet::Error, /can not manage home directories/)
end
it "can be set to true for a provider that does manage homedirs" do
allow(provider.class).to receive(:manages_homedir?).and_return(true)
instance[:managehome] = 'yes'
end
end
describe "instances" do
it "should delegate existence questions to its provider" do
@provider = @provider_class.new(:name => 'foo', :ensure => :absent)
instance = described_class.new(:name => "foo", :provider => @provider)
expect(instance.exists?).to eq(false)
@provider.set(:ensure => :present)
expect(instance.exists?).to eq(true)
end
end
properties = [:ensure, :uid, :gid, :home, :comment, :shell, :password, :password_min_age, :password_max_age, :password_warn_days, :groups, :roles, :auths, :profiles, :project, :keys, :expiry]
properties.each do |property|
it "should have a #{property} property" do
expect(described_class.attrclass(property).ancestors).to be_include(Puppet::Property)
end
it "should have documentation for its #{property} property" do
expect(described_class.attrclass(property).doc).to be_instance_of(String)
end
end
list_properties = [:groups, :roles, :auths]
list_properties.each do |property|
it "should have a list '#{property}'" do
expect(described_class.attrclass(property).ancestors).to be_include(Puppet::Property::List)
end
end
it "should have an ordered list 'profiles'" do
expect(described_class.attrclass(:profiles).ancestors).to be_include(Puppet::Property::OrderedList)
end
it "should have key values 'keys'" do
expect(described_class.attrclass(:keys).ancestors).to be_include(Puppet::Property::KeyValue)
end
describe "when retrieving all current values" do
before do
@provider = @provider_class.new(:name => 'foo', :ensure => :present, :uid => 15, :gid => 15)
@user = described_class.new(:name => "foo", :uid => 10, :provider => @provider)
end
it "should return a hash containing values for all set properties" do
@user[:gid] = 10
values = @user.retrieve
[@user.property(:uid), @user.property(:gid)].each { |property| expect(values).to be_include(property) }
end
it "should set all values to :absent if the user is absent" do
expect(@user.property(:ensure)).to receive(:retrieve).and_return(:absent)
expect(@user.property(:uid)).not_to receive(:retrieve)
expect(@user.retrieve[@user.property(:uid)]).to eq(:absent)
end
it "should include the result of retrieving each property's current value if the user is present" do
expect(@user.retrieve[@user.property(:uid)]).to eq(15)
end
end
describe "when managing the ensure property" do
it "should support a :present value" do
expect { described_class.new(:name => 'foo', :ensure => :present) }.to_not raise_error
end
it "should support an :absent value" do
expect { described_class.new(:name => 'foo', :ensure => :absent) }.to_not raise_error
end
it "should call :create on the provider when asked to sync to the :present state" do
@provider = @provider_class.new(:name => 'foo', :ensure => :absent)
expect(@provider).to receive(:create)
described_class.new(:name => 'foo', :ensure => :present, :provider => @provider).parameter(:ensure).sync
end
it "should call :delete on the provider when asked to sync to the :absent state" do
@provider = @provider_class.new(:name => 'foo', :ensure => :present)
expect(@provider).to receive(:delete)
described_class.new(:name => 'foo', :ensure => :absent, :provider => @provider).parameter(:ensure).sync
end
describe "and determining the current state" do
it "should return :present when the provider indicates the user exists" do
@provider = @provider_class.new(:name => 'foo', :ensure => :present)
expect(described_class.new(:name => 'foo', :ensure => :absent, :provider => @provider).parameter(:ensure).retrieve).to eq(:present)
end
it "should return :absent when the provider indicates the user does not exist" do
@provider = @provider_class.new(:name => 'foo', :ensure => :absent)
expect(described_class.new(:name => 'foo', :ensure => :present, :provider => @provider).parameter(:ensure).retrieve).to eq(:absent)
end
end
end
describe "when managing the uid property" do
it "should convert number-looking strings into actual numbers" do
expect(described_class.new(:name => 'foo', :uid => '50')[:uid]).to eq(50)
end
it "should support UIDs as numbers" do
expect(described_class.new(:name => 'foo', :uid => 50)[:uid]).to eq(50)
end
it "should support :absent as a value" do
expect(described_class.new(:name => 'foo', :uid => :absent)[:uid]).to eq(:absent)
end
end
describe "when managing the gid" do
it "should support :absent as a value" do
expect(described_class.new(:name => 'foo', :gid => :absent)[:gid]).to eq(:absent)
end
it "should convert number-looking strings into actual numbers" do
expect(described_class.new(:name => 'foo', :gid => '50')[:gid]).to eq(50)
end
it "should support GIDs specified as integers" do
expect(described_class.new(:name => 'foo', :gid => 50)[:gid]).to eq(50)
end
it "should support groups specified by name" do
expect(described_class.new(:name => 'foo', :gid => 'foo')[:gid]).to eq('foo')
end
describe "when testing whether in sync" do
it "should return true if no 'should' values are set" do
# this is currently not the case because gid has no default value, so we would never even
# call insync? on that property
if param = described_class.new(:name => 'foo').parameter(:gid)
expect(param).to be_safe_insync(500)
end
end
it "should return true if any of the specified groups are equal to the current integer" do
expect(Puppet::Util).to receive(:gid).with("foo").and_return(300)
expect(Puppet::Util).to receive(:gid).with("bar").and_return(500)
expect(described_class.new(:name => 'baz', :gid => [ 'foo', 'bar' ]).parameter(:gid)).to be_safe_insync(500)
end
it "should return false if none of the specified groups are equal to the current integer" do
expect(Puppet::Util).to receive(:gid).with("foo").and_return(300)
expect(Puppet::Util).to receive(:gid).with("bar").and_return(500)
expect(described_class.new(:name => 'baz', :gid => [ 'foo', 'bar' ]).parameter(:gid)).to_not be_safe_insync(700)
end
end
describe "when syncing" do
it "should use the first found, specified group as the desired value and send it to the provider" do
expect(Puppet::Util).to receive(:gid).with("foo").and_return(nil)
expect(Puppet::Util).to receive(:gid).with("bar").and_return(500)
@provider = @provider_class.new(:name => 'foo')
resource = described_class.new(:name => 'foo', :provider => @provider, :gid => [ 'foo', 'bar' ])
expect(@provider).to receive(:gid=).with(500)
resource.parameter(:gid).sync
end
end
end
describe "when managing groups" do
it "should support a singe group" do
expect { described_class.new(:name => 'foo', :groups => 'bar') }.to_not raise_error
end
it "should support multiple groups as an array" do
expect { described_class.new(:name => 'foo', :groups => [ 'bar' ]) }.to_not raise_error
expect { described_class.new(:name => 'foo', :groups => [ 'bar', 'baz' ]) }.to_not raise_error
end
it "should not support a comma separated list" do
expect { described_class.new(:name => 'foo', :groups => 'bar,baz') }.to raise_error(Puppet::Error, /Group names must be provided as an array/)
end
it "should not support an empty string" do
expect { described_class.new(:name => 'foo', :groups => '') }.to raise_error(Puppet::Error, /Group names must not be empty/)
end
describe "when testing is in sync" do
before :each do
# the useradd provider uses a single string to represent groups and so does Puppet::Property::List when converting to should values
@provider = @provider_class.new(:name => 'foo', :groups => 'a,b,e,f')
end
it "should not care about order" do
@property = described_class.new(:name => 'foo', :groups => [ 'a', 'c', 'b' ]).property(:groups)
expect(@property).to be_safe_insync([ 'a', 'b', 'c' ])
expect(@property).to be_safe_insync([ 'a', 'c', 'b' ])
expect(@property).to be_safe_insync([ 'b', 'a', 'c' ])
expect(@property).to be_safe_insync([ 'b', 'c', 'a' ])
expect(@property).to be_safe_insync([ 'c', 'a', 'b' ])
expect(@property).to be_safe_insync([ 'c', 'b', 'a' ])
end
it "should merge current value and desired value if membership minimal" do
@instance = described_class.new(:name => 'foo', :groups => [ 'a', 'c', 'b' ], :provider => @provider)
@instance[:membership] = :minimum
expect(@instance[:groups]).to eq('a,b,c,e,f')
end
it "should not treat a subset of groups insync if membership inclusive" do
@instance = described_class.new(:name => 'foo', :groups => [ 'a', 'c', 'b' ], :provider => @provider)
@instance[:membership] = :inclusive
expect(@instance[:groups]).to eq('a,b,c')
end
end
end
describe "when managing expiry" do
it "should fail if given an invalid date" do
expect { described_class.new(:name => 'foo', :expiry => "200-20-20") }.to raise_error(Puppet::Error, /Expiry dates must be YYYY-MM-DD/)
end
end
describe "when managing minimum password age" do
it "should accept a negative minimum age" do
expect { described_class.new(:name => 'foo', :password_min_age => '-1') }.to_not raise_error
end
it "should fail with an empty minimum age" do
expect { described_class.new(:name => 'foo', :password_min_age => '') }.to raise_error(Puppet::Error, /minimum age must be provided as a number/)
end
end
describe "when managing maximum password age" do
it "should accept a negative maximum age" do
expect { described_class.new(:name => 'foo', :password_max_age => '-1') }.to_not raise_error
end
it "should fail with an empty maximum age" do
expect { described_class.new(:name => 'foo', :password_max_age => '') }.to raise_error(Puppet::Error, /maximum age must be provided as a number/)
end
end
describe "when managing warning password days" do
it "should accept a negative warning days" do
expect { described_class.new(:name => 'foo', :password_warn_days => '-1') }.to_not raise_error
end
it "should fail with an empty warning days" do
expect { described_class.new(:name => 'foo', :password_warn_days => '') }.to raise_error(Puppet::Error, /warning days must be provided as a number/)
end
end
describe "when managing passwords" do
let(:transaction) { Puppet::Transaction.new(Puppet::Resource::Catalog.new, nil, nil) }
let(:harness) { Puppet::Transaction::ResourceHarness.new(transaction) }
let(:provider) { @provider_class.new(:name => 'foo', :ensure => :present) }
let(:resource) { described_class.new(:name => 'foo', :ensure => :present, :password => 'top secret', :provider => provider) }
it "should not include the password in the change log when adding the password" do
status = harness.evaluate(resource)
sync_event = status.events[0]
expect(sync_event.message).not_to include('top secret')
expect(sync_event.message).to eql('changed [redacted] to [redacted]')
end
it "should not include the password in the change log when changing the password" do
resource[:password] = 'super extra classified'
status = harness.evaluate(resource)
sync_event = status.events[0]
expect(sync_event.message).not_to include('super extra classified')
expect(sync_event.message).to eql('changed [redacted] to [redacted]')
end
it "should fail if a ':' is included in the password" do
expect { described_class.new(:name => 'foo', :password => "some:thing") }.to raise_error(Puppet::Error, /Passwords cannot include ':'/)
end
it "should allow the value to be set to :absent" do
expect { described_class.new(:name => 'foo', :password => :absent) }.to_not raise_error
end
end
describe "when managing comment" do
before :each do
@value = 'abcd™'
expect(@value.encoding).to eq(Encoding::UTF_8)
@user = described_class.new(:name => 'foo', :comment => @value)
end
describe "#insync" do
it "should delegate to the provider's #comments_insync? method if defined" do
# useradd subclasses nameservice and thus inherits #comments_insync?
user = described_class.new(:name => 'foo', :comment => @value, :provider => :useradd)
comment_property = user.properties.find {|p| p.name == :comment}
expect(user.provider).to receive(:comments_insync?)
comment_property.insync?('bar')
end
describe "#change_to_s" do
let(:is) { "\u2603" }
let(:should) { "\u06FF" }
let(:comment_property) { @user.properties.find { |p| p.name == :comment } }
context "given is and should strings with incompatible encoding" do
it "should return a formatted string" do
is.force_encoding(Encoding::ASCII_8BIT)
should.force_encoding(Encoding::UTF_8)
expect(Encoding.compatible?(is, should)).to be_falsey
expect(comment_property.change_to_s(is,should)).to match(/changed '\u{E2}\u{98}\u{83}' to '\u{DB}\u{BF}'/)
end
end
context "given is and should strings with compatible encoding" do
it "should return a formatted string" do
is.force_encoding(Encoding::UTF_8)
should.force_encoding(Encoding::UTF_8)
expect(Encoding.compatible?(is, should)).to be_truthy
expect(comment_property.change_to_s(is,should)).to match(/changed '\u{2603}' to '\u{6FF}'/u)
end
end
end
end
end
describe "when manages_solaris_rbac is enabled" do
it "should support a :role value for ensure" do
expect { described_class.new(:name => 'foo', :ensure => :role) }.to_not raise_error
end
end
describe "when user has roles" do
it "should autorequire roles" do
testuser = described_class.new(:name => "testuser", :roles => ['testrole'] )
testrole = described_class.new(:name => "testrole")
Puppet::Resource::Catalog.new :testing do |conf|
[testuser, testrole].each { |resource| conf.add_resource resource }
end
allow(Puppet::Type::User::ProviderDirectoryservice).to receive(:get_macosx_version_major).and_return("10.5")
rel = testuser.autorequire[0]
expect(rel.source.ref).to eq(testrole.ref)
expect(rel.target.ref).to eq(testuser.ref)
end
end
describe "when setting shell" do
before :each do
@shell_provider_class = described_class.provide(:shell_manager) do
has_features :manages_shell
mk_resource_methods
def create; check_valid_shell;end
def shell=(value); check_valid_shell; end
def delete; end
def exists?; get(:ensure) != :absent; end
def flush; end
def self.instances; []; end
def check_valid_shell; end
end
allow(described_class).to receive(:defaultprovider).and_return(@shell_provider_class)
end
it "should call :check_valid_shell on the provider when changing shell value" do
@provider = @shell_provider_class.new(:name => 'foo', :shell => '/bin/bash', :ensure => :present)
expect(@provider).to receive(:check_valid_shell)
resource = described_class.new(:name => 'foo', :shell => '/bin/zsh', :provider => @provider)
allow(Puppet::Util::Storage).to receive(:load)
allow(Puppet::Util::Storage).to receive(:store)
catalog = Puppet::Resource::Catalog.new
catalog.add_resource resource
catalog.apply
end
it "should call :check_valid_shell on the provider when changing ensure from present to absent" do
@provider = @shell_provider_class.new(:name => 'foo', :shell => '/bin/bash', :ensure => :absent)
expect(@provider).to receive(:check_valid_shell)
resource = described_class.new(:name => 'foo', :shell => '/bin/zsh', :provider => @provider)
allow(Puppet::Util::Storage).to receive(:load)
allow(Puppet::Util::Storage).to receive(:store)
catalog = Puppet::Resource::Catalog.new
catalog.add_resource resource
catalog.apply
end
end
describe "when purging ssh keys" do
it "should not accept a keyfile with a relative path" do
expect {
described_class.new(:name => "a", :purge_ssh_keys => "keys")
}.to raise_error(Puppet::Error, /Paths to keyfiles must be absolute, not keys/)
end
context "with a home directory specified" do
it "should accept true" do
described_class.new(:name => "a", :home => "/tmp", :purge_ssh_keys => true)
end
it "should accept the ~ wildcard" do
described_class.new(:name => "a", :home => "/tmp", :purge_ssh_keys => "~/keys")
end
it "should accept the %h wildcard" do
described_class.new(:name => "a", :home => "/tmp", :purge_ssh_keys => "%h/keys")
end
it "raises when given a relative path" do
expect {
described_class.new(:name => "a", :home => "/tmp", :purge_ssh_keys => "keys")
}.to raise_error(Puppet::Error, /Paths to keyfiles must be absolute/)
end
end
context "with no home directory specified" do
before(:each) do
allow(Dir).to receive(:home).with('a').and_return('/home/a')
end
it "should accept true" do
described_class.new(:name => "a", :purge_ssh_keys => true)
end
it "should accept the ~ wildcard" do
described_class.new(:name => "a", :purge_ssh_keys => "~/keys")
end
it "should accept the %h wildcard" do
described_class.new(:name => "a", :purge_ssh_keys => "%h/keys")
end
end
context "with a valid parameter" do
let(:paths) do
[ "/dev/null", "/tmp/keyfile" ].map { |path| File.expand_path(path) }
end
before(:each) do
allow(Dir).to receive(:home).with('test').and_return('/home/test')
end
subject do
res = described_class.new(:name => "test", :purge_ssh_keys => paths)
res.catalog = Puppet::Resource::Catalog.new
res
end
it "should not just return from generate" do
expect(subject).to receive(:find_unmanaged_keys)
subject.generate
end
it "should check each keyfile for readability" do
paths.each do |path|
expect(File).to receive(:readable?).with(path)
end
subject.generate
end
end
describe "generated keys" do
subject do
res = described_class.new(:name => "test_user_name", :purge_ssh_keys => purge_param)
res.catalog = Puppet::Resource::Catalog.new
res
end
before(:each) do
allow(Dir).to receive(:home).with('test_user_name').and_return('/home/test_user_name')
end
context "when purging is disabled" do
let(:purge_param) { false }
its(:generate) { should be_empty }
end
context "when purging is enabled" do
let(:purge_param) { my_fixture('authorized_keys') }
let(:resources) { subject.generate }
it "should contain a resource for each key" do
names = resources.collect { |res| res.name }
expect(names).to include("key1 name")
expect(names).to include("keyname2")
end
it "should not include keys in comment lines" do
names = resources.collect { |res| res.name }
expect(names).not_to include("keyname3")
end
it "should generate names for unnamed keys" do
names = resources.collect { |res| res.name }
fixture_path = File.join(my_fixture_dir, 'authorized_keys')
expect(names).to include("#{fixture_path}:unnamed-1")
end
it "should each have a value for the user property" do
expect(resources.map { |res|
res[:user]
}.reject { |user_name|
user_name == "test_user_name"
}).to be_empty
end
end
end
end
end
|