1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540
|
"""
Tests for the blank_lines checker.
It uses dedicated assertions which work with TestReport.
"""
import unittest
import pycodestyle
from testing.support import errors_from_src
class BlankLinesTestCase(unittest.TestCase):
"""
Common code for running blank_lines tests.
"""
def assertNoErrors(self, actual):
"""
Check that the actual result from the checker has no errors.
"""
self.assertEqual([], actual)
class TestBlankLinesDefault(BlankLinesTestCase):
"""
Tests for default blank with 2 blank lines for top level and 1
blank line for methods.
"""
def test_initial_no_blank(self):
"""
It will accept no blank lines at the start of the file.
"""
result = errors_from_src("""def some_function():
pass
""")
self.assertNoErrors(result)
def test_initial_lines_one_blank(self):
"""
It will accept 1 blank lines before the first line of actual
code, even if in other places it asks for 2
"""
result = errors_from_src("""
def some_function():
pass
""")
self.assertNoErrors(result)
def test_initial_lines_two_blanks(self):
"""
It will accept 2 blank lines before the first line of actual
code, as normal.
"""
result = errors_from_src("""
def some_function():
pass
""")
self.assertNoErrors(result)
def test_method_less_blank_lines(self):
"""
It will trigger an error when less than 1 blank lin is found
before method definitions.
"""
result = errors_from_src("""# First comment line.
class X:
def a():
pass
def b():
pass
""")
self.assertEqual([
'E301:6:5', # b() call
], result)
def test_method_less_blank_lines_comment(self):
"""
It will trigger an error when less than 1 blank lin is found
before method definition, ignoring comments.
"""
result = errors_from_src("""# First comment line.
class X:
def a():
pass
# A comment will not make it better.
def b():
pass
""")
self.assertEqual([
'E301:7:5', # b() call
], result)
def test_top_level_fewer_blank_lines(self):
"""
It will trigger an error when less 2 blank lines are found
before top level definitions.
"""
result = errors_from_src("""# First comment line.
# Second line of comment.
def some_function():
pass
async def another_function():
pass
def this_one_is_good():
pass
class SomeCloseClass(object):
pass
async def this_async_is_good():
pass
class AFarEnoughClass(object):
pass
""")
self.assertEqual([
'E302:7:1', # another_function
'E302:14:1', # SomeCloseClass
], result)
def test_top_level_more_blank_lines(self):
"""
It will trigger an error when more 2 blank lines are found
before top level definitions.
"""
result = errors_from_src("""# First comment line.
# Second line of comment.
def some_function():
pass
def this_one_is_good():
pass
class SomeFarClass(object):
pass
class AFarEnoughClass(object):
pass
""")
self.assertEqual([
'E303:6:1', # some_function
'E303:15:1', # SomeFarClass
], result)
def test_method_more_blank_lines(self):
"""
It will trigger an error when more than 1 blank line is found
before method definition
"""
result = errors_from_src("""# First comment line.
class SomeCloseClass(object):
def oneMethod(self):
pass
def anotherMethod(self):
pass
def methodOK(self):
pass
def veryFar(self):
pass
""")
self.assertEqual([
'E303:7:5', # oneMethod
'E303:11:5', # anotherMethod
'E303:19:5', # veryFar
], result)
def test_initial_lines_more_blank(self):
"""
It will trigger an error for more than 2 blank lines before the
first line of actual code.
"""
result = errors_from_src("""
def some_function():
pass
""")
self.assertEqual(['E303:4:1'], result)
def test_blank_line_between_decorator(self):
"""
It will trigger an error when the decorator is followed by a
blank line.
"""
result = errors_from_src("""# First line.
@some_decorator
def some_function():
pass
class SomeClass(object):
@method_decorator
def some_method(self):
pass
""")
self.assertEqual(['E304:6:1', 'E304:14:5'], result)
def test_blank_line_decorator(self):
"""
It will accept the decorators which are adjacent to the function
and method definition.
"""
result = errors_from_src("""# First line.
@another_decorator
@some_decorator
def some_function():
pass
class SomeClass(object):
@method_decorator
def some_method(self):
pass
""")
self.assertNoErrors(result)
def test_top_level_fewer_follow_lines(self):
"""
It will trigger an error when less than 2 blank lines are
found between a top level definitions and other top level code.
"""
result = errors_from_src("""
def a():
print('Something')
a()
""")
self.assertEqual([
'E305:5:1', # a call
], result)
def test_top_level_fewer_follow_lines_comments(self):
"""
It will trigger an error when less than 2 blank lines are
found between a top level definitions and other top level code,
even if we have comments before
"""
result = errors_from_src("""
def a():
print('Something')
# comment
# another comment
# With comment still needs 2 spaces before,
# as comments are ignored.
a()
""")
self.assertEqual([
'E305:11:1', # a call
], result)
def test_top_level_good_follow_lines(self):
"""
It not trigger an error when 2 blank lines are
found between a top level definitions and other top level code.
"""
result = errors_from_src("""
def a():
print('Something')
# Some comments in other parts.
# More comments.
# With the right spaces,
# It will work, even when we have comments.
a()
""")
self.assertNoErrors(result)
def test_method_fewer_follow_lines(self):
"""
It will trigger an error when less than 1 blank line is
found between a method and previous definitions.
"""
result = errors_from_src("""
def a():
x = 1
def b():
pass
""")
self.assertEqual([
'E306:4:5', # b() call
], result)
def test_method_nested_fewer_follow_lines(self):
"""
It will trigger an error when less than 1 blank line is
found between a method and previous definitions, even when
nested.
"""
result = errors_from_src("""
def a():
x = 2
def b():
x = 1
def c():
pass
""")
self.assertEqual([
'E306:7:9', # c() call
], result)
def test_method_nested_less_class(self):
"""
It will trigger an error when less than 1 blank line is found
between a method and previous definitions, even when used to
define a class.
"""
result = errors_from_src("""
def a():
x = 1
class C:
pass
""")
self.assertEqual([
'E306:4:5', # class C definition.
], result)
def test_method_nested_ok(self):
"""
Will not trigger an error when 1 blank line is found
found between a method and previous definitions, even when
nested.
"""
result = errors_from_src("""
def a():
x = 2
def b():
x = 1
def c():
pass
class C:
pass
""")
self.assertNoErrors(result)
class TestBlankLinesTwisted(BlankLinesTestCase):
"""
Tests for blank_lines with 3 blank lines for top level and 2 blank
line for methods as used by the Twisted coding style.
"""
def setUp(self):
self._original_lines_config = pycodestyle.BLANK_LINES_CONFIG.copy()
pycodestyle.BLANK_LINES_CONFIG['top_level'] = 3
pycodestyle.BLANK_LINES_CONFIG['method'] = 2
def tearDown(self):
pycodestyle.BLANK_LINES_CONFIG = self._original_lines_config
def test_initial_lines_one_blanks(self):
"""
It will accept less than 3 blank lines before the first line of
actual code.
"""
result = errors_from_src("""
def some_function():
pass
""")
self.assertNoErrors(result)
def test_initial_lines_tree_blanks(self):
"""
It will accept 3 blank lines before the first line of actual
code, as normal.
"""
result = errors_from_src("""
def some_function():
pass
""")
self.assertNoErrors(result)
def test_top_level_fewer_blank_lines(self):
"""
It will trigger an error when less 3 blank lines are found
before top level definitions.
"""
result = errors_from_src("""# First comment line.
# Second line of comment.
def some_function():
pass
async def another_function():
pass
def this_one_is_good():
pass
class SomeCloseClass(object):
pass
async def this_async_is_good():
pass
class AFarEnoughClass(object):
pass
""")
self.assertEqual([
'E302:9:1', # another_function
'E302:17:1', # SomeCloseClass
], result)
def test_top_level_more_blank_lines(self):
"""
It will trigger an error when more 2 blank lines are found
before top level definitions.
"""
result = errors_from_src("""# First comment line.
# Second line of comment.
def some_function():
pass
def this_one_is_good():
pass
class SomeVeryFarClass(object):
pass
class AFarEnoughClass(object):
pass
""")
self.assertEqual([
'E303:7:1', # some_function
'E303:18:1', # SomeVeryFarClass
], result)
def test_the_right_blanks(self):
"""
It will accept 3 blank for top level and 2 for nested.
"""
result = errors_from_src("""
def some_function():
pass
# With comments.
some_other = code_here
class SomeClass:
'''
Docstring here.
'''
def some_method():
pass
def another_method():
pass
# More methods.
def another_method_with_comment():
pass
@decorator
def another_method_with_comment():
pass
""")
self.assertNoErrors(result)
|