1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727
|
# Licensed under the GPL: https://www.gnu.org/licenses/old-licenses/gpl-2.0.html
# For details: https://github.com/pylint-dev/pylint/blob/main/LICENSE
# Copyright (c) https://github.com/pylint-dev/pylint/blob/main/CONTRIBUTORS.txt
"""Puts the check_parallel system under test."""
# pylint: disable=protected-access,missing-function-docstring
from __future__ import annotations
import argparse
import os
import sys
from concurrent.futures.process import BrokenProcessPool, ProcessPoolExecutor
from pathlib import Path
from pickle import PickleError
from typing import TYPE_CHECKING
from unittest.mock import patch
import dill
import pytest
import pylint.interfaces
import pylint.lint.parallel
from pylint.checkers import BaseRawFileChecker
from pylint.checkers.imports import ImportsChecker
from pylint.lint import PyLinter, augmented_sys_path
from pylint.lint.parallel import _worker_check_single_file as worker_check_single_file
from pylint.lint.parallel import _worker_initialize as worker_initialize
from pylint.lint.parallel import check_parallel
from pylint.reporters.progress_reporters import ProgressReporter
from pylint.testutils import GenericTestReporter as Reporter
from pylint.testutils.utils import _test_cwd
from pylint.typing import FileItem
from pylint.utils import LinterStats, ModuleStats
if TYPE_CHECKING:
from unittest.mock import MagicMock
from astroid import nodes
def _gen_file_data(idx: int = 0) -> FileItem:
"""Generates a file to use as a stream."""
filepath = os.path.abspath(
os.path.join(os.path.dirname(__file__), "input", "similar1")
)
file_data = FileItem(
f"--test-file_data-name-{idx}--",
filepath,
f"--test-file_data-modname-{idx}--",
)
return file_data
def _gen_file_datas(count: int = 1) -> list[FileItem]:
return [_gen_file_data(idx) for idx in range(count)]
class SequentialTestChecker(BaseRawFileChecker):
"""A checker that does not need to consolidate data across run invocations."""
name = "sequential-checker"
test_data = "sequential"
msgs = {
"R9999": (
"Test",
"sequential-test-check",
"Some helpful text.",
)
}
def __init__(self, linter: PyLinter) -> None:
super().__init__(linter)
self.data: list[str] = []
self.linter = linter
def process_module(self, node: nodes.Module) -> None:
"""Called once per stream/file/astroid object."""
# record the number of invocations with the data object
record = self.test_data + str(len(self.data))
self.data.append(record)
class ParallelTestChecker(BaseRawFileChecker):
"""A checker that does need to consolidate data.
To simulate the need to consolidate data, this checker only
reports a message for pairs of files.
On non-parallel builds: it works on all the files in a single run.
On parallel builds: ``lint.parallel`` calls ``open`` once per file.
So if files are treated by separate processes, no messages will be
raised from the individual process, all messages will be raised
from reduce_map_data.
"""
name = "parallel-checker"
test_data = "parallel"
msgs = {
"R9999": (
"Test %s",
"parallel-test-check",
"Some helpful text.",
)
}
def __init__(self, linter: PyLinter) -> None:
super().__init__(linter)
self.data: list[str] = []
self.linter = linter
def open(self) -> None:
"""Init the checkers: reset statistics information."""
self.linter.stats.reset_node_count()
self.data = []
def close(self) -> None:
for _ in self.data[1::2]: # Work on pairs of files, see class docstring.
self.add_message("R9999", args=("From process_module, two files seen.",))
def get_map_data(self) -> list[str]:
return self.data
def reduce_map_data(self, linter: PyLinter, data: list[list[str]]) -> None:
recombined = type(self)(linter)
recombined.open()
aggregated = []
for d in data:
aggregated.extend(d)
for _ in aggregated[1::2]: # Work on pairs of files, see class docstring.
self.add_message("R9999", args=("From reduce_map_data",))
recombined.close()
def process_module(self, node: nodes.Module) -> None:
"""Called once per stream/file/astroid object."""
# record the number of invocations with the data object
record = self.test_data + str(len(self.data))
self.data.append(record)
class ExtraSequentialTestChecker(SequentialTestChecker):
"""A checker that does not need to consolidate data across run invocations."""
name = "extra-sequential-checker"
test_data = "extra-sequential"
class ExtraParallelTestChecker(ParallelTestChecker):
"""A checker that does need to consolidate data across run invocations."""
name = "extra-parallel-checker"
test_data = "extra-parallel"
class ThirdSequentialTestChecker(SequentialTestChecker):
"""A checker that does not need to consolidate data across run invocations."""
name = "third-sequential-checker"
test_data = "third-sequential"
class ThirdParallelTestChecker(ParallelTestChecker):
"""A checker that does need to consolidate data across run invocations."""
name = "third-parallel-checker"
test_data = "third-parallel"
class TestCheckParallelFramework:
"""Tests the check_parallel() function's framework."""
def setup_class(self) -> None:
self._prev_global_linter = pylint.lint.parallel._worker_linter
def teardown_class(self) -> None:
pylint.lint.parallel._worker_linter = self._prev_global_linter
def test_worker_initialize(self) -> None:
linter = PyLinter(reporter=Reporter())
worker_initialize(linter=dill.dumps(linter))
assert isinstance(pylint.lint.parallel._worker_linter, type(linter))
def test_worker_initialize_with_package_paths(self) -> None:
linter = PyLinter(reporter=Reporter())
with augmented_sys_path([]):
worker_initialize(
linter=dill.dumps(linter), extra_packages_paths=["fake-path"]
)
assert "fake-path" in sys.path
def test_worker_initialize_reregisters_custom_plugins(self) -> None:
linter = PyLinter(reporter=Reporter())
linter.load_plugin_modules(["pylint.extensions.private_import"])
pickled = dill.dumps(linter)
with patch(
"pylint.extensions.private_import.register", side_effect=AssertionError
):
with pytest.raises(AssertionError):
worker_initialize(linter=pickled)
@pytest.mark.needs_two_cores
def test_worker_initialize_pickling(self) -> None:
"""Test that we can pickle objects that standard pickling in multiprocessing can't.
See:
https://stackoverflow.com/questions/8804830/python-multiprocessing-picklingerror-cant-pickle-type-function
https://github.com/pylint-dev/pylint/pull/5584
"""
linter = PyLinter(reporter=Reporter())
linter.attribute = argparse.ArgumentParser() # type: ignore[attr-defined]
with ProcessPoolExecutor(
max_workers=2, initializer=worker_initialize, initargs=(dill.dumps(linter),)
) as executor:
executor.map(print, [1, 2])
def test_worker_check_single_file_uninitialised(self) -> None:
pylint.lint.parallel._worker_linter = None
with pytest.raises( # Objects that do not match the linter interface will fail
RuntimeError, match="Worker linter not yet initialised"
):
worker_check_single_file(_gen_file_data())
def test_worker_check_single_file_no_checkers(self) -> None:
linter = PyLinter(reporter=Reporter())
worker_initialize(linter=dill.dumps(linter))
(
_, # proc-id
name,
_, # file_path
_, # base_name
msgs,
stats,
msg_status,
_, # mapreduce_data
) = worker_check_single_file(_gen_file_data())
assert name == "--test-file_data-name-0--"
assert not msgs
no_errors_status = 0
assert no_errors_status == msg_status
assert {
"--test-file_data-name-0--": {
"convention": 0,
"error": 0,
"fatal": 0,
"info": 0,
"refactor": 0,
"statement": 18,
"warning": 0,
}
} == stats.by_module
assert not stats.by_msg
assert stats.convention == 0
assert stats.error == 0
assert stats.fatal == 0
assert stats.info == 0
assert stats.refactor == 0
assert stats.statement == 18
assert stats.warning == 0
def test_linter_with_unpickleable_plugins_is_pickleable(self) -> None:
"""The linter needs to be pickle-able in order to be passed between workers."""
linter = PyLinter(reporter=Reporter())
# We load an extension that we know is not pickle-safe
linter.load_plugin_modules(["pylint.extensions.overlapping_exceptions"])
try:
dill.dumps(linter)
# TODO: 4.0: Fix this test by raising this assertion again
# raise AssertionError(
# "Plugins loaded were pickle-safe! This test needs altering"
# )
except (KeyError, TypeError, PickleError, NotImplementedError):
pass
# And expect this call to make it pickle-able
linter.load_plugin_configuration()
try:
dill.dumps(linter)
except KeyError as exc:
raise AssertionError(
"Cannot pickle linter when using non-pickleable plugin"
) from exc
def test_worker_check_sequential_checker(self) -> None:
"""Same as test_worker_check_single_file_no_checkers with SequentialTestChecker."""
linter = PyLinter(reporter=Reporter())
worker_initialize(linter=dill.dumps(linter))
# Add the only checker we care about in this test
linter.register_checker(SequentialTestChecker(linter))
(
_, # proc-id
name,
_, # file_path
_, # base_name
msgs,
stats,
msg_status,
_, # mapreduce_data
) = worker_check_single_file(_gen_file_data())
# Ensure we return the same data as the single_file_no_checkers test
assert name == "--test-file_data-name-0--"
assert not msgs
no_errors_status = 0
assert no_errors_status == msg_status
assert {
"--test-file_data-name-0--": {
"convention": 0,
"error": 0,
"fatal": 0,
"info": 0,
"refactor": 0,
"statement": 18,
"warning": 0,
}
} == stats.by_module
assert not stats.by_msg
assert stats.convention == 0
assert stats.error == 0
assert stats.fatal == 0
assert stats.info == 0
assert stats.refactor == 0
assert stats.statement == 18
assert stats.warning == 0
class TestCheckParallel:
"""Tests the check_parallel() function."""
def test_sequential_checkers_work(self) -> None:
"""Tests original basic types of checker works as expected in -jN.
This means that a sequential checker should return the same data for a given
file-stream irrespective of whether it's run in -j1 or -jN
"""
linter = PyLinter(reporter=Reporter())
# Add a sequential checker to ensure it records data against some streams
linter.register_checker(SequentialTestChecker(linter))
# Create a dummy file, the actual contents of which will be ignored by the
# register test checkers, but it will trigger at least a single-job to be run.
single_file_container = _gen_file_datas(count=1)
# Invoke the lint process in a multi-process way, although we only specify one
# job.
check_parallel(
linter,
jobs=1,
files=iter(single_file_container),
)
assert len(linter.get_checkers()) == 2, (
"We should only have the 'main' and 'sequential-checker' "
"checkers registered"
)
assert {
"--test-file_data-name-0--": {
"convention": 0,
"error": 0,
"fatal": 0,
"info": 0,
"refactor": 0,
"statement": 18,
"warning": 0,
}
} == linter.stats.by_module
assert not linter.stats.by_msg
assert linter.stats.convention == 0
assert linter.stats.error == 0
assert linter.stats.fatal == 0
assert linter.stats.info == 0
assert linter.stats.refactor == 0
assert linter.stats.statement == 18
assert linter.stats.warning == 0
# now run the regular mode of checking files and check that, in this proc, we
# collect the right data
filepath = [single_file_container[0][1]] # get the filepath element
linter.stats = LinterStats()
linter.check(filepath)
assert {
"input.similar1": { # module is the only change from previous
"convention": 0,
"error": 0,
"fatal": 0,
"info": 0,
"refactor": 0,
"statement": 18,
"warning": 0,
}
} == linter.stats.by_module
assert not linter.stats.by_msg
assert linter.stats.convention == 0
assert linter.stats.error == 0
assert linter.stats.fatal == 0
assert linter.stats.info == 0
assert linter.stats.refactor == 0
assert linter.stats.statement == 18
assert linter.stats.warning == 0
def test_invoke_single_job(self) -> None:
"""Tests basic checkers functionality using just a single worker.
This is *not* the same -j1 and does not happen under normal operation
"""
linter = PyLinter(reporter=Reporter())
linter.register_checker(SequentialTestChecker(linter))
# Create a dummy file, the actual contents of which will be ignored by the
# register test checkers, but it will trigger at least a single-job to be run.
single_file_container = _gen_file_datas(count=1)
# Invoke the lint process in a multi-process way, although we only specify one
# job.
check_parallel(
linter,
jobs=1,
files=iter(single_file_container),
)
assert {
"--test-file_data-name-0--": {
"convention": 0,
"error": 0,
"fatal": 0,
"info": 0,
"refactor": 0,
"statement": 18,
"warning": 0,
}
} == linter.stats.by_module
assert not linter.stats.by_msg
assert linter.stats.convention == 0
assert linter.stats.error == 0
assert linter.stats.fatal == 0
assert linter.stats.info == 0
assert linter.stats.refactor == 0
assert linter.stats.statement == 18
assert linter.stats.warning == 0
assert linter.msg_status == 0, "We expect a single-file check to exit cleanly"
@pytest.mark.needs_two_cores
@pytest.mark.parametrize(
"num_files,num_jobs,num_checkers",
[
(1, 2, 1),
(1, 2, 2),
(1, 2, 3),
(2, 2, 1),
(2, 2, 2),
(2, 2, 3),
(3, 2, 1),
(3, 2, 2),
(3, 2, 3),
(3, 1, 1),
(3, 1, 2),
(3, 1, 3),
(10, 2, 1),
(10, 2, 2),
(10, 2, 3),
],
)
def test_compare_workers_to_single_proc(
self, num_files: int, num_jobs: int, num_checkers: int
) -> None:
"""Compares the 3 key parameters for check_parallel() produces the same results.
The intent here is to ensure that the check_parallel() operates on each file,
without ordering issues, irrespective of the number of workers used and the
number of checkers applied.
This test becomes more important if we want to change how we parameterize the
checkers, for example if we aim to batch the files across jobs.
"""
# define the stats we expect to get back from the runs, these should only vary
# with the number of files.
expected_stats = LinterStats(
by_module={
f"--test-file_data-name-{idx}--": ModuleStats(
convention=0,
error=0,
fatal=0,
info=0,
refactor=0,
statement=18,
warning=0,
)
for idx in range(num_files)
}
)
expected_stats.by_msg = {}
expected_stats.convention = 0
expected_stats.error = 0
expected_stats.fatal = 0
expected_stats.info = 0
expected_stats.refactor = 0
expected_stats.statement = 18 * num_files
expected_stats.warning = 0
file_infos = _gen_file_datas(num_files)
progress_reporter = ProgressReporter(is_verbose=False)
# Loop for single-proc and mult-proc, so we can ensure the same linter-config
for do_single_proc in range(2):
linter = PyLinter(reporter=Reporter())
# Assign between 1 and 3 checkers to the linter, they should not change the
# results of the lint
linter.register_checker(SequentialTestChecker(linter))
if num_checkers > 1:
linter.register_checker(ExtraSequentialTestChecker(linter))
if num_checkers > 2:
linter.register_checker(ThirdSequentialTestChecker(linter))
if do_single_proc:
# establish the baseline
assert (
linter.config.jobs == 1
), "jobs>1 are ignored when calling _lint_files"
ast_mapping = linter._get_asts(
iter(file_infos), None, progress_reporter
)
with linter._astroid_module_checker() as check_astroid_module:
linter._lint_files(
ast_mapping, check_astroid_module, progress_reporter
)
assert linter.msg_status == 0, "We should not fail the lint"
stats_single_proc = linter.stats
else:
check_parallel(
linter,
jobs=num_jobs,
files=file_infos,
)
stats_check_parallel = linter.stats
assert linter.msg_status == 0, "We should not fail the lint"
assert str(stats_single_proc) == str(
stats_check_parallel
), "Single-proc and check_parallel() should return the same thing"
assert str(stats_check_parallel) == str(
expected_stats
), "The lint is returning unexpected results, has something changed?"
@pytest.mark.needs_two_cores
@pytest.mark.parametrize(
"num_files,num_jobs,num_checkers",
[
(2, 2, 1),
(2, 2, 2),
(2, 2, 3),
(3, 2, 1),
(3, 2, 2),
(3, 2, 3),
(3, 1, 1),
(3, 1, 2),
(3, 1, 3),
(10, 2, 1),
(10, 2, 2),
(10, 2, 3),
],
)
def test_map_reduce(self, num_files: int, num_jobs: int, num_checkers: int) -> None:
"""Compares the 3 key parameters for check_parallel() produces the same results.
The intent here is to validate the reduce step: no stats should be lost.
Checks regression of https://github.com/pylint-dev/pylint/issues/4118
"""
# define the stats we expect to get back from the runs, these should only vary
# with the number of files.
file_infos = _gen_file_datas(num_files)
# Loop for single-proc and mult-proc, so we can ensure the same linter-config
for do_single_proc in range(2):
linter = PyLinter(reporter=Reporter())
# Assign between 1 and 3 checkers to the linter, they should not change the
# results of the lint
linter.register_checker(ParallelTestChecker(linter))
if num_checkers > 1:
linter.register_checker(ExtraParallelTestChecker(linter))
if num_checkers > 2:
linter.register_checker(ThirdParallelTestChecker(linter))
progress_reporter = ProgressReporter(is_verbose=False)
if do_single_proc:
# establish the baseline
assert (
linter.config.jobs == 1
), "jobs>1 are ignored when calling _lint_files"
ast_mapping = linter._get_asts(
iter(file_infos), None, progress_reporter
)
with linter._astroid_module_checker() as check_astroid_module:
linter._lint_files(
ast_mapping, check_astroid_module, progress_reporter
)
stats_single_proc = linter.stats
else:
check_parallel(
linter,
jobs=num_jobs,
files=file_infos,
)
stats_check_parallel = linter.stats
# pylint: disable=possibly-used-before-assignment
assert str(stats_single_proc.by_msg) == str(
stats_check_parallel.by_msg
), "Single-proc and check_parallel() should return the same thing"
@pytest.mark.timeout(5)
def test_no_deadlock_due_to_initializer_error(self) -> None:
"""Tests that an error in the initializer for the parallel jobs doesn't
lead to a deadlock.
"""
linter = PyLinter(reporter=Reporter())
linter.register_checker(SequentialTestChecker(linter))
# Create a dummy file, the actual contents of which will be ignored by the
# register test checkers, but it will trigger at least a single-job to be run.
single_file_container = _gen_file_datas(count=1)
# The error in the initializer should trigger a BrokenProcessPool exception
with pytest.raises(BrokenProcessPool):
check_parallel(
linter,
jobs=1,
files=iter(single_file_container),
# This will trigger an exception in the initializer for the parallel jobs
# because arguments has to be an Iterable.
extra_packages_paths=1, # type: ignore[arg-type]
)
@pytest.mark.needs_two_cores
def test_cyclic_import_parallel(self) -> None:
tests_dir = Path("tests")
package_path = Path("input") / "func_w0401_package"
linter = PyLinter(reporter=Reporter())
linter.register_checker(ImportsChecker(linter))
with _test_cwd(tests_dir):
check_parallel(
linter,
jobs=2,
files=[
FileItem(
name="input.func_w0401_package.all_the_things",
filepath=str(package_path / "all_the_things.py"),
modpath="input.func_w0401_package",
),
FileItem(
name="input.func_w0401_package.thing2",
filepath=str(package_path / "thing2.py"),
modpath="input.func_w0401_package",
),
],
)
assert "cyclic-import" in linter.stats.by_msg
@pytest.mark.needs_two_cores
@patch("pylint.checkers.imports.ImportsChecker.close")
def test_cyclic_import_parallel_disabled_globally(self, mock: MagicMock) -> None:
tests_dir = Path("tests")
package_path = Path("input") / "func_w0401_package"
linter = PyLinter(reporter=Reporter())
linter.register_checker(ImportsChecker(linter))
linter.disable("cyclic-import")
with _test_cwd(tests_dir):
check_parallel(
linter,
jobs=2,
files=[
FileItem(
name="input.func_w0401_package.all_the_things",
filepath=str(package_path / "all_the_things.py"),
modpath="input.func_w0401_package",
),
FileItem(
name="input.func_w0401_package.thing2",
filepath=str(package_path / "thing2.py"),
modpath="input.func_w0401_package",
),
],
)
mock.assert_not_called()
assert "cyclic-import" not in linter.stats.by_msg
@pytest.mark.needs_two_cores
def test_cyclic_import_parallel_disabled_locally(self) -> None:
tests_dir = Path("tests")
package_path = Path("input") / "func_noerror_cycle"
linter = PyLinter(reporter=Reporter())
linter.register_checker(ImportsChecker(linter))
with _test_cwd(tests_dir):
check_parallel(
linter,
jobs=2,
files=[
FileItem(
name="input.func_noerror_cycle.a",
filepath=str(package_path / "a.py"),
modpath="input.func_noerror_cycle",
),
FileItem(
name="input.func_noerror_cycle.b",
filepath=str(package_path / "b.py"),
modpath="input.func_noerror_cycle",
),
],
)
assert "cyclic-import" not in linter.stats.by_msg
|