1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
|
"""Tests for pyotgw/commandprocessor.py"""
import asyncio
import logging
from unittest.mock import MagicMock, call, patch
import pytest
import pyotgw.vars as v
from tests.helpers import called_once, let_queue_drain
@pytest.mark.asyncio
async def test_submit_response_queuefull(caplog, pygw_proto):
"""Test queuefull on submit_response()"""
test_lines = ("BCDEF", "A1A2B3C4D", "MustBeCommand", "AlsoCommand")
with patch.object(
pygw_proto.command_processor._cmdq, "put_nowait", side_effect=asyncio.QueueFull
) as put_nowait, caplog.at_level(logging.ERROR):
pygw_proto.line_received(test_lines[3])
pygw_proto.activity_callback.assert_called_once()
put_nowait.assert_called_once_with(test_lines[3])
assert pygw_proto.command_processor._cmdq.qsize() == 0
assert caplog.record_tuples == [
(
"pyotgw.commandprocessor",
logging.ERROR,
f"Queue full, discarded message: {test_lines[3]}",
),
]
@pytest.mark.asyncio
async def test_issue_cmd(caplog, pygw_proto):
"""Test OpenThermProtocol.issue_cmd()"""
pygw_proto._connected = False
with caplog.at_level(logging.DEBUG):
assert await pygw_proto.command_processor.issue_cmd("PS", 1, 0) is None
assert caplog.record_tuples == [
(
"pyotgw.commandprocessor",
logging.DEBUG,
"Serial transport closed, not sending command PS",
),
]
caplog.clear()
loop = asyncio.get_running_loop()
pygw_proto._connected = True
pygw_proto.command_processor._cmdq.put_nowait("thisshouldbecleared")
pygw_proto.transport.write = MagicMock()
with caplog.at_level(logging.DEBUG):
task = loop.create_task(
pygw_proto.command_processor.issue_cmd(
v.OTGW_CMD_REPORT,
"I",
1,
)
)
await let_queue_drain(pygw_proto.command_processor._cmdq)
pygw_proto.transport.write.assert_called_once_with(b"PR=I\r\n")
assert caplog.record_tuples == [
(
"pyotgw.commandprocessor",
logging.DEBUG,
"Clearing leftover message from command queue: thisshouldbecleared",
),
(
"pyotgw.commandprocessor",
logging.DEBUG,
"Sending command: PR with value I",
),
]
caplog.clear()
pygw_proto.command_processor.submit_response("SE")
pygw_proto.command_processor.submit_response("SE")
with pytest.raises(SyntaxError):
await task
assert pygw_proto.transport.write.call_args_list == [
call(b"PR=I\r\n"),
call(b"PR=I\r\n"),
]
assert caplog.record_tuples == [
(
"pyotgw.commandprocessor",
logging.DEBUG,
"Response submitted. Queue size: 1",
),
(
"pyotgw.commandprocessor",
logging.DEBUG,
"Response submitted. Queue size: 2",
),
(
"pyotgw.commandprocessor",
logging.DEBUG,
"Got possible response for command PR: SE",
),
(
"pyotgw.commandprocessor",
logging.WARNING,
"Command PR failed with SE, retrying...",
),
(
"pyotgw.commandprocessor",
logging.DEBUG,
"Got possible response for command PR: SE",
),
]
caplog.clear()
pygw_proto.transport.write = MagicMock()
with caplog.at_level(logging.WARNING):
task = loop.create_task(
pygw_proto.command_processor.issue_cmd(
v.OTGW_CMD_CONTROL_SETPOINT_2,
20.501,
1,
)
)
await called_once(pygw_proto.transport.write)
pygw_proto.transport.write.assert_called_once_with(b"C2=20.50\r\n")
pygw_proto.command_processor.submit_response("InvalidCommand")
pygw_proto.command_processor.submit_response("C2: 20.50")
assert await task == "20.50"
assert pygw_proto.transport.write.call_args_list == [
call(b"C2=20.50\r\n"),
call(b"C2=20.50\r\n"),
]
assert caplog.record_tuples == [
(
"pyotgw.commandprocessor",
logging.WARNING,
"Unknown message in command queue: InvalidCommand",
),
(
"pyotgw.commandprocessor",
logging.WARNING,
"Command C2 failed with InvalidCommand, retrying...",
),
]
caplog.clear()
pygw_proto.transport.write = MagicMock()
with caplog.at_level(logging.WARNING):
task = loop.create_task(
pygw_proto.command_processor.issue_cmd(
v.OTGW_CMD_CONTROL_HEATING_2,
-1,
2,
)
)
await called_once(pygw_proto.transport.write)
pygw_proto.transport.write.assert_called_once_with(b"H2=-1\r\n")
pygw_proto.command_processor.submit_response("Error 03")
pygw_proto.command_processor.submit_response("H2: BV")
pygw_proto.command_processor.submit_response("H2: BV")
with pytest.raises(ValueError):
await task
assert caplog.record_tuples == [
(
"pyotgw.commandprocessor",
logging.WARNING,
"Received Error 03. "
"If this happens during a reset of the gateway it can be safely ignored.",
),
(
"pyotgw.commandprocessor",
logging.WARNING,
"Command H2 failed with Error 03, retrying...",
),
(
"pyotgw.commandprocessor",
logging.WARNING,
"Command H2 failed with H2: BV, retrying...",
),
]
pygw_proto.transport.write = MagicMock()
task = loop.create_task(
pygw_proto.command_processor.issue_cmd(
v.OTGW_CMD_MODE,
"R",
0,
)
)
await called_once(pygw_proto.transport.write)
pygw_proto.command_processor.submit_response("ThisGetsIgnored")
pygw_proto.command_processor.submit_response("OpenTherm Gateway 4.3.5")
assert await task is True
pygw_proto.transport.write = MagicMock()
task = loop.create_task(
pygw_proto.command_processor.issue_cmd(
v.OTGW_CMD_SUMMARY,
1,
0,
)
)
await called_once(pygw_proto.transport.write)
pygw_proto.command_processor.submit_response("PS: 1")
pygw_proto.command_processor.submit_response(
"part_2_will_normally_be_parsed_by_get_status",
)
assert await task == ["1", "part_2_will_normally_be_parsed_by_get_status"]
|
