1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659 1660 1661 1662 1663 1664 1665 1666 1667 1668 1669 1670 1671 1672 1673 1674 1675 1676 1677 1678 1679 1680 1681 1682 1683 1684 1685 1686 1687 1688 1689 1690 1691 1692 1693 1694 1695 1696 1697 1698 1699 1700 1701 1702 1703 1704 1705 1706 1707 1708 1709 1710 1711 1712 1713 1714 1715 1716 1717 1718 1719 1720 1721 1722 1723 1724 1725 1726 1727 1728 1729 1730 1731 1732 1733 1734 1735 1736 1737 1738 1739 1740 1741 1742 1743 1744 1745 1746 1747 1748 1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759 1760 1761 1762 1763 1764 1765 1766 1767 1768 1769 1770 1771 1772 1773 1774 1775 1776 1777 1778 1779 1780 1781 1782 1783 1784 1785 1786 1787 1788 1789 1790 1791 1792 1793 1794 1795 1796 1797 1798 1799 1800 1801 1802 1803 1804 1805 1806 1807 1808 1809 1810 1811 1812 1813 1814 1815 1816 1817 1818 1819 1820 1821 1822 1823 1824 1825 1826 1827 1828 1829 1830 1831 1832 1833 1834 1835 1836 1837 1838 1839 1840 1841 1842 1843 1844 1845 1846 1847 1848 1849 1850 1851 1852 1853 1854 1855 1856 1857 1858 1859 1860 1861 1862 1863 1864 1865 1866 1867 1868 1869 1870 1871 1872 1873 1874 1875 1876 1877 1878 1879 1880 1881 1882 1883 1884 1885 1886 1887 1888 1889 1890 1891 1892 1893 1894 1895 1896 1897 1898 1899 1900 1901 1902 1903 1904 1905 1906 1907 1908 1909 1910 1911 1912 1913 1914 1915 1916 1917 1918 1919 1920 1921 1922 1923 1924 1925 1926 1927 1928 1929 1930 1931 1932 1933 1934 1935 1936 1937 1938 1939 1940 1941 1942 1943 1944 1945 1946 1947 1948 1949 1950 1951 1952 1953 1954 1955 1956 1957 1958 1959 1960 1961 1962 1963 1964 1965 1966 1967 1968 1969 1970 1971 1972 1973 1974 1975 1976 1977 1978 1979 1980 1981 1982 1983 1984 1985 1986 1987 1988 1989 1990 1991 1992 1993 1994 1995 1996 1997 1998 1999 2000 2001 2002 2003 2004 2005 2006 2007 2008 2009 2010 2011 2012 2013 2014 2015 2016 2017 2018 2019 2020 2021 2022 2023 2024 2025 2026 2027 2028 2029 2030 2031 2032 2033 2034 2035 2036 2037 2038 2039 2040 2041 2042 2043 2044 2045 2046 2047 2048 2049 2050 2051 2052 2053 2054 2055 2056 2057 2058 2059 2060 2061 2062 2063 2064 2065 2066 2067 2068 2069 2070 2071 2072 2073 2074 2075 2076 2077 2078 2079 2080 2081 2082 2083 2084 2085 2086 2087 2088 2089 2090 2091 2092 2093 2094 2095 2096 2097 2098 2099 2100 2101 2102 2103 2104 2105 2106 2107 2108 2109 2110 2111 2112 2113 2114 2115 2116 2117 2118 2119 2120 2121 2122 2123 2124 2125 2126 2127 2128 2129 2130 2131 2132 2133 2134 2135 2136 2137 2138 2139 2140 2141 2142 2143 2144 2145 2146 2147 2148 2149 2150 2151 2152 2153 2154 2155 2156 2157 2158 2159 2160 2161 2162 2163 2164 2165 2166 2167 2168 2169 2170 2171 2172 2173 2174 2175 2176 2177 2178 2179 2180 2181 2182 2183 2184 2185 2186 2187 2188 2189 2190 2191 2192 2193 2194 2195 2196 2197 2198 2199 2200 2201 2202 2203 2204 2205 2206 2207 2208 2209 2210 2211 2212 2213 2214 2215 2216 2217 2218 2219 2220 2221 2222 2223 2224 2225 2226 2227 2228 2229 2230 2231 2232 2233 2234 2235 2236 2237 2238 2239 2240 2241 2242 2243 2244 2245 2246 2247 2248 2249 2250 2251 2252 2253 2254 2255 2256 2257 2258 2259 2260 2261 2262 2263 2264 2265 2266 2267 2268 2269 2270 2271 2272 2273 2274 2275 2276 2277 2278 2279 2280 2281 2282 2283 2284 2285 2286 2287 2288 2289 2290 2291 2292 2293 2294 2295 2296 2297 2298 2299 2300 2301 2302 2303 2304 2305 2306 2307 2308 2309 2310 2311 2312 2313 2314 2315 2316 2317 2318 2319 2320 2321 2322 2323 2324 2325 2326 2327 2328 2329 2330 2331 2332 2333 2334 2335 2336 2337 2338 2339 2340 2341 2342 2343 2344 2345 2346 2347 2348 2349 2350 2351 2352 2353 2354 2355 2356 2357 2358 2359 2360 2361 2362 2363 2364 2365 2366 2367 2368 2369 2370 2371 2372 2373 2374 2375 2376 2377 2378 2379 2380 2381 2382 2383 2384 2385 2386 2387 2388 2389 2390 2391 2392 2393 2394 2395 2396 2397 2398 2399 2400 2401 2402 2403 2404 2405 2406 2407 2408 2409 2410 2411 2412 2413 2414 2415 2416 2417 2418 2419 2420 2421 2422 2423 2424 2425 2426 2427 2428 2429 2430 2431 2432 2433 2434 2435 2436 2437 2438 2439 2440 2441 2442 2443 2444 2445 2446 2447 2448 2449 2450 2451 2452 2453 2454 2455 2456 2457 2458 2459 2460 2461 2462 2463 2464 2465 2466 2467 2468 2469 2470 2471 2472 2473 2474 2475 2476 2477 2478 2479 2480 2481 2482 2483 2484 2485 2486 2487 2488 2489 2490 2491 2492 2493 2494 2495 2496 2497 2498 2499 2500 2501 2502 2503 2504 2505 2506 2507 2508 2509 2510 2511 2512 2513 2514 2515 2516 2517 2518 2519 2520 2521 2522 2523 2524 2525 2526 2527 2528 2529 2530 2531 2532 2533 2534 2535 2536 2537 2538 2539 2540 2541 2542 2543 2544 2545 2546 2547 2548 2549 2550 2551 2552 2553 2554 2555 2556 2557 2558 2559 2560 2561 2562 2563 2564 2565 2566 2567 2568 2569 2570 2571 2572 2573 2574 2575 2576 2577 2578 2579 2580 2581 2582 2583 2584 2585 2586 2587 2588 2589 2590 2591 2592 2593 2594 2595 2596 2597 2598 2599 2600 2601 2602 2603 2604 2605 2606 2607 2608 2609 2610 2611 2612 2613 2614 2615 2616 2617 2618 2619 2620 2621 2622 2623 2624 2625 2626 2627 2628 2629 2630 2631 2632 2633 2634 2635 2636 2637 2638 2639 2640 2641 2642 2643 2644 2645 2646 2647 2648 2649 2650 2651 2652 2653 2654 2655 2656 2657 2658 2659 2660 2661 2662 2663 2664 2665 2666 2667 2668 2669 2670 2671 2672 2673 2674 2675 2676 2677 2678 2679 2680 2681 2682 2683 2684 2685 2686 2687 2688 2689 2690 2691 2692 2693 2694 2695 2696 2697 2698 2699 2700 2701 2702 2703 2704 2705 2706 2707 2708 2709 2710 2711 2712 2713 2714 2715 2716 2717 2718 2719 2720 2721 2722 2723 2724 2725 2726 2727 2728 2729 2730 2731 2732 2733 2734 2735 2736 2737 2738 2739 2740 2741 2742 2743 2744 2745 2746 2747 2748 2749 2750 2751 2752 2753 2754 2755 2756 2757 2758 2759 2760 2761 2762 2763 2764 2765 2766 2767 2768 2769 2770 2771 2772 2773 2774 2775 2776 2777 2778 2779 2780 2781 2782 2783 2784 2785 2786 2787 2788 2789 2790 2791 2792 2793 2794 2795 2796 2797 2798 2799 2800 2801 2802 2803 2804 2805 2806 2807 2808 2809 2810 2811 2812 2813 2814 2815 2816 2817 2818 2819 2820 2821 2822 2823 2824 2825 2826 2827 2828 2829 2830 2831 2832 2833 2834 2835 2836 2837 2838 2839 2840 2841 2842 2843 2844 2845 2846 2847 2848 2849 2850 2851 2852 2853 2854 2855 2856 2857 2858 2859 2860 2861 2862 2863 2864 2865 2866 2867 2868 2869 2870 2871 2872 2873 2874 2875 2876 2877 2878 2879 2880 2881 2882 2883 2884 2885 2886 2887 2888 2889 2890 2891 2892 2893 2894 2895 2896 2897 2898 2899 2900 2901 2902 2903 2904 2905 2906 2907 2908 2909 2910 2911 2912 2913 2914 2915 2916 2917 2918 2919 2920 2921 2922 2923 2924 2925 2926 2927 2928 2929 2930 2931 2932 2933 2934 2935 2936 2937 2938 2939 2940 2941 2942 2943 2944 2945 2946 2947 2948 2949 2950 2951 2952 2953 2954 2955 2956 2957 2958 2959 2960 2961 2962 2963 2964 2965 2966 2967 2968 2969 2970 2971 2972 2973 2974 2975 2976 2977 2978 2979 2980 2981 2982 2983 2984 2985 2986 2987 2988 2989 2990 2991 2992 2993 2994 2995 2996 2997 2998 2999 3000 3001 3002 3003 3004 3005 3006 3007 3008 3009 3010 3011 3012 3013 3014 3015 3016 3017 3018 3019 3020 3021 3022 3023 3024 3025 3026 3027 3028 3029 3030 3031 3032 3033 3034 3035 3036 3037 3038 3039 3040 3041 3042 3043 3044 3045 3046 3047 3048 3049 3050 3051 3052 3053 3054 3055 3056 3057 3058 3059 3060 3061 3062 3063 3064 3065 3066 3067 3068 3069 3070 3071 3072 3073 3074 3075 3076 3077 3078 3079 3080 3081 3082 3083 3084 3085 3086 3087 3088 3089 3090 3091 3092 3093 3094 3095 3096 3097 3098 3099 3100 3101 3102 3103 3104 3105 3106 3107 3108 3109 3110 3111 3112 3113 3114 3115 3116 3117 3118 3119 3120 3121 3122 3123 3124 3125 3126 3127 3128 3129 3130 3131 3132 3133 3134 3135 3136 3137 3138 3139 3140 3141 3142 3143 3144 3145 3146 3147 3148 3149 3150 3151 3152 3153 3154 3155 3156 3157 3158 3159 3160 3161 3162 3163 3164 3165 3166 3167 3168 3169 3170 3171 3172 3173 3174 3175 3176 3177 3178 3179 3180 3181 3182 3183 3184 3185 3186 3187 3188 3189 3190 3191 3192 3193 3194 3195 3196 3197 3198 3199 3200 3201 3202 3203 3204 3205 3206 3207 3208 3209 3210 3211 3212 3213 3214 3215 3216 3217 3218 3219 3220 3221 3222 3223 3224 3225 3226 3227 3228 3229 3230 3231 3232 3233 3234 3235 3236 3237 3238 3239 3240 3241 3242 3243 3244 3245 3246 3247 3248 3249 3250 3251 3252 3253 3254 3255 3256 3257 3258 3259 3260 3261 3262 3263 3264 3265 3266 3267 3268 3269 3270 3271 3272 3273 3274 3275 3276 3277 3278 3279 3280 3281 3282 3283 3284 3285 3286 3287 3288 3289 3290 3291 3292 3293 3294 3295 3296 3297 3298 3299 3300 3301 3302 3303 3304 3305 3306 3307 3308 3309 3310 3311 3312 3313 3314 3315 3316 3317 3318 3319 3320 3321 3322 3323 3324 3325 3326 3327 3328 3329 3330 3331 3332 3333 3334 3335 3336 3337 3338 3339 3340 3341 3342 3343 3344 3345 3346 3347 3348 3349 3350 3351 3352 3353 3354 3355 3356 3357 3358 3359 3360 3361 3362 3363 3364 3365 3366 3367 3368 3369 3370 3371 3372 3373 3374 3375 3376 3377 3378 3379 3380 3381 3382 3383 3384 3385 3386 3387 3388 3389 3390 3391 3392 3393 3394 3395 3396 3397 3398 3399 3400 3401 3402 3403 3404 3405 3406 3407 3408 3409 3410 3411 3412 3413 3414 3415 3416 3417 3418 3419 3420 3421 3422 3423 3424 3425 3426 3427 3428 3429 3430 3431 3432 3433 3434 3435 3436 3437 3438 3439 3440 3441 3442 3443 3444 3445 3446 3447 3448 3449 3450 3451 3452 3453 3454 3455 3456 3457 3458 3459 3460 3461 3462 3463 3464 3465 3466 3467 3468 3469 3470 3471 3472 3473 3474 3475 3476 3477 3478 3479 3480 3481 3482 3483 3484 3485 3486 3487 3488 3489 3490 3491 3492 3493 3494 3495 3496 3497 3498 3499 3500 3501 3502 3503 3504 3505 3506 3507 3508 3509 3510 3511 3512 3513 3514 3515 3516 3517 3518 3519 3520 3521 3522 3523 3524 3525 3526 3527 3528 3529 3530 3531 3532 3533 3534 3535 3536 3537 3538 3539 3540 3541 3542 3543 3544 3545 3546 3547 3548 3549 3550 3551 3552 3553 3554 3555 3556 3557 3558 3559 3560 3561 3562 3563 3564 3565 3566 3567 3568 3569 3570 3571 3572 3573 3574 3575 3576 3577 3578 3579 3580 3581 3582 3583 3584 3585 3586 3587 3588 3589 3590 3591 3592 3593 3594 3595 3596 3597 3598 3599 3600 3601 3602 3603 3604 3605 3606 3607 3608 3609 3610 3611 3612 3613 3614 3615 3616 3617 3618 3619 3620 3621 3622 3623 3624 3625 3626 3627 3628 3629 3630 3631 3632 3633 3634 3635 3636 3637 3638 3639 3640 3641 3642 3643 3644 3645 3646 3647 3648 3649 3650 3651 3652 3653 3654 3655 3656 3657 3658 3659 3660 3661 3662 3663 3664 3665 3666 3667 3668 3669 3670 3671 3672 3673 3674 3675 3676 3677 3678 3679 3680 3681 3682 3683 3684 3685 3686 3687 3688 3689 3690 3691 3692 3693 3694 3695 3696 3697 3698 3699 3700 3701 3702 3703 3704 3705 3706 3707 3708 3709 3710 3711 3712 3713 3714 3715 3716 3717 3718 3719 3720 3721 3722 3723 3724 3725 3726 3727 3728 3729 3730 3731 3732 3733 3734 3735 3736 3737 3738 3739 3740 3741 3742 3743 3744 3745 3746 3747 3748 3749 3750 3751 3752 3753 3754 3755 3756 3757 3758 3759 3760 3761 3762 3763 3764 3765 3766 3767 3768 3769 3770 3771 3772 3773 3774 3775 3776 3777 3778 3779 3780 3781 3782 3783 3784 3785 3786 3787 3788 3789 3790 3791 3792 3793 3794 3795 3796 3797 3798 3799 3800 3801 3802 3803 3804 3805 3806 3807 3808 3809 3810 3811 3812 3813 3814 3815 3816 3817 3818 3819 3820 3821 3822 3823 3824 3825 3826 3827 3828 3829 3830 3831 3832 3833 3834 3835 3836 3837 3838 3839 3840 3841 3842 3843 3844 3845 3846 3847 3848 3849 3850 3851 3852 3853 3854 3855 3856 3857 3858 3859 3860 3861 3862 3863 3864 3865 3866 3867 3868 3869 3870 3871 3872 3873 3874 3875 3876 3877 3878 3879 3880 3881 3882 3883 3884 3885 3886 3887 3888 3889 3890 3891 3892 3893 3894 3895 3896 3897 3898 3899 3900 3901 3902 3903 3904 3905 3906 3907 3908 3909 3910 3911 3912 3913 3914 3915 3916 3917 3918 3919 3920 3921 3922 3923 3924 3925 3926 3927 3928 3929 3930 3931 3932 3933 3934 3935 3936 3937 3938 3939 3940 3941 3942 3943 3944 3945 3946 3947 3948 3949 3950 3951 3952 3953 3954 3955 3956 3957 3958 3959 3960 3961 3962 3963 3964 3965 3966 3967 3968 3969 3970 3971 3972 3973 3974 3975 3976 3977 3978 3979 3980 3981 3982 3983 3984 3985 3986 3987 3988 3989 3990 3991 3992 3993 3994 3995 3996 3997 3998 3999 4000 4001 4002 4003 4004 4005 4006 4007 4008 4009 4010 4011 4012 4013 4014 4015 4016 4017 4018 4019 4020 4021 4022 4023 4024 4025 4026 4027 4028 4029 4030 4031 4032 4033 4034 4035 4036 4037 4038 4039 4040 4041 4042 4043 4044 4045 4046 4047 4048 4049 4050 4051 4052 4053 4054 4055 4056 4057 4058 4059 4060 4061 4062 4063 4064 4065 4066 4067 4068 4069 4070 4071 4072 4073 4074 4075 4076 4077 4078 4079 4080 4081 4082 4083 4084 4085 4086 4087 4088 4089 4090 4091 4092 4093 4094 4095 4096 4097 4098 4099 4100 4101 4102 4103 4104 4105 4106 4107 4108 4109 4110 4111 4112 4113 4114 4115 4116 4117 4118 4119 4120 4121 4122 4123 4124 4125 4126 4127 4128 4129 4130 4131 4132 4133 4134 4135 4136 4137 4138 4139 4140 4141 4142 4143 4144 4145 4146 4147 4148 4149 4150 4151 4152 4153 4154 4155 4156 4157 4158 4159 4160 4161 4162 4163 4164 4165 4166 4167 4168 4169 4170 4171 4172 4173 4174 4175 4176 4177 4178 4179 4180 4181 4182 4183 4184 4185 4186 4187 4188 4189 4190 4191 4192 4193 4194 4195 4196 4197 4198 4199 4200 4201 4202 4203 4204 4205 4206 4207 4208 4209 4210 4211 4212 4213 4214 4215 4216 4217 4218 4219 4220 4221 4222 4223 4224 4225 4226 4227 4228 4229 4230 4231 4232 4233 4234 4235 4236 4237 4238 4239 4240 4241 4242 4243 4244 4245 4246 4247 4248 4249 4250 4251 4252 4253 4254 4255 4256 4257 4258 4259 4260 4261 4262 4263 4264 4265 4266 4267 4268 4269 4270 4271 4272 4273 4274 4275 4276 4277 4278 4279 4280 4281 4282 4283 4284 4285 4286 4287 4288 4289 4290 4291 4292 4293 4294 4295 4296 4297 4298 4299 4300 4301 4302 4303 4304 4305 4306 4307 4308 4309 4310 4311 4312 4313 4314 4315 4316 4317 4318 4319 4320 4321 4322 4323 4324 4325 4326 4327 4328 4329 4330 4331 4332 4333 4334 4335 4336 4337 4338 4339 4340 4341 4342 4343 4344 4345 4346 4347 4348 4349 4350 4351 4352 4353 4354 4355 4356 4357 4358 4359 4360 4361 4362 4363 4364 4365 4366 4367 4368 4369 4370 4371 4372 4373 4374 4375 4376 4377 4378 4379 4380 4381 4382 4383 4384 4385 4386 4387 4388 4389 4390 4391 4392 4393 4394 4395 4396 4397 4398 4399 4400 4401 4402 4403 4404 4405 4406 4407 4408 4409 4410 4411 4412 4413 4414 4415 4416 4417 4418 4419 4420 4421 4422 4423 4424 4425 4426 4427 4428 4429 4430 4431 4432 4433 4434 4435 4436 4437 4438 4439 4440 4441 4442 4443 4444 4445 4446 4447 4448 4449 4450 4451 4452 4453 4454 4455 4456 4457 4458 4459 4460 4461 4462 4463 4464 4465 4466 4467 4468 4469 4470 4471 4472 4473 4474 4475 4476 4477 4478 4479 4480 4481 4482 4483 4484 4485 4486 4487 4488 4489 4490 4491 4492 4493 4494 4495 4496 4497 4498 4499 4500 4501 4502 4503 4504 4505 4506 4507 4508 4509 4510 4511 4512 4513 4514 4515 4516 4517 4518 4519 4520 4521 4522 4523 4524 4525 4526 4527 4528 4529 4530 4531 4532 4533 4534 4535 4536 4537 4538 4539 4540 4541 4542 4543 4544 4545 4546 4547 4548 4549 4550 4551 4552 4553 4554 4555 4556 4557 4558 4559 4560 4561 4562 4563 4564 4565 4566 4567 4568 4569 4570 4571 4572 4573 4574 4575 4576 4577 4578 4579 4580 4581 4582 4583 4584 4585 4586 4587 4588 4589 4590 4591 4592 4593 4594 4595 4596 4597 4598 4599 4600 4601 4602 4603 4604 4605 4606 4607 4608 4609 4610 4611 4612 4613 4614 4615 4616 4617 4618 4619 4620 4621 4622 4623 4624 4625 4626 4627 4628 4629 4630 4631 4632 4633 4634 4635 4636 4637 4638 4639 4640 4641 4642 4643 4644 4645 4646 4647 4648 4649 4650 4651 4652 4653 4654 4655 4656 4657 4658 4659 4660 4661 4662 4663 4664 4665 4666 4667 4668 4669 4670 4671 4672 4673 4674 4675 4676 4677 4678 4679 4680 4681 4682 4683 4684 4685 4686 4687 4688 4689 4690 4691 4692 4693 4694 4695 4696 4697 4698 4699 4700 4701 4702 4703 4704 4705 4706 4707 4708 4709 4710 4711 4712 4713 4714 4715 4716 4717 4718 4719 4720 4721 4722 4723 4724 4725 4726 4727 4728 4729 4730 4731 4732 4733 4734 4735 4736 4737 4738 4739 4740 4741 4742 4743 4744 4745 4746 4747 4748 4749 4750 4751 4752 4753 4754 4755 4756 4757 4758 4759 4760 4761 4762 4763 4764 4765 4766 4767 4768 4769 4770 4771 4772 4773 4774 4775 4776 4777 4778 4779 4780 4781 4782 4783 4784 4785 4786 4787 4788 4789 4790 4791 4792 4793 4794 4795 4796 4797 4798 4799 4800 4801 4802 4803 4804 4805 4806 4807 4808 4809 4810 4811 4812 4813 4814 4815 4816 4817 4818 4819 4820 4821 4822 4823 4824 4825 4826 4827 4828 4829 4830 4831 4832 4833 4834 4835 4836 4837 4838 4839 4840 4841 4842 4843 4844 4845 4846 4847 4848 4849 4850 4851 4852 4853 4854 4855 4856 4857 4858 4859 4860 4861 4862 4863 4864 4865 4866 4867 4868 4869 4870 4871 4872 4873 4874 4875 4876 4877 4878 4879 4880 4881 4882 4883 4884 4885 4886 4887 4888 4889 4890 4891 4892 4893 4894 4895 4896 4897 4898 4899 4900 4901 4902 4903 4904 4905 4906 4907 4908 4909 4910 4911 4912 4913 4914 4915 4916 4917 4918 4919 4920 4921 4922 4923 4924 4925 4926 4927 4928 4929 4930 4931 4932 4933 4934 4935 4936 4937 4938 4939 4940 4941 4942 4943 4944 4945 4946 4947 4948 4949 4950 4951 4952 4953 4954 4955 4956 4957 4958 4959 4960 4961 4962 4963 4964 4965 4966 4967 4968 4969 4970 4971 4972 4973 4974 4975 4976 4977 4978 4979 4980 4981 4982 4983 4984 4985 4986 4987 4988 4989 4990 4991 4992 4993 4994 4995 4996 4997 4998 4999 5000 5001 5002 5003 5004 5005 5006 5007 5008 5009 5010 5011 5012 5013 5014 5015 5016 5017 5018 5019 5020 5021 5022 5023 5024 5025 5026 5027 5028 5029 5030 5031 5032 5033 5034 5035 5036 5037 5038 5039 5040 5041 5042 5043 5044 5045 5046 5047 5048 5049 5050 5051 5052 5053 5054 5055 5056 5057 5058 5059 5060 5061 5062 5063 5064 5065 5066 5067 5068 5069 5070 5071 5072 5073 5074 5075 5076 5077 5078 5079 5080 5081 5082 5083 5084 5085 5086 5087 5088 5089 5090 5091 5092 5093 5094 5095 5096 5097 5098 5099 5100 5101 5102 5103 5104 5105 5106 5107 5108 5109 5110 5111 5112 5113 5114 5115 5116 5117 5118 5119 5120 5121 5122 5123 5124 5125 5126 5127 5128 5129 5130 5131 5132 5133 5134 5135 5136 5137 5138 5139 5140 5141 5142 5143 5144 5145 5146 5147 5148 5149 5150 5151 5152 5153 5154 5155 5156 5157 5158 5159 5160 5161 5162 5163 5164 5165 5166 5167 5168 5169 5170 5171 5172 5173 5174 5175 5176 5177 5178 5179 5180 5181 5182 5183 5184 5185 5186 5187 5188 5189 5190 5191 5192 5193 5194 5195 5196 5197 5198 5199 5200 5201 5202 5203 5204 5205 5206 5207 5208 5209 5210 5211 5212 5213 5214 5215 5216 5217 5218 5219 5220 5221 5222 5223 5224 5225 5226 5227 5228 5229 5230 5231 5232 5233 5234 5235 5236 5237 5238 5239 5240 5241 5242 5243 5244 5245 5246 5247 5248 5249 5250 5251 5252 5253 5254 5255 5256 5257 5258 5259 5260 5261 5262 5263 5264 5265 5266 5267 5268 5269 5270 5271 5272 5273 5274 5275 5276 5277 5278 5279 5280 5281 5282 5283 5284 5285 5286 5287 5288 5289 5290 5291 5292 5293 5294 5295 5296 5297 5298 5299 5300 5301 5302 5303 5304 5305 5306 5307 5308 5309 5310 5311 5312 5313 5314 5315 5316 5317 5318 5319 5320 5321 5322 5323 5324 5325 5326 5327 5328 5329 5330 5331 5332 5333 5334 5335 5336 5337 5338 5339 5340 5341 5342 5343 5344 5345 5346 5347 5348 5349 5350 5351 5352 5353 5354 5355 5356 5357 5358 5359 5360 5361 5362 5363 5364 5365 5366 5367 5368 5369 5370 5371 5372 5373 5374 5375 5376 5377 5378 5379 5380 5381 5382 5383 5384 5385 5386 5387 5388 5389 5390 5391 5392 5393 5394 5395 5396 5397 5398 5399 5400 5401 5402 5403 5404 5405 5406 5407 5408 5409 5410 5411 5412 5413 5414 5415 5416 5417 5418 5419 5420 5421 5422 5423 5424 5425 5426 5427 5428 5429 5430 5431 5432 5433 5434 5435 5436 5437 5438 5439 5440 5441 5442 5443 5444 5445 5446 5447 5448 5449 5450 5451 5452 5453 5454 5455 5456 5457 5458 5459 5460 5461 5462 5463 5464 5465 5466 5467 5468 5469 5470 5471 5472 5473 5474 5475 5476 5477 5478 5479 5480 5481 5482 5483 5484 5485 5486 5487 5488 5489 5490 5491 5492 5493 5494 5495 5496 5497 5498 5499 5500 5501 5502 5503 5504 5505 5506 5507 5508 5509 5510 5511 5512 5513 5514 5515 5516 5517 5518 5519 5520 5521 5522 5523 5524 5525 5526 5527 5528 5529 5530 5531 5532 5533 5534 5535 5536 5537 5538 5539 5540 5541 5542 5543 5544 5545 5546 5547 5548 5549 5550 5551 5552 5553 5554 5555 5556 5557 5558 5559 5560 5561 5562 5563 5564 5565 5566 5567 5568 5569 5570 5571 5572 5573 5574 5575 5576 5577 5578 5579 5580 5581 5582 5583 5584 5585 5586 5587 5588 5589 5590 5591 5592 5593 5594 5595 5596 5597 5598 5599 5600 5601 5602 5603 5604 5605 5606 5607 5608 5609 5610 5611 5612 5613 5614 5615 5616 5617 5618 5619 5620 5621 5622 5623 5624 5625 5626 5627 5628 5629 5630 5631 5632 5633 5634 5635 5636 5637 5638 5639 5640 5641 5642 5643 5644 5645 5646 5647 5648 5649 5650 5651 5652 5653 5654 5655 5656 5657 5658 5659 5660 5661 5662 5663 5664 5665 5666 5667 5668 5669 5670 5671 5672 5673 5674 5675 5676 5677 5678 5679 5680 5681 5682 5683 5684 5685 5686 5687 5688 5689 5690 5691 5692 5693 5694 5695 5696 5697 5698 5699 5700 5701 5702 5703 5704 5705 5706 5707 5708 5709 5710 5711 5712 5713 5714 5715 5716 5717 5718 5719 5720 5721 5722 5723 5724 5725 5726 5727 5728 5729 5730 5731 5732 5733 5734 5735 5736 5737 5738 5739 5740 5741 5742 5743 5744 5745 5746 5747 5748 5749 5750 5751 5752 5753 5754 5755 5756 5757 5758 5759 5760 5761 5762 5763 5764 5765 5766 5767 5768 5769 5770 5771 5772 5773 5774 5775 5776 5777 5778 5779 5780 5781 5782 5783 5784 5785 5786 5787 5788 5789 5790 5791 5792 5793 5794 5795 5796 5797 5798 5799 5800 5801 5802 5803 5804 5805 5806 5807 5808 5809 5810 5811 5812 5813 5814 5815 5816 5817 5818 5819 5820 5821 5822 5823 5824 5825 5826 5827 5828 5829 5830 5831 5832 5833 5834 5835 5836 5837 5838 5839 5840 5841 5842 5843 5844 5845 5846 5847 5848 5849 5850 5851 5852 5853 5854 5855 5856 5857 5858 5859 5860 5861 5862 5863 5864 5865 5866 5867 5868 5869 5870 5871 5872 5873 5874 5875 5876 5877 5878 5879 5880 5881 5882 5883 5884 5885 5886 5887 5888 5889 5890 5891 5892 5893 5894 5895 5896 5897 5898 5899 5900 5901 5902 5903 5904 5905 5906 5907 5908 5909 5910 5911 5912 5913 5914 5915 5916 5917 5918 5919 5920 5921 5922 5923 5924 5925 5926 5927 5928 5929 5930 5931 5932 5933 5934 5935 5936 5937 5938 5939 5940 5941 5942 5943 5944 5945 5946 5947 5948 5949 5950 5951 5952 5953 5954 5955 5956 5957 5958 5959 5960 5961 5962 5963 5964 5965 5966 5967 5968 5969 5970 5971 5972 5973 5974 5975 5976 5977 5978 5979 5980 5981 5982 5983 5984 5985 5986 5987 5988 5989 5990 5991 5992 5993 5994 5995 5996 5997 5998 5999 6000 6001 6002 6003 6004 6005 6006 6007 6008 6009 6010 6011 6012 6013 6014 6015 6016 6017 6018 6019 6020 6021 6022 6023 6024 6025 6026 6027 6028 6029 6030 6031 6032 6033 6034 6035 6036 6037 6038 6039 6040 6041 6042 6043 6044 6045 6046 6047 6048 6049 6050 6051 6052 6053 6054 6055 6056 6057 6058 6059 6060 6061 6062 6063 6064 6065 6066 6067 6068 6069 6070 6071 6072 6073 6074 6075 6076 6077 6078 6079 6080 6081 6082 6083 6084 6085 6086 6087 6088 6089 6090 6091 6092 6093 6094 6095 6096 6097 6098 6099 6100 6101 6102 6103 6104 6105 6106 6107 6108 6109 6110 6111 6112 6113 6114 6115 6116 6117 6118 6119 6120 6121 6122 6123 6124 6125 6126 6127 6128 6129 6130 6131 6132 6133 6134 6135 6136 6137 6138 6139 6140 6141 6142 6143 6144 6145 6146 6147 6148 6149 6150 6151 6152 6153 6154 6155 6156 6157 6158 6159 6160 6161 6162 6163 6164 6165 6166 6167 6168 6169 6170 6171 6172 6173 6174 6175 6176 6177 6178 6179 6180 6181 6182 6183 6184 6185 6186 6187 6188 6189 6190 6191 6192 6193 6194 6195 6196 6197 6198 6199 6200 6201 6202 6203 6204 6205 6206 6207 6208 6209 6210 6211 6212 6213 6214 6215 6216 6217 6218 6219 6220 6221 6222 6223 6224 6225 6226 6227 6228 6229 6230 6231 6232 6233 6234 6235 6236 6237 6238 6239 6240 6241 6242 6243 6244 6245 6246 6247 6248 6249 6250 6251 6252 6253 6254 6255 6256 6257 6258 6259 6260 6261 6262 6263 6264 6265 6266 6267 6268 6269 6270 6271 6272 6273 6274 6275 6276 6277 6278 6279 6280 6281 6282 6283 6284 6285 6286 6287 6288 6289 6290 6291 6292 6293 6294 6295 6296 6297 6298 6299 6300 6301 6302 6303 6304 6305 6306 6307 6308 6309 6310 6311 6312 6313 6314 6315 6316 6317 6318 6319 6320 6321 6322 6323 6324 6325 6326 6327 6328 6329 6330 6331 6332 6333 6334 6335 6336 6337 6338 6339 6340 6341 6342 6343 6344 6345 6346 6347 6348 6349 6350 6351 6352 6353 6354 6355 6356 6357 6358 6359 6360 6361 6362 6363 6364 6365 6366 6367 6368 6369 6370 6371 6372 6373 6374 6375 6376 6377 6378 6379 6380 6381 6382 6383 6384 6385 6386 6387 6388 6389 6390 6391 6392 6393 6394 6395 6396 6397 6398 6399 6400 6401 6402 6403 6404 6405 6406 6407 6408 6409 6410 6411 6412 6413 6414 6415 6416 6417 6418 6419 6420 6421 6422 6423 6424 6425 6426 6427 6428 6429 6430 6431 6432 6433 6434 6435 6436 6437 6438 6439 6440 6441 6442 6443 6444 6445 6446 6447 6448 6449 6450 6451 6452 6453 6454 6455 6456 6457 6458 6459 6460 6461 6462 6463 6464 6465 6466 6467 6468 6469 6470 6471 6472 6473 6474 6475 6476 6477 6478 6479 6480 6481 6482 6483 6484 6485 6486 6487 6488 6489 6490 6491 6492 6493 6494 6495 6496 6497 6498 6499 6500 6501 6502 6503 6504 6505 6506 6507 6508 6509 6510 6511 6512 6513 6514 6515 6516 6517 6518 6519 6520 6521 6522 6523 6524 6525 6526 6527 6528 6529 6530 6531 6532 6533 6534 6535 6536 6537 6538 6539 6540 6541 6542 6543 6544 6545 6546 6547 6548 6549 6550 6551 6552 6553 6554 6555 6556 6557 6558 6559 6560 6561 6562 6563 6564 6565 6566 6567 6568 6569 6570 6571 6572 6573 6574 6575 6576 6577 6578 6579 6580 6581 6582 6583 6584 6585 6586 6587 6588 6589 6590 6591 6592 6593 6594 6595 6596 6597 6598 6599 6600 6601 6602 6603 6604 6605 6606 6607 6608 6609 6610 6611 6612 6613 6614 6615 6616 6617 6618 6619 6620 6621 6622 6623 6624 6625 6626 6627 6628 6629 6630 6631 6632 6633 6634 6635 6636 6637 6638 6639 6640 6641 6642 6643 6644 6645 6646 6647 6648 6649 6650 6651 6652 6653 6654 6655 6656 6657 6658 6659 6660 6661 6662 6663 6664 6665 6666 6667 6668 6669 6670 6671 6672 6673 6674 6675 6676 6677 6678 6679 6680 6681 6682 6683 6684 6685 6686 6687 6688 6689 6690 6691 6692 6693 6694 6695 6696 6697 6698 6699 6700 6701 6702 6703 6704 6705 6706 6707 6708 6709 6710 6711 6712 6713 6714 6715 6716 6717 6718 6719 6720 6721 6722 6723 6724 6725 6726 6727 6728 6729 6730 6731 6732 6733 6734 6735 6736 6737 6738 6739 6740 6741 6742 6743 6744 6745 6746 6747 6748 6749 6750 6751 6752 6753 6754 6755 6756 6757 6758 6759 6760 6761 6762 6763 6764 6765 6766 6767 6768 6769 6770 6771 6772 6773 6774 6775 6776 6777 6778 6779 6780 6781 6782 6783 6784 6785 6786 6787 6788 6789 6790 6791 6792 6793 6794 6795 6796 6797 6798 6799 6800 6801 6802 6803 6804 6805 6806 6807 6808 6809 6810 6811 6812 6813 6814 6815 6816 6817 6818 6819 6820 6821 6822 6823 6824 6825 6826 6827 6828 6829 6830 6831 6832 6833 6834 6835 6836 6837 6838 6839 6840 6841 6842 6843 6844 6845 6846 6847 6848 6849 6850 6851 6852 6853 6854 6855 6856 6857 6858 6859 6860 6861 6862 6863 6864 6865 6866 6867 6868 6869 6870 6871 6872 6873 6874 6875 6876 6877 6878 6879 6880 6881 6882 6883 6884 6885 6886 6887 6888 6889 6890 6891 6892 6893 6894 6895 6896 6897 6898 6899 6900 6901 6902 6903 6904 6905 6906 6907 6908 6909 6910 6911 6912 6913 6914 6915 6916 6917 6918 6919 6920 6921 6922 6923 6924 6925 6926 6927 6928 6929 6930 6931 6932 6933 6934 6935 6936 6937 6938 6939 6940 6941 6942 6943 6944 6945 6946 6947 6948 6949 6950 6951 6952 6953 6954 6955 6956 6957 6958 6959 6960 6961 6962 6963 6964 6965 6966 6967 6968 6969 6970 6971 6972 6973 6974 6975 6976 6977 6978 6979 6980 6981 6982 6983 6984 6985 6986 6987 6988 6989 6990 6991 6992 6993 6994 6995 6996 6997 6998 6999 7000 7001 7002 7003 7004 7005 7006 7007 7008 7009 7010 7011 7012 7013 7014 7015 7016 7017 7018 7019 7020 7021 7022 7023 7024 7025 7026 7027 7028 7029 7030 7031 7032 7033 7034 7035 7036 7037 7038 7039 7040 7041 7042 7043 7044 7045 7046 7047 7048 7049 7050 7051 7052 7053 7054 7055 7056 7057 7058 7059 7060 7061 7062 7063 7064 7065 7066 7067 7068 7069 7070 7071 7072 7073 7074 7075 7076 7077 7078 7079 7080 7081 7082 7083 7084 7085 7086 7087 7088 7089 7090 7091 7092 7093 7094 7095 7096 7097 7098 7099 7100 7101 7102 7103 7104 7105 7106 7107 7108 7109 7110 7111 7112 7113 7114 7115 7116 7117 7118 7119 7120 7121 7122 7123 7124 7125 7126 7127 7128 7129 7130 7131 7132 7133 7134 7135 7136 7137 7138 7139 7140 7141 7142 7143 7144 7145 7146 7147 7148 7149 7150 7151 7152 7153 7154 7155 7156 7157 7158 7159 7160 7161 7162 7163 7164 7165 7166 7167 7168 7169 7170 7171 7172 7173 7174 7175 7176 7177 7178 7179 7180 7181 7182 7183 7184 7185 7186 7187 7188 7189 7190 7191 7192 7193 7194 7195 7196 7197 7198 7199 7200 7201 7202 7203 7204 7205 7206 7207 7208 7209 7210 7211 7212 7213 7214 7215 7216 7217 7218 7219 7220 7221 7222 7223 7224 7225 7226 7227 7228 7229 7230 7231 7232 7233 7234 7235 7236 7237 7238 7239 7240 7241 7242 7243 7244 7245 7246 7247 7248 7249 7250 7251 7252 7253 7254 7255 7256 7257 7258 7259 7260 7261 7262 7263 7264 7265 7266 7267 7268 7269 7270 7271 7272 7273 7274 7275 7276 7277 7278 7279 7280 7281 7282 7283 7284 7285 7286 7287 7288 7289 7290 7291 7292 7293 7294 7295 7296 7297 7298 7299 7300 7301 7302 7303 7304 7305 7306 7307 7308 7309 7310 7311 7312 7313 7314 7315 7316 7317 7318 7319 7320 7321 7322 7323 7324 7325 7326 7327 7328 7329 7330 7331 7332 7333 7334 7335 7336 7337 7338 7339 7340 7341 7342 7343 7344 7345 7346 7347 7348 7349 7350 7351 7352 7353 7354 7355 7356 7357 7358 7359 7360 7361 7362 7363 7364 7365 7366 7367 7368 7369 7370 7371 7372 7373 7374 7375 7376 7377 7378 7379 7380 7381 7382 7383 7384 7385 7386 7387 7388 7389 7390 7391 7392 7393 7394 7395 7396 7397 7398 7399 7400 7401 7402 7403 7404 7405 7406 7407 7408 7409 7410 7411 7412 7413 7414 7415 7416 7417 7418 7419 7420 7421 7422 7423 7424 7425 7426 7427 7428 7429 7430 7431 7432 7433 7434 7435 7436 7437 7438 7439 7440 7441 7442 7443 7444 7445 7446 7447 7448 7449 7450 7451 7452 7453 7454 7455 7456 7457 7458 7459 7460 7461 7462 7463 7464 7465 7466 7467 7468 7469 7470 7471 7472 7473 7474 7475 7476 7477 7478 7479 7480 7481 7482 7483 7484 7485 7486 7487 7488 7489 7490 7491 7492 7493 7494 7495 7496 7497 7498 7499 7500 7501 7502 7503 7504 7505 7506 7507 7508 7509 7510 7511 7512 7513 7514 7515 7516 7517 7518 7519 7520 7521 7522 7523 7524 7525 7526 7527 7528 7529 7530 7531 7532 7533 7534 7535 7536 7537 7538 7539 7540 7541 7542 7543 7544 7545 7546 7547 7548 7549 7550 7551 7552 7553 7554 7555 7556 7557 7558 7559 7560 7561 7562 7563 7564 7565 7566 7567 7568 7569 7570 7571 7572 7573 7574 7575 7576 7577 7578 7579 7580 7581 7582 7583 7584 7585 7586 7587 7588 7589 7590 7591 7592 7593 7594 7595 7596 7597 7598 7599 7600 7601 7602 7603 7604 7605 7606 7607 7608 7609 7610 7611 7612 7613 7614 7615 7616 7617 7618 7619 7620 7621 7622 7623 7624 7625 7626 7627 7628 7629 7630 7631 7632 7633 7634 7635 7636 7637 7638 7639 7640 7641 7642 7643 7644 7645 7646 7647 7648 7649 7650 7651 7652 7653 7654 7655 7656 7657 7658 7659 7660 7661 7662 7663 7664 7665 7666 7667 7668 7669 7670 7671 7672 7673 7674 7675 7676 7677 7678 7679 7680 7681 7682 7683 7684 7685 7686 7687 7688 7689 7690 7691 7692 7693 7694 7695 7696 7697 7698 7699 7700 7701 7702 7703 7704 7705 7706 7707 7708 7709 7710 7711 7712 7713 7714 7715 7716 7717 7718 7719 7720 7721 7722 7723 7724 7725 7726 7727 7728 7729 7730 7731 7732 7733 7734 7735 7736 7737 7738 7739 7740 7741 7742 7743 7744 7745 7746 7747 7748 7749 7750 7751 7752 7753 7754 7755 7756 7757 7758 7759 7760 7761 7762 7763 7764 7765 7766 7767 7768 7769 7770 7771 7772 7773 7774 7775 7776 7777 7778 7779 7780 7781 7782 7783 7784 7785 7786 7787 7788 7789 7790 7791 7792 7793 7794 7795 7796 7797 7798 7799 7800 7801 7802 7803 7804 7805 7806 7807 7808 7809 7810 7811 7812 7813 7814 7815 7816 7817 7818 7819 7820 7821 7822 7823 7824 7825 7826 7827 7828 7829 7830 7831 7832 7833 7834 7835 7836 7837 7838 7839 7840 7841 7842 7843 7844 7845 7846 7847 7848 7849 7850 7851 7852 7853 7854 7855 7856 7857 7858 7859 7860 7861 7862 7863 7864 7865 7866 7867 7868 7869 7870 7871 7872 7873 7874 7875 7876 7877 7878 7879 7880 7881 7882 7883 7884 7885 7886 7887 7888 7889 7890 7891 7892 7893 7894 7895 7896 7897 7898 7899 7900 7901 7902 7903 7904 7905 7906 7907 7908 7909 7910 7911 7912 7913 7914 7915 7916 7917 7918 7919 7920 7921 7922 7923 7924 7925 7926 7927 7928 7929 7930 7931 7932 7933 7934 7935 7936 7937 7938 7939 7940 7941 7942 7943 7944 7945 7946 7947 7948 7949 7950 7951 7952 7953 7954 7955 7956 7957 7958 7959 7960 7961 7962 7963 7964 7965 7966 7967 7968 7969 7970 7971 7972 7973 7974 7975 7976 7977 7978 7979 7980 7981 7982 7983 7984 7985 7986 7987 7988 7989 7990 7991 7992 7993 7994 7995 7996 7997 7998 7999 8000 8001 8002 8003 8004 8005 8006 8007 8008 8009 8010 8011 8012 8013 8014 8015 8016 8017 8018 8019 8020 8021 8022 8023 8024 8025 8026 8027 8028 8029 8030 8031 8032 8033 8034 8035 8036 8037 8038 8039 8040 8041 8042 8043 8044 8045 8046 8047 8048 8049 8050 8051 8052 8053 8054 8055 8056 8057 8058 8059 8060 8061 8062 8063 8064 8065 8066 8067 8068 8069 8070 8071 8072 8073 8074 8075 8076 8077 8078 8079 8080 8081 8082 8083 8084 8085 8086 8087 8088 8089 8090 8091 8092 8093 8094 8095 8096 8097 8098 8099 8100 8101 8102 8103 8104 8105 8106 8107 8108 8109 8110 8111 8112 8113 8114 8115 8116 8117 8118 8119 8120 8121 8122 8123 8124 8125 8126 8127 8128 8129 8130 8131 8132 8133 8134 8135 8136 8137 8138 8139 8140 8141 8142 8143 8144 8145 8146 8147 8148 8149 8150 8151 8152 8153 8154 8155 8156 8157 8158 8159 8160 8161 8162 8163 8164 8165 8166 8167 8168 8169 8170 8171 8172 8173 8174 8175 8176 8177 8178 8179 8180 8181 8182 8183 8184 8185 8186 8187 8188 8189 8190 8191 8192 8193 8194 8195 8196 8197 8198 8199 8200 8201 8202 8203 8204 8205 8206 8207 8208 8209 8210 8211 8212 8213 8214 8215 8216 8217 8218 8219 8220 8221 8222 8223 8224 8225 8226 8227 8228 8229 8230 8231 8232 8233 8234 8235 8236 8237 8238 8239 8240 8241 8242 8243 8244 8245 8246 8247 8248 8249 8250 8251 8252 8253 8254 8255 8256 8257 8258 8259 8260 8261 8262 8263 8264 8265 8266 8267 8268 8269 8270 8271 8272 8273 8274 8275 8276 8277 8278 8279 8280 8281 8282 8283 8284 8285 8286 8287 8288 8289 8290 8291 8292 8293 8294 8295 8296 8297 8298 8299 8300 8301 8302 8303 8304 8305 8306 8307 8308 8309 8310 8311 8312 8313 8314 8315 8316 8317 8318 8319 8320 8321 8322 8323 8324 8325 8326 8327 8328 8329 8330 8331 8332 8333 8334 8335 8336 8337 8338 8339 8340 8341 8342 8343 8344 8345 8346 8347 8348 8349 8350 8351 8352 8353 8354 8355 8356 8357 8358 8359 8360 8361 8362 8363 8364 8365 8366 8367 8368 8369 8370 8371 8372 8373 8374 8375 8376 8377 8378 8379 8380 8381 8382 8383 8384 8385 8386 8387 8388 8389 8390 8391 8392 8393 8394 8395 8396 8397 8398 8399 8400 8401 8402 8403 8404 8405 8406 8407 8408 8409 8410 8411 8412 8413 8414 8415 8416 8417 8418 8419 8420 8421 8422 8423 8424 8425 8426 8427 8428 8429 8430 8431 8432 8433 8434 8435 8436 8437 8438 8439 8440 8441 8442 8443 8444 8445 8446 8447 8448 8449 8450 8451 8452 8453 8454 8455 8456 8457 8458 8459 8460 8461 8462 8463 8464 8465 8466 8467 8468 8469 8470 8471 8472 8473 8474 8475 8476 8477 8478 8479 8480 8481 8482 8483 8484 8485 8486 8487 8488 8489 8490 8491
|
commit a687c9671981c5f06e1a679f5ecf1407bbf21ad6
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Mar 22 21:55:30 2011 -1000
New version.
commit 99d144c414a62d017f4cce076aaadb86e278650d
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Mar 22 21:52:58 2011 -1000
Fix ConstraintNewTestCase in tests/parted
commit 6f3f39262cbc1b6d20581c835e2cdfe661975bfb
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Mar 22 17:21:27 2011 -1000
Fix FreshDiskTestCase and VersionTestCase in tests/parted.
commit 76187f55e49796506c01919813cc42e19082f09b
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Mar 22 17:20:28 2011 -1000
Fix pyparted_version() function.
Handle version numbers in multiple formats: X, X.Y, and X.Y.Z. Also,
any of those formats with -string on the end.
commit c75465f29d4ff2cd2e8a95576d9d23b2e77bf948
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Mar 22 16:31:55 2011 -1000
Fix failing test cases in tests/_ped
These were failing due to leftovers from incomplete functionality in
either pyparted or libparted, but more things are working these days.
Most notably, we now have working test cases for:
DeviceGetMinimumAlignmentTestCase
DeviceGetOptimumAlignmentTestCase
PartitionGetNameTestCase
Most of these changes are due to improvements in libparted.
commit 8a8433094ea5adcd0f6214db1eceb43a849773bd
Author: David Campbell <davekong@archlinux.us>
Date: Fri Mar 18 13:53:09 2011 -0400
Added __archLabels and getLabels().
__archLabels is a tuple of pairs (disk label, regex) where regex specifies
what architectures the given label supports, and getLabels is a function for
returning a set containing the disk labels for some architecture. These
additions are intended to replace the now deprecated archLabels dict.
Signed-off-by: David Cantrell <dcantrell@redhat.com>
commit 60f08d6899deb5217f59fa193e5948f27bde0ffc
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Mar 17 17:07:05 2011 -1000
Mark _exponent as deprecated, clean up Deprecated()
Use a dict to define the deprecated globals and supplemental warning
message text.
commit 1c1ada9441ca54e0f6b80948c2cb8f63adfaf4b9
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Mar 17 16:53:43 2011 -1000
Mark partitionTypesDict as deprecated.
Add code to mark globals with DeprecationWarning. Mark
partitionTypesDict as deprecated.
commit cbd1460e49fe085dff2711e3255b851daca3eaa1
Author: David Campbell <davekong@archlinux.us>
Date: Tue Mar 8 14:50:04 2011 -0500
Added sizeToSectors function.
Originally named bytesToSectors, but renamed to sizeToSectors
(dcantrell).
Signed-off-by: David Cantrell <dcantrell@redhat.com>
commit 1dea9e3d8617738c83166df1524968712d95cdbd
Author: David Campbell <davekong@archlinux.us>
Date: Thu Mar 17 14:12:38 2011 -0400
Use assertGreater and assertGreaterEqual
There were some places where assertTrue was being used but assertGreater or
assertGreaterEqual could have been used instead. Use the latter since it gives
better output when there the assert fails.
Signed-off-by: David Cantrell <dcantrell@redhat.com>
commit 0a3c14bd23643312286e461a1160230ff75f44a8
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Mar 17 16:31:11 2011 -1000
Formatting improvements.
commit bf5bd64438a5ffbc6083853c96ff5078450b5eaa
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Mar 17 16:28:32 2011 -1000
Add support for PED_PARTITION_LEGACY_BOOT flag.
This is currently in the master branch for upstream parted and is part
of the parted package in Fedora rawhide. The latest stable release of
parted is 2.3. Since we cannot depend on the library version to know if
PED_PARTITION_LEGACY_BOOT is defined, add in a special check for that
constant and enable it in _ped and parted if it's present.
commit aed73f598c02afeba923f34da76fd6af8dedeab3
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Mar 16 17:11:16 2011 -1000
Use the mailing list as the owner email address.
Report bugs to the list or in Trac at
http://fedorahosted.org/pyparted
not me directly.
commit aa722da61a6216620fe1bba6f319fe3738b20992
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Mar 16 16:58:44 2011 -1000
parted may not be installed as /sbin/parted, rely on $PATH
Fedora-based systems install parted as /sbin/parted, but not every
distribution does that. Rely on $PATH and let the shell find it.
commit 5ef68057e3827c30ffdbfd59d430551c3fb581df
Author: David Campbell <davekong@archlinux.us>
Date: Sat Mar 12 21:13:59 2011 -0500
Use unittest.main() to run tests as scripts.
This makes sure that the tests return the correct values on exiting.
Signed-off-by: David Cantrell <dcantrell@redhat.com>
commit 458883b7063a7b9b7ef085167c44b5aaef818cf1
Author: David Campbell <davekong@archlinux.us>
Date: Fri Mar 11 16:29:13 2011 -0500
Added getLength method.
The classes Device, Partition, and Geometry now have a getLength method that
is to replace the getSize method. It uses the new formatBytes function,
allowing for a wider (and more correct) range of byte prefixes. It defaults to
returning the length in sectors, so that it mirrors the length property. Also,
sectors can be passed as an argument to allow easier dynamic unit selection in
user programs.
Signed-off-by: David Cantrell <dcantrell@redhat.com>
commit f3007caf42ffd3da77d73e36b5ac8a2244d343a0
Author: David Campbell <davekong@archlinux.us>
Date: Mon Mar 7 14:08:39 2011 -0500
Added formatBytes function and __exponents dict.
The old _exponents dictionary is incorrect and specifying the base seperate
from the power seems prone to errors.
Signed-off-by: David Cantrell <dcantrell@redhat.com>
commit 166e61a86c567a1da1b7a6ec25561a6ddbf06a82
Author: David Campbell <davekong@archlinux.us>
Date: Fri Mar 11 18:06:39 2011 -0500
Fix script wrapper for _ped/test_ped.py
I got the script working to import all the tests and run them as one suite, and
noticed that there was a '=' where it should be '==' in test_ped.py.
commit 167d7c9295cdcc9afe8cdc4ed9a5785fa3597612
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Mar 10 10:54:37 2011 -1000
We have a new contributor: David Campbell
commit c76f82a008a0bfb91dd8295914843c92246b2ef5
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Mar 10 10:47:11 2011 -1000
Enable colorized test output for things like PASS and FAIL.
Found it in the automake documentation, looked neat.
commit 57b8b61979ba06ffd6ef097ee9df17530d65c028
Author: David Campbell <davekong@archlinux.us>
Date: Wed Mar 9 15:37:13 2011 -0500
Made all the test suites importable.
Added 'if __name__ = "__main__":' wrappers to all the test case scripts so
that they can be imported as modules without running the suite.
commit 6628aa6e31c1d0000f5870bc426a1c544fee456c
Author: David Campbell <davekong@archlinux.us>
Date: Wed Mar 9 11:14:13 2011 -0500
Use the skip decorator to skip unimplemented tests.
Test output is more readable now, and regressions and real failures are easier
to find.
commit 5d2a4a88b297bd030e368ac7bb1d720bc5749124
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Mar 10 10:47:40 2011 -1000
Remove #! from test files, add $(PYTHON) to TESTS_ENVIRONMENT.
We had #!/usr/bin/python at the top of each test file that ran, which is
fine unless you are on a system with multiple versions of Python.
Removing the sha-bang line and add $(PYTHON) to the TESTS_ENVIRONMENT
variable in the Makefile.am files, which ensures our TESTS are run with
the Python picked up by the configure script.
commit 86240b4be7d404c1ca7faccb6407ad6280ac518b
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Mar 10 10:44:55 2011 -1000
Increase minimum required Python version to 2.7.
commit 85b987d79735512dec5c961e46e02fee550f4a1b
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Mar 8 13:09:09 2011 -1000
Updated the HACKING file.
Reference PEP-8, clarify some statements.
commit d64ca6451d8ea18408bb460b1280204be011b5a6
Author: David Campbell <davekong@archlinux.us>
Date: Wed Mar 2 10:53:30 2011 -0500
Wrapped localeC to preserve attributes.
The auto-generated documentation is much more readable now; although, the
function signature still does not appear correct.
commit 18c5e11aff077d3cbc51cc74e7eb5addd8a2965f
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Jan 17 11:01:24 2011 -1000
New version.
commit 63edbaaf86a3229d6dc625b016d05b10ff743a4e
Author: David Cantrell <david.l.cantrell@gmail.com>
Date: Mon Jan 17 09:56:30 2011 -1000
Revert "Allow getting the actual list from the cache."
This reverts commit 696d14b1109787ca23de067cc0c1fbae9f81f968. We
don't want to allow peeking in to the internal structures of
CachedList.
commit 953d56308b2790ccc3c02dec9d35279b5c5236a9
Author: David Cantrell <dcantrell@redhat.com>
Date: Sun Jan 16 01:39:12 2011 -1000
Bad commit in git repo seems to be gone.
commit 0360d3020ae77431807acc4ba78342a9af7f74da
Author: David Cantrell <dcantrell@redhat.com>
Date: Sun Jan 16 00:40:49 2011 -1000
Drop dependency on python-decorator module.
Drop the dependency on the python-decorator module. Still retain the
internal @localeC functionality, but without using the decorator module.
Patch from Toshio Kuratomi.
Resolves https://fedorahosted.org/pyparted/ticket/28
commit 696d14b1109787ca23de067cc0c1fbae9f81f968
Author: Joel Granados Moreno <jgranado@redhat.com>
Date: Thu Aug 13 13:45:00 2009 +0200
Allow getting the actual list from the cache.
commit 983d118f09bc3b5f974c3c2695ddd8ae8a718261
Author: Joel Granados Moreno <jgranado@redhat.com>
Date: Thu Aug 13 13:45:00 2009 +0200
Differentiate the "Could not commit" messages.
Very usefull when trying to debug down to libparted.
commit c975e64fc73711194192815be80d5e88f6173b17
Author: Colin Watson <cjwatson@ubuntu.com>
Date: Tue Jun 22 09:29:22 2010 +0100
Import _ped.DiskLabelException into parted namespace
commit a28d68388c6e346938b8f8497258242b30aa9f36
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Jul 7 08:23:08 2010 -1000
Return PED_EXCEPTION_NO for yes/no interactive exceptions.
If we get a PED_EXCEPTION_YES_NO exception, we return PED_EXCEPTION_NO
to libparted to avoid any potential data loss ('yes' is assuming the
yes/no question would use the affirmative response to proceed with
destructive operations, which may always be the case...it is for now).
In pyparted, we then pass up an appropriate exception to the caller so
the user can be prompted and action taken.
commit f1d1612afb3c86b88db1935791613218908e0dc2
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Apr 29 09:21:30 2010 -1000
New version.
commit 4e30c69c74d719ab6d6c63eaf5dcc66501a580f1
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Apr 29 08:48:10 2010 -1000
Handle PED_EXCEPTION_WARNING with PED_EXCEPTION_YES_NO (#575749)
Catch PED_EXCEPTION_YES_NO and filter it up to the caller. GPT disk
label detection currently uses this exception.
commit 568a2925a13852fd4f37c232820a3ad1b2eda152
Author: Chris Lumens <clumens@redhat.com>
Date: Wed Apr 21 11:54:31 2010 -0400
New version.
Also, bump the required libparted version since we need it for the new parted
flag.
commit e3d63b886f430a90e58a92e70c6f11ba92c695e5
Author: Chris Lumens <clumens@redhat.com>
Date: Wed Apr 21 11:46:10 2010 -0400
Add support for the PARTITION_DIAG parted flag (#583628).
commit 24e0b294cf27d879008520bc0e8ec58545179402
Author: Chris Lumens <clumens@redhat.com>
Date: Thu Mar 25 14:55:25 2010 -0400
New version.
commit 2425a8135b34d07afd666a6b0844f70c501e00bd
Author: Ales Kozumplik <akozumpl@redhat.com>
Date: Thu Mar 25 11:26:25 2010 +0100
Restore locales even when an exception is thrown (#571940).
Otherwise this disables translations of all glade strings in anaconda.
commit 35108d4fea8b6c906f221cc7524e90dfeafbfedb
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Mar 1 12:29:47 2010 -1000
New version.
commit 51a33455b51bac45243141be354c8c147b222c09
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Mar 1 11:52:02 2010 -1000
Prevent hangs when adding >4 partitions on an msdos labeled disk.
The problem lies within pyparted, and to be precise within the tracking
of the "ownership" of PedPartition objects.
We can have multiple python partition objects point to one PedPartition
and when we then remove a partition from the table, pydisk.c assumes the
python partition object now owns the PedPartition as it is no longer
part of the disk (this happens for example when temporarily removing the
extended partition when re-allocating partitons when doing manually
partitioning)
However, we may have another python partition object pointing to that
same PedPartition object. If we then loose the reference which we used
to remove the partition from the disk, which happens when we do
self.partitions.invalidate() in parted/disk.py (I think). The underlying
PedPartition object gets destroyed / free-ed.
Now the other python partition object (the one in the devicetree), has a
pointer to memory which is being re-used.
The destroying happens because the python partition object used for
removing the partition from the disk thinks it is the owner as the
partition is no longer owned by the disk. But it is not necessarily the
*only* owner, yet it still destroys it.
(Patch from Hans de Goede.)
commit cad5797cafa0081946fd2a7517750e6bbc14b149
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Mar 1 11:49:11 2010 -1000
Updated TODO list.
commit 718e815bfa48d67a2a03b06a3484b4924fdccd03
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Mar 1 11:48:51 2010 -1000
Whitespace cleanup.
commit 6bb53e3a6cb7d56731c74ee5b5265905f51fea25
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Jan 12 12:17:36 2010 -1000
New version.
commit 5e65db09996f927c966f465d4edd4094b43bd4bf
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Jan 12 12:04:04 2010 -1000
Increment major version due to libparted API change.
We now required libparted 2.1 or higher. The new major version number
of pyparted is 3 to reflect this API change.
commit b11e639a72cba9babd6c9fb602315c4654e74463
Author: Hans de Goede <hdegoede@redhat.com>
Date: Mon Jan 11 04:15:46 2010 -1000
Remove py_disk_clobber_exclude binding
py_disk_clobber_exclude has been removed from libparted-2.1, which is the
release we are targetting, so remove the binding for it.
commit 68caa14be4c42c30800ed1ccb8135a8dcb19cccd
Author: David Cantrell <dcantrell@redhat.com>
Date: Sat Dec 19 12:31:27 2009 -1000
Note the rpmlog target in the RELEASE instructions.
commit 2a186a98fa0057586b271f568d83a9d283340e14
Author: David Cantrell <dcantrell@redhat.com>
Date: Sat Dec 19 12:29:50 2009 -1000
Add an rpmlog target in the Makefile.
The idea of rpmlog in the pyparted project is that the package can run
'make rpmlog' in the git project and get a changelog entry suitable for
pasting in to the spec file. Copied more or less from anaconda.
commit 06c8b72f5286f8ea89e6c4fd2303b812fa27b55b
Author: David Cantrell <dcantrell@redhat.com>
Date: Sat Dec 19 11:27:10 2009 -1000
New version.
commit b8f008389c47f67e99b1dd82ffc707dbb7a565d3
Author: David Cantrell <dcantrell@redhat.com>
Date: Sat Dec 19 11:24:34 2009 -1000
Update release instructions.
Future work item: Want to remove the '-devel' thing and just have it
generate a .gitXXXXXX thing that gets tacked on to the release number if
you build from the git repo and not a release version.
commit b699f0c4ffb9b74ed9707b5f70959e9f731b7472
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Dec 18 13:48:09 2009 -1000
Remove old cylinder alignment test cases for _ped.
Removed DiskAlignToCylindersOnTestCase and
DiskAlignToCylindersToggleTestCase as those functions have been removed
from pyparted.
commit a5abd138e07fce7704b8b6771fcabfbe0881fe75
Author: Hans de Goede <hdegoede@redhat.com>
Date: Fri Dec 18 01:25:21 2009 -1000
Add tests for max partition length / start sector
commit ae1747149a4bcba03f2a508de835b082c948968a
Author: Hans de Goede <hdegoede@redhat.com>
Date: Fri Dec 18 01:25:20 2009 -1000
Add _pedmodule and parted functions for max partition length / start sector
parted-2.1 and Fedora's parted-1.9.0-24, add functions for querying the
maximum partition length and start sector a disk's label can represent.
This patch adds _pedmodule and parted module support for these functions.
commit 0692b1e24550df9d4d52606a29c41a94058091cb
Author: Hans de Goede <hdegoede@redhat.com>
Date: Fri Dec 18 01:25:19 2009 -1000
Remove align_to_cylinders function bindings
The ped_disk_align_to_cylinders_on() and ped_disk_align_to_cylinders_toggle()
functions were never in upstream parted, so remove their bindings from
pyparted.
commit 294471ccc094eec927a3a71bb564ab928cd2814d
Author: Hans de Goede <hdegoede@redhat.com>
Date: Fri Dec 18 01:25:18 2009 -1000
Add tests for disk flag methods
commit a5a6ea60fbf2fef4f8d8062b0fcc5e87e3b7cba7
Author: Hans de Goede <hdegoede@redhat.com>
Date: Fri Dec 18 01:25:17 2009 -1000
Add _pedmodule and parted functions for per disk flags
parted-2.1 and Fedora's parted-1.9.0-24, add functions for having per
disk flags (instead of per partition). These are used to enable / disable
cylinder alignment on disklabels where it is optional (the Fedora specific
patch which add the toggleAlignToCylinders function was not accepted
upstream).
This patch adds _pedmodule and parted module support for these flags,
this support is modelled after the partition flags and works identically.
commit 738c6e04a0411b6a2786551f44a1c0f38b7b13ff
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Dec 10 14:08:40 2009 -1000
Every tuple member requires a comma after it.
commit c9d43ab4768febbad0cea7673a267e80567c22c0
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Dec 10 14:04:33 2009 -1000
Fill out a lot of simple _ped.Disk test cases.
commit 7faa9a1d2ab79759214ff3bfb64736e1abfbf461
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Dec 10 14:04:03 2009 -1000
Disable DeviceDestroyTestCase for now.
Need online Python API reference and I'm currently over the Pacific
Ocean.
commit 70590a7bd38453584018dc980b8e5cdc478edad1
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Dec 10 14:03:13 2009 -1000
Add RequiresLabeledDevice to tests/_ped/baseclass.py.
This base test class extends RequiresDevice. All it does on top of
RequiresDevice is run parted to label the temporary device with an msdos
disk label.
commit 05cbb0df9767a13d241616ab10347edf361b77aa
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Dec 10 13:33:20 2009 -1000
Attempt at fixing _ped.Device.destroy(), no dice.
Stashing work for now.
commit de3451fa3ab1f51b60d01615ea70f37560f878a9
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Dec 10 13:07:36 2009 -1000
Fix UnitFormatCustomTestCase and UnitFormatTestCase.
Fix UNIT_PERCENT handling in these test cases.
commit e87fa26bb3678b1d6451ca6b6c939ecf038b8682
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Dec 10 12:56:22 2009 -1000
Fix UnitFormatCustomByteTestCase and UnitFormatByteTestCase.
The UNIT_PERCENT handling was incorrect. Compute actual percentage
based on the byte value we're using in the test case and the value of
unit_get_size() for UNIT_PERCENT.
commit 51b633ae85843864eb5c864083176124a041ede9
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Dec 10 09:41:55 2009 -1000
Add DeviceStrTestCase, disable DeviceDestroyTestCase.
Added DeviceStrTestCase. Disabled DeviceDestroyTestCase as it's
producing gc errors.
commit 218c7e56771ec06cef1912782b7d3438b565a190
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Dec 10 09:21:35 2009 -1000
Add DeviceDestroyTestCase and DeviceCacheRemoveTestCase.
commit f68aec424772ba97bb4975f9c1f606d7830729f9
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Dec 3 10:22:01 2009 -1000
Implemented ConstraintIsSolutionTestCase().
commit 958118342e57b64ba63410624bcd57d1509eb330
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Dec 3 10:12:38 2009 -1000
Implement ConstraintSolveMaxTestCase().
commit ba9cde5bb3259ddbc596bb62685d00aba282f818
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Dec 3 09:42:12 2009 -1000
Implement ConstraintSolveNearestTestCase().
commit 7147b9cc7aa9dcdba4aeec48ee5354557ec60377
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Dec 2 10:34:15 2009 -1000
Correct py_ped_file_system_probe_specific() for NULL returns.
If the filesystem you try to probe for is not found in the geometry
region specific, libparted returns NULL. It may also raise an exception
from the filesystem code, but it does not seem appropriate to raise that
here. I could be wrong, but I changed this function so on detection
failures, we just return None. That seems more appropriate to the use
of this function in Python.
commit 0c05af36ecdfa4ef82c10e97836215b59184a2d9
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Dec 2 10:33:22 2009 -1000
Implement FileSystemProbeSpecificTestCase().
Use ext2 and probe for that explicitly. The equals test for the
resulting geometry there is not working correctly, so the test case
manually does the geometry richcompre.
For other filesystem types, the specific probe returns None.
commit 4ed0178467006ba04191632a84acfa520b02c7ad
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Dec 1 11:40:42 2009 -1000
Implement FileSystemProbeTestCase().
Extend RequiresFileSystem and make sure the probed filesystem is ext2
and not any of the other ones available.
commit abe5c09b047ba82394ed790ace9d432b85dd97b9
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Dec 1 11:39:47 2009 -1000
Add RequiresFileSystem to tests/_ped/baseclass.py.
If a test case needs a device with a file system on it,
RequiresFileSystem will do that. It creates an empty file and puts an
ext2 filesystem on it.
commit 3adf9a486afd8f64ada4f916de2d889cef68f187
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Dec 1 09:40:32 2009 -1000
Add disk alignment test cases in test_ped.py.
Added the following test cases:
DiskAlignToCylindersOnTestCase()
DiskAlignToCylindersToggleTestCase()
commit 0c65865b3c6dbd34c24ce53498a1cf458d3d57fa
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Dec 1 07:12:04 2009 -1000
Fix CHSGeometryStrTestCase().
commit 6bf3dc2075ed290899dc79f92f4ccdbfa3d81412
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Dec 1 07:07:17 2009 -1000
Fix ConstraintDuplicateTestCase...finally.
The test case for this one was mostly wrong. Each object in the
_ped.Constraint will have a different repr() than the source, so we need
to validate those with assertNotEquals(). But we do assertEquals() and
check all (well, most) of the actual values in the constraint.
commit 29acecb0cb609256ad0183192c58258f6de7f945
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Dec 1 07:05:32 2009 -1000
Put a deprecation warning in py_ped_constraint_duplicate().
Even though the goal of the _ped module is to create a complete Python
API of libparted, some public functions in libparted just seem
unnecessary in a Python module. The duplicate() functions are among
these. In Python we can do a copy.deepcopy() and get the same effect
that the libparted duplicate functions provide. Put a deprecation
warning in this function to alert users that it will eventually go away
and they could just use a copy.deepcopy() instead.
commit cfb1d2271bb55600c7acba2ddd7230a1888ce874
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Dec 1 06:13:06 2009 -1000
Note that we need parted from Fedora for pyparted.
Upstream parted is not releasing versions of parted to ftp.gnu.org, but
rather pulling patches in to individual distribution offerings. Very
annoying, but I am not upstream parted anymore, so I can only complain.
commit c0798ba64c627acea31d071c449e55a4fad01e2d
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Nov 30 11:52:29 2009 -1000
Fix UnitGetSizeTestCase in _ped test cases for _ped.UNIT_PERCENT.
commit c411cb4ec91a93248a28bd82d908a9a95580344c
Author: Hans de Goede <hdegoede@redhat.com>
Date: Mon Nov 16 11:37:32 2009 +0100
Add testcase for new _ped disk get_partition_alignment method
commit a9de087daa3ed5abb42df49b7e06b12104cfa075
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Nov 6 15:29:16 2009 -1000
New version.
commit 1da479c307e7d168bf2b9eafbd6aaecc7d60b1e7
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Nov 4 14:37:38 2009 -1000
Update TODO list.
commit a57751ffe9b655d5c90c558e34eee4785484bbe4
Author: Hans de Goede <hdegoede@redhat.com>
Date: Thu Nov 5 23:56:26 2009 -1000
Use PedDevice length instead of DIY (#532023)
Use PedDevice length instead of calculating it ourself based on the
BIOS Geometry. Using BIOS Geometry gives the wrong answer for DASD disks
and partitions (as the actual sector size is 4096 but parted fakes 512
bytes sectors). And can also give the wrong answer for very large disks.
commit 2674a71fd2ca7aaeb28cf1577acfec124eb9747f
Author: Hans de Goede <hdegoede@redhat.com>
Date: Thu Nov 5 23:56:25 2009 -1000
Use sectorSize not physicalSectorSize for size calculations
physicalSectorSize is the sector size on the platters of the disk,
where as sectorSize (which is the logical sector size) is the sector
size seen in the (s)ata / scsi commands and on higher levels.
IOW physical sector sizer is for informational purposes only, geometry,
alignments, etc. Are always expressed in logical sector sizes, so
we should use sectorSize in size calculations.
commit 843ddc0324255027aa30cf1b2810f3c0fee243d9
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Nov 3 13:56:51 2009 -1000
New version.
commit 059ea0a6a3a5129d43ee56d93a61d9fe5a9539a5
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Nov 3 11:57:48 2009 -1000
Remove root user requirement in _ped.
commit 28f095ace135d98b577d62f7361f31278ce3ffb9
Author: Hans de Goede <hdegoede@redhat.com>
Date: Fri Oct 30 02:03:03 2009 -1000
Add testcases for new _ped device methods
commit a78da84200f05808db6468dac2ceb60ac499cf3b
Author: Hans de Goede <hdegoede@redhat.com>
Date: Thu Oct 29 10:21:13 2009 -1000
Add python wrapper for new PedDisk partition alignment info function
commit 99e192eb62248f1171bc9903b797a0ebd7827e17
Author: Hans de Goede <hdegoede@redhat.com>
Date: Thu Oct 29 10:21:12 2009 -1000
Add support for new PedDisk parition alignment info function
commit 6bd5a69cefd209d9d02905d92f19bcb806a2ab7a
Author: Hans de Goede <hdegoede@redhat.com>
Date: Thu Oct 29 10:21:10 2009 -1000
Add python wrappers for new PedDevice alignment info functions
commit 799a9c4c038f697d495128550492b27cdaa4fbf1
Author: Hans de Goede <hdegoede@redhat.com>
Date: Thu Oct 29 10:21:09 2009 -1000
Add support for new PedDevice alignment info functions
commit a88b6536dc21855c1ec381dad7000a3e7ef7446f
Author: Chris Lumens <clumens@redhat.com>
Date: Tue Nov 3 16:28:28 2009 -0500
Fix a whole pile of test cases.
commit 81cc7c9c22de5b8b65e3de23a066906c6f9d79fc
Author: Hans de Goede <hdegoede@redhat.com>
Date: Thu Oct 29 10:21:14 2009 -1000
Remove ped_disk_commit_to_dev() call from py_ped_disk_new_fresh()
Remove ped_disk_commit_to_dev() call from py_ped_disk_new_fresh(),
py_ped_disk_new_fresh() should just create a new in memory disklabel
object and not cause any on disk changes (just like the libparted
equivalent), the commit was probably added in the past to workaround the
bug fixed by commit ac80c5ae274ed572bf6ed7fc65c2473205497e77
commit 2e05d162f8ab6de36b4e3181ccdba7649a5d6dda
Author: Hans de Goede <hdegoede@redhat.com>
Date: Thu Oct 29 10:21:11 2009 -1000
Fix error in Constraint __str__ method
commit 3ddb1df4fcce4910e3cb1e476f773cbdab21dec5
Author: Hans de Goede <hdegoede@redhat.com>
Date: Mon Oct 5 14:12:07 2009 +0200
Make _ped_Device2PedDevice properly set / throw exceptions
Make _ped_Device2PedDevice properly set / throw exceptions when
ped_device_get() fails.
commit 8fb2756fe45a37387984b08205a4c02d5ba4852e
Author: Hans de Goede <hdegoede@redhat.com>
Date: Mon Oct 5 14:10:41 2009 +0200
Fixup various errorhandling issues in pydisk.c
This patch fixes:
1) The not checking of partedExnRaised in
py_ped_disk_clobber() and py_ped_disk_clobber_exclude()
2) The return of NULL without setting any sort of python exception in
py_ped_disk_new_fresh() when ped_disk_new_fresh() fails.
3) The leaking of the just created fresh disk when ped_disk_commit_to_dev()
fails in py_ped_disk_new_fresh().
4) Make py_ped_disk_new_fresh() throw DiskExceptions not PartitionExceptions
commit caabe8f52c6a80c476dc3b4ece3344c613885819
Author: Hans de Goede <hdegoede@redhat.com>
Date: Mon Oct 5 13:19:20 2009 +0200
Add missing _ped_Device2PedDevice() retval checks
Add missing check for the retval of _ped_Device2PedDevice() in
_ped_Geometry_init() and _ped_Disk_init().
commit 6f8982745750d12842fcee92c19110b14cb18e93
Author: Chris Lumens <clumens@redhat.com>
Date: Mon Oct 5 09:46:40 2009 -0400
Use libparted commit() for parted.disk.Disk.commit() (hdegoede).
Currently we are using python code to combine the commit_to_dev and
commit_to_os to get commit() however libparted has a native function for this.
Using this removes an open / close of the device node and thus an udev change
event and unnecessary udev rule scanning. Note that for the unnecessary open /
close to be really gone we need a libparted with commit
ad25892bb995f61b0ddf801ed1f74e0b1e7390ce.
Note that this effectively backs out a previous patch to the commit function
that was needed because of errors in libparted. With the above mentioned
libparted commit, this is fixed and we no longer need our workaround.
https://fedorahosted.org/pyparted/ticket/24
commit 6b068de8f952ea0d4caa7ff4f0fe35e9825d1b43
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Oct 2 15:56:59 2009 -1000
New version.
commit 3502dc5ad3bcecad39a610f357ddd23baf15ce5b
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Oct 2 14:58:55 2009 -1000
Add bumpver target to Makefile.am
commit bb169a3b7e3ea7ad11c6bf74f5a7945a3530b1a6
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Oct 2 14:52:47 2009 -1000
Catch exceptions from ped_disk_new_fresh() call.
In py_ped_disk_new_fresh(), catch libparted exceptions when we call
ped_disk_new_fresh().
commit ac80c5ae274ed572bf6ed7fc65c2473205497e77
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Oct 2 14:48:46 2009 -1000
Correct PedDisk2_ped_Disk() to avoid losing the new disk label.
See https://bugzilla.redhat.com/show_bug.cgi?id=526525 for more details.
commit 47cdff12ccbe6809f2b5b543ec3a28179fa298d2
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Aug 26 11:43:40 2009 -1000
Removed WHY document.
commit fe737eed05b2de523d9bbb3ec9a7f2dbb0a8f962
Author: Chris Lumens <clumens@redhat.com>
Date: Tue Aug 25 12:59:09 2009 -0400
If an argument is required, check and raise an exception if not found.
I'd prefer to just remove these things as keyword args, but we've already
released pyparted and it's supposed to have a stable API. For now, we'll
just have to raise exceptions. Later on we can convert them to regular args.
commit fab4ed8670a8d7b5754215b162702cc21febec99
Author: Chris Lumens <clumens@redhat.com>
Date: Mon Aug 17 13:47:37 2009 -0400
New version.
commit 3e84e2eb789dfa5e612330a477a27b8b68c39bb4
Author: Chris Lumens <clumens@redhat.com>
Date: Fri Aug 14 10:29:19 2009 -0400
PED_DEVICE_DM is always defined in libparted these days.
commit ca8cb72b182f6f152dae65491af3927895862fd3
Author: Chris Lumens <clumens@redhat.com>
Date: Tue Aug 11 16:52:37 2009 -0400
Handle parted exceptions arising from ped_device_get (#495433).
The bug has an extensive description of what's going wrong, but the short
story is that by not handling the libparted exception, partedExnRaised stays
set so the next time a libparted function returns NULL, we think that
later caller is where the problem happened. Not only does this raise an
exception where one shouldn't happen, but it raises the exception with a
very outdated and misleading error message.
We likely need to audit pyparted for other instances of this problem.
commit ec576b3aaed4cd8d345d12ad5b072223a5627018
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Aug 4 12:36:03 2009 -1000
New version.
commit e9f83215789463417b429b494016a67bf34ba640
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Aug 4 12:25:50 2009 -1000
Simple parted.Partition.getDeviceNodeName()
This function came over from anaconda's code originally. Removed a lot
of unnecessary logic since we really just want the part of the
partition's path that does not include /dev/.
commit b1bab559955bce27c96e85e53907a9bc9bc7a120
Author: Joel Granados Moreno <jgranado@redhat.com>
Date: Tue Aug 4 17:24:43 2009 +0200
Calculate the length of the geometry correctly.
When one specifies start and end in Geometry, the length has a off by
one error. length != (end - start) because length is a value that
includes the start sector and the end sector. When doing just
(end-start) one does not take into account the start.
commit 6889aed7cd87538df77b72d4b957e968f6143156
Author: Joel Granados Moreno <jgranado@redhat.com>
Date: Tue Aug 4 16:14:23 2009 +0200
Be consistent in importing _ped.FUNCTIUON for the cylinder align stuff.
commit 5215a92f7fe7610f8a0cefc1469164510b9450ec
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Aug 4 12:17:00 2009 -1000
git-clone -> git clone
commit 70001fcf9f33554946b5b47f18e65ef143243fc4
Author: Joel Granados Moreno <jgranado@redhat.com>
Date: Tue Aug 4 18:07:17 2009 +0200
Increase readability.
commit 29a98feee7e98e0ea07c8044cd67985d5b8e6dd4
Author: Joel Granados Moreno <jgranado@redhat.com>
Date: Tue Aug 4 18:05:25 2009 +0200
s/contraints/constraints/
commit d8bf33682da31914a164e2a9886e342c8d85d41a
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Jul 16 14:27:45 2009 -1000
New version.
commit fa5d9ceb881b1004b5c563a111c380391948fcdd
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Jul 16 14:24:31 2009 -1000
Check for decorator.decorator in Python.
commit f92fc93613bf417b4c6cca1325eed3eafa55a7af
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Jul 16 13:39:26 2009 -1000
Rename bootstrap to autogen.sh
commit 6503a88a583e9805edcc84f118b151e2f9844be9
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Jul 16 13:37:52 2009 -1000
Add pass-throughs for the align-to-cylinders functions.
libparted now offers two functions to control aligning partitions to
cylinders. They are:
ped_disk_align_to_cylinders_on()
ped_disk_align_to_cylinders_toggle()
The first returns true if libparted is set to align partitions to
cylinders. The second one toggles the setting back and forth.
Pass-throughs have been added to _ped and parted and test case stubs
have been added.
commit 2912ebd5c575f6859fe4d0b4c01a6fd1e452c446
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Jul 16 13:13:01 2009 -1000
ped_free() -> free()
parted-1.9.0 has removed ped_free() and replaced it with calls to the
regular free() function in the C library.
commit fb16e4b8662d48884239f9f037e7ec25396d0a00
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Jul 16 13:11:32 2009 -1000
Fill out get_max_supported_partition_count() functions.
Implement py_ped_get_max_supported_partition_count() in _ped, add
maxSupportedPartitionCount property to parted.Disk, add stubs for test
cases.
commit f05278c55c3d0047f2135886bd03a960b88ed64d
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Jul 10 16:43:42 2009 -1000
Add py_ped_disk_get_max_supported_partition_count()
This is a new function in parted-1.9.0. Need to finish it in _ped, add
test cases, implement it in the parted module, and write test cases for
that.
commit 91a45f50713016bd63b2e80f435997dc66201e96
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Jul 10 16:36:39 2009 -1000
Add PARTITION_APPLE_TV_RECOVERY and PARTITION_BIOS_GRUB
These new partition types are in parted-1.9.0 and later revisions.
commit 7a8733545c5d62645e083da153ab7f8d98c7ac58
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Jul 10 16:19:31 2009 -1000
Add DEVICE_SDMMC and DEVICE_VIRTBLK from new libparted.
commit b378c46d241c5a5093cce4dbd4e8e3ebdd3a2694
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Jul 10 16:17:04 2009 -1000
Bump minimum required libparted version, set new version number.
Require libparted 1.9.0 or greated, bump pyparted version to 2.1.0.
commit d89d3d083542fd088ca9ab1ec99896ce6b4e6570
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Jul 10 16:16:48 2009 -1000
Updated TODO list.
commit 9e471ad36fe3a7162712c1490b800ab8b925fae3
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Jul 2 17:50:41 2009 -1000
Add more units to _exponent hash.
Add petabytes, exabytes, zettabytes, and yottabytes.
commit 79b1b4e307f07dfd253550611c89f71cdfa93895
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Apr 15 16:17:44 2009 -1000
Free remaining strings from ped_unit_* functions in pyunit.c.
Two more functions needed ped_free() calls to free the string returned
to us by libparted.
commit de5df8f9422cf1474c3762e426be2f18c818b3c2
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Apr 15 16:12:38 2009 -1000
Read in PedUnit values from Python as ints consistently.
The pyunit.c code was using long and int inconsistently for reading in a
PedUnit value from Python, which would result in losing information
since the size of int and long differ.
Since PedUnit is just an enum in libparted, use int in _ped's code to
read and store PedUnit values.
commit 8e114dc0cf7da80070b2058664cd7e927ab1c225
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Apr 15 16:11:47 2009 -1000
More test cases for _ped.Device
Write test cases for some of the unit format functions and write the
DeviceStrTestCase.
commit 845a74515615fc5d1a83938ed88798725633c97e
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Apr 15 16:04:52 2009 -1000
Free string returned from libparted unit format functions.
The PedUnit functions that return strings depend on the caller to call
ped_free() to release the memory. We take the string from libparted and
turn it in to a Python string, which makes a copy and lets Python memory
management take over. Be sure to call ped_free() on the pointer
returned from libparted.
commit 6069a73f6e62a6bce7e14fec22edc58d51899017
Author: Chris Lumens <clumens@redhat.com>
Date: Wed Jun 10 14:52:56 2009 -0400
Add a decorator to set LC_MESSAGES=C before calling into libparted (pjones).
This means that exceptions coming from inside libparted will end up being in
English instead of whatever language the install is proceeding in, which
should be more helpful for developers.
commit f3f62c6a25d9163d83cafbd934c029cdefbb17e7
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Apr 14 22:50:15 2009 -1000
See if device is open or in external mode in py_ped_geometry_check()
If the device is not open or is in external access mode,
ped_geometry_check() will fail. Catch before calling libparted and
raise an exception.
commit 21f6dbb14987cac47cc4ac24aafa8ef9fd50d76c
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Apr 14 22:48:22 2009 -1000
More _ped test case work.
Test case code sanitizing and more work in test_device.py
commit a368e9c85e4f8e9bd4df6fb796ae0cbeb603aa36
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Apr 14 20:57:35 2009 -1000
Avoid assert_
Use assertEquals(), assertNotEquals(), assertTrue(), and assertFalse()
to make the test statements a little more clear.
commit 907571d841013a569f60e9c7516aa0d322a90057
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Apr 14 20:20:46 2009 -1000
Finished test_geometry.py for _ped test cases.
commit 1f0c9f59b9091e008eec5d9963c930db542f1a98
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Apr 14 17:14:41 2009 -1000
New version.
commit affad0466b7447af1671d4af3f0cf0d8a796db26
Author: Chris Lumens <clumens@redhat.com>
Date: Tue Apr 14 13:16:57 2009 -0400
Be more careful with comparing types of objects now (#495713).
commit 1d7cbc2f6f9af4a825ed01d83a0625a3f0f87d6a
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Apr 13 09:48:10 2009 -1000
New version.
commit 98ff1118773ceb430b1fc5a9e6e44b1bb7e6654c
Author: David Cantrell <dcantrell@redhat.com>
Date: Sat Apr 11 12:34:33 2009 -1000
Move unit string format/parse tests to test_device.py
These methods are now on _ped.Device, so move the test cases.
commit b5d999bd6c0a720890bca12ff24cb9ca4dcb0d81
Author: David Cantrell <dcantrell@redhat.com>
Date: Sat Apr 11 12:29:56 2009 -1000
Move unit string parsing methods to be members of _ped.Device
The following methods on _ped:
unit_format_custom_byte()
unit_format_byte()
unit_format_custom()
unit_format()
unit_parse()
unit_parse_custom()
All act on a specific _ped.Device, so these methods are better suited as
members of _ped.Device. Moved them from _ped to _ped.Device.
These methods no longer take in a _ped.Device argument, since that is
now self.
commit edfdffea764de132c550ec015950d3de8c6b2686
Author: David Cantrell <dcantrell@redhat.com>
Date: Sat Apr 11 12:11:31 2009 -1000
Stop on compiler warnings, use -fno-strict-aliasing
Python modules have to be compiled this way because the continual use of
pointers to different sized types since everything becomes a PyObject *
at some point. I don't know of a way around this other than to disable
strict aliasing. Apparently Python is compiled this way too, so
whatever.
commit d7580d4d005e56d48fe302a8745caee4c3c80db8
Author: David Cantrell <dcantrell@redhat.com>
Date: Sat Apr 11 11:31:33 2009 -1000
Inherit CFLAGS from calling environment.
commit f7f8f2fb6f7d507be8708fe5ec4e7b806cb0a10d
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Apr 9 13:47:29 2009 -1000
Name md partitions as /dev/mdXpY in getDeviceNodeName()
'md' is another device type that needs this special naming format,
so add it to the list.
Patch from jdanecki at Intel Corporation.
commit 52a869d2cf07915a55e7e8702d1598fce3b6a14d
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Apr 9 13:44:27 2009 -1000
Fix UnitGetSizeTestCase
Call assertRaises() correctly.
commit a1934af172f207233765335202418fca9a057f96
Author: Chris Lumens <clumens@redhat.com>
Date: Wed Apr 8 11:27:45 2009 -0400
Don't store the partition number in a _ped_Partition since it can change.
parted likes to renumber partitions out from under us when partitions are
added or deleted, so don't store the number directly. Look it up instead.
Also, change num to be a read-only property.
https://fedorahosted.org/pyparted/ticket/17
commit cbfc6dce7291e04c55e1b5863ea1a4b4aa3ccf01
Author: Chris Lumens <clumens@redhat.com>
Date: Wed Apr 8 11:24:32 2009 -0400
The first argument to py_ped_unit_get_size should be a PyObject.
commit ee4a189287e39acd75f795e59e4331b847c266d1
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Apr 6 19:02:07 2009 -1000
Filter exception text back up in py_ped_unit_get_size()
If we get 0 back from ped_unit_get_size(), grab the exception text and
make sure we filter it back up the caller and keep the exception raised.
commit 847fac1ced1638374708c39bfdeebc45dc437fd2
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Apr 6 19:01:54 2009 -1000
Fix up UnitGetSizeTestCase in test_ped.py
commit 66aa899b4f5c056b36f45d39da7268214f981eb7
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Apr 6 18:51:07 2009 -1000
Move unit_get_size() to be a method on _ped.Device
Move this method out of _ped at the top level and make it a method on a
_ped.Device. The first argument is the _ped.Device you want to work on,
so just make it a method.
commit 965aa07a42899fb0f1c33fa95a40c36dad70cac7
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Apr 6 18:35:21 2009 -1000
Compare start, length, and end values rather than PedGeometry pointer.
In tp_compare for _ped.Geometry, compare the start, length, and end
values on the PedGeometry instead of comparing the PedGeometry pointer.
There will be two different geometries, but the values should match.
commit 93917b15b6c265ad91336e812991440aa66da805
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Apr 6 18:34:53 2009 -1000
Complete test_disktype.py test cases.
Not many in here, but filled out the test cases to cover all of the disk
types.
commit cf3d1aa411f8f7b4bc710a2dd92bae6a7564b06e
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Apr 6 18:34:21 2009 -1000
Create RequiresDiskTypes base unit test class.
For test cases that need a hash table of all _ped.DiskType instances
available.
commit d5ea970174cb41d8ab29406f5e83ba734d9d7cf7
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Apr 6 18:10:31 2009 -1000
Fix DiskTypeGetTestCase in test_ped.py.
commit cd5bf35714d2869a0bf6ab2876d382c427e27f08
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Apr 6 18:10:02 2009 -1000
More test_constraint.py work.
Fill out some more test cases, start working on solve nearest.
commit b39baa067cd7015bb0de20d60efd9ebb9ba67858
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Apr 6 16:30:23 2009 -1000
Add tp_compare and tp_richcompare for Constraint.
commit dfde260c6c9fa7bd8418b0c3c492e804d3502b84
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Apr 6 16:22:35 2009 -1000
Add tp_compare and tp_richcompare for Timer.
commit aec25674a69561c02993a593fd713ed1da990973
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Apr 6 16:17:34 2009 -1000
Add tp_compare and tp_richcompare for Alignment.
commit 52c68180b3b96c10e4ba2e9cb7801e6d7b054af9
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Apr 6 16:02:44 2009 -1000
Add tp_compare and tp_richcompare for Geometry.
commit 2207bdd06b0725190c507a1f62582b3221224500
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Apr 6 15:55:57 2009 -1000
Add tp_compare and tp_richcompare for FileSystemType and FileSystem.
commit a710e30777e10de547b5fa1d640425b3ab3c20b9
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Apr 6 15:46:10 2009 -1000
Add tp_compare and tp_richcompare for Partition, Disk, and DiskType.
commit 81b0a6bdeae282843cd457d933f904c21067c769
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Apr 6 15:28:52 2009 -1000
Forgot Py_TPFLAGS_HAVE_RICHCOMPARE on CHSGeometry and Device
Need this flag to indicate we've set tp_richcompare to something usable
now.
commit 191de2441851a72cde5303b40643b23cc3dffc4d
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Apr 6 15:24:02 2009 -1000
tp_compare and tp_richcompare for _ped.Device and _ped.CHSGeometry
Implement tp_compare and tp_richcompare for _ped.Device and
_ped.CHSGeometry types. We can really only test for equality with these
types, so raise TypeError for unimplemented comparisons in richcompare.
The tp_compare function is also poorly documented in the Python guide,
so it may or may not be fully complete at this point.
commit 46e1ba2f4dfe97a612c3f1f9c8af9f7e01f820c6
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Apr 6 14:49:55 2009 -1000
Simplify function prototypes.
commit 711a98903330ab4169ac12d94560a81aaf2751e2
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Apr 6 14:33:51 2009 -1000
Set .tp_hash to PyObject_HashNotImplemented
Setting this to PyObject_HashNotImplemented for now, at least until we
determine which types can be hashable. I'm working on tp_compare and
tp_richcompare and need this set to something valid in the interim.
commit cb96653ebd9d92f9d9e15285a85e467689e5a9de
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Apr 6 12:46:35 2009 -1000
Finish test_chsgeometry.py test cases
commit ebaf1c90c326479321caaf8ec43d3c66cf5fca76
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Apr 6 12:41:27 2009 -1000
Add remaining _ped.Alignment test cases.
Implement the following _ped.Alignment test cases:
AlignmentAlignUpTestCase
AlignmentAlignDownTestCase
AlignmentAlignNearestTestCase
AlignmentStrTestCase
commit 5fb5ddfbdab6665579567bd3a4b7bc8bdd48b54f
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Apr 6 12:40:23 2009 -1000
Add RequiresDeviceAlignment class.
The RequiresDeviceAlignment class is for test cases that need a
_ped.Geometry (which requires a _ped.Device) for _ped.Alignment
operations. The base class has some rounding functions so we can verify
the results from _ped.Alignment methods.
commit 7ef1dd1d88ed7564e02c319ec12028cda0982c7a
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Apr 6 11:44:01 2009 -1000
Expand unit type to name test cases for _ped
commit 2db07f417a632c53b83a6b2fde1c6aea93d2ec6d
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Apr 6 11:40:45 2009 -1000
Read param as in for py_ped_unit_get_name()
'i' was defined as a long, but we were reading it as an int with
PyArg_ParseTuple(). On 64-bit systems...well, you know how the story
ends.
commit 599660b0a530b6a6bb00e6acd397a67b624d472a
Author: David Cantrell <dcantrell@redhat.com>
Date: Sat Apr 4 17:26:24 2009 -1000
Implement the AlignmentIntersectTestCase test case.
This one was fun. natmath.c has proofs in it, so my thought was to
implement the math used in libparted in the test case and compare it to
what we get back from libparted. Doing so uncovered a problem in our
_ped.Alignment code, and hey, that's what the test cases are all about.
commit f417b01ef573b1bec1df3cfa0e7eca009d722816
Author: David Cantrell <dcantrell@redhat.com>
Date: Sat Apr 4 17:22:55 2009 -1000
Copy back values from ped_alignment_init()
Found this problem while working on test cases. It's not sufficient for
us to just try to create a new alignment, we need to copy back the
possibly-adjusted offset and grain_size from the newly created
alignment. ped_alignment_new() calls ped_alignment_init(), which in
turn calls abs_mod() if grain_size is non-zero and the offset of the
alignment is adjusted accordingly. We need these adjusted values in our
_ped.Alignments.
commit 80cb1d6f3b56582ac7d1cef0eb8593b945f52fbd
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Apr 3 16:38:36 2009 -1000
Use kwargs for parted.Constraint
commit ad92b5b682e7c376d4f4b17b8b134722877b25f7
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Apr 3 16:30:50 2009 -1000
Use kwargs for parted.Alignment
commit 8515a2c43764702390c9e31c62727f513ab8a0a7
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Apr 3 16:16:56 2009 -1000
New version.
commit 566e4888b2a4f7702533a88d8c6f8af28e949217
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Apr 3 16:12:19 2009 -1000
Call commitToDevice() then commitToOS() in commit()
This is exactly what ped_disk_commit() does in libparted, but for
whatever reason, calling that function does not work reliably. Tracing
the calls, the lines hit are identical. The only thing that really
happens when we commit to OS is that libparted calls sync() a lot and
issues BLKRRPART.
In an effort to close out storage bugs, I'm changing this in pyparted.
https://bugzilla.redhat.com/show_bug.cgi?id=491746
commit eecb1b328f35e0534c23106a972def8fc38eb6c5
Author: Hans de Goede <hdegoede@redhat.com>
Date: Thu Mar 26 13:05:47 2009 +0100
When checking for PartedException) also check for PyExc_NotImplementedError
In various places we check wether the libparted exception handler was called
when we got an error return from libparted. We then check to see if our custom
libarted exceptionhandler has already defined an exception, using
PyErr_ExceptionMatches(PartedException), if it has not already defined an
exception, then it should have set partedExnMessage, and we define our own
exception using partedExnMessage.
However our custom libarted exceptionhandler will also define exceptions of
the PyExc_NotImplementedError type, in which case our custom libparted
exceptionhandler has not set partedExnMessage. However as
PyErr_ExceptionMatches(PartedException) does not catch the
PyExc_NotImplementedError case, we still define our own exception using
partedExnMessage, this causes us to call PyErr_SetString() with a NULL pointer
which triggers in assert inside python's C-code.
This patch fixes this by also checking
PyErr_ExceptionMatches(PyExc_NotImplementedError) whenever we check
PyErr_ExceptionMatches(PartedException)
commit 4f4d2eae540fcabe04561b680ea1e8086d44323a
Author: Hans de Goede <hdegoede@redhat.com>
Date: Thu Mar 26 13:05:31 2009 +0100
Fix a memory leak in add_partition error handling path
commit fafa4a1af6498eed77c98d689e72909a901a2984
Author: Hans de Goede <hdegoede@redhat.com>
Date: Thu Mar 26 13:05:08 2009 +0100
Make the constraint argument for various partition functions optional
ped_disk_add_partition(), ped_disk_set_partition_geom(),
ped_disk_maximize_partition() and ped_disk_get_max_partition_geometry()
all except NULL as a valid constraint argument. So allow not passing
in any _ped_Constraint object in the wrappers for these.
commit 3f4afd2c9644273e5ecd14ba54743c663c0a1fee
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Mar 23 17:59:40 2009 -1000
Update version number for new development work.
commit 5dfe16cd1cb3e218bfdeed5f8f470b317b689195
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Mar 23 17:36:45 2009 -1000
New version.
commit 9ae61eaef909837825c5bf18c0869af43319addd
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Mar 23 16:09:08 2009 -1000
Revert "Ensure PedDisk pointers match when we call ped_disk_set_partition_geom()"
This reverts commit e43fe6dff7c1b555ac500b58ef00e8bd1fe5135b.
commit b2a1bc85f2116ea2431ca15da8ffc17eb4196166
Author: Hans de Goede <hdegoede@redhat.com>
Date: Mon Mar 23 14:09:20 2009 +0100
Sanity check disk_*_partition arguments
Make sure operations done on a disk which have a partition as argument,
get passed in a partition of the disk on which the operation is being done!
commit d1cfc08a39c59ab99377b656229e15086e335662
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Mar 23 13:39:12 2009 -1000
Check ownership when removing partitions from disk.
Failing to do this will cause libparted to SIGSEGV.
Patch from Joel Granados <jgranado AT redhat DOT com>.
commit 3158133ea7904cedbe379e7b3df28d9577158595
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Mar 20 17:27:13 2009 -1000
Update version number for new development tree.
commit 02f59bcb066cc8b32cf9b2f9130ee4366026eead
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Mar 20 17:22:25 2009 -1000
New version.
commit e43fe6dff7c1b555ac500b58ef00e8bd1fe5135b
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Mar 20 17:02:07 2009 -1000
Ensure PedDisk pointers match when we call ped_disk_set_partition_geom()
commit 03f9751775a2006f3e2bbe18bef4be92accb358d
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Mar 20 14:59:10 2009 -1000
Remove unused variables.
commit 173bbc267b60f4f4f47af7cdae2bf39ed919bb95
Author: Hans de Goede <hdegoede@redhat.com>
Date: Fri Mar 20 15:59:15 2009 +0100
Use one and only one _ped_Disk object to represent a PedDisk object (#489745).
This one is best explained (I think) by explaining what was happening in the
old code.
1. Create a new _ped_Disk object, lets call this pydisk
2. Get a _ped_Partition from pydisk with (ie) py_ped_disk_next_partition
3. py_ped_disk_next_partition calls ped_disk_next_partition and gets a
PedPartition
4. Then it calls PedPartition2_ped_Partition on the PedPartition it just got,
lets call the resulting _ped_Partition pypart, but we are not that far yet.
5. PedPartition2_ped_Partition takes the PedDisk the PedPartition is on,
part->disk and then calls PedDisk2_ped_Disk on it. Note part->disk is
the same as pydisk->ped_disk !
6. PedDisk2_ped_Disk creates a new _ped_Disk object with its ped_disk pointing
to the passed in part->disk, lets call this pydisk2. Note how pydisk's and
pydisk2's ped_disk attribute point to the same PedDisk.
7. PedPartition2_ped_Partition stores pydisk2 in pypart->disk and returns
pypart to py_ped_disk_next_partition, which in turn return it to its caller
8. So now we have 2 _ped_Disk objects pointing to the same PedDisk,
pydisk and pypart->disk (aka pydisk2)
9. We do some stuff with pypart and then are done with it
10. _ped_Partition_dealloc(pypart) gets called, it DECREF's pypart->disk
11. _ped_Disk_dealloc gets called on pypart->disk aka pydisk2
12. _ped_Disk_dealloc calls ped_disk_destroy(pydisk2->ped_disk)
13. We try to do some stuff to pydisk, which ends up using pydisk->ped_disk,
which now points to freed memory / a destroyed PedDisk object, not good.
This patch fixes this by passing in the existing _ped_Disk object in to
PedPartition2_ped_Partition, and simply INCREF-ing it there.
commit e54687d575eccb56438e247dd3e3a1e8c5342133
Author: Chris Lumens <clumens@redhat.com>
Date: Fri Mar 20 14:30:21 2009 -0400
Add missing import.
https://fedorahosted.org/pyparted/ticket/12
commit 5ea89ffbfd35c6304215f10614bbcfdbe5e3ee12
Author: Chris Lumens <clumens@redhat.com>
Date: Fri Mar 20 14:23:56 2009 -0400
Use a better test for empty extended partitions (#491326, hdegoede).
My original test for whether the extended partition was empty or not was not
quite right, as there's still a freespace "partition" in the part_list.
libparted works around this by removing freespace and metadata partitions from
the part_list before doing the check, then removing them afterwards. We should
just ignore them here.
commit 1048e1bf29aae86537a066f5450224aedf74d90b
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Mar 19 18:33:42 2009 -1000
Update version for new development tree.
commit 006b52ff74dbde9d79f74ebbcc110d7c43057529
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Mar 19 18:30:13 2009 -1000
New version.
commit 04e502aef8fb814378a7ee1467f042c0c75e13a5
Author: Chris Lumens <clumens@redhat.com>
Date: Thu Mar 19 13:17:13 2009 -0400
Raise an exception if an extended part still contains logical partitions.
commit 845c971eda3a67f5c4fa387f5c7ec23de3747cd2
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Mar 18 10:19:39 2009 -1000
Catch PartitionException in parted.Partition.name property.
Not all disk labels support get_name(). If we don't have that, an
exception is raised.
commit d5e20a8f4cb4e18954e584fabe415ce01d096ee7
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Mar 18 10:19:13 2009 -1000
s._device -> self._device
commit b945a3d8ba2452e383b30cda5e27db4a8e7de65e
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Mar 18 10:18:05 2009 -1000
Call is_busy(), do not pass it to bool()
is_busy() returns a bool, so we only need to return that in the
parted.Device.busy property.
commit 1cea4bbdd3c9a6c2a852e166c4b9922a10cb69d7
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Mar 16 11:31:21 2009 -1000
Use new style Python property syntax for read-only properties.
Use @property methods for read-only properties to increase
readability in the code.
commit 992271fc02b620b31bb27ab3f78c54bee030e52e
Author: Chris Lumens <clumens@redhat.com>
Date: Mon Mar 16 11:06:11 2009 -0400
Fix a typo in a test case.
https://fedorahosted.org/pyparted/ticket/10
commit f9a01ca683cd06ae7a988c046761fad59560f01b
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Mar 13 11:27:50 2009 -1000
Improve readability of parted.Device property code.
Use new-style @property syntax for the properties on
parted.Device.
commit ca18a0a64fd1706886ee74b8d55241a9bdd72701
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Mar 13 10:57:04 2009 -1000
DEVICE_DM only exists if libparted was built with device-mapper.
GNU parted must be compiled with --enable-device-mapper in order
to have PED_DEVICE_DM defined (which leads to DEVICE_DM defined.
commit 4fcc41b808bb55399760bc9d1540b3bc520fd5ac
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Mar 12 11:11:49 2009 -1000
Update version for new development series.
commit b1093fdccd167263f1d2f1c6ec8d12f2914da274
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Mar 12 11:06:07 2009 -1000
New version.
commit f8a2d385801019ec07d0ea7fbfeb24077a59cf25
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Mar 12 11:04:48 2009 -1000
PED_DEVICE_DM may not be defined
If PED_DEVICE_DM is not defined, do not try to add it to our
module. parted has to be built with --enable-device-mapper to
get this define enabled.
https://fedorahosted.org/pyparted/ticket/9
commit 1f80a2abb14b33ce4eb6e346a23c531a12c11ffb
Author: Chris Lumens <clumens@redhat.com>
Date: Thu Mar 12 13:46:48 2009 -0400
Don't pass NULL to PyString_FromString (#489518).
If the string we're supposed to return is NULL, return an empty string
instead. Passing NULL is certainly a bug, though pyparted may not be the
offender in the above referenced bug.
commit f7a561f40b566dbd67b9179b6436a06653520b40
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Mar 5 15:05:58 2009 -1000
Update version number for new development release.
commit d9ed8c79e83b0faf0198f155714952d8eff15281
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Mar 5 15:03:27 2009 -1000
New version.
commit 20d723775331c3ab38e6dadf0acda31bb20233fc
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Mar 5 14:37:22 2009 -1000
Update cached geometry when py_ped_disk_set_partition_geom() is called.
commit 13d599774c6710c701c2454763dbb8911869b612
Author: Chris Lumens <clumens@redhat.com>
Date: Thu Mar 5 10:28:07 2009 -0500
Add a DiskLabelException class and raise it instead of IOException.
This makes it much easier to tell when the problem was that there was no disk
label on a disk, instead of some other random IO error.
commit 6190399332a58218b554285d9969718a02e0a6af
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Mar 3 14:02:08 2009 -1000
Invalidate cached partitions when minimizeExtendedPartition() is used
The geometry of the extended may change, so invalidate the cache
if this method succeeds.
commit d91d3b6bc9afeb5f00cbdf40a66b1309ef04d33d
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Mar 3 14:00:55 2009 -1000
Move clobber() method to parted.Device
These methods moved in _ped, so move them in parted.
commit 939514cb042afb7301e72ff68b6dab8ce445c5f8
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Mar 3 13:58:21 2009 -1000
Remove invalid line from py_ped_disk_minimize_extended_partition()
There are not _ped_Partition or PedPartition objects we work with
in this function.
commit 9f4ca6401c43bfb02776cd08966718677dd444bf
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Mar 3 13:56:24 2009 -1000
When updating a partitions geometry, update the pyobject contents
When updating a partitions geometry, update the pyobject contents,
instead of dereferencing it and creating a new one.
(Patch from Hans de Geode.)
commit e28c0d6a88682489716cc96a675496cfe43dc1c6
Author: Hans de Goede <hdegoede@redhat.com>
Date: Sun Mar 1 20:39:01 2009 +0100
Fix copy and paste error
Do not use _ped_FileSystem_Type_obj.tp_repr() to represent a _ped_Geometry
object, but use _ped_Geometry_Type_obj.tp_repr() .
Signed-off-by: David Cantrell <dcantrell@redhat.com>
commit 63f204b75ea8833ce0bf963469f899ea8ac5a2d3
Author: Hans de Goede <hdegoede@redhat.com>
Date: Sun Mar 1 20:38:09 2009 +0100
Update _ped_Filesystem's _ped_Geometry object in py_ped_file_system_resize()
py_ped_file_system_resize() changes the geometry of the filesystem, so we
need to update our PyObject representing the geometry with the new data.
Signed-off-by: David Cantrell <dcantrell@redhat.com>
commit 424061454f930e65826b4d44c4d0afb24dad75d0
Author: Hans de Goede <hdegoede@redhat.com>
Date: Sun Mar 1 20:10:02 2009 +0100
Update _ped_Partition's _ped_Geometry object in disk functions which change it
py_ped_disk_set_partition_geom() and py_ped_disk_maximize_partition() change
the geometry of the partiton, so update the partitions _ped_Geometry object
to match the new geometry.
Signed-off-by: David Cantrell <dcantrell@redhat.com>
commit 48ce309268c57c079cade5db647af46b8617aee4
Author: Hans de Goede <hdegoede@redhat.com>
Date: Sun Mar 1 19:23:27 2009 +0100
Cache libparted geometry objects in our _ped_Geometry objects
Currently _ped_Geometry2PedGeometry() returns a pointer to a new libparted
PedGeometry object each call, and not a single users frees this object. By
making _ped_Geometry cache the underlying PedGeometry object this patch fixes
this memory leak (and gives a very very small speedup by avoiding creating a
lot of new PedGeometry objects).
This patch also adds sanity checking to any changes made to _ped_Geometry.
{start,length,end}. And makes setting the end actually change the geometry
(the old _ped_Geometry2PedGeometry() never used the end member, so changing
it did not have any effect).
Signed-off-by: David Cantrell <dcantrell@redhat.com>
commit 33bb48df89f6d3ab10b067abe678f383f6e57158
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Mar 3 13:48:43 2009 -1000
Updated TODO list.
commit 0ebea186a827d1e395d81983dc58fcab53e9354c
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Mar 3 12:03:03 2009 -1000
Call py_ped_disk_remove_partition() from py_ped_disk_delete_partition()
Use ped_disk_remove_partition() so that we safely destroy on-disk
partitions, but keep the PedPartition alive since we may be pointing
to that from Python objects.
commit c74c80bfcfca291205b10b769c5972ac789e1019
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Mar 3 12:00:02 2009 -1000
Make py_ped_disk_clobber*() members of _ped.Device
The ped_disk_clobber() and ped_disk_clobber_exclude() functions
work on a PedDevice, so make them members of the _ped.Device
object.
commit 90985b66f3eeb8e6f1b9db2c12cb0273eeed8539
Author: Chris Lumens <clumens@redhat.com>
Date: Tue Mar 3 11:25:24 2009 -0500
Fix a couple simple build warnings.
commit daa6cebbcf4aff6a8d4852b928e8bbafa17555b0
Author: Chris Lumens <clumens@redhat.com>
Date: Tue Mar 3 11:11:11 2009 -0500
_ped.Disk.__init__ only takes one argument now. Update tests.
commit 7041b5061065eb944ec9fb167787a31e0da63312
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Mar 2 15:22:43 2009 -1000
Update TODO and BUGS file.
commit 3f556b4ec5decdc8a83feb9db3360a2ec11cc0b2
Author: David Cantrell <dcantrell@redhat.com>
Date: Sat Feb 28 18:53:24 2009 -1000
Update version number for new development release.
commit d07090834506fcc15f8e4b7591743a812efafe3c
Author: David Cantrell <dcantrell@redhat.com>
Date: Sat Feb 28 18:41:06 2009 -1000
New version.
commit 0d0f99d2ffb60f665a2897af9a2a97a5c50fc0a8
Author: David Cantrell <dcantrell@redhat.com>
Date: Sat Feb 28 18:37:31 2009 -1000
Update geometry when a partition is added to a disk label.
Update our copy of the geometry object in both _ped and parted.
In the _ped module, grab the new PedGeometry and convert it to
a _ped.Geometry and put it in the existing _ped.Partition
object. In the parted module, update the partition.geometry
property in parted.Disk.addPartition().
commit 5ae6e61a0fe925116f7364a4a9851471efbbb9e1
Author: David Cantrell <dcantrell@redhat.com>
Date: Sat Feb 28 15:29:23 2009 -1000
Read at most 10 characters for the devel string identifier.
commit 20551d5b3d66da0c9abe2d4acb0da757c2388680
Author: David Cantrell <dcantrell@redhat.com>
Date: Sat Feb 28 12:13:06 2009 -1000
Mark _ped.Partition as owned by a Disk when necessary.
Prevent accidental free of PedPartition when it becomes owned by
a PedDisk.
https://fedorahosted.org/pyparted/ticket/4
commit b450ae9a2fc4b34968e321618c4675e127322ca8
Author: David Cantrell <dcantrell@redhat.com>
Date: Sat Feb 28 12:06:23 2009 -1000
For _ped.Partition functions, pass _ped_Partition instead of PyObject.
For all of the functions that provide methods on _ped.Partition
objects, pass the first argument as a (_ped_Partition *) rather
than a (PyObject *) that we may or may not have to cast.
commit d4f433a85b3be1b63c1bb5a71e2801bd793701fe
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Feb 27 14:56:17 2009 -1000
Update for new development version.
commit 40e72adc3f66a140dcbd4823d1662c3c1c91af64
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Feb 27 14:55:57 2009 -1000
The archive is a .tar.gz not a .tar.bz2
commit 008655baf742696210ac9e2d2c40d10b75e4a1f6
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Feb 27 14:52:47 2009 -1000
New version.
commit e42fa2a2fe16b09f559cd510a7b022e0823f0186
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Feb 27 09:52:00 2009 -1000
Revert "Replace PyErr_ExceptionMatches() with PyErr_Occurred()"
This reverts commit a54541462b7c7df9a0124cdf25f3348446c59e1c.
commit a54541462b7c7df9a0124cdf25f3348446c59e1c
Author: Hans de Goede <hdegoede@redhat.com>
Date: Fri Feb 27 14:35:05 2009 +0100
Replace PyErr_ExceptionMatches() with PyErr_Occurred()
In various places we check wether the libparted exception handler was called
when we got an error return from libparted. We then check to see if
our custom libarted exceptionhandler has already defined an exception, using
PyErr_ExceptionMatches(PartedException), if it has not already defined an
exception, then it should have set partedExnMessage, and we define our
own exception using partedExnMessage.
However our custom libarted exceptionhandler will also define exceptions of
the PyExc_NotImplementedError type, in which case our custom libparted
exceptionhandler has not set partedExnMessage. However as
PyErr_ExceptionMatches(PartedException) does not catch the
PyExc_NotImplementedError case, we still define our own exception using
partedExnMessage, this causes us to call PyErr_SetString() with a NULL
pointer which triggers in assert inside python's C-code.
This patch avoids triggering this assert by using PyErr_Occurred() instead of
PyErr_ExceptionMatches() to see if our custom libparted
exceptionhandler has already defined an exception.
Signed-off-by: David Cantrell <dcantrell@redhat.com>
commit 5e66da497f2b5be9f4c68f33acaab345a90c3d15
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Feb 27 09:36:40 2009 -1000
Update development version number.
commit 3e39c8c8e250b78c2feaae3b7af8879a646322e8
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Feb 27 09:35:22 2009 -1000
Instructions on making a new release.
Rather than increasing the version number after each release, I'd
rather tack on '-devel' to the version. Modified the
pyparted_version() function to work accordingly.
Added RELEASE file which explains the steps I use to make a new
release.
commit 58ce4355b6f0b9711d9b05c1b07a2b3fa96d00b3
Author: Chris Lumens <clumens@redhat.com>
Date: Fri Feb 27 09:39:19 2009 -0500
Include cachedlist.py in the archive, thanks.
commit 9c0041e37e0240bae540e74e47a191cf30de171c
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Feb 25 14:11:35 2009 -1000
Fix compile errors in pyfilesys.c
commit 056b247fa6bf57c6158a1aa550d5590fd7756611
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Feb 25 14:08:37 2009 -1000
Add some more test cases.
Not much here, but I've been working on it.
commit bd5468bec2876270d51eb8e3a7ab1cc4b7b47865
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Feb 25 14:08:25 2009 -1000
Add parted.freeAllDevices()
commit 4b43fdf320910cdfebd43029eea8124c170fb8f7
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Feb 25 10:39:09 2009 -1000
Add ped_filesystem to _ped_FileSystem struct.
Cache the PedFileSystem inside a _ped.FileSystem now.
commit 166961ced21c26e66def2ec14b5029ef72d45fbb
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Feb 25 10:37:58 2009 -1000
Clean up cached libparted types in dealloc functions.
In _ped_Disk_dealloc(), call ped_disk_destroy() on the cached
PedDisk.
In _ped_FileSystem_dealloc(), call ped_file_system_close() on the
cached PedFileSystem.
In _ped_Partition_dealloc(), call ped_partition_destroy() on the
cached PedPartition.
commit 240bb8f707ee5d71f90696b14afeb1f3424a509c
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Feb 25 10:25:58 2009 -1000
Cache PedFileSystem in _ped.FileSystem
Only perform one open operation for the _ped.FileSystem and keep the
PedFileSystem cached so we can use that for subsequent fs-related
calls.
commit 9996752a0e8896e7d6c86262d62d2ce2323847a9
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Feb 25 10:04:27 2009 -1000
Remove unncessary Py_INCREF and incorrect GC_DEL.
https://fedorahosted.org/pyparted/ticket/1
commit be7e48783072d9f870c6cee4313406329b280318
Author: Chris Lumens <clumens@redhat.com>
Date: Wed Feb 25 15:09:42 2009 -0500
Use a CachedList for storing the partitions list to speed things up.
commit 5455a0a1b245961d1908db24f9766e77bdfae18b
Author: Chris Lumens <clumens@redhat.com>
Date: Wed Feb 25 15:09:20 2009 -0500
Add a caching list implementation.
The documentation in the file should explain how to use it.
commit 5524f4aa88b77db735985e6882988df9af6b17e1
Author: Hans de Goede <hdegoede@redhat.com>
Date: Wed Feb 25 10:02:47 2009 +0100
Fix various memleaks in error paths
Fix various memleaks in error paths.
Signed-off-by: David Cantrell <dcantrell@redhat.com>
commit 96f262d017c00a1b4a149558c66c87afc3648663
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Feb 23 17:32:39 2009 -1000
Some pychecker fixes.
pychecker caught some stuff. It complains about a lot, but then
the code works anyway. I do not know how to make pychecker
understand dicts. It also seems to hate hidden variables unless
they are used in the same module. Might look at pylint.
commit f3a777d0afb9ba12dfafeb6fbd0aeb5d87dc7722
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Feb 23 17:32:24 2009 -1000
Need reproducers for these bugs that we can run from Python.
commit 168e5eafcf6f55abe3ef6be63be1f94423f4021b
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Feb 23 17:00:39 2009 -1000
Remove unnecessary '*' from boilerplates.
'FOR A * PARTICULAR' -> 'FOR A PARTICULAR'
commit bbdacdd10cbfa59f7352c9cbf54cec646a5dd3cd
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Feb 23 16:54:04 2009 -1000
Update the release tag in Makefile.am and fix boilerplate.
Fix a typo in the boilerplate.
In the release tag, remind us that we need to make a new Version
entry in the Trac admin page for the project.
commit d7c8b4327b22d2b64376f4791f5b9896d912d8ce
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Feb 23 14:56:37 2009 -1000
More BUGS.
commit 570d1cf4ec08ba2a17c6a609df15c19c03250e9d
Author: Chris Lumens <clumens@redhat.com>
Date: Tue Feb 24 10:15:13 2009 -0500
Use the right types for numeric members of _ped.Disk in __str__.
commit cd49c89467ee3ac2e25b5eda97756b7242722bc1
Author: Hans de Goede <hdegoede@redhat.com>
Date: Sun Feb 22 20:18:59 2009 +0100
Fix typo in error checking in pyfilesys.c
Fix typo in error checking in pyfilesys.c.
commit fdd3f3824294327cb6aeddbf48c3df0cbfdc5cfa
Author: Hans de Goede <hdegoede@redhat.com>
Date: Sun Feb 22 17:56:03 2009 +0100
Add missing error checking to a few *2_ped_*() calls
Add missing error checking to a few *2_ped_*() calls.
commit e848b787a7cfdaf0120baa198b2604f6cee89b34
Author: Hans de Goede <hdegoede@redhat.com>
Date: Sun Feb 22 17:36:28 2009 +0100
Do not call free on a PedDiskType
Do not call free on a PedDiskType.
commit 621c7d12981c165e5e71de439e2d3f9818d9db6e
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Feb 23 13:46:53 2009 -1000
Add remaining __str__ methods for _ped module.
Remaining __str__ methods and test cases stubs for the following
classes in _ped:
_ped.DiskType
_ped.FileSystemType
_ped.CHSGeometry
commit 515aed1bfff0dafd8de1419e6af8bc1082087334
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Feb 23 13:36:43 2009 -1000
Move _ped_Device_str to the _ped_Device_Type_obj.
Accidently put this one on _ped_CHSGeometry_Type_obj first.
commit 265bf90f5889369ed08bb9ba5ddb54e3f4848fa8
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Feb 23 12:33:54 2009 -1000
Added __str__ method for _ped.Partition
commit 8f5b99f7715c6998f4c5ce581017c9ce900de4b9
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Feb 23 12:24:33 2009 -1000
Added __str__ method for _ped.Geometry
commit 926cd690524c228d16a4c837fc8265076282135d
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Feb 23 12:07:25 2009 -1000
Added __str__ method for _ped.FileSystem
commit 2aaa014fa69b83d399d9a221660b5545bb63d050
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Feb 23 11:59:46 2009 -1000
Added __str__ method for _ped.Disk
commit 3872a6b411e4f733a4ff2060bd6b1ee73ba0d093
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Feb 23 11:46:39 2009 -1000
Added __str__ method for _ped.Device
commit 708b70edd3b27851d299c45acd33405b97e6ed2f
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Feb 23 11:29:36 2009 -1000
Do not free() values from PyString_AsString()
commit b1ce959e2c2a013d243bf5acae05731ff4084c6f
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Feb 23 11:26:58 2009 -1000
If PyString_AsString() returns NULL, filter back up.
If we get NULL from PyString_AsString(), we have a TypeError or
other exception raised, so we need to return NULL here so it
filters back up the stack.
commit 72b6c2512c0d45c4d76844c5aa2abb397a6ecc96
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Feb 23 11:20:48 2009 -1000
Add __str__ method for _ped.Constraint()
This one is more complex than the one for _ped.Alignment. Since
a _ped.Constraint has two Alignments and two Geometries and two
Sectors, we need to call the repr() methods a few times. Namely,
we need to call repr() for the two Alignments and the two
Geometries. Sectors are long longs, so we can pull those in
directly.
Also stubbed out the test case.
commit d141db7769224e7b3c6f556b3fcaf1a7387a2e02
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Feb 23 11:20:20 2009 -1000
Wrap the long line in pynatmath.c:_ped_Alignment_str()
commit 5e8757cd5b950d40b7fc5d092064f6b8b1ecee3b
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Feb 23 10:51:44 2009 -1000
Added __str__ method for _ped.Alignment.
We have __str__ methods on parted module classes, so we should
have them on _ped for completeness. This is the one for
_ped.Alignment. Also included the stub for the test case.
The next commits will be similar for the remainder of the classes
that need __str__ methods.
commit a1399f30170888e7a8dfb278c95d36e89ee7b820
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Feb 23 10:38:13 2009 -1000
Stub out __str__() test cases for the parted module.
commit 76d4a4f638acb42ef0a41bc9bdf2dc953dcd41d4
Author: Chris Lumens <clumens@redhat.com>
Date: Mon Feb 23 16:20:56 2009 -0500
Free temporary buffers in read and check methods.
commit 7f677f6e3120673e17765f7e8a9eeec5c8df54e7
Author: Chris Lumens <clumens@redhat.com>
Date: Mon Feb 23 16:13:15 2009 -0500
ped_disk_type_check_feature can accept 0 as a feature flag.
commit 916109a889895a1f54ae88daa67e271b04ad5ed4
Author: Chris Lumens <clumens@redhat.com>
Date: Mon Feb 23 16:04:37 2009 -0500
Using "z" everywhere doesn't make sense.
Not all libparted functions want a NULL string, so we need to make sure to
only use "z" in PyArg_ParseTuple either where the libparted method is okay
with a potential NULL or where we explicitly test for it.
commit bfb8937f067f90b6a3bb0d90eaecdda5a390d306
Author: Hans de Goede <hdegoede@redhat.com>
Date: Fri Feb 20 20:11:10 2009 +0100
Fix various python object leaks in convert.c
This patch adds a ton of missing DECREF's and removes a few unneeded INCREF's
from convert.c
commit de47c58a9527a19797021232f7791513a56896e6
Author: Chris Lumens <clumens@redhat.com>
Date: Fri Feb 20 15:52:57 2009 -0500
More do not keep a borrowed refence without INCREF-ing it changes (hdegoede).
commit 10805323df4bb775f72e7e18de61f4317d61afc3
Author: Chris Lumens <clumens@redhat.com>
Date: Fri Feb 20 15:43:37 2009 -0500
Remove an unneeded INCREF from pygeom (hdegoede).
commit 92dc2b40f1b535f0712e0bb55483f2d30949a5f6
Author: Chris Lumens <clumens@redhat.com>
Date: Fri Feb 20 11:51:57 2009 -0500
Remove a couple of unneeded INCREF's from pydisk.c (hdegoede).
Remove a couple of unneeded INCREF's from pydisk.c, stopping us from leaking
a couple of python objects.
commit 2705ccaef2dcf83bfb48a985fb56fb91ddf0f833
Author: Chris Lumens <clumens@redhat.com>
Date: Fri Feb 20 11:50:21 2009 -0500
Free c-strings on dealloc too (hdegoede).
In a couple of places we store strdup-ed C-strings in our python objects, free
these when the python objects get destroyed.
commit 0dc25daef13e9a1ee9aa31e871e78bb11995d71c
Author: Chris Lumens <clumens@redhat.com>
Date: Fri Feb 20 11:45:39 2009 -0500
Do not keep a borrowed refence without INCREF-ing it (hdegoede).
In _ped_Disk_init we store a borrowed reference in self->dev (through
PyArg_ParseTuple()). We INCREF this on success at the end. But we keep it
without INCREF-ing it in an error path. This path clears the borrowed reference
in the error path. This fixes various cases of python crashing when having
an invalid partition table.
commit b4c1d75688d93e17b7c55fa111ff34134d22065a
Author: Chris Lumens <clumens@redhat.com>
Date: Fri Feb 20 11:29:15 2009 -0500
Add __str__ methods to all parted objects.
This will make anaconda exception dumps more useful, since the __str__ methods
are what we use there to print objects out. Note that we cannot implement
__repr__ methods now, because we use those in the __str__ methods to print out
the very short description of objects. Otherwise, we'd end up with never
ending printout as we go around in circles printing members.
commit 14984c740a9f2c322c2424b1e432376d0a0219c1
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Feb 19 12:43:47 2009 -1000
Created a HACKING file.
commit 78849cf9c0dcd6d147ba3dcd2f3bd8b7be270967
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Feb 16 16:28:54 2009 -1000
Increment version number for next release.
commit 569b02a02a728078cb8ce752f577cd5f74766ff8
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Feb 16 16:19:47 2009 -1000
Updated documentation.
commit 2d23f6048780c31d49d1107dfdb8260db825b41b
Author: Chris Lumens <clumens@redhat.com>
Date: Mon Feb 16 10:18:40 2009 -0500
If two object have different types, they are not equal (#485632).
commit e5572f25bd2326ec48d01505bee056be191cb0e9
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Feb 12 14:37:13 2009 -1000
Increase minor version number for next release.
Want to get in the habit of keeping the master branch at the next
release version number so I don't forget to bump at the end. I am
not storing the spec file for the pyparted package in the upstream
project, so configure.ac is the location of the version number.
commit 8189df962c17cba5c348b4a2066bbe1a57dee37a
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Feb 12 14:36:44 2009 -1000
Makefile.am fixes.
commit a2e425a9dbbc599edaf91e647e1b2a9c84a9d077
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Feb 12 10:49:02 2009 -1000
Fooled around with fdisk.py a bit last night.
It's a work in progress, but it could provide a nice way to test
out pyparted.
commit 2e5dd020aaf9d8806d81a6536b0bb8de7396a34e
Author: Chris Lumens <clumens@redhat.com>
Date: Thu Feb 12 15:16:29 2009 -0500
Remove temporary buffers and sizes from the public API.
commit 2c37ad942ab79b075e608217a5508ab2ec8b55de
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Feb 12 10:11:08 2009 -1000
Updated documentation.
commit 217878eb9ede310fbff7fa19be760d4edf01aa10
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Feb 12 10:10:26 2009 -1000
math.floor() -> float()
Fix problem found by jgranados. This function didn't get
transferred entirely correctly from partedUtils.py to pyparted.
commit 8755935562c5de738b11b86927b290e307132d06
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Feb 11 14:17:43 2009 -1000
Speed up parted module a bit.
Pass around parted.Disk and parted.Device if we have those. No need
to keep creating them over and over.
commit ee1ac7ed134027dc4135962088f1779a886d7fdf
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Feb 11 13:16:00 2009 -1000
Added tag and release targets to Makefile.am
Getting near release time.
commit d6685ebe180266d0e4d13fe2bdee5d41fdda9c1d
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Feb 11 10:45:41 2009 -1000
Removed getSizeAsSectors()
Why did I add this? It's parted.Device.length
commit 281d5b1d5e0e32498f5c5f70a7f522e2df87e6cb
Author: Chris Lumens <clumens@redhat.com>
Date: Wed Feb 11 15:57:22 2009 -0500
We did some stuff.
commit 380a615529044c86f931c32ff79e6a19bc50ca13
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Feb 10 18:39:10 2009 -1000
More test case cleanups and new test cases.
commit c613c0a71ca2f692c8386da8b83607e550b198f8
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Feb 10 18:38:16 2009 -1000
_ped.partition_flag_next() loops around to the beginning.
It does not raise an exception if you try to get a flag beyond the
end of the list, it just goes back to the beginning, which is flag
0. Stop the loop on that condition.
commit 50e8bd272ee956ed2b3420e12533e55d0cb885eb
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Feb 10 16:43:07 2009 -1000
Code and documentation cleanups in the parted module.
Added more properties to parted.Constraint.
commit d82afc658491e92a3fff36cdaf181a4f25fba48f
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Feb 10 16:42:54 2009 -1000
More test cases for the parted module.
commit c0df5e8c197f785dd81d2f05591c535bf7d7ca8a
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Feb 10 13:18:38 2009 -1000
Fix errors in src/parted/alignment.py
setattr() was called incorrectly and the isAligned() method needed
to handle invalid input.
commit b2d365a809e1dc2dfc00e98534f64eaf401dd05d
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Feb 10 13:18:11 2009 -1000
Three test cases for parted/test_alignment.py
AlignmentNewTestCase
AlignmentGetSetTestCase
AlignmentIsAlignedTestCase
commit 83be0f0c0fe8f0708b16749772974892c0e7bad0
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Feb 10 13:07:33 2009 -1000
Remove suite.addTest() lines for rounding functions.
commit 0264328d34de531927a7087c5aabc6591dba9ea7
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Feb 10 13:07:06 2009 -1000
Add baseclass.py for parted test cases.
Adapted from _ped/baseclass.py
commit 23b4533349dcfa431fe2abff968d4a645c0c9b1f
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Feb 10 12:44:23 2009 -1000
Remove rounding function test cases and add simple test case.
In the parted module test cases, remove the ones for the
rounding functions. Added a test case for the version()
function on the parted module.
commit 9a1effe2b7a6aefb1d2fbe53c618df7fb63a9676
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Feb 10 12:44:07 2009 -1000
Remove rounding function test cases.
commit bf44c1afdb820e0e98934216262606aec20d425c
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Feb 10 12:42:23 2009 -1000
Remove pointless rounding function pass-throughs.
libparted has some math utility functions that are useful inside
libparted and probably C programs linking with libparted, but we
don't need to expose those pyparted users. Removed the following
functions because we can perform the same tasks in native Python:
py_ped_round_up_to()
py_ped_round_down_to()
py_ped_round_to_nearest()
py_ped_greatest_common_divisor()
py_ped_div_round_up()
py_ped_div_round_to_nearest()
commit 7d09d3d1e38fd023e050774adf2f0dc81508837a
Author: Chris Lumens <clumens@redhat.com>
Date: Tue Feb 10 16:56:00 2009 -0500
Add custom __eq__ and __ne__ methods on parted objects.
commit 4640a5ef36ab2287a16dd777094693c536113292
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Feb 10 11:34:44 2009 -1000
Make all unwritten test cases fail with self.fail()
Rather than pass, use self.fail with the message "Unimplemented
test case." so we continue to see those messages when we run
'make check'. Right now, it's a bit misleading because the pass
causes the test case to succeed.
commit aa6eb4eaed4b51c7db8c2491fe84d5d485a21757
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Feb 10 11:34:34 2009 -1000
Add docstrings for parted.probeFileSystem()
commit 569130afeb021eb9fd58b7801389e49337f783bd
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Feb 10 11:16:52 2009 -1000
Add tests/parted/Makefile to configure.ac
commit a387bc618976aa36bdd249edb09d2ad1ccc68dea
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Feb 10 11:01:05 2009 -1000
Updated documentation.
commit 28505b51d4fa78da587d3f5b47ad60e652176102
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Feb 10 10:46:04 2009 -1000
Spelling fix in docstrings.
commit 0290e8ad3b45bdaf628b05ceb28f39a8b9623d89
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Feb 10 10:45:42 2009 -1000
Started test cases for the parted module.
Just the test case file layout.
commit 1cf112c83f5dc88bd9cecae3a68fb9ab963b8578
Author: Chris Lumens <clumens@redhat.com>
Date: Tue Feb 10 13:14:08 2009 -0500
We can't call Py_CLEAR on a libparted type.
commit b46974a542da2a2cbb8dbed4ab0c2cb5647b890d
Author: Chris Lumens <clumens@redhat.com>
Date: Tue Feb 10 11:54:39 2009 -0500
Fix a couple pychecker-discovered errors.
commit 77ac49dc681a1a3c6fba503ce70ecdb0e3abae7b
Author: Chris Lumens <clumens@redhat.com>
Date: Tue Feb 10 11:46:21 2009 -0500
Type conversions in geometry.py as well.
commit 9b0dfe39b60345bbd743044e2456db3b8d1b6506
Author: Chris Lumens <clumens@redhat.com>
Date: Tue Feb 10 11:39:43 2009 -0500
Fix type conversions in filesystem.py
commit 16bf5f161bf2e239a073b591f4b234598d2cc32e
Author: Chris Lumens <clumens@redhat.com>
Date: Tue Feb 10 11:35:19 2009 -0500
Fix a few more _ped <-> parted type conversions in disk.py.
commit af2b84ab975b84b2800a3b8174402e1f3fa847e5
Author: Chris Lumens <clumens@redhat.com>
Date: Tue Feb 10 11:27:17 2009 -0500
Handle conversion between _ped and parted types in constraint.py.
commit 066fadaf76c72b119df3cacc26ad97b6b71b428c
Author: Chris Lumens <clumens@redhat.com>
Date: Tue Feb 10 11:19:36 2009 -0500
Let Alignment take offset+grainSize or a PedAlignment.
Also, handle conversions between _ped types and parted types.
commit a7e0ae8a6cd5d56efa7ccdf4b06bcb6a735905a1
Author: Chris Lumens <clumens@redhat.com>
Date: Tue Feb 10 11:07:13 2009 -0500
Return the correct parted module type in more places (dlehman).
commit ab182d4ab0c20a1e6834205604a34491d3d4c6ba
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Feb 9 19:01:54 2009 -1000
Update documentation.
commit 86c2ea8ae9e77c70f50a44da209a8f49ad9d3b8f
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Feb 9 10:51:41 2009 -1000
Added parted.Device.getSizeAsSectors()
Returns the number of sectors that make up a device. Size of disk
as bytes, divided by sector size, +1 if there is a remainder.
commit 7c0ff88155e042ea5b687b4d838415b605367a06
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Feb 6 16:55:07 2009 -1000
Disable self.partitions cache in parted.Disk
The caching system is not working quite right, so disable it for
now.
commit 686fb4ace20dd3812f729d2d296a9c120148b733
Author: Chris Lumens <clumens@redhat.com>
Date: Fri Feb 6 15:25:50 2009 -0500
...except, put "/dev/" on the right argument.
commit 2ded7025914a1ec0baa9a8136b8548366b1e6c08
Author: Chris Lumens <clumens@redhat.com>
Date: Fri Feb 6 15:10:03 2009 -0500
getDeviceNodeName returns just the node, not the full path.
commit d134337a4f33510c816fd0b1ae704c0d597ed0d5
Author: Chris Lumens <clumens@redhat.com>
Date: Fri Feb 6 11:45:01 2009 -0500
We must call ped_disk_commit_to_dev after ped_disk_fresh_new.
If we don't, nothing will get written to the disk and running the conversion
functions will fail. ped_disk_fresh_new only operates on the in-memory
representation.
commit 4c415dc90843c31dd37ddb89bbf31f9e26ea9a33
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Feb 5 19:28:32 2009 -1000
Py_INCREF the _ped.Partition in py_ped_disk_add_partition()
commit 91e8f585ea78de61ef10e72d612df3c2b5a533c8
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Feb 5 19:27:50 2009 -1000
Change how self.partitions is generated.
The get_partition() method doesn't seem to work quite right, so
use next_partition() to step through the partition list.
Syntax fix as well (return Partition should be return partition).
commit 58766a01be76989ef9619763fba7793b641908d4
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Feb 5 19:04:08 2009 -1000
Add getPartitionByPath() to parted.Disk
Removed the parted.getPartitionByName() function since it wasn't
really what we wanted. Created getPartitionByPath() on Disk
which works in the same way, but only on that Disk.
In parted.Disk, make sure the self.partitions list is being
refreshed often enough.
commit 1861e1bd38413f88647bc7048ba60da021300c40
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Feb 5 11:13:13 2009 -1000
Fix warnings in py_ped_disk_add_partition()
Pass PyObjects to convert.c functions, but use a _ped_Partition
here so we can access those structure members.
commit 7ab96f7d53664e2fb2cd5ca32e314f68571a3834
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Feb 5 10:52:35 2009 -1000
After ped_disk_add_partition() call, update partition number.
The ped_disk_add_partition() function in libparted takes in a
new PedPartition and adds it to the in-memory partition table
for the disk. The partition is given a number during this
operation, so after the call we need to update the number in
our Python object otherwise every partition is -1 that we add.
commit f0cc56dad8962dd36158ba4f90d4bba1838e6e2c
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Feb 4 22:02:05 2009 -1000
Store PedPartition in _ped.Partition.
commit e9e7ee8db60c70288b702535987c3abd8c3774d4
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Feb 4 18:28:53 2009 -1000
Store PedDisk pointer in _ped.Disk object.
We need this to avoid needless conversions and to keep the
in-memory representation of the changed partition table.
commit 29750cd1377cbe03abdd9313c889d75f7b737be7
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Feb 4 14:19:31 2009 -1000
Ignore ctags files.
commit aedbe201ddaac222f5488b95325c748978fa79bb
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Feb 4 12:00:16 2009 -1000
Keep the part_list and flags from PedDisk.
We are losing information when we convert to and from a _ped_Disk
and PedDisk. We're using ped_disk_new(), which works fine to give
us the right struct, but we lose anything in memory that has not
been committed to the disk.
Save part_list, needs_clobber, and update_mode. The block_sizes
struct member of PedDisk is not used at all in libparted, so we
just ignore it.
commit 5f2a2e508782c944c17f407e010bcd5d6137792e
Author: Chris Lumens <clumens@redhat.com>
Date: Wed Feb 4 11:22:02 2009 -0500
Start keeping a list of things that are running really slowly.
commit 24899abb78d53d62833dea57334b860387b12708
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Feb 3 18:01:36 2009 -1000
Fix up _ped_Partition2PedPartition for addPartition()
We might be converting a new partition, so account for that at
the end of _ped_Partition2PedPartition.
Also, when adding a partition, make sure the PedDisk pointers
match, otherwise we get an assert from libparted.
Some small -Werror clean ups too.
commit 21abade6e06f438fc0a4204a1b79bc5d0a1b7c92
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Feb 3 15:03:41 2009 -1000
Correct last parameter to _ped.Partition()
It needs to be a _ped.FileSystemType, which we can get this way
in the parted module:
parted.fileSystemType[fs.type]
commit 97ed97ad09840037b321efcc0d1c76de0705373e
Author: Chris Lumens <clumens@redhat.com>
Date: Tue Feb 3 16:31:12 2009 -0500
getFreeSpaceRegions and getFreeSpacePartitions need to return a list.
commit 6813d3d433261fce735fb4c72bf67c876ccb5310
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Feb 3 10:58:19 2009 -1000
Fix parted.Partition.nextPartition() and converter function.
When using ped_disk_next_partition(), we iterate over every
PedPartition region on the disk. Three types of regions have
no partition number associated with them, the metadata, free
space, and protected regions. Still, we want to iterate over
them.
In nextPartition(), return None when we get to the end of the
partition list.
In _ped_Partition2PedPartition, get special partitions by
using ped_disk_next_partition(), checking the types, and then
comparing the geometry values.
commit aa91bc3fd4cffc582c24cc88beb4ec0a6194b661
Author: Chris Lumens <clumens@redhat.com>
Date: Tue Feb 3 15:03:40 2009 -0500
Added parted.Geometry.getSize, and make parted.Partition.getSize use it.
commit 626ad9caf7a29bb7a3f0dee770077a6214ecaedc
Author: Chris Lumens <clumens@redhat.com>
Date: Tue Feb 3 14:51:02 2009 -0500
If a partition isn't active (freespace, metadata, etc.) we can't get_flag.
This is yet another libparted assertion we need to catch before calling into a
libparted function.
commit d1addcfe61eaadd4f6b244d16c126a78239f840b
Author: Chris Lumens <clumens@redhat.com>
Date: Tue Feb 3 14:35:39 2009 -0500
Use a partition filtering function to reduce duplicated code.
commit 883328a362d1eac67e34f459cac75380b4dfad5f
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Feb 2 20:13:47 2009 -1000
Make sure nextPartition() returns a parted.Partition
Encapsulate the _ped.Partition as a parted.Partition.
commit dd644a8a5833957524e5e6647eed79e72a5c3504
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Feb 2 20:12:07 2009 -1000
Add getFirstPartition() to parted.Disk
This allows us to get the first partition in the partition list
for the Disk. We can then call nextPartition() on the Partition
object and iterate the partitions that way. This is the only
way in libparted to iterate partitions including
commit 11fd27fddaa131a8ad6b05f7b2c2656a86b13c17
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Feb 2 20:11:19 2009 -1000
If ped_disk_next_partition() returns NULL, return None in Python.
NULL means there is no next partition, so we can call that
None in Python.
commit 6c5023786f21173a96a177fedf7b1e979538307b
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Feb 2 19:09:48 2009 -1000
Three fixes to disk.py in the parted module.
1) Make sure we are refreshing the self._partitions list. If we
remove a partition, we should remove it from this list.
2) Add getFreeSpaceRegions() to return a list of Geometry objects
representing the free space on the disk.
3) Add getFreeSpacePartitions() to do the same as above, but return
a list of Partition objects.
commit 6d8556d57b94712ce86af26acfeddd6adb70bfed
Author: Chris Lumens <clumens@redhat.com>
Date: Mon Feb 2 10:50:03 2009 -0500
Convert from parted objects to _ped objects in constructors (dlehman).
We should try to make sure that all parted methods and constructors take parted
objects, and that when we call into the _ped module we pass the underlying _ped
objects in as arguments. Confused yet?
commit 4bee654778db19138ccf3954e01d1dfa40586505
Author: Chris Lumens <clumens@redhat.com>
Date: Fri Jan 30 13:24:44 2009 -0500
When we moved file_system_probe_specific to _ped, we never fixed the args.
In particular, it needs to take a FileSystemType object as a first parameter
instead of a self pointer.
commit 46d24d8fef832572a726b0a2bb38e3119111c578
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Jan 29 09:05:20 2009 -1000
Raise object-specific exceptions when necessary.
commit cfea3f000925abb58b641232917c3e4f93efa2c7
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Jan 29 09:04:36 2009 -1000
Add GeometryException for Geometry objects to raise.
commit 7322c437120b70e57560200078988d0baacfe6a0
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Jan 29 09:01:19 2009 -1000
_ped.device_get() raises a DeviceException now.
commit e569b6869127b5f09067811d6d0b47406bd30e22
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Jan 29 08:59:12 2009 -1000
Add _ped.DeviceException for _ped.Device and parted.Device
Add a DeviceException class for exceptions we want to raise
from a Device object.
commit cb0a2e8b433c581dfa00075b29ae839908b82eca
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Jan 29 08:52:49 2009 -1000
Raise a DiskException in parted.Disk.__init__() on syntax error.
commit f81aecb6da5bcc88ded86f82fe9067d3a189f3c0
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Jan 29 08:52:30 2009 -1000
Import all _ped exceptions in to parted namespace.
This is so we can refer to exceptions in either namespace.
commit f2fe580a05c398e1795b29c59cf0daf9c73d31ef
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Jan 29 07:22:45 2009 -1000
Changed Disk._partitions to a list.
Was storing this as a hash table with the key being the partition
number and the value being the parted.Partition. I thought that
would be a useful data structure, but in every instance that I've
been using Disk._partitions, I've only been using the values()
part, so change it to just a list of parted.Partition objects.
commit 9026b723bfe87bfaa6c188a084a86e4945f063b7
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Jan 28 19:29:22 2009 -1000
Handle fs_type as None when creating parted.Partition.
A Partition does not have to have a filesystem, so we'll use
None for those cases rather than throwing an exception.
commit 54524499e8062473b70566489bae5e58873adc05
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Jan 28 19:21:24 2009 -1000
Simplify _ped_Partition2PedPartition()
We had this all wrong. Make libparted do most of the work here.
commit 30c9bd2092c93d0e55633e45b548df56b2e7c2de
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Jan 28 19:14:19 2009 -1000
Fix _ped_Partition_init as well as PedPartition2_ped_Partition
1) In _ped_Partition_init we were creating a new partition, but
not adding it to the disk label. Added the code for that.
2) Partition numbers are always -1 because of our
PedPartition2_ped_Partition() function. We were building an
arg list and then calling _ped_Partition_init, which was
creating a new partition and adding it to the disk label. We
don't really want that to happen for the conversion function,
so revert the conversion function to just converting the
struct members manually. Partition numbers match up now.
3) Do not call ped_disk_destroy() except in our destroy function.
This is OS specific and causes the disk buffers to be flushed
and other things to happen. We want to free the struct, but
not cause anything to happen on the system. We might be
leaking memory now, but we can get to that later.
commit 1c9f8abec6e8f6fec658ff008cafa99676c3073d
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Jan 28 18:25:52 2009 -1000
Do not store PedDevice pointers in Python data structures.
We were doing this in order to prevent segfaults. I think this
is causing more problems now. Looking through libparted, we can
call ped_device_get() as many times as we want and it will give
us a pointer to the PedDevice in the device list that corresponds
to the path we give it. I've modified the code to work this way
and got rid of the 'ped_device' struct members for _ped_Device
and _ped_Geometry.
commit 9b5097449f00425050669f04c4121d2a7223eccd
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Jan 28 16:24:41 2009 -1000
Again with namespace problems.
We've imported every class in the parted module directly in to the
namespace of __init__, so change parted.Disk to Disk.
commit 173132074fb7e75d9ef0a8ae03a8764a57df2324
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Jan 28 12:58:00 2009 -1000
Move __maxLogicalPartitionCount inside getMaxLogicalPartitions()
commit 2da7867cf67e8662ed9e2c473e1e4a0a4b863236
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Jan 28 12:45:24 2009 -1000
In Disk.getMaxLogicalPartitions(), use self.supportsFeature()
Call self.supportsFeature(parted.DISK_TYPE_EXTENDED) rather than
the lowlevel check_feature() call.
commit da5d05e2f284f82cbdbd9f7facb722061a9b5166
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Jan 28 12:41:03 2009 -1000
disk.Disk -> parted.Disk
Typo.
commit 7967414a2e6db8a91d2784d6b0e64c29443c9019
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Jan 28 12:29:23 2009 -1000
Return None if there is no extended partition on the Disk.
commit d1e8d3c3e9d1022d7e85dc70566d35a1d8df86ff
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Jan 28 12:09:01 2009 -1000
Call _ped methods passing the correct types.
Need to pass _ped.Partition, _ped.Constraint, and _ped.Geometry
objects to the underlying _ped methods.
commit 43e8cf6e72055ed1b8b25931674368ad40755271
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Jan 28 10:54:21 2009 -1000
This is the constraint.py file.
commit b6370d3e97b534aecc18fc9e379485172e2714da
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Jan 28 10:31:12 2009 -1000
Allow start and end sectors for parted.Geometry init.
Allow users to specify start and end sectors and have __init__
compute the length of the geometry.
commit c2ff4542b59578add9e66e12b5780ec174ecc996
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Jan 27 21:07:24 2009 -1000
Add a device property to Disk.
commit 5662b436212af83804a692e8b44af1081f32af2c
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Jan 27 20:44:15 2009 -1000
Fix the getMaxAvailableSize() method on Partition.
Iterate over disk.partitions.values()
commit 48dd7bcb08fe1160a2c3928e6169c16f8e033887
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Jan 27 20:06:16 2009 -1000
Fix __init__ and attributes on parted.FileSystem
Fix the __init__ function so it worked correctly. Fix the
attributes to refer to correct values.
commit 8e949b585ec7cc40cfd785aa1c253a91d93df5d7
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Jan 27 20:04:53 2009 -1000
Create unsetFlag() to accompany setFlag(), typo fixes.
The setFlag() function was taking a flag and a boolean. Break this
out in to a setFlag() and unsetFlag() option rather than passing in
True or False to the setFlag() function.
Also fix some typos in this file.
commit 68e7a8aa6f15bf543db5837aaf4dcf6c5ebebe0d
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Jan 27 15:04:31 2009 -1000
Remove number property for Disk, fix type property.
The number property does not apply to a Disk.
Do not store self._type with the type name (key in diskType).
Modify the type property to return the self.__disk.type.name for
the getter. For the setter, set the self.__disk.type property
to parted.diskType[v].
commit 548277ed2bbae5c6e2c1aeb416fa5ecfebef0815
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Jan 27 15:00:30 2009 -1000
Increase flexibility of the parted.freshDisk() function.
Allow the type to be a key or value in diskType.
commit 410f6802e590bcfd6f103db401f407927c08b341
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Jan 27 14:59:54 2009 -1000
Do not require a type argument for parted.Disk.__init__()
We don't need type here, so stop allowing it and stop trying to
figure it out.
commit 6be0f0946fbd93588d39172f14dc8c0e00be95f2
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Jan 27 14:28:14 2009 -1000
Updated README file.
commit 29056b0fe69d32841ecab53a9159eb7207138916
Author: Chris Lumens <clumens@redhat.com>
Date: Tue Jan 27 17:44:55 2009 -0500
The .tp_init methods all expect a tuple, so provide it with one.
Py_BuildValue doesn't make a tuple unless you tell it to or pass it multiple
arguments. We'll just have to tell it to do so.
commit 5794635a59c1c58e02e4ddec7119c86eb981cd0b
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Jan 27 11:35:35 2009 -1000
Correct internal syntax in freshDisk()
commit 4fb8fc20ecf47e696eeb5cee60ac80dea0dd2cf8
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Jan 27 11:30:29 2009 -1000
Add parted.freshDisk() to expose _ped.disk_new_fresh()
commit efb3511c3400fa4fd50b7068f0789bbe017efac3
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Jan 27 11:25:23 2009 -1000
Add disk_new_fresh() to the _ped module.
Allow users to call _ped.disk_new_fresh(Device, DiskType) to create
a new Disk with the specified disk label type. Like libparted, the
new label is only in-memory. The user has to call commit_to_dev()
to write the label to disk.
commit de29dcac352bf9f9b8083048b3682570f5805ea4
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Jan 27 11:13:46 2009 -1000
Fix up _ped_Disk_init() and PedDisk2_ped_Disk()
Back when this function was first written, the thought was that
the user could optionally provide a disk type and we could then
call ped_disk_new_fresh() underneath to relabel the disk. The
problem is this causes our conversion functions to fail and gets
us in to difficult situations in the code.
A _ped.Disk() now can only be initialized with a _ped.Device as
the argument. ped_disk_new() is called.
commit 7cdc428fac762d37a2e8143c3ead0ba0229a56c2
Author: Chris Lumens <clumens@redhat.com>
Date: Tue Jan 27 11:19:55 2009 -0500
Add a supportsFeature method on parted.Disk.
This exposes the check_feature function for disk types but doesn't require
client code to know anything about disk types. I don't even want to know
anything about disk types and I'm working on this program.
commit 0ec113995c8368eca778b2c7295afd98cdaee5ea
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Jan 26 17:09:34 2009 -1000
Fix incorrect error string.
commit 742d48e212a0598bb1f5b8f4f442c533f8217b1a
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Jan 26 17:09:09 2009 -1000
Add name attribute to parted.Partition
This attribute is read-only and a pass-through to the
py_ped_partition_get_name() function.
commit 3801904c0844d86496ba82f9dc7ac941d222bcfc
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Jan 26 17:08:48 2009 -1000
Removed unnecessary from/import line.
commit 82848b88aa6cb376c3390505c1787fcdf712b9e2
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Jan 26 16:46:13 2009 -1000
Add isFlagAvailable() and nextPartition() methods.
The Partition object needed these methods.
commit c11601cf361cdce61a728a574503f7bbc8c4ce1f
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Jan 26 16:14:52 2009 -1000
Create a parted.Geometry from self.__fileSystem.geom
commit 5bc8c48a892a38b4dcf06afd1a76f684e45a18ac
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Jan 26 16:14:34 2009 -1000
Create parted.FileSystem when init'ed with PedPartition
commit aaa56b13ec38d2adea5dc03715161238019ed923
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Jan 26 16:00:13 2009 -1000
Revert "In _ped_Disk_init(), honor optional type argument first."
This reverts commit e008e19d5a5dc2efdecd940b8c16ac127caee7aa.
commit e008e19d5a5dc2efdecd940b8c16ac127caee7aa
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Jan 26 15:45:02 2009 -1000
In _ped_Disk_init(), honor optional type argument first.
If the caller gives us a type argument, honor that before
probing for the disk type.
commit efa1428343cbcae3ce8c2139ad1fd4949d834490
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Jan 26 15:43:56 2009 -1000
Add getPartitionByName()
Replaces partedUtils.get_partition_by_name() in anaconda.
commit ac8742bf1e789ff54545252e0d9c48c8aae8a3f3
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Jan 26 14:49:17 2009 -1000
Allow callers to pass True/False to setFlag() on Partition
In Python, we have a real boolean type. Make sure we translate
it to ints when calling the lowlevel libparted code.
commit bd0ad3747f1428ff42d3c21a5d27414b0ffabdb1
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Jan 26 14:48:37 2009 -1000
Add more functions from partedUtils.py in anaconda
Bring over:
getLogicalPartitions()
getPrimaryPartitions()
getRaidPartitions()
getLVMPartitions()
commit 18e2c5e0233f06fe9bd13e6797590e6c0ec6d3fe
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Jan 26 14:14:37 2009 -1000
Cleared out these two bugs.
commit 34c9fd835e4cd1df3be7566713453a9483ea6c99
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Jan 26 14:13:02 2009 -1000
Pass geom as the PedGeometry parameter.
Syntax error:
return geometry.Geometry(geom)
to:
return geometry.Geometry(PedGeometry=geom)
commit 433215e89020f20e63dac7573d0ba9a80d7bcfd3
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Jan 26 14:11:29 2009 -1000
Make partitions a read-only property on parted.Disk
Initializing this hash table in __init__ was causing recursive
indefinite looping. Whenever a Disk was created, it would go
and create the hash again.
Make partitions a property. On the first access, init
self._partitions with the hash table.
commit d2ed591d6c158c033da845b1ad88783a978eff1d
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Jan 26 13:57:27 2009 -1000
Make all parameters have default values.
In order to initialize a parted.Geometry with just a PedGeometry,
all of the other parameters should have a default (that is, be
optional).
Fix a namespace issue (Device -> parted.Device).
commit ce4988d1dca3a579cc3f6886211ae42bbde4a8d1
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Jan 26 13:16:29 2009 -1000
Let the Partition parameter on next_partition() be optional.
Syncing up with the functionality of libparted. The next_partition()
parameter can take NULL and just return the head of the list.
commit effe6ae299aabd449525ba5ab421bc006586ff85
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Jan 26 12:54:59 2009 -1000
If Py_BuildValue() returns NULL, return to caller.
Per Chris' recommendation. If Py_BuildValue() returns NULL, we
should return NULL immediately so we can catch exceptions that
may have been raised and avoid segfaults.
commit 9debe17a89cbe5715544f37d40af28521334a51f
Author: Chris Lumens <clumens@redhat.com>
Date: Mon Jan 26 16:28:16 2009 -0500
The fs_type on a partition can be NULL, so don't pack that into a tuple.
We also need handle errors from Py_BuildValue by returning NULL so exceptions
get propagated up. That's easier to handle than random segfaults.
commit 3ca036dba7b2f62b8764ae3876ffa9197cda1a99
Author: Chris Lumens <clumens@redhat.com>
Date: Mon Jan 26 16:00:07 2009 -0500
We really shouldn't ever be calling free on a PyObject.
commit e58984bbb8b6fadabd36d4f4fc5a5dca6b538918
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Jan 26 10:34:44 2009 -1000
New bugs.
commit fd532b9c928d89cb28ef72e542ce402d334219b4
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Jan 26 10:27:32 2009 -1000
Add parted.Partition.getDeviceNodeName()
Previously implemented in anaconda in partedUtils.py as
get_partition_name().
commit ac5c61e2d619e82e0342ef84cdeedfc45bd9924e
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Jan 26 10:26:58 2009 -1000
Add archLabels hash table.
From anaconda's partedUtils.py file. A hash table listing valid
disk labels for each architecture.
commit e30479fda00638581a9ddb076bb64a976be8033c
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Jan 26 10:26:10 2009 -1000
Do not call ped_partition_destroy() unless we are destroying.
The ped_partition_destroy() function is named poorly. It actually
calls the label-specific function to destroy the partition on the
disk. We don't want that.
commit 7cea44689161ba7044ed18844581da0ae56ffda9
Author: Chris Lumens <clumens@redhat.com>
Date: Mon Jan 26 15:04:50 2009 -0500
Fix the geometry read and write test cases.
These were only failing because I didn't understand how the methods were
supposed to work. If you try to write more bytes than the buffer contains,
it'll only write the contents of the buffer once. It doesn't copy the
buffer over and over again into the geometry to meet the byte request.
commit aab2b98f1a5e552a9e7610f35aea687a73c8db33
Author: Chris Lumens <clumens@redhat.com>
Date: Mon Jan 26 14:58:34 2009 -0500
Fix a typo in FileSystemTypeGetSetTestCase.
commit 77d674028b7b16f8011118aa8d76bac4ea4f10ce
Author: Chris Lumens <clumens@redhat.com>
Date: Mon Jan 26 14:56:37 2009 -0500
Fix ConstraintDuplicateTestCase.
If an alignment has a non-zero grain_size, libparted sets the offset to be
|offset % grain_size|. Since this is a copy test, we need to set grain_size
to be 0 in order to not have to deal with this little quirk.
commit f7936ff4ac096523412fcb5702d5481033e81511
Author: Chris Lumens <clumens@redhat.com>
Date: Mon Jan 26 12:00:00 2009 -0500
Fix order of parameter passing when building the _ped.Partition arg tuple.
The order of the arguments to _ped.Partition.__init__ changed because the
filesystem type argument is no longer required. I changed the order everywhere
except for this place, it looks like.
commit 9b3420af52fbf19ce7d6c3dc518e56a94fc739e8
Author: Chris Lumens <clumens@redhat.com>
Date: Mon Jan 26 10:27:07 2009 -0500
The flag_get_next, flag_get, and flag_get_by_name methods have changed names.
In the future, we should always check that we update the test suite at the same
time as we are changing the names or locations of methods.
commit 27302a44e120a91493658e53358619c8dca8e9fc
Author: David Cantrell <dcantrell@redhat.com>
Date: Sat Jan 24 23:29:02 2009 -1000
Allow type as optional argument to parted.Disk.__init__
If the caller does not provide a type, probe for it.
commit 43227749f8569347167c1026fd2280feb18fa250
Author: David Cantrell <dcantrell@redhat.com>
Date: Sat Jan 24 14:55:54 2009 -1000
getAllDisks() renamed to getAllDevices()
This method was named poorly. It returns a list of all Devices
in the system. Additionally, it was returning a list of
_ped.Device objects, so make sure it's now returning a list of
parted.Device objects.
commit 2264e16c0f6b11fe95c392f571d0246fe5ce3ef0
Author: David Cantrell <dcantrell@redhat.com>
Date: Sat Jan 24 14:28:19 2009 -1000
Handle PedPartition initializer for parted.Partition
If we initialize a parted.Partition using a PedPartition, be sure
to make self._disk a parted.Disk and self._geometry a
parted.Geometry. Just pulling the values from the PedPartition
gives us _ped types, which we don't want at this level.
commit e1a33cbd6fb691a659579eb7dd5047cc21e65f81
Author: David Cantrell <dcantrell@redhat.com>
Date: Sat Jan 24 14:27:57 2009 -1000
Note the _ped.Disk.get_partition() method failure.
commit 6d00f672a8f21550d9e55fefa8fc5d9638554950
Author: David Cantrell <dcantrell@redhat.com>
Date: Sat Jan 24 11:05:14 2009 -1000
Add getMaxLogicalPartitions() method to parted.Disk
Taken from partedUtils.py in anaconda. Returns the maximum number
of logical partitions allowed based on the device type.
commit f6e9f8808ded0ad69399c668dc01dc99aba9cbd0
Author: David Cantrell <dcantrell@redhat.com>
Date: Sat Jan 24 10:54:49 2009 -1000
Add getMaxAvailableSize() method to parted.Partition
Taken from partedUtils.py in anaconda, this method looks at
partitions that come after this partition (self) and add up the
ones that are marked as freespace to tell the caller the max
size this partition can grow to.
commit 882840d56cf90b038027487332eaaa40fec7fd60
Author: David Cantrell <dcantrell@redhat.com>
Date: Sat Jan 24 10:36:47 2009 -1000
Install parted module to arch site-packages dir.
The _pedmodule.so module is installed to either /usr/lib or
/usr/lib64. While the Python code is not arch-specific, I think
it still makes sense to group the parted module together with the
_ped module and keep them either in /usr/lib (for 32-bit arches)
and /usr/lib64 (for 64-bit arches).
commit e7eb377f3aef26ebe0a97ab072b06b2155ef9643
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Jan 23 22:35:47 2009 -1000
Install parted Python module via automake rules.
commit 3ce4c3ef23ca1741ade21d3a50bc663f33190dc5
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Jan 23 22:24:27 2009 -1000
Ignore py-compile script.
commit 340d8ac1b0e0ba8f57897cc2cf1c56890874b579
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Jan 23 21:55:30 2009 -1000
Update Makefile.am to include docs and more targets
Need to include the other docs and add targets to generate
the ChangeLog and to clear out things we don't want in dist
archives.
commit 426e5105604359910cd05b9bf2c2c5ac673eaf9a
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Jan 23 18:01:51 2009 -1000
Include exceptions.h in the release tarball.
commit 1ae37e3f5d803c202245f028925ac6c307f57922
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Jan 23 17:49:01 2009 -1000
Seriously, we forgot to import what we're writing?
commit 1d6f65a0d09306213500efc32f495d40542d759b
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Jan 23 17:48:28 2009 -1000
import math
Need the math module here.
commit a76334c19340bd784cd5bfa693649dde0dab74bd
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Jan 23 17:47:31 2009 -1000
__exponent -> _exponent
pychecker caught this. I was trying to make the hash too
hidden.
commit 678309fc7b27bf28009d68cbea9681c5434ec553
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Jan 23 17:46:20 2009 -1000
floor -> math.floor
pychecker caught this.
commit 7d822e3c470a88e095edefa1d54246674e1ff678
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Jan 23 14:38:01 2009 -1000
Modify getSize() in Partition to use global __exponent hash.
commit b584d61952778dd821104969a2bde68f21d8dcc6
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Jan 23 14:36:38 2009 -1000
Make the device property on parted.Geometry give parted.Device
The Geometry class had a getPedDevice() method to return the
lowlevel _ped.Device object associated with this Geometry.
However, at the higher level code, we want to deal with
parted.Device as much as possible.
Make the 'device' attribute on parted.Geometry return a
parted.Device version of the internal _ped.Device.
commit 8e60c3405a3de09e0a10a0727ce7c2c09eb1d4f2
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Jan 23 14:36:01 2009 -1000
Fix some __init__ problems in parted.Disk
This object is still giving me some errors, but I'm committing
what I have for now.
commit fbff8a39e2ebd1053bb5d5d44338909d93842e06
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Jan 23 14:34:30 2009 -1000
Fix __init__ to accept right parameters, add getSize()
The __init__() methods takes either a path to a device on the
filesystem or an existing _ped.Device object. Removed the device
parameter, since it didn't make sense.
Added the getSize() method to convert the size of the Device,
which is internally stored as a number of sectors, to a value
suitable for display to the user. The conversion function
defaults to megabytes, but you can pick your unit from bytes
up to terabytes.
commit 3a12ff1037b74a3b11f01fc6ef637fca16d27702
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Jan 23 14:33:02 2009 -1000
Import all objects, rename getDisk() to getDevice()
Fill out __all__ and make sure we import everything in to the same
namespace.
The getDisk() method was a bit of a misnomer. It gives you a
parted.Device, so rename it to getDevice().
I've added some getSize() methods to Partition and Device objects,
which work sort of the same way. Put the exponents hash at the top
level to share it between those methods.
commit 1339448516c86da64afe6acc3a5b013e70402b93
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Jan 23 14:32:38 2009 -1000
PedPartitionType is an enum, so store it as an int.
commit 9d86023f5a65cb41741f29fe8e6b0057e1f89a57
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Jan 23 12:35:06 2009 -1000
convertion -> converting
Speling error.
commit 6c030b0d6832804e3b8475a14adf6783fa576afd
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Jan 23 12:27:27 2009 -1000
Return boolean types more safely.
See commit 0383379fc77b90cfdb3df1f71b3c2888c7a791c5 for more
details.
commit 927c1f3ad7ea2b72822b3fc8dfec2f82a2628328
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Jan 23 12:23:30 2009 -1000
Return a string representation of this partitions flags.
Walk the list of partition flags and if a flag applies to our
partition, add its string name to a list of flags. After walking
the list, return the string representations as a comma-separated
list.
commit 0383379fc77b90cfdb3df1f71b3c2888c7a791c5
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Jan 23 12:21:51 2009 -1000
Use 'int' for partition flag, return booleans more safely.
Make sure that pydisk.c uses the int type for all instances of
partition flags.
Rather than using PyBool_FromLong() to convert an int to a boolean
in Python, just test the return value in C and use either the
Py_RETURN_TRUE or Py_RETURN_FALSE macro. We've hit some size
problems on 32-bit vs. 64-bit platforms when moving between ints
and longs, so be safer about returning a boolean value.
commit 7f662910e31a4e0d39fd82ce39e8d5ad1019fb43
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Jan 23 12:03:03 2009 -1000
Create a partitionFlag hash under parted.partition
The partitionFlag hash holds a mapping of partition flag values
to string representations. Done so we don't have to call the
get next nonsense over and over at runtime.
commit 7c2c5325a28e226a946e5fbe8b8322026d965199
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Jan 23 11:56:07 2009 -1000
Treat partition flag values as int consistently.
We were reading an int and storing it in a long variable, so we
never could look up a partition flag name.
commit bfbb6222c193cb638efbe033873ecc1dcd15cc70
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Jan 23 11:44:22 2009 -1000
Prefix the partition flag functions with partition_
Keeping consistent with the other _ped toplevel functions, prefix
the partition flag functions with partition_
commit 6ca5a09e6c3f62cc69998e8e4367b468fdcf79d4
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Jan 23 11:10:17 2009 -1000
Add getSize() method to parted.Partition
The getSize() method will return the size of the partition in a
unit suitable for human consumption. Internally, parted deals
with sectors for the partition length, so we have to convert that
to something suitable for display. partedUtils.py had a
getPartSizeMB() function to convert the length to megabytes. This
new getSize() method defaults to megabytes, but can also handle
bytes through terabytes. Adding new size conversions should be
easy too.
commit 1df1e12c5b970913910c7137f6fea9e862f30890
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Jan 23 11:09:35 2009 -1000
Bring over cylinder<->sector conversion functions.
These functions lived in partedUtils.py in anaconda prior to
becoming methods on the parted.Device object.
commit c381b769f0e7d1cf623bfb32fc2de7840cd40e3d
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Jan 23 10:32:35 2009 -1000
Started the fdisk.py command
Started the fdisk.py command, which aims to be a more or less
compatible replacement for /sbin/fdisk that uses the pyparted
module and is written in Python. We may not be able to do
everything that fdisk can do, but the point of this program is
to exercise the pyparted module.
commit ee2e0e65eefbe9acc5287d9d302222ef96d4e01e
Author: Chris Lumens <clumens@redhat.com>
Date: Fri Jan 23 17:05:04 2009 -0500
Remove the _register and _unregister methods.
pyparted is the wrong place to be adding support for new disk labels and
filesystems.
commit 996d9292b08cd54c277619f8777c81213f97fab9
Author: Chris Lumens <clumens@redhat.com>
Date: Fri Jan 23 10:01:42 2009 -0500
Add basic test cases for _ped.FileSystemType.
Do we want to add test cases for the _register and _unregister methods?
Do we even want these in pyparted?
commit 8ba8fcb7d920af238bdf2c54cac7736ccf282269
Author: Chris Lumens <clumens@redhat.com>
Date: Fri Jan 23 09:47:42 2009 -0500
Finish the test cases for CHSGeometry.
commit cc4205e7902859934c22e5d446b77525e2e7abbd
Author: Chris Lumens <clumens@redhat.com>
Date: Thu Jan 22 17:36:54 2009 -0500
Add stub test cases for every method that didn't already have one.
commit 06598679fcb9d542e96ecb4d5876f502ad88e782
Author: Chris Lumens <clumens@redhat.com>
Date: Thu Jan 22 16:55:49 2009 -0500
More simple test cases for _ped.Partition.
commit ce19a5d5bfcd2d021959448d5fbb4fb4f7a06f49
Author: Chris Lumens <clumens@redhat.com>
Date: Thu Jan 22 16:55:12 2009 -0500
Catch a lot of assertions before they happen in _ped.Partition.
commit e32ff4d5f1bbd496136c3927d08a23c915732933
Author: Chris Lumens <clumens@redhat.com>
Date: Thu Jan 22 16:38:17 2009 -0500
You can't call free on a PyObject. That just doesn't make sense.
commit af5c76e78775a9f29c7ed9db38e9120ac1bdc001
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Jan 21 08:11:04 2009 -1000
Make some PyMemberDef members read-only.
Set the READONLY flag for PyMemberDef struct members that need to
be read-only.
commit e5bcf30fce3c409d0e9c11573c7436d28f936c20
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Jan 21 04:29:58 2009 -1000
In __init__ methods for _ped objects, handle kwds=NULL
We may call the __init__ with no keywords, so handle object init
with the keywords set to NULL. Basically we just use PyArg_ParseTuple
and read parameters in the same order.
commit bc63f343547226463df57e7a37eafab3ec4cb25d
Author: Chris Lumens <clumens@redhat.com>
Date: Wed Jan 21 15:30:23 2009 -0500
Add the beginnings of the _ped.Partition test cases.
commit a3e06fb21a7acfbbe7881254ecc4ad5fa277bb27
Author: Chris Lumens <clumens@redhat.com>
Date: Wed Jan 21 15:21:21 2009 -0500
Add base test classes for partitions and mounted filesystems.
commit 008eb5e9de4b25aca2e4cbd27e03d86100ab38b3
Author: Chris Lumens <clumens@redhat.com>
Date: Wed Jan 21 15:19:04 2009 -0500
Support having a filesystem type of None on Partition objects.
If a _ped.Partition object has a type of PARTITION_FREESPACE or
PARTITION_METADATA, it must not have an associated filesystem type.
Otherwise, you'll get strange assertions when checking if a partition is
active. Now I just need to modify everywhere else we support optional
arguments to make sure they get set to a default.
commit a3b55dc39b5ad9e9010ece7d947808a69874292e
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Jan 21 03:21:33 2009 -1000
Fix PyArg argument processing for 32-bit architectures.
This was a fun one to track down. After figuring out the code that
was failing on my i386 devel box (but works on clumens' x86_64 box),
I looked further and saw that our PedSector values were getting lost
by the time we hit the next function.
Anything that gets converted down to a PedSector needs to be treated
as a long long int. We were converting those using "l" in the PyArg
parsing functions, which is just long int. We need to use "L" to
make sure it always uses long long int.
For enum values, I changed those from long int to int. enum values
are strange and we can probably leave them as long ints, but I want
to be specific and consistent across the code base.
commit b28164d7bb0eeff90f26af2cf2acab61f0972013
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Jan 21 03:16:09 2009 -1000
Support keywords or no keywords in init, read PedSector as long long.
In _ped_Geometry_init(), rewrite the function to support cases where
there are no keywords provided. For those instances, we want to
use PyArg_ParseTuple(). If there are keywords, we want to call
PyArg_ParseTupleAndKeywords().
For all instances where we are reading in a long long int using a
PyArg parsing function, use "L" for the format string. We were
using "l", which leads to problems on 32-bit architectures. All
PedSector values are long long ints and need the "L" conversion.
commit f44a4d7c1de69377f2d4f22c388176f856b7db1a
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Jan 21 01:07:39 2009 -1000
Update README.
I am no longer the GNU parted maintainer.
commit e55fe762a74ffe22db2397e9480d87009a7d30f4
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Jan 20 05:25:04 2009 -1000
Do not override the current exception when calling tp_init
If tp_init fails, we should already have an exception. There's no
reason to drive over it with an exception that says we couldn't what
was just tried. We already know that. We need the exception that
caused the tp_init call to fail.
commit 5b41aab29729a00d3fb6218af24838dd8a9ca8b9
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Jan 19 09:07:52 2009 -1000
docstrings for parted.Disk
commit ba5ca3f5b4c8e612d836cbc9846b276586d1e2bc
Author: Chris Lumens <clumens@redhat.com>
Date: Wed Jan 21 13:01:38 2009 -0500
After calling ped_disk_new_fresh, flush the changes to the device.
This is needed because _ped.Disk.commit_to_dev ends up calling into
_ped_Disk2PedDisk, which then calls ped_disk_new, which will fail because
there's still no disk label.
commit 7a394056a9a2e6734b627d612c31f1f52b82af1d
Author: Chris Lumens <clumens@redhat.com>
Date: Tue Jan 20 15:16:48 2009 -0500
In _ped_Disk_init, only call ped_disk_new if there's a label.
If we are creating a new disk that has no label, we'll never get around to
calling ped_disk_new_fresh and so there will never end up being a disk label.
Instead, we need to probe for a label and if there isn't one present, add one.
commit 50e62471f8113e5e2cfe9aba33578c979220a0ee
Author: Chris Lumens <clumens@redhat.com>
Date: Mon Jan 19 15:23:19 2009 -0500
Add test cases for most of the methods on _ped.Device.
commit 52c65b33fa3d9d8565f59bfcc8d4987f1a533660
Author: Chris Lumens <clumens@redhat.com>
Date: Mon Jan 19 15:22:57 2009 -0500
Add another test class for tests requiring a filesystem mounted.
commit 3134333cc6817efd632e8676f975e9cba6d3adf8
Author: Chris Lumens <clumens@redhat.com>
Date: Mon Jan 19 15:19:26 2009 -0500
Add checks for libparted assertions.
libparted will just raise C assertions for a variety of reasons. However,
the assertions are outside the usual exception handling mechanisms so we
can't do anything useful when they occur. So we need to duplicate the
libparted checks and raise exceptions before calling into libparted.
commit fe7a5b0ba7038289b4106c2dd899b9d7621b1714
Author: Chris Lumens <clumens@redhat.com>
Date: Mon Jan 19 14:47:52 2009 -0500
Copy open_count and external_mode back to the _ped.Device object.
The open/close and begin/end_external_access functions have side effects.
Namely, they modify the open_count and external_mode variables. In order for
pyparted to know what's going on, we need to copy these modified values back
into our _ped.Device object.
commit 0d7c8eeb9cca65dac63f0c8034e33bb8a1ea2155
Author: Chris Lumens <clumens@redhat.com>
Date: Mon Jan 19 13:18:18 2009 -0500
Add test cases for the last of the constraint constructors in _ped.
commit 7f2a2c384bbb817d4323c193ff0b021017ff95a8
Author: Chris Lumens <clumens@redhat.com>
Date: Mon Jan 19 13:16:43 2009 -0500
Enforce the assertion that the min geom must be within the max geom.
commit 2c0f7e6019b8e88d6f616f305042afe8b7c82670
Author: Chris Lumens <clumens@redhat.com>
Date: Fri Jan 16 13:55:57 2009 -0500
Set all other PyObject pointers to NULL when parsing arguments fails.
commit f58c10e45943fe68bc355f302b074923ac46e413
Author: Chris Lumens <clumens@redhat.com>
Date: Fri Jan 16 13:50:30 2009 -0500
Recover from type errors on processing args in _ped.Constraint.__init__.
If arguments are provided to the _ped.Constraint.__init__ method in the wrong
order such that the types don't line up properly, memory will get scribbled
over and you'll get random segfaults. PyArg_ParseTupleAndKeywords appears to
work from left to right doing arguments as they come, instead of validating
types first and then doing assignments.
So, we need to set things back to NULL on error.
commit 8cb83d003e1f8df04c8981c1b7ead6d83e9aa6ae
Author: Chris Lumens <clumens@redhat.com>
Date: Fri Jan 16 13:39:31 2009 -0500
Add a test for wrong parameter order to _ped.Geometry.__init__.
This is causing segfaults in _ped.Constraint.__init__, so add the test case
to Geometry as well to make sure it works there.
commit 3f90dc6f10bdc08caa7b617d9b428ae99cf5c86b
Author: Chris Lumens <clumens@redhat.com>
Date: Fri Jan 16 13:37:05 2009 -0500
Add all the easy test cases for _ped.Constraint.
commit e186c33fa9dbe16d0c5baa10c77478cf8215d286
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Jan 16 01:22:21 2009 -1000
We are the only authors of this pyparted iteration.
commit 56c59dc83100d1657943f320062cda103c20c43b
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Jan 16 01:20:15 2009 -1000
Updated to do list.
commit 3ed9fdfd87020a917bfcb34b3c6b76bf4f9cc133
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Jan 16 01:18:01 2009 -1000
Remove py_ped_geometry_destroy()
Similar to _ped.Alignment, users can just call 'del' in Python on
the object and garbage collection will take over. Remove the
destroy() method.
Also remove the test case for _ped.Geometry.destroy()
commit dbac632202d6fca43bb90708855c85e220ea5480
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Jan 16 01:17:25 2009 -1000
Remove py_ped_constraint_destroy()
Similar to _ped.Alignment, users can just call 'del' in Python on
the object and garbage collection will take over. Remove the
destroy() method.
commit efb83935cb40a8be5eae2db87d1cda5ef610c576
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Jan 16 01:15:39 2009 -1000
Make notes about the device, disk, and partition destroy methods.
Leaving these alone for now, but they most likely segfault. Will
investigate later.
commit 397fb0a2ee937012077ec634ff4de78b46e6aa41
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Jan 15 07:27:33 2009 -1000
filesystem -> fileSystem
Use Python-like naming for parted properties. Drop a comment in to
record brain state so I can stop coding for now.
commit ea3643fdbd95ab225e8dad4118e0b14bbab3e2c1
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Jan 15 07:11:50 2009 -1000
grainSize -> grain_size
We use C-style naming in _ped and Python-style naming in parted.
commit 03f9626f470cfb6ded863f7eb4ef84230e9446f0
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Jan 15 07:09:54 2009 -1000
Remove _ped_FileSystemType_set and _ped_FileSystem_set
You cannot set attributes on _ped.FileSystem or _ped.FileSystemType, so
remove the functionality.
commit 67aa645969f91dfc92666a182d7030d269ade0d9
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Jan 15 07:06:58 2009 -1000
Remove _ped_DiskType_set
You cannot set attributes on a _ped.DiskType, so remove the code that
does that.
commit 07143ebcb3cd712c5739c5a1d3a76462998cbbae
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Jan 15 07:01:58 2009 -1000
Make properties on parted.Device read-only.
commit 452030716c2d5cfa16166e3151475c67b4c5a7b1
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Jan 15 06:59:48 2009 -1000
Remove _ped_Device_set
None of the attributes on _ped.Device can be set, so remove the
function that handles that.
commit 1b18f1e33b88420861e855e488bf7ef1157563f7
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Jan 15 06:20:25 2009 -1000
Remove AlignmentDestroyTestCase
The py_ped_alignment_destroy() function is gone, so remove the
associated test case.
commit 75ed3c40692ee9382d71b6d76b388b0f67d73aef
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Jan 15 06:17:47 2009 -1000
Add CHS geometry attributes to parted.Device
Allow users to read the hardwareGeometry and biosGeometry attributes
on the parted.Device object. The attribute returns a 3-tuple in
the order of cylinders, heads, and sectors.
commit a534ff79f473178505627c4b394e2d014d26d688
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Jan 15 06:13:47 2009 -1000
Removed _ped_CHSGeometry_set
The attributes on a _ped.CHSGeometry cannot be set by the user, they
are read-only. Removed the set function and all capability for users
to set those values.
commit 75d094c83273bccfb74b956f2a273355c64589f4
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Jan 15 06:11:16 2009 -1000
Use Python-style naming for properties in the parted module.
min_size -> minSize
max_size -> maxSize
commit ab84adeba1062effc1882e68850e1859dc358b1b
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Jan 15 05:46:36 2009 -1000
Remove py_ped_alignment_destroy, it's pointless.
By supporting garbage collection, the py_ped_alignment_destroy
function is pointless. Destroying a PedAlignment in libparted just
frees the struct, so our method on _ped.Alignment just reaps the
Python object.
There's really no point to this method since we have 'del' in
Python to trigger this functionality.
commit ace7608105fd68187dcd758aa64930540d0aea75
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Jan 15 04:17:37 2009 -1000
Removed DESIGN file.
From a brainstorming session, we no longer need this.
commit 06bf6c4c935dab7d089cdc6e80efd8ab54988c41
Author: Chris Lumens <clumens@redhat.com>
Date: Thu Jan 15 16:40:53 2009 -0500
Add more test cases for the _ped module.
This includes a new base test case class - BuildList - that can be useful
for testing all those stupid _get_next methods.
commit 82d112be3f698cf8025327eb209445e7576b1bfe
Author: Chris Lumens <clumens@redhat.com>
Date: Thu Jan 15 14:17:19 2009 -0500
Fix up another round of stupid pychecker errors.
commit f6a8b67662b2fd0f777e07f609a8e615850f7687
Author: Chris Lumens <clumens@redhat.com>
Date: Thu Jan 15 14:14:04 2009 -0500
Fix a segfault in PyArg_ParseTuple caused by not passing in a double pointer.
commit 84dab60f2b6c7f1583b449109202d5b56f038f88
Author: Chris Lumens <clumens@redhat.com>
Date: Thu Jan 15 14:03:38 2009 -0500
Let __init__ methods for each class accept either a low-level _ped type or all
of the high-level parted objects that could be used to create the _ped type.
commit 8b0d9b4983d6ed15d745f54e0a9026e2a7051775
Author: Chris Lumens <clumens@redhat.com>
Date: Thu Jan 15 14:02:49 2009 -0500
Fix a couple more s. -> self. typos.
commit 186756fd91d39656a435eaa5b949d46eb9416e80
Author: Chris Lumens <clumens@redhat.com>
Date: Thu Jan 15 13:56:06 2009 -0500
Create getPed_____() methods to return the low-level _ped type contained
within the high-level object.
commit 7de64eecda02ba813fa4409b8a142f214b59269f
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Jan 15 03:53:09 2009 -1000
Yes, there is more to do.
commit 6d340b29488a1aef7f48b30122b6f99285254525
Author: Chris Lumens <clumens@redhat.com>
Date: Thu Jan 15 13:44:22 2009 -0500
Add the parted.Alignment class.
commit 2fad5c41276b9a06ec6776788d5b437c41927fca
Author: Chris Lumens <clumens@redhat.com>
Date: Thu Jan 15 11:05:22 2009 -0500
Fix errors found by pychecker.
commit cdd17c32a3ddf3ed7c569d4478bcd150505ed22b
Author: Chris Lumens <clumens@redhat.com>
Date: Thu Jan 15 11:05:01 2009 -0500
Allow passing command line arguments to pychecker.
commit 03db3a6d977261915535745858a697417ba70dc9
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Jan 15 03:27:31 2009 -1000
Put get_create_constraint() and get_copy_constraint() on _ped.Device.
Put the get_create_constraint() and get_copy_constraint() as
methods on the _ped.Device object. We originally had these as methods
on _ped.FileSystem because they are functions in filesys.c in
libparted. However, looking at the code in libparted, you can tell
it's more obvious that the action is on a specific device, not a
specific filesystem.
The code for these methods still lives in pyfilesys.c to keep it
consistent with the libparted code, but the methods in Python live
on the _ped.Device class.
commit 643c09a0ab85a9d688db4c93f22c5564723a56f3
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Jan 15 01:53:39 2009 -1000
Add parted.FileSystem class.
This one will need some more work, but the framework is there.
NOTE: The probe and probe_specific functions in libparted exist
at the parted level rather than being methods on a FileSystem.
Additionally, the get_create_constraint and get_copy_constraint
functions in libparted are more closely related to a Device than
a FileSystem, so they exist as methods on a Device.
commit 6f3714f62db09cd42bdedd1ad249d6cbfabe1768
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Jan 15 01:48:42 2009 -1000
Add parted.probeForSpecificFileSystem and parted.probeFileSystem
commit bc815d5b16fac9fbda1f1bddb797182daf10fc19
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Jan 15 01:44:12 2009 -1000
Add getPedGeometry() method to parted.Geometry
This method returns the _ped.Geometry object in the class.
commit 10c76ffb4d722f13fb41195c6b9a837fdedd604c
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Jan 14 08:33:02 2009 -1000
Support calling py_ped_file_system_type_get_next() from _ped.
Allow users to pass nothing in to get the first file system type,
or to specify an existing file system type to get the next in the
list.
commit 1ddbc7a4f016036b786bb512236447905d17c068
Author: Chris Lumens <clumens@redhat.com>
Date: Wed Jan 14 16:11:03 2009 -0500
Add a pychecker make target that's callable from the top level.
Also, remove all the *.pyc files on maintainer-clean.
commit 030b797b1e1f214fc10e94205b811eecb7aa897b
Author: Chris Lumens <clumens@redhat.com>
Date: Wed Jan 14 15:57:04 2009 -0500
Add the src/parted directory to the makefiles.
Among other things, this makes sure it gets picked up by 'make dist'. In
the near future, it'll also mean we have the Makefile framework in place to
add a 'make pycheck' target.
commit 74d8daebe0e27715d3a5bc4a1f589b015b828797
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Jan 14 08:22:30 2009 -1000
Move FileSystemType get functions to _ped
Similar to the DiskType get functions commit from yesterday. We
need these to live outside of the FileSystemType object.
commit bedafbebccd49b38880d6b5f78c4e678bc515eff
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Jan 14 08:13:44 2009 -1000
Removed test script since we have localtest.
commit b6d9e1de3312af4aa7aa303bff5370ee94717f5f
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Jan 14 08:08:19 2009 -1000
Support instantiating parted.Partition with _ped.Partition.
For internal module use, we may want to instantiate a
parted.Partition with just a _ped.Partition. You can do that
with the PedPartition= named parameter.
commit a8d8ff2027dab9151e04a09c08208b66bb3feffa
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Jan 14 07:47:25 2009 -1000
prop -> property
Consistency, but pointless.
commit 5b767330af8c1a2d5e70aceb5e1f80a6ebe6a37f
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Jan 14 07:44:06 2009 -1000
Consistently name the __readOnly() method in our classes.
We are using properties and have a method to raise an exception if
someone tries to write to a read-only property. Purely for code
consistently, make sure this method is named the same in all of our
classes.
commit 3f9d14872037e3c16378fa1de0144618f03229f2
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Jan 14 07:31:01 2009 -1000
Make some variables private and super private in disk.py.
The device and type passed in to the object should be private. Do
not make the partitions list be private either. Be sure to hide
the type variable used to build up diskType.
commit 43efffc3607b0a564005979b6f237f5e6e23ced0
Author: Chris Lumens <clumens@redhat.com>
Date: Wed Jan 14 15:45:29 2009 -0500
Add the parted.constraint class.
commit d3f584b160bf02e574ed490fff3803040ff2b790
Author: Chris Lumens <clumens@redhat.com>
Date: Tue Jan 13 17:33:40 2009 -0500
Fix the _ped.flag_get_name test case to anticipate the proper exception.
commit c6445234bc3d792396220103fd39fe819484e737
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Jan 13 10:13:38 2009 -1000
test script
commit df3b3b49b2f12b5c5c7f706fbe14925cf0352174
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Jan 13 10:12:53 2009 -1000
Take in optional DiskType object for py_ped_disk_type_get_next()
Since the get functions for DiskType live at the toplevel now, take
an optional DiskType object so that we can iterate over the list
and collect all types.
commit 4bb25ebd61419c6520ec1abb3dadb7cf20465bd5
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Jan 13 10:12:13 2009 -1000
Initialize a diskType hash containing all DiskType objects.
key=type name (e.g., 'msdos')
value=_ped.DiskType object for that type
commit 82b956950ac6054d10295d5b0877bd7f262df5ae
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Jan 13 10:11:48 2009 -1000
Import from disk.py in parted/__init__.py
commit 6ae1b6722f653141cf49d986d530890e131cc598
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Jan 13 10:10:09 2009 -1000
Move DiskType get functions to the top level _ped module.
DiskTypes are initialized at runtime, but are essentially static.
We can remove a type once the library is loaded, but we never really
create new types. They are merely for reference purposes to give us
things like type names and feature lists of disk types.
I moved the get functions for DiskType to _ped so that in the
parted/disk.py module, I can initialize a diskType hash table that
contains all of the disk types with the type name as the key value
of the hash.
commit 0eba5dc02f9a6cdfc54fffb8a89a0dbf176cd565
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Jan 13 09:39:27 2009 -1000
Docstring fix for device_get_next_doc in _pedmodule.c
The method is device_get_next(), not get_next().
commit c58f8589a84b1df3553aea5ae7bd961d70a8aad2
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Jan 13 09:35:09 2009 -1000
Started the parted.Disk module.
Disk starts to get a bit more complicated past Device. The beginnings
are in the class, but there is more to come.
commit 6c6efa901fd515515965df48936144b5dea01e2c
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Jan 13 09:33:54 2009 -1000
Created getPedDevice() method on parted.Device.
The point of this method is to give us the _ped.Device low level
object that is part of the parted.Device. This might change to a
property later, but for now I'm just adding a method to do this.
commit 469323dafbb8ebfe9e9ba4053382c16163bb4f30
Author: Chris Lumens <clumens@redhat.com>
Date: Tue Jan 13 16:51:02 2009 -0500
Add stub test case files for all the other _ped classes.
commit 331b325cf3704f898a80b4fe1edae6aa3112da3e
Author: Chris Lumens <clumens@redhat.com>
Date: Tue Jan 13 16:02:39 2009 -0500
Geometry.read never needed to take in a buffer argument.
commit 607e4a895684ba5f70632b626d7810fdf197e2c5
Author: Chris Lumens <clumens@redhat.com>
Date: Tue Jan 13 15:58:09 2009 -0500
Add parted.Partition, though it still needs a few docstrings.
commit eb3d4c614b3eaf20c197f6a94c2507b30d004912
Author: Chris Lumens <clumens@redhat.com>
Date: Tue Jan 13 15:46:18 2009 -0500
Add module-level documentation to parted.Geometry.
commit fbe3a4f78b9e45af190317dff249620a65565bdd
Author: Chris Lumens <clumens@redhat.com>
Date: Tue Jan 13 14:44:36 2009 -0500
Don't assert in libparted if an invalid flag constant is passed.
commit 615a6266e403464e972653494cac39fd0131c42f
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Jan 13 07:22:08 2009 -1000
Add docstrings for the parted.Device class.
commit 9108b68d5ace0ecf518466012307af28cd154e61
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Jan 13 07:08:01 2009 -1000
Define parted.ReadOnlyProperty exception for Device class.
Define the ReadOnlyProperty exception at the top level parted module,
raised when users try to write to a read-only property.
Also define the __all__ list and import the submodules inside the
parted module.
commit c6f999a7d0373fabfb9ff4e47c25bf378450f85c
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Jan 13 08:26:32 2009 -1000
Call setattr() for property set methods, docstrings, typo fixes.
1) Use setattr() for the set part of a property() call.
2) Add docstring for the main class.
3) Inherit 'object' not 'Object'.
4) The busy property needed to accept 'v' in the set lambda expression.
commit d133b711087c60143e9fbf78cd396faf7f5420b6
Author: Chris Lumens <clumens@redhat.com>
Date: Mon Jan 12 17:14:53 2009 -0500
Add the parted.Geometry module.
commit ea1b6a6f71a0af03c593a9a74a9acdec5afb8ef1
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Jan 12 12:08:12 2009 -1000
Started the parted.Device module.
Still need to work on docstrings and property handling, and possibly
buffer handling as well, but the basic structure is there.
commit 40a0a7cf9f7c8e48b21822b0de36e8aa71b8618e
Author: Chris Lumens <clumens@redhat.com>
Date: Mon Jan 12 15:26:20 2009 -0500
Add base level getAllDisks and getDisk methods.
commit 13676093d2b9da71d964dbb9fe849865669d79f4
Author: Chris Lumens <clumens@redhat.com>
Date: Mon Jan 12 15:00:49 2009 -0500
Move device_get_next to the _ped module.
We need this method in the top level _ped module so parted.getAllDisks can
have access to the method it needs to build up a list of all devices.
Having it be a method on a Device instance doesn't work.
commit 6c37f2702969c6c1272ca3f53548ce2e099d94a1
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Jan 12 08:55:34 2009 -1000
Rough design notes for the higher level pyparted API.
Notes from the discussion of the higher level pyparted API.
commit b5df8e5e658b20f5caefb0d097fe3462886302f6
Author: Chris Lumens <clumens@redhat.com>
Date: Thu Jan 8 13:45:02 2009 -0500
Remove the stubs of the old API since we're not going to do that.
Implementing the old pyparted API is difficult and seems like a waste of
time, plus doesn't really get us all that much. It's being removed so we
can focus on designing the new API and get to work testing that.
commit 5b43da6b3a385075d11f156828ddca1393737444
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Jan 8 08:47:37 2009 -1000
Removed PedDisk.py
We are not going to support the old pyparted API.
commit 7c955b1070ee2c3a433e805fe4bb7e5e0d83c48f
Author: Chris Lumens <clumens@redhat.com>
Date: Tue Dec 16 13:14:40 2008 -0500
Add the parted.PedPartition module.
commit 9ce6ffaf00a17be4cc1f79ade05198fae45a2f49
Author: Chris Lumens <clumens@redhat.com>
Date: Mon Dec 15 16:55:00 2008 -0500
Add a more complete PedDisk object, thought it's not yet accessible.
parted.PedDisk gets used, but there's also parted.PedDisk.new which we still
need to make visible so anaconda can call it. I haven't reconciled that
problem yet, but for now here's the full parted.PedDisk class.
commit e26ed634786ea460755549318ee96368dfc3026f
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Dec 15 17:26:46 2008 -1000
Initialize tp_dict to NULL.
Python documentation recommends that you set tp_dict to NULL before
you call PyType_Ready(). You can modify it after the fact, but you
want it to be NULL so that PyType_Ready() can set it up.
commit d89022bf420d048beb4f6a9ba8bd00b8fc845729
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Dec 15 17:23:07 2008 -1000
Remove tp_print placeholder.
Current Python documentation recommends that you do not set tp_print
to anything as it may be removed in future versions of Python. The
tp_repr and tp_str functions should be used instead.
commit 9f3d1c39e12c3e99416497b7e51f3751881426fe
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Dec 15 17:21:57 2008 -1000
Set tp_call to NULL for all types.
None of our types are callable (for now), so set tp_call to NULL.
commit 6854ee5552328d131239b811affe6758c6e09fb5
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Dec 15 16:48:14 2008 -1000
Remove internal-only PyTypeObject members.
tp_mro, tp_cache, tp_subclasses, and tp_weaklist are internal-only,
so we don't need to define them in our PyTypeObjects.
commit 6e17314f7b60982db2a779a865243e9931238650
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Dec 15 16:34:34 2008 -1000
Destroy PedDisk and PedPartitions and associated Python objects.
In py_ped_disk_destroy(), call ped_disk_destroy() on the PedDisk
and call Py_CLEAR() on self.
In py_ped_partition_destroy(), call ped_partition_destroy() on the
PedPartition and call Py_CLEAR() on self.
commit 98c912382f6e3b04c0b7f56333fd908c3aa6f592
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Dec 15 16:33:42 2008 -1000
Call Py_CLEAR() from _destroy functions.
Make sure we are calling Py_CLEAR() in the destroy functions for
_ped.Geometry, _ped.Alignment, and _ped.Timer.
commit 3c06ed94589d23f62f6ded6538b45ef84408147b
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Dec 15 16:04:47 2008 -1000
Call Py_CLEAR() in py_ped_device_destroy() to reap the object.
We successfully destroy the PedDevice in libparted, but we need to
decrement the refcount on self to 0 so that Python's garbage
collector will destroy the Python object.
commit f2dc083afaa7714845a1bf517d7751d426d3f278
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Dec 15 16:02:20 2008 -1000
Call Py_CLEAR() in py_ped_constraint_destroy()
We do not need to convert the _ped.Constraint to a PedConstraint
only to destroy it. Call Py_CLEAR() on the PyObject pointer passed
in to the function (self) so we drop its refcount to 0 and then
Python should take over from there.
commit e6471cade66b429c116848bb085a174ca0cf465f
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Dec 15 15:52:53 2008 -1000
Use Py_CLEAR() in dealloc and clear functions.
Use Py_CLEAR() instead of Py_XDECREF() in dealloc and clear
functions for our types. Also set PyObject type members to NULL
after we clear them.
commit 3d50d6d1aa605211184ae9b42a7256d86f6a2f15
Author: Chris Lumens <clumens@redhat.com>
Date: Mon Dec 15 15:14:59 2008 -0500
Update parted.PedDevice for changes to _ped.Device.
It's been a long time since we looked at the parted module. One big thing
we changed is that you can no longer create a _ped.Device yourself. We also
moved a couple methods around. Update PedDevice to reflect these changes.
I have not yet tested this module, but test cases for it will be coming.
commit c2d73d53e65a760471304b9d19646f8219a32ae0
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Dec 15 10:23:25 2008 -1000
Hate vim autoformatting of comments.
commit ac8259c7112d4a2775bfc0c29975da3400b197fa
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Dec 15 10:19:16 2008 -1000
Move py_ped_disk_probe() to pydevice.c, make method on _ped.Device
This is the first of hopefully few 1:1 function shift arounds. We
started the _ped module code by created py*.c files that more or less
mirrored the libparted code as closely as possible while creating
Python objects for the typedefs in libparted.
The py_ped_disk_probe() function is the first one that we need to
move to a new file. It was part of pydisk.c, but since it operates
on _ped.Device objects, it should be a method on that object. As
such, it's now in the pydevice.c file and the include components
have changed locations in the header files.
commit ee144f33bd2599d4eb8e35ae4f1ce86e12a69225
Author: Chris Lumens <clumens@redhat.com>
Date: Mon Dec 15 14:42:00 2008 -0500
Add a test case for _ped.Alignment.is_aligned.
commit a678cc5c13f9c376d1c61af19f5b8981d5651e08
Author: Chris Lumens <clumens@redhat.com>
Date: Mon Dec 15 14:03:19 2008 -0500
Handle various libparted assertions inside ped_geometry_{read,write}.
libparted will assert if the device is not yet open, so handle that before
calling into libparted and raise an exception. Likewise, passing bad
arguments also causes assertions and must be caught ahead of time.
commit 5df0432165bae9ff3ddf582665239a934c693060
Author: Chris Lumens <clumens@redhat.com>
Date: Fri Dec 12 13:15:12 2008 -0500
Add test cases for most of _ped.Geometry, except the tricky ones at the end.
commit 861d97fe1a9c821809d27b255564486619aa89f7
Author: Chris Lumens <clumens@redhat.com>
Date: Fri Dec 12 10:03:26 2008 -0500
Add the initial set of tests for _ped.Alignment.
commit 857b5199e7d03cd01e1479d44898f5a6bcebbaa2
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Dec 12 18:56:46 2008 -1000
Store PedDevice pointer in _ped.Geometry object.
A PedGeometry stores a pointer to a PedDevice, so store a copy of that
pointer in the _ped.Geometry object.
commit bc38b608a1e5b6742179c3b921738f32afdb6e8d
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Dec 12 18:51:41 2008 -1000
Do not use ped_geometry_destroy()
PedGeometry stores three PedSectors and a pointer to PedDevice. If
we call ped_geometry_destroy, we kill that PedDevice, which we don't
want to do. PedSectors are long long variables, so those are fine.
commit 10492d1ea2ca91efb4ccadc08d6627e2e6c75ee0
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Dec 12 13:17:52 2008 -1000
Comment explaining _ped_Device2PedDevice.
commit 9825f6f14a171b8654bce110ce5fe8f1f27e5841
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Dec 12 13:15:11 2008 -1000
Do not run ped_device_destroy() all over the place.
Do not use ped_device_destroy() to free a PedDevice. We are not
working with PedDevice types like we do with a PedGeometry or
something similar. We are passing the pointers around to the
master copies of PedDevice objects. If you are getting a
PedDevice by calling _ped_Device2PedDevice(), you are getting a
pointer and you SHOULD NOT destroy it.
The only place where we should call ped_device_destroy() is in
py_ped_device_destroy().
commit 2318284f9569f797601dc2769f495df79f04a516
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Dec 12 13:01:31 2008 -1000
Store PedDevice pointer in _ped_Device struct.
The PedDevice structs in libparted are unique. Unlike the other
types in libparted, PedDevices are generated when the library
loads and scans for everything. Things like Constraint and
Alignment are can created on the fly and thrown away. But Devices
are arch-specific and need to live through the life of the program.
In our _ped_Device struct, keep our convenience copies of the data,
but also store a pointer to the PedDevice we're mirroring to
Python so that we can use that in other calls where we need the
PedDevice.
This solves the problem of "what to do about the arch_specific data"
issue.
commit a2e84105e8fed9c98f690ae37decf3f51eb3ee01
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Dec 12 12:15:11 2008 -1000
Add AC_CONFIG_MACRO_DIR([m4]) to configure.ac
The output from the bootstrap script keeps telling us to do that,
so I did that.
commit 7ad7f64854f70a67a13bad7424eba38f4e391cab
Author: Chris Lumens <clumens@redhat.com>
Date: Fri Dec 12 16:24:12 2008 -0500
Fix errors in converting _ped.Device to and from PedDevice.
First, _ped_Device2PedDevice was only doing a ped_device_get, it wasn't
actually copying any of the values into the PedDevice object. That's not
going to work. Second, we have to copy the arch_specific pointer around
since that has function pointers that libparted methods will need to
access.
commit f9f37e5c5ac9922bb461b66ccf9793b5f46a77ab
Author: Chris Lumens <clumens@redhat.com>
Date: Fri Dec 12 16:19:13 2008 -0500
Make sure to copy the open_count attribute when we open a device.
This is another instance where a libparted function sets a value on one of
the libparted types, and we don't copy it back into the corresponding pyparted
type. This should make read/write methods work a little better.
commit f94ee259d845c2c26dd04a877f2bd2fd4afe778d
Author: Chris Lumens <clumens@redhat.com>
Date: Thu Dec 11 16:28:55 2008 -0500
Add a test case for _ped.device_get.
commit df898812d836a00a18c26c516426758b4bd8c73f
Author: Chris Lumens <clumens@redhat.com>
Date: Thu Dec 11 16:24:27 2008 -0500
Raise an exception instead of segfaulting on _ped.device_get(None).
commit b6c6450a586d7b06e7d6253036d42e5f8f899de0
Author: Chris Lumens <clumens@redhat.com>
Date: Fri Dec 12 10:52:38 2008 -0500
Copy modified attributes from ped_geometry_set_* to the _ped.Geometry object.
All our _ped.Geometry.set_* methods were failing because the values were being
set on a libparted object, but never being copied back to the _ped.Geometry
object. So it's like those method calls never happened. Unfortunately, this
causes another GC error to appear.
commit 8efcd8c2d713812c49cb51290878906bb5a5fd71
Author: Chris Lumens <clumens@redhat.com>
Date: Fri Dec 12 10:19:57 2008 -0500
Fix a bunch of typos and thinkos in the test cases.
The existing _ped.Geometry test cases should now all pass with the right
successes and errors, except destroy. But then, we don't know what we
want to do with the destroy methods anyway.
commit 660f5ec59e3f0c3ab153cdc233772fc4d653da69
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Dec 11 19:12:18 2008 -1000
Handle reference counts in _ped.Geometry correctly.
In the dealloc and clear functions for _ped.Geometry, use the
Py_CLEAR() call to bring the reference count to 0 for PyObject
members.
In the init method, initialize PyObject members to NULL and
increment the reference count on self before returning.
commit 7fd719e2dd28638ecf9877a1a0c565754246ee81
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Dec 11 16:18:09 2008 -1000
Handle object members in _ped.FileSystem correctly.
This object may need some more work later. We allow users to create
_ped.FileSystem objects, but we don't want to call libparted from
inside the __init__ function to see that what the user provided is
valid. Why not? The only function we get in libparted to check
that is the ped_file_system_create() function, but the user may not
want to create the filesystem on disk yet.
The disk and type parameters are required, so make sure to Py_INCREF
those correctly. An optional parameter for now is checked. Init it
to false. I say this function may need some more work because we
may want to change 'checked' to be a boolean.
commit 3222d345e2664cc1f8b0994779c0d44e96b509d9
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Dec 11 16:15:50 2008 -1000
Initialize members in _ped_Geometry_init() correctly.
Call Py_INCREF() on the _ped.Device object. For start, length, and
end, just copy those back from the PedGeometry we get. end may or
may not be provided by the user, but it doesn't matter because we
should be able to just copy the values directly back from the
PedGeometry and know we have everything we need. They are long long
values in our struct and in libparted, so no special PyObject
handling for these.
commit acde8a535ff87b945cb5af67b5f40ce354851310
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Dec 11 16:11:25 2008 -1000
Copy in missing members in _ped_Disk_init()
Similar to the work done for 67fcd69777057e5670e90d523a17d24e3247c6f4
commit 02c2c2764a9ccf42f74c6c40d2808c0318ed6331
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Dec 11 15:44:20 2008 -1000
Copy in missing members in _ped_Constraint_init()
Similar to the work done for 67fcd69777057e5670e90d523a17d24e3247c6f4
commit 46c72caea7d4fefe30df7086110f0179f88e06a4
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Dec 11 15:35:22 2008 -1000
Use tp_alloc for types that must use factory functions.
We have some types that users are not allowed to create on their
own. The module may hand them one of these object types, but one
cannot be created in the usual way.
For these types, we have tp_new set to NULL. In convert.c, make
sure we call tp_alloc rather than tp_new to allocate the new object
and return it to the caller.
commit 429a1f09a8c3376ff6e419031e044fa6cf353fc7
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Dec 11 13:19:45 2008 -1000
Py_CLEAR sets the argument to NULL, remove redundant line.
commit 9501a349c8d24e12e71bbd0722ca4cf3bcc1534d
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Dec 11 13:12:33 2008 -1000
Copy in missing members in _ped_Partition_init()
For some objects, we only require the user to give us a bare minimum
of information and then we let libparted compute the other members.
To get these additional members back in to the Python object, I was
doing a Py_XDECREF on self and then simply converting the newly
generated libparted type to a Python object and assigning it to self.
On paper, this sounded like a good idea. Several problems:
1) Py_XDECREF only decrements the count by one. We really need
to zero out the count.
2) Clearing self and then assigning something new to it while
you're inside the object isn't very clean.
3) The new self needed a Py_INCREF.
Things I've learned:
- PyArg_ParseTuple and PyArg_ParseTupleAndKeywords do not run
Py_INCREF for you on PyObjects it reads.
The new solution is pretty simple to follow. We keep the parsing
using PyArg_ParseTupleAndKeywords and we keep the libparted call
because that computes the other members we need, but changes I've
made:
1) Py_INCREF the PyObjects read by PyArg_ParseTupleAndKeywords
2) Copy in computed members that are not PyObjects by just
using an assignment in C.
3) For computed members that are PyObjects, first I Py_CLEAR
the member and set it to NULL, then I convert the computed
type to a PyObject, and lastly I call Py_INCREF on that
member.
4) Use ped_free() to destroy the PedPartition we made.
In short, we need to use Py_INCREF on all PyObjects read by the
PyArg_ParseTuple functions. We should not clear self and reconvert
the object, instead we should correctly copy in the new members.
commit 7e973965a5710fce3d9bce96d5c3b4e848331890
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Dec 11 12:46:15 2008 -1000
Use tp_new for PedCHSGeometry2_ped_CHSGeometry()
commit 983d4a92bc455e7811ad72d33f42eedabad81598
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Dec 11 12:45:12 2008 -1000
Use tp_new for PedFileSystemType2_ped_FileSystemType()
commit 461f7c6fbbf2a3bebe63c47050e9df2942ace69e
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Dec 11 12:43:59 2008 -1000
Use tp_new in PedDiskType2_ped_DiskType()
commit 8c27c45f784c09b37dac55444a622f2209d9eca9
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Dec 11 12:41:19 2008 -1000
Use tp_new/tp_init for PedDisk2_ped_Disk
commit 26aaa738bfadf10ddf206713c0fba988108bef95
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Dec 11 12:25:47 2008 -1000
Use tp_new in PedDevice2_ped_Device()
Use tp_new to allocate the new _ped.Device object in
PedDevice2_ped_Device. Remove some GC function calls and added
Py_INCREF calls for the _ped.CHSGeometry objects we create.
commit 955e565f943a4ccd1b12870a36d39fc89b85b421
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Dec 11 12:17:07 2008 -1000
Use tp_new/tp_init for PedFileSystem2_ped_FileSystem()
commit 9b20c54d920b8f92bae69b8a9a4f019c5c9388b6
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Dec 11 12:00:43 2008 -1000
Use tp_new/tp_init in PedConstraint2_ped_Constraint
commit cca6a1bba756e95bdee30b0d32c80d72340e1830
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Dec 11 11:30:27 2008 -1000
Change PedGeometry2_ped_Geometry() to use tp_new and tp_init
We changed PedAlignment2_ped_Alignment to use the tp_new and tp_init
function pointers for the _ped.Alignment type object and use the
Py_BuildValue() function to build the argument list for tp_init.
Changed PedGeometry2_ped_Geometry to work the same way.
Also fixed up an error message in PedAlignment2_ped_Alignment.
commit ab84bf7ea1a0bc598cf6e0a6576b3bbf1c0c5424
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Dec 11 11:10:32 2008 -1000
Move #include <structmember.h> to typeobjects header files.
We only need to include this head for the structs defined in the
typeobjects header files.
commit c62b331165556e426cc050d643e34321ecf97006
Author: Chris Lumens <clumens@redhat.com>
Date: Thu Dec 11 13:58:19 2008 -0500
If _ped_Geometry_init returns -1, make sure we set an error string.
Python requires all NULL/-1/other error code returns from functions to have
some error string set as well. Otherwise, it complains. If we are not
handling this same case in all the other files, I'll need to go through and
change them too. It's probably easiest to do that as I work my way
through the test cases.
commit 77797fd92681380676a57d21f5a4559b65d333dd
Author: Chris Lumens <clumens@redhat.com>
Date: Thu Dec 11 10:38:41 2008 -0500
Fix converting libparted execptions into python exceptions.
First, we were always hitting a double free because libparted frees the error
string for us, but we were also doing that in partedExnHandler. Second, the
exception flag and message need to be moved into a .c file and externed in
the header, just like was required for fixing the isinstance problem.
commit 62f9fb45609466af0fd032620af9963e27b8aa03
Author: Chris Lumens <clumens@redhat.com>
Date: Thu Dec 11 11:45:13 2008 -0500
Add a test case for CHSGeometry, which is really kind of useless.
commit 0268f3bd821ca26c2b919d8131e47a4ec565fe71
Author: Chris Lumens <clumens@redhat.com>
Date: Thu Dec 11 14:08:06 2008 -0500
Add test cases for all the easy methods on _ped.Geometry.
These test cases do not all pass yet. There are some GC-related errors and
other problems that are keeping them from passing. However, I've only been
working on them on a private branch. By pulling the test cases onto master,
it's opened up for everyone to see the errors and work on them.
commit 1ad2c616060300e021964b7a6a780893641704d9
Author: Chris Lumens <clumens@redhat.com>
Date: Mon Nov 24 15:14:11 2008 -0500
Add a file to contain baseclasses for our test cases.
Lots of our test cases will have to do similar operations, like set up a
temporary device for testing destructive parted functions against. For
these test cases, it's convenient to create a base class with the setUp and
tearDown methods that the test cases then subclass.
commit e1435fde00c9ef7f3136ec5ebac020d1569e1fbe
Author: Chris Lumens <clumens@redhat.com>
Date: Thu Dec 11 14:05:30 2008 -0500
Add test case stubs for the other methods that have moved into _ped.
commit d3044a116b60f8a90ca0fdfef0dcfad56337a6e1
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Dec 10 18:45:31 2008 -1000
Forgot the \ at the end of the noinst_HEADERS line.
commit 25bfe7e3123871a82c770e4bab03069823fb3522
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Dec 10 18:44:22 2008 -1000
Created include/typeobjects/*.h to hold PyTypeObject definitions.
I like header files for source organization. Since I did that for
the docstrings, I decided to move the PyTypeObject stuff in to
header files under the include/typeobjects/ subdirectory. That way,
we can work on those structs in one location and not end up with
huge source files in src/
commit d9ed389c0c0527793c5d1a7e1b989f9d27ec795d
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Dec 10 18:02:10 2008 -1000
Move all PyDoc_STRVAR() declarations to docstrings header files.
We only want docstrings for PyTypeObjects and related structures.
The docstrings get long, so put them in their own header files under
include/docstrings and then include the per-source docstrings header
under src/
Organizational change and also clears up errors where we were
defining tons of docstrings each time we included something.
commit 6c315acde583b82407559de7260dc83007a7acb0
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Dec 10 17:40:10 2008 -1000
Move other static structs to C source for PyTypeObjects.
Move PyMemberDef, PyMethodDef, and PyGetSetDef structs to C source
files to be next to the PyTypeObject structs.
commit a581ac8f90c553206f353254eec19a5770c94a56
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Dec 10 16:47:25 2008 -1000
Move PyTypeObject defintions to source files.
Do not declare PyTypeObjects as static structures in the header
files, because this leads to multiple PyTypeObjects in our Python
module, which causes things like isinstance() to fail.
commit c8bddd6c58a1d2df8fa973bb91a5f406b05d9214
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Dec 10 16:22:33 2008 -1000
Fixed the isinstance bug.
commit 8ffddb0a893c93513afbff0fe7724b7138efae95
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Dec 10 14:54:06 2008 -1000
PyObject_HEAD_INIT(NULL) -> PyObject_HEAD_INIT(&PyType_Type)
Left over from something I was trying earlier, forgot to put back
the &PyType_Type component.
commit 903d07e55e7685472c1106721499a1e84664085d
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Dec 10 14:52:47 2008 -1000
Use _ped_Alignment_init() in PedAlignment2_ped_Alignment.
Better to use our own code rather than have assignment lines for
each class member.
commit dbd87ef75c521321ccac02fe2c39cae359d8bc51
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Dec 10 14:49:31 2008 -1000
Fix PedAlignment2_ped_Alignment() missing ob_type problem.
This fixes the following problem:
import _ped
x = _ped.Alignment(10, 10)
isinstance(x, _ped.Alignment) -> True
y = x.duplicate()
isinstance(y, _ped.Alignment) -> False
The problem was because we have our PyTypeObject declarations in the
header files to the project and have them all set to 'static', which
means we have too many copies. Only the one seen in _pedmodule.c was
getting ob_type set correctly, which is why x is an instance of
_ped.Alignment, but not y.
The solution is to remove the static part of the declaration and put
it in the appropriate source file in the project, but then add this
line to the header file:
extern PyTypeObject _ped_Alignment_Type_obj;
The extern line is so we can use that type object throughout the rest
of the code.
commit 0c1d36ede75ea0d7f70e9b73f1715611d53b10a7
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Dec 10 14:01:12 2008 -1000
Correct some format strings in pydisk.c
The device path part of a PedDisk is buried in the PedDevice and
finally the path member, so we should have an extra ->dev->path on
all of the instances where we want the device path.
Use %d for the partition number rather than %s.
commit 4306d2b1ed2338718653e747b65a43eda4512f81
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Dec 10 13:53:30 2008 -1000
Remove unused tp_new functions.
Removed the following tp_new functions: _ped_FileSystem_new(),
_ped_Alignment_new(), _ped_Timer_new().
commit 010c4cf64b4eb3770d2fb6fb01a17ea500d7602b
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Dec 10 13:50:21 2008 -1000
Remove tp_new functions in pydisk.c we aren't using anymore.
Removed _ped_Partition_new() and _ped_Disk_new() since we are using
the PyObject_GenericNew() function now.
commit 7c1c9bf028b5c85a2bf42b3503c6f1d83a6a0c8d
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Dec 10 13:50:03 2008 -1000
Removed unused variable 'o' in init_ped()
commit 277eb92a565daa6e0789513759bc4e8c33d1dd89
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Dec 10 13:44:39 2008 -1000
Add prototype for init_ped() function.
commit 80908532be80f23df933091ba5602b799155ca08
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Dec 10 13:37:25 2008 -1000
Add '-Wall -Wmissing-prototypes' to the CFLAGS.
commit 2ed4756c5f01b9cb57d67de4c35d466c8c41fe8d
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Dec 10 13:06:22 2008 -1000
Ignore autogenerated m4 files.
commit db1e50a2ba62e39b919cca980cbfa50c08163d79
Author: Chris Lumens <clumens@redhat.com>
Date: Tue Nov 25 15:11:05 2008 -0500
Update bug list for the latest disaster.
commit 39ba3d45851caab5e4c06460d65af7fff7dabd89
Author: Chris Lumens <clumens@redhat.com>
Date: Tue Nov 25 11:22:59 2008 -0500
Make _ped.Device documentation look like all the rest.
commit a611d36a117425ee66fb6b81766db6339a41d792
Author: Chris Lumens <clumens@redhat.com>
Date: Tue Nov 25 11:12:06 2008 -0500
Add documentation for everything else in pydisk.h.
We're not really going to use Timers in the future, so I'm removing them from
the TODO list. Writing a bunch of documentation we're just going to throw
away seems like a big waste to me.
commit 1504cf1770215c56897a0a445386cb7f6d261f54
Author: Chris Lumens <clumens@redhat.com>
Date: Fri Nov 21 10:52:07 2008 -0500
PyType_GenericNew behaves correctly for GC-managed objects.
commit 5036bad08d9fc283fce78f8f9277225d84c7daa0
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Nov 19 05:30:34 2008 -1000
Remove Py_TPFLAGS_DEFAULT from PyTypeObjects.
We shouldn't be using Py_TPFLAGS_DEFAULT because it sets things that
we don't necessarily have defined for our objects. Made sure ours
are set to just the things we want.
NOTE: We'll have to update the tp_flags when we define more things.
commit 60fbfc19b9a3ac923da48f9f0eac5069e9c3b1d5
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Nov 19 04:34:07 2008 -1000
Updated TODO list.
commit 0508f79eb6ad9d173d856467324ade8f4a3498ae
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Nov 19 04:29:08 2008 -1000
Use PyObject_GC_Del() for object destruction.
Since we are using GC now, we should use PyObject_GC_Del() to destroy
objects. Explained when we should and should not use the Py_XDECREF()
and PyObject_GC_Del() functions.
commit 4df04a561c350386e6166be9508048e69704e049
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Nov 19 04:17:08 2008 -1000
Add garbage collection for _ped.Timer
That completes the basic layout for the GC support on our custom
PyTypeObject definitions.
commit cd1983d913989eb32c1d10420a146d79b308d9c9
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Nov 19 04:13:25 2008 -1000
Added garbage collection for _ped.Alignment
commit 9bb650f0b53706a397d67e9b568afbb2fb53a9d7
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Nov 19 04:08:42 2008 -1000
Added garbage collection for _ped.Geometry
commit 2973ea1163fe7241750361d6f79e87c4cab53ee6
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Nov 19 03:59:39 2008 -1000
Added garbage collection for _ped.FileSystem and _ped.FileSystemType
commit 32ea2f9251ce425123f874d7872dd5c660dfeb73
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Nov 19 03:44:17 2008 -1000
Rename Device factory functions to more closely match libparted.
The names I gave the Device factory functions at the _ped level do
not follow the naming style we've been trying to use in _ped. Made
the following method renames:
_ped.get_device() -> _ped.device_get()
_ped.probe_all_devices() -> _ped.device_probe_all()
_ped.free_all_devices() -> _ped.device_free_all()
commit 984ee859e3dd7676ad571e0dcf3e345d4b38593b
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Nov 19 00:09:17 2008 -1000
Updated TODO list.
commit 9a4350fc4e839bdb237738e65ce97c9df6a37830
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Nov 18 23:57:03 2008 -1000
Add garbage collection support for pydisk
Add GC functions for _ped.Partition, _ped.Disk, and _ped.DiskType.
commit 024c4afd6b838e60801cedaeb12722b6f056ef7a
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Nov 18 23:26:27 2008 -1000
Add garbage collection support for _ped.Constraint
commit d22816b44fb7dc03e5bc08eaf8d48ad720605c2f
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Nov 18 23:12:51 2008 -1000
Forgot the Py_TPFLAGS_HAVE_GC in the _ped.CHSGeometry PyTypeObject
commit 6a587ca361b4588c19f674a580e583b65cfe300c
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Nov 18 23:09:53 2008 -1000
Add garbage collection support for _ped.CHSGeometry
commit 3347d820465a9ac07df0d1ad2acb08312a99598e
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Nov 18 22:43:15 2008 -1000
Add garbage collection support to pydevice
Seems pretty straightforward. Use a different _New function, add
traverse and clear functions, fix up the dealloc function to work
with GC, set the GC flag in the PyTypeObject.
Will be carrying this over to the other types.
commit 2ff371dd7f5ac0c51b3036a548ed58b8640fed08
Author: Chris Lumens <clumens@redhat.com>
Date: Thu Nov 20 15:04:57 2008 -0500
Use PyType_GenericNew instead of our own function, where appropriate.
On our object types where you can create them manually, the generic new
method both allocates space for the type and sets up default values. With
just using our own new functions, we'd have to set the defaults ourselves
to prevent tracebacks. This new mechanism has the pleasant side effect
of enforcing the number of arguments required to be passed to the __init__
method.
commit fa2e1debb6f58c599b16a133e3051b50db126b9c
Author: Chris Lumens <clumens@redhat.com>
Date: Thu Nov 20 13:38:32 2008 -0500
Add test cases for a couple more things in _ped.
commit d0dc99794457e72f5e740c3fd73df39062d9cbdc
Author: Chris Lumens <clumens@redhat.com>
Date: Thu Nov 20 13:19:51 2008 -0500
PedPartitionType and PedPartitionFlag are enums, so treat them as longs.
This fixes the same stack alignment problems as we were having with PedUnit.
commit cc187567619a7aa29e01564bdd207a0665a84423
Author: Chris Lumens <clumens@redhat.com>
Date: Thu Nov 20 12:17:01 2008 -0500
Move flag and type methods into _ped.
The following methods do not operate on an object, but instead return flags
and types based on integers/strings:
py_ped_partition_type_get_name
py_ped_partition_flag_get_name
py_ped_partition_flag_get_by_name
py_ped_partition_flag_next
commit c37be24f677a7d0b6f9347b8734d6b4c513b721c
Author: Chris Lumens <clumens@redhat.com>
Date: Thu Nov 20 12:12:03 2008 -0500
Add documentation for _ped.Partition.
commit 36d9c7cb6c370be9f13322aad6338abeeabcb21c
Author: Chris Lumens <clumens@redhat.com>
Date: Thu Nov 20 10:36:46 2008 -0500
Fix dir() not wowrking on all other object types, too.
commit 87b477c1b032e139ea1fd692deb57e4a5d9594e4
Author: Chris Lumens <clumens@redhat.com>
Date: Thu Nov 20 10:21:06 2008 -0500
Use the right types when calling PyObject_New.
I don't think this actually affects anything, but all examples I've seen
use a real type as the first argument instead of PyObject, and it certainly
does make things a little more clear.
commit 0b25435d23f57609e6fd3e84d956c51a1c33a99c
Author: Chris Lumens <clumens@redhat.com>
Date: Thu Nov 20 10:14:09 2008 -0500
Fix the problem of _ped.Device objects not having any attributes.
What do you know, we needed to add a method to the type struct for how to
get attributes. I suppose this now needs to be done for our other types,
too.
commit 2f1c2663419e77277e1dbba7b12029189f64e3ff
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Nov 18 12:44:51 2008 -1000
Updated TODO list.
commit 31b5810c0f89161d0dd23fdceff5b3422a00737c
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Nov 18 12:44:18 2008 -1000
Add docstrings to include/pydevice.h
commit 22c7bc670bd8f018e043129244d0904c064651af
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Nov 18 05:50:52 2008 -1000
__init__() cleanups in _ped.Disk
Throw CreateException if the user does not provide the required
parameters. Remove the extra conversion checks since libparted
will error out anyway if those are invalid. Lastly, delete self
if we failed to create the PedDisk.
commit d3360bc7d08058338dc3fabeb6498f7f38b70cea
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Nov 18 05:50:17 2008 -1000
Delete self if __init__ fails in _ped.Constraint
Make sure to delete self if __init__() fails in _ped.Constraint.
commit bb9f2cbbe35bc4a5d8a5860ed2c5541b1f551d2e
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Nov 18 05:49:34 2008 -1000
Convert newly created PedGeometry to _ped.Geometry in __init__
After we create the new PedGeometry, convert it to self before
returning.
commit 61e1fced555ea567e99ca330b8393f9c4e099761
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Nov 18 02:48:57 2008 -1000
Use PyObject_New() and PyObject_Del()
Found out the difference between the _New/_NEW and _Del/_DEL
functions. The all caps versions eliminate some safety checks and
NULL tests in favor of speed. I figure we can use all the safety
checks we can get, so use the more safer versions.
commit 3353848efb11e08b0a10f9ed973a599d86ddafe1
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Nov 18 02:45:19 2008 -1000
Expanded _ped_Disk_init()
Removed the py_ped_disk_new() and py_ped_disk_new_fresh() functions.
Several problems discovered. First, those functions weren't that
correct. More importantly, they should not be per-Disk methods.
Since they deal with creation of Disks, merged their functionality
in to the __init__() function for _ped.Disk.
The __init__() function will have one required parameter, the Device.
If you also provide the option DiskType paramter, the behavior
changes. Providing just the Device causes us to call ped_disk_new()
in libparted. If you provide a Device and a DiskType, we call
ped_disk_new_fresh() in libparted.
commit fcb736f0838695ca124a4c63ab27fc03c997acf8
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Nov 18 02:16:10 2008 -1000
In *_destroy() functions, destroy the Python object.
In our py_ped_*_destroy() pass-through functions, we were converting
the Python object to a libparted type, then destroying and returning
None. While this works, it seems pointless. We don't need to create
and destroy a libparted type, we only need to destroy our Python type,
so call PyObject_DEL() and return None.
The py_ped_file_system_clobber() function is special. We have to
call the file system clobber function to actually destroy it on disk
and then destroy the object.
commit d3af4a4709284a9879ffa1dc1c4b12359044a3b6
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Nov 18 02:00:39 2008 -1000
Move py_ped_timer_new() functionality to init for _ped.Timer
Timers are not entirely implemented, but keep the current code in
line with the rest of the module. The ped_timer_new() function
should not be a method on a Timer object. Moved its functionality
to the __init__() function for _ped.Timer.
commit 8eff9b3f561a9e3a3294a03ae82df79d13e80a71
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Nov 18 01:54:58 2008 -1000
Move py_ped_partition_new() functionality to init for _ped.Partition
The py_ped_partition_new() function should not be a method on the
_ped.Partition type. Moved the functionality it was providing to
the __init__() function for a _ped.Partition.
commit cbff35f5e82c0814468e9be29a9354d716f1ce94
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Nov 18 01:12:58 2008 -1000
Updated TODO list.
Explain the bug where we create new objects with factory functions,
but they appear empty until we just access them in the interactive
environment.
commit b9b030ba7950314943c540051d809acac3148ae5
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Nov 18 01:10:48 2008 -1000
Use PyObject_NEW() in convert.c
The *_new() functions for non-instantiatable objects are not longer
available, so use PyObject_NEW() to create them in convert.c
commit d9f6850e130b83f8d3fd93bead73c6e1eff22e7b
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Nov 18 11:02:30 2008 -1000
Make some types non-instantiatable by users, clean up tp_allocs.
The following objects cannot be instantiated by users directly:
_ped.Device, _ped.CHSGeometry, _ped.DeviceType, _ped.DiskType,
_ped.FileSystemType, _ped.PartitionType
These are valid objects with other methods and attributes, but _ped
will hand the user that object when necessary.
Remove all of the tp_alloc assignments from _pedmodule.c and put those
in the PyTypeObject structs.
commit 0de87041d8e72734b007105ba522d35704e70c9f
Author: Chris Lumens <clumens@redhat.com>
Date: Tue Nov 18 15:34:07 2008 -0500
And there's more stuff to write test cases for in _ped.
commit 77430fcf085841b4f863b0729d5ad5cab06f863c
Author: Chris Lumens <clumens@redhat.com>
Date: Tue Nov 18 14:06:28 2008 -0500
Add documentation for FileSystem and FileSystemType.
commit 7c7b7988e3540a4e7735e097830a1047ca9f5b2b
Author: Chris Lumens <clumens@redhat.com>
Date: Tue Nov 18 11:58:36 2008 -0500
Use a much more simplified way to add constants to the _ped module.
commit 91310740c94b4ce0999565338191893d31ff719d
Author: Chris Lumens <clumens@redhat.com>
Date: Tue Nov 18 11:34:41 2008 -0500
Add documentation for Alignment objects.
commit ebe1ff4a1ef5ed7c7fc7ef2fb2896dcb337f3692
Author: Chris Lumens <clumens@redhat.com>
Date: Tue Nov 18 11:07:59 2008 -0500
Finish up Constraint documentation with an object-level blurb.
commit 992501cd194a4e5d0772b8f114bfa72cb6d38cae
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Nov 17 08:10:39 2008 -1000
Updated TODO list.
Added a note to make sure that all of the destroy pass-through
functions also destroy the corresponding Python object.
commit 727f7e980683c48ae1e653399984cf8482aec52b
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Nov 17 08:06:57 2008 -1000
Add docstrings for pyconstraint, remove py_ped_constraint_done.
Added docstrings for the pyconstraint attributes and methods, based
on what I found reading the libparted source.
Saw that the ped_constraint_done() function is a helper function
for ped_constraint_destroy() and we don't need a pass-through for
it in Python, so I removed it.
commit b95edbe306be325aafdc572dc858e44e5b14a691
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Nov 17 02:04:32 2008 -1000
Updated TODO list.
Note the stupid git ref error we're getting and make a note to fix
it at some point in the future.
commit 01006816d5948172bd05368398bca646c9af18f8
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Nov 17 11:46:26 2008 -1000
Last try and then I just give up on git.
commit c9922161280c751b014dbbba356081ad9d35128a
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Nov 17 11:45:08 2008 -1000
One more test.
commit e072231d39e058cb702057789accb7ffde98513e
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Nov 17 11:42:37 2008 -1000
And do we have those annoying errors gone?
commit 01a5336c282b4b92d75ed97c3154c50598410778
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Nov 17 11:37:37 2008 -1000
Testing the git gc fix.
commit 9b476401989d216b5c31363a425477eee9573118
Author: Chris Lumens <clumens@redhat.com>
Date: Mon Nov 17 14:42:48 2008 -0500
Fix _ped.Device object creation so you can only create them from functions.
The tp_alloc function we had was causing segfaults, so I replaced it with
PyType_GenericAlloc which is what the python docs recommend we do anyway.
Also we were setting a tp_new in _pedmodule.c which was overriding our NULL
setting in the type object. That'd explain why a = _ped.Device() still
worked.
commit 6b597a0487ff10fc4dbd711a35c24ab73577d017
Author: David Cantrell <dcantrell@redhat.com>
Date: Sat Nov 15 07:29:38 2008 -1000
Move Constraint factory functions to _ped.
The following Constraint functions are not specific to a single
Constraint instance, they are factory functions. Move them to _ped
and add docstrings for them:
py_ped_constraint_new_from_min_max()
py_ped_constraint_new_from_min()
py_ped_constraint_new_from_max()
py_ped_constraint_any()
py_ped_constraint_exact()
commit 5817ca6229bf492f16d177850ebe7b7cef56d6ed
Author: David Cantrell <dcantrell@redhat.com>
Date: Sat Nov 15 07:15:08 2008 -1000
Remove init and new functions for Constraint, Geometry, & Alignment.
The py_ped_OBJECT_init and py_ped_OBJECT_new functions for the
Constraint, Geometry, and Alignment OBJECTS were sort of pointless.
The object's tp_new and tp_init methods are sufficient.
Remove the pass-through calls for the unnecessary functions. Added
calls to the ped_OBJECT_new() function inside each type's tp_init
function. We can use this to have libparted validate whether or
not the user is creating a correct object. Catch exceptions from
libparted like we were doing in the new and init function pass
throughs.
The __init__() functions now for Constraint, Geometry, and
Alignment require all arguments since it's now like calling the
ped_OBJECT_new() function in libparted.
commit e7916a123e32241955f5e37ae8d281f6fea5a649
Author: Chris Lumens <clumens@redhat.com>
Date: Sun Nov 16 17:35:12 2008 -0500
And trim off the leading py_ped_ from everything too.
commit 65ddcc8f82b1e791873c09966681720d4eef604b
Author: Chris Lumens <clumens@redhat.com>
Date: Sun Nov 16 17:32:19 2008 -0500
Add documentation for pygeom.h.
commit 138da9bcf549e170a2b24b798c11cb7611d15d3b
Author: Chris Lumens <clumens@redhat.com>
Date: Sun Nov 16 13:47:59 2008 -0500
Update docs for pyparted_version_doc to match new return type.
commit 9f7a43566c266cb33fa892c339f5cf213eba1a82
Author: David Cantrell <dcantrell@redhat.com>
Date: Sat Nov 15 17:48:14 2008 -1000
Updated TODO list.
Figured the difference between the ped_TYPE_new() and
ped_TYPE_init() functions in libparted. The former is a convenience
wrapper for the latter. We really only need to call the _init()
function in the corresponding Python type's tp_init function.
commit 1981ce4726d60c67acef7e287d604644d481b632
Author: David Cantrell <dcantrell@redhat.com>
Date: Sat Nov 15 17:23:24 2008 -1000
Return pyparted version number as a 3-tuple.
Returning the version number as a string will make it more difficult
to do version enforcement in other programs (e.g., anaconda). Return
the pyparted version number as a 3-tuple of major, minor, and update.
commit 74cc37d10a6267779380a8fd38898bd2cf07fc82
Author: David Cantrell <dcantrell@redhat.com>
Date: Sat Nov 15 17:10:05 2008 -1000
Fix comments in header files.
_partedmodule.h -> _pedmodule.h
_exceptions.h -> exceptions.h
commit 1671ace99bf1ea09ab752a483cdbe557ac33ab71
Author: David Cantrell <dcantrell@redhat.com>
Date: Sat Nov 15 02:11:25 2008 -1000
Update pyfilesys.c functions to use object members.
For a number of methods in _ped.FileSystem, we were taking in the
params in the method call rather than reading them from self. Fixed
that in a number of functions. Take the value from self if we can,
otherwise, assume it's a parameter to the method.
commit ca47117a698643d6901cbeaa28a4ade6e1108b82
Author: David Cantrell <dcantrell@redhat.com>
Date: Sat Nov 15 02:00:25 2008 -1000
Move file system probing functions to _ped module.
The py_ped_file_system_probe() and py_ped_file_system_probe_specific()
functions are not tied to any particular FileSystem instance. They
take in a Geometry (and in the case of the _specific function, also
a FileSystemType), and return a FileSystem. Moved them up to the _ped
module where the rest of the non-object-specific functions live.
commit cb2377a82067741d776de7a8e0820b6b5d966e3e
Author: David Cantrell <dcantrell@redhat.com>
Date: Sat Nov 15 01:15:08 2008 -1000
Updated TODO list.
More brainstorming leads to more things on the TODO list.
commit 04327b439f3938a5978685ad5eb7fe2cc83c7e5e
Author: David Cantrell <dcantrell@redhat.com>
Date: Sat Nov 15 01:14:22 2008 -1000
Remove prototype for _ped_Device_new() function.
The .tp_new function for _ped_Device does not exist anymore since
we are not letting users instantiate the object, they have to call
_ped.get_device() to create a _ped_Device object.
commit d41af5f9c0fe1d0bc15b58d99502d98ee116686f
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Nov 13 14:45:34 2008 -1000
Bring _ped.Device closer to the way we want it to function.
That is, the type needs to exist and we need to be able to create
internally in _ped, but users cannot instantiate a new _ped.Device
and build it up programatically. Here's where we are as of this
commit:
In [1]: import _ped
In [2]: a = _ped.get_device("/dev/sda")
In [3]: a.length
---------------------------------------------------------------------------
AttributeError Traceback (most recent call last)
/home/dcantrel/pyparted/<ipython console> in <module>()
AttributeError: '_ped.Device' object has no attribute 'length'
In [4]: a
Out[4]: <_ped.Device object at 0xb7b7bd40>
In [5]: a.length
Out[5]: 20480544L
In [6]: b = _ped.Device()
./localtest: line 3: 13230 Segmentation fault ipython
[dcantrel@electron pyparted]$
You can see we have quite a bit more work to do.
commit a267589f8c3ca4bb14bb105e0b189cf5c5c6942b
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Nov 13 13:43:52 2008 -1000
Add placeholders for the other PyTypeObject members.
PyTypeObjects are complex structs. Fill out our structs with
placeholders for everything we are not currently using.
commit 218057c283de329c9640e991b014397c71b6799c
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Nov 13 11:00:40 2008 -1000
Use Py_XDECREF() on PyMemberDef members that are PyObjects.
For every type we have, there exists a PyMemberDef structure that
defines the type members, which are attributes. Everything is
ultimately a PyObject in the C API, which means that a PyMemberDef
struct can contain C primitives or other PyObjects. Structure
members that are PyObjects need to have a Py_XDECREF() call made
on them in the type's dealloc function so that the Python machine
will clean up properly.
commit 217d8232bc6a316258ea7d237f12a91611f7cdc1
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Nov 13 10:51:15 2008 -1000
Renamed PyDoc_STRVAR names to match method names.
commit 3373ec12a36b6c35336174ae65ee7c09f26367ba
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Nov 13 10:48:57 2008 -1000
Use underscore naming convention for _ped members.
_ped is a lowlevel module, meant to make writing the new parted
module easier. Keep the functions named closely to what they are
named in libparted for consistency.
Updated TODO list as well.
commit ee72fd75eb555ea63e09f183664ba5d3fa4cb263
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Nov 13 10:12:44 2008 -1000
Convert self to a PedDevice in py_ped_disk_clobber_exclude().
commit 102dff7a2f6cf912397d8a776f3d97fa8c13de49
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Nov 13 10:06:46 2008 -1000
Updated TODO list.
In object types where some of the members are PyObjects, we need to
make sure to Py_XDECREF() those members from the dealloc function.
commit 9f938e49cc25a18b42329ebe319a89c32a62cd86
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Nov 13 10:06:06 2008 -1000
Reference self object correctly in remaining source files.
Like the previous change to pydevice.c, do not read self through
PyArg_ParseTuple(). Use the first argument to the function, which
is PyObject *self.
commit 3c1d0438ab2f9c282d90ca5792a8730619947901
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Nov 13 04:23:59 2008 -1000
Fix vim control comments at the end of source files.
The vim in rawhide does not like the trailing */, so move that to
a new line.
commit 492c5d8c0586fb738b3b1fb54ee25780f0a81a38
Author: Chris Lumens <clumens@redhat.com>
Date: Fri Nov 14 15:32:05 2008 -0500
Require being root to import _ped.
commit 5f9a8aaa6308a06728b4dbc3026d48185c554885
Author: Chris Lumens <clumens@redhat.com>
Date: Fri Nov 14 11:32:02 2008 -0500
Make sure I don't forget to make test cases for the new _ped stuff.
commit 91de244235b4b64575dfa8f32d4068f0d80056c4
Author: Chris Lumens <clumens@redhat.com>
Date: Fri Nov 14 11:31:48 2008 -0500
Added another bug we need to think about.
commit 497e50922c50db965c4f0da2bab4d66ecaf7ed89
Author: Chris Lumens <clumens@redhat.com>
Date: Fri Nov 14 11:29:05 2008 -0500
Fix build warnings.
commit 0f76ab2b9b9f11493a3687b5a4355c2734ea56c1
Author: Chris Lumens <clumens@redhat.com>
Date: Fri Nov 14 11:20:04 2008 -0500
Update the _ped module documentation and reformat it in the source.
This completes the _ped documentation for everything that's currently in the
module and adds a description of the module itself. I also modified the
formatting of the docs in the source so it's easier to tell where line breaks
should go.
commit 51ac17d8ea8a515345418edf60475699bc452347
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Nov 13 14:45:52 2008 -1000
In pydevice.c, reference self correctly.
We were using PyArg_ParseTuple() and assuming that self would be the
first argument in the args array. This is incorrect. Self is given
to us as the first argument to the function, so use that any time we
need to reference self.
commit f02668abdc26cd4a1e403609e688f144c588fae6
Author: David Cantrell <dcantrel@electron.honolulu.burdell.org>
Date: Thu Nov 13 02:19:14 2008 -1000
Updated TODO list with non-instantiatable objects.
These objects need to be able to exist with methods, attributes, and
so on, but users should not be able to instantiate them. Setting
.tp_new to NULL as stated in the Python documentation does not work.
Might have to create a special .tp_new or .tp_init function that
throws an exception if the user tries to instantiate the object.
commit 74208a0d322385b8aae5e15c3c102d3bcfb76692
Author: David Cantrell <dcantrel@electron.honolulu.burdell.org>
Date: Thu Nov 13 02:13:39 2008 -1000
Move higher level Device methods to _ped module.
With the Device type, we have determined that in order to match the
functionality of libparted, we need to prevent the Device type from
being instantiated, but allow the user to get a Device type when
calling ped_device_get().
The following functions have moved to the _ped module:
_ped.Device.get() -> _ped.getDevice()
_ped.Device.probe_all() -> _ped.probeAllDevices()
_ped.Device.free_all() -> _ped.freeAllDevices()
Also fixed a double free that was occuring in py_ped_device_get().
commit 0444ce39b64490ccd24e7064c515f151b7b93d7c
Author: Chris Lumens <clumens@redhat.com>
Date: Thu Nov 13 15:59:27 2008 -0500
Update TODO list for test suite.
commit 09b3d24aedbf1a9da7964a65d11750cf5f6816fc
Author: Chris Lumens <clumens@redhat.com>
Date: Thu Nov 13 15:42:38 2008 -0500
Add test cases for all the easy stuff in pyunit.
The outstanding test cases to write all require PedDevice or PedGeometry,
so we should make sure those are working first.
commit 09a58f03c86b7af9de9f89308b3d0f3f96fffeec
Author: Chris Lumens <clumens@redhat.com>
Date: Thu Nov 13 15:42:07 2008 -0500
Fix checking for whether ped_unit_get_by_name gives us a good value.
commit 191587d6ebc7d46d49ffddd3fd6f6631b6225954
Author: Chris Lumens <clumens@redhat.com>
Date: Thu Nov 13 15:29:37 2008 -0500
Add more docs strings for all the unit stuff.
commit c52602afa516d7e278cb0acb4d26e96da866a22b
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Nov 13 10:08:06 2008 -1000
Do bounds checking for PedUnit input values.
We need to make sure a user hands us a valid PedUnit value, which
has to within the PED_UNIT_FIRST and PED_UNIT_LAST bounds,
inclusive.
commit 8b523d4645c370d6eaeb85fadd233f3ecf3ac277
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Nov 13 10:02:50 2008 -1000
Use 'long' for PedUnit.
PedUnit is an enum in libparted, which introduces size problems on
64-bit architectures.
commit 94af346006e2dffd9c1995102ce47e509966838e
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Nov 13 09:36:28 2008 -1000
Updated TODO list.
commit b48b2bc0a243853d5a062d330c79bea5a50670d1
Author: Chris Lumens <clumens@redhat.com>
Date: Thu Nov 13 11:16:41 2008 -0500
The beginnings of a working test suite for pyparted.
The test suite is all organized under tests/, one directory per major API
in the package (one for _ped, one for the old API, one for the new), one
file per module in each API. Then each file contains one test class per
method with multiple tests in each. The entire test suite will use python's
unittest framework and can easily be run with "make check" in the top level
of the source directory.
commit db938a876cd529d8cb3a4068c2d2a38865b1fefd
Author: Chris Lumens <clumens@redhat.com>
Date: Thu Nov 13 11:14:37 2008 -0500
Raise ZeroDivisionError when the divisor is zero, instead of exploding.
These were all found by writing the initial test suite. Seems like this
is going to be time well spent.
commit 4497cdb258d895363ef6d073c3bb8fbb1da2e99f
Author: Chris Lumens <clumens@redhat.com>
Date: Thu Nov 13 10:54:27 2008 -0500
Add docs strings for the natmath methods in the _ped module.
commit cd4a598842565bdbc682eb5f49a1f9aee891d437
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Nov 12 17:39:59 2008 -1000
Add vim settings to all of the .h and .c files.
commit c3582e877680a2e2bd02331a035f8add2ed064a5
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Nov 12 17:14:26 2008 -1000
Initialize all pointers to NULL.
Whenever we declare a new pointer, init it to NULL.
commit f3453f26c15b68543fa63e0d3513b711b172eb8e
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Nov 12 15:41:00 2008 -1000
Use 'z' in PyArg_ParseTuple() when reading strings.
Use 'z' in the PyArg_ParseTuple() format string. The 'z' value
will convert string values of None to NULL in C, which is what we
want.
commit a2c9998c1ed98f6be9483bf2c6dc77a831ecc27d
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Nov 12 15:08:44 2008 -1000
Use 'z' in PyArg_ParseTuple and fix ped_device_*_all() functions.
When reading strings with PyArg_ParseTuple(), use 'z' for the
format string so we get NULL if the string value is None in Python.
Fixed py_ped_device_probe_all() and py_ped_device_free_all() so
they do not expect any input parameters and always return None.
The functions in libparted take no parameters and are void.
commit eb7e97bff7f336718901ec91607d0845bb24f458
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Nov 12 13:07:30 2008 -1000
Updated TODO list.
Add entry for adding docstrings to _ped. Basically, every Py*
struct needs docstrings.
commit 2a3df9076398f7d7e718dac8c2858e2442339bec
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Nov 12 12:54:23 2008 -1000
Updated TODO list.
Moved all the exception things to be next to each other. Removed
some items that I don't think apply anymore. Everything pretty
much has a place now in the code.
commit e6d0f402f71dfa1dd2e315560c3328ff8454bf97
Author: Chris Lumens <clumens@redhat.com>
Date: Wed Nov 12 16:44:13 2008 -0500
Raise ZeroDivisionError instead of letting C explode if divisor is 0.
commit f85f2009ce9087d3a6cec8d74178c861e0906555
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Nov 12 10:28:28 2008 -1000
Wrote py_ped_unit_parse() and py_ped_unit_parse_custom()
These were the last of the pyunit.c functions that needed to be
written.
commit 585d1d2f225be64228e589b4670c57bd5b9eb9a6
Author: Chris Lumens <clumens@redhat.com>
Date: Wed Nov 12 15:27:55 2008 -0500
Add a skeleton PedDisk file.
commit f29ec18065f1a87a4db301bbf43288689128e799
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Apr 16 10:18:12 2008 -1000
Remove 'All rights reserved' from the boilerplates.
Apparently we aren't supposed to have this in the standard
license boilerplate.
commit f4c99102bcb30fd9063c795e8b65190315718dd6
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Nov 21 15:50:59 2007 -0500
Add my email address.
commit 9a69e5b3d0743fdeed9ec81b5851218b1bd015bc
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Nov 21 15:45:56 2007 -0500
Sign the WHY document.
commit b138cf73e79ada450833765d8f27ba78053b8e76
Author: Chris Lumens <clumens@redhat.com>
Date: Thu Nov 15 15:50:07 2007 -0500
Make sure the deprecated API raises the same exceptions as existing parted.
commit ad0cb4c5438d9ce7de0daf76991c4f7b922356e2
Author: Chris Lumens <clumens@redhat.com>
Date: Thu Nov 15 13:55:57 2007 -0500
Make properties for accessing the underlying _ped.Device attributes.
commit a021de4661dd6f24c1b8f7c6e8bb27246dc0005f
Author: Chris Lumens <clumens@redhat.com>
Date: Thu Nov 15 13:31:15 2007 -0500
Make sure the deprecated API raises the same exceptions as existing parted.
commit c107478bd8c4b5571902fd2c7886a348678f63a6
Author: Chris Lumens <clumens@redhat.com>
Date: Thu Nov 15 10:29:55 2007 -0500
Use the convenience functions for building return values throughout.
commit 2790ac2f961e8dea3b8102f9cbededf8a55a3b61
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Nov 14 17:22:31 2007 -0500
Added missing PedDevice.py
commit 8c91e5d1342bae3c58cdddff8da699da347a5b4e
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Nov 14 17:17:16 2007 -0500
Updated the to do list!
commit d09b6843dc6e1335590a746eb008b9dca9a9e3b2
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Nov 14 17:16:27 2007 -0500
Started PedDevice old-API class
Moved PedDevice class to the PedDevice module. The old pyparted named the modules and classes the same, which makes it a bit confusing. This is the start of the implementation of the deprecated API for PedDevice. Visibility is key for these old modules, which will require some fun meta class tricks.
commit 2a66fbe47f3e875799eb72f124a57b0f47a6f8cf
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Nov 14 17:15:14 2007 -0500
Remove double free.
commit 0061e8816334f081ac12c73bd312138657cb4c6d
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Nov 14 16:04:40 2007 -0500
Fix a typo
Py_DECRET -> Py_DECREF
commit b58221e4fc853d587203727af5c11294fd8acb52
Author: Chris Lumens <clumens@redhat.com>
Date: Wed Nov 14 15:55:10 2007 -0500
Free previously allocated memory in error handlers.
commit 0fc0992e98d6d45d28b4d950bb776178520fa656
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Nov 14 15:37:33 2007 -0500
Updated to do list.
commit 3a760e1c77a42bf137c68efe584e76c9a145c5fd
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Nov 14 15:33:55 2007 -0500
Add my email address to configure.ac
commit d78575836e2caf3e2141e12a92fa558b4fc48022
Author: Chris Lumens <clumens@redhat.com>
Date: Tue Nov 13 18:13:37 2007 -0500
Add lots more exception raising and error handling code.
commit 2851ef6bf357e0054101bf7b801fc57cf046f440
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Nov 13 16:41:56 2007 -0500
Use convenience function for handling strings.
Change occurencens of Py_BuildValue() for 's' to PyString_FromString().
commit a2c49fe08804dc765bf69b3566b8d20552db17ba
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Nov 13 16:35:24 2007 -0500
Moved methods to the object they correspond to
Reduced the _ped methods struct and moved most of the methods out to the corresponding object. Removed the Py_InitModule3() calls in the init function for _ped because those were driving over our method struct.
Updated the to do list with some new ideas. We have a problem with some of the natmath functions. Not sure where to put those. Also, we lack _ped_Unit now, but should we bring it back as a method container and nothing more?
commit 6b6431e169d1b056a02877923d05413c7ee1a191
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Nov 13 15:32:00 2007 -0500
Added set method for _ped_Timer and updated to do list
commit 22f97bc90fa931ef10583e2b132e1e5637354894
Merge: bf945c3 5f53c45
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Nov 13 15:25:26 2007 -0500
Merge branch 'master' of ssh://dcantrel@git.fedoraproject.org/git/hosted/pyparted
* 'master' of ssh://dcantrel@git.fedoraproject.org/git/hosted/pyparted:
Use more exact exceptions and error messages.
Use more exact exceptions and error messages.
Add a CreateException for all those places where we can't create an object.
commit bf945c3ef2c5c028117582f759491e3655ec8d98
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Nov 13 15:25:18 2007 -0500
Implemented set methods for a number of types in _ped
The following set methods have been written:
_ped_Device_set()
_ped_Partition_set()
_ped_DiskType_set()
_ped_FileSystemType_set()
_ped_FileSystem_set()
_ped_Geometry_set()
_ped_Alignment_set()
commit 5f53c456d35741761b0171f3c453a79ce2b677e7
Author: Chris Lumens <clumens@redhat.com>
Date: Tue Nov 13 14:16:31 2007 -0500
Use more exact exceptions and error messages.
commit 5bb98097e5fe45f25e7a53ded9875f7a15628d19
Author: Chris Lumens <clumens@redhat.com>
Date: Tue Nov 13 13:56:32 2007 -0500
Use more exact exceptions and error messages.
commit 12b245a260a89f8829ee4c71834e043f081e9724
Author: Chris Lumens <clumens@redhat.com>
Date: Tue Nov 13 13:56:06 2007 -0500
Add a CreateException for all those places where we can't create an object.
commit e22eef5203ceb26df6690810010614f0712cd6cd
Merge: 4935d63 68acd57
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Nov 13 13:44:24 2007 -0500
Merge branch 'master' of ssh://dcantrel@git.fedoraproject.org/git/hosted/pyparted
* 'master' of ssh://dcantrel@git.fedoraproject.org/git/hosted/pyparted:
Add error handling and exception raising to pynatmath.c.
Add an AlignmentException as well.
Add error handling and exception raising code to pytimer.c.
Add a new TimerException.
Add error checking to the results of the conversion functions.
Fix up some -Wall warnings.
commit 4935d63525c873c8998858135073c01e0a9cef4c
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Nov 13 13:44:16 2007 -0500
get and set method updates
The following changes are encapsulated in this diff:
- Update get method prototypes to use a void * as the last arg. We
create the member variable in the function, casted from closure.
- Add prototypes for set methods
- Stub out all set method functions in the C files
- Wrote the set method for _ped_CHSGeometry
commit 68acd576a5bdee3847eace6923b80693509957f8
Author: Chris Lumens <clumens@redhat.com>
Date: Tue Nov 13 13:36:08 2007 -0500
Add error handling and exception raising to pynatmath.c.
commit 161b9cbcca8ce9d3444341c8fd8267f60d6ded6c
Author: Chris Lumens <clumens@redhat.com>
Date: Tue Nov 13 13:35:52 2007 -0500
Add an AlignmentException as well.
commit 5eddc3b8f2a837aa92ebedb363e8f534024243e5
Author: Chris Lumens <clumens@redhat.com>
Date: Tue Nov 13 13:24:05 2007 -0500
Add error handling and exception raising code to pytimer.c.
commit 1b328c2cdab6e62f703a82af320f97f5f9ea2d8c
Author: Chris Lumens <clumens@redhat.com>
Date: Tue Nov 13 13:23:48 2007 -0500
Add a new TimerException.
commit 28bc88d4c2eb6825978a9ae7cfd71f7167bb5e4e
Author: Chris Lumens <clumens@redhat.com>
Date: Tue Nov 13 13:15:51 2007 -0500
Add error checking to the results of the conversion functions.
commit dcb320a73b15c4f2b3d4101efc3ce86d91ac0025
Author: Chris Lumens <clumens@redhat.com>
Date: Tue Nov 13 13:03:59 2007 -0500
Fix up some -Wall warnings.
commit 6f2aa642637a24e2347ac4b5f7a5792d7397258b
Merge: e33639e 53be40b
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Nov 13 13:02:48 2007 -0500
Merge branch 'master' of ssh://dcantrel@git.fedoraproject.org/git/hosted/pyparted
* 'master' of ssh://dcantrel@git.fedoraproject.org/git/hosted/pyparted:
Fill in the _ped_Whatever_init methods with kwarg processing code.
Fix raising an exception at the end of the parted lists.
commit e33639e70a094bced7afa0c64e66ded968e63092
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Nov 13 13:02:36 2007 -0500
Started set method for _ped_Device
commit 6407f5a218e8a7b0d93547a61daf12ade9f7e8fe
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Nov 13 13:01:33 2007 -0500
Wrote set method for _ped_Constraint
The setter for _ped_Constraint handles setting the max_size and min_size structure members.
commit 53be40b0e4264dbf9772b607521e1ea218d2aa1b
Author: Chris Lumens <clumens@redhat.com>
Date: Tue Nov 13 12:58:29 2007 -0500
Fill in the _ped_Whatever_init methods with kwarg processing code.
commit 2c5c5a61b1abe0815650abde5c98612106dc0b05
Author: Chris Lumens <clumens@redhat.com>
Date: Tue Nov 13 11:45:43 2007 -0500
Fix raising an exception at the end of the parted lists.
commit 28a8765d464e57d9cc16ef64d6fb2c0db5039542
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Nov 13 11:43:19 2007 -0500
Pass string as 2nd arg to PyDict_SetItemString()
For all of the ENUM() macro replacement code, pass a string as the second argument to PyDict_SetItemString().
commit 602e164737e3fd3e2980f6ff456730f8f9473d3c
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Nov 13 11:34:54 2007 -0500
Removed ENUM() macro
Just put the code in _pedmodule.c because I can't stand the ENUM() macro. I also updated the to do list and added some more fun things to work on.
commit acd31c7273ceb43353d243bed1e24f3e0e7d5ef4
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Nov 13 11:13:25 2007 -0500
Updated to do list.
commit 66fdeb6817e3660ebeb82f0f8665378c00c44c9f
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Nov 13 11:12:47 2007 -0500
Remove tp_alloc() use in _ped_Disk_new()
Use PyObject_New() rather than tp_alloc() when creating a new _ped_Disk
object.
commit fbb9444a2e0272afb9fd4ea158073859701042f6
Author: Chris Lumens <clumens@redhat.com>
Date: Tue Nov 13 01:04:02 2007 -0500
Pass the member name as the optional data to the getset method.
Also, I cleaned up the structure definitions to only specify what we are
overriding and updated the TODO list.
commit 9b5a440d90eaf7de97e64bb141e46591a491a62f
Author: Chris Lumens <clumens@redhat.com>
Date: Tue Nov 13 00:11:27 2007 -0500
Use _new functions instead of calling PyObject_New directly.
This fixes a bug where the conversion functions were returning objects of the
correct types, but the type checking on PyArg_ParseTuple was failing anyway.
I don't quite know why this was happening, but not going through the type
object functions must have confused Python's internals.
commit 522ee692f3335fefa028e54ff83a3e261058fa24
Author: Chris Lumens <clumens@redhat.com>
Date: Mon Nov 12 17:51:35 2007 -0500
Added ipython sessions showing a couple weird bugs.
commit 3c0b7a45aede993f228203f694e2c285a33de6d3
Author: Chris Lumens <clumens@redhat.com>
Date: Mon Nov 12 17:26:13 2007 -0500
Compare to NULL, not Py_None for optional arguments.
commit 04d79a37a5164df4693bb1bb54c303f526a36769
Author: Chris Lumens <clumens@redhat.com>
Date: Mon Nov 12 17:25:51 2007 -0500
Fix the build.
commit a0de38ac5a71258d8dca9a0e0be19f9173a44eee
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Nov 12 17:16:58 2007 -0500
get() methods for _ped_Partition and _ped_Timer
Wrote get methods for _ped_Partition and _ped_Timer to return the C primitives
in the Python data type.
commit ebf09297372f140f2359d97785f3a6da9f84824d
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Nov 9 18:00:09 2007 -0500
Add get method for C primitives in _ped_Alignment
commit 3f769cccb274634652657ab6fbdac388a46a439a
Author: Chris Lumens <clumens@redhat.com>
Date: Mon Nov 12 17:14:18 2007 -0500
Check the return values for all conversion functions.
commit e7a2fb7c8df37434d90a4b0d565bef8acc647075
Author: Chris Lumens <clumens@redhat.com>
Date: Mon Nov 12 17:01:48 2007 -0500
Add error handling and exception raising to pyconstraint.c.
commit 7650f25992e3dc23c27aa08112d46e3228f91770
Author: Chris Lumens <clumens@redhat.com>
Date: Mon Nov 12 15:17:50 2007 -0500
Timers are usually optional arguments, so treat them as such.
commit d79e69e26a4750e7d9bf77b6203aedc011f1f8eb
Merge: e5b33b6 f1604be
Author: Chris Lumens <clumens@redhat.com>
Date: Fri Nov 9 17:59:01 2007 -0500
Merge branch 'master' of ssh://clumens@git.fedoraproject.org/git/hosted/pyparted
commit e5b33b694ddf1f96a04d0a24282a3fa9d5c5d9da
Author: Chris Lumens <clumens@redhat.com>
Date: Fri Nov 9 17:58:50 2007 -0500
We have a lot more to work on now.
commit f1604bedc76e2961002e865dd8cb104fec09974b
Merge: c17adb8 258466a
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Nov 9 17:56:50 2007 -0500
Merge branch 'master' of ssh://dcantrel@git.fedoraproject.org/git/hosted/pyparted
* 'master' of ssh://dcantrel@git.fedoraproject.org/git/hosted/pyparted:
Add getattr methods for FileSystem and FileSystemType. Add error checking.
Create new ConstraintException and IOException.
commit c17adb80fa6259fb381ba515d1e8c629225325d4
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Nov 9 17:56:41 2007 -0500
Add get method for C primitives in _ped_Geometry
commit 258466a747c53408e4760d7e880eea6364fb322f
Author: Chris Lumens <clumens@redhat.com>
Date: Fri Nov 9 17:50:54 2007 -0500
Add getattr methods for FileSystem and FileSystemType. Add error checking.
commit 8ab545deabe1ff520f180faf87bd7c11f8695288
Author: Chris Lumens <clumens@redhat.com>
Date: Fri Nov 9 17:48:50 2007 -0500
Create new ConstraintException and IOException.
commit 50fcced4affd8507d26d3c79aa576fe39e552af5
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Nov 9 17:48:29 2007 -0500
Add get method for C primitives in _ped_Device
commit 81ea6822719d253b43ca88ee8150105c4fe90dc1
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Nov 9 17:38:00 2007 -0500
Add get method for C primitives in _ped_CHSGeometry
commit 56d8ebf8c3c71445c43ffb03a1f7a2697d025640
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Nov 9 17:31:06 2007 -0500
Fix line wrapping
Do not carry long lines for _ped_DiskType_getset[]
commit 709d4f8db3d0a454ebf8bc069e53632eba5e9b01
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Nov 9 17:24:28 2007 -0500
Move C primitives to get/set method for _ped_Constraint
commit 3fc411c04d1dd62dd7b7b79c64e1b4822516c6a0
Merge: ca66c57 761284d
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Nov 9 14:55:16 2007 -0500
Merge branch 'master' of ssh://dcantrel@git.fedoraproject.org/git/hosted/pyparted
* 'master' of ssh://dcantrel@git.fedoraproject.org/git/hosted/pyparted:
Add error handling to the pyunit functions.
commit ca66c57bfe3d3398d19254502162cfb549075f3e
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Nov 9 14:55:02 2007 -0500
Fix problems with the _ped_DiskType type
Removed C primitives from the members structure. Added a get method to
return Python data types for the C primitives stored in the _ped_DiskType
structure. Reduced the big type object structure so we don't have so many
0 lines.
commit 39daf3900306c619517608a6c1ef107d7d7c74f9
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Nov 9 14:53:05 2007 -0500
Correct PYTHONPATH in localtest script.
commit fe199044fc6f5918b00901d47052501ad448e359
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Nov 9 14:52:39 2007 -0500
Create new version functions
Changed version functions in _ped to libparted_version() and
pyparted_version(). They return strings containing the version numbers
of either libparted or pyparted. Added a function to parted called
version() that returns a dict containing both the libparted and pyparted
versions.
commit 761284de2aeb952233b37f124a84d10d382724e7
Author: Chris Lumens <clumens@redhat.com>
Date: Fri Nov 9 13:45:57 2007 -0500
Add error handling to the pyunit functions.
commit b2fdc8caba509a440696643417f63edacee9578c
Author: Chris Lumens <clumens@redhat.com>
Date: Fri Nov 9 11:56:30 2007 -0500
Raise an exception when there are no more DiskTypes or flags.
commit 9aab8d1746aea3ff1a69c1145755157b996b1036
Author: Chris Lumens <clumens@redhat.com>
Date: Fri Nov 9 11:54:04 2007 -0500
All the py_ped_partition_flag_* functions now work.
commit ebe52af02e483625eaadf85915d99ea661893445
Author: Chris Lumens <clumens@redhat.com>
Date: Fri Nov 9 11:53:20 2007 -0500
If no optional argument is given, don't pass None to the C bindings.
commit bed0e65716e1485c6ca69e7570bd637b1d9b549f
Author: Chris Lumens <clumens@redhat.com>
Date: Fri Nov 9 11:06:52 2007 -0500
Handle the provided disk type not being found by raising an exception.
commit a9223a6a9be49cd99e4dd83f7c7d427b00768b69
Author: Chris Lumens <clumens@redhat.com>
Date: Fri Nov 9 11:04:28 2007 -0500
Merge the two Unknown*TypeExceptions into a single one.
We're probably going to have a lot of places where a parted function can get
an unknown disk type, filesystem type, or whatever. It makes sense to just
have one exception for all these events instead of a whole pile. The caller
will know what sort of thing is Unknown.
commit 05a13e154594fc5c22c69066ee0f6a806389d323
Author: Chris Lumens <clumens@redhat.com>
Date: Thu Nov 8 22:56:39 2007 -0500
The correct way to specify a type is with O!, not O&.
commit 7c0ec2db8f0b3a839314c15578e6405a75459cde
Author: Chris Lumens <clumens@redhat.com>
Date: Thu Nov 8 22:45:57 2007 -0500
Add type checking to PyArg_ParseTuple.
This commit adds type references to most of the PyArg_ParseTuple calls
so that passing the wrong kind of PyObject as an argument will result in
a TypeError instead of unintended results.
commit b9f74f3dcf24077a53b12cfe0506180f13125749
Author: Chris Lumens <clumens@redhat.com>
Date: Thu Nov 8 20:56:54 2007 -0500
No more need for a .cvsignore file. Ignore compiled Python.
commit be83990f9f3147fc4594657c656ded280d3e4007
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Nov 7 18:02:14 2007 -0500
Make sure we return at the end of partedExnHandler()
commit f33df4f803fb88f0b48e363b052ecb5f566637d6
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Nov 7 17:31:07 2007 -0500
Remove remaining type handling calls for the long long types.
commit 98f9867bc7455a662a9aa5abfd2f30550e69f4be
Author: Chris Lumens <clumens@redhat.com>
Date: Wed Nov 7 17:26:11 2007 -0500
Handle libparted exceptions as well.
Added a libparted exception handler that catches those exceptions and then
either immediately raises python exceptions for serious bugs or sets global
flags so parted module methods can raise more specific exceptions with some
useful information. This is untested.
commit f2a773b3030500e907e82b16c235167a95bff6d4
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Nov 7 16:48:47 2007 -0500
Modify _ped types to account for long long changes.
Modified _ped_Constraint, _ped_Device, _ped_Partition, _ped_Geometry, and
_ped_Alignment to store long longs as long long and not their old _ped
type.
commit 08bcbd93b55be9b708a6163d1cebf899ea31740f
Author: Chris Lumens <clumens@redhat.com>
Date: Wed Nov 7 16:24:39 2007 -0500
Add lots of error checking to the conversion funtions.
commit abeadcc87a7807752a4cbfe46b9ac8b454c330ff
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Nov 7 16:04:31 2007 -0500
Change simple Python _ped types back to just long longs.
Change the following back to just long longs:
_ped.PartitionType
_ped.Sector
_ped.PartitionFlag
_ped.DiskTypeFeature
commit 08483005be8e2c26d6394b000969f0486edd4998
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Nov 7 15:04:06 2007 -0500
Removed conversion functions for long long types
Removed conversion functions for:
_ped.PartitionType
_ped.Sector
_ped.PartitionFlag
_ped.DiskTypeFeature
commit b9f98f78af6a709cec1ffc3604fef089707a5bc4
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Nov 7 14:59:19 2007 -0500
Removed the _ped.Unit type from the _ped module
Removed the _ped.Unit type and all calls to conversion routines. We are
just storing the PedUnit as a long long in Python since that maps easily
over to the C API.
commit d174ae2e4706d93c100284317aa484f47a870366
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Nov 7 14:58:38 2007 -0500
Removed the _ped.Unit() and PedUnit conversion functions
commit 3972cc74a27d06a8ec0dca48408f5372b395d61a
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Nov 7 14:57:58 2007 -0500
Remove _ped.Unit() functions
Removed _ped_Unit2PedUnit() and PedUnit2_ped_Unit() since those are just
long longs in both C and Python.
commit 88f1773c50df192384dcf0285c7afd6edf87f683
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Nov 7 14:30:09 2007 -0500
Use libparted functions to make libparted types in convert.c
Rather than manually creating the libparted structures in convert.c, use
the appropriate new function in libparted if it exists for that type. The
following changes were made:
in _ped_Disk2PedDisk(), call ped_disk_new() to make the return type
in _ped_DiskType2PedDiskType(), use ped_disk_type_get()
in _ped_FileSystem2PedFileSystem(), use ped_file_system_open()
in _ped_Partition2PedPartition(), use ped_partition_new()
commit 66a120a22a6a8428c22eda58d027cb3776e950c6
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Nov 7 14:26:39 2007 -0500
Updated to do list with old pyparted stuff
Walked the old pyparted API and updated the to do list with what I found in
all the MethodDef structures. We may or may not have to implement all of
them, but I don't know right now.
commit 19664a0c33f43659a525cbdc5b778d0da5a24dfb
Author: Chris Lumens <clumens@redhat.com>
Date: Wed Nov 7 14:24:25 2007 -0500
Raise an exception if an unknown filesystem type is requested.
commit 8d39ca5202df44fbe122c1e772b91fb4f1c9229b
Author: Chris Lumens <clumens@redhat.com>
Date: Wed Nov 7 14:15:45 2007 -0500
Move exceptions into their own header file so they are visible in all sources.
commit 0e4a6346d2f4de3a8a10b0de8d0fc9655a73c4fc
Author: Chris Lumens <clumens@redhat.com>
Date: Wed Nov 7 13:41:48 2007 -0500
Never call ped_file_system_type_destroy.
All the file_system_type code in libparted returns pointers to elements in
an internal linked list, so we never want to free those things.
commit e6c127f2a37959681b4d3c83cd7c20afd6de6724
Author: Chris Lumens <clumens@redhat.com>
Date: Wed Nov 7 10:24:29 2007 -0500
Fill in all the easy methods in the old API and add docs strings.
commit 58f09f31f275f6d8c81df749d3dc7b8c9b8eb6ec
Author: Chris Lumens <clumens@exeter.boston.redhat.com>
Date: Tue Nov 6 17:23:39 2007 -0500
Fix syntax errors on deprecated API functions.
commit 9952c820317d6209b7248d24d443b2751dc25ba8
Author: Chris Lumens <clumens@exeter.boston.redhat.com>
Date: Tue Nov 6 17:17:25 2007 -0500
Define away functions that are not yet implemented in libparted.
commit 235f3f5885fe8c30a3c4ff03cb21589122611d5b
Author: Chris Lumens <clumens@exeter.boston.redhat.com>
Date: Tue Nov 6 17:16:16 2007 -0500
Revert "ped_file_system_destroy isn't implemented in libparted, so define it away for now."
This reverts commit fe6e58b9d2f6b3277793d38f22925181063d9548.
commit 15746bef1a537a5cb740dd30747c86376bd5136c
Author: Chris Lumens <clumens@exeter.boston.redhat.com>
Date: Tue Nov 6 17:13:51 2007 -0500
ped_file_system_clobber_exclude is a static function. We can't implement it.
commit e418868b2b5556172bc6397f8819b5c7ba5bd8dd
Author: Chris Lumens <clumens@exeter.boston.redhat.com>
Date: Tue Nov 6 17:10:49 2007 -0500
Fix typos.
commit fe6e58b9d2f6b3277793d38f22925181063d9548
Author: Chris Lumens <clumens@exeter.boston.redhat.com>
Date: Tue Nov 6 17:10:41 2007 -0500
ped_file_system_destroy isn't implemented in libparted, so define it away for now.
commit 5d0c0fe7f2c3593d38ae4c8c5525c3b31c5fc8bf
Author: Chris Lumens <clumens@exeter.boston.redhat.com>
Date: Tue Nov 6 17:09:27 2007 -0500
Fix typo.
commit b9acfcbd92887f9f51c1b8a63811c013df90ae19
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Nov 6 16:40:53 2007 -0500
Remove block_sizes code and implemented remaining functions.
Implemented:
_ped_FileSystemType2PedFileSystemType()
_ped_PartitionFlag2PedPartitionFlag()
_ped_PartitionType2PedPartitionType()
PedPartitionType2_ped_PartitionType()
Removed code referencing the block_sizes structure members. We're not storing
those in the Python data types.
commit 6a2018108d635bab346d7261d410c5e5e4607ec4
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Nov 6 16:39:31 2007 -0500
Remove block_sizes from the Python data types.
We don't want to store the block_sizes array in the Python data type. Why?
Several problems. First, it's not really used in libparted that I can find,
so maybe it's a good candidate for removal. Second, it is stored as an
array of ints, but with no NULL terminator and no count of how many elements
are in the array. So how does that even work? My guess is it doesn't because
it was never used elsewhere in the libparted code.
commit cd05d80c863c242fe4ef45ffe589b9836206f5e6
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Nov 5 17:03:06 2007 -0500
More conversion functions.
Implemented:
PedFileSystemType2_ped_FileSystemType()
PedPartition2_ped_Partition()
PedPartitionFlag2_ped_PartitionFlag()
Also made some other code cleanups for types and casting and stuff.
commit e1f42c4c8a6901af756c7be34430a9481170b11f
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Nov 5 16:16:34 2007 -0500
Remove unused members and add more conversion functions
Implemented PedDisk2_ped_Disk(), _ped_DiskType2PedDiskType(), and
_ped_Partition2PedPartition(). Removed assignments to structure
members that no longer exist (next, prev, part_list, and so on).
commit 191a20e543d767d9b4f17eea21f8ab356d470095
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Nov 5 16:14:38 2007 -0500
Clean up Python members structure
Removed next, prev, part_list, and other members that have been removed from
the Python _ped data structures.
commit 189b64d3105b656bfc95ea32f97ed4eeda1a8d09
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Nov 5 16:05:38 2007 -0500
Removed libparted-specific data structure elements
Removed libparted-specific data structure elements from the Python _ped data
structures.
commit 6850c95dbe9b3fb01a2b0d58f9b5beb067dc2661
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Nov 5 13:41:07 2007 -0500
Implemented convert functions for PedDiskTypeFeature
Write _ped_DiskTypeFeature2PedDiskTypeFeature() and
PedDiskTypeFeature2_ped_DiskTypeFeature(). Modified prototypes since we only
deal with PedDiskTypeFeature as an enumerated value.
commit 09457882d144cfc721d16a220c2da11d71b51bd3
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Oct 31 17:29:22 2007 -0400
Remove pyexception.c stuff from TODO.
We are not reimplementing the code from exception.c in libparted in pyparted. We will use native Python exceptions.
commit 5c7cef0c17ca24ef2b480d484f51bd3cd3fa284b
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Oct 31 17:22:13 2007 -0400
Started _ped_Disk2PedDisk() and more comments.
Started the _ped_Disk2PedDisk() function. Need to figure out how to copy
over the block_sizes and disk_specific struct members correctly. Added a
more detailed comment at the top explaining the approach to memory management
with these functions.
commit 73eda002485e3b6a4811d3b888921f2168979a35
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Wed Oct 31 16:10:21 2007 -0400
Remove unncessary return value checking code.
commit f5894b1f4fe60a069e636eb4ec8f1cb0f8af5ebe
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Wed Oct 31 16:06:30 2007 -0400
Remove unnecessary return value checking code. Formatting fixes.
commit defa8e5304228808eb611c9a026607aa59102341
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Wed Oct 31 16:04:48 2007 -0400
Remove unnecessary return value checking code.
commit e57d76e0f932658537e50e7162129c2814bfa242
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Wed Oct 31 16:03:05 2007 -0400
free() -> ped_file_system_type_destroy()
commit 70401be8e65ac48ff8255d87676db822910e09ff
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Wed Oct 31 16:01:11 2007 -0400
Free up libparted types that we create
commit 7adea50e7318026331e5c4c185e1072ce70cbd48
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Wed Oct 31 13:53:38 2007 -0400
Remove unnecessary return value checking. Formatting fixes.
commit e91a592114a8622928aef3f6ecabef2ce8b3505e
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Wed Oct 31 13:47:28 2007 -0400
Remove unnecessary return value checking at the end of the functions. We want Python exceptions to be in force.
commit 781accc1902a9aad4801f250545365bc74087ae3
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Tue Oct 30 17:11:04 2007 -0400
Add the many many many methods definitions for the _ped module so we have ways to run the C functions we've been working on.
commit 12c4dbc69b46d53167965b8e3957cb350bdb69dd
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Tue Oct 30 16:11:46 2007 -0400
Implemented the remaining functions in pydisk.c:
py_ped_disk_add_partition()
py_ped_disk_remove_partition()
py_ped_disk_delete_partition()
py_ped_disk_delete_all()
py_ped_disk_set_partition_geom()
py_ped_disk_maximize_partition()
py_ped_disk_get_max_partition_geometry()
py_ped_disk_minimize_extended_partition()
py_ped_disk_next_partition()
py_ped_disk_get_partition()
py_ped_disk_get_partition_by_sector()
py_ped_disk_extended_partition()
Updated to do list (remove fdasd.h and vtoc.h stuff).
Stubbed out new convert functions:
_ped_PartitionFlag2PedPartitionFlag()
PedPartitionFlag2_ped_PartitionFlag()
_ped_PartitionType2PedPartitionType()
PedPartitionType2_ped_PartitionType()
commit 1d92887fae843c0d6189c5d0470d5e180f5a99e4
Merge: e9acf9b e497675
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Tue Oct 30 11:50:57 2007 -0400
Merge branch 'master' of ssh://dcantrel@git.fedoraproject.org/git/hosted/pyparted
commit e9acf9b4398b6aea451826cad952550e93045758
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Tue Oct 30 11:50:51 2007 -0400
Removed functions that have been implemented.
commit cf946bb286c2cbbc60aa7a2286881b4699170333
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Tue Oct 30 11:49:56 2007 -0400
Implemented the following functions in pydisk.c:
py_ped_disk_duplicate()
py_ped_disk_print()
py_ped_disk_get_primary_partition_count()
py_ped_disk_get_last_partition_num()
py_ped_disk_get_max_primary_partition_count()
py_ped_partition_new()
py_ped_partition_destroy()
py_ped_partition_is_active()
commit e497675810e4f9266a37f2c47a00a890abca1f92
Author: Chris Lumens <clumens@exeter.boston.redhat.com>
Date: Tue Oct 30 11:33:32 2007 -0400
Add more error checking to pynatmath.c and return booleans where appropriate.
commit e5bd76c459970c9c8c5ecf273375469c7283ed7b
Author: Chris Lumens <clumens@exeter.boston.redhat.com>
Date: Tue Oct 30 11:27:20 2007 -0400
Fill in the remaining functions in pygeom.c.
Also added more error checking and changed most functions to return booleans
instead of integers where it makes sense.
commit 9501e344cfa7742a7a060ff9fe61dbc8daf39183
Author: Chris Lumens <clumens@exeter.boston.redhat.com>
Date: Tue Oct 30 11:00:37 2007 -0400
Finish the last of the pydevice.c functions, add more error checking.
commit 600e37dbe808fa73d677a47477fe2db67aafda66
Merge: bba36c0 e6b346f
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Tue Oct 30 10:31:35 2007 -0400
Merge commit 'e6b346f40b9e9b9d3060f2ddbcf76455c5efd3c5'
Conflicts:
src/pytimer.c
commit bba36c05450b29becbb8ad4fa4599f12512e5f42
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Tue Oct 30 10:27:17 2007 -0400
Fuck git.
commit 3552b977629885bd8c9e6fc8c4b77206661d4b5a
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Tue Oct 30 10:21:12 2007 -0400
Updated to do list.
commit c2b6bdcedf82b711e098e381f2bd4b11b6611499
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Tue Oct 30 10:20:46 2007 -0400
Formatting cleanups and change FIXME comment to XXX.
commit 308298e2a47ed7ee0855d20cde711fe4e4a3c144
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Tue Oct 30 10:20:18 2007 -0400
Change FIXME comments to XXX so we are consistent throughout the code. For 1:1 functions that have not been implemented yet, throw a NotImplementedError exception rather than just returning None.
commit 18115bd6d06f11127e2b5258b818510bfc7f046e
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Tue Oct 30 10:17:47 2007 -0400
Define the NotNeededException exception.
commit e6b346f40b9e9b9d3060f2ddbcf76455c5efd3c5
Author: Chris Lumens <clumens@exeter.boston.redhat.com>
Date: Tue Oct 30 10:14:02 2007 -0400
Add all the simple pytimer.c functions.
commit 7302df6f621efd902ac60e9332314b1901f5e617
Author: Chris Lumens <clumens@exeter.boston.redhat.com>
Date: Tue Oct 30 10:13:52 2007 -0400
Build fixes.
commit 4d12564f3cd4d511af3cacd482d9adacfa70aaf4
Author: Chris Lumens <clumens@exeter.boston.redhat.com>
Date: Tue Oct 30 10:13:32 2007 -0400
Add more conversion function stubs.
commit 31c3469f8af1dce0f47c82c9b729a2567d3b7dd3
Merge: 4d85ec7 e11b5ec
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Mon Oct 29 16:58:40 2007 -0400
Merge branch 'master' of ssh://dcantrel@git.fedoraproject.org/git/hosted/pyparted
commit 4d85ec77604f9283752d2151e79edc16667fd60e
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Mon Oct 29 16:58:27 2007 -0400
Added the following functions to pydisk.c:
py_ped_disk_type_register(), py_ped_disk_type_unregister(),
py_ped_disk_type_get_next(), py_ped_disk_type_get(),
py_ped_disk_type_check_feature(), py_ped_disk_probe(),
py_ped_disk_clobber(), py_ped_disk_clobber_exclude(),
py_ped_disk_new(), py_ped_disk_new_fresh(), py_ped_disk_destroy(),
py_ped_disk_commit(), py_ped_disk_commit_to_dev(),
py_ped_disk_commit_to_os(), py_ped_disk_check(),
py_ped_partition_is_busy(), py_ped_partition_get_path()
commit e11b5ec3fed017020ad6d84b3e98c85caf58d9dc
Author: Chris Lumens <clumens@exeter.boston.redhat.com>
Date: Mon Oct 29 16:53:08 2007 -0400
Filled in loads of the conversion functions.
commit 43c037d9c9fb0e5f2146952a324859d9ed54d4d0
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Mon Oct 29 15:39:38 2007 -0400
Clean up the AUTHORS file a bit.
commit 87e5e98bbcac4bcf184415faf64cd27f335fe234
Author: Chris Lumens <clumens@exeter.boston.redhat.com>
Date: Mon Oct 29 15:14:24 2007 -0400
Fill in all the functions in pyfilesys.c.
commit c46614865f3c69500d91102604b32c2792e1ee3d
Author: Chris Lumens <clumens@exeter.boston.redhat.com>
Date: Mon Oct 29 15:14:10 2007 -0400
More stubs for conversion functions.
commit c161e52d6e8d68717e97f8320803e753625bc543
Author: Chris Lumens <clumens@exeter.boston.redhat.com>
Date: Mon Oct 29 14:27:50 2007 -0400
Fix a typo.
commit c95bb72e6675698a09acb325eaf2ad9a790d1d6a
Author: Chris Lumens <clumens@exeter.boston.redhat.com>
Date: Mon Oct 29 14:07:33 2007 -0400
Use "s" instead of "S". Return booleans from functions where it makes sense.
commit 8c0e6a667ee4f19f96c742ddb44aee010cb3b019
Author: Chris Lumens <clumens@exeter.boston.redhat.com>
Date: Mon Oct 29 13:48:36 2007 -0400
Forgot to add myself as an author.
commit 6667c491cb9130e17e5afb2268a2740b62a95d2a
Merge: 5cc1b13 3782a4f
Author: Chris Lumens <clumens@exeter.boston.redhat.com>
Date: Mon Oct 29 13:48:18 2007 -0400
Merge branch 'master' of ssh://clumens@git.fedoraproject.org/git/hosted/pyparted
commit 5cc1b13be23dac97ae53dad78a1d4adedbcea60c
Author: Chris Lumens <clumens@exeter.boston.redhat.com>
Date: Mon Oct 29 13:46:13 2007 -0400
Fill in all the easy functions in pydevice.c.
commit ea1c2b5d65fb87844061e7efea29c5c5eee59255
Author: Chris Lumens <clumens@exeter.boston.redhat.com>
Date: Mon Oct 29 13:46:00 2007 -0400
Add another stub conversion function.
commit 3782a4fe77e2ae487c3843e1a13cab6c8cf63538
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Mon Oct 29 13:38:00 2007 -0400
Updates to the WHY document.
commit 14b6432eba5a0186e874b8891dec1a8d36141efc
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Mon Oct 29 13:35:39 2007 -0400
More to do.
commit a3415d7e2206620c78d7efc008ec8f69e3e90cb5
Author: Chris Lumens <clumens@exeter.boston.redhat.com>
Date: Mon Oct 29 12:12:20 2007 -0400
Fix up a couple more of the redundant calls to PyObject_New.
commit 9055ed7f42bea23dbc5b15ac067069ed31f329f2
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Sun Oct 28 17:27:45 2007 -0400
Remove the pyparted.spec.in file. We don't need to ship a spec file.
commit 0f7325fd1b7bb28d049b7b543ef8144030c39d48
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Sun Oct 28 17:27:25 2007 -0400
Add email addresses to the boilerplates.
commit 521116d8182829751666f7d176569284f650de60
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Sun Oct 28 13:07:59 2007 -0400
Remove -Werror from the AM_INIT_AUTOMAKE macro.
commit 7f18e8065648c3af5d6bf3218cb7f07789e579c7
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Sun Oct 28 13:07:41 2007 -0400
Ignore *.o files and files that end with tilde.
commit c36ee910aa138533ac172ab230670eb218ba3187
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Mon Oct 22 14:34:32 2007 -0400
Remove WHY from the MAINTAINERCLEANFILES list.
commit 18bf2a8ee41caa8d7cb4241097fab1d61559650b
Author: Chris Lumens <clumens@exeter.boston.redhat.com>
Date: Fri Oct 12 12:14:51 2007 -0400
Add my name to that file I did stuff in.
commit db9e85b24d89e0e1ac245a61a3316d2a48ca1b54
Author: Chris Lumens <clumens@exeter.boston.redhat.com>
Date: Fri Oct 12 12:13:11 2007 -0400
Remove redundant calls to PyObject_New.
commit 8ad7da28af35e75a47659ddbf5e32c4ed7db1e7c
Author: Chris Lumens <clumens@exeter.boston.redhat.com>
Date: Fri Oct 12 11:56:09 2007 -0400
Fix the typos that were causing compile warnings in pynatmath.c
commit dda8576289e3825af209c554e43125e570ac495b
Author: Chris Lumens <clumens@exeter.boston.redhat.com>
Date: Fri Oct 12 11:39:33 2007 -0400
And remove the completed functions from the list.
commit 16cd8a879cf6c804edbcf37ef7763bef0c5c1e6b
Author: Chris Lumens <clumens@exeter.boston.redhat.com>
Date: Fri Oct 12 11:38:54 2007 -0400
Added all the easy functions in pygeom.c.
commit 2801638d132148883a8f152adcee49dca4764d32
Author: Chris Lumens <clumens@exeter.boston.redhat.com>
Date: Fri Oct 12 11:38:40 2007 -0400
Use the libparted functions for freeing objects instead of our own.
commit 6cd28e7e499305358c0413aa1a7a9e8c85104090
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Thu Oct 11 17:35:34 2007 -0400
Ignore the ChangeLog.
commit c74f62e4261d2d8eb46c7bd8d16079a5d38953cd
Merge: d36f433 a3e0281
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Thu Oct 11 14:10:21 2007 -0400
Fixed merge conflicts.
commit a3e0281a4aefc19fcc1fbdff61901e808aaa0d0c
Author: Chris Lumens <clumens@exeter.boston.redhat.com>
Date: Thu Oct 11 14:06:51 2007 -0400
Fix copy-and-paste errors.
commit 3bb296f0acad4a06b416a915570979345a2d4e20
Author: Chris Lumens <clumens@exeter.boston.redhat.com>
Date: Thu Oct 11 14:00:10 2007 -0400
And remove everything I did from the TODO list.
commit 89d0412796a11c1d58173e4382ba8bc136b2d4a4
Author: Chris Lumens <clumens@exeter.boston.redhat.com>
Date: Thu Oct 11 13:59:28 2007 -0400
Add most of the functions for the pynatmath.c module.
commit d36f43359c11cc50b491dc1fa8f9dee6582677a8
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Thu Oct 11 13:53:44 2007 -0400
In the convert.c functions, use the ped_*_new() functions to create new libparted objects. Except for the conversion to PedDevice where we use ped_device_get() and hand it the device path. Removed all of the _free_*() functions since libparted provides those already.
commit b0a4f50b29be24a5bd8c8aef8fabe8210005768b
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Thu Oct 11 13:20:11 2007 -0400
Remove calls to _free_Ped*() functions and just use the ped_*_destroy() functions to handle free'ing those objects.
commit 7d882fef5f83f49bac0f01047bff788569be221d
Author: Chris Lumens <clumens@exeter.boston.redhat.com>
Date: Thu Oct 11 10:35:25 2007 -0400
Add funtions for converting to _ped_Sector, _ped_Unit, and a stub for
_ped_Geometry.
commit c0def772c5a4e6bb1bd63ea3e3043b832951946f
Author: Chris Lumens <clumens@exeter.boston.redhat.com>
Date: Thu Oct 11 10:34:20 2007 -0400
Add all the pynatmath.c functions to the module list.
commit 7f2d9fcbb5a8dc95940242ec73bb341fcbda48a6
Author: Chris Lumens <clumens@exeter.boston.redhat.com>
Date: Wed Oct 10 19:31:30 2007 -0400
Fix a couple typos that were breaking import.
commit dc16d3827df5eae2764cf223df3fd349472e81c1
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Wed Oct 10 17:22:20 2007 -0400
Added missing '_new' part of the libparted library calls.
commit 7a00cc71fc2d589003a175690f26ea0dbd9e14ca
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Wed Oct 10 17:21:50 2007 -0400
Stub for PedConstraint2_ped_Constraint().
commit e45712ed08ccac72a50e5f78ba8741b1fbb497dd
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Wed Oct 10 17:21:27 2007 -0400
_ped_PartitionFlagType_Type_obj -> _ped_PartitionFlag_Type_obj
commit 9667343ce42c353a2a337e9b6ec3b7e871544ae9
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Wed Oct 10 16:54:38 2007 -0400
Call appropriate object destroy function in libparted to take care of objects allocated by libparted library calls and returned to us.
commit 8592987fdd64144809ceb55f1a6b639dc8b83059
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Wed Oct 10 16:39:10 2007 -0400
Correct some typos in pyconstraint.c.
commit c0d12f107644ecc1c7dd52bc03a59709b1c5ada8
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Wed Oct 10 15:18:00 2007 -0400
Updated the to do list.
commit 7d33b2f5206d5671f0e3df5458f012afd6514af9
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Wed Oct 10 15:17:35 2007 -0400
Wrote the pyconstraint.c 1:1 pass-thru functions.
commit 318bedf0775d807ce71303cde2ce7225fa83f060
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Wed Oct 10 15:17:12 2007 -0400
Ignore *.loT files.
commit 1167b0c8e001f57e9e986b9b5490aa174ce3bb0c
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Tue Oct 9 15:29:26 2007 -0400
Use PyObject_New() in the _init() functions.
commit c8073b4a3109956a986fe0a30570d9d878a720f5
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Tue Oct 9 15:28:25 2007 -0400
Call _free_X() functions to free libparted types.
commit 2af1314fa81e05597aba51583d9ee0123dbe3f0d
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Tue Oct 9 13:09:07 2007 -0400
Use PyObject_Del() in the dealloc functions.
commit 90ca2d341c82403ddc54f53131d468d64d1dd381
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Tue Oct 9 13:05:25 2007 -0400
New coding style in place for the 1:1 function mappings. Basically, the functions will call PyArg_ParseTuple() to get the input parameters. Any sanity checking will take place and exceptions raised as necessary. The object return will be allocated using PyObject_New(). The _ped_X2Y() functions will be used to convert input parameters to libparted types so that libparted can be called. After the libparted call, the appropriate _free_X() function will be called to free memory that was allocated for the libpared call.
The conversion functions all take in PyObject pointers now and cast within, so when we call PyArg_ParseTuple(), we store directly to PyObjects rather than the specific _ped_X types.
commit 6c0e3e3d4585d404adb95a1773a0b4bbc9f7d031
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Tue Oct 9 13:02:11 2007 -0400
Can't return NULL in a void function, just return.
commit c823f0ee730bd78c37d9a8072500631fd11b3d00
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Tue Oct 9 13:01:46 2007 -0400
Include pyunit.h.
commit e19c756a7aece0e97e27f6b93cf39f03e87252cf
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Tue Oct 9 11:21:48 2007 -0400
Remove bad #endif comment from the end of the file (copied prototypes over from the header to use to start functions).
commit 77e3e26d435a07dd362815bea0eb7e5a1f43e12a
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Tue Oct 9 11:21:06 2007 -0400
Note that start_range and end_range are _ped.Geometry() objects.
commit 87855382865fe831044e2180b9da44f9633f2504
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Tue Oct 9 11:20:00 2007 -0400
Implemented remaining conversion functions and added a few more.
commit 4ceee4db7286cf4911b3ba6888c93e7457cfcf14
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Tue Oct 9 01:11:41 2007 -0400
Working on _ped_X object to libparted typedef conversion functions to easily handle converting between the Python and C datatypes. Not done yet (in fact, this won't compile, but I'm going to bed right now).
commit d17da76f857e808e722a73c4145d5d44f6dd9e26
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Tue Oct 9 00:58:07 2007 -0400
Documentation updates.
commit 9e31ac6ef2fa430321921204e20a5115ca058e14
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Tue Oct 9 00:57:46 2007 -0400
Stubs for:
_ped_Alignment2PedAlignment()
_ped_Constraint2PedConstraint()
_ped_Geometry2PedGeometry()
_ped_Sector2PedSector()
commit 3bd42c271fb9de7d2d97bbfe223992586b85806a
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Tue Oct 9 00:56:45 2007 -0400
Implemented py_ped_constraint_init().
commit 860bc65faf0bbd0d9302bf833d17676bbbf8596c
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Tue Oct 9 00:56:23 2007 -0400
Minor style cleanups and added a note to remind myself to check in to whether or not I need a particular incref.
commit a41cceea24392ed9eb30528305e9fab17a6bf451
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Mon Oct 8 15:31:34 2007 -0400
Some comments to make it a little more clear as to what _ped_Device2PedDevice() is doing.
commit 588ff6b65d66332f60ce8568445ed0e55e1185d4
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Mon Oct 8 15:31:05 2007 -0400
Upper bounds check with PED_UNIT_LAST rather than PED_UNIT_TEBIBYTE.
commit 3c8220a060a4c0c7c352e98ff9dba406d60bf255
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Mon Oct 8 15:20:43 2007 -0400
Stubbed out all remaining pass-thru functions that need to be written. All functions that have not been written yet have a FIXME comment and they return a Py_None right now.
commit 4447442e823e25b6a5f4592d27644d4e27582866
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Mon Oct 8 14:37:09 2007 -0400
Ignore the generated pyparted.spec file.
commit e7439b657ebbbf91a14c4c3d81175dc239127423
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Mon Oct 8 14:36:40 2007 -0400
Implemented the following pass-thru functions for unit.h in libparted:
py_ped_unit_set_default()
py_ped_unit_get_default()
py_ped_unit_get_size()
py_ped_unit_get_name()
py_ped_unit_get_by_name()
py_ped_unit_format_custom_byte()
py_ped_unit_format_byte()
py_ped_unit_format_custom()
py_ped_unit_format()
commit 07975c95017f62ec4c335d4090e41f67133ea78e
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Mon Oct 8 14:35:16 2007 -0400
Store the next struct member of _ped_Device as a PedDevice pointer rather than a _ped_Device pointer.
commit bdbeb4fa45369a3c70d8fc18f24bc2395e1f7f76
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Mon Oct 8 14:34:33 2007 -0400
The convert.c file (and header file) define a set of convenience functions that convert to and from the Python types and libparted typedefs. For example, converting a _ped.Device(), which is a _ped_Unit pointer in C, to a PedDevice for libparted.
commit 9b0feaa10f4c9112a2e7ce26484cd985ceb70b50
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Mon Oct 8 14:32:39 2007 -0400
Add WHY to the list of files to include in the distribution.
commit dca7a5476a813e776afff0dbf1591ba58fd5f2d6
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Sat Oct 6 18:34:22 2007 -0400
Stubbed out the new __init__.py for the new parted module. For starters, we need to reimplement all of the existing pyparted functionality as-is and mark it as deprecated (with the exception of the many enums).
commit ebdd22501530a9dc9623d7cb127b6ac1a926537f
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Fri Oct 5 17:20:19 2007 -0400
Stubbed out _ped.FileSystemType() and _ped.FileSystem() objects.
commit d55690c16b2c4c035aaf32c15b00733ec55eb376
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Fri Oct 5 16:31:37 2007 -0400
Stubbed out _ped.Disk(), _ped.DiskType(), and _ped.DiskTypeFeature() objects.
commit 83819f97d6fee528052957c30b0641e898a5c300
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Fri Oct 5 15:14:52 2007 -0400
Renamed all static PyTypeObject types to the format _ped_NAME_Type_obj where NAME would be Device, Disk, Partition, PartitionType, Unit, Sector, and so on.
commit 6a58be32b2cf8836bc489c93e63863a8fbcc965d
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Fri Oct 5 14:57:41 2007 -0400
Ignore autom4te.cache.
commit a949266055b4e2a8ce32da428887e987cd29b337
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Fri Oct 5 14:57:10 2007 -0400
Stubbed out _ped.PartitionType(), _ped.PartitionFlag(), and _ped.Partition() objects.
commit e23a6fa47689725c075a560972a9ba26a6e7e0c0
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Fri Oct 5 14:13:30 2007 -0400
Explaining why I'm not using an automatic binding generator.
commit 365a5084b406dc0bdcb9175509a258e53eebf477
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Fri Oct 5 11:51:41 2007 -0400
Stubbed out _ped.Constraint() object.
commit 66e355984344b058c521c2a97e309fc1e16db09d
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Fri Oct 5 11:37:22 2007 -0400
Stubbed out _ped.Alignment() object.
commit 96210b61f9d28bafe1e1ea7c52b7df431ebdacbb
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Fri Oct 5 11:29:12 2007 -0400
Implemented stub for the _ped.Geometry() object type.
commit 65061557e29760b0886a3567ac4700ce104011ea
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Thu Oct 4 22:56:41 2007 -0400
PyObject_HEAD_INIT(NULL) -> PyObject_HEAD_INIT(&PyType_Type)
commit e61295131be5834e187e9307da8799d0b2ee1185
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Thu Oct 4 22:56:18 2007 -0400
Added _ped.Timer() object. Stub mostly for now.
commit ec0df169e57183bc726e8b8b11c9dd3fbd5d9d5c
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Thu Oct 4 22:55:06 2007 -0400
Move AC_PROG_LIBTOOL to after AC_HEADER_STDC.
commit 1878c34ee71bd791fc0f3b576bdf7fc33a59817e
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Thu Oct 4 22:25:43 2007 -0400
Make sure Python module files are installed directly to site-packages and not a subdirectory in site-packages.
commit 25c99a42d6f89aa97c5ac47f0b266f0442807c5e
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Thu Oct 4 21:51:05 2007 -0400
Return -1 instead of NULL on error for int functions. Fix py_ped_unit_get_default() so it returns a new _ped.Unit() object containing the PedUnit we get from libparted.
commit fe0b19c4ddbe38e6ff3e5924be7c710a0869a3f8
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Thu Oct 4 21:50:34 2007 -0400
Return -1 instead of NULL for error conditions on int functions.
commit 2f71538cf7a3efd97f5719a362d62848584cc72c
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Thu Oct 4 21:49:54 2007 -0400
Change PyObject_HEAD_INIT(NULL) to PyObject_HEAD_INIT(&PyType_Type).
commit b784ac7267ae166c16ee6a73123866af56b603c2
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Thu Oct 4 19:31:26 2007 -0400
Ignore vim swap files.
commit 3d673361db82774abda159686d23558d82a14358
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Thu Oct 4 19:31:02 2007 -0400
Stubbed out pydevice.h types (PedSector, PedCHSGeometry, and PedDevice). Enough so that pyunit.c can be finished out later.
commit eb0fbf3c7a7f109e54ec0666d2239031a496b1f6
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Thu Oct 4 19:30:01 2007 -0400
Removed what was in pyconstraint.h for now since it'll all change shortly.
commit e4b4427996bc5b6c116aa6f9b9de883f6b0fde43
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Thu Oct 4 19:29:34 2007 -0400
Updated to do list (this happens a lot).
commit 0436ae5e907348e3af3211f9986c33d9ed6a5a3f
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Thu Oct 4 16:24:49 2007 -0400
Yeah, I did this.
commit a91ef22a105fd918c6e1c7fca5f3283eea55b66b
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Thu Oct 4 16:12:31 2007 -0400
Removed items that have been completed.
commit 84b41ff53041d22d0e2d809490b7281cdeae1a3e
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Thu Oct 4 16:12:17 2007 -0400
Added the _ped.Sector and _ped.CHSGeometry types to the module initialization.
commit 1a015b58e7ce8d785e63ccd8aa6ea3c951448eb6
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Thu Oct 4 16:08:10 2007 -0400
Forgot to commit the pydevice.c changes for src/Makefile.am.
commit ba76de0f8f2413cb9caccfd407cf2e12bb23bef6
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Thu Oct 4 16:07:44 2007 -0400
Added pydevice.c and pydevice.h and made modifications to the automake files as necessary. pydevice defines the PedSector and PedCHSGeometry types for now, but will be the main 1:1 point for device.h in libparted.
commit 715f74288aa0f0c908ddce2a3bdfd990a6683798
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Thu Oct 4 16:01:14 2007 -0400
More detailed listing of the types and functions that need to be created for the _ped module.
commit 9fd5648a5b06583b75be7be5c765e7651617ddab
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Thu Oct 4 16:00:47 2007 -0400
Simple script to fire up Python so I can find the _ped module just built here.
commit f105bb05a2971de650da1e335ebda14c8e3e6ad8
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Thu Oct 4 16:00:25 2007 -0400
Ignore even more junk.
commit 28aabfc6268181ca0236bf16f9ec6c28df121401
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Thu Oct 4 14:50:56 2007 -0400
Ignore more junk.
commit f08e3305e63fb0ddf621dea6d71b49117e5ed126
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Thu Oct 4 14:49:36 2007 -0400
Ignore junk.
commit 1a4fcc693563c5b764ecde7b98df7935b3dd7bf0
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Thu Oct 4 14:31:54 2007 -0400
Added get/set methods for the 'val' member of the _ped.Unit object. Also started filling in more functions in pyunit.c.
commit 4f8f10eb904dfdcf77fc3319b0a6012b0fee3d81
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Thu Oct 4 13:25:37 2007 -0400
Some docs.
commit f3dc0fa50627f32270de58314feb54f64ec1e2a8
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Thu Oct 4 13:25:16 2007 -0400
Define the ENUM macro for easily bringing over enumerated types from libparted. This is more or less the same as REGISTER_ENUM from the previous pyparted.
commit 21db8d925033964d6946cfeb2c27fd5361e1f99b
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Thu Oct 4 13:24:47 2007 -0400
Renamed partedmodule.c to _pedmodule.c. Added pyunit stuff.
commit 8768ea1934119f38594cf63bfc8f9180e9a9da44
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Thu Oct 4 13:23:45 2007 -0400
automake/autoconf updates.
commit f90a34efc5fd14939e8a3ff34612ea20c525b0c8
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Thu Oct 4 13:23:02 2007 -0400
Added pyunit.h and pyunit.c, which are the Python 1:1 function mappings for libparted/unit.c.
commit 9283a5de2bd5f3f5d74958a94a46fff1a54afc6e
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Wed Oct 3 11:36:01 2007 -0400
Updated to do list again.
commit 23b0d1eb9745a93cb7dc69426d10126d02102b07
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Tue Oct 2 15:06:31 2007 -0400
Forgot one other change to _pedmodule.c.
commit aa3b79eef334088d96f3f31e031de9b5004e5e4c
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Tue Oct 2 15:02:32 2007 -0400
_partedmodule -> _pedmodule
commit 0bdfd5b30954555a5f0ecb44e96d9c780fe5d3b7
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Tue Oct 2 15:00:09 2007 -0400
Change the name of the _parted module to _ped.
commit 10498deece42a4cf37d25b8abe9973119bbca4cc
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Tue Oct 2 14:59:51 2007 -0400
Change argument list to PyObject *s, PyObject *args.
commit 8aae12f58a251692273d368f050a7eb10b369fd7
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Tue Oct 2 14:48:00 2007 -0400
Removed old files.
commit c484bc02c4e858fc3017d0ad04e1c512a012ad44
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Tue Oct 2 14:47:53 2007 -0400
Added new pyconstraint.h and pygeom.h, which are in progress.
commit f7d3488d1a82d378643df05000cf9dd6b558cd0e
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Tue Oct 2 14:47:17 2007 -0400
Started new _partedmodule.c in src directory. Shortened source file list in Makefile to only those sources that are valid now.
commit 3706c385b36abc76adebb3f1979fc2ed656c08d9
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Tue Oct 2 14:46:32 2007 -0400
Renamed partedmodule.h to _partedmodule.h, started over. Removed references to old include files.
commit dd9f5eef5df52d7105060d7c3b696d9a832f4cf8
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Tue Oct 2 14:20:11 2007 -0400
Removed old headers.
commit 73d15059d5de348b58ea3a9a686c9195eb74ab24
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Tue Oct 2 13:52:31 2007 -0400
Renamed mkrelease.sh to the more appropriate bootstrap name.
commit 81a160c747ac3e35f64b898c66b69cdc6ace8271
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Tue Oct 2 13:51:34 2007 -0400
In my projects, I let the revision control system track the ChangeLog. Removed the static ChangeLog.
commit 1ba58164334fe40e36e7ee217b53bc8794accbd4
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Tue Oct 2 13:47:27 2007 -0400
So I think we're getting somewhere. The automake checks are in place to find Python and libparted and we actually link the module correctly.
commit a91c92d2c541a249e8e80c53b916544314f53798
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Tue Oct 2 13:46:58 2007 -0400
More things on the to do list.
commit a1700f1835a91f92d128443a0ca7b81b9a3e0e58
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Tue Oct 2 13:46:36 2007 -0400
Make _partedmodule.so.
commit f55054c657834eda229e0c7b12b3e3356df033cc
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Tue Oct 2 13:43:48 2007 -0400
Do not run make distclean. Also, the m4 directory will be there.
commit b281109f8dce5bc0ef33391fe75d6a3c07bc55de
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Tue Oct 2 13:29:08 2007 -0400
Updates for libparted automake checks.
commit 1ba56ea7102bf61f3c5bf8b84e60208d30652e16
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Tue Oct 2 13:08:20 2007 -0400
Renamed partedmodule.c to _partedmodule.c. The C module is only going to be used by the higher level Python modules rather than directly by users.
commit 2faea7bcf8ab42139deb3373de05191f55888061
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Tue Oct 2 13:05:39 2007 -0400
More automake clean ups.
commit 881e6564b6d1bce6ce7d04eab96a6ab7a31ee5ee
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Tue Oct 2 13:05:14 2007 -0400
Documentation updates.
commit 676ec45f549bc9a8aa95bd199ae9a1bdb3e907b3
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Mon Oct 1 22:48:40 2007 -0400
We won't be tracking the INSTALL file since the standard one will work fine. Expand the list of files for 'make maintainer-clean'.
commit c21c275f479fa94b7210511b3242486be6b155f4
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Mon Oct 1 16:10:57 2007 -0400
Shorten the MAINTAINERCLEANFILES list.
commit f0d53d1c75c2f3a2dca2b4e418b58e9909d9fe36
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Mon Oct 1 16:10:28 2007 -0400
LIBPARTED -> libparted in configure output.
commit 4b6a944b7e2f07969f33c9febc89e76244cbd284
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Mon Oct 1 16:09:13 2007 -0400
A to do list, like there's some sort of point to it.
commit 5a0e625f6d577d02fd2fbd74cde463b9e59912b5
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Mon Oct 1 15:52:30 2007 -0400
Now have it generating the autoconf/automake environment without any errors, but I'm not sure it actually works now.
commit 078ffbc9eb2d4c711d0d689d2220be07c3607b2a
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Mon Oct 1 15:51:45 2007 -0400
Checks for Python on the system (m4 macros from gnome-python-2.20.0).
commit 884f2971add70470640fab734dc4cb55396b479c
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Mon Oct 1 15:26:32 2007 -0400
Correct src and include makefile targets.
commit 502a7f5147100d5c220b3308fabbaf82cb4fb54d
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Mon Oct 1 15:21:39 2007 -0400
More autoconf/automake changes.
commit 521d9c330d15c5cb57dc9921c21b57745b4f2b9e
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Mon Oct 1 14:42:52 2007 -0400
Create the m4 subdirectory if it doesn't exist.
commit 8b3955ef5be6ad6d4c37796e96866984d1fecad0
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Mon Oct 1 14:40:00 2007 -0400
Beginnings of the autoconf/automake transition for the source code.
commit c81068394e7bfda870e3bcdf704081ccb96e2219
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Mon Oct 1 14:38:47 2007 -0400
Updated documentation (or at least indicated that I'm working on it).
commit 5502f996cb593d02da523250d8fc1001915f25f1
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Mon Oct 1 13:50:35 2007 -0400
Moved source files to src/ subdirectory.
commit 4b98c68eede18659bf32946dbb666467f49606bc
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Mon Oct 1 13:49:56 2007 -0400
Moved header files to include/ subdirectory.
commit 37130fbdbbd78bae98fccc637557bcfe00fdb7e9
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Fri Aug 10 17:08:29 2007 -0400
tar is no longer a target, remove from .PHONY
commit 9bd4c817d7036b242842b22b580231a607551c23
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Fri Aug 10 16:55:37 2007 -0400
Modify the TAG variable so it doesn't replace . with _ in tag names.
commit 5639e79bdf225a70ff5cd4c2e43aa81a7c4f7a92
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Fri Aug 10 16:50:49 2007 -0400
New version.
commit cc4ae2ac3aefdc21f9b111ed57cd9ecc10e27e5f
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Fri Aug 10 16:22:26 2007 -0400
List other authors of the software.
commit 4e4c238352f34189d052c0754839a1f3f1c4bd7c
Author: David Cantrell <dcantrel@mortise.boston.redhat.com>
Date: Fri Aug 10 16:22:15 2007 -0400
Relicense pyparted as GPL version 2 or any later version.
commit da593c8fc451b791134e04e00b2f035286e544d8
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Jun 14 19:12:54 2007 +0000
* pyparted.spec: Bump version.
* pyparted.spec: Clean up wording in package description,
BuildRequire pkgconfig (#226337).
commit d227e6958fe6f82d6e554fae5c300da1796586bb
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Jun 14 18:19:15 2007 +0000
* pyparted.spec: Bump version.
* pyparted.spec: Remove buildroot as first step in install section.
commit ae0f5cb13331d4a46001bb123e65244f69ba1abe
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Apr 23 17:20:22 2007 +0000
* Makefile: Inherit CC and CFLAGS from calling environment.
* pyparted.spec: Pass %{optflags} and %{__cc} to make process in %build.
commit b6fe07a7cd87b0046b13d9838a32ce4821c9986a
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Apr 20 16:31:54 2007 +0000
Forgot DESTDIR.
commit fd258cdbe1bec03dbc9b06eddc287d9497252670
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Apr 20 15:51:03 2007 +0000
Use correct libdir (/usr/lib or /usr/lib64).
commit 29118a97b22de57234b8c0ad9875bd299691af47
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Apr 20 15:43:59 2007 +0000
Add -fPIC to CFLAGS.
commit 56289951e3a8ec24eaefb2a8bf3370e793b87b2c
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Apr 20 15:35:05 2007 +0000
gz -> bz2
commit 4b8224de4d9036a4338b5fc63ed8fad2259be70c
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Apr 20 15:31:58 2007 +0000
Correct changelog entry date.
commit ed29069b02defe4ac34dd3208650e76216ec403a
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Apr 20 15:29:56 2007 +0000
Remove stuff related to PedConstraint object (work in progress, post-F7).
commit faffe420d84d4eb9c2c269c6ddbe768c0a83f806
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Apr 20 15:28:36 2007 +0000
Bump version.
commit 7e8f8ae2b0e64b8dcaac24d2070bd669ac53c47f
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Apr 20 15:28:07 2007 +0000
* partedmodule.c: Whitespace cleanups.
* AUTHORS: Note where to file bugs.
* pyparted.spec: Merge review cleanups.
commit 9888d49cf576de822ec1dc974ac7ff7d6abcac82
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon Mar 19 20:19:44 2007 +0000
* Makefile.am, configure.in, autogen.sh: Remove autotools stuff.
* Makefile: Add simple Makefile.
* pyparted.spec: Clean up for Fedora packaging guidelines, require
parted >= 1.8.4.
commit f718e19e40e3314b5add9d4c6016415500b685ba
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Mar 16 21:13:12 2007 +0000
Bump release.
commit 0feef9f07b91809ba4286ba73ed629769ebab150
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Feb 8 17:28:48 2007 +0000
* Thu Feb 08 2007 David Cantrell <dcantrell@redhat.com> - 1.8.5-1
- Define and use python_sitearch rather than python_sitelib
commit 1f2971923144a49ff8468d5c82c188f79a3fbbb4
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Feb 8 16:30:30 2007 +0000
* Thu Feb 08 2007 David Cantrell <dcantrell@redhat.com> - 1.8.4-1
- Use preferred BuildRoot (package review)
- Define and use python_sitelib macro (package review)
commit 743cceb0ec72e78cabbc4850f3260125e9395f7a
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Jan 12 19:45:33 2007 +0000
Required parted-1.8.2 or higher.
commit 3efeffc3650dc5cfd51a96327b144e5e9c4c54d7
Author: Jeremy Katz <katzj@redhat.com>
Date: Wed Jan 10 20:38:29 2007 +0000
2007-01-10 Jeremy Katz <katzj@redhat.com>
* pyparted.spec: Bump version.
* pygeometry.c (py_ped_geometry_dealloc): Use PyObject_DEL instead
of PyMem_DEL
* pyfilesystem.c (py_ped_file_system_type_dealloc): Likewise.
* pyexception.c (py_ped_exception_dealloc): Likewise.
* pydisk.c: Likewise.
* pydevice.c: Likewise.
* pyconstraint.c (py_ped_constraint_dealloc): Likewise.
commit 9de99c4a28d0e51451e4ed1226668b6f3b979b98
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Dec 14 16:49:51 2006 +0000
Pass s->dev rather than s to ped_device_destroy().
commit 668e67a1f685af28aa492007d994d9bf8c04e242
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Dec 14 16:05:40 2006 +0000
Require parted-1.8.1.
commit f142930628f72d28383f0f50a64752cfc1704d95
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Dec 14 16:04:55 2006 +0000
* pydevice.c: Add py_ped_device_destroy() function so we can call
ped_device_destroy() in libparted.
commit 99120149f55740c90fd98800091c51e895bf326c
Author: David Cantrell <dcantrell@redhat.com>
Date: Thu Nov 30 20:50:10 2006 +0000
* pyparted.spec: Bump version. Determine Python version to enable in
the %build section rather than assuming 2.4. Makes the source RPM
more easy to move between distribution releases.
commit 6ce55879a9b501b789c93bd3845acdaaecd04fe6
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri Nov 17 21:13:05 2006 +0000
Bump version.
commit 9e84031f77c63cd51d64b5b01e81828bf0cc7610
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Aug 30 18:02:06 2006 +0000
Reference source URL on people.redhat.com
commit b3fc15cfabaeca55814bb049e042eedc7606c07c
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Aug 30 17:59:18 2006 +0000
Tag for real.
commit e720e4e56b112ca99e2589e3e57ee573573ce40d
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Aug 30 17:57:38 2006 +0000
Make sure we don't get %{?dist} in CVS tags.
commit 792cfdf062b054b7aec3b17bb42b7dc30dd41570
Author: David Cantrell <dcantrell@redhat.com>
Date: Wed Aug 30 17:54:58 2006 +0000
* Wed Aug 30 2006 David Cantrell <dcantrell@redhat.com> - 1.7.3-1
- Include parted/constraint.h in required header files
* Wed Aug 30 2006 David Cantrell <dcantrell@redhat.com> - 1.7.2-2
- Require parted-1.7.1 or higher
commit d2fa7dc73a072dc7a19ac69c202475329c393636
Author: David Cantrell <dcantrell@redhat.com>
Date: Tue Jul 25 17:22:53 2006 +0000
Add HPSERVICE, PALO, PREP, and MSFT_RESERVED to partition types list.
commit ce7370e3e395c57acccaee1d900da65d63886460
Author: David Cantrell <dcantrell@redhat.com>
Date: Mon May 29 14:31:42 2006 +0000
Bump version.
commit c5bb884efb45077f3cd89fa3329eb5124d7e6ef9
Author: David Cantrell <dcantrell@redhat.com>
Date: Fri May 19 20:44:16 2006 +0000
* pyparted.spec: Bump version. Require parted >= 1.7.0.
commit 9f06f76055d61b037c95d80f65f9d0ae4a3e4ded
Author: Chris Lumens <clumens@redhat.com>
Date: Mon Dec 12 14:54:17 2005 +0000
Resync with package cvs.
commit b038c1d8cbae08e3796c0150b7b36a4da9f7e1b8
Author: Peter Jones <pjones@redhat.com>
Date: Fri Nov 11 22:04:01 2005 +0000
bump version to 1.6.10-1
commit 3b807d517143356096f3a3cf8fa3c217b4069406
Author: Peter Jones <pjones@redhat.com>
Date: Fri Nov 11 22:02:29 2005 +0000
update lots of classes to be new-style so I stop pulling my hair out.
commit 180f7247974322839522da3e9a830fe7541c9a47
Author: Peter Jones <pjones@redhat.com>
Date: Fri Nov 11 22:00:51 2005 +0000
update cflags and changelog
commit e8e58b2cb9d4850e6d02f1d2f33759f107526a97
Author: Peter Jones <pjones@redhat.com>
Date: Fri Nov 11 21:13:15 2005 +0000
- minor fixes for PedGeometry
- convert PedPartition to a new-style class
commit 0893a2464d1c26896386f690e1ebd1890017452b
Author: Peter Jones <pjones@redhat.com>
Date: Fri Nov 11 20:41:01 2005 +0000
- make PedGeometry a new-style class
- use descriptors for start/end/length
commit db00f08f950d4d5ef60bd0496068bb9184308769
Author: Chris Lumens <clumens@redhat.com>
Date: Wed Aug 31 21:12:04 2005 +0000
Rebuilt for new parted library version.
commit 63374432354c408e42f9cda8f4250d524ac778a3
Author: Chris Lumens <clumens@redhat.com>
Date: Wed Mar 16 20:07:55 2005 +0000
Doesn't hurt to update the changelog too.
commit 807038a2e8aa78154c347ab38c8bc772cb2a9e06
Author: Chris Lumens <clumens@redhat.com>
Date: Wed Mar 16 20:02:58 2005 +0000
Updated for gcc4 and python2.4. Fixed build warnings.
commit 8f66960a81453ff64cc3cf0aa19433ea5234d4f1
Author: Jeremy Katz <katzj@redhat.com>
Date: Tue Dec 14 20:55:48 2004 +0000
2004-12-14 Jeremy Katz <katzj@redhat.com>
* pyparted.spec: Bump version.
* partedmodule.c: add support for sx8 devices
commit be0aca3c9b03b334c44027fe8f212e551447ab99
Author: Jeremy Katz <katzj@redhat.com>
Date: Tue Aug 17 14:55:03 2004 +0000
2004-08-17 Jeremy Katz <katzj@redhat.com>
* pyparted.spec: Bump version and requirements
* pydevice.c (py_ped_device_getattr): heads, sectors, cylinders
are for the bios geometry form (update to work with parted >= 1.6.12)
commit 2fedd8383aa642d6b1cc7c4f5de3c1126aa314fe
Author: Jeremy Katz <katzj@redhat.com>
Date: Thu Jul 22 07:39:54 2004 +0000
already been built as -2. *sigh*
commit 2d7718078ae4958949801a9b1ed6d43fc9682387
Author: Jeremy Katz <katzj@redhat.com>
Date: Thu Jul 22 07:38:09 2004 +0000
build on ppc64 again
commit 3577fb18cb2d4422f7126a23ce1ca57419fb91bc
Author: Jeremy Katz <katzj@redhat.com>
Date: Thu May 13 19:36:01 2004 +0000
fix build for newer versions of gcc (fix from Jeff Law)
commit 45b9730ef48668a52d983bba80bc6af0ff2299f4
Author: Jeremy Katz <katzj@redhat.com>
Date: Tue Mar 16 21:32:34 2004 +0000
2004-03-16 Jeremy Katz <katzj@redhat.com>
* partedmodule.c: make sure PARTITION_PROTECTED gets defined (#118451)
commit 6b054beac29b7927540214d6492208dfdfd70d0f
Author: Jeremy Katz <katzj@redhat.com>
Date: Fri Mar 12 21:50:15 2004 +0000
actually do the tagging
commit 9cfe9e5587805b771fcfa1bd2a781e6bd3c1c205
Author: Jeremy Katz <katzj@redhat.com>
Date: Fri Mar 12 21:49:53 2004 +0000
excludearch ppc64 for now
commit 61a6870559b4ccce591ba164c4756586f45bd979
Author: Jeremy Katz <katzj@redhat.com>
Date: Fri Mar 12 21:48:18 2004 +0000
add .cvsignore
commit 6c33ee6924ce8b82d14993c3b6b3856f967db2ad
Author: Jeremy Katz <katzj@redhat.com>
Date: Fri Mar 12 21:46:05 2004 +0000
use that autofoo
commit 168abb796d414f1d2538a60a6a4d3599c8cb2e94
Author: Jeremy Katz <katzj@redhat.com>
Date: Fri Mar 12 21:06:23 2004 +0000
versioned requires, buildrequire python-devel
commit 5c2add338e2b9b722a37ed24d780de8f08f1c435
Author: Jeremy Katz <katzj@redhat.com>
Date: Fri Mar 12 21:02:27 2004 +0000
Initial revision
|