1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803
|
from rpython.rtyper.lltypesystem import lltype, llmemory
from rpython.flowspace.model import mkentrymap, checkgraph, Block, Link
from rpython.flowspace.model import Variable, Constant, SpaceOperation
from rpython.tool.algo.regalloc import perform_register_allocation
from rpython.tool.algo.unionfind import UnionFind
from rpython.translator.unsimplify import varoftype, insert_empty_block
from rpython.translator.unsimplify import insert_empty_startblock, split_block
from rpython.translator.simplify import join_blocks
from rpython.rlib.rarithmetic import intmask
from collections import defaultdict
def is_trivial_rewrite(op):
return (op.opname in ('same_as', 'cast_pointer', 'cast_opaque_ptr')
and isinstance(op.args[0], Variable))
def find_predecessors(graph, pending_pred):
"""Return the set of variables whose content can end up inside one
of the 'pending_pred', which is a list of (block, var) tuples.
"""
entrymap = mkentrymap(graph)
if len(entrymap[graph.startblock]) != 1:
insert_empty_startblock(graph)
entrymap = mkentrymap(graph)
pred = set([v for block, v in pending_pred])
def add(block, v):
if isinstance(v, Variable):
if v not in pred:
pending_pred.append((block, v))
pred.add(v)
while pending_pred:
block, v = pending_pred.pop()
if v in block.inputargs:
var_index = block.inputargs.index(v)
for link in entrymap[block]:
prevblock = link.prevblock
if prevblock is not None:
add(prevblock, link.args[var_index])
else:
for op in block.operations:
if op.result is v:
if is_trivial_rewrite(op):
add(block, op.args[0])
break
return pred
def find_successors(graph, pending_succ):
"""Return the set of variables where one of the 'pending_succ' can
end up. 'block_succ' is a list of (block, var) tuples.
"""
succ = set([v for block, v in pending_succ])
def add(block, v):
if isinstance(v, Variable):
if v not in succ:
pending_succ.append((block, v))
succ.add(v)
while pending_succ:
block, v = pending_succ.pop()
for op in block.operations:
if op.args and v is op.args[0] and is_trivial_rewrite(op):
add(block, op.result)
for link in block.exits:
for i, v1 in enumerate(link.args):
if v1 is v:
add(link.target, link.target.inputargs[i])
return succ
def find_interesting_variables(graph):
# Decide which variables are "interesting" or not. Interesting
# variables contain at least the ones that appear in gc_push_roots
# and gc_pop_roots.
pending_pred = []
pending_succ = []
interesting_vars = set()
for block in graph.iterblocks():
for op in block.operations:
if op.opname == 'gc_push_roots':
for v in op.args:
if not isinstance(v, Variable):
continue
interesting_vars.add(v)
pending_pred.append((block, v))
elif op.opname == 'gc_pop_roots':
for v in op.args:
if not isinstance(v, Variable):
continue
assert v in interesting_vars # must be pushed just above
pending_succ.append((block, v))
if not interesting_vars:
return None
# If there is a path from a gc_pop_roots(v) to a subsequent
# gc_push_roots(w) where w contains the same value as v along that
# path, then we consider all intermediate blocks along that path
# which contain a copy of the same value, and add these variables
# as "interesting", too. Formally, a variable in a block is
# "interesting" if it is both a "predecessor" and a "successor",
# where predecessors are variables which (sometimes) end in a
# gc_push_roots, and successors are variables which (sometimes)
# come from a gc_pop_roots.
pred = find_predecessors(graph, pending_pred)
succ = find_successors(graph, pending_succ)
interesting_vars |= (pred & succ)
return interesting_vars
def allocate_registers(graph):
interesting_vars = find_interesting_variables(graph)
if not interesting_vars:
return None
regalloc = perform_register_allocation(graph, interesting_vars.__contains__)
assert regalloc.graph is graph
regalloc.find_num_colors()
return regalloc
def _gc_save_root(index, var):
c_index = Constant(index, lltype.Signed)
return SpaceOperation('gc_save_root', [c_index, var],
varoftype(lltype.Void))
def _gc_restore_root(index, var):
c_index = Constant(index, lltype.Signed)
return SpaceOperation('gc_restore_root', [c_index, var],
varoftype(lltype.Void))
def make_bitmask(filled, graph='?'):
n = filled.count(False)
if n == 0:
return (None, None)
bitmask = 0
last_index = 0
for i in range(len(filled)):
if not filled[i]:
bitmask <<= (i - last_index)
last_index = i
bitmask |= 1
assert bitmask & 1
if bitmask != intmask(bitmask):
raise GCBitmaskTooLong("the graph %r is too complex: cannot create "
"a bitmask telling than more than 31/63 "
"shadowstack entries are unused" % (graph,))
# the mask is always a positive value, but it is replaced by a
# negative value during a minor collection root walking. Then,
# if the next minor collection finds an already-negative value,
# we know we can stop. So that's why we don't include here an
# optimization to not re-write a same-valued mask: it is important
# to re-write the value, to turn it from potentially negative back
# to positive, in order to mark this shadow frame as modified.
assert bitmask > 0
return (last_index, bitmask)
def expand_one_push_roots(regalloc, args):
if regalloc is None:
assert len(args) == 0
else:
filled = [False] * regalloc.numcolors
for v in args:
index = regalloc.getcolor(v)
assert not filled[index]
filled[index] = True
yield _gc_save_root(index, v)
bitmask_index, bitmask = make_bitmask(filled, regalloc.graph)
if bitmask_index is not None:
# xxx we might in some cases avoid this gc_save_root
# entirely, if we know we're after another gc_push/gc_pop
# that wrote exactly the same mask at the same index
bitmask_c = Constant(bitmask, lltype.Signed)
yield _gc_save_root(bitmask_index, bitmask_c)
def expand_one_pop_roots(regalloc, args):
if regalloc is None:
assert len(args) == 0
else:
for v in args:
index = regalloc.getcolor(v)
yield _gc_restore_root(index, v)
def expand_push_roots(graph, regalloc):
"""Expand gc_push_roots into a series of gc_save_root, including
writing a bitmask tag to mark some entries as not-in-use.
(If regalloc is None, it will still remove empty gc_push_roots.)
"""
for block in graph.iterblocks():
any_change = False
newops = []
for op in block.operations:
if op.opname == 'gc_push_roots':
args = [v for v in op.args if isinstance(v, Variable)]
newops += expand_one_push_roots(regalloc, args)
any_change = True
else:
newops.append(op)
if any_change:
block.operations = newops
def move_pushes_earlier(graph, regalloc):
"""gc_push_roots and gc_pop_roots are pushes/pops to the shadowstack,
immediately enclosing the operation that needs them (typically a call).
Here, we try to move individual pushes earlier.
Should run after expand_push_roots(), but before expand_pop_roots(),
so that it sees individual 'gc_save_root' operations but bulk
'gc_pop_roots' operations.
"""
# Concrete example (assembler tested on x86-64 gcc 5.3 and clang 3.7):
#
# ----original---- ----move_pushes_earlier----
#
# while (a > 10) { *foo = b;
# *foo = b; while (a > 10) {
# a = g(a); a = g(a);
# b = *foo; b = *foo;
# // *foo = b;
# } }
# return b; return b;
#
# => the store and the => the store is before, and gcc/clang
# load are in the loop, moves the load after the loop
# even in the assembler (the commented-out '*foo=b' is removed
# here, but gcc/clang would also remove it)
# Draft of the algorithm: see shadowcolor.txt
if not regalloc:
return
entrymap = mkentrymap(graph)
assert len(entrymap[graph.startblock]) == 1
inputvars = {} # {inputvar: (its block, its index in inputargs)}
for block in graph.iterblocks():
for i, v in enumerate(block.inputargs):
inputvars[v] = (block, i)
Plist = []
for index in range(regalloc.numcolors):
U = UnionFind()
S = set()
for block in graph.iterblocks():
for op in reversed(block.operations):
if op.opname == 'gc_pop_roots':
break
else:
continue # no gc_pop_roots in this block
for v in op.args:
if isinstance(v, Variable) and regalloc.checkcolor(v, index):
break
else:
continue # no variable goes into index i
succ = set()
pending_succ = [(block, v)]
while pending_succ:
block1, v1 = pending_succ.pop()
assert regalloc.checkcolor(v1, index)
for op1 in block1.operations:
if is_trivial_rewrite(op1) and op1.args[0] is v1:
if regalloc.checkcolor(op1.result, index):
pending_succ.append((block1, op1.result))
for link1 in block1.exits:
for i2, v2 in enumerate(link1.args):
if v2 is not v1:
continue
block2 = link1.target
w2 = block2.inputargs[i2]
if w2 in succ or not regalloc.checkcolor(w2, index):
continue
succ.add(w2)
for op2 in block2.operations:
if op2.opname in ('gc_save_root', 'gc_pop_roots'):
break
else:
pending_succ.append((block2, w2))
U.union_list(list(succ))
S.update(succ)
G = defaultdict(set)
for block in graph.iterblocks():
found = False
for opindex, op in enumerate(block.operations):
if op.opname == 'gc_save_root':
if (isinstance(op.args[1], Constant) and
op.args[1].concretetype == lltype.Signed):
break
elif op.args[0].value == index:
found = True
break
if not found or not isinstance(op.args[1], Variable):
continue # no matching gc_save_root in this block
key = (block, op)
pred = set()
pending_pred = [(block, op.args[1], opindex)]
while pending_pred:
block1, v1, opindex1 = pending_pred.pop()
assert regalloc.getcolor(v1) == index
for i in range(opindex1-1, -1, -1):
op1 = block1.operations[i]
if op1.opname == 'gc_pop_roots':
break # stop
if op1.result is v1:
if not is_trivial_rewrite(op1):
break # stop
if not regalloc.checkcolor(op1.args[0], index):
break # stop
v1 = op1.args[0]
else:
varindex = block1.inputargs.index(v1)
if v1 in pred:
continue # already done
pred.add(v1)
for link1 in entrymap[block1]:
prevblock1 = link1.prevblock
if prevblock1 is not None:
w1 = link1.args[varindex]
if isinstance(w1, Variable) and w1 not in pred:
if regalloc.checkcolor(w1, index):
pending_pred.append((prevblock1, w1,
len(prevblock1.operations)))
U.union_list(list(pred))
for v1 in pred:
G[v1].add(key)
M = S.intersection(G)
parts_target = {}
for v in M:
vp = U.find_rep(v)
if vp not in parts_target:
new_part = (index, set(), set())
# (index,
# subset P of variables,
# set of (block, gc_save_root))
Plist.append(new_part)
parts_target[vp] = new_part
part = parts_target[vp]
part[1].add(v)
part[2].update(G[v])
# Sort P so that it prefers places that would avoid multiple
# gcsaveroots (smaller 'heuristic' result, so first in sorted
# order); but also prefers smaller overall pieces, because it
# might be possible to remove several small-scale pieces instead
# of one big-scale one.
def heuristic((index, P, gcsaveroots)):
return float(len(P)) / len(gcsaveroots)
Plist.sort(key=heuristic)
variables_along_changes = {}
live_at_start_of_block = set() # set of (block, index)
insert_gc_push_root = defaultdict(list)
for index, P, gcsaveroots in Plist:
# if this Plist entry is not valid any more because of changes
# done by the previous entries, drop it
if any((inputvars[v][0], index) in live_at_start_of_block for v in P):
continue
if any(op not in block.operations for block, op in gcsaveroots):
continue
for v in P:
assert regalloc.getcolor(v) == index
assert v not in variables_along_changes
success_count = 0
mark = []
for v in P:
block, varindex = inputvars[v]
for link in entrymap[block]:
w = link.args[varindex]
if link.prevblock is not None:
prevoperations = link.prevblock.operations
else:
prevoperations = []
for op in reversed(prevoperations):
if op.opname == 'gc_pop_roots':
# it is possible to have gc_pop_roots() without
# w in the args, if w is the result of the call
# that comes just before.
if (isinstance(w, Variable) and
w in op.args and
regalloc.checkcolor(w, index)):
success_count += 1
else:
mark.append((index, link, varindex))
break
if op.result is w:
if is_trivial_rewrite(op) and (
regalloc.checkcolor(op.args[0], index)):
w = op.args[0]
else:
mark.append((index, link, varindex))
break
else:
if not isinstance(w, Variable) or w not in P:
mark.append((index, link, varindex))
if success_count > 0:
for block, op in gcsaveroots:
newops = list(block.operations)
newops.remove(op)
block.operations = newops
for index, link, varindex in mark:
insert_gc_push_root[link].append((index, link.args[varindex]))
for v in P:
block, varindex = inputvars[v]
variables_along_changes[v] = block, index
live_at_start_of_block.add((block, index))
for link in insert_gc_push_root:
newops = [_gc_save_root(index, v)
for index, v in sorted(insert_gc_push_root[link])]
insert_empty_block(link, newops=newops)
def expand_pop_roots(graph, regalloc):
"""gc_pop_roots => series of gc_restore_root; this is done after
move_pushes_earlier() because that one doesn't work correctly if
a completely-empty gc_pop_roots is removed.
Also notice in-block code sequences like gc_pop_roots(v) followed
by a gc_save_root(v), and drop the gc_save_root.
"""
drop = {}
for block in graph.iterblocks():
any_change = False
newops = []
for op in block.operations:
if op.opname == 'gc_pop_roots':
args = [v for v in op.args if isinstance(v, Variable)]
expanded = list(expand_one_pop_roots(regalloc, args))
drop = {}
for op1 in expanded:
if isinstance(op1.args[1], Variable):
drop[op1.args[1]] = op1.args[0].value
newops += expanded
any_change = True
elif (op.opname == 'gc_save_root' and
drop.get(op.args[1]) == op.args[0].value):
any_change = True # kill the operation
else:
newops.append(op)
if any_change:
block.operations = newops
def add_enter_leave_roots_frame(graph, regalloc, c_gcdata):
# put 'gc_enter_roots_frame' as late as possible, but before the
# first 'gc_save_root' is reached.
#
# put the 'gc_leave_roots_frame' operations as early as possible,
# that is, just after the last 'gc_restore_root' reached. This is
# done by putting it along a link, such that the previous block
# contains a 'gc_restore_root' and from the next block it is not
# possible to reach any extra 'gc_restore_root'; then, as doing
# this is not as precise as we'd like, we first break every block
# just after their last 'gc_restore_root'.
if regalloc is None:
return
# break blocks after their last 'gc_restore_root', unless they
# are already at the last position
for block in graph.iterblocks():
ops = block.operations
for i in range(len(ops)-1, -1, -1):
if ops[i].opname == 'gc_restore_root':
if i < len(ops) - 1:
split_block(block, i + 1)
break
# done
insert_empty_startblock(graph)
entrymap = mkentrymap(graph)
# helpers
def is_interesting_op(op):
if op.opname == 'gc_restore_root':
return True
if op.opname == 'gc_save_root':
# ignore saves that say "everything is free"
return not (isinstance(op.args[1], Constant) and
isinstance(op.args[1].value, int) and
op.args[1].value == bitmask_all_free)
return False
bitmask_all_free = (1 << regalloc.numcolors) - 1
def insert_along_link(link, opname, args, cache):
b2 = link.target
if b2 not in cache:
newblock = Block([v.copy() for v in b2.inputargs])
newblock.operations.append(
SpaceOperation(opname, args, varoftype(lltype.Void)))
newblock.closeblock(Link(list(newblock.inputargs), b2))
cache[b2] = newblock
link.target = cache[b2]
# make a list of blocks with gc_save_root/gc_restore_root in them
interesting_blocks = []
for block in graph.iterblocks():
for op in block.operations:
if is_interesting_op(op):
assert block is not graph.startblock
assert block is not graph.returnblock
interesting_blocks.append(block)
break # interrupt this block, go to the next one
# compute the blocks such that 'gc_save_root/gc_restore_root'
# exist anywhere before the start of this block
before_blocks = set()
pending = list(interesting_blocks)
seen = set(pending)
while pending:
block = pending.pop()
for link in block.exits:
before_blocks.add(link.target)
if link.target not in seen:
seen.add(link.target)
pending.append(link.target)
assert graph.startblock not in before_blocks
# compute the blocks such that 'gc_save_root/gc_restore_root'
# exist anywhere after the start of this block
after_blocks = set(interesting_blocks)
pending = list(interesting_blocks)
while pending:
block = pending.pop()
for link in entrymap[block]:
if link.prevblock is not None:
if link.prevblock not in after_blocks:
after_blocks.add(link.prevblock)
pending.append(link.prevblock)
assert graph.returnblock not in after_blocks
# this is the set of blocks such that, at the start of the block,
# we're "in frame", i.e. there are 'gc_save_root/gc_restore_root'
# both before and after the start of the block.
inside_blocks = before_blocks & after_blocks
inside_or_interesting_blocks = set(interesting_blocks) | inside_blocks
# if a block contains gc_save_root/gc_restore_root but is not
# an "inside_block", then add gc_enter_roots_frame where needed
c_num = Constant(regalloc.numcolors, lltype.Signed)
for block in interesting_blocks:
if block not in inside_blocks:
i = 0
while not is_interesting_op(block.operations[i]):
i += 1
block.operations.insert(i,
SpaceOperation('gc_enter_roots_frame', [c_gcdata, c_num],
varoftype(lltype.Void)))
# If a link goes from a "non-inside, non-interesting block"
# straight to an "inside_block", insert a gc_enter_roots_frame
# along the link. Similarly, if a block is a "inside-or-
# interesting_block" and exits with a link going to a
# "non-inside_block", then insert a gc_leave_roots_frame along the
# link.
cache1 = {}
cache2 = {}
for block in list(graph.iterblocks()):
if block not in inside_or_interesting_blocks:
for link in block.exits:
if link.target in inside_blocks:
insert_along_link(link, 'gc_enter_roots_frame',
[c_gcdata, c_num], cache1)
else:
for link in block.exits:
if link.target not in inside_blocks:
insert_along_link(link, 'gc_leave_roots_frame',
[], cache2)
# check all blocks not in "inside_block": they might contain a
# gc_save_root() that writes the bitmask meaning "everything is
# free". Look only before gc_enter_roots_frame, if there is one
# in that block. Remove these out-of-frame gc_save_root().
for block in graph.iterblocks():
if block not in inside_blocks:
newops = []
for i, op in enumerate(block.operations):
if op.opname == 'gc_enter_roots_frame':
newops.extend(block.operations[i:])
break
if op.opname == 'gc_save_root' and not is_interesting_op(op):
pass # don't add in newops
else:
newops.append(op)
if len(newops) < len(block.operations):
block.operations = newops
join_blocks(graph) # for the extra new blocks made in this function
class GCBitmaskTooLong(Exception):
pass
class PostProcessCheckError(Exception):
pass
def postprocess_double_check(graph):
# Debugging only: double-check that the placement is correct.
# Assumes that every gc_restore_root() indicates that the variable
# must be saved at the given position in the shadowstack frame (in
# practice it may have moved because of the GC, but in theory it
# is still the "same" object). So we build the set of all known
# valid-in-all-paths saved locations, and check that.
saved = {} # {var-from-inputargs: location} where location is:
# <unset>: we haven't seen this variable so far
# set-of-indexes: says where the variable is always
# saved at the start of this block
# empty-set: same as above, so: "saved nowhere"
in_frame = {} # {block: bool}, tells if, at the start of this block,
# we're in status "frame entered" or not
in_frame[graph.startblock] = False
pending = set([graph.startblock])
while pending:
block = pending.pop()
locsaved = {}
currently_in_frame = in_frame[block]
if currently_in_frame:
for v in block.inputargs:
locsaved[v] = saved[v]
for op in block.operations:
if op.opname == 'gc_restore_root':
if not currently_in_frame:
raise PostProcessCheckError(graph, block, op, 'no frame!')
if isinstance(op.args[1], Constant):
continue
num = op.args[0].value
if num not in locsaved[op.args[1]]:
raise PostProcessCheckError(graph, block, op, num, locsaved)
elif op.opname == 'gc_save_root':
if not currently_in_frame:
raise PostProcessCheckError(graph, block, op, 'no frame!')
num = op.args[0].value
# first, cancel any other variable that would be saved in 'num'
for v in locsaved:
locsaved[v] = locsaved[v].difference([num])
#
v = op.args[1]
if isinstance(v, Variable):
locsaved[v] = locsaved[v].union([num])
else:
if v.concretetype != lltype.Signed:
locsaved[v] = locsaved.get(v, frozenset()).union([num])
continue
bitmask = v.value
if bitmask != 1:
# cancel any variable that would be saved in any
# position shown by the bitmask, not just 'num'
assert bitmask & 1
assert 1 < bitmask < (2<<num)
nummask = [i for i in range(num+1)
if bitmask & (1<<(num-i))]
assert nummask[-1] == num
for v in locsaved:
locsaved[v] = locsaved[v].difference(nummask)
elif op.opname == 'gc_enter_roots_frame':
if currently_in_frame:
raise PostProcessCheckError(graph, block, op,'double enter')
currently_in_frame = True
# initialize all local variables so far with "not seen anywhere"
# (already done, apart from block.inputargs)
for v in block.inputargs:
locsaved[v] = frozenset()
elif op.opname == 'gc_leave_roots_frame':
if not currently_in_frame:
raise PostProcessCheckError(graph, block, op, 'not entered')
currently_in_frame = False
elif is_trivial_rewrite(op) and currently_in_frame:
locsaved[op.result] = locsaved[op.args[0]]
else:
locsaved[op.result] = frozenset()
for link in block.exits:
changed = False
if link.target not in in_frame:
in_frame[link.target] = currently_in_frame
changed = True
else:
if in_frame[link.target] != currently_in_frame:
raise PostProcessCheckError(graph, link.target,
'inconsistent in_frame')
if currently_in_frame:
for i, v in enumerate(link.args):
try:
loc = locsaved[v]
except KeyError:
assert isinstance(v, Constant)
loc = frozenset()
w = link.target.inputargs[i]
if w in saved:
if loc == saved[w]:
continue # already up-to-date
loc = loc.intersection(saved[w])
saved[w] = loc
changed = True
if changed:
pending.add(link.target)
if in_frame.get(graph.returnblock, False):
raise PostProcessCheckError(graph, 'missing gc_leave_roots_frame')
assert graph.getreturnvar() not in saved # missing gc_leave_roots_frame?
def postprocess_graph(graph, c_gcdata):
"""Collect information about the gc_push_roots and gc_pop_roots
added in this complete graph, and replace them with real operations.
"""
regalloc = allocate_registers(graph)
expand_push_roots(graph, regalloc)
move_pushes_earlier(graph, regalloc)
expand_pop_roots(graph, regalloc)
add_enter_leave_roots_frame(graph, regalloc, c_gcdata)
checkgraph(graph)
postprocess_double_check(graph)
return (regalloc is not None)
def postprocess_inlining(graph):
"""We first write calls to GC functions with gc_push_roots(...) and
gc_pop_roots(...) around. Then we inline some of these functions.
As a result, the gc_push_roots and gc_pop_roots are no longer in
the same block. Fix that by moving the gc_push_roots/gc_pop_roots
inside the inlined portion of the graph, around every call.
We could also get a correct result by doing things in a different
order, e.g. first postprocess_graph() and then inlining. However,
this order brings an important benefit: if the inlined graph has a
fast-path, like malloc_fixedsize(), then there are no gc_push_roots
and gc_pop_roots left along the fast-path.
"""
for block in graph.iterblocks():
for i in range(len(block.operations)-1, -1, -1):
op = block.operations[i]
if op.opname == 'gc_pop_roots':
break
if op.opname == 'gc_push_roots':
_fix_graph_after_inlining(graph, block, i)
break
checkgraph(graph)
def _fix_graph_after_inlining(graph, initial_block, initial_index):
op = initial_block.operations.pop(initial_index)
assert op.opname == 'gc_push_roots'
seen = set()
pending = [(initial_block, initial_index, op.args)]
while pending:
block, start_index, track_args = pending.pop()
if block in seen:
continue
seen.add(block)
assert block.operations != () # did not find the gc_pop_roots?
new_operations = block.operations[:start_index]
stop = False
for i in range(start_index, len(block.operations)):
op = block.operations[i]
if op.opname == 'gc_push_roots':
raise Exception("%r: seems to have inlined inside it another "
"graph which also uses GC roots" % (graph,))
if op.opname == 'gc_pop_roots':
# end of the inlined graph, drop gc_pop_roots, keep the tail
new_operations += block.operations[i + 1:]
stop = True
break
if op.opname in ('direct_call', 'indirect_call'):
new_operations.append(SpaceOperation('gc_push_roots',
track_args[:],
varoftype(lltype.Void)))
new_operations.append(op)
new_operations.append(SpaceOperation('gc_pop_roots',
track_args[:],
varoftype(lltype.Void)))
else:
new_operations.append(op)
block.operations = new_operations
if not stop:
for link in block.exits:
track_next = []
for v in track_args:
if not isinstance(v, Variable):
continue
i = link.args.index(v) # should really be here
w = link.target.inputargs[i]
track_next.append(w)
pending.append((link.target, 0, track_next))
|