1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
|
# pylint: disable=missing-module-docstring
# pylint: disable=missing-function-docstring
import pytest
import smartcard.reader.ReaderGroups
import smartcard.ulist
def test_reader_groups_acts_like_a_singleton():
"""Verify that the target class *acts* like a singleton."""
instance_1 = smartcard.reader.ReaderGroups.readergroups()
instance_2 = smartcard.reader.ReaderGroups.readergroups()
assert instance_1.instance is instance_2.instance
def test_reader_groups_method_calls():
reader_group = smartcard.reader.ReaderGroups.readergroups()
assert len(reader_group.instance) == 0, "No reader groups should be pre-defined"
list.append(reader_group.instance, "a")
assert len(reader_group.instance) == 1, "Unable to add a reader group"
reader_group.addreadergroup("a")
assert len(reader_group.instance) == 1, "Reader groups must be unique"
with pytest.raises(smartcard.reader.ReaderGroups.BadReaderGroupException):
reader_group.addreadergroup(1)
with pytest.raises(smartcard.reader.ReaderGroups.BadReaderGroupException):
reader_group.removereadergroup(1)
# .__iter__()
assert len(list(reader_group.instance)) == 1
# No-op calls
reader_group.addreadertogroup("no-op", "bogus")
reader_group.removereaderfromgroup("no-op", "bogus")
assert list.pop(reader_group.instance) == "a"
assert len(list(reader_group.instance)) == 0
# ------------------------------------------------------------------------------------
# The tests below this line demonstrate serious behavioral problems with readergroups.
@pytest.mark.xfail(reason="readergroups is not actually a singleton", strict=True)
def test_reader_groups_is_a_singleton():
"""Verify that readergroups is a singleton."""
instance_1 = smartcard.reader.ReaderGroups.readergroups()
instance_2 = smartcard.reader.ReaderGroups.readergroups()
assert instance_1 is instance_2
@pytest.mark.xfail(reason="initlist parameters may be silently ignored", strict=True)
def test_demonstrate_initlist_values_may_be_silently_ignored():
"""Demonstrate that `initlist` parameters may be silently ignored."""
smartcard.reader.ReaderGroups.readergroups(["a"])
reader_group = smartcard.reader.ReaderGroups.readergroups(["b"])
# pylint: disable=unsupported-membership-test
assert "b" in reader_group.instance
def test_demonstrate_adding_is_impossible():
"""Demonstrate that `.addreadergroup()` cannot be called."""
reader_group = smartcard.reader.ReaderGroups.readergroups()
with pytest.raises(RecursionError, match="maximum recursion depth exceeded"):
reader_group.addreadergroup("a")
def test_demonstrate_removing_is_impossible():
"""Demonstrate that `.removereadergroup()` cannot be called.
`.removereadergroup()` recurses twice.
It successfully removes the value, then fails to find it the second time.
"""
reader_group = smartcard.reader.ReaderGroups.readergroups()
list.append(reader_group.instance, "a")
assert reader_group.instance == ["a"]
with pytest.raises(ValueError, match="x not in list"):
reader_group.removereadergroup("a")
# pylint: disable=use-implicit-booleaness-not-comparison
assert reader_group.instance == []
def test_demonstrate_getting_is_impossible():
"""Demonstrate that `.getreadergroups()` returns hard-coded values."""
reader_group = smartcard.reader.ReaderGroups.readergroups()
list.append(reader_group.instance, "a")
assert reader_group.instance == ["a"]
assert reader_group.getreadergroups() == []
assert list.pop(reader_group.instance) == "a"
assert len(list(reader_group.instance)) == 0
|
