1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
|
import asyncio
import json
import time
from typing import Any, Dict, MutableMapping, Optional, cast
import nacl.secret
import nacl.utils
import pytest
from aiohttp import web
from aiohttp.test_utils import TestClient
from aiohttp.typedefs import Handler
from nacl.encoding import Base64Encoder
from aiohttp_session import (
Session,
get_session,
new_session,
session_middleware,
)
from aiohttp_session.nacl_storage import NaClCookieStorage
from .typedefs import AiohttpClient
def test_invalid_key() -> None:
with pytest.raises(ValueError):
NaClCookieStorage(b"123") # short key
def make_cookie(
client: TestClient, secretbox: nacl.secret.SecretBox, data: Dict[str, Any]
) -> None:
session_data = {"session": data, "created": int(time.time())}
cookie_data = json.dumps(session_data).encode("utf-8")
nonce = nacl.utils.random(nacl.secret.SecretBox.NONCE_SIZE)
encr = secretbox.encrypt(cookie_data, nonce, encoder=Base64Encoder).decode("utf-8")
client.session.cookie_jar.update_cookies({"AIOHTTP_SESSION": encr})
def create_app(
handler: Handler, key: bytes, max_age: Optional[int] = None
) -> web.Application:
middleware = session_middleware(NaClCookieStorage(key, max_age=max_age))
app = web.Application(middlewares=[middleware])
app.router.add_route("GET", "/", handler)
return app
def decrypt(secretbox: nacl.secret.SecretBox, cookie_value: str) -> Any:
assert type(cookie_value) == str
return json.loads(
secretbox.decrypt(cookie_value.encode("utf-8"), encoder=Base64Encoder).decode(
"utf-8"
)
)
@pytest.fixture
def secretbox(key: bytes) -> nacl.secret.SecretBox:
return nacl.secret.SecretBox(key)
@pytest.fixture
def key() -> bytes:
return nacl.utils.random(nacl.secret.SecretBox.KEY_SIZE)
async def test_create_new_session(
aiohttp_client: AiohttpClient, secretbox: nacl.secret.SecretBox, key: bytes
) -> None:
async def handler(request: web.Request) -> web.StreamResponse:
session = await get_session(request)
assert isinstance(session, Session)
assert session.new
assert not session._changed
assert cast(MutableMapping[str, Any], {}) == session
return web.Response(body=b"OK")
client = await aiohttp_client(create_app(handler, key))
resp = await client.get("/")
assert resp.status == 200
async def test_load_existing_session(
aiohttp_client: AiohttpClient, secretbox: nacl.secret.SecretBox, key: bytes
) -> None:
async def handler(request: web.Request) -> web.StreamResponse:
session = await get_session(request)
assert isinstance(session, Session)
assert not session.new
assert not session._changed
assert cast(MutableMapping[str, Any], {"a": 1, "b": 12}) == session
return web.Response(body=b"OK")
client = await aiohttp_client(create_app(handler, key))
make_cookie(client, secretbox, {"a": 1, "b": 12})
resp = await client.get("/")
assert resp.status == 200
async def test_change_session(
aiohttp_client: AiohttpClient, secretbox: nacl.secret.SecretBox, key: bytes
) -> None:
async def handler(request: web.Request) -> web.StreamResponse:
session = await get_session(request)
session["c"] = 3
return web.Response(body=b"OK")
client = await aiohttp_client(create_app(handler, key))
make_cookie(client, secretbox, {"a": 1, "b": 2})
resp = await client.get("/")
assert resp.status == 200
morsel = resp.cookies["AIOHTTP_SESSION"]
cookie_data = decrypt(secretbox, morsel.value)
assert "session" in cookie_data
assert "a" in cookie_data["session"]
assert "b" in cookie_data["session"]
assert "c" in cookie_data["session"]
assert "created" in cookie_data
assert cookie_data["session"]["a"] == 1
assert cookie_data["session"]["b"] == 2
assert cookie_data["session"]["c"] == 3
assert morsel["httponly"]
assert "/" == morsel["path"]
async def test_del_cookie_on_session_invalidation(
aiohttp_client: AiohttpClient, secretbox: nacl.secret.SecretBox, key: bytes
) -> None:
async def handler(request: web.Request) -> web.StreamResponse:
session = await get_session(request)
session.invalidate()
return web.Response(body=b"OK")
client = await aiohttp_client(create_app(handler, key))
make_cookie(client, secretbox, {"a": 1, "b": 2})
resp = await client.get("/")
assert resp.status == 200
morsel = resp.cookies["AIOHTTP_SESSION"]
assert "" == morsel.value
assert not morsel["httponly"]
assert morsel["path"] == "/"
async def test_nacl_session_fixation(
aiohttp_client: AiohttpClient, secretbox: nacl.secret.SecretBox, key: bytes
) -> None:
async def login(request: web.Request) -> web.StreamResponse:
session = await get_session(request)
session["k"] = "v"
return web.Response()
async def logout(request: web.Request) -> web.StreamResponse:
session = await get_session(request)
session.invalidate()
return web.Response()
app = create_app(login, key)
app.router.add_route("DELETE", "/", logout)
client = await aiohttp_client(app)
resp = await client.get("/")
assert "AIOHTTP_SESSION" in resp.cookies
evil_cookie = resp.cookies["AIOHTTP_SESSION"].value
resp = await client.delete("/")
assert resp.cookies["AIOHTTP_SESSION"].value == ""
client.session.cookie_jar.update_cookies({"AIOHTTP_SESSION": evil_cookie})
resp = await client.get("/")
assert resp.cookies["AIOHTTP_SESSION"].value != evil_cookie
async def test_load_session_dont_load_expired_session(
aiohttp_client: AiohttpClient, key: bytes
) -> None:
async def handler(request: web.Request) -> web.StreamResponse:
session = await get_session(request)
exp_param = request.rel_url.query.get("exp", None)
if exp_param is None:
session["a"] = 1
session["b"] = 2
else:
assert cast(MutableMapping[str, Any], {}) == session
return web.Response(body=b"OK")
client = await aiohttp_client(create_app(handler, key, 2))
resp = await client.get("/")
assert resp.status == 200
await asyncio.sleep(5)
resp = await client.get("/?exp=yes")
assert resp.status == 200
async def test_load_corrupted_session(
aiohttp_client: AiohttpClient, key: bytes
) -> None:
async def handler(request: web.Request) -> web.StreamResponse:
session = await get_session(request)
assert isinstance(session, Session)
assert session.new
assert cast(MutableMapping[str, Any], {}) == session
return web.Response(body=b"OK")
client = await aiohttp_client(create_app(handler, key))
client.session.cookie_jar.update_cookies({"AIOHTTP_SESSION": "bad key"})
resp = await client.get("/")
assert resp.status == 200
async def test_load_session_different_key(
aiohttp_client: AiohttpClient, key: bytes
) -> None:
async def handler(request: web.Request) -> web.StreamResponse:
session = await get_session(request)
assert isinstance(session, Session)
assert session.new
assert cast(MutableMapping[str, Any], {}) == session
return web.Response(body=b"OK")
client = await aiohttp_client(create_app(handler, key))
# create another box with another key
key = nacl.utils.random(nacl.secret.SecretBox.KEY_SIZE)
secretbox = nacl.secret.SecretBox(key)
make_cookie(client, secretbox, {"a": 1, "b": 12})
resp = await client.get("/")
assert resp.status == 200
async def test_load_expired_session(aiohttp_client: AiohttpClient, key: bytes) -> None:
MAX_AGE = 2
async def login(request: web.Request) -> web.StreamResponse:
session = await new_session(request)
session["created"] = int(time.time())
return web.Response()
async def handler(request: web.Request) -> web.StreamResponse:
session = await get_session(request)
created = session.get("created", "") if not session.new else ""
return web.Response(text=str(created))
app = create_app(handler, key, max_age=MAX_AGE)
app.router.add_route("POST", "/", login)
client = await aiohttp_client(app)
resp = await client.post("/")
assert "AIOHTTP_SESSION" in resp.cookies
cookie = resp.cookies["AIOHTTP_SESSION"].value
await asyncio.sleep(MAX_AGE + 1)
client.session.cookie_jar.update_cookies({"AIOHTTP_SESSION": cookie})
resp = await client.get("/")
assert await resp.text() == ""
|
