1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747
|
import asyncio
import gc
import ipaddress
import socket
from collections.abc import Generator
from ipaddress import ip_address
from typing import Any, Awaitable, Callable, Collection, List, NamedTuple, Tuple, Union
from unittest.mock import Mock, create_autospec, patch
import pytest
from aiohttp.resolver import (
_NAME_SOCKET_FLAGS,
AsyncResolver,
DefaultResolver,
ThreadedResolver,
_DNSResolverManager,
)
try:
import aiodns
getaddrinfo: Any = hasattr(aiodns.DNSResolver, "getaddrinfo")
except ImportError:
aiodns = None # type: ignore[assignment]
getaddrinfo = False
@pytest.fixture()
def check_no_lingering_resolvers() -> Generator[None, None, None]:
"""Verify no resolvers remain after the test.
This fixture should be used in any test that creates instances of
AsyncResolver or directly uses _DNSResolverManager.
"""
manager = _DNSResolverManager()
before = len(manager._loop_data)
yield
after = len(manager._loop_data)
if after > before: # pragma: no branch
# Force garbage collection to ensure weak references are updated
gc.collect() # pragma: no cover
after = len(manager._loop_data) # pragma: no cover
if after > before: # pragma: no cover
pytest.fail( # pragma: no cover
f"Lingering resolvers found: {(after - before)} "
"new AsyncResolver instances were not properly closed."
)
@pytest.fixture()
def dns_resolver_manager() -> Generator[_DNSResolverManager, None, None]:
"""Create a fresh _DNSResolverManager instance for testing.
Saves and restores the singleton state to avoid affecting other tests.
"""
# Save the original instance
original_instance = _DNSResolverManager._instance
# Reset the singleton
_DNSResolverManager._instance = None
# Create and yield a fresh instance
try:
yield _DNSResolverManager()
finally:
# Clean up and restore the original instance
_DNSResolverManager._instance = original_instance
class FakeAIODNSAddrInfoNode(NamedTuple):
family: int
addr: Union[Tuple[bytes, int], Tuple[bytes, int, int, int]]
class FakeAIODNSAddrInfoIPv4Result:
def __init__(self, hosts: Collection[str]) -> None:
self.nodes = [
FakeAIODNSAddrInfoNode(socket.AF_INET, (h.encode(), 0)) for h in hosts
]
class FakeAIODNSAddrInfoIPv6Result:
def __init__(self, hosts: Collection[str]) -> None:
self.nodes = [
FakeAIODNSAddrInfoNode(
socket.AF_INET6,
(h.encode(), 0, 0, 3 if ip_address(h).is_link_local else 0),
)
for h in hosts
]
class FakeAIODNSNameInfoIPv6Result:
def __init__(self, host: str) -> None:
self.node = host
self.service = None
class FakeQueryResult:
def __init__(self, host):
self.host = host
async def fake_aiodns_getaddrinfo_ipv4_result(
hosts: Collection[str],
) -> FakeAIODNSAddrInfoIPv4Result:
return FakeAIODNSAddrInfoIPv4Result(hosts=hosts)
async def fake_aiodns_getaddrinfo_ipv6_result(
hosts: Collection[str],
) -> FakeAIODNSAddrInfoIPv6Result:
return FakeAIODNSAddrInfoIPv6Result(hosts=hosts)
async def fake_aiodns_getnameinfo_ipv6_result(
host: str,
) -> FakeAIODNSNameInfoIPv6Result:
return FakeAIODNSNameInfoIPv6Result(host)
async def fake_query_result(result):
return [FakeQueryResult(host=h) for h in result]
def fake_addrinfo(hosts: Collection[str]) -> Callable[..., Awaitable[Any]]:
async def fake(*args: Any, **kwargs: Any) -> List[Any]:
if not hosts:
raise socket.gaierror
return [(socket.AF_INET, None, socket.SOCK_STREAM, None, [h, 0]) for h in hosts]
return fake
def fake_ipv6_addrinfo(hosts: Collection[str]) -> Callable[..., Awaitable[Any]]:
async def fake(*args: Any, **kwargs: Any) -> List[Any]:
if not hosts:
raise socket.gaierror
return [
(
socket.AF_INET6,
None,
socket.SOCK_STREAM,
None,
(h, 0, 0, 3 if ip_address(h).is_link_local else 0),
)
for h in hosts
]
return fake
def fake_ipv6_nameinfo(host: str) -> Callable[..., Awaitable[Any]]:
async def fake(*args: Any, **kwargs: Any) -> Tuple[str, int]:
return host, 0
return fake
@pytest.mark.skipif(not getaddrinfo, reason="aiodns >=3.2.0 required")
@pytest.mark.usefixtures("check_no_lingering_resolvers")
async def test_async_resolver_positive_ipv4_lookup(
loop: asyncio.AbstractEventLoop,
) -> None:
with patch("aiodns.DNSResolver") as mock:
mock().getaddrinfo.return_value = fake_aiodns_getaddrinfo_ipv4_result(
["127.0.0.1"]
)
resolver = AsyncResolver()
real = await resolver.resolve("www.python.org")
ipaddress.ip_address(real[0]["host"])
mock().getaddrinfo.assert_called_with(
"www.python.org",
family=socket.AF_INET,
flags=socket.AI_ADDRCONFIG,
port=0,
type=socket.SOCK_STREAM,
)
await resolver.close()
@pytest.mark.skipif(not getaddrinfo, reason="aiodns >=3.2.0 required")
@pytest.mark.usefixtures("check_no_lingering_resolvers")
async def test_async_resolver_positive_link_local_ipv6_lookup(
loop: asyncio.AbstractEventLoop,
) -> None:
with patch("aiodns.DNSResolver") as mock:
mock().getaddrinfo.return_value = fake_aiodns_getaddrinfo_ipv6_result(
["fe80::1"]
)
mock().getnameinfo.return_value = fake_aiodns_getnameinfo_ipv6_result(
"fe80::1%eth0"
)
resolver = AsyncResolver()
real = await resolver.resolve("www.python.org")
ipaddress.ip_address(real[0]["host"])
mock().getaddrinfo.assert_called_with(
"www.python.org",
family=socket.AF_INET,
flags=socket.AI_ADDRCONFIG,
port=0,
type=socket.SOCK_STREAM,
)
mock().getnameinfo.assert_called_with(("fe80::1", 0, 0, 3), _NAME_SOCKET_FLAGS)
await resolver.close()
@pytest.mark.skipif(not getaddrinfo, reason="aiodns >=3.2.0 required")
@pytest.mark.usefixtures("check_no_lingering_resolvers")
async def test_async_resolver_multiple_replies(loop: asyncio.AbstractEventLoop) -> None:
with patch("aiodns.DNSResolver") as mock:
ips = ["127.0.0.1", "127.0.0.2", "127.0.0.3", "127.0.0.4"]
mock().getaddrinfo.return_value = fake_aiodns_getaddrinfo_ipv4_result(ips)
resolver = AsyncResolver()
real = await resolver.resolve("www.google.com")
ipaddrs = [ipaddress.ip_address(x["host"]) for x in real]
assert len(ipaddrs) > 3, "Expecting multiple addresses"
await resolver.close()
@pytest.mark.skipif(not getaddrinfo, reason="aiodns >=3.2.0 required")
@pytest.mark.usefixtures("check_no_lingering_resolvers")
async def test_async_resolver_negative_lookup(loop: asyncio.AbstractEventLoop) -> None:
with patch("aiodns.DNSResolver") as mock:
mock().getaddrinfo.side_effect = aiodns.error.DNSError()
resolver = AsyncResolver()
with pytest.raises(OSError):
await resolver.resolve("doesnotexist.bla")
await resolver.close()
@pytest.mark.skipif(not getaddrinfo, reason="aiodns >=3.2.0 required")
@pytest.mark.usefixtures("check_no_lingering_resolvers")
async def test_async_resolver_no_hosts_in_getaddrinfo(
loop: asyncio.AbstractEventLoop,
) -> None:
with patch("aiodns.DNSResolver") as mock:
mock().getaddrinfo.return_value = fake_aiodns_getaddrinfo_ipv4_result([])
resolver = AsyncResolver()
with pytest.raises(OSError):
await resolver.resolve("doesnotexist.bla")
await resolver.close()
async def test_threaded_resolver_positive_lookup() -> None:
loop = Mock()
loop.getaddrinfo = fake_addrinfo(["127.0.0.1"])
resolver = ThreadedResolver(loop=loop)
real = await resolver.resolve("www.python.org")
assert real[0]["hostname"] == "www.python.org"
ipaddress.ip_address(real[0]["host"])
async def test_threaded_resolver_positive_ipv6_link_local_lookup() -> None:
loop = Mock()
loop.getaddrinfo = fake_ipv6_addrinfo(["fe80::1"])
loop.getnameinfo = fake_ipv6_nameinfo("fe80::1%eth0")
# Mock the fake function that was returned by helper functions
loop.getaddrinfo = create_autospec(loop.getaddrinfo)
loop.getnameinfo = create_autospec(loop.getnameinfo)
# Set the correct return values for mock functions
loop.getaddrinfo.return_value = await fake_ipv6_addrinfo(["fe80::1"])()
loop.getnameinfo.return_value = await fake_ipv6_nameinfo("fe80::1%eth0")()
resolver = ThreadedResolver()
resolver._loop = loop
real = await resolver.resolve("www.python.org")
assert real[0]["hostname"] == "www.python.org"
ipaddress.ip_address(real[0]["host"])
loop.getaddrinfo.assert_called_with(
"www.python.org",
0,
type=socket.SOCK_STREAM,
family=socket.AF_INET,
flags=socket.AI_ADDRCONFIG,
)
loop.getnameinfo.assert_called_with(("fe80::1", 0, 0, 3), _NAME_SOCKET_FLAGS)
async def test_threaded_resolver_multiple_replies() -> None:
loop = Mock()
ips = ["127.0.0.1", "127.0.0.2", "127.0.0.3", "127.0.0.4"]
loop.getaddrinfo = fake_addrinfo(ips)
resolver = ThreadedResolver(loop=loop)
real = await resolver.resolve("www.google.com")
ips = [ipaddress.ip_address(x["host"]) for x in real]
assert len(ips) > 3, "Expecting multiple addresses"
async def test_threaded_negative_lookup() -> None:
loop = Mock()
ips = []
loop.getaddrinfo = fake_addrinfo(ips)
resolver = ThreadedResolver(loop=loop)
with pytest.raises(socket.gaierror):
await resolver.resolve("doesnotexist.bla")
async def test_threaded_negative_ipv6_lookup() -> None:
loop = Mock()
ips: List[Any] = []
loop.getaddrinfo = fake_ipv6_addrinfo(ips)
resolver = ThreadedResolver()
resolver._loop = loop
with pytest.raises(socket.gaierror):
await resolver.resolve("doesnotexist.bla")
async def test_threaded_negative_lookup_with_unknown_result() -> None:
loop = Mock()
# If compile CPython with `--disable-ipv6` option,
# we will get an (int, bytes) tuple, instead of a Exception.
async def unknown_addrinfo(*args: Any, **kwargs: Any) -> List[Any]:
return [
(
socket.AF_INET6,
socket.SOCK_STREAM,
6,
"",
(10, b"\x01\xbb\x00\x00\x00\x00*\x04NB\x00\x1a\x00\x00"),
)
]
loop.getaddrinfo = unknown_addrinfo
resolver = ThreadedResolver()
resolver._loop = loop
with patch("socket.has_ipv6", False):
res = await resolver.resolve("www.python.org")
assert len(res) == 0
async def test_close_for_threaded_resolver(loop) -> None:
resolver = ThreadedResolver()
await resolver.close()
@pytest.mark.skipif(aiodns is None, reason="aiodns required")
@pytest.mark.usefixtures("check_no_lingering_resolvers")
async def test_close_for_async_resolver(loop: asyncio.AbstractEventLoop) -> None:
resolver = AsyncResolver()
await resolver.close()
async def test_default_loop_for_threaded_resolver(loop) -> None:
asyncio.set_event_loop(loop)
resolver = ThreadedResolver()
assert resolver._loop is loop
@pytest.mark.skipif(not getaddrinfo, reason="aiodns >=3.2.0 required")
@pytest.mark.usefixtures("check_no_lingering_resolvers")
async def test_async_resolver_ipv6_positive_lookup(
loop: asyncio.AbstractEventLoop,
) -> None:
with patch("aiodns.DNSResolver") as mock:
mock().getaddrinfo.return_value = fake_aiodns_getaddrinfo_ipv6_result(["::1"])
resolver = AsyncResolver()
real = await resolver.resolve("www.python.org")
ipaddress.ip_address(real[0]["host"])
mock().getaddrinfo.assert_called_with(
"www.python.org",
family=socket.AF_INET,
flags=socket.AI_ADDRCONFIG,
port=0,
type=socket.SOCK_STREAM,
)
await resolver.close()
@pytest.mark.skipif(aiodns is None, reason="aiodns required")
async def test_async_resolver_query_ipv6_positive_lookup(loop) -> None:
with patch("aiodns.DNSResolver") as mock:
del mock().gethostbyname
mock().query.return_value = fake_query_result(["::1"])
resolver = AsyncResolver(loop=loop)
real = await resolver.resolve("www.python.org", family=socket.AF_INET6)
ipaddress.ip_address(real[0]["host"])
mock().query.assert_called_with("www.python.org", "AAAA")
@pytest.mark.skipif(not getaddrinfo, reason="aiodns >=3.2.0 required")
async def test_async_resolver_query_fallback_error_messages_passed(
loop: asyncio.AbstractEventLoop,
) -> None:
"""Ensure error messages are passed through from aiodns with query fallback."""
with patch("aiodns.DNSResolver", autospec=True, spec_set=True) as mock:
del mock().gethostbyname
mock().query.side_effect = aiodns.error.DNSError(1, "Test error message")
resolver = AsyncResolver()
with pytest.raises(OSError, match="Test error message") as excinfo:
await resolver.resolve("x.org")
assert excinfo.value.strerror == "Test error message"
@pytest.mark.skipif(not getaddrinfo, reason="aiodns >=3.2.0 required")
async def test_async_resolver_query_fallback_error_messages_passed_no_hosts(
loop: asyncio.AbstractEventLoop,
) -> None:
"""Ensure error messages are passed through from aiodns with query fallback."""
with patch("aiodns.DNSResolver", autospec=True, spec_set=True) as mock:
del mock().gethostbyname
mock().query.return_value = fake_query_result([])
resolver = AsyncResolver()
with pytest.raises(OSError, match="DNS lookup failed") as excinfo:
await resolver.resolve("x.org")
assert excinfo.value.strerror == "DNS lookup failed"
@pytest.mark.skipif(not getaddrinfo, reason="aiodns >=3.2.0 required")
@pytest.mark.usefixtures("check_no_lingering_resolvers")
async def test_async_resolver_error_messages_passed(
loop: asyncio.AbstractEventLoop,
) -> None:
"""Ensure error messages are passed through from aiodns."""
with patch("aiodns.DNSResolver", autospec=True, spec_set=True) as mock:
mock().getaddrinfo.side_effect = aiodns.error.DNSError(1, "Test error message")
resolver = AsyncResolver()
with pytest.raises(OSError, match="Test error message") as excinfo:
await resolver.resolve("x.org")
assert excinfo.value.strerror == "Test error message"
await resolver.close()
@pytest.mark.skipif(not getaddrinfo, reason="aiodns >=3.2.0 required")
@pytest.mark.usefixtures("check_no_lingering_resolvers")
async def test_async_resolver_error_messages_passed_no_hosts(
loop: asyncio.AbstractEventLoop,
) -> None:
"""Ensure error messages are passed through from aiodns."""
with patch("aiodns.DNSResolver", autospec=True, spec_set=True) as mock:
mock().getaddrinfo.return_value = fake_aiodns_getaddrinfo_ipv6_result([])
resolver = AsyncResolver()
with pytest.raises(OSError, match="DNS lookup failed") as excinfo:
await resolver.resolve("x.org")
assert excinfo.value.strerror == "DNS lookup failed"
await resolver.close()
@pytest.mark.usefixtures("check_no_lingering_resolvers")
async def test_async_resolver_aiodns_not_present(
loop: asyncio.AbstractEventLoop, monkeypatch: pytest.MonkeyPatch
) -> None:
monkeypatch.setattr("aiohttp.resolver.aiodns", None)
with pytest.raises(RuntimeError):
AsyncResolver(loop=loop)
@pytest.mark.skipif(not getaddrinfo, reason="aiodns >=3.2.0 required")
@pytest.mark.usefixtures("check_no_lingering_resolvers")
def test_aio_dns_is_default() -> None:
assert DefaultResolver is AsyncResolver
@pytest.mark.skipif(getaddrinfo, reason="aiodns <3.2.0 required")
def test_threaded_resolver_is_default() -> None:
assert DefaultResolver is ThreadedResolver
@pytest.mark.skipif(not getaddrinfo, reason="aiodns >=3.2.0 required")
async def test_dns_resolver_manager_sharing(
dns_resolver_manager: _DNSResolverManager,
) -> None:
"""Test that the DNSResolverManager shares a resolver among AsyncResolver instances."""
# Create two default AsyncResolver instances
resolver1 = AsyncResolver()
resolver2 = AsyncResolver()
# Check that they share the same underlying resolver
assert resolver1._resolver is resolver2._resolver
# Create an AsyncResolver with custom args
resolver3 = AsyncResolver(nameservers=["8.8.8.8"])
# Check that it has its own resolver
assert resolver1._resolver is not resolver3._resolver
# Cleanup
await resolver1.close()
await resolver2.close()
await resolver3.close()
@pytest.mark.skipif(not getaddrinfo, reason="aiodns >=3.2.0 required")
async def test_dns_resolver_manager_singleton(
dns_resolver_manager: _DNSResolverManager,
) -> None:
"""Test that DNSResolverManager is a singleton."""
# Create a second manager and check it's the same instance
manager1 = dns_resolver_manager
manager2 = _DNSResolverManager()
assert manager1 is manager2
@pytest.mark.skipif(not getaddrinfo, reason="aiodns >=3.2.0 required")
async def test_dns_resolver_manager_resolver_lifecycle(
dns_resolver_manager: _DNSResolverManager,
) -> None:
"""Test that DNSResolverManager creates and destroys resolver correctly."""
manager = dns_resolver_manager
# Initially there should be no resolvers
assert not manager._loop_data
# Create a mock AsyncResolver for testing
mock_client = Mock(spec=AsyncResolver)
mock_client._loop = asyncio.get_running_loop()
# Getting resolver should create one
mock_loop = mock_client._loop
resolver = manager.get_resolver(mock_client, mock_loop)
assert resolver is not None
assert manager._loop_data[mock_loop][0] is resolver
# Getting it again should return the same instance
assert manager.get_resolver(mock_client, mock_loop) is resolver
# Clean up
manager.release_resolver(mock_client, mock_loop)
assert not manager._loop_data
@pytest.mark.skipif(not getaddrinfo, reason="aiodns >=3.2.0 required")
async def test_dns_resolver_manager_client_registration(
dns_resolver_manager: _DNSResolverManager,
) -> None:
"""Test client registration and resolver release logic."""
with patch("aiodns.DNSResolver") as mock:
# Create resolver instances
resolver1 = AsyncResolver()
resolver2 = AsyncResolver()
# Both should use the same resolver from the manager
assert resolver1._resolver is resolver2._resolver
# The manager should be tracking both clients
assert resolver1._manager is resolver2._manager
manager = resolver1._manager
assert manager is not None
loop = asyncio.get_running_loop()
_, client_set = manager._loop_data[loop]
assert len(client_set) == 2
# Close one resolver
await resolver1.close()
_, client_set = manager._loop_data[loop]
assert len(client_set) == 1
# Resolver should still exist
assert manager._loop_data # Not empty
# Close the second resolver
await resolver2.close()
assert not manager._loop_data # Should be empty after closing all clients
# Now all resolvers should be canceled and removed
assert not manager._loop_data # Should be empty
mock().cancel.assert_called_once()
@pytest.mark.skipif(not getaddrinfo, reason="aiodns >=3.2.0 required")
async def test_dns_resolver_manager_multiple_event_loops(
dns_resolver_manager: _DNSResolverManager,
) -> None:
"""Test that DNSResolverManager correctly manages resolvers across different event loops."""
# Create separate resolvers for each loop
resolver1 = Mock(name="resolver1")
resolver2 = Mock(name="resolver2")
# Create a patch that returns different resolvers based on the loop argument
mock_resolver = Mock()
mock_resolver.side_effect = lambda loop=None, **kwargs: (
resolver1 if loop is asyncio.get_running_loop() else resolver2
)
with patch("aiodns.DNSResolver", mock_resolver):
manager = dns_resolver_manager
# Create two mock clients on different loops
mock_client1 = Mock(spec=AsyncResolver)
mock_client1._loop = asyncio.get_running_loop()
# Create a second event loop
loop2 = Mock(spec=asyncio.AbstractEventLoop)
mock_client2 = Mock(spec=AsyncResolver)
mock_client2._loop = loop2
# Get resolvers for both clients
loop1 = mock_client1._loop
loop2 = mock_client2._loop
# Get the resolvers through the manager
manager_resolver1 = manager.get_resolver(mock_client1, loop1)
manager_resolver2 = manager.get_resolver(mock_client2, loop2)
# Should be different resolvers for different loops
assert manager_resolver1 is resolver1
assert manager_resolver2 is resolver2
assert manager._loop_data[loop1][0] is resolver1
assert manager._loop_data[loop2][0] is resolver2
# Release the first resolver
manager.release_resolver(mock_client1, loop1)
# First loop's resolver should be gone, but second should remain
assert loop1 not in manager._loop_data
assert loop2 in manager._loop_data
# Release the second resolver
manager.release_resolver(mock_client2, loop2)
# Both resolvers should be gone
assert not manager._loop_data
# Verify resolver cleanup
resolver1.cancel.assert_called_once()
resolver2.cancel.assert_called_once()
@pytest.mark.skipif(not getaddrinfo, reason="aiodns >=3.2.0 required")
async def test_dns_resolver_manager_weakref_garbage_collection() -> None:
"""Test that release_resolver handles None resolver due to weakref garbage collection."""
manager = _DNSResolverManager()
# Create a mock resolver that will be None when accessed
mock_resolver = Mock()
mock_resolver.cancel = Mock()
with patch("aiodns.DNSResolver", return_value=mock_resolver):
# Create an AsyncResolver to get a resolver from the manager
resolver = AsyncResolver()
loop = asyncio.get_running_loop()
# Manually corrupt the data to simulate garbage collection
# by setting the resolver to None
manager._loop_data[loop] = (None, manager._loop_data[loop][1]) # type: ignore[assignment]
# This should not raise an AttributeError: 'NoneType' object has no attribute 'cancel'
await resolver.close()
# Verify no exception was raised and the loop data was cleaned up properly
# Since we set resolver to None and there was one client, the entry should be removed
assert loop not in manager._loop_data
@pytest.mark.skipif(not getaddrinfo, reason="aiodns >=3.2.0 required")
async def test_dns_resolver_manager_missing_loop_data() -> None:
"""Test that release_resolver handles missing loop data gracefully."""
manager = _DNSResolverManager()
with patch("aiodns.DNSResolver"):
# Create an AsyncResolver
resolver = AsyncResolver()
loop = asyncio.get_running_loop()
# Manually remove the loop data to simulate race condition
manager._loop_data.clear()
# This should not raise a KeyError
await resolver.close()
# Verify no exception was raised
assert loop not in manager._loop_data
@pytest.mark.skipif(not getaddrinfo, reason="aiodns >=3.2.0 required")
@pytest.mark.usefixtures("check_no_lingering_resolvers")
async def test_async_resolver_close_multiple_times() -> None:
"""Test that AsyncResolver.close() can be called multiple times without error."""
with patch("aiodns.DNSResolver") as mock_dns_resolver:
mock_resolver = Mock()
mock_resolver.cancel = Mock()
mock_dns_resolver.return_value = mock_resolver
# Create a resolver with custom args (dedicated resolver)
resolver = AsyncResolver(nameservers=["8.8.8.8"])
# Close it once
await resolver.close()
mock_resolver.cancel.assert_called_once()
# Close it again - should not raise AttributeError
await resolver.close()
# cancel should still only be called once
mock_resolver.cancel.assert_called_once()
@pytest.mark.skipif(not getaddrinfo, reason="aiodns >=3.2.0 required")
@pytest.mark.usefixtures("check_no_lingering_resolvers")
async def test_async_resolver_close_with_none_resolver() -> None:
"""Test that AsyncResolver.close() handles None resolver gracefully."""
with patch("aiodns.DNSResolver"):
# Create a resolver with custom args (dedicated resolver)
resolver = AsyncResolver(nameservers=["8.8.8.8"])
# Manually set resolver to None to simulate edge case
resolver._resolver = None # type: ignore[assignment]
# This should not raise AttributeError
await resolver.close()
@pytest.mark.skipif(aiodns is None, reason="aiodns required")
def test_async_resolver_uses_provided_loop() -> None:
"""Test that AsyncResolver uses the loop parameter when provided."""
# Create a custom event loop
custom_loop = asyncio.new_event_loop()
try:
# Need to set the loop as current for get_running_loop() to work
asyncio.set_event_loop(custom_loop)
# Create resolver with explicit loop parameter
resolver = AsyncResolver(loop=custom_loop)
# Check that the resolver uses the provided loop
assert resolver._loop is custom_loop
finally:
asyncio.set_event_loop(None)
custom_loop.close()
@pytest.mark.skipif(aiodns is None, reason="aiodns required")
@pytest.mark.usefixtures("check_no_lingering_resolvers")
async def test_async_resolver_uses_running_loop_when_none_provided() -> None:
"""Test that AsyncResolver uses get_running_loop() when no loop is provided."""
# Create resolver without loop parameter
resolver = AsyncResolver()
# Check that the resolver uses the current running loop
assert resolver._loop is asyncio.get_running_loop()
# Clean up
await resolver.close()
|