1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120
|
"""Tests for circular imports in all local packages and modules.
This ensures all internal packages can be imported right away without
any need to import some other module before doing so.
This module is based on an idea that pytest uses for self-testing:
* https://github.com/sanitizers/octomachinery/blob/be18b54/tests/circular_imports_test.py
* https://github.com/pytest-dev/pytest/blob/d18c75b/testing/test_meta.py
* https://twitter.com/codewithanthony/status/1229445110510735361
""" # noqa: E501
import os
import pkgutil
import subprocess
import sys
from itertools import chain
from pathlib import Path
from types import ModuleType
from typing import TYPE_CHECKING, Generator, List, Union
import pytest
if TYPE_CHECKING:
from _pytest.mark.structures import ParameterSet
from conftest import IS_UNIX # type: ignore[attr-defined]
import aiohttp
def _mark_aiohttp_worker_for_skipping(
importables: List[str],
) -> List[Union[str, "ParameterSet"]]:
return [
pytest.param(
importable,
marks=pytest.mark.skipif(not IS_UNIX, reason="It's a UNIX-only module"),
)
if importable == "aiohttp.worker"
else importable
for importable in importables
]
def _find_all_importables(pkg: ModuleType) -> List[str]:
"""Find all importables in the project.
Return them in order.
"""
return sorted(
set(
chain.from_iterable(
_discover_path_importables(Path(p), pkg.__name__)
# FIXME: Unignore after upgrading to `mypy > 0.910`. The fix
# FIXME: is in the `master` branch of upstream since Aug 4,
# FIXME: 2021 but has not yet been included in any releases.
# Refs:
# * https://github.com/python/mypy/issues/1422
# * https://github.com/python/mypy/pull/9454
for p in pkg.__path__ # type: ignore[attr-defined]
),
),
)
def _discover_path_importables(
pkg_pth: Path,
pkg_name: str,
) -> Generator[str, None, None]:
"""Yield all importables under a given path and package."""
for dir_path, _d, file_names in os.walk(pkg_pth):
pkg_dir_path = Path(dir_path)
if pkg_dir_path.parts[-1] == "__pycache__":
continue
if all(Path(_).suffix != ".py" for _ in file_names):
continue
rel_pt = pkg_dir_path.relative_to(pkg_pth)
pkg_pref = ".".join((pkg_name,) + rel_pt.parts)
yield from (
pkg_path
for _, pkg_path, _ in pkgutil.walk_packages(
(str(pkg_dir_path),),
prefix=f"{pkg_pref}.",
)
)
@pytest.mark.parametrize(
"import_path",
_mark_aiohttp_worker_for_skipping(_find_all_importables(aiohttp)),
)
def test_no_warnings(import_path: str) -> None:
"""Verify that exploding importables doesn't explode.
This is seeking for any import errors including ones caused
by circular imports.
"""
imp_cmd = (
# fmt: off
sys.executable,
"-W", "error",
# The following deprecation warning is triggered by importing
# `gunicorn.util`. Hopefully, it'll get fixed in the future. See
# https://github.com/benoitc/gunicorn/issues/2840 for detail.
"-W", "ignore:module 'sre_constants' is "
"deprecated:DeprecationWarning:pkg_resources._vendor.pyparsing",
# The following deprecation warning is coming from an old
# version of `setuptools` (the last one to support Python 3.6).
# It is stepping on it's own toes. But since it doesn't
# originate in aiohttp, we don't care much about it.
"-W",
"ignore:Creating a LegacyVersion has been deprecated and will "
"be removed in the next major release:DeprecationWarning:",
"-c", f"import {import_path!s}",
# fmt: on
)
subprocess.check_call(imp_cmd)
|