1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
|
#
# Copyright IBM 2016. All rights reserved
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License. You may obtain
# a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
import argparse
from unittest import mock
import testtools
from aodhclient.v2 import alarm_cli
class CliAlarmCreateTest(testtools.TestCase):
def setUp(self):
super().setUp()
self.app = mock.Mock()
self.parser = mock.Mock()
self.cli_alarm_create = (
alarm_cli.CliAlarmCreate(self.app, self.parser))
@mock.patch.object(argparse.ArgumentParser, 'error')
def test_validate_args_gnocchi_resources_threshold(self, mock_arg):
# Cover the test case of the method _validate_args for
# gnocchi_resources_threshold
parser = self.cli_alarm_create.get_parser('aodh alarm create')
test_parsed_args = parser.parse_args([
'--name', 'gnocchi_resources_threshold_test',
'--type', 'gnocchi_resources_threshold',
'--metric', 'cpu',
'--aggregation-method', 'last',
'--resource-type', 'generic',
'--threshold', '80'
])
self.cli_alarm_create._validate_args(test_parsed_args)
mock_arg.assert_called_once_with(
'gnocchi_resources_threshold requires --metric, '
'--threshold, --resource-id, --resource-type and '
'--aggregation-method')
@mock.patch.object(argparse.ArgumentParser, 'error')
def test_validate_args_threshold(self, mock_arg):
# Cover the test case of the method _validate_args for
# threshold
parser = self.cli_alarm_create.get_parser('aodh alarm create')
test_parsed_args = parser.parse_args([
'--name', 'threshold_test',
'--type', 'threshold',
'--threshold', '80'
])
self.cli_alarm_create._validate_args(test_parsed_args)
mock_arg.assert_called_once_with(
'Threshold alarm requires -m/--meter-name and '
'--threshold parameters. Meter name can be '
'found in Ceilometer')
@mock.patch.object(argparse.ArgumentParser, 'error')
def test_validate_args_composite(self, mock_arg):
# Cover the test case of the method _validate_args for
# composite
parser = self.cli_alarm_create.get_parser('aodh alarm create')
test_parsed_args = parser.parse_args([
'--name', 'composite_test',
'--type', 'composite'
])
self.cli_alarm_create._validate_args(test_parsed_args)
mock_arg.assert_called_once_with(
'Composite alarm requires --composite-rule parameter')
@mock.patch.object(argparse.ArgumentParser, 'error')
def test_validate_args_gno_agg_by_resources_threshold(self, mock_arg):
# Cover the test case of the method _validate_args for
# gnocchi_aggregation_by_resources_threshold
parser = self.cli_alarm_create.get_parser('aodh alarm create')
test_parsed_args = parser.parse_args([
'--name', 'gnocchi_aggregation_by_resources_threshold_test',
'--type', 'gnocchi_aggregation_by_resources_threshold',
'--metric', 'cpu',
'--aggregation-method', 'last',
'--resource-type', 'generic',
'--threshold', '80'
])
self.cli_alarm_create._validate_args(test_parsed_args)
mock_arg.assert_called_once_with(
'gnocchi_aggregation_by_resources_threshold requires '
'--metric, --threshold, --aggregation-method, --query and '
'--resource-type')
@mock.patch.object(argparse.ArgumentParser, 'error')
def test_validate_args_gno_agg_by_metrics_threshold(self, mock_arg):
# Cover the test case of the method _validate_args for
# gnocchi_aggregation_by_metrics_threshold
parser = self.cli_alarm_create.get_parser('aodh alarm create')
test_parsed_args = parser.parse_args([
'--name', 'gnocchi_aggregation_by_metrics_threshold_test',
'--type', 'gnocchi_aggregation_by_metrics_threshold',
'--resource-type', 'generic',
'--threshold', '80'
])
self.cli_alarm_create._validate_args(test_parsed_args)
mock_arg.assert_called_once_with(
'gnocchi_aggregation_by_metrics_threshold requires '
'--metric, --threshold and --aggregation-method')
@mock.patch.object(argparse.ArgumentParser, 'error')
def test_validate_args_prometheus(self, mock_arg):
# Cover the test case of the method _validate_args for
# prometheus
parser = self.cli_alarm_create.get_parser('aodh alarm create')
test_parsed_args = parser.parse_args([
'--name', 'prom_test',
'--type', 'prometheus',
'--comparison-operator', 'gt',
'--threshold', '666',
])
self.cli_alarm_create._validate_args(test_parsed_args)
mock_arg.assert_called_once_with(
'Prometheus alarm requires --query and --threshold parameters.')
def test_alarm_from_args(self):
# The test case to cover the method _alarm_from_args
parser = self.cli_alarm_create.get_parser('aodh alarm create')
test_parsed_args = parser.parse_args([
'--type', 'event',
'--name', 'alarm_from_args_test',
'--project-id', '01919bbd-8b0e-451c-be28-abe250ae9b1b',
'--user-id', '01919bbd-8b0e-451c-be28-abe250ae9c1c',
'--description', 'For Test',
'--state', 'ok',
'--severity', 'critical',
'--enabled', 'True',
'--alarm-action', 'http://something/alarm',
'--ok-action', 'http://something/ok',
'--repeat-action', 'True',
'--insufficient-data-action',
'http://something/insufficient',
'--time-constraint',
'name=cons1;start="0 11 * * *";duration=300;description=desc1',
'--evaluation-periods', '60',
'--comparison-operator', 'le',
'--threshold', '80',
'--event-type', 'event',
'--query', 'resource=fake-resource-id',
'--granularity', '60',
'--aggregation-method', 'last',
'--metric', 'cpu',
'--resource-id', '01919bbd-8b0e-451c-be28-abe250ae9c1c',
'--resource-type', 'generic',
'--stack-id', '0809ab348-8b0e-451c-be28-abe250ae9c1c',
'--pool-id', '79832aabf-343ba-be28-abe250ae9c1c',
'--autoscaling-group-id', 'abe250ae9c1c-79832aabf-343ba-be28'
])
# Output for the test
alarm = {
'name': 'alarm_from_args_test',
'project_id': '01919bbd-8b0e-451c-be28-abe250ae9b1b',
'user_id': '01919bbd-8b0e-451c-be28-abe250ae9c1c',
'description': 'For Test',
'state': 'ok',
'severity': 'critical',
'enabled': True,
'alarm_actions': ['http://something/alarm'],
'ok_actions': ['http://something/ok'],
'insufficient_data_actions':
['http://something/insufficient'],
'time_constraints': [{'description': 'desc1',
'duration': '300',
'name': 'cons1',
'start': '0 11 * * *'}],
'repeat_actions': True,
'event_rule': {
'event_type': 'event',
'query': [{'field': 'resource',
'op': 'eq',
'type': '',
'value': 'fake-resource-id'}]
},
'threshold_rule': {'comparison_operator': 'le',
'evaluation_periods': 60,
'query': [{'field': 'resource',
'op': 'eq',
'type': '',
'value': 'fake-resource-id'}],
'threshold': 80.0},
'prometheus_rule': {'comparison_operator': 'le',
'query': [{'field': 'resource',
'op': 'eq',
'type': '',
'value': 'fake-resource-id'}],
'threshold': 80.0},
'gnocchi_resources_threshold_rule': {
'granularity': '60',
'metric': 'cpu',
'aggregation_method': 'last',
'evaluation_periods': 60,
'resource_id': '01919bbd-8b0e-451c-be28-abe250ae9c1c',
'comparison_operator': 'le',
'threshold': 80.0,
'resource_type': 'generic'
},
'gnocchi_aggregation_by_metrics_threshold_rule': {
'granularity': '60',
'aggregation_method': 'last',
'evaluation_periods': 60,
'comparison_operator': 'le',
'threshold': 80.0,
'metrics': ['cpu'],
},
'loadbalancer_member_health_rule': {
'autoscaling_group_id': 'abe250ae9c1c-79832aabf-343ba-be28',
'pool_id': '79832aabf-343ba-be28-abe250ae9c1c',
'stack_id': '0809ab348-8b0e-451c-be28-abe250ae9c1c'
},
'gnocchi_aggregation_by_resources_threshold_rule': {
'granularity': '60',
'metric': 'cpu',
'aggregation_method': 'last',
'evaluation_periods': 60,
'comparison_operator': 'le',
'threshold': 80.0,
'query': [{'field': 'resource',
'op': 'eq',
'type': '',
'value': 'fake-resource-id'}],
'resource_type': 'generic'
},
'composite_rule': None,
'type': 'event'
}
alarm_rep = self.cli_alarm_create._alarm_from_args(test_parsed_args)
self.assertEqual(alarm, alarm_rep)
def test_alarm_from_args_for_prometheus(self):
# The test case to cover the method _alarm_from_args
parser = self.cli_alarm_create.get_parser('aodh alarm create')
test_parsed_args = parser.parse_args([
'--name', 'alarm_prom',
'--type', 'prometheus',
'--comparison-operator', 'gt',
'--threshold', '666',
'--query', r'some_metric{some_label="some_value"}'
])
prom_rule = {'comparison_operator': 'gt',
'query': r'some_metric{some_label="some_value"}',
'threshold': 666.0}
alarm_rep = self.cli_alarm_create._alarm_from_args(test_parsed_args)
self.assertEqual(prom_rule, alarm_rep['prometheus_rule'])
def test_validate_time_constraint(self):
starts = ['0 11 * * *', ' 0 11 * * * ',
'"0 11 * * *"', '\'0 11 * * *\'']
for start in starts:
string = 'name=const1;start=%s;duration=1' % start
expected = dict(name='const1',
start='0 11 * * *',
duration='1')
self.assertEqual(
expected,
self.cli_alarm_create.validate_time_constraint(string))
def test_validate_time_constraint_with_bad_format(self):
string = 'name=const2;start="0 11 * * *";duration:2'
self.assertRaises(argparse.ArgumentTypeError,
self.cli_alarm_create.validate_time_constraint,
string)
|
