1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
|
import pytest
from flask import json
from authlib.common.security import generate_token
from authlib.common.urls import url_decode
from authlib.common.urls import urlparse
from authlib.oauth2.rfc6749 import grants
from authlib.oauth2.rfc7636 import CodeChallenge as _CodeChallenge
from authlib.oauth2.rfc7636 import create_s256_code_challenge
from .models import Client
from .models import CodeGrantMixin
from .models import User
from .models import db
from .models import save_authorization_code
from .oauth2_server import TestCase
from .oauth2_server import create_authorization_server
class AuthorizationCodeGrant(CodeGrantMixin, grants.AuthorizationCodeGrant):
TOKEN_ENDPOINT_AUTH_METHODS = ["client_secret_basic", "client_secret_post", "none"]
def save_authorization_code(self, code, request):
return save_authorization_code(code, request)
class CodeChallenge(_CodeChallenge):
SUPPORTED_CODE_CHALLENGE_METHOD = ["plain", "S256", "S128"]
class CodeChallengeTest(TestCase):
def prepare_data(self, token_endpoint_auth_method="none"):
server = create_authorization_server(self.app)
server.register_grant(AuthorizationCodeGrant, [CodeChallenge(required=True)])
user = User(username="foo")
db.session.add(user)
db.session.commit()
client_secret = ""
if token_endpoint_auth_method != "none":
client_secret = "code-secret"
client = Client(
user_id=user.id,
client_id="code-client",
client_secret=client_secret,
)
client.set_client_metadata(
{
"redirect_uris": ["https://a.b"],
"scope": "profile address",
"token_endpoint_auth_method": token_endpoint_auth_method,
"response_types": ["code"],
"grant_types": ["authorization_code"],
}
)
self.authorize_url = "/oauth/authorize?response_type=code&client_id=code-client"
db.session.add(client)
db.session.commit()
def test_missing_code_challenge(self):
self.prepare_data()
rv = self.client.get(self.authorize_url + "&code_challenge_method=plain")
assert "Missing" in rv.location
def test_has_code_challenge(self):
self.prepare_data()
rv = self.client.get(
self.authorize_url
+ "&code_challenge=Zhs2POMonIVVHZteWfoU7cSXQSm0YjghikFGJSDI2_s"
)
assert rv.data == b"ok"
def test_invalid_code_challenge(self):
self.prepare_data()
rv = self.client.get(
self.authorize_url + "&code_challenge=abc&code_challenge_method=plain"
)
assert "Invalid" in rv.location
def test_invalid_code_challenge_method(self):
self.prepare_data()
suffix = "&code_challenge=Zhs2POMonIVVHZteWfoU7cSXQSm0YjghikFGJSDI2_s&code_challenge_method=invalid"
rv = self.client.get(self.authorize_url + suffix)
assert "Unsupported" in rv.location
def test_supported_code_challenge_method(self):
self.prepare_data()
suffix = "&code_challenge=Zhs2POMonIVVHZteWfoU7cSXQSm0YjghikFGJSDI2_s&code_challenge_method=plain"
rv = self.client.get(self.authorize_url + suffix)
assert rv.data == b"ok"
def test_trusted_client_without_code_challenge(self):
self.prepare_data("client_secret_basic")
rv = self.client.get(self.authorize_url)
assert rv.data == b"ok"
rv = self.client.post(self.authorize_url, data={"user_id": "1"})
assert "code=" in rv.location
params = dict(url_decode(urlparse.urlparse(rv.location).query))
code = params["code"]
headers = self.create_basic_header("code-client", "code-secret")
rv = self.client.post(
"/oauth/token",
data={
"grant_type": "authorization_code",
"code": code,
},
headers=headers,
)
resp = json.loads(rv.data)
assert "access_token" in resp
def test_missing_code_verifier(self):
self.prepare_data()
url = (
self.authorize_url
+ "&code_challenge=Zhs2POMonIVVHZteWfoU7cSXQSm0YjghikFGJSDI2_s"
)
rv = self.client.post(url, data={"user_id": "1"})
assert "code=" in rv.location
params = dict(url_decode(urlparse.urlparse(rv.location).query))
code = params["code"]
rv = self.client.post(
"/oauth/token",
data={
"grant_type": "authorization_code",
"code": code,
"client_id": "code-client",
},
)
resp = json.loads(rv.data)
assert "Missing" in resp["error_description"]
def test_trusted_client_missing_code_verifier(self):
self.prepare_data("client_secret_basic")
url = (
self.authorize_url
+ "&code_challenge=Zhs2POMonIVVHZteWfoU7cSXQSm0YjghikFGJSDI2_s"
)
rv = self.client.post(url, data={"user_id": "1"})
assert "code=" in rv.location
params = dict(url_decode(urlparse.urlparse(rv.location).query))
code = params["code"]
headers = self.create_basic_header("code-client", "code-secret")
rv = self.client.post(
"/oauth/token",
data={
"grant_type": "authorization_code",
"code": code,
},
headers=headers,
)
resp = json.loads(rv.data)
assert "Missing" in resp["error_description"]
def test_plain_code_challenge_invalid(self):
self.prepare_data()
url = (
self.authorize_url
+ "&code_challenge=Zhs2POMonIVVHZteWfoU7cSXQSm0YjghikFGJSDI2_s"
)
rv = self.client.post(url, data={"user_id": "1"})
assert "code=" in rv.location
params = dict(url_decode(urlparse.urlparse(rv.location).query))
code = params["code"]
rv = self.client.post(
"/oauth/token",
data={
"grant_type": "authorization_code",
"code": code,
"code_verifier": "bar",
"client_id": "code-client",
},
)
resp = json.loads(rv.data)
assert "Invalid" in resp["error_description"]
def test_plain_code_challenge_failed(self):
self.prepare_data()
url = (
self.authorize_url
+ "&code_challenge=Zhs2POMonIVVHZteWfoU7cSXQSm0YjghikFGJSDI2_s"
)
rv = self.client.post(url, data={"user_id": "1"})
assert "code=" in rv.location
params = dict(url_decode(urlparse.urlparse(rv.location).query))
code = params["code"]
rv = self.client.post(
"/oauth/token",
data={
"grant_type": "authorization_code",
"code": code,
"code_verifier": generate_token(48),
"client_id": "code-client",
},
)
resp = json.loads(rv.data)
assert "failed" in resp["error_description"]
def test_plain_code_challenge_success(self):
self.prepare_data()
code_verifier = generate_token(48)
url = self.authorize_url + "&code_challenge=" + code_verifier
rv = self.client.post(url, data={"user_id": "1"})
assert "code=" in rv.location
params = dict(url_decode(urlparse.urlparse(rv.location).query))
code = params["code"]
rv = self.client.post(
"/oauth/token",
data={
"grant_type": "authorization_code",
"code": code,
"code_verifier": code_verifier,
"client_id": "code-client",
},
)
resp = json.loads(rv.data)
assert "access_token" in resp
def test_s256_code_challenge_success(self):
self.prepare_data()
code_verifier = generate_token(48)
code_challenge = create_s256_code_challenge(code_verifier)
url = self.authorize_url + "&code_challenge=" + code_challenge
url += "&code_challenge_method=S256"
rv = self.client.post(url, data={"user_id": "1"})
assert "code=" in rv.location
params = dict(url_decode(urlparse.urlparse(rv.location).query))
code = params["code"]
rv = self.client.post(
"/oauth/token",
data={
"grant_type": "authorization_code",
"code": code,
"code_verifier": code_verifier,
"client_id": "code-client",
},
)
resp = json.loads(rv.data)
assert "access_token" in resp
def test_not_implemented_code_challenge_method(self):
self.prepare_data()
url = (
self.authorize_url
+ "&code_challenge=Zhs2POMonIVVHZteWfoU7cSXQSm0YjghikFGJSDI2_s"
)
url += "&code_challenge_method=S128"
rv = self.client.post(url, data={"user_id": "1"})
assert "code=" in rv.location
params = dict(url_decode(urlparse.urlparse(rv.location).query))
code = params["code"]
with pytest.raises(RuntimeError):
self.client.post(
"/oauth/token",
data={
"grant_type": "authorization_code",
"code": code,
"code_verifier": generate_token(48),
"client_id": "code-client",
},
)
|
