1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
|
from functools import partial
import pytest
from bleach import clean
clean = partial(clean, tags=['p'], attributes=['style'])
@pytest.mark.parametrize('data, styles, expected', [
(
'font-family: Arial; color: red; float: left; background-color: red;',
['color'],
'color: red;'
),
(
'border: 1px solid blue; color: red; float: left;',
['color'],
'color: red;'
),
(
'border: 1px solid blue; color: red; float: left;',
['color', 'float'],
'color: red; float: left;'
),
(
'color: red; float: left; padding: 1em;',
['color', 'float'],
'color: red; float: left;'
),
(
'color: red; float: left; padding: 1em;',
['color'],
'color: red;'
),
(
'cursor: -moz-grab;',
['cursor'],
'cursor: -moz-grab;'
),
(
'color: hsl(30,100%,50%);',
['color'],
'color: hsl(30,100%,50%);'
),
(
'color: rgba(255,0,0,0.4);',
['color'],
'color: rgba(255,0,0,0.4);'
),
(
"text-overflow: ',' ellipsis;",
['text-overflow'],
"text-overflow: ',' ellipsis;"
),
(
'text-overflow: "," ellipsis;',
['text-overflow'],
'text-overflow: "," ellipsis;'
),
(
'font-family: "Arial";',
['font-family'],
'font-family: "Arial";'
),
])
def test_allowed_css(data, styles, expected):
p_single = '<p style="{0!s}">bar</p>'
p_double = "<p style='{0!s}'>bar</p>"
if '"' in data:
assert clean(p_double.format(data), styles=styles) == p_double.format(expected)
else:
assert clean(p_single.format(data), styles=styles) == p_single.format(expected)
def test_valid_css():
"""The sanitizer should fix missing CSS values."""
styles = ['color', 'float']
assert (
clean('<p style="float: left; color: ">foo</p>', styles=styles) ==
'<p style="float: left;">foo</p>'
)
assert (
clean('<p style="color: float: left;">foo</p>', styles=styles) ==
'<p style="">foo</p>'
)
@pytest.mark.parametrize('data, expected', [
# No url--unchanged
(
'<p style="background: #00D;">foo</p>',
'<p style="background: #00D;">foo</p>'
),
# Verify urls with no quotes, single quotes, and double quotes are all dropped
(
'<p style="background: url(topbanner.png) #00D;">foo</p>',
'<p style="background: #00D;">foo</p>'
),
(
'<p style="background: url(\'topbanner.png\') #00D;">foo</p>',
'<p style="background: #00D;">foo</p>'
),
(
'<p style=\'background: url("topbanner.png") #00D;\'>foo</p>',
'<p style="background: #00D;">foo</p>'
),
# Verify urls with spacing
(
'<p style="background: url( \'topbanner.png\') #00D;">foo</p>',
'<p style="background: #00D;">foo</p>'
),
(
'<p style="background: url(\'topbanner.png\' ) #00D;">foo</p>',
'<p style="background: #00D;">foo</p>'
),
(
'<p style="background: url( \'topbanner.png\' ) #00D;">foo</p>',
'<p style="background: #00D;">foo</p>'
),
(
'<p style="background: url ( \'topbanner.png\' ) #00D;">foo</p>',
'<p style="background: #00D;">foo</p>'
),
# Verify urls with character entities
(
'<p style="background: url	(\'topbanner.png\') #00D;">foo</p>',
'<p style="background: #00D;">foo</p>'
),
])
def test_urls(data, expected):
assert clean(data, styles=['background']) == expected
def test_style_hang():
"""The sanitizer should not hang on any inline styles"""
style = [
'margin-top: 0px;',
'margin-right: 0px;',
'margin-bottom: 1.286em;',
'margin-left: 0px;',
'padding-top: 15px;',
'padding-right: 15px;',
'padding-bottom: 15px;',
'padding-left: 15px;',
'border-top-width: 1px;',
'border-right-width: 1px;',
'border-bottom-width: 1px;',
'border-left-width: 1px;',
'border-top-style: dotted;',
'border-right-style: dotted;',
'border-bottom-style: dotted;',
'border-left-style: dotted;',
'border-top-color: rgb(203, 200, 185);',
'border-right-color: rgb(203, 200, 185);',
'border-bottom-color: rgb(203, 200, 185);',
'border-left-color: rgb(203, 200, 185);',
'background-image: initial;',
'background-attachment: initial;',
'background-origin: initial;',
'background-clip: initial;',
'background-color: rgb(246, 246, 242);',
'overflow-x: auto;',
'overflow-y: auto;',
'font: italic small-caps bolder condensed 16px/3 cursive;',
'background-position: initial initial;',
'background-repeat: initial initial;'
]
html = '<p style="%s">Hello world</p>' % ' '.join(style)
styles = [
'border', 'float', 'overflow', 'min-height', 'vertical-align',
'white-space',
'margin', 'margin-left', 'margin-top', 'margin-bottom', 'margin-right',
'padding', 'padding-left', 'padding-top', 'padding-bottom',
'padding-right',
'background',
'background-color',
'font', 'font-size', 'font-weight', 'text-align', 'text-transform',
]
expected = (
'<p style="'
'margin-top: 0px; '
'margin-right: 0px; '
'margin-bottom: 1.286em; '
'margin-left: 0px; '
'padding-top: 15px; '
'padding-right: 15px; '
'padding-bottom: 15px; '
'padding-left: 15px; '
'background-color: rgb(246, 246, 242); '
'font: italic small-caps bolder condensed 16px/3 cursive;'
'">Hello world</p>'
)
assert clean(html, styles=styles) == expected
@pytest.mark.parametrize('data, styles, expected', [
(
'<p style="font-family: Droid Sans, serif; white-space: pre-wrap;">text</p>',
['font-family', 'white-space'],
'<p style="font-family: Droid Sans, serif; white-space: pre-wrap;">text</p>'
),
(
'<p style="font-family: "Droid Sans", serif; white-space: pre-wrap;">text</p>',
['font-family', 'white-space'],
'<p style=\'font-family: "Droid Sans", serif; white-space: pre-wrap;\'>text</p>'
),
])
def test_css_parsing_with_entities(data, styles, expected):
"""The sanitizer should be ok with character entities"""
assert clean(data, tags=['p'], attributes={'p': ['style']}, styles=styles) == expected
|
