1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387
|
# Copyright 2023 Amazon.com, Inc. or its affiliates. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License"). You
# may not use this file except in compliance with the License. A copy of
# the License is located at
#
# http://aws.amazon.com/apache2.0/
#
# or in the "license" file accompanying this file. This file is
# distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF
# ANY KIND, either express or implied. See the License for the specific
# language governing permissions and limitations under the License.
import logging
import time
from concurrent import futures
from itertools import product
import pytest
from botocore import __version__ as botocore_version
from botocore.config import Config
from tests import ClientHTTPStubber
class UACapHTTPStubber(ClientHTTPStubber):
"""
Wrapper for ClientHTTPStubber that captures UA header from one request.
"""
def __init__(self, obj_with_event_emitter):
super().__init__(obj_with_event_emitter, strict=False)
self.add_response() # expect exactly one request
@property
def captured_ua_string(self):
if len(self.requests) > 0:
return self.requests[0].headers['User-Agent'].decode()
return None
@pytest.mark.parametrize(
'sess_name, sess_version, sess_extra, cfg_extra, cfg_appid',
# Produce every combination of User-Agent related config settings other
# than Config.user_agent which will always be set in this test.
product(
('sess_name', None),
('sess_version', None),
('sess_extra', None),
('cfg_extra', None),
('cfg_appid', None),
),
)
def test_user_agent_from_config_replaces_default(
sess_name,
sess_version,
sess_extra,
cfg_extra,
cfg_appid,
patched_session,
):
# Config.user_agent replaces all parts of the regular User-Agent header
# format except for itself and "extras" set in Session and Config. This
# behavior exists to maintain backwards compatibility for clients who
# expect an exact User-Agent header value.
expected_str = 'my user agent str'
if sess_name:
patched_session.user_agent_name = sess_name
if sess_version:
patched_session.user_agent_version = sess_version
if sess_extra:
patched_session.user_agent_extra = sess_extra
expected_str += f' {sess_extra}'
client_cfg = Config(
user_agent='my user agent str',
user_agent_extra=cfg_extra,
user_agent_appid=cfg_appid,
)
if cfg_extra:
expected_str += f' {cfg_extra}'
client_s3 = patched_session.create_client('s3', config=client_cfg)
with UACapHTTPStubber(client_s3) as stub_client:
client_s3.list_buckets()
assert stub_client.captured_ua_string == expected_str
@pytest.mark.parametrize(
'sess_name, sess_version, cfg_appid',
# Produce every combination of User-Agent related config settings other
# than Config.user_agent which is never set in this test
# (``test_user_agent_from_config_replaces_default`` covers all cases where
# it is set) and Session.user_agent_extra and Config.user_agent_extra
# which both are always set in this test
product(
('sess_name', None),
('sess_version', None),
('cfg_appid', None),
),
)
def test_user_agent_includes_extra(
sess_name,
sess_version,
cfg_appid,
patched_session,
):
# Libraries and apps can use the ``Config.user_agent_extra`` and
# ``Session.user_agent_extra`` to append arbitrary data to the User-Agent
# header. Unless Config.user_agent is also set, these two fields should
# always appear at the end of the header value.
if sess_name:
patched_session.user_agent_name = sess_name
if sess_version:
patched_session.user_agent_version = sess_version
patched_session.user_agent_extra = "sess_extra"
client_cfg = Config(
user_agent=None,
user_agent_extra='cfg_extra',
user_agent_appid=cfg_appid,
)
client_s3 = patched_session.create_client('s3', config=client_cfg)
with UACapHTTPStubber(client_s3) as stub_client:
client_s3.list_buckets()
assert stub_client.captured_ua_string.endswith(' sess_extra cfg_extra')
@pytest.mark.parametrize(
'sess_name, sess_version, sess_extra, cfg_extra',
# Produce every combination of User-Agent related config settings other
# than Config.user_agent which is never set in this test and
# Config.user_agent_appid which is always set in this test.
product(
('sess_name', None),
('sess_version', None),
('sess_extra', None),
('cfg_extra', None),
),
)
def test_user_agent_includes_appid(
sess_name,
sess_version,
sess_extra,
cfg_extra,
patched_session,
):
# The User-Agent header string should always include the value set in
# ``Config.user_agent_appid``, unless ``Config.user_agent`` is also set
# (this latter case is covered in ``test_user_agent_from_config_replaces_default``).
if sess_name:
patched_session.user_agent_name = sess_name
if sess_version:
patched_session.user_agent_version = sess_version
if sess_extra:
patched_session.user_agent_extra = sess_extra
client_cfg = Config(
user_agent=None,
user_agent_appid='123456',
user_agent_extra=cfg_extra,
)
client_s3 = patched_session.create_client('s3', config=client_cfg)
with UACapHTTPStubber(client_s3) as stub_client:
client_s3.list_buckets()
uafields = stub_client.captured_ua_string.split(' ')
assert 'app/123456' in uafields
def test_user_agent_long_appid_yields_warning(patched_session, caplog):
# user_agent_appid config values longer than 50 characters should result
# in a warning
sixtychars = '000000000011111111112222222222333333333344444444445555555555'
assert len(sixtychars) > 50
client_cfg = Config(user_agent_appid=sixtychars)
client_s3 = patched_session.create_client('s3', config=client_cfg)
with UACapHTTPStubber(client_s3):
with caplog.at_level(logging.INFO):
client_s3.list_buckets()
assert (
'The configured value for user_agent_appid exceeds the maximum length'
in caplog.text
)
def test_user_agent_appid_gets_sanitized(patched_session, caplog):
# Parentheses are not valid characters in the user agent string
badchars = '1234('
client_cfg = Config(user_agent_appid=badchars)
client_s3 = patched_session.create_client('s3', config=client_cfg)
with UACapHTTPStubber(client_s3) as stub_client:
with caplog.at_level(logging.INFO):
client_s3.list_buckets()
# given string should be truncated to 50 characters
uafields = stub_client.captured_ua_string.split(' ')
assert 'app/1234-' in uafields
def test_user_agent_has_registered_feature_id(patched_session):
client_s3 = patched_session.create_client('s3')
with UACapHTTPStubber(client_s3) as stub_client:
paginator = client_s3.get_paginator('list_buckets')
# The `paginate()` method registers `'PAGINATOR': 'C'`
for _ in paginator.paginate():
pass
uafields = stub_client.captured_ua_string.split(' ')
feature_field = [field for field in uafields if field.startswith('m/')][0]
feature_list = feature_field[2:].split(',')
assert 'C' in feature_list
def test_registered_feature_ids_dont_bleed_between_requests(patched_session):
client_s3 = patched_session.create_client('s3')
with UACapHTTPStubber(client_s3) as stub_client:
waiter = client_s3.get_waiter('bucket_exists')
# The `wait()` method registers `'WAITER': 'B'`
waiter.wait(Bucket='mybucket')
uafields = stub_client.captured_ua_string.split(' ')
feature_field = [field for field in uafields if field.startswith('m/')][0]
feature_list = feature_field[2:].split(',')
assert 'B' in feature_list
with UACapHTTPStubber(client_s3) as stub_client:
paginator = client_s3.get_paginator('list_buckets')
# The `paginate()` method registers `'PAGINATOR': 'C'`
for _ in paginator.paginate():
pass
uafields = stub_client.captured_ua_string.split(' ')
feature_field = [field for field in uafields if field.startswith('m/')][0]
feature_list = feature_field[2:].split(',')
assert 'C' in feature_list
assert 'B' not in feature_list
def test_registered_feature_ids_dont_bleed_across_threads(patched_session):
client_s3 = patched_session.create_client('s3')
# The client stubber isn't thread-safe because it mutates the client's
# event system. This boolean is a workaround that ensures the paginator
# worker's thread spawns at the same time, but does not actually execute
# its job until the waiter thread finishes first and resets client state.
waiter_done = False
def wait(client, features):
with UACapHTTPStubber(client) as stub_client:
waiter = client.get_waiter('bucket_exists')
# The `wait()` method registers `'WAITER': 'B'`
waiter.wait(Bucket='mybucket')
uafields = stub_client.captured_ua_string.split(' ')
feature_field = [
field for field in uafields if field.startswith('m/')
][0]
features.extend(feature_field[2:].split(','))
nonlocal waiter_done
waiter_done = True
def paginate(client, features):
nonlocal waiter_done
while not waiter_done:
time.sleep(0.5)
with UACapHTTPStubber(client) as stub_client:
paginator = client.get_paginator('list_buckets')
# The `paginate()` method registers `'PAGINATOR': 'C'`
for _ in paginator.paginate():
pass
uafields = stub_client.captured_ua_string.split(' ')
feature_field = [
field for field in uafields if field.startswith('m/')
][0]
features.extend(feature_field[2:].split(','))
waiter_features = []
paginator_features = []
with futures.ThreadPoolExecutor(max_workers=2) as executor:
waiter_future = executor.submit(wait, client_s3, waiter_features)
paginator_future = executor.submit(
paginate, client_s3, paginator_features
)
waiter_future.result()
paginator_future.result()
assert 'B' in waiter_features
assert 'C' not in waiter_features
assert 'C' in paginator_features
assert 'B' not in paginator_features
def test_boto3_user_agent(patched_session):
# emulate Boto3's behavior
botocore_info = f'Botocore/{patched_session.user_agent_version}'
if patched_session.user_agent_extra:
patched_session.user_agent_extra += ' ' + botocore_info
else:
patched_session.user_agent_extra = botocore_info
patched_session.user_agent_name = 'Boto3'
patched_session.user_agent_version = '9.9.9' # Boto3 version
client_s3 = patched_session.create_client('s3')
with UACapHTTPStubber(client_s3) as stub_client:
client_s3.list_buckets()
# The user agent string should start with "Boto3/9.9.9" from the setting
# above, followed by Botocore's version info as metadata ("md/...").
assert stub_client.captured_ua_string.startswith(
f'Boto3/9.9.9 md/Botocore#{botocore_version} '
)
# The regular User-Agent header components for platform, language, ...
# should also be present:
assert ' ua/2.1 ' in stub_client.captured_ua_string
assert ' os/' in stub_client.captured_ua_string
assert ' lang/' in stub_client.captured_ua_string
assert ' cfg/' in stub_client.captured_ua_string
def test_awscli_v1_user_agent(patched_session):
# emulate behavior from awscli.clidriver._set_user_agent_for_session
patched_session.user_agent_name = 'aws-cli'
patched_session.user_agent_version = '1.1.1'
patched_session.user_agent_extra = f'botocore/{botocore_version}'
client_s3 = patched_session.create_client('s3')
with UACapHTTPStubber(client_s3) as stub_client:
client_s3.list_buckets()
# The user agent string should start with "aws-cli/1.1.1" from the setting
# above, followed by Botocore's version info as metadata ("md/...").
assert stub_client.captured_ua_string.startswith(
f'aws-cli/1.1.1 md/Botocore#{botocore_version} '
)
# The regular User-Agent header components for platform, language, ...
# should also be present:
assert ' ua/2.1 ' in stub_client.captured_ua_string
assert ' os/' in stub_client.captured_ua_string
assert ' lang/' in stub_client.captured_ua_string
assert ' cfg/' in stub_client.captured_ua_string
def test_awscli_v2_user_agent(patched_session):
# emulate behavior from awscli.clidriver._set_user_agent_for_session
patched_session.user_agent_name = 'aws-cli'
patched_session.user_agent_version = '2.2.2'
patched_session.user_agent_extra = 'sources/x86_64'
# awscli.clidriver.AWSCLIEntrypoint._run_driver
patched_session.user_agent_extra += ' prompt/off'
# from awscli.clidriver.ServiceOperation._add_customization_to_user_agent
patched_session.user_agent_extra += ' command/service-name.op-name'
client_s3 = patched_session.create_client('s3')
with UACapHTTPStubber(client_s3) as stub_client:
client_s3.list_buckets()
# The user agent string should start with "aws-cli/1.1.1" from the setting
# above, followed by Botocore's version info as metadata ("md/...").
assert stub_client.captured_ua_string.startswith(
f'aws-cli/2.2.2 md/Botocore#{botocore_version} '
)
assert stub_client.captured_ua_string.endswith(
' sources/x86_64 prompt/off command/service-name.op-name'
)
# The regular User-Agent header components for platform, language, ...
# should also be present:
assert ' ua/2.1 ' in stub_client.captured_ua_string
assert ' os/' in stub_client.captured_ua_string
assert ' lang/' in stub_client.captured_ua_string
assert ' cfg/' in stub_client.captured_ua_string
def test_s3transfer_user_agent(patched_session):
# emulate behavior from s3transfer ClientFactory
cfg = Config(user_agent_extra='s3transfer/0.1.2 processpool')
client = patched_session.create_client('s3', config=cfg)
# s3transfer tests make assertions against the _modified_ `user_agent` field
# in ``client.meta.config.user_agent``. See for example
# ``tests.unit.test_processpool.TestClientFactory`` in s3transfer.
assert 'processpool' in client.meta.config.user_agent
def test_chalice_user_agent(patched_session):
# emulate behavior from chalice's cli.factory._add_chalice_user_agent
suffix = f'{patched_session.user_agent_name}/{patched_session.user_agent_version}'
patched_session.user_agent_name = 'aws-chalice'
patched_session.user_agent_version = '0.1.2'
patched_session.user_agent_extra = suffix
client_s3 = patched_session.create_client('s3')
with UACapHTTPStubber(client_s3) as stub_client:
client_s3.list_buckets()
assert stub_client.captured_ua_string.startswith(
f'aws-chalice/0.1.2 md/Botocore#{botocore_version} '
)
|