1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443
|
import shutil
import subprocess
import sys
from pathlib import Path
from unittest import mock
import pytest
from briefcase.exceptions import BriefcaseCommandError
from briefcase.platforms.linux import system
from briefcase.platforms.linux.system import (
LinuxSystemPackageCommand,
debian_multiline_description,
)
from ....utils import create_file
@pytest.fixture
def package_command(dummy_console, first_app, tmp_path):
command = LinuxSystemPackageCommand(
console=dummy_console,
base_path=tmp_path / "base_path",
data_path=tmp_path / "briefcase",
)
command.tools.home_path = tmp_path / "home"
# Mock ABI from packaging system
command._deb_abi = "wonky"
# Mock the app context
command.tools.app_tools[first_app].app_context = mock.MagicMock()
# Mock shutil
command.tools.shutil = mock.MagicMock()
# Make the mock rmtree still remove content
command.tools.shutil.rmtree.side_effect = shutil.rmtree
# Mock not using docker
command.target_image = None
command.extra_docker_build_args = []
return command
@pytest.fixture
def first_app_deb(first_app):
# Mock a debian app
first_app.python_version_tag = "3.10"
first_app.target_vendor_base = "debian"
first_app.packaging_format = "deb"
first_app.glibc_version = "2.99"
first_app.long_description = "Long description\nfor the app"
return first_app
@pytest.fixture
def external_first_app_deb(first_app_deb, tmp_path):
# Make the app external
first_app_deb.sources = None
first_app_deb.external_package_path = tmp_path / "base_path/external/package-deb"
# Move the generated first app to the external location
(tmp_path / "base_path/external").mkdir()
shutil.move(
tmp_path / "base_path/build/first-app/somevendor/surprising/first-app-0.0.1",
tmp_path / "base_path/external/package-deb",
)
return first_app_deb
def test_verify_no_docker(package_command, first_app_deb, monkeypatch):
"""If not using docker, existence of dpkg-deb is verified."""
# Mock the existence of dpkg-deb
package_command.tools.shutil.which = mock.MagicMock(return_value="/mybin/dpkg-deb")
# App tools can be verified
package_command.verify_app_tools(first_app_deb)
# dpkg_deb was inspected
package_command.tools.shutil.which.assert_called_once_with("dpkg-deb")
@pytest.mark.parametrize(
"vendor_base, error_msg",
[
(
"debian",
"Can't find the dpkg tools. Try running `sudo apt install dpkg-dev`.",
),
(None, "Can't find the dpkg-deb tool. Install this first to package the deb."),
],
)
def test_verify_dpkg_deb_missing(
package_command,
first_app_deb,
vendor_base,
error_msg,
monkeypatch,
):
"""If dpkg-deb isn't installed, an error is raised."""
# Mock distro so packager is found or not appropriately
first_app_deb.target_vendor_base = vendor_base
# Mock packager as missing
package_command.tools.shutil.which = mock.MagicMock(return_value="")
# Verifying app tools will raise an error
with pytest.raises(BriefcaseCommandError, match=error_msg):
package_command.verify_app_tools(first_app_deb)
# which was called for dpkg-deb
package_command.tools.shutil.which.assert_called_once_with("dpkg-deb")
def test_verify_docker(package_command, first_app_deb, monkeypatch):
"""If using Docker, no tool checks are needed."""
# Mock using docker
package_command.target_image = "somevendor:surprising"
# Mock the existence of a valid non-docker system Python
# with the same major/minor as the current Python,
# plus the existence of dpkg-deb
python3 = mock.MagicMock()
python3.resolve.return_value = Path(
f"/usr/bin/python{sys.version_info.major}.{sys.version_info.minor}"
)
dpkg_deb = mock.MagicMock()
dpkg_deb.exists.return_value = False
mock_Path = mock.MagicMock(side_effect=[python3, dpkg_deb])
monkeypatch.setattr(system, "Path", mock_Path)
# App tools can be verified
package_command.verify_app_tools(first_app_deb)
# dpkg_deb was not inspected
dpkg_deb.exists.assert_not_called()
@pytest.mark.skipif(sys.platform == "win32", reason="Can't build debs on Windows")
def test_deb_package(package_command, first_app_deb, tmp_path):
"""A deb app can be packaged."""
bundle_path = tmp_path / "base_path/build/first-app/somevendor/surprising"
# Package the app
package_command.package_app(first_app_deb)
# The control file is written
assert (bundle_path / "first-app-0.0.1/DEBIAN/control").exists()
with (bundle_path / "first-app-0.0.1/DEBIAN/control").open(encoding="utf-8") as f:
assert (
f.read()
== "\n".join(
[
"Package: first-app",
"Version: 0.0.1",
"Architecture: wonky",
"Maintainer: Megacorp <maintainer@example.com>",
"Homepage: https://example.com/first-app",
"Description: The first simple app \\ demonstration",
" Long description",
" for the app",
"Depends: libc6 (>=2.99), libpython3.10",
"Section: utils",
"Priority: optional",
]
)
+ "\n"
)
package_command.tools.app_tools[
first_app_deb
].app_context.run.assert_called_once_with(
[
"dpkg-deb",
"--build",
"--root-owner-group",
bundle_path / "first-app-0.0.1",
],
check=True,
cwd=bundle_path,
)
# The deb was moved into the final location
package_command.tools.shutil.move.assert_called_once_with(
bundle_path / "first-app-0.0.1.deb",
tmp_path / "base_path/dist/first-app_0.0.1-1~somevendor-surprising_wonky.deb",
)
def test_deb_re_package(package_command, first_app_deb, tmp_path):
"""A deb app that has previously been packaged can be re-packaged."""
bundle_path = tmp_path / "base_path/build/first-app/somevendor/surprising"
# Create an old control file that will be overwritten.
create_file(bundle_path / "first-app-0.0.1/DEBIAN/control", "Old control content")
# Package the app
package_command.package_app(first_app_deb)
# The control file is re-written
assert (bundle_path / "first-app-0.0.1/DEBIAN/control").exists()
with (bundle_path / "first-app-0.0.1/DEBIAN/control").open(encoding="utf-8") as f:
assert (
f.read()
== "\n".join(
[
"Package: first-app",
"Version: 0.0.1",
"Architecture: wonky",
"Maintainer: Megacorp <maintainer@example.com>",
"Homepage: https://example.com/first-app",
"Description: The first simple app \\ demonstration",
" Long description",
" for the app",
"Depends: libc6 (>=2.99), libpython3.10",
"Section: utils",
"Priority: optional",
]
)
+ "\n"
)
package_command.tools.app_tools[
first_app_deb
].app_context.run.assert_called_once_with(
[
"dpkg-deb",
"--build",
"--root-owner-group",
bundle_path / "first-app-0.0.1",
],
check=True,
cwd=bundle_path,
)
# The deb was moved into the final location
package_command.tools.shutil.move.assert_called_once_with(
bundle_path / "first-app-0.0.1.deb",
tmp_path / "base_path/dist/first-app_0.0.1-1~somevendor-surprising_wonky.deb",
)
def test_deb_package_no_long_description(package_command, first_app_deb, tmp_path):
"""A deb app without a long description raises an error."""
bundle_path = tmp_path / "base_path/build/first-app/somevendor/surprising"
# Delete the long description
first_app_deb.long_description = None
# Packaging the app will fail
with pytest.raises(
BriefcaseCommandError,
match=r"App configuration does not define `long_description`. Debian projects require a long description.",
):
package_command.package_app(first_app_deb)
# The control file won't be written
assert not (bundle_path / "first-app-0.0.1/DEBIAN/control").exists()
@pytest.mark.parametrize(
"input, output",
[
["", ""],
["one line", "one line"],
["first line\nsecond line", "first line\n second line"],
["first line\n\nsecond line", "first line\n second line"],
["first line\n \nsecond line", "first line\n second line"],
],
)
def test_multiline_long_description(input, output):
"""Multiline debian descriptions are transformed."""
assert debian_multiline_description(input) == output
def test_deb_package_extra_requirements(package_command, first_app_deb, tmp_path):
"""A deb app can be packaged with extra runtime requirements and configuration
options."""
bundle_path = tmp_path / "base_path/build/first-app/somevendor/surprising"
# Add system requirements and other optional settings.
first_app_deb.system_runtime_requires = ["first", "second (>=1.2.3)"]
first_app_deb.revision = 42
first_app_deb.system_section = "Funny stuff"
# Package the app
package_command.package_app(first_app_deb)
# The control file is written
assert (bundle_path / "first-app-0.0.1/DEBIAN/control").exists()
with (bundle_path / "first-app-0.0.1/DEBIAN/control").open(encoding="utf-8") as f:
assert (
f.read()
== "\n".join(
[
"Package: first-app",
"Version: 0.0.1",
"Architecture: wonky",
"Maintainer: Megacorp <maintainer@example.com>",
"Homepage: https://example.com/first-app",
"Description: The first simple app \\ demonstration",
" Long description",
" for the app",
"Depends: libc6 (>=2.99), libpython3.10, first, second (>=1.2.3)",
"Section: Funny stuff",
"Priority: optional",
]
)
+ "\n"
)
package_command.tools.app_tools[
first_app_deb
].app_context.run.assert_called_once_with(
[
"dpkg-deb",
"--build",
"--root-owner-group",
bundle_path / "first-app-0.0.1",
],
check=True,
cwd=bundle_path,
)
# The deb was moved into the final location
package_command.tools.shutil.move.assert_called_once_with(
bundle_path / "first-app-0.0.1.deb",
tmp_path / "base_path/dist/first-app_0.0.1-42~somevendor-surprising_wonky.deb",
)
def test_deb_package_failure(package_command, first_app_deb, tmp_path):
"""If a packaging doesn't succeed, an error is raised."""
bundle_path = tmp_path / "base_path/build/first-app/somevendor/surprising"
# Mock a packaging failure
package_command.tools.app_tools[
first_app_deb
].app_context.run.side_effect = subprocess.CalledProcessError(
cmd="dpkg-deb ...", returncode=-1
)
# Package the app
with pytest.raises(
BriefcaseCommandError, match=r"Error while building .deb package for first-app."
):
package_command.package_app(first_app_deb)
# The control file is written
assert (bundle_path / "first-app-0.0.1/DEBIAN/control").exists()
with (bundle_path / "first-app-0.0.1/DEBIAN/control").open(encoding="utf-8") as f:
assert (
f.read()
== "\n".join(
[
"Package: first-app",
"Version: 0.0.1",
"Architecture: wonky",
"Maintainer: Megacorp <maintainer@example.com>",
"Homepage: https://example.com/first-app",
"Description: The first simple app \\ demonstration",
" Long description",
" for the app",
"Depends: libc6 (>=2.99), libpython3.10",
"Section: utils",
"Priority: optional",
]
)
+ "\n"
)
# The call to package was made
package_command.tools.app_tools[
first_app_deb
].app_context.run.assert_called_once_with(
[
"dpkg-deb",
"--build",
"--root-owner-group",
bundle_path / "first-app-0.0.1",
],
check=True,
cwd=bundle_path,
)
# The deb wasn't built, so it wasn't moved.
package_command.tools.shutil.move.assert_not_called()
@pytest.mark.skipif(sys.platform == "win32", reason="Can't build debs on Windows")
def test_external_deb_package_docker(package_command, external_first_app_deb, tmp_path):
"""An external app cannot be packaged as a deb using Docker."""
bundle_path = tmp_path / "base_path/build/first-app/somevendor/surprising"
package_path = tmp_path / "base_path/external/package-deb"
# Package the app
package_command.package_app(external_first_app_deb)
# The control file is written
assert (package_path / "DEBIAN/control").exists()
with (package_path / "DEBIAN/control").open(encoding="utf-8") as f:
assert (
f.read()
== "\n".join(
[
"Package: first-app",
"Version: 0.0.1",
"Architecture: wonky",
"Maintainer: Megacorp <maintainer@example.com>",
"Homepage: https://example.com/first-app",
"Description: The first simple app \\ demonstration",
" Long description",
" for the app",
"Depends: libc6 (>=2.99), libpython3.10",
"Section: utils",
"Priority: optional",
]
)
+ "\n"
)
package_command.tools.app_tools[
external_first_app_deb
].app_context.run.assert_called_once_with(
[
"dpkg-deb",
"--build",
"--root-owner-group",
package_path,
],
check=True,
cwd=bundle_path,
)
# The deb was moved into the final location
package_command.tools.shutil.move.assert_called_once_with(
tmp_path / "base_path/external/package-deb.deb",
tmp_path / "base_path/dist/first-app_0.0.1-1~somevendor-surprising_wonky.deb",
)
|