1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
|
import subprocess
import pytest
from briefcase.console import LogLevel
from briefcase.exceptions import BriefcaseCommandError
from ...utils import create_file, file_content
@pytest.mark.parametrize("verbose", [True, False])
def test_thin_binary(dummy_command, verbose, tmp_path, capsys):
"""A thin binary is left as-is."""
if verbose:
dummy_command.console.verbosity = LogLevel.VERBOSE
# Create a source binary.
create_file(tmp_path / "path/to/file.dylib", "dylib-original")
# Mock the result of the "lipo info" call.
dummy_command.tools.subprocess.check_output.return_value = (
"Non-fat file: path/to/file.dylib is architecture: gothic\n"
)
# Thin the binary; this is effectively a no-op
dummy_command.ensure_thin_binary(
tmp_path / "path/to/file.dylib",
arch="gothic",
)
# Lipo -info was invoked
dummy_command.tools.subprocess.check_output.assert_called_once_with(
[
"lipo",
"-info",
tmp_path / "path/to/file.dylib",
],
)
# Lipo -thin was *not* invoked
dummy_command.tools.subprocess.run.assert_not_called()
# The original file is unmodified.
assert file_content(tmp_path / "path/to/file.dylib") == "dylib-original"
# Output only happens if in debug mode
output = capsys.readouterr().out.split("\n")
assert len(output) == (2 if verbose else 1)
@pytest.mark.parametrize("verbose", [True, False])
def test_fat_dylib(dummy_command, verbose, tmp_path, capsys):
"""A fat binary library can be thinned."""
if verbose:
dummy_command.console.verbosity = LogLevel.VERBOSE
# Create a source binary.
create_file(tmp_path / "path/to/file.dylib", "dylib-fat")
# Mock the result of the "lipo info" call.
dummy_command.tools.subprocess.check_output.return_value = (
"Architectures in the fat file: path/to/file.dylib are: modern gothic\n"
)
# Mock the result of successfully thinning a library
def thin_dylib(*args, **kwargs):
create_file(args[0][args[0].index("-output") + 1], "dylib-thin")
dummy_command.tools.subprocess.run.side_effect = thin_dylib
# Thin the binary to the "gothic" architecture
dummy_command.ensure_thin_binary(
tmp_path / "path/to/file.dylib",
arch="gothic",
)
# Lipo -info was invoked
dummy_command.tools.subprocess.check_output.assert_called_once_with(
[
"lipo",
"-info",
tmp_path / "path/to/file.dylib",
],
)
# Lipo -thin was invoked
dummy_command.tools.subprocess.run.assert_called_once_with(
[
"lipo",
"-thin",
"gothic",
"-output",
tmp_path / "path/to/file.dylib.gothic",
tmp_path / "path/to/file.dylib",
],
check=True,
)
# The original file now has the thinned content.
assert file_content(tmp_path / "path/to/file.dylib") == "dylib-thin"
# Output only happens if in debug mode
output = capsys.readouterr().out.split("\n")
assert len(output) == (2 if verbose else 1)
@pytest.mark.parametrize("verbose", [True, False])
def test_fat_dylib_arch_mismatch(dummy_command, verbose, tmp_path, capsys):
"""If a fat binary doesn't contain the target architecture, an error is raised."""
if verbose:
dummy_command.console.verbosity = LogLevel.VERBOSE
# Create a source binary.
create_file(tmp_path / "path/to/file.dylib", "dylib-fat")
# Mock the result of the "lipo info" call.
dummy_command.tools.subprocess.check_output.return_value = (
"Architectures in the fat file: path/to/file.dylib are: modern artdeco\n"
)
# Thin the binary to the "gothic" architecture. This will raise an exception
with pytest.raises(
BriefcaseCommandError,
match=r"file\.dylib does not contain a gothic slice",
):
dummy_command.ensure_thin_binary(
tmp_path / "path/to/file.dylib",
arch="gothic",
)
# Lipo -info was invoked
dummy_command.tools.subprocess.check_output.assert_called_once_with(
[
"lipo",
"-info",
tmp_path / "path/to/file.dylib",
],
)
# Lipo -thin was *not* invoked
dummy_command.tools.subprocess.run.assert_not_called()
@pytest.mark.parametrize("verbose", [True, False])
def test_fat_dylib_unknown_info(dummy_command, verbose, tmp_path, capsys):
"""If the lipo info call succeeds, but generates unknown output, an error is
raised."""
if verbose:
dummy_command.console.verbosity = LogLevel.VERBOSE
# Create a source binary.
create_file(tmp_path / "path/to/file.dylib", "dylib-fat")
# Mock the result of the "lipo info" call.
dummy_command.tools.subprocess.check_output.return_value = (
"This is unexpected output...\n"
)
# Thin the binary to the "gothic" architecture. This will raise an exception
with pytest.raises(
BriefcaseCommandError,
match=r"Unable to determine architectures in .*file\.dylib",
):
dummy_command.ensure_thin_binary(
tmp_path / "path/to/file.dylib",
arch="gothic",
)
# Lipo -info was invoked
dummy_command.tools.subprocess.check_output.assert_called_once_with(
[
"lipo",
"-info",
tmp_path / "path/to/file.dylib",
],
)
# Lipo -thin was *not* invoked
dummy_command.tools.subprocess.run.assert_not_called()
def test_lipo_info_fail(dummy_command, tmp_path):
"""If lipo can't inspect a binary, an error is raised."""
# Create a source binary.
create_file(tmp_path / "path/to/file.dylib", "dylib-fat")
# Mock the result of the "lipo info" call.
dummy_command.tools.subprocess.check_output.side_effect = (
subprocess.CalledProcessError(cmd="lipo -info", returncode=-1)
)
# Thin the binary to the "gothic" architecture. This will raise an exception
with pytest.raises(
BriefcaseCommandError, match=r"Unable to inspect architectures in .*file\.dylib"
):
dummy_command.ensure_thin_binary(
tmp_path / "path/to/file.dylib",
arch="gothic",
)
# Lipo -info was invoked
dummy_command.tools.subprocess.check_output.assert_called_once_with(
[
"lipo",
"-info",
tmp_path / "path/to/file.dylib",
],
)
# Lipo -thin was not invoked
dummy_command.tools.subprocess.run.assert_not_called()
@pytest.mark.parametrize("verbose", [True, False])
def test_lipo_thin_fail(dummy_command, verbose, tmp_path, capsys):
"""If lipo fails thinning the binary, an error is raised."""
if verbose:
dummy_command.console.verbosity = LogLevel.VERBOSE
# Create a source binary.
create_file(tmp_path / "path/to/file.dylib", "dylib-fat")
# Mock the result of the "lipo -info" call.
dummy_command.tools.subprocess.check_output.return_value = (
"Architectures in the fat file: path/to/file.dylib are: modern gothic\n"
)
# Mock the result of the failed "lipo -thin" call.
dummy_command.tools.subprocess.run.side_effect = subprocess.CalledProcessError(
cmd="lipo -thin", returncode=-1
)
# Thin the binary to the "gothic" architecture. This will raise an exception
with pytest.raises(
BriefcaseCommandError,
match=r"Unable to create thin binary from .*file.dylib",
):
dummy_command.ensure_thin_binary(
tmp_path / "path/to/file.dylib",
arch="gothic",
)
# Lipo -info was invoked
dummy_command.tools.subprocess.check_output.assert_called_once_with(
[
"lipo",
"-info",
tmp_path / "path/to/file.dylib",
],
)
# Lipo -thin was invoked
dummy_command.tools.subprocess.run.assert_called_once_with(
[
"lipo",
"-thin",
"gothic",
"-output",
tmp_path / "path/to/file.dylib.gothic",
tmp_path / "path/to/file.dylib",
],
check=True,
)
# The original file is unmodified.
assert file_content(tmp_path / "path/to/file.dylib") == "dylib-fat"
# Output only happens if in debug mode
output = capsys.readouterr().out.split("\n")
assert len(output) == (2 if verbose else 1)
|
