1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412
|
from django.contrib.admin.sites import AdminSite
from django.contrib.auth.models import User
from django.contrib.messages.storage.fallback import FallbackStorage
from django.contrib.sessions.middleware import SessionMiddleware
from django.db import models as django_models
from django.test import RequestFactory, TestCase
from testapp import models
from testapp.admin import ModelAdmin, UnorderedModelAdmin
from tree_queries.admin import MOVE_POSITIONS, MOVE_POSITIONS_PARENT_ONLY, MoveNodeForm
class TreeAdminTestCase(TestCase):
def setUp(self):
self.factory = RequestFactory()
self.site = AdminSite()
# Create superuser for admin access
self.user = User.objects.create_superuser("admin", "admin@test.com", "password")
# Set up test tree structure with ordering
self.root = models.Model.objects.create(name="root", order=10)
self.child1 = models.Model.objects.create(
name="child1", parent=self.root, order=10
)
self.child2 = models.Model.objects.create(
name="child2", parent=self.root, order=20
)
self.grandchild = models.Model.objects.create(
name="grandchild", parent=self.child1, order=10
)
# Set up unordered tree structure
self.unordered_root = models.UnorderedModel.objects.create(name="root")
self.unordered_child = models.UnorderedModel.objects.create(
name="child", parent=self.unordered_root
)
def setup_request(self, request):
"""Set up request with proper middleware for messages and sessions."""
# Set up session
middleware = SessionMiddleware(lambda r: None)
middleware.process_request(request)
request.session.save()
# Set up messages
request._messages = FallbackStorage(request)
request.user = self.user
return request
def test_position_field_configuration(self):
"""Test different position field configurations."""
# Model with position field
admin = ModelAdmin(models.Model, self.site)
assert admin.position_field == "order"
assert admin.position_field
# Model without position field
admin = UnorderedModelAdmin(models.UnorderedModel, self.site)
assert admin.position_field is None
assert not admin.position_field
def test_move_positions_with_ordering(self):
"""Test available move positions when ordering is controllable."""
admin = ModelAdmin(models.Model, self.site)
request = self.factory.get("/")
request.user = self.user
# Should show all positions
move_column_html = admin.move_column(self.child1)
for key in MOVE_POSITIONS:
assert f'value="{key}"' in move_column_html
def test_move_positions_without_ordering(self):
"""Test available move positions when ordering is not controllable."""
admin = UnorderedModelAdmin(models.UnorderedModel, self.site)
request = self.factory.get("/")
request.user = self.user
# Should show only parent-only positions
move_column_html = admin.move_column(self.unordered_child)
for key in MOVE_POSITIONS_PARENT_ONLY:
assert f'value="{key}"' in move_column_html
# Should not show sibling positions
assert 'value="before"' not in move_column_html
assert 'value="after"' not in move_column_html
# Should show "move to root" button for child nodes in models without ordering
assert "move-to-root" in move_column_html
# But root nodes should NOT show the "move to root" button
root_move_column_html = admin.move_column(self.unordered_root)
assert "move-to-root" not in root_move_column_html
def test_tree_admin_context(self):
"""Test the context provided to JavaScript."""
admin = ModelAdmin(models.Model, self.site)
request = self.factory.get("/")
request.user = self.user
context = admin.tree_admin_context(request)
assert context["initiallyCollapseDepth"] == 1
# Test without ordering
admin = UnorderedModelAdmin(models.UnorderedModel, self.site)
context = admin.tree_admin_context(request)
assert context["initiallyCollapseDepth"] == 1
def test_move_node_form_with_ordering(self):
"""Test move node form validation with ordering field."""
admin = ModelAdmin(models.Model, self.site)
request = self.factory.post(
"/admin/testapp/model/move-node/",
{
"move": self.grandchild.pk,
"relative_to": self.child2.pk,
"position": "before",
},
)
request.user = self.user
form = MoveNodeForm(request.POST, modeladmin=admin, request=request)
assert form.is_valid()
# Test all valid positions
for position in MOVE_POSITIONS:
form = MoveNodeForm(
{
"move": self.grandchild.pk,
"relative_to": self.child2.pk,
"position": position,
},
modeladmin=admin,
request=request,
)
assert form.is_valid(), f"Position {position} should be valid"
def test_move_node_form_without_ordering(self):
"""Test move node form validation without ordering field."""
admin = UnorderedModelAdmin(models.UnorderedModel, self.site)
request = self.factory.post(
"/admin/testapp/unorderedmodel/move-node/",
{
"move": self.unordered_child.pk,
"relative_to": self.unordered_root.pk,
"position": "child",
},
)
request.user = self.user
form = MoveNodeForm(request.POST, modeladmin=admin, request=request)
assert form.is_valid()
# Test only valid positions for unordered model
for position in MOVE_POSITIONS_PARENT_ONLY:
form = MoveNodeForm(
{
"move": self.unordered_child.pk,
"relative_to": self.unordered_root.pk,
"position": position,
},
modeladmin=admin,
request=request,
)
assert form.is_valid(), f"Position {position} should be valid"
# Test invalid positions for unordered model
form = MoveNodeForm(
{
"move": self.unordered_child.pk,
"relative_to": self.unordered_root.pk,
"position": "before",
},
modeladmin=admin,
request=request,
)
assert not form.is_valid()
# Test that "root" is valid without relative_to
form = MoveNodeForm(
{"move": self.unordered_child.pk, "position": "root"},
modeladmin=admin,
request=request,
)
assert form.is_valid()
# Test that "root" is also valid with relative_to (for backward compatibility)
form = MoveNodeForm(
{
"move": self.unordered_child.pk,
"relative_to": self.unordered_root.pk,
"position": "root",
},
modeladmin=admin,
request=request,
)
assert form.is_valid()
# Test that non-root positions require relative_to
form = MoveNodeForm(
{"move": self.unordered_child.pk, "position": "child"},
modeladmin=admin,
request=request,
)
assert not form.is_valid()
class MoveOperationTestCase(TestCase):
def setUp(self):
self.factory = RequestFactory()
self.site = AdminSite()
self.user = User.objects.create_superuser("admin", "admin@test.com", "password")
# Create test tree with ordering
self.root = models.Model.objects.create(name="root", order=10)
self.child1 = models.Model.objects.create(
name="child1", parent=self.root, order=10
)
self.child2 = models.Model.objects.create(
name="child2", parent=self.root, order=20
)
self.child3 = models.Model.objects.create(
name="child3", parent=self.root, order=30
)
def setup_request(self, request):
"""Set up request with proper middleware for messages and sessions."""
# Set up session
middleware = SessionMiddleware(lambda r: None)
middleware.process_request(request)
request.session.save()
# Set up messages
request._messages = FallbackStorage(request)
request.user = self.user
return request
def test_move_before(self):
"""Test moving a node before another sibling."""
admin = ModelAdmin(models.Model, self.site)
request = self.factory.post("/test/")
request.user = self.user
form = MoveNodeForm(
{
"move": self.child3.pk,
"relative_to": self.child1.pk,
"position": "before",
},
modeladmin=admin,
request=request,
)
# Verify form is valid
assert form.is_valid()
# Test the move logic directly
move = form.cleaned_data["move"]
relative_to = form.cleaned_data["relative_to"]
form.cleaned_data["position"]
# Simulate the move logic
move.parent = relative_to.parent
position_field = admin.position_field
siblings_qs = relative_to.__class__._default_manager.filter(
parent=relative_to.parent
)
siblings_qs.filter(**{
f"{position_field}__gte": getattr(relative_to, position_field)
}).update(**{position_field: django_models.F(position_field) + 10})
setattr(move, position_field, getattr(relative_to, position_field))
move.save()
# Refresh from database
self.child3.refresh_from_db()
self.child1.refresh_from_db()
# child3 should now have the same order as child1 originally had
assert self.child3.order == 10
def test_move_after(self):
"""Test moving a node after another sibling."""
admin = ModelAdmin(models.Model, self.site)
request = self.factory.post(
"/admin/testapp/model/move-node/",
{
"move": self.child1.pk,
"relative_to": self.child2.pk,
"position": "after",
},
)
request = self.setup_request(request)
form = MoveNodeForm(request.POST, modeladmin=admin, request=request)
result = form.process()
assert result == "ok"
# Refresh from database
self.child1.refresh_from_db()
# child1 should now be positioned after child2
assert self.child1.order == 30 # child2.order + 10
def test_move_first_child(self):
"""Test moving a node as first child."""
# Create a new node to move
new_child = models.Model.objects.create(name="new_child", order=100)
admin = ModelAdmin(models.Model, self.site)
request = self.factory.post(
"/admin/testapp/model/move-node/",
{
"move": new_child.pk,
"relative_to": self.root.pk,
"position": "first-child",
},
)
request = self.setup_request(request)
form = MoveNodeForm(request.POST, modeladmin=admin, request=request)
result = form.process()
assert result == "ok"
# Refresh from database
new_child.refresh_from_db()
# Should be child of root and have order 10 (first position)
assert new_child.parent == self.root
assert new_child.order == 10
def test_move_last_child(self):
"""Test moving a node as last child."""
new_child = models.Model.objects.create(name="new_child", order=100)
admin = ModelAdmin(models.Model, self.site)
request = self.factory.post(
"/admin/testapp/model/move-node/",
{
"move": new_child.pk,
"relative_to": self.root.pk,
"position": "last-child",
},
)
request = self.setup_request(request)
form = MoveNodeForm(request.POST, modeladmin=admin, request=request)
result = form.process()
assert result == "ok"
# Refresh from database
new_child.refresh_from_db()
# Should be child of root
assert new_child.parent == self.root
def test_move_to_root_without_ordering(self):
"""Test moving a node to root level when no ordering is available."""
# Use unordered model
root = models.UnorderedModel.objects.create(name="root")
child = models.UnorderedModel.objects.create(name="child", parent=root)
admin = UnorderedModelAdmin(models.UnorderedModel, self.site)
request = self.factory.post(
"/admin/testapp/unorderedmodel/move-node/",
{
"move": child.pk,
"position": "root", # No relative_to needed for root moves
},
)
request = self.setup_request(request)
form = MoveNodeForm(request.POST, modeladmin=admin, request=request)
result = form.process()
assert result == "ok"
# Refresh from database
child.refresh_from_db()
# Should now be at root level
assert child.parent is None
def test_move_as_child_without_ordering(self):
"""Test moving a node as child when no ordering is available."""
root1 = models.UnorderedModel.objects.create(name="root1")
root2 = models.UnorderedModel.objects.create(name="root2")
child = models.UnorderedModel.objects.create(name="child", parent=root1)
admin = UnorderedModelAdmin(models.UnorderedModel, self.site)
request = self.factory.post(
"/admin/testapp/unorderedmodel/move-node/",
{"move": child.pk, "relative_to": root2.pk, "position": "child"},
)
request = self.setup_request(request)
form = MoveNodeForm(request.POST, modeladmin=admin, request=request)
result = form.process()
assert result == "ok"
# Refresh from database
child.refresh_from_db()
# Should now be child of root2
assert child.parent == root2
|