1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
|
from django.conf import settings
from django.contrib.flatpages.forms import FlatpageForm
from django.contrib.flatpages.models import FlatPage
from django.contrib.sites.models import Site
from django.test import TestCase, modify_settings, override_settings
from django.utils import translation
@modify_settings(INSTALLED_APPS={"append": ["django.contrib.flatpages"]})
@override_settings(SITE_ID=1)
class FlatpageAdminFormTests(TestCase):
@classmethod
def setUpTestData(cls):
# don't use the manager because we want to ensure the site exists
# with pk=1, regardless of whether or not it already exists.
cls.site1 = Site(pk=1, domain="example.com", name="example.com")
cls.site1.save()
def setUp(self):
# Site fields cache needs to be cleared after flatpages is added to
# INSTALLED_APPS
Site._meta._expire_cache()
self.form_data = {
"title": "A test page",
"content": "This is a test",
"sites": [settings.SITE_ID],
}
def test_flatpage_admin_form_url_validation(self):
"The flatpage admin form correctly validates urls"
self.assertTrue(
FlatpageForm(data=dict(url="/new_flatpage/", **self.form_data)).is_valid()
)
self.assertTrue(
FlatpageForm(
data=dict(url="/some.special~chars/", **self.form_data)
).is_valid()
)
self.assertTrue(
FlatpageForm(
data=dict(url="/some.very_special~chars-here/", **self.form_data)
).is_valid()
)
self.assertFalse(
FlatpageForm(data=dict(url="/a space/", **self.form_data)).is_valid()
)
self.assertFalse(
FlatpageForm(data=dict(url="/a % char/", **self.form_data)).is_valid()
)
self.assertFalse(
FlatpageForm(data=dict(url="/a ! char/", **self.form_data)).is_valid()
)
self.assertFalse(
FlatpageForm(data=dict(url="/a & char/", **self.form_data)).is_valid()
)
self.assertFalse(
FlatpageForm(data=dict(url="/a ? char/", **self.form_data)).is_valid()
)
def test_flatpage_requires_leading_slash(self):
form = FlatpageForm(data=dict(url="no_leading_slash/", **self.form_data))
with translation.override("en"):
self.assertFalse(form.is_valid())
self.assertEqual(form.errors["url"], ["URL is missing a leading slash."])
@override_settings(
APPEND_SLASH=True, MIDDLEWARE=["django.middleware.common.CommonMiddleware"]
)
def test_flatpage_requires_trailing_slash_with_append_slash(self):
form = FlatpageForm(data=dict(url="/no_trailing_slash", **self.form_data))
with translation.override("en"):
self.assertEqual(
form.fields["url"].help_text,
"Example: “/about/contact/”. Make sure to have leading and "
"trailing slashes.",
)
self.assertFalse(form.is_valid())
self.assertEqual(form.errors["url"], ["URL is missing a trailing slash."])
@override_settings(
APPEND_SLASH=False, MIDDLEWARE=["django.middleware.common.CommonMiddleware"]
)
def test_flatpage_doesnt_requires_trailing_slash_without_append_slash(self):
form = FlatpageForm(data=dict(url="/no_trailing_slash", **self.form_data))
self.assertTrue(form.is_valid())
with translation.override("en"):
self.assertEqual(
form.fields["url"].help_text,
"Example: “/about/contact”. Make sure to have a leading slash.",
)
def test_flatpage_admin_form_url_uniqueness_validation(self):
"""
The flatpage admin form correctly enforces url uniqueness among
flatpages of the same site.
"""
data = dict(url="/myflatpage1/", **self.form_data)
FlatpageForm(data=data).save()
f = FlatpageForm(data=data)
with translation.override("en"):
self.assertFalse(f.is_valid())
self.assertEqual(
f.errors,
{
"__all__": [
"Flatpage with url /myflatpage1/ already exists for site "
"example.com"
]
},
)
def test_flatpage_admin_form_edit(self):
"""
Existing flatpages can be edited in the admin form without triggering
the url-uniqueness validation.
"""
existing = FlatPage.objects.create(
url="/myflatpage1/", title="Some page", content="The content"
)
existing.sites.add(settings.SITE_ID)
data = dict(url="/myflatpage1/", **self.form_data)
f = FlatpageForm(data=data, instance=existing)
self.assertTrue(f.is_valid(), f.errors)
updated = f.save()
self.assertEqual(updated.title, "A test page")
def test_flatpage_nosites(self):
data = dict(url="/myflatpage1/", **self.form_data)
data.update({"sites": ""})
f = FlatpageForm(data=data)
self.assertFalse(f.is_valid())
self.assertEqual(
f.errors, {"sites": [translation.gettext("This field is required.")]}
)
|
