1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410
|
import typing
from enum import Enum
from unittest import mock
import pytest
from django import __version__ as DJANGO_VERSION
from django.utils.translation import gettext_lazy as _
from rest_framework import generics, mixins, serializers, viewsets
from rest_framework.decorators import action
from rest_framework.views import APIView
try:
from django.db.models.enums import IntegerChoices, TextChoices
except ImportError:
TextChoices = object # type: ignore # django < 3.0 handling
IntegerChoices = object # type: ignore # django < 3.0 handling
from drf_spectacular.plumbing import _load_enum_name_overrides, list_hash, load_enum_name_overrides
from drf_spectacular.utils import OpenApiParameter, extend_schema
from tests import assert_schema, generate_schema
language_choices = (
('en', 'en'),
('es', 'es'),
('ru', 'ru'),
('cn', 'cn'),
)
blank_null_language_choices = (
('en', 'en'),
('es', 'es'),
('ru', 'ru'),
('cn', 'cn'),
('', 'not provided'),
(None, 'unknown'),
)
vote_choices = (
(1, 'Positive'),
(0, 'Neutral'),
(-1, 'Negative'),
)
language_list = ['en']
class LanguageEnum(Enum):
EN = 'en'
class LanguageStrEnum(str, Enum):
EN = 'en'
class LanguageChoices(TextChoices):
EN = 'en'
blank_null_language_list = ['en', '', None]
class BlankNullLanguageEnum(Enum):
EN = 'en'
BLANK = ''
NULL = None
class BlankNullLanguageStrEnum(str, Enum):
EN = 'en'
BLANK = ''
# These will still be included since the values get cast to strings so 'None' != None
NULL = None
if '3' < DJANGO_VERSION < '5':
# Django 5 added a sanity check that prohibits None
class BlankNullLanguageChoices(TextChoices):
EN = 'en'
BLANK = ''
# These will still be included since the values get cast to strings so 'None' != None
NULL = None
class ASerializer(serializers.Serializer):
language = serializers.ChoiceField(choices=language_choices)
vote = serializers.ChoiceField(choices=vote_choices)
class BSerializer(serializers.Serializer):
language = serializers.ChoiceField(choices=language_choices, allow_blank=True, allow_null=True)
class AViewset(mixins.ListModelMixin, viewsets.GenericViewSet):
serializer_class = ASerializer
@extend_schema(responses=BSerializer)
@action(detail=False, serializer_class=BSerializer)
def selection(self, request):
pass # pragma: no cover
def test_postprocessing(no_warnings):
schema = generate_schema('a', AViewset)
assert_schema(schema, 'tests/test_postprocessing.yml')
@mock.patch(
'drf_spectacular.settings.spectacular_settings.ENUM_ADD_EXPLICIT_BLANK_NULL_CHOICE', False
)
def test_no_blank_and_null_in_enum_choices(no_warnings):
schema = generate_schema('a', AViewset)
assert 'NullEnum' not in schema['components']['schemas']
assert 'BlankEnum' not in schema['components']['schemas']
assert 'oneOf' not in schema['components']['schemas']['B']['properties']['language']
@mock.patch('drf_spectacular.settings.spectacular_settings.ENUM_NAME_OVERRIDES', {
'LanguageEnum': 'tests.test_postprocessing.language_choices'
})
def test_global_enum_naming_override(no_warnings, clear_caches):
# the override will prevent the warning for multiple names
class XSerializer(serializers.Serializer):
foo = serializers.ChoiceField(choices=language_choices)
bar = serializers.ChoiceField(choices=language_choices)
class XView(generics.RetrieveAPIView):
serializer_class = XSerializer
schema = generate_schema('/x', view=XView)
assert 'LanguageEnum' in schema['components']['schemas']['X']['properties']['foo']['$ref']
assert 'LanguageEnum' in schema['components']['schemas']['X']['properties']['bar']['$ref']
assert len(schema['components']['schemas']) == 2
@mock.patch('drf_spectacular.settings.spectacular_settings.ENUM_NAME_OVERRIDES', {
'LanguageEnum': 'tests.test_postprocessing.blank_null_language_choices'
})
def test_global_enum_naming_override_with_blank_and_none(no_warnings, clear_caches):
"""Test that choices with blank values can still have their name overridden."""
class XSerializer(serializers.Serializer):
foo = serializers.ChoiceField(choices=blank_null_language_choices)
bar = serializers.ChoiceField(choices=blank_null_language_choices)
class XView(generics.RetrieveAPIView):
serializer_class = XSerializer
schema = generate_schema('/x', view=XView)
foo_data = schema['components']['schemas']['X']['properties']['foo']
bar_data = schema['components']['schemas']['X']['properties']['bar']
assert len(foo_data['oneOf']) == 3
assert len(bar_data['oneOf']) == 3
foo_ref_values = [ref_object['$ref'] for ref_object in foo_data['oneOf']]
bar_ref_values = [ref_object['$ref'] for ref_object in bar_data['oneOf']]
assert foo_ref_values == [
'#/components/schemas/LanguageEnum',
'#/components/schemas/BlankEnum',
'#/components/schemas/NullEnum'
]
assert bar_ref_values == [
'#/components/schemas/LanguageEnum',
'#/components/schemas/BlankEnum',
'#/components/schemas/NullEnum'
]
def test_enum_name_reuse_warning(capsys):
class XSerializer(serializers.Serializer):
foo = serializers.ChoiceField(choices=language_choices)
bar = serializers.ChoiceField(choices=language_choices)
class XView(generics.RetrieveAPIView):
serializer_class = XSerializer
generate_schema('/x', view=XView)
assert 'encountered multiple names for the same choice set' in capsys.readouterr().err
def test_enum_collision_without_override(capsys):
class XSerializer(serializers.Serializer):
foo = serializers.ChoiceField(choices=[('A', 'A')])
class YSerializer(serializers.Serializer):
foo = serializers.ChoiceField(choices=[('A', 'A'), ('B', 'B')])
class ZSerializer(serializers.Serializer):
foo = serializers.ChoiceField(choices=[('A', 'A'), ('B', 'B')])
class XAPIView(APIView):
@extend_schema(responses=ZSerializer)
def get(self, request):
pass # pragma: no cover
@extend_schema(request=XSerializer, responses=YSerializer)
def post(self, request):
pass # pragma: no cover
generate_schema('x', view=XAPIView)
assert 'enum naming encountered a non-optimally resolvable' in capsys.readouterr().err
def test_resolvable_enum_collision(no_warnings):
class XSerializer(serializers.Serializer):
foo = serializers.ChoiceField(choices=[('A', 'A')])
class YSerializer(serializers.Serializer):
foo = serializers.ChoiceField(choices=[('A', 'A'), ('B', 'B')])
class XAPIView(APIView):
@extend_schema(request=XSerializer, responses=YSerializer)
def post(self, request):
pass # pragma: no cover
schema = generate_schema('x', view=XAPIView)
assert 'XFooEnum' in schema['components']['schemas']
assert 'YFooEnum' in schema['components']['schemas']
@mock.patch('drf_spectacular.settings.spectacular_settings.COMPONENT_SPLIT_PATCH', True)
@mock.patch('drf_spectacular.settings.spectacular_settings.COMPONENT_SPLIT_REQUEST', True)
def test_enum_resolvable_collision_with_patched_and_request_splits():
class XSerializer(serializers.Serializer):
foo = serializers.ChoiceField(choices=[('A', 'A')])
class YSerializer(serializers.Serializer):
foo = serializers.ChoiceField(choices=[('A', 'A'), ('B', 'B')])
class XViewset(viewsets.GenericViewSet):
@extend_schema(request=XSerializer, responses=YSerializer)
def create(self, request):
pass # pragma: no cover
@extend_schema(
request=XSerializer,
responses=YSerializer,
parameters=[OpenApiParameter('id', int, OpenApiParameter.PATH)]
)
def partial_update(self, request):
pass # pragma: no cover
schema = generate_schema('/x', XViewset)
components = schema['components']['schemas']
assert 'XFooEnum' in components and 'YFooEnum' in components
assert '/XFooEnum' in components['XRequest']['properties']['foo']['$ref']
assert '/XFooEnum' in components['PatchedXRequest']['properties']['foo']['$ref']
def test_enum_override_variations(no_warnings):
enum_override_variations = [
('language_list', [('en', 'en')]),
('LanguageEnum', [('en', 'EN')]),
('LanguageStrEnum', [('en', 'EN')]),
]
if DJANGO_VERSION > '3':
enum_override_variations += [
('LanguageChoices', [('en', 'En')]),
('LanguageChoices.choices', [('en', 'En')])
]
for variation, expected_hashed_keys in enum_override_variations:
with mock.patch(
'drf_spectacular.settings.spectacular_settings.ENUM_NAME_OVERRIDES',
{'LanguageEnum': f'tests.test_postprocessing.{variation}'}
):
_load_enum_name_overrides.cache_clear()
assert list_hash(expected_hashed_keys) in load_enum_name_overrides()
def test_enum_override_variations_with_blank_and_null(no_warnings):
enum_override_variations = [
('blank_null_language_list', [('en', 'en')]),
('BlankNullLanguageEnum', [('en', 'EN')]),
('BlankNullLanguageStrEnum', [('en', 'EN'), ('None', 'NULL')])
]
if '3' < DJANGO_VERSION < '5':
# Django 5 added a sanity check that prohibits None
enum_override_variations += [
('BlankNullLanguageChoices', [('en', 'En'), ('None', 'Null')]),
('BlankNullLanguageChoices.choices', [('en', 'En'), ('None', 'Null')])
]
for variation, expected_hashed_keys in enum_override_variations:
with mock.patch(
'drf_spectacular.settings.spectacular_settings.ENUM_NAME_OVERRIDES',
{'LanguageEnum': f'tests.test_postprocessing.{variation}'}
):
_load_enum_name_overrides.cache_clear()
# Should match after None and blank strings are removed
assert list_hash(expected_hashed_keys) in load_enum_name_overrides()
@mock.patch('drf_spectacular.settings.spectacular_settings.ENUM_NAME_OVERRIDES', {
'LanguageEnum': 'tests.test_postprocessing.NOTEXISTING'
})
def test_enum_override_loading_fail(capsys, clear_caches):
load_enum_name_overrides()
assert 'unable to load choice override for LanguageEnum' in capsys.readouterr().err
@pytest.mark.skipif(DJANGO_VERSION < '3', reason='Not available before Django 3.0')
def test_textchoice_annotation(no_warnings):
class QualityChoices(TextChoices):
GOOD = 'GOOD'
BAD = 'BAD'
class XSerializer(serializers.Serializer):
quality_levels = serializers.SerializerMethodField()
def get_quality_levels(self, obj) -> typing.List[QualityChoices]:
return [QualityChoices.GOOD, QualityChoices.BAD] # pragma: no cover
class XAPIView(APIView):
@extend_schema(responses=XSerializer)
def get(self, request):
pass # pragma: no cover
schema = generate_schema('x', view=XAPIView)
assert 'QualityLevelsEnum' in schema['components']['schemas']
assert schema['components']['schemas']['X']['properties']['quality_levels'] == {
'type': 'array',
'items': {'$ref': '#/components/schemas/QualityLevelsEnum'},
'readOnly': True
}
def test_uuid_choices(no_warnings):
import uuid
class XSerializer(serializers.Serializer):
foo = serializers.ChoiceField(
choices=[
(uuid.UUID('93d7527f-de3c-4a76-9cc2-5578675630d4'), 'baz'),
(uuid.UUID('47a4b873-409e-4e43-81d5-fafc3faeb849'), 'bar')
]
)
class XAPIView(APIView):
@extend_schema(responses=XSerializer)
def get(self, request):
pass # pragma: no cover
schema = generate_schema('x', view=XAPIView)
assert 'FooEnum' in schema['components']['schemas']
assert schema['components']['schemas']['FooEnum']['enum'] == [
uuid.UUID('93d7527f-de3c-4a76-9cc2-5578675630d4'),
uuid.UUID('47a4b873-409e-4e43-81d5-fafc3faeb849')
]
@pytest.mark.skipif(DJANGO_VERSION < '3', reason='Not available before Django 3.0')
def test_equal_choices_different_semantics(no_warnings):
class Health(IntegerChoices):
OK = 0
FAIL = 1
class Status(IntegerChoices):
GREEN = 0
RED = 1
class Test(IntegerChoices):
A = 0, _("test group A")
B = 1, _("test group B")
class XSerializer(serializers.Serializer):
some_health = serializers.ChoiceField(choices=Health.choices)
some_status = serializers.ChoiceField(choices=Status.choices)
some_test = serializers.ChoiceField(choices=Test.choices)
class XAPIView(APIView):
@extend_schema(responses=XSerializer)
def get(self, request):
pass # pragma: no cover
# This should not generate a warning even though the enum list is identical
# in both Enums. We now also differentiate the Enums by their labels.
schema = generate_schema('x', view=XAPIView)
assert schema['components']['schemas']['SomeHealthEnum'] == {
'enum': [0, 1], 'type': 'integer', 'description': '* `0` - Ok\n* `1` - Fail'
}
assert schema['components']['schemas']['SomeStatusEnum'] == {
'enum': [0, 1], 'type': 'integer', 'description': '* `0` - Green\n* `1` - Red'
}
assert schema['components']['schemas']['SomeTestEnum'] == {
'enum': [0, 1], 'type': 'integer', 'description': '* `0` - test group A\n* `1` - test group B',
}
@mock.patch('drf_spectacular.settings.spectacular_settings.ENUM_NAME_OVERRIDES', {
'VoteChoices': 'tests.test_postprocessing.vote_choices'
})
def test_enum_suffix(no_warnings, clear_caches):
"""Test that enums generated have the suffix from the settings."""
# check variations of suffix
enum_suffix_variations = ['Type', 'Enum', 'Testing', '']
for variation in enum_suffix_variations:
with mock.patch('drf_spectacular.settings.spectacular_settings.ENUM_SUFFIX', variation):
schema = generate_schema('a', AViewset)
assert f'Null{variation}' in schema['components']['schemas']
assert f'Blank{variation}' in schema['components']['schemas']
assert f'Language{variation}' in schema['components']['schemas']
# vote choices is overridden, so should not have the suffix added
assert f'Vote{variation}' not in schema['components']['schemas']
assert 'VoteChoices' in schema['components']['schemas']
|