1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540
|
from typing import Union
from unittest import mock
import pytest
from django.db import models
from django.urls import path
from rest_framework import mixins, serializers, views, viewsets
from rest_framework.authentication import BaseAuthentication
from rest_framework.decorators import action, api_view
from rest_framework.schemas import AutoSchema as DRFAutoSchema
from rest_framework.views import APIView
from drf_spectacular.types import OpenApiTypes
from drf_spectacular.utils import (
OpenApiParameter, OpenApiRequest, PolymorphicProxySerializer, extend_schema, extend_schema_view,
inline_serializer,
)
from tests import generate_schema
from tests.models import SimpleModel, SimpleSerializer
def test_serializer_name_reuse(capsys):
from rest_framework import routers
router = routers.SimpleRouter()
def x1():
class XSerializer(serializers.Serializer):
uuid = serializers.UUIDField()
return XSerializer
def x2():
class XSerializer(serializers.Serializer):
integer = serializers.IntegerField()
return XSerializer
class X1Viewset(mixins.ListModelMixin, viewsets.GenericViewSet):
serializer_class = x1()
router.register('x1', X1Viewset, basename='x1')
class X2Viewset(mixins.ListModelMixin, viewsets.GenericViewSet):
serializer_class = x2()
router.register('x2', X2Viewset, basename='x2')
generate_schema(None, patterns=router.urls)
stderr = capsys.readouterr().err
assert 'Encountered 2 components with identical names "X" and different identities' in stderr
def test_owned_serializer_naming_override_with_ref_name_collision(warnings):
class XSerializer(serializers.Serializer):
x = serializers.UUIDField()
class YSerializer(serializers.Serializer):
x = serializers.IntegerField()
class Meta:
ref_name = 'X' # already used above
class XAPIView(APIView):
@extend_schema(request=XSerializer, responses=YSerializer)
def post(self, request):
pass # pragma: no cover
generate_schema('x', view=XAPIView)
def test_no_queryset_warn(capsys):
class X1Serializer(serializers.Serializer):
uuid = serializers.UUIDField()
class X1Viewset(viewsets.ReadOnlyModelViewSet):
serializer_class = X1Serializer
generate_schema('x1', X1Viewset)
stderr = capsys.readouterr().err
assert (
'could not derive type of path parameter "id" because it '
'is untyped and obtaining queryset from the viewset failed.'
) in stderr
def test_path_param_not_in_model(capsys):
class XViewset(viewsets.ReadOnlyModelViewSet):
serializer_class = SimpleSerializer
queryset = SimpleModel.objects.none()
@action(detail=True, url_path='meta/(?P<ephemeral>[^/.]+)', methods=['POST'])
def meta_param(self, request, ephemeral, pk):
pass # pragma: no cover
generate_schema('x1', XViewset)
stderr = capsys.readouterr().err
assert 'no such field' in stderr
assert 'XViewset' in stderr
def test_no_authentication_scheme_registered(capsys):
class XAuth(BaseAuthentication):
pass # pragma: no cover
class XSerializer(serializers.Serializer):
uuid = serializers.UUIDField()
class XViewset(mixins.ListModelMixin, viewsets.GenericViewSet):
serializer_class = XSerializer
authentication_classes = [XAuth]
generate_schema('x', XViewset)
stderr = capsys.readouterr().err
assert 'no OpenApiAuthenticationExtension registered' in stderr
assert 'XViewset' in stderr
def test_serializer_not_found(capsys):
class XViewset(mixins.ListModelMixin, viewsets.GenericViewSet):
pass # pragma: no cover
generate_schema('x', XViewset)
assert (
'Error [XViewset]: exception raised while getting serializer.'
) in capsys.readouterr().err
def test_extend_schema_unknown_class(capsys):
class DoesNotCompute:
pass # pragma: no cover
class X1Viewset(viewsets.GenericViewSet):
@extend_schema(responses={200: DoesNotCompute})
def list(self, request):
pass # pragma: no cover
generate_schema('x1', X1Viewset)
assert 'Expected either a serializer' in capsys.readouterr().err
def test_extend_schema_unknown_class2(capsys):
class DoesNotCompute:
pass # pragma: no cover
class X1Viewset(viewsets.GenericViewSet):
@extend_schema(responses=DoesNotCompute)
def list(self, request):
pass # pragma: no cover
generate_schema('x1', X1Viewset)
assert 'Expected either a serializer' in capsys.readouterr().err
def test_no_serializer_class_on_apiview(capsys):
class XView(views.APIView):
def get(self, request):
pass # pragma: no cover
generate_schema('x', view=XView)
assert 'Error [XView]: unable to guess serializer.' in capsys.readouterr().err
def test_unable_to_follow_field_source_through_intermediate_property_warning(capsys):
class FailingFieldSourceTraversalModel1(models.Model):
@property
def x(self): # missing type hint emits warning
return # pragma: no cover
class XSerializer(serializers.ModelSerializer):
x = serializers.ReadOnlyField(source='x.y')
class Meta:
model = FailingFieldSourceTraversalModel1
fields = '__all__'
class XAPIView(APIView):
@extend_schema(responses=XSerializer)
def get(self, request):
pass # pragma: no cover
generate_schema('x', view=XAPIView)
assert (
'[XAPIView > XSerializer]: could not follow field source through intermediate property'
) in capsys.readouterr().err
def test_unable_to_derive_function_type_warning(capsys):
class FailingFieldSourceTraversalModel2(models.Model):
@property
def x(self): # missing type hint emits warning
return # pragma: no cover
class XSerializer(serializers.ModelSerializer):
x = serializers.ReadOnlyField()
y = serializers.SerializerMethodField()
def get_y(self):
return # pragma: no cover
class Meta:
model = FailingFieldSourceTraversalModel2
fields = '__all__'
class XAPIView(APIView):
@extend_schema(responses=XSerializer)
def get(self, request):
pass # pragma: no cover
generate_schema('x', view=XAPIView)
stderr = capsys.readouterr().err
assert '[XAPIView > XSerializer]: unable to resolve type hint for function "x"' in stderr
assert '[XAPIView > XSerializer]: unable to resolve type hint for function "get_y"' in stderr
def test_unable_to_traverse_union_type_hint(capsys):
class Foo:
foo_value: int = 1
class Bar:
pass
class FailingFieldSourceTraversalModel3(models.Model):
@property
def foo_or_bar(self) -> Union[Foo, Bar]: # type: ignore
pass # pragma: no cover
class XSerializer(serializers.ModelSerializer):
foo_value = serializers.ReadOnlyField(source='foo_or_bar.foo_value')
class Meta:
model = FailingFieldSourceTraversalModel3
fields = '__all__'
class XAPIView(APIView):
@extend_schema(responses=XSerializer)
def get(self, request):
pass # pragma: no cover
generate_schema('foo_value', view=XAPIView)
stderr = capsys.readouterr().err
assert 'could not traverse Union type' in stderr
assert 'Foo' in stderr
assert 'Bar' in stderr
def test_operation_id_collision_resolution(capsys):
@extend_schema(responses=OpenApiTypes.FLOAT)
@api_view(['GET'])
def view_func(request, format=None):
pass # pragma: no cover
urlpatterns = [
path('pi/<int:foo>', view_func),
path('pi/', view_func),
]
schema = generate_schema(None, patterns=urlpatterns)
assert schema['paths']['/pi/']['get']['operationId'] == 'pi_retrieve'
assert schema['paths']['/pi/{foo}']['get']['operationId'] == 'pi_retrieve_2'
assert 'operationId "pi_retrieve" has collisions' in capsys.readouterr().err
@mock.patch('rest_framework.settings.api_settings.DEFAULT_SCHEMA_CLASS', DRFAutoSchema)
def test_compatible_auto_schema_class_on_view(no_warnings):
@extend_schema(responses=OpenApiTypes.FLOAT)
@api_view(['GET'])
def view_func(request):
pass # pragma: no cover
with pytest.raises(AssertionError) as excinfo:
generate_schema('/x/', view_function=view_func)
assert "Incompatible AutoSchema" in str(excinfo.value)
def test_extend_schema_view_on_missing_view_method(capsys):
@extend_schema_view(
post=extend_schema(tags=['tag'])
)
class XAPIView(APIView):
def get(self, request):
pass # pragma: no cover
generate_schema('x', view=XAPIView)
stderr = capsys.readouterr().err
assert '@extend_schema_view argument "post" was not found on view' in stderr
def test_polymorphic_proxy_subserializer_missing_type_field(capsys):
class IncompleteSerializer(serializers.Serializer):
field = serializers.IntegerField() # missing field named type
class XAPIView(APIView):
@extend_schema(
responses=PolymorphicProxySerializer(
component_name='Broken',
serializers=[IncompleteSerializer],
resource_type_field_name='type',
)
)
def get(self, request):
pass # pragma: no cover
generate_schema('x', view=XAPIView)
stderr = capsys.readouterr().err
assert 'sub-serializer Incomplete of Broken must contain' in stderr
@pytest.mark.parametrize('resource_type_field_name', ['field', None])
def test_polymorphic_proxy_serializer_misconfig(capsys, resource_type_field_name):
class XSerializer(serializers.Serializer):
field = serializers.IntegerField() # missing field named type
class XAPIView(APIView):
@extend_schema(
responses=PolymorphicProxySerializer(
component_name='Broken',
serializers=[XSerializer(many=True)],
resource_type_field_name=resource_type_field_name,
)
)
def get(self, request):
pass # pragma: no cover
generate_schema('x', view=XAPIView)
stderr = capsys.readouterr().err
assert 'following usage pattern is necessary: PolymorphicProxySerializer' in stderr
def test_warning_operation_id_on_extend_schema_view(capsys):
from drf_spectacular.drainage import GENERATOR_STATS
@extend_schema(operation_id='Invalid', responses=int)
class XAPIView(APIView):
def get(self, request):
pass # pragma: no cover
generate_schema('x', view=XAPIView)
stderr = capsys.readouterr().err
# check basic emittance of error message to stdout
assert 'using @extend_schema on viewset class XAPIView with parameters' in stderr
# check that delayed error message was persisted on view class
assert getattr(XAPIView, '_spectacular_annotation', {}).get('errors')
# check that msg survived pre-generation warning/error cache reset
assert 'using @extend_schema on viewset' in list(GENERATOR_STATS._error_cache.keys())[0]
def test_warning_request_body_not_resolvable(capsys):
class Dummy:
pass
@extend_schema(request=Dummy)
@api_view(['POST'])
def view_func(request, format=None):
pass # pragma: no cover
generate_schema('x', view_function=view_func)
stderr = capsys.readouterr().err
assert 'could not resolve request body for POST /x' in stderr
def test_response_header_warnings(capsys):
@extend_schema(
request=OpenApiTypes.ANY,
responses=OpenApiTypes.ANY,
parameters=[OpenApiParameter(name='test', response=True)]
)
@api_view(['POST'])
def view_func(request, format=None):
pass # pragma: no cover
generate_schema('x', view_function=view_func)
stderr = capsys.readouterr().err
assert 'incompatible location type ignored' in stderr
def test_unknown_base_field_warning(capsys):
class UnknownField(serializers.Field):
pass
class XSerializer(serializers.Serializer):
field = UnknownField()
@extend_schema(request=XSerializer, responses=XSerializer)
@api_view(['POST'])
def view_func(request, format=None):
pass # pragma: no cover
generate_schema('x', view_function=view_func)
stderr = capsys.readouterr().err
assert 'could not resolve serializer field' in stderr
def test_warning_read_only_field_on_non_model_serializer(capsys):
class XSerializer(serializers.Serializer):
field = serializers.ReadOnlyField()
class XViewSet(viewsets.ModelViewSet):
serializer_class = XSerializer
queryset = SimpleModel.objects.all()
# test validity of serializer construction
serializer = XSerializer(instance={'field': 1})
serializer.data
generate_schema('x', XViewSet)
stderr = capsys.readouterr().err
assert 'Could not derive type for ReadOnlyField "field"' in stderr
def test_warning_missing_lookup_field_on_model_serializer(capsys):
class XViewSet(viewsets.ModelViewSet):
serializer_class = SimpleSerializer
queryset = SimpleModel.objects.all()
lookup_field = 'non_existent_field'
generate_schema('x', XViewSet)
stderr = capsys.readouterr().err
assert (
'could not derive type of path parameter "non_existent_field" because model '
'"tests.models.SimpleModel" contained no such field.'
) in stderr
@mock.patch(
'drf_spectacular.settings.spectacular_settings.PATH_CONVERTER_OVERRIDES', {'int': object}
)
def test_invalid_path_converter_override(capsys):
@extend_schema(responses=OpenApiTypes.FLOAT)
@api_view(['GET'])
def pi(request, foo):
pass # pragma: no cover
urlpatterns = [path('/a/<int:var>/', pi)]
generate_schema(None, patterns=urlpatterns)
stderr = capsys.readouterr().err
assert 'Unable to use path converter override for "int".' in stderr
def test_malformed_vendor_extensions(capsys):
@extend_schema(
responses=None,
extensions={'foo': 'not-prefixed'}
)
@api_view(['GET'])
def view_func(request, format=None):
pass # pragma: no cover
generate_schema('x', view_function=view_func)
stderr = capsys.readouterr().err
assert 'invalid extension \'foo\'. vendor extensions must start with' in stderr
def test_serializer_method_missing(capsys):
class XSerializer(serializers.Serializer):
some_field = serializers.SerializerMethodField()
@extend_schema(responses=XSerializer)
@api_view(['GET'])
def view_func(request):
pass # pragma: no cover
generate_schema('x', view_function=view_func)
stderr = capsys.readouterr().err
assert 'SerializerMethodField "some_field" is missing required method "get_some_field"' in stderr
def test_invalid_field_names(capsys):
@extend_schema(
responses=inline_serializer(
'Name with spaces',
fields={'test': serializers.CharField()}
),
)
@api_view(['GET'])
def view_func(request, format=None):
pass # pragma: no cover
generate_schema('/x/', view_function=view_func)
stderr = capsys.readouterr().err
assert 'illegal characters' in stderr
@pytest.mark.parametrize('type_arg,many', [
(SimpleSerializer, True),
(SimpleSerializer(many=True), None),
(serializers.ListSerializer(child=serializers.CharField()), None),
(serializers.ListField(child=serializers.CharField()), None),
])
def test_invalid_parameter_types(capsys, type_arg, many):
@extend_schema(
request=OpenApiTypes.ANY,
responses=OpenApiTypes.ANY,
parameters=[OpenApiParameter(name='test', type=type_arg, many=many)]
)
@api_view(['POST'])
def view_func(request, format=None):
pass # pragma: no cover
generate_schema('/x/', view_function=view_func)
stderr = capsys.readouterr().err
assert 'parameter "test"' in stderr
def test_primary_key_related_field_without_serializer_meta(capsys):
class XSerializer(serializers.Serializer):
field = serializers.PrimaryKeyRelatedField(read_only=True)
@extend_schema(responses=XSerializer, request=XSerializer)
@api_view(['GET'])
def view_func(request, format=None):
pass # pragma: no cover
generate_schema('/x/', view_function=view_func)
stderr = capsys.readouterr().err
assert 'Could not derive type for under-specified PrimaryKeyRelatedField "field"' in stderr
def test_request_encoding_on_invalid_content_type(capsys):
class XSerializer(serializers.Serializer):
field = serializers.MultipleChoiceField(choices=[1, 2, 3, 4])
@extend_schema(
request={
'application/msgpack': OpenApiRequest(
request=XSerializer,
encoding={"field": {"style": "form", "explode": True}},
)
},
responses=XSerializer
)
@api_view(['POST'])
def view_func(request, format=None):
pass # pragma: no cover
generate_schema('/x/', view_function=view_func)
stderr = capsys.readouterr().err
assert 'Encodings object on media types other than' in stderr
|