1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368
|
# Licensed to Elasticsearch B.V. under one or more contributor
# license agreements. See the NOTICE file distributed with
# this work for additional information regarding copyright
# ownership. Elasticsearch B.V. licenses this file to you under
# the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
import logging
import logging.config
from unittest import mock
import pytest
import json
import time
import random
import ecs_logging
from io import StringIO
@pytest.fixture(scope="function")
def logger():
return logging.getLogger(f"test-logger-{time.time():f}-{random.random():f}")
def make_record():
record = logging.LogRecord(
name="logger-name",
level=logging.DEBUG,
pathname="/path/file.py",
lineno=10,
msg="%d: %s",
args=(1, "hello"),
func="test_function",
exc_info=None,
)
record.created = 1584713566
record.msecs = 123
return record
def test_record_formatted(spec_validator):
formatter = ecs_logging.StdlibFormatter(exclude_fields=["process"])
assert spec_validator(formatter.format(make_record())) == (
'{"@timestamp":"2020-03-20T14:12:46.123Z","log.level":"debug","message":"1: hello","ecs.version":"1.6.0",'
'"log":{"logger":"logger-name","origin":{"file":{"line":10,"name":"file.py"},"function":"test_function"},'
'"original":"1: hello"}}'
)
def test_extra_global_is_merged(spec_validator):
formatter = ecs_logging.StdlibFormatter(
exclude_fields=["process"], extra={"environment": "dev"}
)
assert spec_validator(formatter.format(make_record())) == (
'{"@timestamp":"2020-03-20T14:12:46.123Z","log.level":"debug","message":"1: hello","ecs.version":"1.6.0",'
'"environment":"dev",'
'"log":{"logger":"logger-name","origin":{"file":{"line":10,"name":"file.py"},"function":"test_function"},'
'"original":"1: hello"}}'
)
def test_can_be_overridden(spec_validator):
class CustomFormatter(ecs_logging.StdlibFormatter):
def format_to_ecs(self, record):
ecs_dict = super().format_to_ecs(record)
ecs_dict["custom"] = "field"
return ecs_dict
formatter = CustomFormatter(exclude_fields=["process"])
assert spec_validator(formatter.format(make_record())) == (
'{"@timestamp":"2020-03-20T14:12:46.123Z","log.level":"debug","message":"1: hello",'
'"custom":"field","ecs.version":"1.6.0","log":{"logger":"logger-name","origin":'
'{"file":{"line":10,"name":"file.py"},"function":"test_function"},"original":"1: hello"}}'
)
def test_can_be_set_on_handler():
stream = StringIO()
handler = logging.StreamHandler(stream)
handler.setFormatter(ecs_logging.StdlibFormatter(exclude_fields=["process"]))
handler.handle(make_record())
assert stream.getvalue() == (
'{"@timestamp":"2020-03-20T14:12:46.123Z","log.level":"debug","message":"1: hello",'
'"ecs.version":"1.6.0","log":{"logger":"logger-name","origin":{"file":{"line":10,'
'"name":"file.py"},"function":"test_function"},"original":"1: hello"}}\n'
)
@mock.patch("time.time_ns")
@mock.patch("time.time")
def test_extra_is_merged(time, time_ns, logger):
time.return_value = 1584720997.187709
time_ns.return_value = time.return_value * 1_000_000_000
stream = StringIO()
handler = logging.StreamHandler(stream)
handler.setFormatter(
ecs_logging.StdlibFormatter(exclude_fields=["process", "tls.client"])
)
logger.addHandler(handler)
logger.setLevel(logging.INFO)
logger.info(
"hey world",
extra={
"tls": {
"cipher": "AES",
"client": {"hash": {"md5": "0F76C7F2C55BFD7D8E8B8F4BFBF0C9EC"}},
},
"tls.established": True,
"tls.client.certificate": "cert",
},
)
ecs = json.loads(stream.getvalue().rstrip())
assert isinstance(ecs["log"]["origin"]["file"].pop("line"), int)
assert ecs == {
"@timestamp": "2020-03-20T16:16:37.187Z",
"ecs.version": "1.6.0",
"log.level": "info",
"log": {
"logger": logger.name,
"origin": {
"file": {"name": "test_stdlib_formatter.py"},
"function": "test_extra_is_merged",
},
"original": "hey world",
},
"message": "hey world",
"tls": {"cipher": "AES", "established": True},
}
@pytest.mark.parametrize("kwargs", [{}, {"stack_trace_limit": None}])
def test_stack_trace_limit_default(kwargs, logger):
def f():
g()
def g():
h()
def h():
raise ValueError("error!")
stream = StringIO()
handler = logging.StreamHandler(stream)
handler.setFormatter(ecs_logging.StdlibFormatter(**kwargs))
logger.addHandler(handler)
logger.setLevel(logging.DEBUG)
try:
f()
except ValueError:
logger.info("there was an error", exc_info=True)
ecs = json.loads(stream.getvalue().rstrip())
error_stack_trace = ecs["error"].pop("stack_trace")
assert all(x in error_stack_trace for x in ("f()", "g()", "h()"))
@pytest.mark.parametrize("stack_trace_limit", [0, False])
def test_stack_trace_limit_disabled(stack_trace_limit, logger):
stream = StringIO()
handler = logging.StreamHandler(stream)
handler.setFormatter(
ecs_logging.StdlibFormatter(stack_trace_limit=stack_trace_limit)
)
logger.addHandler(handler)
logger.setLevel(logging.DEBUG)
try:
raise ValueError("error!")
except ValueError:
logger.info("there was an error", exc_info=True)
ecs = json.loads(stream.getvalue().rstrip())
assert ecs["error"] == {"message": "error!", "type": "ValueError"}
assert ecs["log.level"] == "info"
assert ecs["message"] == "there was an error"
assert ecs["log"]["original"] == "there was an error"
def test_exc_info_false_does_not_raise(logger):
stream = StringIO()
handler = logging.StreamHandler(stream)
handler.setFormatter(ecs_logging.StdlibFormatter())
logger.addHandler(handler)
logger.setLevel(logging.DEBUG)
logger.info("there was %serror", "no ", exc_info=False)
ecs = json.loads(stream.getvalue().rstrip())
assert ecs["log.level"] == "info"
assert ecs["message"] == "there was no error"
assert "error" not in ecs
def test_stack_trace_limit_traceback(logger):
def f():
g()
def g():
h()
def h():
raise ValueError("error!")
stream = StringIO()
handler = logging.StreamHandler(stream)
handler.setFormatter(ecs_logging.StdlibFormatter(stack_trace_limit=2))
logger.addHandler(handler)
logger.setLevel(logging.DEBUG)
try:
f()
except ValueError:
logger.info("there was an error", exc_info=True)
ecs = json.loads(stream.getvalue().rstrip())
error_stack_trace = ecs["error"].pop("stack_trace")
assert all(x in error_stack_trace for x in ("f()", "g()"))
assert "h()" not in error_stack_trace
assert ecs["error"] == {
"message": "error!",
"type": "ValueError",
}
assert ecs["log.level"] == "info"
assert ecs["message"] == "there was an error"
assert ecs["log"]["original"] == "there was an error"
def test_stack_trace_limit_types_and_values():
with pytest.raises(TypeError) as e:
ecs_logging.StdlibFormatter(stack_trace_limit="a")
assert str(e.value) == "'stack_trace_limit' must be None, or a non-negative integer"
with pytest.raises(ValueError) as e:
ecs_logging.StdlibFormatter(stack_trace_limit=-1)
assert str(e.value) == "'stack_trace_limit' must be None, or a non-negative integer"
@pytest.mark.parametrize(
"exclude_fields",
[
"process",
"log",
"log.level",
"message",
["log.origin", "log.origin.file", "log.origin.file.line"],
],
)
def test_exclude_fields(exclude_fields):
if isinstance(exclude_fields, str):
exclude_fields = [exclude_fields]
formatter = ecs_logging.StdlibFormatter(exclude_fields=exclude_fields)
ecs = formatter.format_to_ecs(make_record())
for entry in exclude_fields:
field_path = entry.split(".")
try:
obj = ecs
for path in field_path[:-1]:
obj = obj[path]
except KeyError:
continue
assert field_path[-1] not in obj
@pytest.mark.parametrize(
"exclude_fields",
[
"ecs.version",
],
)
def test_exclude_fields_not_dedotted(exclude_fields):
formatter = ecs_logging.StdlibFormatter(exclude_fields=[exclude_fields])
ecs = formatter.format_to_ecs(make_record())
for entry in exclude_fields:
assert entry not in ecs
def test_exclude_fields_empty_json_object():
"""Assert that if all JSON objects attributes are excluded then the object doesn't appear."""
formatter = ecs_logging.StdlibFormatter(
exclude_fields=["process.pid", "process.name", "process.thread"]
)
ecs = formatter.format_to_ecs(make_record())
assert "process" not in ecs
formatter = ecs_logging.StdlibFormatter(exclude_fields=["ecs.version"])
ecs = formatter.format_to_ecs(make_record())
assert "ecs" not in ecs
def test_exclude_fields_type_and_values():
with pytest.raises(TypeError) as e:
ecs_logging.StdlibFormatter(exclude_fields="a")
assert str(e.value) == "'exclude_fields' must be a sequence of strings"
with pytest.raises(TypeError) as e:
ecs_logging.StdlibFormatter(exclude_fields={"a"})
assert str(e.value) == "'exclude_fields' must be a sequence of strings"
with pytest.raises(TypeError) as e:
ecs_logging.StdlibFormatter(exclude_fields=[1])
assert str(e.value) == "'exclude_fields' must be a sequence of strings"
def test_stack_info(logger):
stream = StringIO()
handler = logging.StreamHandler(stream)
handler.setFormatter(ecs_logging.StdlibFormatter())
logger.addHandler(handler)
logger.setLevel(logging.DEBUG)
logger.info("stack info!", stack_info=True)
ecs = json.loads(stream.getvalue().rstrip())
assert list(ecs["error"].keys()) == ["stack_trace"]
error_stack_trace = ecs["error"].pop("stack_trace")
assert "test_stack_info" in error_stack_trace and __file__ in error_stack_trace
@pytest.mark.parametrize("exclude_fields", [["error"], ["error.stack_trace"]])
def test_stack_info_excluded(logger, exclude_fields):
stream = StringIO()
handler = logging.StreamHandler(stream)
handler.setFormatter(ecs_logging.StdlibFormatter(exclude_fields=exclude_fields))
logger.addHandler(handler)
logger.setLevel(logging.DEBUG)
logger.info("stack info!", stack_info=True)
ecs = json.loads(stream.getvalue().rstrip())
assert "error" not in ecs
def test_stdlibformatter_signature():
logging.config.dictConfig(
{
"version": 1,
"formatters": {"my_formatter": {"class": "ecs_logging.StdlibFormatter"}},
}
)
def test_apm_data_conflicts(spec_validator):
record = make_record()
record.service = {"version": "1.0.0", "name": "myapp", "environment": "dev"}
formatter = ecs_logging.StdlibFormatter(exclude_fields=["process"])
assert spec_validator(formatter.format(record)) == (
'{"@timestamp":"2020-03-20T14:12:46.123Z","log.level":"debug","message":"1: hello","ecs.version":"1.6.0",'
'"log":{"logger":"logger-name","origin":{"file":{"line":10,"name":"file.py"},"function":"test_function"},'
'"original":"1: hello"},"service":{"environment":"dev","name":"myapp","version":"1.0.0"}}'
)
|