1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037
|
import json
import pytest
import falcon
import falcon.errors
import falcon.testing as testing
from falcon.util.deprecation import DeprecatedWarning
from falcon.util.misc import _utcnow
_EXPECTED_BODY = {'status': 'ok'}
context = {'executed_methods': []} # type: ignore
TEST_ROUTE = '/test_path'
class CaptureResponseMiddleware:
def process_response(self, req, resp, resource, req_succeeded):
self.req = req
self.resp = resp
self.resource = resource
self.req_succeeded = req_succeeded
class CaptureRequestMiddleware:
def process_request(self, req, resp):
self.req = req
class RequestTimeMiddleware:
def process_request(self, req, resp):
global context
context['start_time'] = _utcnow()
def process_resource(self, req, resp, resource, params):
global context
context['mid_time'] = _utcnow()
def process_response(self, req, resp, resource, req_succeeded):
global context
context['end_time'] = _utcnow()
context['req_succeeded'] = req_succeeded
async def process_request_async(self, req, resp):
self.process_request(req, resp)
async def process_resource_async(self, req, resp, resource, params):
self.process_resource(req, resp, resource, params)
async def process_response_async(self, req, resp, resource, req_succeeded):
self.process_response(req, resp, resource, req_succeeded)
class TransactionIdMiddleware:
def process_request(self, req, resp):
global context
context['transaction_id'] = 'unique-req-id'
def process_resource(self, req, resp, resource, params):
global context
context['resource_transaction_id'] = 'unique-req-id-2'
def process_response(self, req, resp, resource, req_succeeded):
pass
class TransactionIdMiddlewareAsync:
def __init__(self):
self._mw = TransactionIdMiddleware()
async def process_request(self, req, resp):
self._mw.process_request(req, resp)
async def process_resource(self, req, resp, resource, params):
self._mw.process_resource(req, resp, resource, params)
async def process_response(self, req, resp, resource, req_succeeded):
self._mw.process_response(req, resp, resource, req_succeeded)
class ExecutedFirstMiddleware:
def process_request(self, req, resp):
global context
context['executed_methods'].append(
'{}.{}'.format(self.__class__.__name__, 'process_request')
)
def process_resource(self, req, resp, resource, params):
global context
context['executed_methods'].append(
'{}.{}'.format(self.__class__.__name__, 'process_resource')
)
# NOTE(kgriffs): This also tests that the framework can continue to
# call process_response() methods that do not have a 'req_succeeded'
# arg.
def process_response(self, req, resp, resource, req_succeeded):
global context
context['executed_methods'].append(
'{}.{}'.format(self.__class__.__name__, 'process_response')
)
context['req'] = req
context['resp'] = resp
context['resource'] = resource
class ExecutedLastMiddleware(ExecutedFirstMiddleware):
pass
class RemoveBasePathMiddleware:
def process_request(self, req, resp):
req.path = req.path.replace('/base_path', '', 1)
class ResponseCacheMiddlware:
PROCESS_REQUEST_CACHED_BODY = {'cached': True}
PROCESS_RESOURCE_CACHED_BODY = {'cached': True, 'resource': True}
def process_request(self, req, resp):
if req.path == '/cached':
resp.media = self.PROCESS_REQUEST_CACHED_BODY
resp.complete = True
return
def process_resource(self, req, resp, resource, params):
if req.path == '/cached/resource':
resp.media = self.PROCESS_RESOURCE_CACHED_BODY
resp.complete = True
return
class AccessParamsMiddleware:
def process_resource(self, req, resp, resource, params):
global context
params['added'] = True
context['params'] = params
class MiddlewareClassResource:
def on_get(self, req, resp, **kwargs):
resp.status = falcon.HTTP_200
resp.text = json.dumps(_EXPECTED_BODY)
def on_post(self, req, resp):
raise falcon.HTTPForbidden(title=falcon.HTTP_403, description='Setec Astronomy')
class EmptySignatureMiddleware:
def process_request(self):
pass
def process_response(self):
pass
class TestCorsResource:
def on_get(self, req, resp, **kwargs):
resp.status = falcon.HTTP_200
resp.text = 'Test'
class TestMiddleware:
def setup_method(self, method):
# Clear context
global context
context = {'executed_methods': []}
class TestRequestTimeMiddleware(TestMiddleware):
def test_skip_process_resource(self, asgi, util):
global context
app = util.create_app(asgi, middleware=[RequestTimeMiddleware()])
app.add_route('/', MiddlewareClassResource())
client = testing.TestClient(app)
response = client.simulate_request(path='/404')
assert response.status == falcon.HTTP_404
assert 'start_time' in context
assert 'mid_time' not in context
assert 'end_time' in context
assert not context['req_succeeded']
def test_add_invalid_middleware(self, asgi, util):
"""Test than an invalid class can not be added as middleware"""
class InvalidMiddleware:
def process_request(self, *args):
pass
mw_list = [RequestTimeMiddleware(), InvalidMiddleware]
with pytest.raises(AttributeError):
util.create_app(asgi, middleware=mw_list)
mw_list = [RequestTimeMiddleware(), 'InvalidMiddleware']
with pytest.raises(TypeError):
util.create_app(asgi, middleware=mw_list)
mw_list = [{'process_request': 90}]
with pytest.raises(TypeError):
util.create_app(asgi, middleware=mw_list)
def test_response_middleware_raises_exception(self, asgi, util):
"""Test that error in response middleware is propagated up"""
class RaiseErrorMiddleware:
def process_response(self, req, resp, resource):
raise Exception('Always fail')
app = util.create_app(asgi, middleware=[RaiseErrorMiddleware()])
app.add_route(TEST_ROUTE, MiddlewareClassResource())
client = testing.TestClient(app)
result = client.simulate_request(path=TEST_ROUTE)
assert result.status_code == 500
@pytest.mark.parametrize('independent_middleware', [True, False])
def test_log_get_request(self, independent_middleware, asgi, util):
"""Test that Log middleware is executed"""
global context
app = util.create_app(
asgi,
middleware=[RequestTimeMiddleware()],
independent_middleware=independent_middleware,
)
app.add_route(TEST_ROUTE, MiddlewareClassResource())
client = testing.TestClient(app)
response = client.simulate_request(path=TEST_ROUTE)
assert _EXPECTED_BODY == response.json
assert response.status == falcon.HTTP_200
assert 'start_time' in context
assert 'mid_time' in context
assert 'end_time' in context
assert (
context['mid_time'] >= context['start_time']
), 'process_resource not executed after request'
assert (
context['end_time'] >= context['start_time']
), 'process_response not executed after request'
assert context['req_succeeded']
class TestTransactionIdMiddleware(TestMiddleware):
def test_generate_trans_id_with_request(self, asgi, util):
"""Test that TransactionIdmiddleware is executed"""
global context
middleware = (
TransactionIdMiddlewareAsync() if asgi else TransactionIdMiddleware()
)
app = util.create_app(asgi, middleware=middleware)
app.add_route(TEST_ROUTE, MiddlewareClassResource())
client = testing.TestClient(app)
response = client.simulate_request(path=TEST_ROUTE)
assert _EXPECTED_BODY == response.json
assert response.status == falcon.HTTP_200
assert 'transaction_id' in context
assert 'unique-req-id' == context['transaction_id']
class TestSeveralMiddlewares(TestMiddleware):
@pytest.mark.parametrize('independent_middleware', [True, False])
def test_generate_trans_id_and_time_with_request(
self, independent_middleware, asgi, util
):
# NOTE(kgriffs): We test both so that we can cover the code paths
# where only a single middleware method is implemented by a
# component.
creq = CaptureRequestMiddleware()
cresp = CaptureResponseMiddleware()
global context
app = util.create_app(
asgi,
independent_middleware=independent_middleware,
# NOTE(kgriffs): Pass as a generic iterable to verify that works.
middleware=iter(
[
TransactionIdMiddleware(),
RequestTimeMiddleware(),
]
),
)
# NOTE(kgriffs): Add a couple more after the fact to test
# add_middleware().
app.add_middleware(creq)
app.add_middleware(cresp)
app.add_route(TEST_ROUTE, MiddlewareClassResource())
client = testing.TestClient(app)
response = client.simulate_request(path=TEST_ROUTE)
assert _EXPECTED_BODY == response.json
assert response.status == falcon.HTTP_200
assert 'transaction_id' in context
assert 'unique-req-id' == context['transaction_id']
assert 'start_time' in context
assert 'mid_time' in context
assert 'end_time' in context
assert (
context['mid_time'] >= context['start_time']
), 'process_resource not executed after request'
assert (
context['end_time'] >= context['start_time']
), 'process_response not executed after request'
def test_legacy_middleware_called_with_correct_args(self, asgi, util):
global context
app = util.create_app(asgi, middleware=[ExecutedFirstMiddleware()])
app.add_route(TEST_ROUTE, MiddlewareClassResource())
client = testing.TestClient(app)
client.simulate_request(path=TEST_ROUTE)
assert isinstance(context['req'], falcon.Request)
assert isinstance(context['resp'], falcon.Response)
assert isinstance(context['resource'], MiddlewareClassResource)
def test_middleware_execution_order(self, asgi, util):
global context
app = util.create_app(
asgi,
independent_middleware=False,
middleware=[ExecutedFirstMiddleware(), ExecutedLastMiddleware()],
)
app.add_route(TEST_ROUTE, MiddlewareClassResource())
client = testing.TestClient(app)
response = client.simulate_request(path=TEST_ROUTE)
assert _EXPECTED_BODY == response.json
assert response.status == falcon.HTTP_200
# as the method registration is in a list, the order also is
# tested
expectedExecutedMethods = [
'ExecutedFirstMiddleware.process_request',
'ExecutedLastMiddleware.process_request',
'ExecutedFirstMiddleware.process_resource',
'ExecutedLastMiddleware.process_resource',
'ExecutedLastMiddleware.process_response',
'ExecutedFirstMiddleware.process_response',
]
assert expectedExecutedMethods == context['executed_methods']
def test_independent_middleware_execution_order(self, asgi, util):
global context
app = util.create_app(
asgi,
independent_middleware=True,
middleware=[ExecutedFirstMiddleware(), ExecutedLastMiddleware()],
)
app.add_route(TEST_ROUTE, MiddlewareClassResource())
client = testing.TestClient(app)
response = client.simulate_request(path=TEST_ROUTE)
assert _EXPECTED_BODY == response.json
assert response.status == falcon.HTTP_200
# as the method registration is in a list, the order also is
# tested
expectedExecutedMethods = [
'ExecutedFirstMiddleware.process_request',
'ExecutedLastMiddleware.process_request',
'ExecutedFirstMiddleware.process_resource',
'ExecutedLastMiddleware.process_resource',
'ExecutedLastMiddleware.process_response',
'ExecutedFirstMiddleware.process_response',
]
assert expectedExecutedMethods == context['executed_methods']
def test_multiple_response_mw_throw_exception(self, asgi, util):
"""Test that error in inner middleware leaves"""
global context
context['req_succeeded'] = []
class RaiseStatusMiddleware:
def process_response(self, req, resp, resource, req_succeeded):
raise falcon.HTTPStatus(falcon.HTTP_201)
class RaiseErrorMiddleware:
def process_response(self, req, resp, resource, req_succeeded):
raise falcon.HTTPError(falcon.HTTP_748)
class ProcessResponseMiddleware:
def process_response(self, req, resp, resource, req_succeeded):
context['executed_methods'].append('process_response')
context['req_succeeded'].append(req_succeeded)
app = util.create_app(
asgi,
middleware=[
ProcessResponseMiddleware(),
RaiseErrorMiddleware(),
ProcessResponseMiddleware(),
RaiseStatusMiddleware(),
ProcessResponseMiddleware(),
],
)
app.add_route(TEST_ROUTE, MiddlewareClassResource())
client = testing.TestClient(app)
response = client.simulate_request(path=TEST_ROUTE)
assert response.status == falcon.HTTP_748
expected_methods = ['process_response'] * 3
assert context['executed_methods'] == expected_methods
assert context['req_succeeded'] == [True, False, False]
def test_inner_mw_throw_exception(self, asgi, util):
"""Test that error in inner middleware leaves"""
global context
class MyException(Exception):
pass
class RaiseErrorMiddleware:
def process_request(self, req, resp):
raise MyException('Always fail')
app = util.create_app(
asgi,
middleware=[
TransactionIdMiddleware(),
RequestTimeMiddleware(),
RaiseErrorMiddleware(),
],
)
# NOTE(kgriffs): Now that we install a default handler for
# Exception, we have to clear them to test the path we want
# to trigger with RaiseErrorMiddleware
# TODO(kgriffs): Since we always add a default error handler
# for Exception, should we take out the checks in the WSGI/ASGI
# callable and just always assume it will be handled? If so,
# then we would remove the test here...
app._error_handlers.clear()
app.add_route(TEST_ROUTE, MiddlewareClassResource())
client = testing.TestClient(app)
with pytest.raises(MyException):
client.simulate_request(path=TEST_ROUTE)
# RequestTimeMiddleware process_response should be executed
assert 'transaction_id' in context
assert 'start_time' in context
assert 'mid_time' not in context
# NOTE(kgriffs): Should not have been added since raising an
# unhandled error skips further processing, including response
# middleware methods.
assert 'end_time' not in context
def test_inner_mw_throw_exception_while_processing_resp(self, asgi, util):
"""Test that error in inner middleware leaves"""
global context
class MyException(Exception):
pass
class RaiseErrorMiddleware:
def process_response(self, req, resp, resource, req_succeeded):
raise MyException('Always fail')
app = util.create_app(
asgi,
middleware=[
TransactionIdMiddleware(),
RequestTimeMiddleware(),
RaiseErrorMiddleware(),
],
)
# NOTE(kgriffs): Now that we install a default handler for
# Exception, we have to clear them to test the path we want
# to trigger with RaiseErrorMiddleware
# TODO(kgriffs): Since we always add a default error handler
# for Exception, should we take out the checks in the WSGI/ASGI
# callable and just always assume it will be handled? If so,
# then we would remove the test here...
app._error_handlers.clear()
app.add_route(TEST_ROUTE, MiddlewareClassResource())
client = testing.TestClient(app)
with pytest.raises(MyException):
client.simulate_request(path=TEST_ROUTE)
# RequestTimeMiddleware process_response should be executed
assert 'transaction_id' in context
assert 'start_time' in context
assert 'mid_time' in context
# NOTE(kgriffs): Should not have been added since raising an
# unhandled error skips further processing, including response
# middleware methods.
assert 'end_time' not in context
def test_inner_mw_with_ex_handler_throw_exception(self, asgi, util):
"""Test that error in inner middleware leaves"""
global context
class RaiseErrorMiddleware:
def process_request(self, req, resp, resource):
raise Exception('Always fail')
app = util.create_app(
asgi,
middleware=[
TransactionIdMiddleware(),
RequestTimeMiddleware(),
RaiseErrorMiddleware(),
],
)
def handler(req, resp, ex, params):
context['error_handler'] = True
app.add_error_handler(Exception, handler)
app.add_route(TEST_ROUTE, MiddlewareClassResource())
client = testing.TestClient(app)
client.simulate_request(path=TEST_ROUTE)
# RequestTimeMiddleware process_response should be executed
assert 'transaction_id' in context
assert 'start_time' in context
assert 'mid_time' not in context
assert 'end_time' in context
assert 'error_handler' in context
def test_outer_mw_with_ex_handler_throw_exception(self, asgi, util):
"""Test that error in inner middleware leaves"""
global context
class RaiseErrorMiddleware:
def process_request(self, req, resp):
raise Exception('Always fail')
app = util.create_app(
asgi,
middleware=[
TransactionIdMiddleware(),
RaiseErrorMiddleware(),
RequestTimeMiddleware(),
],
)
def handler(req, resp, ex, params):
context['error_handler'] = True
app.add_error_handler(Exception, handler)
app.add_route(TEST_ROUTE, MiddlewareClassResource())
client = testing.TestClient(app)
client.simulate_request(path=TEST_ROUTE)
# Any mw is executed now...
assert 'transaction_id' in context
assert 'start_time' not in context
assert 'mid_time' not in context
assert 'end_time' in context
assert 'error_handler' in context
def test_order_mw_executed_when_exception_in_resp(self, asgi, util):
"""Test that error in inner middleware leaves"""
global context
class RaiseErrorMiddleware:
def process_response(self, req, resp, resource):
raise Exception('Always fail')
app = util.create_app(
asgi,
middleware=[
ExecutedFirstMiddleware(),
RaiseErrorMiddleware(),
ExecutedLastMiddleware(),
],
)
def handler(req, resp, ex, params):
pass
app.add_error_handler(Exception, handler)
app.add_route(TEST_ROUTE, MiddlewareClassResource())
client = testing.TestClient(app)
client.simulate_request(path=TEST_ROUTE)
# Any mw is executed now...
expectedExecutedMethods = [
'ExecutedFirstMiddleware.process_request',
'ExecutedLastMiddleware.process_request',
'ExecutedFirstMiddleware.process_resource',
'ExecutedLastMiddleware.process_resource',
'ExecutedLastMiddleware.process_response',
'ExecutedFirstMiddleware.process_response',
]
assert expectedExecutedMethods == context['executed_methods']
def test_order_independent_mw_executed_when_exception_in_resp(self, asgi, util):
"""Test that error in inner middleware leaves"""
global context
class RaiseErrorMiddleware:
def process_response(self, req, resp, resource):
raise Exception('Always fail')
app = util.create_app(
asgi,
independent_middleware=True,
middleware=[
ExecutedFirstMiddleware(),
RaiseErrorMiddleware(),
ExecutedLastMiddleware(),
],
)
def handler(req, resp, ex, params):
pass
app.add_error_handler(Exception, handler)
app.add_route(TEST_ROUTE, MiddlewareClassResource())
client = testing.TestClient(app)
client.simulate_request(path=TEST_ROUTE)
# Any mw is executed now...
expectedExecutedMethods = [
'ExecutedFirstMiddleware.process_request',
'ExecutedLastMiddleware.process_request',
'ExecutedFirstMiddleware.process_resource',
'ExecutedLastMiddleware.process_resource',
'ExecutedLastMiddleware.process_response',
'ExecutedFirstMiddleware.process_response',
]
assert expectedExecutedMethods == context['executed_methods']
def test_order_mw_executed_when_exception_in_req(self, asgi, util):
"""Test that error in inner middleware leaves"""
global context
class RaiseErrorMiddleware:
def process_request(self, req, resp):
raise Exception('Always fail')
class RaiseErrorMiddlewareAsync:
async def process_request(self, req, resp):
raise Exception('Always fail')
rem = RaiseErrorMiddlewareAsync() if asgi else RaiseErrorMiddleware()
app = util.create_app(
asgi, middleware=[ExecutedFirstMiddleware(), rem, ExecutedLastMiddleware()]
)
def handler(req, resp, ex, params):
pass
app.add_error_handler(Exception, handler)
app.add_route(TEST_ROUTE, MiddlewareClassResource())
client = testing.TestClient(app)
client.simulate_request(path=TEST_ROUTE)
# Any mw is executed now...
expectedExecutedMethods = [
'ExecutedFirstMiddleware.process_request',
'ExecutedLastMiddleware.process_response',
'ExecutedFirstMiddleware.process_response',
]
assert expectedExecutedMethods == context['executed_methods']
def test_order_independent_mw_executed_when_exception_in_req(self, asgi, util):
"""Test that error in inner middleware leaves"""
global context
class RaiseErrorMiddleware:
def process_request(self, req, resp):
raise Exception('Always fail')
class RaiseErrorMiddlewareAsync:
async def process_request(self, req, resp):
raise Exception('Always fail')
rem = RaiseErrorMiddlewareAsync() if asgi else RaiseErrorMiddleware()
app = util.create_app(
asgi,
independent_middleware=True,
middleware=[ExecutedFirstMiddleware(), rem, ExecutedLastMiddleware()],
)
def handler(req, resp, ex, params):
pass
app.add_error_handler(Exception, handler)
app.add_route(TEST_ROUTE, MiddlewareClassResource())
client = testing.TestClient(app)
client.simulate_request(path=TEST_ROUTE)
# All response middleware still executed...
expectedExecutedMethods = [
'ExecutedFirstMiddleware.process_request',
'ExecutedLastMiddleware.process_response',
'ExecutedFirstMiddleware.process_response',
]
assert expectedExecutedMethods == context['executed_methods']
def test_order_mw_executed_when_exception_in_rsrc(self, asgi, util):
"""Test that error in inner middleware leaves"""
global context
class RaiseErrorMiddleware:
def process_resource(self, req, resp, resource):
raise Exception('Always fail')
class RaiseErrorMiddlewareAsync:
# NOTE(kgriffs): The *_async postfix is not required in this
# case, but we include it to make sure it works as expected.
async def process_resource_async(self, req, resp, resource):
raise Exception('Always fail')
rem = RaiseErrorMiddlewareAsync() if asgi else RaiseErrorMiddleware()
app = util.create_app(
asgi, middleware=[ExecutedFirstMiddleware(), rem, ExecutedLastMiddleware()]
)
def handler(req, resp, ex, params):
pass
app.add_error_handler(Exception, handler)
app.add_route(TEST_ROUTE, MiddlewareClassResource())
client = testing.TestClient(app)
client.simulate_request(path=TEST_ROUTE)
# Any mw is executed now...
expectedExecutedMethods = [
'ExecutedFirstMiddleware.process_request',
'ExecutedLastMiddleware.process_request',
'ExecutedFirstMiddleware.process_resource',
'ExecutedLastMiddleware.process_response',
'ExecutedFirstMiddleware.process_response',
]
assert expectedExecutedMethods == context['executed_methods']
def test_order_independent_mw_executed_when_exception_in_rsrc(self, asgi, util):
"""Test that error in inner middleware leaves"""
global context
class RaiseErrorMiddleware:
def process_resource(self, req, resp, resource):
raise Exception('Always fail')
class RaiseErrorMiddlewareAsync:
async def process_resource(self, req, resp, resource):
raise Exception('Always fail')
rem = RaiseErrorMiddlewareAsync() if asgi else RaiseErrorMiddleware()
app = util.create_app(
asgi,
independent_middleware=True,
middleware=[ExecutedFirstMiddleware(), rem, ExecutedLastMiddleware()],
)
def handler(req, resp, ex, params):
pass
app.add_error_handler(Exception, handler)
app.add_route(TEST_ROUTE, MiddlewareClassResource())
client = testing.TestClient(app)
client.simulate_request(path=TEST_ROUTE)
# Any mw is executed now...
expectedExecutedMethods = [
'ExecutedFirstMiddleware.process_request',
'ExecutedLastMiddleware.process_request',
'ExecutedFirstMiddleware.process_resource',
'ExecutedLastMiddleware.process_response',
'ExecutedFirstMiddleware.process_response',
]
assert expectedExecutedMethods == context['executed_methods']
class TestRemoveBasePathMiddleware(TestMiddleware):
def test_base_path_is_removed_before_routing(self, asgi, util):
"""Test that RemoveBasePathMiddleware is executed before routing"""
app = util.create_app(asgi, middleware=RemoveBasePathMiddleware())
# We dont include /base_path as it will be removed in middleware
app.add_route('/sub_path', MiddlewareClassResource())
client = testing.TestClient(app)
response = client.simulate_request(path='/base_path/sub_path')
assert _EXPECTED_BODY == response.json
assert response.status == falcon.HTTP_200
response = client.simulate_request(path='/base_pathIncorrect/sub_path')
assert response.status == falcon.HTTP_404
class TestResourceMiddleware(TestMiddleware):
@pytest.mark.parametrize('independent_middleware', [True, False])
def test_can_access_resource_params(self, asgi, util, independent_middleware):
"""Test that params can be accessed from within process_resource"""
global context
class Resource:
def on_get(self, req, resp, **params):
resp.text = json.dumps(params)
app = util.create_app(
asgi,
middleware=AccessParamsMiddleware(),
independent_middleware=independent_middleware,
)
app.add_route('/path/{id}', Resource())
client = testing.TestClient(app)
response = client.simulate_request(path='/path/22')
assert 'params' in context
assert context['params']
assert context['params']['id'] == '22'
assert response.json == {'added': True, 'id': '22'}
class TestEmptySignatureMiddleware(TestMiddleware):
def test_dont_need_params_in_signature(self, asgi, util):
"""
Verify that we don't need parameters in the process_* signatures (for
side-effect-only middlewares, mostly). Makes no difference on py27
but does affect py36.
https://github.com/falconry/falcon/issues/1254
"""
util.create_app(asgi, middleware=EmptySignatureMiddleware())
class TestErrorHandling(TestMiddleware):
def test_error_composed_before_resp_middleware_called(self, asgi, util):
mw = CaptureResponseMiddleware()
app = util.create_app(asgi, middleware=mw)
app.add_route('/', MiddlewareClassResource())
client = testing.TestClient(app)
response = client.simulate_request(path='/', method='POST')
assert response.status == falcon.HTTP_403
assert mw.resp.status == response.status
composed_body = json.loads(mw.resp.data.decode())
assert composed_body['title'] == response.status
assert not mw.req_succeeded
# NOTE(kgriffs): Sanity-check the other params passed to
# process_response()
assert isinstance(mw.req, falcon.Request)
assert isinstance(mw.resource, MiddlewareClassResource)
def test_http_status_raised_from_error_handler(self, asgi, util):
mw = CaptureResponseMiddleware()
app = util.create_app(asgi, middleware=mw)
app.add_route('/', MiddlewareClassResource())
client = testing.TestClient(app)
# NOTE(kgriffs): Use the old-style error handler signature to
# ensure our shim for that works as expected.
def _http_error_handler(error, req, resp, params):
raise falcon.HTTPStatus(falcon.HTTP_201)
async def _http_error_handler_async(req, resp, error, params):
raise falcon.HTTPStatus(falcon.HTTP_201)
h = _http_error_handler_async if asgi else _http_error_handler
# NOTE(kgriffs): This will take precedence over the default
# handler for facon.HTTPError.
if asgi:
# NOTE(vytas): The ASGI flavour supports no reordering shim.
app.add_error_handler(falcon.HTTPError, h)
else:
with pytest.warns(DeprecatedWarning, match='deprecated signature'):
app.add_error_handler(falcon.HTTPError, h)
response = client.simulate_request(path='/', method='POST')
assert response.status == falcon.HTTP_201
assert mw.resp.status == response.status
class TestShortCircuiting(TestMiddleware):
def setup_method(self, method):
super(TestShortCircuiting, self).setup_method(method)
def _make_client(self, asgi, util, independent_middleware=True):
mw = [
RequestTimeMiddleware(),
ResponseCacheMiddlware(),
TransactionIdMiddleware(),
]
app = util.create_app(
asgi, middleware=mw, independent_middleware=independent_middleware
)
app.add_route('/', MiddlewareClassResource())
app.add_route('/cached', MiddlewareClassResource())
app.add_route('/cached/resource', MiddlewareClassResource())
return testing.TestClient(app)
def test_process_request_not_cached(self, asgi, util):
response = self._make_client(asgi, util).simulate_get('/')
assert response.status == falcon.HTTP_200
assert response.json == _EXPECTED_BODY
assert 'transaction_id' in context
assert 'resource_transaction_id' in context
assert 'mid_time' in context
assert 'end_time' in context
@pytest.mark.parametrize('independent_middleware', [True, False])
def test_process_request_cached(self, asgi, util, independent_middleware):
response = self._make_client(asgi, util, independent_middleware).simulate_get(
'/cached'
)
assert response.status == falcon.HTTP_200
assert response.json == ResponseCacheMiddlware.PROCESS_REQUEST_CACHED_BODY
# NOTE(kgriffs): Since TransactionIdMiddleware was ordered after
# ResponseCacheMiddlware, the response short-circuiting should have
# skipped it.
assert 'transaction_id' not in context
assert 'resource_transaction_id' not in context
# NOTE(kgriffs): RequestTimeMiddleware only adds this in
# process_resource(), which should be skipped when
# ResponseCacheMiddlware sets resp.completed = True in
# process_request().
assert 'mid_time' not in context
# NOTE(kgriffs): Short-circuiting does not affect process_response()
assert 'end_time' in context
@pytest.mark.parametrize('independent_middleware', [True, False])
def test_process_resource_cached(self, asgi, util, independent_middleware):
response = self._make_client(asgi, util, independent_middleware).simulate_get(
'/cached/resource'
)
assert response.status == falcon.HTTP_200
assert response.json == ResponseCacheMiddlware.PROCESS_RESOURCE_CACHED_BODY
# NOTE(kgriffs): This should be present because it is added in
# process_request(), but the short-circuit does not occur until
# process_resource().
assert 'transaction_id' in context
# NOTE(kgriffs): Since TransactionIdMiddleware was ordered after
# ResponseCacheMiddlware, the response short-circuiting should have
# skipped it.
assert 'resource_transaction_id' not in context
# NOTE(kgriffs): RequestTimeMiddleware only adds this in
# process_resource(), which will not be skipped in this case because
# RequestTimeMiddleware is ordered before ResponseCacheMiddlware.
assert 'mid_time' in context
# NOTE(kgriffs): Short-circuiting does not affect process_response()
assert 'end_time' in context
class TestCORSMiddlewareWithAnotherMiddleware(TestMiddleware):
@pytest.mark.parametrize(
'mw,allowed',
[
(CaptureResponseMiddleware(), True),
([CaptureResponseMiddleware()], True),
((CaptureResponseMiddleware(),), True),
(iter([CaptureResponseMiddleware()]), True),
(falcon.CORSMiddleware(), False),
([falcon.CORSMiddleware()], False),
],
)
def test_api_initialization_with_cors_enabled_and_middleware_param(
self, mw, asgi, util, allowed
):
if allowed:
app = util.create_app(asgi, middleware=mw, cors_enable=True)
app.add_route('/', TestCorsResource())
client = testing.TestClient(app)
result = client.simulate_get(headers={'Origin': 'localhost'})
assert result.headers['Access-Control-Allow-Origin'] == '*'
else:
with pytest.raises(ValueError, match='CORSMiddleware'):
app = util.create_app(asgi, middleware=mw, cors_enable=True)
def test_async_postfix_method_must_be_coroutine(util):
class FaultyComponentA:
def process_request_async(self, req, resp):
pass
class FaultyComponentB:
def process_resource_async(self, req, resp, resource, params):
pass
class FaultyComponentC:
def process_response_async(self, req, resp, resource, req_succeeded):
pass
if util.HAS_CYTHON:
pytest.skip(reason='Cythonized coroutine functions cannot be detected')
for mw in (FaultyComponentA, FaultyComponentB, FaultyComponentC):
with pytest.raises(falcon.errors.CompatibilityError):
util.create_app(True, middleware=[mw()])
|