1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601
|
import uuid
import pytest
from globus_sdk.exc import ErrorSubdocument
from globus_sdk.gare import (
GARE,
GlobusAuthorizationParameters,
_variants,
has_gares,
is_gare,
to_gare,
to_gares,
)
from globus_sdk.testing import construct_error
@pytest.mark.parametrize(
"error_dict, status, expected_required_scopes, expected_message",
(
(
{
"code": "ConsentRequired",
"message": "Missing required foo_bar consent",
"request_id": "WmMV97A1w",
"required_scopes": [
"urn:globus:auth:scope:transfer.api.globus.org:all[*foo *bar]"
],
"resource": "/transfer",
},
403,
["urn:globus:auth:scope:transfer.api.globus.org:all[*foo *bar]"],
"Missing required foo_bar consent",
),
(
{
"code": "ConsentRequired",
"required_scope": (
"urn:globus:auth:scope:transfer.api.globus.org:all[*foo *bar]"
),
"description": "Missing required foo_bar consent",
},
401,
["urn:globus:auth:scope:transfer.api.globus.org:all[*foo *bar]"],
"Missing required foo_bar consent",
),
pytest.param(
{
"error": "dependent_consent_required",
"error_description": "User must approve your client using scopes. See 'unapproved_scopes'.", # noqa: E501
"errors": [
{
"code": "DEPENDENT_CONSENT_REQUIRED",
"id": str(uuid.uuid4()),
"title": "User must approve your client using scopes. See 'unapproved_scopes'.", # noqa: E501
"unapproved_scopes": [
"https://auth.globus.org/scopes/00000000-ec3c-427d-bfb5-51049530122b/flow_00000000_ec3c_427d_bfb5_51049530122b_user" # noqa: E501
],
"status": "403",
"detail": "User hasn't approved the following scopes: https://auth.globus.org/scopes/00000000-ec3c-427d-bfb5-51049530122b/flow_00000000_ec3c_427d_bfb5_51049530122b_user", # noqa: E501
}
],
},
403,
[
"https://auth.globus.org/scopes/00000000-ec3c-427d-bfb5-51049530122b/flow_00000000_ec3c_427d_bfb5_51049530122b_user" # noqa: E501
],
None,
id="Auth 'dependent_consent_required' error",
),
),
)
def test_create_auth_requirements_error_from_consent_error(
error_dict, status, expected_required_scopes, expected_message
):
"""
Test that various ConsentRequired error shapes can be detected and converted
to a GlobusAuthRequirementsError.
"""
# Create various supplementary objects representing this error
error_subdoc = ErrorSubdocument(error_dict)
api_error = construct_error(body=error_dict, http_status=status)
for error in (error_dict, error_subdoc, api_error):
# Test boolean utility functions
assert is_gare(error)
assert has_gares([error])
# Check that this only produces one error
assert len(to_gares([error])) == 1
# Create a Globus Auth requirements error from the original error
authreq_error = to_gare(error)
assert isinstance(authreq_error, GARE)
assert authreq_error.code == "ConsentRequired"
assert (
authreq_error.authorization_parameters.required_scopes
== expected_required_scopes
)
if expected_message is not None:
assert (
authreq_error.authorization_parameters.session_message
== expected_message
)
@pytest.mark.parametrize(
"authorization_parameters",
(
{
"session_message": (
"To gain access you need to authenticate with your baz identity"
),
"session_required_identities": ["urn:globus:auth:identity:baz"],
"session_required_mfa": True,
},
{
"session_message": (
"You need to authenticate with an identity that "
"matches the required policies"
),
"session_required_policies": ["foo", "baz"],
},
{
"session_message": (
"You need to authenticate with an identity that "
"belongs to an authorized domain"
),
"session_required_single_domain": ["foo.com", "baz.org"],
},
{
"session_message": "You need to re-authenticate",
"session_required_single_domain": ["foo.com", "baz.org"],
"prompt": "login",
},
),
)
def test_create_auth_requirements_error_from_authorization_error(
authorization_parameters,
):
"""
Test that various authorization parameters error shapes can be detected and
converted to a GlobusAuthRequirementsError.
"""
# Create various supplementary objects representing this error
error_dict = {"authorization_parameters": authorization_parameters}
error_subdoc = ErrorSubdocument(error_dict)
api_error = construct_error(body=error_dict, http_status=403)
for error in (error_dict, error_subdoc, api_error):
# Test boolean utility functions
assert is_gare(error)
assert has_gares([error])
# Check that this only produces one error
assert len(to_gares([error])) == 1
# Create a Globus Auth requirements error from a legacy
# authorization parameters format error
authreq_error = to_gare(error)
assert isinstance(authreq_error, GARE)
# Check that the default error code is set
assert authreq_error.code == "AuthorizationRequired"
# Iterate over the expected attributes and check that they match
for name, value in authorization_parameters.items():
assert getattr(authreq_error.authorization_parameters, name) == value
@pytest.mark.parametrize(
"authorization_parameters",
(
{
"session_message": (
"You need to authenticate with an identity that "
"matches the required policies"
),
"session_required_policies": ["foo", "baz"],
},
{
"session_message": (
"You need to authenticate with an identity that "
"belongs to an authorized domain"
),
"session_required_single_domain": ["foo.com", "baz.org"],
},
),
)
def test_create_auth_requirements_error_from_authorization_error_csv(
authorization_parameters,
):
"""
Test that authorization parameters error shapes that provide lists as comma-
delimited values can be detected and converted to a GlobusAuthRequirementsError
normalizing to lists of strings for those values.
"""
# Create various supplementary objects representing this error
error_dict = {"authorization_parameters": {}}
for key, value in authorization_parameters.items():
if key in ("session_required_policies", "session_required_single_domain"):
# Convert the list to a comma-separated string for known variants
error_dict["authorization_parameters"][key] = ",".join(value)
else:
error_dict["authorization_parameters"][key] = value
error_subdoc = ErrorSubdocument(error_dict)
api_error = construct_error(body=error_dict, http_status=403)
for error in (error_dict, error_subdoc, api_error):
# Test boolean utility functions
assert is_gare(error)
assert has_gares([error])
# Check that this only produces one error
assert len(to_gares([error])) == 1
# Create a Globus Auth requirements error from a legacy
# authorization parameters format error
authreq_error = to_gare(error)
assert isinstance(authreq_error, GARE)
# Check that the default error code is set
assert authreq_error.code == "AuthorizationRequired"
# Iterate over the expected attributes and check that they match
for name, value in authorization_parameters.items():
assert getattr(authreq_error.authorization_parameters, name) == value
def test_create_auth_requirements_errors_from_multiple_errors():
"""
Test that a GlobusAPIError with multiple subdocuments is converted to multiple
GlobusAuthRequirementsErrors, and additionally test that this is correct even
when mingled with other accepted data types.
"""
consent_errors = construct_error(
body={
"errors": [
{
"code": "ConsentRequired",
"message": "Missing required foo_bar consent",
"authorization_parameters": {
"required_scopes": [
"urn:globus:auth:scope:transfer.api.globus.org:all[*bar]"
],
"session_message": "Missing required foo_bar consent",
},
},
{
"code": "ConsentRequired",
"message": "Missing required foo_baz consent",
"authorization_parameters": {
"required_scopes": [
"urn:globus:auth:scope:transfer.api.globus.org:all[*baz]"
],
"session_message": "Missing required foo_baz consent",
},
},
]
},
http_status=403,
)
authorization_error = construct_error(
body={
"authorization_parameters": {
"session_message": (
"You need to authenticate with an identity that "
"matches the required policies"
),
"session_required_policies": ["foo", "baz"],
}
},
http_status=403,
)
not_an_error = construct_error(
body={
"code": "NotAnError",
"message": "This is not an error",
},
http_status=403,
)
all_errors = [consent_errors, not_an_error, authorization_error]
# Test boolean utility function
assert has_gares(all_errors)
# Create auth requirements errors from a all errors
authreq_errors = to_gares(all_errors)
assert isinstance(authreq_errors, list)
assert len(authreq_errors) == 3
# Check that errors properly converted
for authreq_error in authreq_errors:
assert isinstance(authreq_error, GARE)
# Check that the proper auth requirements errors were produced
assert authreq_errors[0].code == "ConsentRequired"
assert authreq_errors[0].authorization_parameters.required_scopes == [
"urn:globus:auth:scope:transfer.api.globus.org:all[*bar]"
]
assert (
authreq_errors[0].authorization_parameters.session_message
== "Missing required foo_bar consent"
)
assert authreq_errors[1].code == "ConsentRequired"
assert authreq_errors[1].authorization_parameters.required_scopes == [
"urn:globus:auth:scope:transfer.api.globus.org:all[*baz]"
]
assert (
authreq_errors[1].authorization_parameters.session_message
== "Missing required foo_baz consent"
)
assert authreq_errors[2].code == "AuthorizationRequired"
assert authreq_errors[2].authorization_parameters.session_required_policies == [
"foo",
"baz",
]
assert authreq_errors[2].authorization_parameters.session_message == (
"You need to authenticate with an identity that matches the required policies"
)
def test_create_auth_requirements_error_from_legacy_authorization_error_with_code():
"""
Test that legacy authorization parameters error shapes that provide a `code` can be
detected and converted to a GlobusAuthRequirementsError while retaining the `code`.
"""
# Create a legacy authorization parameters error with a code
error_dict = {
"code": "UnsatisfiedPolicy",
"authorization_parameters": {
"session_message": (
"You need to authenticate with an identity that "
"matches the required policies"
),
"session_required_policies": "foo,baz",
},
}
# Create various supplementary objects representing this error
error_subdoc = ErrorSubdocument(error_dict)
api_error = construct_error(body=error_dict, http_status=403)
for error in (error_dict, error_subdoc, api_error):
# Test boolean utility functions
assert is_gare(error)
assert has_gares([error])
# Check that this only produces one error
assert len(to_gares([error])) == 1
# Create a Globus Auth requirements error from a legacy
# authorization parameters format error
authreq_error = to_gare(error)
assert isinstance(authreq_error, GARE)
# Check that the custom error code is set
assert authreq_error.code == "UnsatisfiedPolicy"
# Iterate over the expected attributes and check that they match
assert authreq_error.authorization_parameters.session_required_policies == [
"foo",
"baz",
]
def test_backward_compatibility_consent_required_error():
"""
Test that a consent required error with a comingled backward-compatible
data schema is converted to a GlobusAuthRequirementsError.
"""
# Create an API error with a backward compatible data schema using
# distinct values for duplicative fields to facilitate testing
# (in practice these would be the same)
error = construct_error(
body={
"code": "ConsentRequired",
"message": "Missing required foo_bar consent",
"request_id": "WmMV97A1w",
"required_scopes": [
"urn:globus:auth:scope:transfer.api.globus.org:all[*foo *bar]"
],
"resource": "/transfer",
"authorization_parameters": {
"session_message": "Missing baz consent",
"required_scopes": [
"urn:globus:auth:scope:transfer.api.globus.org:all[*baz]"
],
"optional": "A non-canonical field",
},
},
http_status=403,
)
# Test boolean utility functions
assert is_gare(error)
assert has_gares([error])
# Check that this only produces one error
assert len(to_gares([error])) == 1
# Create a Globus Auth requirements error
authreq_error = to_gare(error)
assert isinstance(authreq_error, GARE)
assert authreq_error.code == "ConsentRequired"
assert authreq_error.authorization_parameters.required_scopes == [
"urn:globus:auth:scope:transfer.api.globus.org:all[*baz]"
]
assert (
authreq_error.authorization_parameters.session_message == "Missing baz consent"
)
# Test that only suppotred fields are present in the dict
assert authreq_error.to_dict() == {
"code": "ConsentRequired",
"authorization_parameters": {
"session_message": "Missing baz consent",
"required_scopes": [
"urn:globus:auth:scope:transfer.api.globus.org:all[*baz]"
],
},
}
# Test that extra fields are present in the dict
assert authreq_error.to_dict(include_extra=True) == {
"code": "ConsentRequired",
"message": "Missing required foo_bar consent",
"request_id": "WmMV97A1w",
"required_scopes": [
"urn:globus:auth:scope:transfer.api.globus.org:all[*foo *bar]"
],
"resource": "/transfer",
"authorization_parameters": {
"session_message": "Missing baz consent",
"required_scopes": [
"urn:globus:auth:scope:transfer.api.globus.org:all[*baz]"
],
"optional": "A non-canonical field",
},
}
@pytest.mark.parametrize(
"target_class, data, expect_message",
[
( # missing 'code'
GARE,
{"authorization_parameters": {"session_required_policies": "foo"}},
"'code' must be a string",
),
( # missing 'authorization_parameters'
_variants.LegacyAuthorizationParametersError,
{},
(
"'authorization_parameters' must be a 'LegacyAuthorizationParameters' "
"object or a dictionary"
),
),
( # missing 'code'
_variants.LegacyConsentRequiredTransferError,
{"required_scopes": []},
"'code' must be the string 'ConsentRequired'",
),
( # missing 'code'
_variants.LegacyConsentRequiredAPError,
{"required_scope": "foo"},
"'code' must be the string 'ConsentRequired'",
),
],
)
def test_error_from_dict_insufficient_input(target_class, data, expect_message):
""" """
with pytest.raises(ValueError) as exc_info:
target_class.from_dict(data)
assert str(exc_info.value) == expect_message
@pytest.mark.parametrize(
"target_class",
[
GlobusAuthorizationParameters,
_variants.LegacyAuthorizationParameters,
],
)
def test_authorization_parameters_from_empty_dict(target_class):
""" """
authorization_params = target_class.from_dict({})
assert authorization_params.to_dict() == {}
def test_gare_repr_shows_attrs():
error_doc = GARE(
code="NeedsReauth",
authorization_parameters={"session_required_policies": ["foo"]},
)
# the repr will include the parameters repr -- tested separately below
assert repr(error_doc) == (
"GARE("
"code='NeedsReauth', "
f"authorization_parameters={error_doc.authorization_parameters!r}"
")"
)
def test_gare_repr_indicates_presence_of_extra():
error_doc_no_extra = GARE(
code="NeedsReauth",
authorization_parameters={"session_required_policies": ["foo"]},
)
error_doc_with_extra = GARE(
code="NeedsReauth",
authorization_parameters={"session_required_policies": ["foo"]},
extra={"alpha": "beta"},
)
assert "extra=..." not in repr(error_doc_no_extra)
assert "extra=..." in repr(error_doc_with_extra)
def test_authorization_parameters_repr_shows_all_attrs():
params = GlobusAuthorizationParameters()
assert repr(params) == (
"GlobusAuthorizationParameters("
"session_message=None, "
"session_required_identities=None, "
"session_required_policies=None, "
"session_required_single_domain=None, "
"session_required_mfa=None, "
"required_scopes=None, "
"prompt=None"
")"
)
def test_authorization_parameters_repr_indicates_presence_of_extra():
params_no_extra = GlobusAuthorizationParameters()
params_with_extra = GlobusAuthorizationParameters(extra={"gamma": "delta"})
assert "extra=..." not in repr(params_no_extra)
assert "extra=..." in repr(params_with_extra)
@pytest.mark.parametrize("method", (to_gare, to_gares))
def test_create_gare_from_policy_error_when_non_gare_subdocuments_are_present(
method,
):
# this error data is based on a real API error shape from Auth
# the top-level error is a GARE; but the subdocuments are not
policy_id = str(uuid.uuid1())
error_dict = {
"errors": [
{
"detail": (
"To access this project you must have an identity with admin "
"privileges in session within the last 30 minutes."
),
"id": "4a156297-a2e5-4095-a13c-ba9486035f79",
"title": "Forbidden",
"status": "403",
"code": "FORBIDDEN",
}
],
"error": "forbidden",
"error_description": "Forbidden",
"authorization_parameters": {
"session_required_policies": [policy_id],
"session_message": (
"To access this project you must have an identity with admin "
"privileges in session within the last 30 minutes."
),
},
}
api_error = construct_error(body=error_dict, http_status=403)
# pass singular or plural, to match the relevant method
if method is to_gare:
gare = method(api_error)
else:
all_gares = method([api_error])
assert len(all_gares) == 1
gare = all_gares[0]
assert isinstance(gare, GARE)
# no 'code' was provided in the original error data, so the default will be induced
assert gare.code == "AuthorizationRequired"
# there are no scopes
assert gare.authorization_parameters.required_scopes is None
# the message matches the input doc
assert (
gare.authorization_parameters.session_message
== error_dict["authorization_parameters"]["session_message"]
)
# and the policy ID is provided in the required policies field
assert gare.authorization_parameters.session_required_policies == [policy_id]
|