1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526
|
"""
Tests invalid frame sequences, and validates that they fail appropriately.
"""
from __future__ import annotations
import pytest
import h2.config
import h2.connection
import h2.errors
import h2.events
import h2.exceptions
class TestInvalidFrameSequences:
"""
Invalid frame sequences, either sent or received, cause ProtocolErrors to
be thrown.
"""
example_request_headers = [
(":authority", "example.com"),
(":path", "/"),
(":scheme", "https"),
(":method", "GET"),
]
example_request_headers_bytes = [
(b":authority", b"example.com"),
(b":path", b"/"),
(b":scheme", b"https"),
(b":method", b"GET"),
]
example_response_headers = [
(":status", "200"),
("server", "fake-serv/0.1.0"),
]
server_config = h2.config.H2Configuration(client_side=False)
client_config = h2.config.H2Configuration(client_side=True)
@pytest.mark.parametrize("request_headers", [example_request_headers, example_request_headers_bytes])
def test_cannot_send_on_closed_stream(self, request_headers) -> None:
"""
When we've closed a stream locally, we cannot send further data.
"""
c = h2.connection.H2Connection()
c.initiate_connection()
c.send_headers(1, request_headers, end_stream=True)
with pytest.raises(h2.exceptions.ProtocolError):
c.send_data(1, b"some data")
def test_missing_preamble_errors(self) -> None:
"""
Server side connections require the preamble.
"""
c = h2.connection.H2Connection(config=self.server_config)
encoded_headers_frame = (
b"\x00\x00\r\x01\x04\x00\x00\x00\x01"
b"A\x88/\x91\xd3]\x05\\\x87\xa7\x84\x87\x82"
)
with pytest.raises(h2.exceptions.ProtocolError):
c.receive_data(encoded_headers_frame)
@pytest.mark.parametrize("request_headers", [example_request_headers, example_request_headers_bytes])
def test_server_connections_reject_even_streams(self, frame_factory, request_headers) -> None:
"""
Servers do not allow clients to initiate even-numbered streams.
"""
c = h2.connection.H2Connection(config=self.server_config)
c.initiate_connection()
c.receive_data(frame_factory.preamble())
f = frame_factory.build_headers_frame(
request_headers, stream_id=2,
)
with pytest.raises(h2.exceptions.ProtocolError):
c.receive_data(f.serialize())
@pytest.mark.parametrize("request_headers", [example_request_headers, example_request_headers_bytes])
def test_clients_reject_odd_stream_pushes(self, frame_factory, request_headers) -> None:
"""
Clients do not allow servers to push odd numbered streams.
"""
c = h2.connection.H2Connection()
c.initiate_connection()
c.send_headers(1, request_headers, end_stream=True)
f = frame_factory.build_push_promise_frame(
stream_id=1,
headers=request_headers,
promised_stream_id=3,
)
with pytest.raises(h2.exceptions.ProtocolError):
c.receive_data(f.serialize())
@pytest.mark.parametrize("request_headers", [example_request_headers, example_request_headers_bytes])
def test_can_handle_frames_with_invalid_padding(self, frame_factory, request_headers) -> None:
"""
Frames with invalid padding cause connection teardown.
"""
c = h2.connection.H2Connection(config=self.server_config)
c.initiate_connection()
c.receive_data(frame_factory.preamble())
f = frame_factory.build_headers_frame(request_headers)
c.receive_data(f.serialize())
c.clear_outbound_data_buffer()
invalid_data_frame = (
b"\x00\x00\x05\x00\x0b\x00\x00\x00\x01\x06\x54\x65\x73\x74"
)
with pytest.raises(h2.exceptions.ProtocolError):
c.receive_data(invalid_data_frame)
expected_frame = frame_factory.build_goaway_frame(
last_stream_id=1, error_code=1,
)
assert c.data_to_send() == expected_frame.serialize()
def test_receiving_frames_with_insufficent_size(self, frame_factory) -> None:
"""
Frames with not enough data cause connection teardown.
"""
c = h2.connection.H2Connection(config=self.server_config)
c.initiate_connection()
c.receive_data(frame_factory.preamble())
c.clear_outbound_data_buffer()
invalid_window_update_frame = (
b"\x00\x00\x03\x08\x00\x00\x00\x00\x00\x00\x00\x02"
)
with pytest.raises(h2.exceptions.FrameDataMissingError):
c.receive_data(invalid_window_update_frame)
expected_frame = frame_factory.build_goaway_frame(
last_stream_id=0, error_code=h2.errors.ErrorCodes.FRAME_SIZE_ERROR,
)
assert c.data_to_send() == expected_frame.serialize()
@pytest.mark.parametrize("request_headers", [example_request_headers, example_request_headers_bytes])
def test_reject_data_on_closed_streams(self, frame_factory, request_headers) -> None:
"""
When a stream is not open to the remote peer, we reject receiving data
frames from them.
"""
c = h2.connection.H2Connection(config=self.server_config)
c.initiate_connection()
c.receive_data(frame_factory.preamble())
f = frame_factory.build_headers_frame(
request_headers,
flags=["END_STREAM"],
)
c.receive_data(f.serialize())
c.clear_outbound_data_buffer()
bad_frame = frame_factory.build_data_frame(
data=b"some data",
)
c.receive_data(bad_frame.serialize())
expected = frame_factory.build_rst_stream_frame(
stream_id=1,
error_code=h2.errors.ErrorCodes.STREAM_CLOSED,
).serialize()
assert c.data_to_send() == expected
@pytest.mark.parametrize("request_headers", [example_request_headers, example_request_headers_bytes])
def test_unexpected_continuation_on_closed_stream(self, frame_factory, request_headers) -> None:
"""
CONTINUATION frames received on closed streams cause connection errors
of type PROTOCOL_ERROR.
"""
c = h2.connection.H2Connection(config=self.server_config)
c.initiate_connection()
c.receive_data(frame_factory.preamble())
f = frame_factory.build_headers_frame(
request_headers,
flags=["END_STREAM"],
)
c.receive_data(f.serialize())
c.clear_outbound_data_buffer()
bad_frame = frame_factory.build_continuation_frame(
header_block=b"hello",
)
with pytest.raises(h2.exceptions.ProtocolError):
c.receive_data(bad_frame.serialize())
expected_frame = frame_factory.build_goaway_frame(
error_code=h2.errors.ErrorCodes.PROTOCOL_ERROR,
last_stream_id=1,
)
assert c.data_to_send() == expected_frame.serialize()
@pytest.mark.parametrize("request_headers", [example_request_headers, example_request_headers_bytes])
def test_prevent_continuation_dos(self, frame_factory, request_headers) -> None:
"""
Receiving too many CONTINUATION frames in one block causes a protocol
error.
"""
c = h2.connection.H2Connection(config=self.server_config)
c.initiate_connection()
c.receive_data(frame_factory.preamble())
f = frame_factory.build_headers_frame(
request_headers,
)
f.flags = {"END_STREAM"}
c.receive_data(f.serialize())
c.clear_outbound_data_buffer()
# Send 63 additional frames.
for _ in range(63):
extra_frame = frame_factory.build_continuation_frame(
header_block=b"hello",
)
c.receive_data(extra_frame.serialize())
# The final continuation frame should cause a protocol error.
extra_frame = frame_factory.build_continuation_frame(
header_block=b"hello",
)
with pytest.raises(h2.exceptions.ProtocolError):
c.receive_data(extra_frame.serialize())
expected_frame = frame_factory.build_goaway_frame(
last_stream_id=0,
error_code=0x1,
)
assert c.data_to_send() == expected_frame.serialize()
# These settings are a bit annoyingly anonymous, but trust me, they're bad.
@pytest.mark.parametrize(
"settings",
[
{0x2: 5},
{0x4: 2**31},
{0x5: 5},
{0x5: 2**24},
],
)
def test_reject_invalid_settings_values(self, frame_factory, settings) -> None:
"""
When a SETTINGS frame is received with invalid settings values it
causes connection teardown with the appropriate error code.
"""
c = h2.connection.H2Connection(config=self.server_config)
c.initiate_connection()
c.receive_data(frame_factory.preamble())
f = frame_factory.build_settings_frame(settings=settings)
with pytest.raises(h2.exceptions.InvalidSettingsValueError) as e:
c.receive_data(f.serialize())
assert e.value.error_code == (
h2.errors.ErrorCodes.FLOW_CONTROL_ERROR if 0x4 in settings else
h2.errors.ErrorCodes.PROTOCOL_ERROR
)
@pytest.mark.parametrize("request_headers", [example_request_headers, example_request_headers_bytes])
def test_invalid_frame_headers_are_protocol_errors(self, frame_factory, request_headers) -> None:
"""
When invalid frame headers are received they cause ProtocolErrors to be
raised.
"""
c = h2.connection.H2Connection(config=self.server_config)
c.initiate_connection()
c.receive_data(frame_factory.preamble())
f = frame_factory.build_headers_frame(
headers=request_headers,
)
# Do some annoying bit twiddling here: the stream ID is currently set
# to '1', change it to '0'. Grab the first 9 bytes (the frame header),
# replace any instances of the byte '\x01', and then graft it onto the
# remaining bytes.
frame_data = f.serialize()
frame_data = frame_data[:9].replace(b"\x01", b"\x00") + frame_data[9:]
with pytest.raises(h2.exceptions.ProtocolError) as e:
c.receive_data(frame_data)
assert "Received frame with invalid header" in str(e.value)
@pytest.mark.parametrize("request_headers", [example_request_headers, example_request_headers_bytes])
def test_data_before_headers(self, frame_factory, request_headers) -> None:
"""
When data frames are received before headers
they cause ProtocolErrors to be raised.
"""
c = h2.connection.H2Connection(config=self.client_config)
c.initiate_connection()
# transition stream into OPEN
c.send_headers(1, request_headers)
f = frame_factory.build_data_frame(b"hello")
with pytest.raises(h2.exceptions.ProtocolError) as e:
c.receive_data(f.serialize())
assert "cannot receive data before headers" in str(e.value)
@pytest.mark.parametrize("request_headers", [example_request_headers, example_request_headers_bytes])
def test_get_stream_reset_event_on_auto_reset(self, frame_factory, request_headers) -> None:
"""
When hyper-h2 resets a stream automatically, a StreamReset event fires.
"""
c = h2.connection.H2Connection(config=self.server_config)
c.initiate_connection()
c.receive_data(frame_factory.preamble())
f = frame_factory.build_headers_frame(
request_headers,
flags=["END_STREAM"],
)
c.receive_data(f.serialize())
c.clear_outbound_data_buffer()
bad_frame = frame_factory.build_data_frame(
data=b"some data",
)
events = c.receive_data(bad_frame.serialize())
expected = frame_factory.build_rst_stream_frame(
stream_id=1,
error_code=h2.errors.ErrorCodes.STREAM_CLOSED,
).serialize()
assert c.data_to_send() == expected
assert len(events) == 1
event = events[0]
assert isinstance(event, h2.events.StreamReset)
assert event.stream_id == 1
assert event.error_code == h2.errors.ErrorCodes.STREAM_CLOSED
assert not event.remote_reset
@pytest.mark.parametrize("request_headers", [example_request_headers, example_request_headers_bytes])
def test_one_one_stream_reset(self, frame_factory, request_headers) -> None:
"""
When hyper-h2 resets a stream automatically, a StreamReset event fires,
but only for the first reset: the others are silent.
"""
c = h2.connection.H2Connection(config=self.server_config)
c.initiate_connection()
c.receive_data(frame_factory.preamble())
f = frame_factory.build_headers_frame(
request_headers,
flags=["END_STREAM"],
)
c.receive_data(f.serialize())
c.clear_outbound_data_buffer()
bad_frame = frame_factory.build_data_frame(
data=b"some data",
)
# Receive 5 frames.
events = c.receive_data(bad_frame.serialize() * 5)
expected = frame_factory.build_rst_stream_frame(
stream_id=1,
error_code=h2.errors.ErrorCodes.STREAM_CLOSED,
).serialize()
assert c.data_to_send() == expected * 5
assert len(events) == 1
event = events[0]
assert isinstance(event, h2.events.StreamReset)
assert event.stream_id == 1
assert event.error_code == h2.errors.ErrorCodes.STREAM_CLOSED
assert not event.remote_reset
@pytest.mark.parametrize("request_headers", [example_request_headers, example_request_headers_bytes])
@pytest.mark.parametrize("value", ["", "twelve"])
def test_error_on_invalid_content_length(self, frame_factory, value, request_headers) -> None:
"""
When an invalid content-length is received, a ProtocolError is thrown.
"""
c = h2.connection.H2Connection(config=self.server_config)
c.initiate_connection()
c.receive_data(frame_factory.preamble())
c.clear_outbound_data_buffer()
f = frame_factory.build_headers_frame(
stream_id=1,
headers=[*request_headers, ("content-length", value)],
)
with pytest.raises(h2.exceptions.ProtocolError):
c.receive_data(f.serialize())
expected_frame = frame_factory.build_goaway_frame(
last_stream_id=1,
error_code=h2.errors.ErrorCodes.PROTOCOL_ERROR,
)
assert c.data_to_send() == expected_frame.serialize()
@pytest.mark.parametrize("request_headers", [example_request_headers, example_request_headers_bytes])
def test_invalid_header_data_protocol_error(self, frame_factory, request_headers) -> None:
"""
If an invalid header block is received, we raise a ProtocolError.
"""
c = h2.connection.H2Connection(config=self.server_config)
c.initiate_connection()
c.receive_data(frame_factory.preamble())
c.clear_outbound_data_buffer()
f = frame_factory.build_headers_frame(
stream_id=1,
headers=request_headers,
)
f.data = b"\x00\x00\x00\x00"
with pytest.raises(h2.exceptions.ProtocolError):
c.receive_data(f.serialize())
expected_frame = frame_factory.build_goaway_frame(
last_stream_id=0,
error_code=h2.errors.ErrorCodes.PROTOCOL_ERROR,
)
assert c.data_to_send() == expected_frame.serialize()
@pytest.mark.parametrize("request_headers", [example_request_headers, example_request_headers_bytes])
def test_invalid_push_promise_data_protocol_error(self, frame_factory, request_headers) -> None:
"""
If an invalid header block is received on a PUSH_PROMISE, we raise a
ProtocolError.
"""
c = h2.connection.H2Connection()
c.initiate_connection()
c.send_headers(stream_id=1, headers=request_headers)
c.clear_outbound_data_buffer()
f = frame_factory.build_push_promise_frame(
stream_id=1,
promised_stream_id=2,
headers=request_headers,
)
f.data = b"\x00\x00\x00\x00"
with pytest.raises(h2.exceptions.ProtocolError):
c.receive_data(f.serialize())
expected_frame = frame_factory.build_goaway_frame(
last_stream_id=0,
error_code=h2.errors.ErrorCodes.PROTOCOL_ERROR,
)
assert c.data_to_send() == expected_frame.serialize()
@pytest.mark.parametrize("request_headers", [example_request_headers, example_request_headers_bytes])
def test_cannot_receive_push_on_pushed_stream(self, frame_factory, request_headers) -> None:
"""
If a PUSH_PROMISE frame is received with the parent stream ID being a
pushed stream, this is rejected with a PROTOCOL_ERROR.
"""
c = h2.connection.H2Connection()
c.initiate_connection()
c.send_headers(
stream_id=1,
headers=request_headers,
end_stream=True,
)
f1 = frame_factory.build_push_promise_frame(
stream_id=1,
promised_stream_id=2,
headers=request_headers,
)
f2 = frame_factory.build_headers_frame(
stream_id=2,
headers=self.example_response_headers,
)
c.receive_data(f1.serialize() + f2.serialize())
c.clear_outbound_data_buffer()
f = frame_factory.build_push_promise_frame(
stream_id=2,
promised_stream_id=4,
headers=request_headers,
)
with pytest.raises(h2.exceptions.ProtocolError):
c.receive_data(f.serialize())
expected_frame = frame_factory.build_goaway_frame(
last_stream_id=2,
error_code=h2.errors.ErrorCodes.PROTOCOL_ERROR,
)
assert c.data_to_send() == expected_frame.serialize()
@pytest.mark.parametrize("request_headers", [example_request_headers, example_request_headers_bytes])
def test_cannot_send_push_on_pushed_stream(self, frame_factory, request_headers) -> None:
"""
If a user tries to send a PUSH_PROMISE frame with the parent stream ID
being a pushed stream, this is rejected with a PROTOCOL_ERROR.
"""
c = h2.connection.H2Connection(config=self.server_config)
c.initiate_connection()
c.receive_data(frame_factory.preamble())
f = frame_factory.build_headers_frame(
stream_id=1, headers=request_headers,
)
c.receive_data(f.serialize())
c.push_stream(
stream_id=1,
promised_stream_id=2,
request_headers=request_headers,
)
c.send_headers(stream_id=2, headers=self.example_response_headers)
with pytest.raises(h2.exceptions.ProtocolError):
c.push_stream(
stream_id=2,
promised_stream_id=4,
request_headers=request_headers,
)
|