1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
|
import numpy as np
import pytest
import laspy
from . import skip_if_cli_deps_are_not_installed
skip_if_cli_deps_are_not_installed()
from typer.testing import CliRunner
from laspy.cli.core import (
BinaryFilteringExpression,
Comparator,
Condition,
FilteringAction,
FilteringExpression,
FilteringExpressionKind,
NegatedFilteringExpression,
Token,
app,
parse_float_or_int,
parse_list_of_numbers,
tokenize,
)
runner = CliRunner()
def test_parse_float_or_number():
value = parse_float_or_int("10")
assert type(value) == int
assert value == 10
value = parse_float_or_int(" 17 ")
assert type(value) == int
assert value == 17
value = parse_float_or_int("0.3")
assert type(value) == float
assert value == 0.3
value = parse_float_or_int(" 0.889 ")
assert type(value) == float
assert value == 0.889
with pytest.raises(ValueError):
_ = parse_float_or_int("238a")
def test_parse_list_of_numbers():
value = parse_list_of_numbers("[1, 2, 3]")
assert value == [1, 2, 3]
value = parse_list_of_numbers("(4, 5, 6)")
assert value == [4, 5, 6]
with pytest.raises(ValueError):
_ = parse_list_of_numbers("238")
with pytest.raises(ValueError):
_ = parse_list_of_numbers("[238, 1")
with pytest.raises(ValueError):
_ = parse_list_of_numbers("38, 1]")
def test_tokenize():
tokens = tokenize("not classification == 2")
Kind = Token.Kind
expected = [
Token(Kind.Not, "not"),
Token(Kind.LiteralStr, "classification"),
Token(Kind.EqEq, "=="),
Token(Kind.LiteralStr, "2"),
]
assert tokens == expected
def test_parse_valid_filter_action():
action = FilteringAction.parse_string("intensity >= 128")
expected = FilteringAction("intensity", Comparator.GreaterOrEqual, "128")
assert action == expected
def test_parse_valid_filter_action_in():
action = FilteringAction.parse_string("intensity in [128, 129, 130]")
expected = FilteringAction("intensity", Comparator.In, "[128, 129, 130]")
assert action == expected
def test_parse_invalid_filter_action_invalid_operator():
with pytest.raises(ValueError):
_ = FilteringAction.parse_string("point_source_id <> 128")
def test_parse_invalid_filter_action_no_operator():
"""This one show that our simplistic parsing catches some error late"""
with pytest.raises(ValueError):
_ = FilteringAction.parse_string("point_source_id 128")
def test_parse_filtering_expression():
parsed_expr = FilteringExpression.parse_string(
"classification == 2 or classification == 3 and x > 10.0"
)
"""
┌────┐
│ or │
└▲─▲─┘
│ │
│ │
│ │
┌─────────────────────┤ │
│ classification == 2 │ │
└─────────────────────┘ └───────┬─────┐
│ and │
└─▲──▲┘
│ │
┌─────────────────────┬┘ └─┬──────────┐
│ classification == 3 │ │ x > 10.0 │
└─────────────────────┘ └──────────┘
"""
expected_expr = FilteringExpression(
kind=FilteringExpressionKind.Binary,
data=BinaryFilteringExpression(
condition=Condition.Or,
lhs=FilteringExpression(
kind=FilteringExpressionKind.Action,
data=FilteringAction(
field_name="classification",
comparator=Comparator.Equality,
value="2",
),
),
rhs=FilteringExpression(
kind=FilteringExpressionKind.Binary,
data=BinaryFilteringExpression(
condition=Condition.And,
lhs=FilteringExpression(
kind=FilteringExpressionKind.Action,
data=FilteringAction(
field_name="classification",
comparator=Comparator.Equality,
value="3",
),
),
rhs=FilteringExpression(
kind=FilteringExpressionKind.Action,
data=FilteringAction(
field_name="x",
comparator=Comparator.GreaterThan,
value="10.0",
),
),
),
),
),
)
assert parsed_expr == expected_expr
def test_parse_filtering_expression_not():
parsed_expr = FilteringExpression.parse_string("not classification == 2")
expected_expr = FilteringExpression(
kind=FilteringExpressionKind.Negated,
data=NegatedFilteringExpression(
expr=FilteringExpression(
kind=FilteringExpressionKind.Action,
data=FilteringAction(
field_name="classification",
comparator=Comparator.Equality,
value="2",
),
),
),
)
assert parsed_expr == expected_expr
def test_parse_filtering_expression_2():
parsed_expr = FilteringExpression.parse_string(
"(classification == 2 or classification == 3) and x > 10.0"
)
"""
┌─────┐
│ And │
└─▲─▲─┘
│ │
│ │
┌────┬───────┘ │
┌─────►│ or │ └────────────────┬──────────┐
│ └───▲┘ │ x > 10.0 │
│ │ └──────────┘
┌──────────────┴───────┐ ┌┴────────────────────┐
│ classification == 2 │ │ classification == 3 │
└──────────────────────┘ └─────────────────────┘
"""
expected_expr = FilteringExpression(
kind=FilteringExpressionKind.Binary,
data=BinaryFilteringExpression(
condition=Condition.And,
lhs=FilteringExpression(
kind=FilteringExpressionKind.Binary,
data=BinaryFilteringExpression(
condition=Condition.Or,
lhs=FilteringExpression(
kind=FilteringExpressionKind.Action,
data=FilteringAction(
field_name="classification",
comparator=Comparator.Equality,
value="2",
),
),
rhs=FilteringExpression(
kind=FilteringExpressionKind.Action,
data=FilteringAction(
field_name="classification",
comparator=Comparator.Equality,
value="3",
),
),
),
),
rhs=FilteringExpression(
kind=FilteringExpressionKind.Action,
data=FilteringAction(
field_name="x",
comparator=Comparator.GreaterThan,
value="10.0",
),
),
),
)
assert parsed_expr == expected_expr
def test_parse_filtering_expression_2_pdal_style():
parsed_expr = FilteringExpression.parse_string(
"(classification == 2 || classification == 3) && x > 10.0"
)
expected_expr = FilteringExpression(
kind=FilteringExpressionKind.Binary,
data=BinaryFilteringExpression(
condition=Condition.And,
lhs=FilteringExpression(
kind=FilteringExpressionKind.Binary,
data=BinaryFilteringExpression(
condition=Condition.Or,
lhs=FilteringExpression(
kind=FilteringExpressionKind.Action,
data=FilteringAction(
field_name="classification",
comparator=Comparator.Equality,
value="2",
),
),
rhs=FilteringExpression(
kind=FilteringExpressionKind.Action,
data=FilteringAction(
field_name="classification",
comparator=Comparator.Equality,
value="3",
),
),
),
),
rhs=FilteringExpression(
kind=FilteringExpressionKind.Action,
data=FilteringAction(
field_name="x",
comparator=Comparator.GreaterThan,
value="10.0",
),
),
),
)
assert parsed_expr == expected_expr
def test_apply_filter_expression():
parsed_expr = FilteringExpression.parse_string(
"classification == 2 or classification == 3 and x > 10.0"
)
points = laspy.ScaleAwarePointRecord.zeros(
3,
point_format=laspy.PointFormat(3),
scales=np.array([1.0, 1.0, 1.0]),
offsets=np.array([1.0, 1.0, 1.0]),
)
points["classification"] = [1, 2, 3]
points["x"] = [1.0, 5.0, 11.0]
result = parsed_expr.apply(points)
expected = np.array([False, True, True])
assert np.all(result == expected)
def test_apply_filter_expression_2():
parsed_expr = FilteringExpression.parse_string(
"(classification == 2 or classification == 3) and x > 10.0"
)
points = laspy.ScaleAwarePointRecord.zeros(
3,
point_format=laspy.PointFormat(3),
scales=np.array([1.0, 1.0, 1.0]),
offsets=np.array([1.0, 1.0, 1.0]),
)
points["classification"] = [1, 2, 3]
points["x"] = [1.0, 5.0, 11.0]
result = parsed_expr.apply(points)
expected = np.array([False, False, True])
assert np.all(result == expected)
def test_cli_filtering_classification_eq_2(tmp_path):
path = tmp_path / "simple_cls_2.las"
result = runner.invoke(
app, ["filter", "tests/data/simple.las", str(path), "classification == 2"]
)
assert result.exit_code == 0
las = laspy.read(path)
assert np.all(las.classification == 2)
def test_cli_filtering_classification_ne_2(tmp_path):
path = tmp_path / "simple_cls_2.las"
result = runner.invoke(
app, ["filter", "tests/data/simple.las", str(path), "classification != 2"]
)
assert result.exit_code == 0
las = laspy.read(path)
assert np.all(las.classification != 2)
def test_cli_filtering_classification_in(tmp_path):
path = tmp_path / "simple_cls_2.las"
result = runner.invoke(
app,
[
"filter",
"tests/data/simple.las",
str(path),
"classification in [2, 3, 4]",
],
)
assert result.exit_code == 0
las = laspy.read(path)
assert np.all(np.isin(las.classification, [2, 3, 4]))
def test_cli_filtering_classification_intensity(tmp_path):
path = tmp_path / "simple_cls_2.las"
result = runner.invoke(
app,
[
"filter",
"tests/data/simple.las",
str(path),
"(intensity >= 128 and intensity <= 256) and classification == 2",
],
)
assert result.exit_code == 0
las = laspy.read(path)
assert np.all(las.classification == 2)
assert np.all(las.intensity >= 128)
assert np.all(las.intensity <= 256)
def test_cli_filtering(tmp_path):
path = tmp_path / "simple_cls_2.las"
result = runner.invoke(
app,
[
"filter",
"tests/data/simple.las",
str(path),
"intensity <= 42 and not classification == 2",
],
)
assert result.exit_code == 0
las = laspy.read(path)
assert np.all(las.intensity <= 42)
assert np.all(las.classification != 2)
|
