1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406
|
# Copyright (c) Meta Platforms, Inc. and affiliates.
#
# This source code is licensed under the MIT license found in the
# LICENSE file in the root directory of this source tree.
#
# pyre-strict
import argparse
from typing import Callable, Optional, Sequence, Set, Tuple, Union
import libcst as cst
from libcst.codemod import CodemodContext, VisitorBasedCodemodCommand
from libcst.codemod.visitors import AddImportsVisitor, RemoveImportsVisitor
from libcst.helpers import get_full_name_for_node
from libcst.metadata import QualifiedNameProvider
def leave_import_decorator(
method: Callable[..., Union[cst.Import, cst.ImportFrom]],
) -> Callable[..., Union[cst.Import, cst.ImportFrom]]:
# We want to record any 'as name' that is relevant but only after we leave the corresponding Import/ImportFrom node since
# we don't want the 'as name' to interfere with children 'Name' and 'Attribute' nodes.
def wrapper(
self: "RenameCommand",
original_node: Union[cst.Import, cst.ImportFrom],
updated_node: Union[cst.Import, cst.ImportFrom],
) -> Union[cst.Import, cst.ImportFrom]:
updated_node = method(self, original_node, updated_node)
if original_node != updated_node:
self.record_asname(original_node)
return updated_node
return wrapper
class RenameCommand(VisitorBasedCodemodCommand):
"""
Rename all instances of a local or imported object.
"""
DESCRIPTION: str = "Rename all instances of a local or imported object."
METADATA_DEPENDENCIES = (QualifiedNameProvider,)
@staticmethod
def add_args(arg_parser: argparse.ArgumentParser) -> None:
arg_parser.add_argument(
"--old_name",
dest="old_name",
required=True,
help="Full dotted name of object to rename. Eg: `foo.bar.baz`",
)
arg_parser.add_argument(
"--new_name",
dest="new_name",
required=True,
help=(
"Full dotted name of replacement object. You may provide a single-colon-delimited name to specify how you want the new import to be structured."
+ "\nEg: `foo:bar.baz` will be translated to `from foo import bar`."
+ "\nIf no ':' character is provided, the import statement will default to `from foo.bar import baz` for a `new_name` value of `foo.bar.baz`"
+ " or simply replace the old import on the spot if the old import is an exact match."
),
)
def __init__(self, context: CodemodContext, old_name: str, new_name: str) -> None:
super().__init__(context)
new_module, has_colon, new_mod_or_obj = new_name.rpartition(":")
# Exit early if improperly formatted args.
if ":" in new_module:
raise ValueError("Error: `new_name` should contain at most one colon.")
if ":" in old_name:
raise ValueError("Error: `old_name` should not contain any colons.")
if not has_colon or not new_module:
new_module, _, new_mod_or_obj = new_name.rpartition(".")
self.new_name: str = new_name.replace(":", ".").strip(".")
self.new_module: str = new_module.replace(":", ".").strip(".")
self.new_mod_or_obj: str = new_mod_or_obj
# If `new_name` contains a single colon at the end, then we assume the user wants the import
# to be structured as 'import new_name'. So both self.new_mod_or_obj and self.old_mod_or_obj
# will be empty in this case.
if not self.new_mod_or_obj:
old_module = old_name
old_mod_or_obj = ""
else:
old_module, _, old_mod_or_obj = old_name.rpartition(".")
self.old_name: str = old_name
self.old_module: str = old_module
self.old_mod_or_obj: str = old_mod_or_obj
@property
def as_name(self) -> Optional[Tuple[str, str]]:
if "as_name" not in self.context.scratch:
self.context.scratch["as_name"] = None
return self.context.scratch["as_name"]
@as_name.setter
def as_name(self, value: Optional[Tuple[str, str]]) -> None:
self.context.scratch["as_name"] = value
@property
def scheduled_removals(
self,
) -> Set[Union[cst.CSTNode, Tuple[str, Optional[str], Optional[str]]]]:
"""A set of nodes that have been renamed to help with the cleanup of now potentially unused
imports, during import cleanup in `leave_Module`. Can also contain tuples that can be passed
directly to RemoveImportsVisitor.remove_unused_import()."""
if "scheduled_removals" not in self.context.scratch:
self.context.scratch["scheduled_removals"] = set()
return self.context.scratch["scheduled_removals"]
@scheduled_removals.setter
def scheduled_removals(
self, value: Set[Union[cst.CSTNode, Tuple[str, Optional[str], Optional[str]]]]
) -> None:
self.context.scratch["scheduled_removals"] = value
@property
def bypass_import(self) -> bool:
"""A flag to indicate that an import has been renamed while inside an `Import` or `ImportFrom` node."""
if "bypass_import" not in self.context.scratch:
self.context.scratch["bypass_import"] = False
return self.context.scratch["bypass_import"]
@bypass_import.setter
def bypass_import(self, value: bool) -> None:
self.context.scratch["bypass_import"] = value
def visit_Import(self, node: cst.Import) -> None:
for import_alias in node.names:
alias_name = get_full_name_for_node(import_alias.name)
if alias_name is not None:
if alias_name == self.old_name or alias_name.startswith(
self.old_name + "."
):
# If the import statement is exactly equivalent to the old name, or we are renaming a top-level module of the import,
# it will be taken care of in `leave_Name` or `leave_Attribute` when visiting the Name and Attribute children of this Import.
self.bypass_import = True
@leave_import_decorator
def leave_Import(
self, original_node: cst.Import, updated_node: cst.Import
) -> cst.Import:
new_names = []
for import_alias in updated_node.names:
# We keep the original import_alias here in case it's used by other symbols.
# It will be removed later in RemoveImportsVisitor if it's unused.
new_names.append(import_alias)
import_alias_name = import_alias.name
import_alias_full_name = get_full_name_for_node(import_alias_name)
if import_alias_full_name is None:
raise ValueError("Could not parse full name for ImportAlias.name node.")
if self.old_name.startswith(import_alias_full_name + "."):
replacement_module = self.gen_replacement_module(import_alias_full_name)
if not replacement_module:
# here import_alias_full_name isn't an exact match for old_name
# don't add an import here, it will be handled either in more
# specific import aliases or at the very end
continue
self.bypass_import = True
if replacement_module != import_alias_full_name:
self.scheduled_removals.add(original_node)
new_name_node: Union[cst.Attribute, cst.Name] = (
self.gen_name_or_attr_node(replacement_module)
)
new_names.append(cst.ImportAlias(name=new_name_node))
elif (
import_alias_full_name == self.new_name
and import_alias.asname is not None
):
self.bypass_import = True
# Add removal tuple instead of calling directly
self.scheduled_removals.add(
(
import_alias.evaluated_name,
None,
import_alias.evaluated_alias,
)
)
new_names.append(import_alias.with_changes(asname=None))
return updated_node.with_changes(names=new_names)
def visit_ImportFrom(self, node: cst.ImportFrom) -> None:
module = node.module
if module is None:
return
imported_module_name = get_full_name_for_node(module)
if imported_module_name is None:
return
if imported_module_name == self.old_name or imported_module_name.startswith(
self.old_name + "."
):
# If the imported module is exactly equivalent to the old name or we are renaming a parent module of the current module,
# it will be taken care of in `leave_Name` or `leave_Attribute` when visiting the children of this ImportFrom.
self.bypass_import = True
@leave_import_decorator
def leave_ImportFrom(
self, original_node: cst.ImportFrom, updated_node: cst.ImportFrom
) -> cst.ImportFrom:
module = updated_node.module
if module is None:
return updated_node
imported_module_name = get_full_name_for_node(module)
names = original_node.names
if imported_module_name is None or not isinstance(names, Sequence):
return updated_node
else:
new_names: list[cst.ImportAlias] = []
for import_alias in names:
alias_name = get_full_name_for_node(import_alias.name)
if alias_name is not None:
qual_name = f"{imported_module_name}.{alias_name}"
if self.old_name == qual_name:
replacement_module = self.gen_replacement_module(
imported_module_name
)
replacement_obj = self.gen_replacement(alias_name)
if not replacement_obj:
# The user has requested an `import` statement rather than an `from ... import`.
# This will be taken care of in `leave_Module`, in the meantime, schedule for potential removal.
new_names.append(import_alias)
self.scheduled_removals.add(original_node)
continue
new_import_alias_name: Union[cst.Attribute, cst.Name] = (
self.gen_name_or_attr_node(replacement_obj)
)
# Rename on the spot only if this is the only imported name under the module.
if len(names) == 1:
updated_node = updated_node.with_changes(
module=cst.parse_expression(replacement_module),
)
self.scheduled_removals.add(updated_node)
new_names.append(import_alias)
# Or if the module name is to stay the same.
elif replacement_module == imported_module_name:
self.bypass_import = True
new_names.append(
cst.ImportAlias(name=new_import_alias_name)
)
else:
if self.old_name.startswith(qual_name + "."):
# This import might be in use elsewhere in the code, so schedule a potential removal.
self.scheduled_removals.add(original_node)
new_names.append(import_alias)
if isinstance(new_names[-1].comma, cst.Comma) and updated_node.rpar is None:
new_names[-1] = new_names[-1].with_changes(
comma=cst.MaybeSentinel.DEFAULT
)
return updated_node.with_changes(names=new_names)
return updated_node
def leave_Name(
self, original_node: cst.Name, updated_node: cst.Name
) -> Union[cst.Attribute, cst.Name]:
full_name_for_node: str = original_node.value
full_replacement_name = self.gen_replacement(full_name_for_node)
# If a node has no associated QualifiedName, we are still inside an import statement.
inside_import_statement: bool = not self.get_metadata(
QualifiedNameProvider, original_node, set()
)
if QualifiedNameProvider.has_name(self, original_node, self.old_name) or (
inside_import_statement and full_replacement_name == self.new_name
):
if not full_replacement_name:
full_replacement_name = self.new_name
if not inside_import_statement:
self.scheduled_removals.add(original_node)
return self.gen_name_or_attr_node(full_replacement_name)
return updated_node
def leave_Attribute(
self, original_node: cst.Attribute, updated_node: cst.Attribute
) -> Union[cst.Name, cst.Attribute]:
full_name_for_node = get_full_name_for_node(original_node)
if full_name_for_node is None:
raise ValueError("Could not parse full name for Attribute node.")
full_replacement_name = self.gen_replacement(full_name_for_node)
# If a node has no associated QualifiedName, we are still inside an import statement.
inside_import_statement: bool = not self.get_metadata(
QualifiedNameProvider, original_node, set()
)
if QualifiedNameProvider.has_name(
self,
original_node,
self.old_name,
) or (inside_import_statement and full_replacement_name == self.new_name):
new_value, new_attr = self.new_module, self.new_mod_or_obj
if not inside_import_statement:
self.scheduled_removals.add(original_node.value)
if full_replacement_name == self.new_name:
value = cst.parse_expression(new_value)
if new_attr:
return updated_node.with_changes(
value=value,
attr=cst.Name(value=new_attr.rstrip(".")),
)
assert isinstance(value, (cst.Name, cst.Attribute))
return value
return self.gen_name_or_attr_node(new_attr)
return updated_node
def leave_Module(
self, original_node: cst.Module, updated_node: cst.Module
) -> cst.Module:
for removal in self.scheduled_removals:
if isinstance(removal, tuple):
RemoveImportsVisitor.remove_unused_import(
self.context, removal[0], removal[1], removal[2]
)
else:
RemoveImportsVisitor.remove_unused_import_by_node(self.context, removal)
# If bypass_import is False, we know that no import statements were directly renamed, and the fact
# that we have any `self.scheduled_removals` tells us we encountered a matching `old_name` in the code.
if not self.bypass_import and self.scheduled_removals:
if self.new_module and self.new_module != "builtins":
new_obj: Optional[str] = (
self.new_mod_or_obj.split(".")[0] if self.new_mod_or_obj else None
)
AddImportsVisitor.add_needed_import(
self.context, module=self.new_module, obj=new_obj
)
return updated_node
def gen_replacement(self, original_name: str) -> str:
module_as_name = self.as_name
if module_as_name is not None:
if original_name == module_as_name[0]:
original_name = module_as_name[1]
elif original_name.startswith(module_as_name[0] + "."):
original_name = original_name.replace(
module_as_name[0] + ".", module_as_name[1] + ".", 1
)
if self.old_module and original_name == self.old_mod_or_obj:
return self.new_mod_or_obj
elif original_name == self.old_name:
return (
self.new_mod_or_obj
if (not self.bypass_import and self.new_mod_or_obj)
else self.new_name
)
elif original_name.endswith("." + self.old_mod_or_obj):
return self.new_mod_or_obj
else:
return self.gen_replacement_module(original_name)
def gen_replacement_module(self, original_module: str) -> str:
return self.new_module if original_module == self.old_module else ""
def gen_name_or_attr_node(
self, dotted_expression: str
) -> Union[cst.Attribute, cst.Name]:
name_or_attr_node: cst.BaseExpression = cst.parse_expression(dotted_expression)
if not isinstance(name_or_attr_node, (cst.Name, cst.Attribute)):
raise ValueError(
"`parse_expression()` on dotted path returned non-Attribute-or-Name."
)
return name_or_attr_node
def record_asname(self, original_node: Union[cst.Import, cst.ImportFrom]) -> None:
# Record the import's `as` name if it has one, and set the attribute mapping.
names = original_node.names
if not isinstance(names, Sequence):
return
for import_alias in names:
alias_name = get_full_name_for_node(import_alias.name)
if isinstance(original_node, cst.ImportFrom):
module = original_node.module
if module is None:
return
module_name = get_full_name_for_node(module)
if module_name is None:
return
qual_name = f"{module_name}.{alias_name}"
else:
qual_name = alias_name
if qual_name is not None and alias_name is not None:
if qual_name == self.old_name or self.old_name.startswith(
qual_name + "."
):
as_name_optional = import_alias.asname
as_name_node = (
as_name_optional.name if as_name_optional is not None else None
)
if as_name_node is not None and isinstance(
as_name_node, (cst.Name, cst.Attribute)
):
full_as_name = get_full_name_for_node(as_name_node)
if full_as_name is not None:
self.as_name = (full_as_name, alias_name)
|