File: test_codec.py

package info (click to toggle)
python-miltertest 1.0.0-2
  • links: PTS, VCS
  • area: main
  • in suites: forky, sid, trixie
  • size: 176 kB
  • sloc: python: 771; makefile: 4
file content (295 lines) | stat: -rw-r--r-- 10,982 bytes parent folder | download
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
# Copyright 2011 Chris Siebenmann
# Copyright 2024 Paul Arthur MacIain
# GNU General Public License v3.0 (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)

# TODO: we should have some real, validated binary messages so that we can
# test proper interoperability.

import struct
import unittest

from miltertest import codec
from miltertest import constants


class codingTests(unittest.TestCase):
    ctypes = (
        ('char', 'A'),
        ('char3', 'abc'),
        ('u16', 10),
        ('u32', 30000),
        ('str', 'a long string'),
        (
            'strs',
            [
                'a',
                'b',
                'c',
            ],
        ),
        (
            'strpairs',
            [
                'd',
                'e',
                'f',
                'g',
                'h',
                'i',
            ],
        ),
        ('buf', 'a buffer with an embedded \0 just for fun'),
        # Corner case for strings
        ('str', ''),
        ('strs', ['a', '']),
        ('strpairs', []),
        # these are corner cases for unsigned int ranges
        ('u16', (2**16) - 1),
        ('u32', (2**32) - 1),
    )

    def testEncodeDecode(self):
        """Test that we can encode and then decode an example of
        every known type."""
        for ctype, val in self.ctypes:
            d = codec.encode(ctype, val)
            r, d2 = codec.decode(ctype, d)
            self.assertEqual(val, r)
            # also, nothing left over from the data
            self.assertEqual(d2, b'')

    # Test bad encodes that should error out.
    bencs = (
        ('char3', 'a'),
        ('char3', 'abcd'),
        ('strs', []),
        (
            'strpairs',
            [
                'a',
            ],
        ),
    )

    def testBadEncode(self):
        """Test that certain things fail to encode with errors."""
        for ctype, val in self.bencs:
            self.assertRaises(codec.MilterProtoError, codec.encode, ctype, val)

    bdecs = (
        # No terminating \0
        ('str', b'abcdef'),
        # uneven number of pairs
        ('strpairs', b'abc\0def\0ghi\0'),
        # No strings in string array
        ('strs', b''),
    )

    def testBadDecode(self):
        """Test that certain things fail to decode."""
        for ctype, data in self.bdecs:
            self.assertRaises(codec.MilterProtoError, codec.decode, ctype, data)


# A sample message for every milter protocol message that we know about.
sample_msgs = [
    ('A', {}),
    ('B', {'buf': 'abcdefghi\nthis is a test, yes.\n\t-cks'}),
    ('C', {'hostname': 'localhost', 'family': '4', 'port': 3000, 'address': '127.0.0.1'}),
    ('D', {'cmdcode': 'R', 'nameval': ['rcpt_mailer', 'abc', 'rcpt_host', 'localhost', 'rcpt_addr', 'cks']}),
    ('E', {}),
    ('H', {'helo': 'localhost.localdomain'}),
    ('K', {}),
    ('L', {'name': 'Subject', 'value': 'Tedium'}),
    ('M', {'args': ['<>', 'haha']}),
    ('N', {}),
    ('O', {'version': 2, 'actions': 0x01, 'protocol': 0x02}),
    ('Q', {}),
    ('R', {'args': ['<foo@example.com>', 'SIZE=100']}),
    ('T', {}),
    ('+', {'rcpt': '<foo@example.com>'}),
    ('-', {'rcpt': '<foo@example.com>'}),
    ('2', {'rcpt': '<foo@example.com>', 'args': ['SIZE=100']}),
    ('4', {}),
    ('a', {}),
    ('b', {'buf': 'ARGLEBARGLE TEDIUM'}),
    ('c', {}),
    ('d', {}),
    ('e', {'from': '<foo@example.com>', 'args': ['AUTH=bar']}),
    ('f', {}),
    ('h', {'name': 'X-Annoyance', 'value': 'Testing'}),
    ('l', {'where': 1, 'macros': 'i dunno, probably something'}),
    ('m', {'index': 10, 'name': 'X-Spam-Goblets', 'value': '100% canned'}),
    ('p', {}),
    ('q', {'reason': 'Your mother was an Englishman'}),
    ('r', {}),
    ('s', {}),
    ('t', {}),
    ('y', {'smtpcode': '450', 'space': ' ', 'text': 'lazyness strikes'}),
    # It is explicitly valid to have an empty value for a modified
    # header; this deletes the header. We test that we can at least
    # generate such a message.
    ('m', {'index': 1, 'name': 'Subject', 'value': ''}),
    # Macros can be empty.
    ('D', {'cmdcode': 'H', 'nameval': []}),
]


class basicTests(unittest.TestCase):
    def testMessageEncode(self):
        """Can we encode every sample message to a non-zero message
        that has the cmd code as its fifth character?"""
        for cmd, args in sample_msgs:
            r = codec.encode_msg(cmd, **args)
            self.assertNotEqual(len(r), 0)
            self.assertTrue(len(r) >= 5)
            self.assertEqual(chr(r[4]), cmd)
            if not args:
                self.assertEqual(len(r), 5)

    def testMessageDecode(self):
        """Test that encoded messages decode back to something that
        is identical to what we started with."""
        suffix = b'\nabc'
        for cmd, args in sample_msgs:
            r = codec.encode_msg(cmd, **args)
            dcmd, dargs, rest = codec.decode_msg(r)
            self.assertEqual(cmd, dcmd)
            self.assertEqual(args, dargs)
            self.assertEqual(rest, b'')
            # As a bonus, test that decoding with more data works
            # right for all messages.
            dcmd, dargs, rest = codec.decode_msg(r + suffix)
            self.assertEqual(rest, suffix)

    def testTruncatedDecode(self):
        """Test that we signal not-enough on truncated decodes."""
        for cmd, args in sample_msgs:
            r = codec.encode_msg(cmd, **args)
            r = r[:-1]
            self.assertRaises(codec.MilterIncomplete, codec.decode_msg, r)

    def testBrokenCommands(self):
        """Sleazily test that we signal errors on malformed packets."""
        # Encode something that has no arguments.
        r = codec.encode_msg('A')
        # Break the command byte to something that doesn't exist.
        r = r[:4] + b'!'
        self.assertRaises(codec.MilterDecodeError, codec.decode_msg, r)
        # Break the command byte to something that requires arguments.
        r = r[:4] + b'D'
        self.assertRaises(codec.MilterDecodeError, codec.decode_msg, r)

    # Change the claimed length of a message by delta (may be positive
    # or negative). If this lengthens the message, you need to supply
    # extra actual data yourself.
    def _changelen(self, msg, delta):
        tlen = struct.unpack('!L', msg[:4])[0]
        tlen = tlen + delta
        if tlen <= 0:
            raise IndexError('new length too short')
        return struct.pack('!L', tlen) + msg[4:]

    def testBrokenLength(self):
        """Sleazily test for a too-short version of every message."""
        minlen = struct.pack('!L', 1)
        for cmd, args in sample_msgs:
            # We can't shorten a message that has no arguments.
            if not args:
                continue
            # We can't shorten or grow SMFIC_BODY or
            # SMFIR_REPLYBODY messages.
            if cmd in (constants.SMFIC_BODY, constants.SMFIR_REPLBODY):
                continue
            r = codec.encode_msg(cmd, **args)
            r = self._changelen(r, -1)
            self.assertRaises(codec.MilterDecodeError, codec.decode_msg, r)
            # See what happens with a minimum-length message.
            r = minlen + r[4:]
            self.assertRaises(codec.MilterDecodeError, codec.decode_msg, r)

    def testExtraLength(self):
        """Sleazily test that messages with extra packet data
        fail to decode."""
        for cmd, args in sample_msgs:
            # We can't shorten or grow SMFIC_BODY or
            # SMFIR_REPLYBODY messages.
            if cmd in (constants.SMFIC_BODY, constants.SMFIR_REPLBODY):
                continue
            r = codec.encode_msg(cmd, **args)
            # remember: we've got to supply the actual extra
            # data, or we just get a 'message incomplete' note.
            r = self._changelen(r, +10) + (b'*' * 10)
            self.assertRaises(codec.MilterDecodeError, codec.decode_msg, r)

    def testZeroLength(self):
        """Trying to decode a zero-length message should fail with
        a decode error."""
        zlen = struct.pack('!L', 0)
        self.assertRaises(codec.MilterDecodeError, codec.decode_msg, zlen)

    def testExtraArgsEncode(self):
        """Test that adding arguments results in an encode error."""
        for cmd, args in sample_msgs:
            args = args.copy()
            args['blarg'] = 10
            self.assertRaises(codec.MilterProtoError, codec.encode_msg, cmd, **args)

    def testMissingArgsEncode(self):
        """Test that removing arguments results in an encode error."""
        for cmd, args in sample_msgs:
            # Can't remove an argument if we don't have one
            if not args:
                continue
            args = args.copy()
            args.popitem()
            self.assertRaises(codec.MilterProtoError, codec.encode_msg, cmd, **args)

    # These test results are from the MTA side of things.
    optneg_tests = (
        ((0x0, 0x0), (0x0, 0x0)),
        ((0xFFFFFF, 0xFFFFFF), (constants.SMFI_V6_ACTS, constants.SMFI_V6_PROT)),
        ((0x10, 0x10), (0x10, 0x10)),
        ((constants.SMFI_V2_ACTS, constants.SMFI_V2_PROT), (constants.SMFI_V2_ACTS, constants.SMFI_V2_PROT)),
    )

    def testOptnegCap(self):
        """Test that optneg_mta_capable correctly masks things."""
        for a, b in self.optneg_tests:
            r = codec.optneg_mta_capable(a[0], a[1])
            self.assertEqual(r, b)

    optneg_milter_tests = (
        ((constants.SMFI_V6_ACTS, constants.SMFI_V6_PROT), (constants.SMFI_V6_ACTS, 0), (constants.SMFI_V6_ACTS, 0)),
        ((constants.SMFI_V2_ACTS, constants.SMFI_V2_PROT), (constants.SMFI_V2_ACTS, 0), (constants.SMFI_V2_ACTS, 0)),
        ((constants.SMFI_V2_ACTS, 0xFFFFFF), (constants.SMFI_V2_ACTS, 0), (constants.SMFI_V2_ACTS, 0xE00000)),
    )

    def testOptnegMilterCap(self):
        """Test that optneg_milter_capable correctly masks things."""
        for a, b, c in self.optneg_milter_tests:
            r = codec.optneg_milter_capable(a[0], a[1], b[0], b[1])
            self.assertEqual(r, c)

    def testOptnegEncode(self):
        """Test that encode_optneg() works right."""
        return
        for a, b in self.optneg_tests:
            r = codec.encode_optneg(actions=a[0], protocol=a[1])
            rcmd, rdict, data = codec.decode_msg(r)
            self.assertEqual(data, '')
            self.assertEqual(rcmd, constants.SMFIC_OPTNEG)
            rpair = (rdict['actions'], rdict['protocol'])
            self.assertEqual(rpair, b)

    def testOptnegMilterEncode(self):
        """Test encode_optneg() with is_milter=True, which should
        not clamp protocol to SMFI_V6_PROT."""
        r = codec.encode_optneg(actions=0xFFFFFF, protocol=0xFFFFFF, is_milter=True)
        rcmd, rdict, data = codec.decode_msg(r)
        self.assertEqual(rdict['actions'], constants.SMFI_V6_ACTS)
        self.assertEqual(rdict['protocol'], 0xFFFFFF)


if __name__ == '__main__':
    unittest.main()