1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
|
import json
from string import Template
from uuid import uuid4
import boto3
import pytest
from botocore.exceptions import ClientError
from moto import mock_aws
from tests import EXAMPLE_AMI_ID
SEC_GROUP_INGRESS = Template(
"""{
"AWSTemplateFormatVersion": "2010-09-09",
"Description": "AWS CloudFormation Template to create an EC2 instance",
"Parameters": {
"VPCId": {
"Type": "String",
"Description": "The VPC ID",
"AllowedPattern": "^vpc-[a-zA-Z0-9]*"
}
},
"Resources": {
"SecurityGroup": {
"Type": "AWS::EC2::SecurityGroup",
"Properties": {
"GroupDescription": "Test VPC security group",
"GroupName": $group_name,
"VpcId": {
"Ref": "VPCId"
}
}
},
"SSHIngressRule": {
"Type": "AWS::EC2::SecurityGroupIngress",
"Properties": {
"CidrIp": "10.0.0.0/8",
"Description": "Allow SSH traffic from 10.0.0.0/8",
"FromPort": 22,
"ToPort": 22,
"GroupId": {
"Fn::GetAtt": [
"SecurityGroup",
"GroupId"
]
},
"IpProtocol": "tcp"
}
}
}
}
"""
)
SEC_GROUP_INGRESS_WITHOUT_DESC = Template(
"""{
"AWSTemplateFormatVersion": "2010-09-09",
"Description": "AWS CloudFormation Template to create an EC2 instance",
"Parameters": {
"VPCId": {
"Type": "String",
"Description": "The VPC ID",
"AllowedPattern": "^vpc-[a-zA-Z0-9]*"
}
},
"Resources": {
"SecurityGroup": {
"Type": "AWS::EC2::SecurityGroup",
"Properties": {
"GroupDescription": "Test VPC security group",
"GroupName": "$group_name",
"VpcId": {
"Ref": "VPCId"
}
}
},
"SSHIngressRule": {
"Type": "AWS::EC2::SecurityGroupIngress",
"Properties": {
"CidrIp": "10.0.0.0/8",
"FromPort": 22,
"ToPort": 22,
"GroupId": {
"Fn::GetAtt": [
"SecurityGroup",
"GroupId"
]
},
"IpProtocol": "tcp"
}
}
}
}
"""
)
SEC_GROUP_SOURCE = {
"AWSTemplateFormatVersion": "2010-09-09",
"Resources": {
"my-security-group": {
"Type": "AWS::EC2::SecurityGroup",
"Properties": {"GroupDescription": "My other group"},
},
"Ec2Instance2": {
"Type": "AWS::EC2::Instance",
"Properties": {
"SecurityGroups": [{"Ref": "InstanceSecurityGroup"}],
"ImageId": EXAMPLE_AMI_ID,
},
},
"InstanceSecurityGroup": {
"Type": "AWS::EC2::SecurityGroup",
"Properties": {
"GroupDescription": "My security group",
"Tags": [{"Key": "bar", "Value": "baz"}],
"SecurityGroupIngress": [
{
"IpProtocol": "tcp",
"FromPort": "22",
"ToPort": "22",
"CidrIp": "123.123.123.123/32",
},
{
"IpProtocol": "tcp",
"FromPort": "80",
"ToPort": "8000",
"SourceSecurityGroupId": {"Ref": "my-security-group"},
},
],
},
},
},
}
@mock_aws
def test_security_group_ingress():
cf_client = boto3.client("cloudformation", region_name="us-east-1")
ec2 = boto3.resource("ec2", region_name="us-west-1")
ec2_client = boto3.client("ec2", region_name="us-east-1")
group_name = str(uuid4())
vpc = ec2.create_vpc(CidrBlock="10.0.0.0/16")
cf_client.create_stack(
StackName=str(uuid4()),
TemplateBody=SEC_GROUP_INGRESS.substitute(group_name=group_name),
Parameters=[{"ParameterKey": "VPCId", "ParameterValue": vpc.id}],
Capabilities=["CAPABILITY_NAMED_IAM"],
OnFailure="DELETE",
)
groups = ec2_client.describe_security_groups()["SecurityGroups"]
group = [g for g in groups if g["GroupName"] == group_name][0]
assert group["Description"] == "Test VPC security group"
assert len(group["IpPermissions"]) == 1
ingress = group["IpPermissions"][0]
assert ingress["FromPort"] == 22
assert ingress["ToPort"] == 22
assert ingress["IpProtocol"] == "tcp"
assert ingress["IpRanges"] == [
{"CidrIp": "10.0.0.0/8", "Description": "Allow SSH traffic from 10.0.0.0/8"}
]
@mock_aws
def test_delete_security_group_ingress():
cf_client = boto3.client("cloudformation", region_name="us-east-1")
ec2 = boto3.resource("ec2", region_name="us-west-1")
ec2_client = boto3.client("ec2", region_name="us-east-1")
stack_name = str(uuid4())
group_name = str(uuid4())
vpc = ec2.create_vpc(CidrBlock="10.0.0.0/16")
cf_client.create_stack(
StackName=stack_name,
TemplateBody=SEC_GROUP_INGRESS.substitute(group_name=group_name),
Parameters=[{"ParameterKey": "VPCId", "ParameterValue": vpc.id}],
Capabilities=["CAPABILITY_NAMED_IAM"],
OnFailure="DELETE",
)
sg_id = cf_client.list_stack_resources(StackName=stack_name)[
"StackResourceSummaries"
][0]["PhysicalResourceId"]
assert (
len(ec2_client.describe_security_groups(GroupIds=[sg_id])["SecurityGroups"])
== 1
)
cf_client.delete_stack(StackName=stack_name)
with pytest.raises(ClientError) as exc:
ec2_client.describe_security_groups(GroupIds=[sg_id])
assert exc.value.response["Error"]["Code"] == "InvalidGroup.NotFound"
@mock_aws
def test_security_group_ingress_without_description():
cf_client = boto3.client("cloudformation", region_name="us-east-1")
ec2 = boto3.resource("ec2", region_name="us-west-1")
ec2_client = boto3.client("ec2", region_name="us-east-1")
group_name = str(uuid4())
vpc = ec2.create_vpc(CidrBlock="10.0.0.0/16")
cf_client.create_stack(
StackName=str(uuid4()),
TemplateBody=SEC_GROUP_INGRESS_WITHOUT_DESC.substitute(group_name=group_name),
Parameters=[{"ParameterKey": "VPCId", "ParameterValue": vpc.id}],
Capabilities=["CAPABILITY_NAMED_IAM"],
OnFailure="DELETE",
)
groups = ec2_client.describe_security_groups()["SecurityGroups"]
group = [g for g in groups if g["GroupName"] == group_name][0]
assert group["Description"] == "Test VPC security group"
assert len(group["IpPermissions"]) == 1
ingress = group["IpPermissions"][0]
assert ingress["IpRanges"] == [{"CidrIp": "10.0.0.0/8"}]
@mock_aws
def test_stack_security_groups():
first_desc = str(uuid4())
second_desc = str(uuid4())
our_template = SEC_GROUP_SOURCE.copy()
our_template["Resources"]["my-security-group"]["Properties"]["GroupDescription"] = (
second_desc
)
our_template["Resources"]["InstanceSecurityGroup"]["Properties"][
"GroupDescription"
] = first_desc
template = json.dumps(our_template)
cf = boto3.client("cloudformation", region_name="us-west-1")
stack_name = str(uuid4())[0:6]
cf.create_stack(
StackName=stack_name,
TemplateBody=template,
Tags=[{"Key": "foo", "Value": "bar"}],
)
ec2 = boto3.client("ec2", region_name="us-west-1")
instance_group = ec2.describe_security_groups(
Filters=[{"Name": "description", "Values": [first_desc]}]
)["SecurityGroups"][0]
assert instance_group["Description"] == first_desc
assert "Tags" in instance_group
assert {"Key": "bar", "Value": "baz"} in instance_group["Tags"]
assert {"Key": "foo", "Value": "bar"} in instance_group["Tags"]
other_group = ec2.describe_security_groups(
Filters=[{"Name": "description", "Values": [second_desc]}]
)["SecurityGroups"][0]
instance = cf.list_stack_resources(StackName=stack_name)["StackResourceSummaries"][
1
]
instance_id = instance["PhysicalResourceId"]
ec2_instance = ec2.describe_instances(InstanceIds=[instance_id])["Reservations"][0][
"Instances"
][0]
assert (
ec2_instance["NetworkInterfaces"][0]["Groups"][0]["GroupId"]
== instance_group["GroupId"]
)
rule1, rule2 = instance_group["IpPermissions"]
assert int(rule1["ToPort"]) == 22
assert int(rule1["FromPort"]) == 22
assert rule1["IpRanges"][0]["CidrIp"] == "123.123.123.123/32"
assert rule1["IpProtocol"] == "tcp"
assert int(rule2["ToPort"]) == 8000
assert int(rule2["FromPort"]) == 80
assert rule2["IpProtocol"] == "tcp"
assert rule2["UserIdGroupPairs"][0]["GroupId"] == other_group["GroupId"]
|
