1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613
|
"""Tests that original from the developer test suite."""
import os
import glob
import numbers
import re
from copy import deepcopy
import pytest
from ruamel.yaml import YAML
from ruamel.yaml.compat import StringIO
from ruamel.yaml.comments import CommentedMap
from ruamel.yaml.scalarstring import DoubleQuotedScalarString as DQ
from ntc_templates.parse import parse_output
FILE_PATH = os.path.abspath(__file__)
FILE_DIR = os.path.dirname(FILE_PATH)
TEST_DIR = f"{FILE_DIR}/tests"
YAML_OBJECT = YAML()
YAML_OBJECT.explicit_start = True
YAML_OBJECT.indent(sequence=4, offset=2)
YAML_OBJECT.block_style = True
RE_MULTILINE_REMARK = re.compile(r"(.*\n\s*#)(.*)")
def ensure_spacing_for_multiline_comment(remark):
r"""
Finds all comments and ensures a single space after "#" symbol.
Args:
remark (str): The remark of a comment from a ``ruamel.yaml.token.CommentToken``.
Returns:
str: The ``remark`` formatted with a single space after comment start, "#"
Example:
>>> remark = "comment 11\n# comment 12\n#comment 13\n"
>>> remark_formatted = ensure_spacing_for_multiline_comment(remark)
>>> # Formatting has normalized each comment to have a single space after the "#"
>>> remark_formatted
'comment 11\n# comment 12\n# comment 13'
>>>
"""
remarks = re.findall(RE_MULTILINE_REMARK, remark)
# remarks that don't have a subsequent comment are not captured by regex
if not remarks:
remarks = (("", remark),)
# Example remarks: [('comment \n#', ' comment2 '), ('\n #', 'comment3 # 9')]
remark_formatted = "".join([entry[0] + " " + entry[1].strip() for entry in remarks])
return remark_formatted
def ensure_space_after_octothorpe(comment):
r"""
Ensures a single space is between the "#" and first letter of a comment.
Args:
comment (ruamel.yaml.token.CommentToken): The comment to update.
Returns:
None: The comment is updated in place.
Example:
>>> from ruamel.yaml import YAML
>>> yml = YAML()
>>> with open("test.yml", encoding="utf-8") as fh: # doctest: +SKIP
... print(fh.read())
... fh.seek(0)
... data = yml.load(fh)
...
---
a: 5 # comment 1
b: 6 #comment 2
#comment 3
c:
- 7 #comment 4
#comment 5
- 8
#comment 6
d:
#comment 7
e: a #comment 8
f:
- 9
#comment 9
- 10
- a:
a: 8
#comment 10
b: 1
- b: 1
- 9
#comment 11
# comment 12
#comment 13
>>> type(data) # doctest: +SKIP
<class 'ruamel.yaml.comments.CommentedMap'>
>>> comment = data.ca.items["b"][2] # doctest: +SKIP
>>> comment # doctest: +SKIP
CommentToken('#comment 2\n#comment 3\n', line: 2, col: 5)
>>> ensure_space_after_octothorpe(comment) # doctest: +SKIP
>>> # Both comments within the CommentToken object
>>> # now have a space between the "#" and the first symbol
>>> comment # doctest: +SKIP
CommentToken('# comment 2\n# comment 3\n', line: 2, col: 5)
>>>
"""
if comment is not None:
# Comments can start with whitespace,
# so partition is used to preserve that in the final result
space, _, remark = comment.value.partition("#")
remark_formatted = ensure_spacing_for_multiline_comment(remark)
comment.value = f"{space}# {remark_formatted.lstrip()}\n"
def ensure_space_comments(comments):
r"""
Ensures there is a space after the "#" in comments.
Args:
comments (iter): The comments from ruamel.yaml.YAML() object.
Returns:
None: Comments are update in place.
Example:
>>> from ruamel.yaml import YAML
>>> yml = YAML()
>>> with open("test.yml", encoding="utf-8") as fh: # doctest: +SKIP
... print(fh.read())
... fh.seek(0)
... data = yml.load(fh)
...
---
a: 5 # comment 1
b: 6 #comment 2
#comment 3
c:
- 7 #comment 4
#comment 5
- 8
#comment 6
d:
#comment 7
e: a #comment 8
f:
- 9
#comment 9
- 10
- a:
a: 8
#comment 10
b: 1
- b: 1
- 9
#comment 11
# comment 12
#comment 13
>>> type(data) # doctest: +SKIP
<class 'ruamel.yaml.comments.CommentedMap'>
>>> comments = data.ca.items.values() # doctest: +SKIP
>>> comments # doctest: +SKIP
dict_values([
[None, None, CommentToken('# comment 1\n', line: 1, col: 5), None],
[None, None, CommentToken('#comment 2\n#comment 3\n', line: 2, col: 5), None],
[None, None, None, [CommentToken('#comment 7\n', line: 10, col: 2)]]
])
>>> ensure_space_comments(comments) # doctest: +SKIP
>>> # Every comment now has a space between the "#" and the first symbol
>>> comments # doctest: +SKIP
dict_values([
[None, None, CommentToken('# comment 1\n', line: 1, col: 5), None],
[None, None, CommentToken('# comment 2\n# comment 3\n', line: 2, col: 5), None],
[None, None, None, [CommentToken('# comment 7\n', line: 10, col: 2)]]
])
>>>
"""
comment_objects = (comment for comment_list in comments for comment in comment_list)
for comment in comment_objects:
# Some comments are nested inside an additional list
if not isinstance(comment, list):
ensure_space_after_octothorpe(comment)
else:
for cmt in comment:
ensure_space_after_octothorpe(cmt)
def update_yaml_comments(yaml_object):
"""
Ensures comments have a space after the "#" on itself and its entries.
Args:
yaml_object (ruamel.yaml.comments.CommentedMap | ruamel.yaml.comments.CommentedSeq): The list or dict object.
Returns:
None: Comments are updated in place.
Example:
>>> from ruamel.yaml import YAML
>>> yml = YAML()
>>> with open("test.yml", encoding="utf-8") as fh: # doctest: +SKIP
... print(fh.read())
... fh.seek(0)
... data = yml.load(fh)
...
---
a: 5 # comment 1
b: 6 #comment 2
#comment 3
c:
- 7 #comment 4
#comment 5
- 8
#comment 6
d:
#comment 7
e: a #comment 8
f:
- 9
#comment 9
- 10
- a:
a: 8
#comment 10
b: 1
- b: 1
- 9
#comment 11
# comment 12
#comment 13
>>> type(data) # doctest: +SKIP
<class 'ruamel.yaml.comments.CommentedMap'>
>>> update_yaml_comments(data) # doctest: +SKIP
>>> with open("test.yml", "w", encoding="utf-8") as fh: # doctest: +SKIP
... yml.dump(data, fh)
...
>>>
# Notice that comments now have a space between the hash and first symbol.
>>> with open("test.yml", encoding="utf-8") as fh: # doctest: +SKIP
... print(fh.read())
...
a: 5 # comment 1
b: 6 # comment 2
#comment 3
c:
- 7 # comment 4
#comment 5
- 8
# comment 6
d:
# comment 7
e: a # comment 8
f:
- 9
# comment 9
- 10
- a:
a: 8
# comment 10
b: 1
- b: 1
- 9
# comment 11
# comment 12
# comment 13
>>>
"""
comments = yaml_object.ca.items.values()
ensure_space_comments(comments)
try:
yaml_object_values = yaml_object.values()
except AttributeError:
yaml_object_values = yaml_object
for entry in yaml_object_values:
if isinstance(entry, (dict, list)):
update_yaml_comments(entry)
def transform_file(filepath):
"""
Loads YAML file and formats to adhere to yamllint config.
Args:
filepath (str): The full path to a YAML file.
Returns:
None: File I/O is performed to ensure YAML file adheres to yamllint config.
Example:
>>> filepath = "tests/cisco_ios/show_version/cisco_ios_show_version.yml"
>>> transform_file(filepath)
>>>
"""
with open(filepath, encoding="utf-8") as parsed_file:
parsed_object = YAML_OBJECT.load(parsed_file)
ensure_yaml_standards(parsed_object, filepath)
def transform_glob(dirpath):
"""
Globs for YAML files and formats to adhere to yamllint config.
Every file in ``dirpath`` ending in ``.yml`` will be formatted according to
yamllint config. Since this is using glob, the directory string passed in can
also include glob syntax (see ``Example``)
Args:
dirpath (str): The path to search for files with ``.yml`` extension.
Returns:
None: File I/O is performed to ensure YAML files adhere to yamllint config.
Example:
>>> dirpath = "tests/*/*"
>>> transform_file(dirpath) # doctest: +SKIP
# Each filename is printed to the terminal
>>>
"""
# This commented out code was used for mass renaming of files;
# it is probably not needed anymore
# for file in glob.iglob("{0}/*.parsed".format(dirpath)):
# os.rename(file, file.replace(file[-6:], "yml"))
for file in glob.iglob(f"{dirpath}/*.yml"):
print(file)
transform_file(file)
def ensure_yaml_standards(parsed_object, output_path):
"""
Ensures YAML files adhere to yamllint config as defined in this project.
Args:
parsed_object (dict): The TextFSM/CliTable data converted to a list of dicts.
The list of dicts must be the value of a dictionary key, ``parsed_sample``.
output_path (str): The filepath to write the ``parsed_object`` to.
Returns:
None: File I/O is performed to write ``parsed_object`` to ``output_path``.
"""
sorted_entry = []
for entry in parsed_object["parsed_sample"]:
# TextFSM conversion will allways be a list of dicts
new_dict = CommentedMap()
for key, value in sorted(entry.items()):
# TextFSM capture groups always return strings or lists
# This also accounts for numbers incase the YAML was done by hand
if isinstance(value, (str, numbers.Number)):
new_dict[key] = DQ(value)
else:
new_dict[key] = [DQ(val) for val in value]
sorted_entry.append(new_dict)
parsed_object["parsed_sample"] = sorted_entry
try:
update_yaml_comments(parsed_object)
except AttributeError:
pass
with open(output_path, "w", encoding="utf-8") as parsed_file:
YAML_OBJECT.dump(parsed_object, parsed_file)
def parse_test_filepath(filepath):
"""
Parses fullpath of test file to obtain platform, command, and filename info.
Args:
filepath (str): The path to a test file from platform directory or earlier.
Returns:
tuple: Strings of platform, command, and the filename without the extension.
Example:
>>> filepath = "tests/cisco_ios/show_version/cisco_ios_show_version.raw"
>>> platform, command, filename = parse_test_filepath(filepath)
>>> print(platform)
cisco_ios
>>> print(command)
show version
>>> print(filename)
cisco_ios_show_version
>>>
"""
command_dir, filename = os.path.split(filepath)
platform_dir, command = os.path.split(command_dir)
_, platform = os.path.split(platform_dir)
command_without_underscores = command.replace("_", " ")
filename_without_extension, _ = filename.rsplit(".", 1)
return platform, command_without_underscores, filename_without_extension
def build_parsed_data_from_output(filepath, test_dir=TEST_DIR):
"""
Generates a YAML file from the file containing the raw command output.
The command output should be stored in a file in the appropriate directory;
for example, ``tests/cisco_ios/show_version/cisco_ios_show_version.raw``
This uses ``lib.ntc_templates.parse.parse_output``, so the template must
be in the ``templates/`` directory, and ``templates/index`` must be updated
with the correct entry for the template.
Args:
filepath (str): The path to the file containing sample command output.
test_dir (str): The root directory to story the resulting YAML file.
Returns
None: File I/O is performed to generate a YAML file pased on command output.
Example:
>>> root_dir = "tests/cisco_ios/dir"
>>> os.listdir(root_dir) # doctest: +SKIP
['cisco_ios_dir.raw']
>>> filepath = "tests/cisco_ios/dir/cisco_ios_dir.raw"
>>> build_parsed_data_from_output(filepath) # doctest: +SKIP
>>> os.listdir(root_dir) # doctest: +SKIP
['cisco_ios_dir.raw', 'cisco_ios_dir.yml']
>>>
"""
platform, command, filename = parse_test_filepath(filepath)
with open(filepath, encoding="utf-8") as output_file:
output_data = output_file.read()
structured_data = parse_output(platform, command, output_data)
command_with_underscores = command.replace(" ", "_")
yaml_file = f"{test_dir}/{platform}/{command_with_underscores}/{filename}.yml"
ensure_yaml_standards({"parsed_sample": structured_data}, yaml_file)
def build_parsed_data_from_dir(dirpath, test_dir=TEST_DIR):
"""
Globs for files ending in ``.raw`` and generates YAML files based on TextFSM ouptut.
Every file in ``dirpath`` ending in ``.raw`` will be parsed with TextFSM and written
to a YAML file following the yamllint config standards. Since this is using glob, the
directory string passed in can also include glob syntax.
Args:
dirpath (str): The path to search for files with ``.raw`` extension.
Returns:
None: File I/O is performed to ensure YAML files exist for each test output file.
Example:
>>> dirpath = "tests/cisco_ios/show_mac-address-table"
>>> build_parsed_data_from_dir(dirpath) # doctest: +SKIP
# Each filename is printed to the terminal
>>>
"""
for file in glob.iglob(f"{dirpath}/*.raw"):
print(file)
build_parsed_data_from_output(file, test_dir)
@pytest.fixture(scope="module")
def yaml_comments_file():
"""Yaml comments tests."""
with open("tests/mocks/load/yaml_comments.yml", encoding="utf-8") as file_handler:
return YAML_OBJECT.load(file_handler)
@pytest.fixture
def copy_yaml_comments(yaml_comments_file):
"""Helper to copy yaml comments."""
return deepcopy(yaml_comments_file)
@pytest.fixture
def teardown_normalize_file():
"""Test fixture to normalize a file."""
filepaths = {}
def _teardown_normalize_file(filepath):
with open(filepath, encoding="utf-8") as file_handler:
contents = file_handler.read()
filepaths[filepath] = contents
yield _teardown_normalize_file
for filepath, contents in filepaths.items():
with open(filepath, "w", encoding="utf-8") as file_handler:
file_handler.write(contents)
@pytest.fixture(scope="module")
def expected_file():
"""Test fixture to find the expected yaml file."""
expected_path = "tests/mocks/expected/parsed_sample.yml"
with open(expected_path, encoding="utf-8") as file_handler:
return file_handler.read()
@pytest.fixture(scope="module")
def expected_mac_file():
"""Test fixture to find the expected mac yaml file."""
expected_path = "tests/mocks/expected/show_mac.yml"
with open(expected_path, encoding="utf-8") as file_handler:
return file_handler.read()
@pytest.fixture
def teardown_delete_file():
"""Test fixture to delete a file."""
filepaths = []
def _teardown_delete_file(filepath):
filepaths.append(filepath)
yield _teardown_delete_file
for file in filepaths:
os.remove(file)
def test_ensure_spacing_for_multiline_comment():
remark = "comment 11\n# comment 12\n#comment 13\n"
remark_formatted = ensure_spacing_for_multiline_comment(remark)
assert remark_formatted == "comment 11\n# comment 12\n# comment 13"
def test_ensure_space_after_octothorpe(copy_yaml_comments):
comment = copy_yaml_comments.ca.items["b"][2]
ensure_space_after_octothorpe(comment)
assert comment.value == "# comment 2\n# comment 3\n"
def test_ensure_space_comments(copy_yaml_comments):
comments = copy_yaml_comments.ca.items
comment_values = comments.values()
ensure_space_comments(comment_values)
assert comments["a"][2].value == "# comment 1\n"
assert comments["b"][2].value == "# comment 2\n# comment 3\n"
assert comments["d"][3][0].value == "# comment 7\n"
def test_update_yaml_comments(copy_yaml_comments):
update_yaml_comments(copy_yaml_comments)
string_yaml = StringIO()
YAML_OBJECT.dump(copy_yaml_comments, string_yaml)
actual = string_yaml.getvalue()
with open("tests/mocks/expected/yaml_comments.yml", encoding="utf-8") as file_handler:
expected = file_handler.read()
assert actual == expected
def test_transform_file(teardown_normalize_file, expected_file):
load_file = "tests/mocks/load/parsed_sample.yml"
teardown_normalize_file(load_file)
transform_file(load_file)
with open(load_file, encoding="utf-8") as actual:
assert actual.read() == expected_file
def test_transform_glob(teardown_normalize_file, expected_file):
glob_dir = "tests/mocks/load/gl*"
parsed_files = glob.glob(f"{glob_dir}/*.yml")
for file in parsed_files:
teardown_normalize_file(file)
transform_glob(glob_dir)
for file in parsed_files:
with open(file, encoding="utf-8") as actual:
assert actual.read() == expected_file
def test_ensure_yaml_standards(teardown_normalize_file, expected_file):
load_file = "tests/mocks/load/parsed_sample.yml"
teardown_normalize_file(load_file)
with open(load_file, encoding="utf-8") as file_handler:
load_yaml = YAML_OBJECT.load(file_handler)
ensure_yaml_standards(load_yaml, load_file)
with open(load_file, encoding="utf-8") as actual:
assert actual.read() == expected_file
def test_parse_test_filepath():
filepath = "tests/cisco_ios/show_version/cisco_ios_show_version.raw"
platform, command, filename = parse_test_filepath(filepath)
assert platform == "cisco_ios"
assert command == "show version"
assert filename == "cisco_ios_show_version"
def test_build_parsed_data_from_output(teardown_delete_file, expected_mac_file):
load_file = "tests/mocks/cisco_ios/show_mac-address-table/show_mac1.raw"
yaml_file = f"{load_file[:-3]}yml"
teardown_delete_file(yaml_file)
build_parsed_data_from_output(load_file, test_dir="tests/mocks")
with open(yaml_file, encoding="utf-8") as actual:
assert actual.read() == expected_mac_file
def test_build_parsed_data_from_dir(teardown_delete_file, expected_mac_file):
glob_dir = "tests/mocks/cisco_ios/show_mac-*"
command_files = glob.iglob(f"{glob_dir}/*.raw")
parsed_files = [f"{file[:-3]}yml" for file in command_files]
for file in parsed_files:
teardown_delete_file(file)
build_parsed_data_from_dir(glob_dir, test_dir="tests/mocks")
for file in parsed_files:
with open(file, encoding="utf-8") as actual:
assert actual.read() == expected_mac_file
|