1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
|
# Copyright 2015 Hewlett-Packard Development Company, L.P.
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License. You may obtain
# a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
from unittest import mock
import testtools
from proliantutils import exception
from proliantutils.hpssa import disk_allocator
from proliantutils.hpssa import objects
from proliantutils.tests.hpssa import raid_constants
@mock.patch.object(objects.Server, '_get_all_details')
class DiskAllocatorTestCase(testtools.TestCase):
def test__get_criteria_matching_disks_all_criterias(self,
get_all_details_mock):
get_all_details_mock.return_value = raid_constants.HPSSA_ONE_DRIVE
server = objects.Server()
physical_drives = server.controllers[0].unassigned_physical_drives
logical_disk = {'size_gb': 100,
'raid_level': '1',
'disk_type': 'hdd',
'interface_type': 'sas',
'model': 'HP EF0600FARNA',
'firmware': 'HPD6'}
ret_physical_drives = disk_allocator._get_criteria_matching_disks(
logical_disk, physical_drives)
self.assertEqual(ret_physical_drives, physical_drives)
def test__get_criteria_matching_disks_not_all_criterias(
self, get_all_details_mock):
get_all_details_mock.return_value = raid_constants.HPSSA_ONE_DRIVE
server = objects.Server()
physical_drives = server.controllers[0].unassigned_physical_drives
logical_disk = {'size_gb': 100,
'raid_level': '1',
'disk_type': 'hdd',
'interface_type': 'sas',
'firmware': 'HPD6'}
ret_physical_drives = disk_allocator._get_criteria_matching_disks(
logical_disk, physical_drives)
self.assertEqual(ret_physical_drives, physical_drives)
def test__get_criteria_matching_disks_some_disks_dont_match(
self, get_all_details_mock):
get_all_details_mock.return_value = raid_constants.HPSSA_ONE_DRIVE
server = objects.Server()
physical_drives = server.controllers[0].unassigned_physical_drives
logical_disk = {'size_gb': 100,
'raid_level': '1',
'disk_type': 'hdd',
'interface_type': 'sas',
'firmware': 'HPD6'}
physical_drives[0].disk_type = 'ssd'
physical_drives[1].firmware = 'HPD7'
ret_physical_drives = disk_allocator._get_criteria_matching_disks(
logical_disk, physical_drives)
exp_physical_drives = physical_drives[2:]
self.assertEqual(exp_physical_drives, ret_physical_drives)
def test__get_criteria_matching_disks_no_disks_match(
self, get_all_details_mock):
get_all_details_mock.return_value = raid_constants.HPSSA_ONE_DRIVE
server = objects.Server()
physical_drives = server.controllers[0].unassigned_physical_drives
logical_disk = {'size_gb': 100,
'raid_level': '1',
'disk_type': 'ssdd',
'interface_type': 'sas',
'firmware': 'HPD6'}
ret_physical_drives = disk_allocator._get_criteria_matching_disks(
logical_disk, physical_drives)
self.assertFalse(ret_physical_drives)
def test_allocate_disks_okay(self, get_all_details_mock):
get_all_details_mock.return_value = raid_constants.HPSSA_ONE_DRIVE
server = objects.Server()
logical_disk = {'size_gb': 100,
'raid_level': '1',
'disk_type': 'hdd',
'interface_type': 'sas'}
# Decrease size of two disks so that they get selected.
disk1 = server.controllers[0].get_physical_drive_by_id('5I:1:3')
disk2 = server.controllers[0].get_physical_drive_by_id('6I:1:7')
disk1.size_gb = 300
disk2.size_gb = 300
raid_config = {'logical_disks': [logical_disk]}
disk_allocator.allocate_disks(logical_disk, server, raid_config)
self.assertEqual('Smart Array P822 in Slot 2',
logical_disk['controller'])
self.assertEqual(sorted(['5I:1:3', '6I:1:7']),
sorted(logical_disk['physical_disks']))
def test_allocate_disks_max_okay(self, get_all_details_mock):
get_all_details_mock.return_value = raid_constants.HPSSA_ONE_DRIVE
server = objects.Server()
logical_disk = {'size_gb': 'MAX',
'raid_level': '1',
'disk_type': 'hdd',
'interface_type': 'sas'}
# Decrease size of three disks so that the remaining gets
# selected.
disk1 = server.controllers[0].get_physical_drive_by_id('5I:1:3')
disk2 = server.controllers[0].get_physical_drive_by_id('6I:1:7')
disk3 = server.controllers[0].get_physical_drive_by_id('5I:1:4')
disk1.size_gb = 300
disk2.size_gb = 300
disk3.size_gb = 300
raid_config = {'logical_disks': [logical_disk]}
disk_allocator.allocate_disks(logical_disk, server, raid_config)
self.assertEqual('Smart Array P822 in Slot 2',
logical_disk['controller'])
self.assertEqual(sorted(['6I:1:5', '6I:1:6']),
sorted(logical_disk['physical_disks']))
def test_allocate_disks_disk_size_not_matching(self,
get_all_details_mock):
get_all_details_mock.return_value = raid_constants.HPSSA_ONE_DRIVE
server = objects.Server()
logical_disk = {'size_gb': 700,
'raid_level': '1',
'disk_type': 'hdd',
'interface_type': 'sas'}
raid_config = {'logical_disks': [logical_disk]}
exc = self.assertRaises(exception.PhysicalDisksNotFoundError,
disk_allocator.allocate_disks,
logical_disk, server, raid_config)
self.assertIn("of size 700 GB and raid level 1", str(exc))
def test_allocate_disks_disk_not_enough_disks(self,
get_all_details_mock):
get_all_details_mock.return_value = raid_constants.HPSSA_ONE_DRIVE
server = objects.Server()
physical_drives = server.controllers[0].unassigned_physical_drives
physical_drives = physical_drives[:2]
server.controllers[0].unassigned_physical_drives = physical_drives
logical_disk = {'size_gb': 600,
'raid_level': '5',
'disk_type': 'hdd',
'interface_type': 'sas'}
raid_config = {'logical_disks': [logical_disk]}
exc = self.assertRaises(exception.PhysicalDisksNotFoundError,
disk_allocator.allocate_disks,
logical_disk, server, raid_config)
self.assertIn("of size 600 GB and raid level 5", str(exc))
@mock.patch.object(objects.Controller, 'execute_cmd')
def test_allocate_disks_share_physical_disks(self, execute_mock,
get_all_details_mock):
get_all_details_mock.return_value = raid_constants.ONE_DRIVE_RAID_1
execute_mock.return_value = (
raid_constants.DRIVE_2_RAID_1_OKAY_TO_SHARE, None)
rdh = {'wwn': '0x600508b1001c02bd'}
controller = 'Smart Array P822 in Slot 2'
physical_disks = ['5I:1:1', '5I:1:2']
raid_config = {'logical_disks': [{'size_gb': 50,
'raid_level': '1',
'share_physical_disks': True,
'root_device_hint': rdh,
'controller': controller,
'physical_disks': physical_disks},
{'size_gb': 50,
'raid_level': '1',
'share_physical_disks': True}]}
logical_disk = raid_config['logical_disks'][1]
server = objects.Server()
disk_allocator.allocate_disks(logical_disk, server, raid_config)
self.assertEqual(controller, logical_disk['controller'])
self.assertEqual('A', logical_disk['array'])
self.assertNotIn('physical_disks', logical_disk)
@mock.patch.object(objects.Controller, 'execute_cmd')
def test_allocate_disks_share_physical_disks_no_space(
self, execute_mock, get_all_details_mock):
get_all_details_mock.return_value = raid_constants.ONE_DRIVE_RAID_1
execute_mock.return_value = (
raid_constants.DRIVE_2_RAID_1_OKAY_TO_SHARE, None)
rdh = {'wwn': '0x600508b1001c02bd'}
controller = 'Smart Array P822 in Slot 2'
physical_disks = ['5I:1:1', '5I:1:2']
raid_config = {'logical_disks': [{'size_gb': 50,
'raid_level': '1',
'share_physical_disks': True,
'root_device_hint': rdh,
'controller': controller,
'physical_disks': physical_disks},
{'size_gb': 600,
'raid_level': '1',
'share_physical_disks': True}]}
logical_disk = raid_config['logical_disks'][1]
server = objects.Server()
self.assertRaises(exception.PhysicalDisksNotFoundError,
disk_allocator.allocate_disks,
logical_disk, server, raid_config)
def test_allocate_disks_share_physical_disks_criteria_mismatch(
self, get_all_details_mock):
# Both the drives don't have firmware HPD6
get_all_details_mock.return_value = raid_constants.ONE_DRIVE_RAID_1
rdh = {'wwn': '0x600508b1001c02bd'}
controller = 'Smart Array P822 in Slot 2'
physical_disks = ['5I:1:1', '5I:1:2']
raid_config = {'logical_disks': [{'size_gb': 50,
'raid_level': '1',
'share_physical_disks': True,
'root_device_hint': rdh,
'controller': controller,
'physical_disks': physical_disks},
{'size_gb': 50,
'raid_level': '1',
'firmware': 'HPD6',
'share_physical_disks': True}]}
logical_disk = raid_config['logical_disks'][1]
server = objects.Server()
self.assertRaises(exception.PhysicalDisksNotFoundError,
disk_allocator.allocate_disks,
logical_disk, server, raid_config)
|
