1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365
|
"""
Copyright (c) 2023 Proton AG
This file is part of Proton VPN.
Proton VPN is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.
Proton VPN is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with ProtonVPN. If not, see <https://www.gnu.org/licenses/>.
"""
from typing import Type
from unittest.mock import Mock, call, AsyncMock
import pytest
from proton.vpn.connection import states, events
from proton.vpn.connection.enum import KillSwitchSetting
from proton.vpn.connection.exceptions import ConcurrentConnectionsError
def test_state_subclass_raises_exception_when_missing_state():
class DummyState(states.State):
pass
with pytest.raises(TypeError):
DummyState(states.StateContext())
def test_state_on_event_logs_warning_when_event_did_not_cause_state_transition(caplog):
class DummyState(states.State):
type = Mock()
def _on_event(self, event: events.Event) -> states.State:
return self
state = DummyState(states.StateContext())
new_state = state.on_event(events.Up(events.EventContext(connection=Mock())))
assert new_state is state
warnings = [record for record in caplog.records if record.levelname == "WARNING"]
assert len(warnings) == 1
assert "state received unexpected event" in warnings[0].message
@pytest.mark.parametrize(
"event_type, concurrent_connections_error_expected", [
(event_type, event_type != events.Up) for event_type in events.EVENT_TYPES
]
)
def test_state_on_event_raises_concurrent_connections_error_when_multiple_connections_are_detected(
event_type, concurrent_connections_error_expected
):
"""
All state instance raise an exception if they receive an event carrying a connection that's not
the same as the one the state instance already has on its context. The reason for this is that
the current state should be receiving state updates from the same connection that led to this
state.
The exception to this rule is the Up event, since the goal of the Up event is to start a new
connection.
"""
# In this case, the concrete state instance doesn't matter, since this check is done in
# the base State class.
state = states.Connected(states.StateContext(connection=Mock()))
event = event_type(events.EventContext(connection=Mock()))
try:
state.on_event(event)
error_raised = False
except ConcurrentConnectionsError:
error_raised = True
assert error_raised is concurrent_connections_error_expected
def assert_state_transition(
state_type: Type[states.State],
event_type: Type[events.Event],
expected_next_state_type: Type[states.State]
):
"""Asserts that when calling the `on_event` method on an instance of `state_type` passing it
an instance of `event_type` then the result is an instance of `expected_next_state_type`."""
connection = Mock()
state = state_type(states.StateContext(connection=connection))
event = event_type(events.EventContext(connection=connection))
next_state = state.on_event(event)
assert isinstance(next_state, expected_next_state_type)
if next_state is not state:
# The new state should keep the event that led to it in its context.
assert next_state.context.event is event
@pytest.mark.parametrize("state_type, event_type, expected_next_state_type", [
(states.Disconnected, events.Up, states.Connecting),
(states.Connecting, events.Connected, states.Connected),
(states.Connected, events.Down, states.Disconnecting),
(states.Disconnecting, events.Disconnected, states.Disconnected)
])
def test_happy_flow_state_transitions(state_type, event_type, expected_next_state_type):
"""
{DISCONNECTED} --Up--> {CONNECTING} --Connected--> {CONNECTED}
--Down--> {DISCONNECTING} --Disconnected--> {DISCONNECTED}
"""
assert_state_transition(state_type, event_type, expected_next_state_type)
@pytest.mark.parametrize("event_type, expected_next_state_type", [
(events.Up, states.Connecting),
(events.Down, states.Disconnected),
(events.Disconnected, states.Disconnected),
(events.Connected, states. Disconnected), # Invalid event.
(events.UnexpectedError, states.Disconnected) # Invalid event.
])
def test_disconnected_on_event_transitions(event_type, expected_next_state_type):
assert_state_transition(states.Disconnected, event_type, expected_next_state_type)
@pytest.mark.parametrize("event_type, expected_next_state_type", [
(events.Connected, states.Connected),
(events.Down, states.Disconnecting),
(events.UnexpectedError, states.Error),
(events.Up, states.Disconnecting), # Reconnection.
(events.Disconnected, states.Disconnected)
])
def test_connecting_on_event_transitions(event_type, expected_next_state_type):
assert_state_transition(states.Connecting, event_type, expected_next_state_type)
@pytest.mark.parametrize("event_type, expected_next_state_type", [
(events.Down, states.Disconnecting),
(events.Up, states.Disconnecting), # Reconnection.
(events.UnexpectedError, states.Error),
(events.Disconnected, states.Disconnected),
(events.Connected, states.Connected)
])
def test_connected_on_event_transitions(event_type, expected_next_state_type):
assert_state_transition(states.Connected, event_type, expected_next_state_type)
@pytest.mark.parametrize("event_type, expected_next_state_type", [
(events.Disconnected, states.Disconnected),
(events.Up, states.Disconnecting), # Reconnection.
(events.Down, states.Disconnecting),
(events.UnexpectedError, states.Disconnected), # Errors events also signal VPN disconnection
(events.Connected, states.Disconnecting) # Invalid event.
])
def test_disconnecting_on_event_transitions(event_type, expected_next_state_type):
assert_state_transition(states.Disconnecting, event_type, expected_next_state_type)
@pytest.mark.parametrize("event_type, expected_next_state_type", [
(events.Down, states.Disconnected),
(events.Up, states.Disconnecting),
(events.UnexpectedError, states.Error),
(events.Connected, states.Connected),
(events.Disconnected, states.Error) # Invalid event.
])
def test_error_on_event_transitions(event_type, expected_next_state_type):
assert_state_transition(states.Error, event_type, expected_next_state_type)
@pytest.mark.parametrize("active_state_type", [
states.Connecting, states.Connected, states.Disconnecting, states.Error
])
def test_reconnection_is_triggered_when_up_event_is_received_while_a_connection_is_active(
active_state_type
):
"""
A connection is active while in Connecting, Connected and Disconnecting
states. When one of these states receives an Up event then a reconnection
will be triggered. That means that, the current state will transition to
Disconnecting state (to start disconnection) while keeping the new connection
to be started (carried by the Up event) once the Disconnected state is reached.
"""
active_state = active_state_type(states.StateContext(connection=Mock()))
up = events.Up(events.EventContext(connection=Mock()))
disconnecting = active_state.on_event(up)
assert isinstance(disconnecting, states.Disconnecting)
# The connection to disconnect from is the same we were connecting to.
assert disconnecting.context.connection is active_state.context.connection
# The connection that we want to reconnect to is the one carried by the up event.
assert disconnecting.context.reconnection is up.context.connection
@pytest.mark.asyncio
async def test_disconnected_run_tasks_when_reconnection_is_not_requested_and_kill_switch_is_not_permanent():
"""
When reconnection is not requested and the kill switch is not set to permanent,
the disconnected state should run the following tasks:
- Remove persisted connection parameters.
- Disable kill switch.
- Disable IPv6 leak protection.
"""
context = Mock()
context.reconnection = None # Reconnection not requested
context.kill_switch_setting = KillSwitchSetting.ON
context.kill_switch.disable_ipv6_leak_protection = AsyncMock(return_value=None)
context.kill_switch.disable = AsyncMock(return_value=None)
context.connection.remove_persistence = AsyncMock(return_value=None)
disconnected = states.Disconnected(context=context)
generated_event = await disconnected.run_tasks()
assert context.method_calls == [
call.connection.remove_persistence(),
call.kill_switch.disable(),
call.kill_switch.disable_ipv6_leak_protection()
]
assert generated_event is None
@pytest.mark.asyncio
async def test_disconnected_run_tasks_does_not_disable_the_kill_switch_when_set_to_permanent():
"""
When the kill switch is not set to permanent, the disconnected state should
**not** disable the kill switch.
"""
context = AsyncMock()
context.reconnection = None # Reconnection not requested
context.kill_switch_setting = KillSwitchSetting.PERMANENT
context.connection.remove_persistence = AsyncMock(return_value=None)
disconnected = states.Disconnected(context=context)
generated_event = await disconnected.run_tasks()
assert context.method_calls == [
call.connection.remove_persistence(),
call.kill_switch.enable(permanent=True)
]
assert generated_event is None
@pytest.mark.asyncio
async def test_disconnected_run_tasks_when_reconnection_is_requested_and_should_return_up_event():
"""
When reconnection **is** requested while on the disconnected state then:
- No connection tasks should be performed. It's very important that
IPv6 leak protection or the kill switch are **not** disabled.
- An Up event should be returned with the new connection to be started.
"""
context = AsyncMock()
context.reconnection = Mock()
disconnected = states.Disconnected(context=context)
generated_event = await disconnected.run_tasks()
assert context.method_calls == [
call.connection.remove_persistence(),
call.kill_switch.enable() # Kill switch is enabled to avoid leaks when switching servers.
]
assert isinstance(generated_event, events.Up)
assert generated_event.context.connection is context.reconnection
@pytest.mark.asyncio
async def test_disconnected_run_tasks_when_there_is_no_connection():
"""
When there is no current connection and reconnection was not requested,
the disconnect state should run the following taks:
- disable the kill switch
- disable IPv6 leak protection.
"""
context = AsyncMock()
context.connection = None
context.reconnection = None
disconnected = states.Disconnected(context=context)
generated_event = await disconnected.run_tasks()
assert context.method_calls == [
call.kill_switch.disable(),
call.kill_switch.disable_ipv6_leak_protection()
]
assert generated_event is None
@pytest.mark.asyncio
@pytest.mark.parametrize(
"kill_switch_setting", [KillSwitchSetting.ON, KillSwitchSetting.PERMANENT, KillSwitchSetting.OFF]
)
async def test_connecting_run_tasks(kill_switch_setting):
"""
The connecting state tasks are the following ones, in the specified order:
1. Enable IPv6 leak protection.
2. Enable kill switch if it's set to be enabled.
3. Start the connection.
It's very important that IPv6 leak protection (and kill switch) is enabled
before starting the connection.
"""
context = AsyncMock()
context.kill_switch_setting = kill_switch_setting
connecting = states.Connecting(context=context)
await connecting.run_tasks()
permanent_ks = kill_switch_setting == KillSwitchSetting.PERMANENT
assert context.method_calls == [
call.kill_switch.enable(context.connection.server, permanent=permanent_ks),
call.connection.start()
]
@pytest.mark.asyncio
@pytest.mark.parametrize(
"kill_switch_setting", [KillSwitchSetting.ON, KillSwitchSetting.PERMANENT, KillSwitchSetting.OFF]
)
async def test_connected_run_tasks(kill_switch_setting):
"""The tasks to be run while on the connected state is to persist the connection parameters and
enable kill switch if it's set to be enabled."""
context = AsyncMock()
context.kill_switch_setting = kill_switch_setting
connected = states.Connected(context)
await connected.run_tasks()
if kill_switch_setting == KillSwitchSetting.ON:
assert context.method_calls == [
call.kill_switch.enable(permanent=False),
call.connection.add_persistence()
]
elif kill_switch_setting == KillSwitchSetting.PERMANENT:
assert context.method_calls == [
call.kill_switch.enable(permanent=True),
call.connection.add_persistence()
]
else: # Kill switch OFF.
assert context.method_calls == [
call.kill_switch.enable_ipv6_leak_protection(),
call.kill_switch.disable(),
call.connection.add_persistence()
]
@pytest.mark.asyncio
async def test_disconnecting_run_tasks_stops_connection():
"""The only task be run while on the disconnecting state is to stop the connection."""
connection = Mock()
connection.stop = AsyncMock(return_value=None)
disconnecting = states.Disconnecting(states.StateContext(connection=connection))
await disconnecting.run_tasks()
connection_calls = connection.method_calls
assert len(connection_calls) == 1
connection_calls[0].method = connection.stop
|