1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
|
# Copyright 2015 IBM Corp.
#
# All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License. You may obtain
# a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
import mock
import unittest
from pypowervm.tasks.hdisk import _fc as fc
import pypowervm.tests.tasks.util as tju
VIOS_FEED = 'fake_vios_feed.txt'
class TestFC(unittest.TestCase):
def setUp(self):
super(TestFC, self).setUp()
def test_itl(self):
"""Tests the ITL class."""
itl = fc.ITL('AABBCCDDEEFF0011', '00:11:22:33:44:55:66:EE', 238)
self.assertEqual('aabbccddeeff0011', itl.initiator)
self.assertEqual('00112233445566ee', itl.target)
self.assertEqual('ee000000000000', itl.lun)
# Test Lun-ID length for max 8 bytes
itl = fc.ITL('AABBC11', '00:11:22:33:44:55:66:EE', 1074872357)
self.assertEqual('4011402500000000', itl.lun)
self.assertEqual(16, len(itl.lun))
def test_build_itls(self):
"""Tests that the ITL combinations can be built out."""
i_wwpns = ['0011223344556677', '0011223344556678']
t_wwpns = ['1111223344556677', '1111223344556678', '1111223344556679']
all_itls = fc.build_itls(i_wwpns, t_wwpns, 238)
self.assertEqual(6, len(all_itls))
combos = [fc.ITL(i_wwpns[0], t_wwpns[0], 238),
fc.ITL(i_wwpns[0], t_wwpns[1], 238),
fc.ITL(i_wwpns[0], t_wwpns[2], 238),
fc.ITL(i_wwpns[1], t_wwpns[0], 238),
fc.ITL(i_wwpns[1], t_wwpns[1], 238),
fc.ITL(i_wwpns[1], t_wwpns[2], 238)]
self.assertListEqual(combos, all_itls)
def test_lua_recovery_xml(self):
"""Validates that the LUA recovery XML is build properly."""
i_wwpns = ['0011223344556677', '0011223344556678']
t_wwpns = ['1111223344556677', '1111223344556678', '1111223344556679']
all_itls = fc.build_itls(i_wwpns, t_wwpns, 238)
lua_xml = ('<XML_LIST><general><cmd_version>3</cmd_version><version>'
'2.0</version></general><reliableITL>false</reliableITL>'
'<deviceList><device><vendor>OTHER</vendor><deviceTag>'
'1</deviceTag><itlList><number>6</number><itl>'
'<Iwwpn>0011223344556677</Iwwpn><Twwpn>1111223344556677'
'</Twwpn><lua>ee000000000000</lua></itl><itl><Iwwpn>'
'0011223344556677</Iwwpn><Twwpn>1111223344556678</Twwpn>'
'<lua>ee000000000000</lua></itl><itl><Iwwpn>'
'0011223344556677</Iwwpn><Twwpn>1111223344556679</Twwpn>'
'<lua>ee000000000000</lua></itl><itl><Iwwpn>'
'0011223344556678</Iwwpn><Twwpn>1111223344556677</Twwpn>'
'<lua>ee000000000000</lua></itl><itl><Iwwpn>'
'0011223344556678</Iwwpn><Twwpn>1111223344556678</Twwpn>'
'<lua>ee000000000000</lua></itl><itl><Iwwpn>'
'0011223344556678</Iwwpn><Twwpn>1111223344556679</Twwpn>'
'<lua>ee000000000000</lua></itl></itlList></device>'
'</deviceList></XML_LIST>')
self.assertEqual(lua_xml, fc._lua_recovery_xml(all_itls, None))
def test_process_lua_result_no_resp(self):
result = {}
status, dev_name, udid = fc._process_lua_result(result)
self.assertIsNone(status)
self.assertIsNone(dev_name)
self.assertIsNone(udid)
def test_process_lua_result_terse_resp(self):
"""Tests where valid XML is returned, but no device."""
xml = ('<luaResult><version>2.0</version><deviceList></deviceList>'
'</luaResult>')
result = {'StdOut': xml}
status, dev_name, udid = fc._process_lua_result(result)
self.assertIsNone(status)
self.assertIsNone(dev_name)
self.assertIsNone(udid)
def test_process_lua_result(self):
xml = ('<luaResult><version>2.0</version><deviceList><device>'
'<deviceTag>21</deviceTag><status>8</status><msg><msgLen>9'
'</msgLen><msgText>test text</msgText></msg><pvName>hdisk10'
'</pvName><uniqueID>fake_uid</uniqueID><udid>fake_udid'
'</udid></device></deviceList></luaResult>')
result = {'StdOut': xml}
status, dev_name, udid = fc._process_lua_result(result)
self.assertEqual('8', status)
self.assertEqual('hdisk10', dev_name)
self.assertEqual('fake_udid', udid)
# Repeat with the input as the resultXML
result = {'OutputXML': xml}
status, dev_name, udid = fc._process_lua_result(result)
self.assertEqual('8', status)
self.assertEqual('hdisk10', dev_name)
self.assertEqual('fake_udid', udid)
@mock.patch('pypowervm.tasks.hdisk._fc.LOG')
def test_validate_lua_status(self, mock_log):
"""This tests the branches of validate_lua_status."""
fc._log_lua_status(fc.LUAStatus.DEVICE_AVAILABLE, 'dev_name',
'message')
self.assertEqual(1, mock_log.info.call_count)
fc._log_lua_status(fc.LUAStatus.FOUND_ITL_ERR, 'dev_name', 'message')
self.assertEqual(1, mock_log.warning.call_count)
fc._log_lua_status(fc.LUAStatus.DEVICE_IN_USE, 'dev_name', 'message')
self.assertEqual(2, mock_log.warning.call_count)
fc._log_lua_status(fc.LUAStatus.FOUND_DEVICE_UNKNOWN_UDID, 'dev_name',
'message')
self.assertEqual(3, mock_log.warning.call_count)
fc._log_lua_status(fc.LUAStatus.INCORRECT_ITL, 'dev_name', 'message')
self.assertEqual(4, mock_log.warning.call_count)
@mock.patch('pypowervm.tasks.hdisk._fc._process_lua_result')
@mock.patch('pypowervm.wrappers.job.Job', new=mock.Mock())
@mock.patch('pypowervm.adapter.Adapter')
def test_lua_recovery(self, mock_adapter, mock_lua_result):
itls = [fc.ITL('AABBCCDDEEFF0011', '00:11:22:33:44:55:66:EE', 238)]
mock_lua_result.return_value = ('OK', 'hdisk1', 'udid')
status, devname, udid = fc.lua_recovery(mock_adapter, 'vios_uuid',
itls)
# Validate value unpack
self.assertEqual('OK', status)
self.assertEqual('hdisk1', devname)
self.assertEqual('udid', udid)
# Validate method invocations
self.assertEqual(1, mock_adapter.read.call_count)
self.assertEqual(1, mock_lua_result.call_count)
@mock.patch('pypowervm.tasks.hdisk._fc._lua_recovery_xml')
@mock.patch('pypowervm.tasks.hdisk._fc._process_lua_result')
@mock.patch('pypowervm.wrappers.job.Job', new=mock.Mock())
@mock.patch('pypowervm.adapter.Adapter')
def test_lua_recovery_dupe_itls(self, mock_adapter, mock_lua_result,
mock_lua_xml):
itls = [fc.ITL('AABBCCDDEEFF0011', '00:11:22:33:44:55:66:EE', 238),
fc.ITL('AABBCCDDEEFF0011', '00:11:22:33:44:55:66:EE', 238)]
mock_lua_result.return_value = ('OK', 'hdisk1', 'udid')
status, devname, udid = fc.lua_recovery(mock_adapter, 'vios_uuid',
itls)
# Validate value unpack
self.assertEqual('OK', status)
self.assertEqual('hdisk1', devname)
self.assertEqual('udid', udid)
# Validate method invocations
self.assertEqual(1, mock_adapter.read.call_count)
self.assertEqual(1, mock_lua_result.call_count)
mock_lua_xml.assert_called_with({itls[0]}, mock_adapter,
vendor='OTHER')
@mock.patch('pypowervm.tasks.hdisk._fc.lua_recovery')
@mock.patch('pypowervm.utils.transaction.FeedTask')
@mock.patch('pypowervm.tasks.storage.add_lpar_storage_scrub_tasks')
@mock.patch('pypowervm.tasks.storage.find_stale_lpars')
@mock.patch('pypowervm.wrappers.entry_wrapper.EntryWrapper.get',
new=mock.Mock())
def test_discover_hdisk(self, mock_fsl, mock_alsst, mock_ftsk, mock_luar):
def set_luar_side_effect(_stat, _dev):
"""Set up the lua_recovery mock's side effect.
The second return will always be the same - used to verify that we
really called twice when appropriate.
The first return will be (_stat, _dev, "udid"), per the params.
"""
mock_luar.reset_mock()
mock_luar.side_effect = [(_stat, _dev, 'udid'),
('ok_s', 'ok_h', 'ok_u')]
stale_lpar_ids = [12, 34]
# All of these should cause a scrub-and-retry
retry_rets = [(None, None), (fc.LUAStatus.DEVICE_AVAILABLE, None),
(fc.LUAStatus.FOUND_DEVICE_UNKNOWN_UDID, 'hdisk456')]
# These should *not* cause a scrub-and-retry
no_retry_rets = [(fc.LUAStatus.DEVICE_AVAILABLE, 'hdisk456'),
(fc.LUAStatus.FOUND_ITL_ERR, 'hdisk456'),
(fc.LUAStatus.DEVICE_IN_USE, 'hdisk456')]
mock_fsl.return_value = stale_lpar_ids
for st, dev in retry_rets:
set_luar_side_effect(st, dev)
self.assertEqual(
('ok_s', 'ok_h', 'ok_u'), fc.discover_hdisk(
'adp', 'vuuid', ['itls']))
self.assertEqual(1, mock_fsl.call_count)
mock_ftsk.assert_called_with('scrub_vios_vuuid', mock.ANY)
self.assertEqual(1, mock_alsst.call_count)
mock_luar.assert_has_calls(
[mock.call('adp', 'vuuid', ['itls'],
vendor=fc.LUAType.OTHER)] * 2)
mock_fsl.reset_mock()
mock_alsst.reset_mock()
mock_ftsk.reset_mock()
for st, dev in no_retry_rets:
set_luar_side_effect(st, dev)
self.assertEqual(
(st, dev, 'udid'), fc.discover_hdisk(
'adp', 'vuuid', ['itls']))
self.assertEqual(0, mock_fsl.call_count)
self.assertEqual(0, mock_ftsk.call_count)
self.assertEqual(0, mock_alsst.call_count)
self.assertEqual(1, mock_luar.call_count)
mock_luar.assert_called_with('adp', 'vuuid', ['itls'],
vendor=fc.LUAType.OTHER)
# If no stale LPARs found, scrub-and-retry should not be triggered with
# either set.
mock_fsl.return_value = []
for st, dev in retry_rets + no_retry_rets:
set_luar_side_effect(st, dev)
self.assertEqual(
(st, dev, 'udid'), fc.discover_hdisk(
'adp', 'vuuid', ['itls']))
# find_stale_lpars will be called for retry_rets, but not for
# no_retry_rets
self.assertLessEqual(mock_fsl.call_count, 1)
self.assertEqual(0, mock_ftsk.call_count)
self.assertEqual(0, mock_alsst.call_count)
self.assertEqual(1, mock_luar.call_count)
mock_luar.assert_called_with('adp', 'vuuid', ['itls'],
vendor=fc.LUAType.OTHER)
mock_fsl.reset_mock()
@mock.patch('pypowervm.wrappers.job.Job.job_status', new=mock.Mock())
@mock.patch('pypowervm.wrappers.job.Job.run_job')
@mock.patch('pypowervm.adapter.Adapter')
def test_remove_hdisk_classic(self, mock_adapter, mock_run_job):
mock_adapter.read.return_value = (tju.load_file(VIOS_FEED)
.feed.entries[0])
fc._remove_hdisk_classic(mock_adapter, 'host_name', 'dev_name',
'vios_uuid')
# Validate method invocations
self.assertEqual(2, mock_adapter.read.call_count)
self.assertEqual(1, mock_run_job.call_count)
@mock.patch('pypowervm.wrappers.job.Job.run_job')
@mock.patch('pypowervm.adapter.Adapter')
def test_remove_hdisk_job(self, mock_adapter, mock_run_job):
mock_adapter.read.return_value = (tju.load_file(VIOS_FEED)
.feed.entries[0])
def verify_run_job(vios_uuid, job_parms=None):
self.assertEqual('vios_uuid', vios_uuid)
self.assertEqual(1, len(job_parms))
job_parm = (b'<web:JobParameter xmlns:web="http://www.ibm.com/'
b'xmlns/systems/power/firmware/web/mc/2012_10/" '
b'schemaVersion="V1_0"><web:ParameterName>devName'
b'</web:ParameterName><web:ParameterValue>dev_name'
b'</web:ParameterValue></web:JobParameter>')
self.assertEqual(job_parm, job_parms[0].toxmlstring())
mock_run_job.side_effect = verify_run_job
fc._remove_hdisk_job(mock_adapter, 'dev_name', 'vios_uuid')
# Validate method invocations
self.assertEqual(1, mock_adapter.read.call_count)
self.assertEqual(1, mock_run_job.call_count)
def test_normalize_lun(self):
lun = fc.normalize_lun(12)
self.assertEqual('c000000000000', lun)
# Test when lun exceeds len 8
lun = fc.normalize_lun(1074872357)
self.assertEqual('4011402500000000', lun)
|
