1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722
|
# Copyright 2015 IBM Corp.
#
# All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License. You may obtain
# a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
import mock
import testtools
from pypowervm import adapter as adpt
import pypowervm.entities as ent
from pypowervm import exceptions as pvm_exc
from pypowervm.tasks import network_bridger as net_br
import pypowervm.tests.test_fixtures as fx
from pypowervm.tests.test_utils import pvmhttp
from pypowervm.wrappers import managed_system as pvm_ms
from pypowervm.wrappers import network as pvm_net
MGR_NET_BR_FAILOVER_FILE = 'nbbr_network_bridge_failover.txt'
MGR_NET_BR_FILE = 'nbbr_network_bridge.txt'
MGR_NET_BR_PEER_FILE = 'nbbr_network_bridge_peer.txt'
MGR_VNET_FILE = 'nbbr_virtual_network.txt'
MGR_VSW_FILE = 'nbbr_virtual_switch.txt'
ORPHAN_VIOS_FEED = 'fake_vios_feed.txt'
ORPHAN_CNA_FEED = 'cna_feed.txt'
class TestNetworkBridger(testtools.TestCase):
"""General tests for the Network Bridger superclass.
Subclasses of Network Bridgers should extend this class.
"""
def setUp(self):
super(TestNetworkBridger, self).setUp()
self.adptfx = self.useFixture(fx.AdapterFx(
traits=fx.LocalPVMTraits))
self.adpt = self.adptfx.adpt
def resp(file_name):
return pvmhttp.load_pvm_resp(
file_name, adapter=self.adpt).get_response()
self.mgr_nbr_resp = resp(MGR_NET_BR_FILE)
self.mgr_nbr_fo_resp = resp(MGR_NET_BR_FAILOVER_FILE)
self.mgr_nbr_peer_resp = resp(MGR_NET_BR_PEER_FILE)
self.mgr_vnet_resp = resp(MGR_VNET_FILE)
self.mgr_vsw_resp = resp(MGR_VSW_FILE)
self.orphan_vio_resp = resp(ORPHAN_VIOS_FEED)
self.orphan_cna_feed = resp(ORPHAN_CNA_FEED)
self.host_uuid = 'c5d782c7-44e4-3086-ad15-b16fb039d63b'
self.nb_uuid = 'b6a027a8-5c0b-3ac0-8547-b516f5ba6151'
self.nb_uuid_peer = '9af89d52-5892-11e5-885d-feff819cdc9f'
def test_ensure_vlan_on_nb(self):
"""This does a happy path test. Assumes VLAN on NB already.
No subclass invocation.
"""
self.adpt.read.return_value = self.mgr_nbr_resp
net_br.ensure_vlan_on_nb(self.adpt, self.host_uuid, self.nb_uuid, 2227)
self.assertEqual(1, self.adpt.read.call_count)
@mock.patch('pypowervm.tasks.network_bridger.NetworkBridger'
'._validate_orphan_on_ensure')
@mock.patch('pypowervm.tasks.network_bridger.NetworkBridger'
'._remove_vlan_from_nb_synch')
def test_ensure_vlan_on_nb_wrong_peer(self, mock_remove, mock_orphan):
"""Test moving vlan from one peer to another.
No subclass invocation.
"""
self.adpt.read.side_effect = [
self.mgr_nbr_peer_resp, self.mgr_vsw_resp, self.mgr_vnet_resp]
def validate_of_update_nb(*kargs, **kwargs):
# Validate args
nb = kargs[0]
self.assertEqual(self.nb_uuid, nb.uuid)
return nb.entry
self.adpt.update_by_path.side_effect = validate_of_update_nb
net_br.ensure_vlan_on_nb(self.adpt, self.host_uuid, self.nb_uuid, 1001)
mock_remove.assert_called_once_with(
self.nb_uuid_peer, 1001, fail_if_pvid=True, existing_nbs=mock.ANY)
def test_is_arbitrary_vid(self):
nbs = pvm_net.NetBridge.wrap(self.mgr_nbr_resp)
bridger = net_br.NetworkBridger(self.adpt, self.host_uuid)
self.assertTrue(bridger._is_arbitrary_vid(4094, nbs))
self.assertFalse(bridger._is_arbitrary_vid(2227, nbs))
def test_find_new_arbitrary_vid(self):
nbs = pvm_net.NetBridge.wrap(self.mgr_nbr_resp)
bridger = net_br.NetworkBridger(self.adpt, self.host_uuid)
self.assertEqual(4093, bridger._find_new_arbitrary_vid(nbs))
self.assertEqual(4092, bridger._find_new_arbitrary_vid(nbs,
others=[4093]))
def test_remove_vlan_from_nb_bad_vid(self):
"""Attempt to remove a VID that can't be taken off NB."""
# Mock Data
self.adpt.read.return_value = self.mgr_nbr_resp
# Should fail if fail_if_pvid set to True
self.assertRaises(pvm_exc.PvidOfNetworkBridgeError,
net_br.remove_vlan_from_nb, self.adpt,
self.host_uuid, self.nb_uuid, 2227, True)
# Should not fail if fail_if_pvid set to False, but shouldn't call
# update either.
net_br.remove_vlan_from_nb(self.adpt, self.host_uuid, self.nb_uuid,
'2227')
self.assertEqual(0, self.adpt.update.call_count)
def _setup_reassign_arbitrary_vid(self):
vsw_p = mock.patch('pypowervm.wrappers.network.VSwitch.search')
self.mock_vsw = vsw_p.start()
self.addCleanup(vsw_p.stop)
vnet = pvm_net.VNet._bld(self.adpt).entry
resp1 = adpt.Response('reqmethod', 'reqpath', 'status', 'reason', {})
resp1.feed = ent.Feed({}, [vnet])
self.adpt.read.return_value = resp1
self.adpt.read_by_href.return_value = vnet
nb = pvm_net.NetBridge.wrap(self.mgr_nbr_resp)[0]
resp2 = adpt.Response('reqmethod', 'reqpath', 'status', 'reason', {})
resp2.entry = nb.entry
self.adpt.update.return_value = resp2
vsw = pvm_net.VSwitch.wrap(self.mgr_vsw_resp)[0]
self.mock_vsw.return_value = vsw
return nb
def test_build_orphan_map(self):
self.adpt.read.side_effect = [self.orphan_vio_resp]
bridger = net_br.NetworkBridger(self.adpt, self.host_uuid)
orphan_map = bridger._build_orphan_map()
expected_map = {
0: {'nimbus-ch03-p2-vios2': {'ent11': [4092, 2018, 2019]}},
1: {'nimbus-ch03-p2-vios2': {'ent12': [2800, 2801]}}
}
self.assertEqual(expected_map, orphan_map)
def test_validate_orphan_on_ensure(self):
"""Tests the _validate_orphan_on_ensure method."""
self.adpt.read.side_effect = [self.orphan_vio_resp]
bridger = net_br.NetworkBridger(self.adpt, self.host_uuid)
# Test the Trunk Path - PVID and then an additional
self.assertRaises(
pvm_exc.OrphanVLANFoundOnProvision,
bridger._validate_orphan_on_ensure, 4092, 0)
self.assertRaises(
pvm_exc.OrphanVLANFoundOnProvision,
bridger._validate_orphan_on_ensure, 2018, 0)
# Different vSwitch
self.assertRaises(
pvm_exc.OrphanVLANFoundOnProvision,
bridger._validate_orphan_on_ensure, 2800, 1)
# Shouldn't fail on a good vlan
bridger._validate_orphan_on_ensure(2, 0)
bridger._validate_orphan_on_ensure(1, 0)
bridger._validate_orphan_on_ensure(4094, 1)
def test_get_orphan_vlans(self):
"""Tests the _get_orphan_vlans method."""
self.adpt.read.side_effect = [self.orphan_vio_resp]
bridger = net_br.NetworkBridger(self.adpt, self.host_uuid)
self.assertListEqual([], bridger._get_orphan_vlans(2))
self.assertListEqual([2018, 2019, 4092],
bridger._get_orphan_vlans(0))
self.assertListEqual([2800, 2801], bridger._get_orphan_vlans(1))
class TestNetworkBridgerVNet(TestNetworkBridger):
"""General tests for the network bridge super class and the VNet impl."""
def setUp(self):
super(TestNetworkBridgerVNet, self).setUp()
self.adptfx.set_traits(fx.RemoteHMCTraits)
@mock.patch('oslo_concurrency.lockutils.lock')
@mock.patch('pypowervm.tasks.network_bridger.NetworkBridger.'
'_get_orphan_vlans')
@mock.patch('pypowervm.tasks.network_bridger.NetworkBridger.'
'_validate_orphan_on_ensure')
@mock.patch('pypowervm.tasks.network_bridger.NetworkBridgerVNET.'
'_reassign_arbitrary_vid')
@mock.patch('pypowervm.wrappers.network.NetBridge.supports_vlan')
def test_ensure_vlan_on_nb_reassign(
self, mock_support_vlan, mock_reassign, mock_orphan_validate,
mock_orphans, mock_lock):
"""Validates that after update, we support the VLAN."""
# Have the response
self.adpt.read.return_value = self.mgr_nbr_resp
# First call, say that we don't support the VLAN (which is true).
# Second call, fake out that we now do.
# Works in pairs, as there are two VLANs we're working through.
mock_support_vlan.side_effect = [False, False, True, True]
mock_orphans.return_value = []
# Invoke
net_br.ensure_vlans_on_nb(self.adpt, self.host_uuid, self.nb_uuid,
[4093, 4094])
self.assertEqual(2, self.adpt.read.call_count)
self.assertEqual(1, mock_reassign.call_count)
self.assertEqual(1, mock_lock.call_count)
# Should be called re-assigning 4094 (old) to 4092. Shouldn't be
# 4093 as that is also an additional VLAN.
mock_reassign.assert_called_once_with(4094, 4092, mock.ANY)
@mock.patch('oslo_concurrency.lockutils.lock')
@mock.patch('pypowervm.tasks.network_bridger.NetworkBridger.'
'_validate_orphan_on_ensure')
@mock.patch('pypowervm.tasks.network_bridger.NetworkBridgerVNET.'
'_find_or_create_vnet')
@mock.patch('pypowervm.tasks.network_bridger.NetworkBridgerVNET.'
'_is_arbitrary_vid')
def test_ensure_vlan_on_nb_new_vlan(self, mock_arb_vid, mock_find_vnet,
mock_orphan_validate, mock_lock):
"""Validates new VLAN on existing Load Group."""
# Build the responses
self.adpt.read.side_effect = [self.mgr_nbr_resp, self.mgr_vsw_resp,
self.mgr_vnet_resp]
mock_arb_vid.return_value = False
mock_vnet = mock.MagicMock()
mock_vnet.related_href = 'fake_href'
mock_find_vnet.return_value = mock_vnet
def validate_of_update_nb(*kargs, **kwargs):
# Validate args
nb = kargs[0]
self.assertIsNotNone(nb)
self.assertEqual(1,
len(nb.load_grps[0].vnet_uri_list))
self.assertEqual(2,
len(nb.load_grps[1].vnet_uri_list))
self.assertEqual(self.nb_uuid, nb.uuid)
return nb.entry
self.adpt.update_by_path.side_effect = validate_of_update_nb
# Invoke
net_br.ensure_vlan_on_nb(self.adpt, self.host_uuid, self.nb_uuid, 2000)
# Validate the calls
self.assertEqual(1, self.adpt.update_by_path.call_count)
self.assertEqual(1, mock_lock.call_count)
@mock.patch('oslo_concurrency.lockutils.lock')
@mock.patch('pypowervm.tasks.network_bridger.NetworkBridger.'
'_validate_orphan_on_ensure')
@mock.patch('pypowervm.tasks.network_bridger.NetworkBridgerVNET.'
'_find_or_create_vnet')
@mock.patch('pypowervm.tasks.network_bridger.NetworkBridgerVNET.'
'_is_arbitrary_vid')
def test_ensure_vlans_on_nb_new_vlan(self, mock_arb_vid, mock_find_vnet,
mock_orphan_validate, mock_lock):
"""Validates new VLAN on existing Load Group."""
# Build the responses
self.adpt.read.side_effect = [self.mgr_nbr_resp, self.mgr_vsw_resp,
self.mgr_vnet_resp]
mock_arb_vid.return_value = False
mock_vnet = mock.MagicMock()
mock_vnet.related_href = 'fake_href'
mock_find_vnet.return_value = mock_vnet
def validate_of_update_nb(*kargs, **kwargs):
# Validate args
nb = kargs[0]
self.assertEqual(1, len(nb.load_grps[0].vnet_uri_list))
self.assertEqual(2, len(nb.load_grps[1].vnet_uri_list))
self.assertEqual(self.nb_uuid, nb.uuid)
return nb.entry
self.adpt.update_by_path.side_effect = validate_of_update_nb
# Invoke. VLAN 2227 should be on there already.
net_br.ensure_vlans_on_nb(self.adpt, self.host_uuid,
self.nb_uuid, [2227, 2000])
# Validate the calls
self.assertEqual(1, self.adpt.update_by_path.call_count)
self.assertEqual(1, mock_lock.call_count)
@mock.patch('oslo_concurrency.lockutils.lock')
@mock.patch('pypowervm.tasks.network_bridger.NetworkBridger.'
'_get_orphan_vlans')
@mock.patch('pypowervm.tasks.network_bridger.NetworkBridger.'
'_validate_orphan_on_ensure')
@mock.patch('pypowervm.tasks.network_bridger.NetworkBridgerVNET.'
'_find_or_create_vnet')
@mock.patch('pypowervm.tasks.network_bridger.NetworkBridgerVNET.'
'_find_available_ld_grp')
@mock.patch('pypowervm.tasks.network_bridger.NetworkBridgerVNET.'
'_is_arbitrary_vid')
def test_ensure_vlan_on_nb_new_lg(
self, mock_arb_vid, mock_avail_lg, mock_find_vnet,
mock_orphan_validate, mock_orphan_vlans, mock_lock):
"""Validates new VLAN on new Load Group."""
# Build the responses
self.adpt.read.side_effect = [self.mgr_nbr_resp, self.mgr_vsw_resp,
self.mgr_vnet_resp]
mock_arb_vid.return_value = False
mock_avail_lg.return_value = None
mock_orphan_vlans.return_value = []
# Make the fake virtual networks (the new, then the arb vid)
mock_vnet = mock.MagicMock()
mock_vnet.related_href = 'fake_href'
mock_vnet_avid = mock.MagicMock()
mock_vnet_avid.related_href = 'fake_avid_href'
mock_find_vnet.side_effect = [mock_vnet, mock_vnet_avid]
def validate_of_update_nb(*kargs, **kwargs):
# Validate args
nb = kargs[0]
self.assertIsNotNone(nb)
self.assertEqual(1, len(nb.load_grps[0].vnet_uri_list))
self.assertEqual(2, len(nb.load_grps[2].vnet_uri_list))
self.assertEqual(self.nb_uuid, nb.uuid)
return nb.entry
self.adpt.update_by_path.side_effect = validate_of_update_nb
# Invoke
net_br.ensure_vlan_on_nb(self.adpt, self.host_uuid, self.nb_uuid, 2000)
# Validate the calls
self.assertEqual(1, self.adpt.update_by_path.call_count)
self.assertEqual(1, mock_lock.call_count)
@mock.patch('pypowervm.tasks.network_bridger.NetworkBridgerVNET.'
'_find_or_create_vnet')
def test_reassign_arbitrary_vid(self, mock_find_vnet):
nb = self._setup_reassign_arbitrary_vid()
mock_find_vnet.return_value = mock.MagicMock()
mock_find_vnet.return_value.related_href = 'other'
# Make this function return itself.
def return_self(*kargs, **kwargs):
return kargs[0].entry
self.adpt.update_by_path.side_effect = return_self
bridger = net_br.NetworkBridgerVNET(self.adpt, self.host_uuid)
bridger._reassign_arbitrary_vid(4094, 4093, nb)
# Make sure the mocks were called
self.mock_vsw.assert_called_with(self.adpt, parent_type=pvm_ms.System,
parent_uuid=self.host_uuid,
one_result=True, switch_id=0)
self.assertEqual(1, mock_find_vnet.call_count)
self.assertEqual(2, self.adpt.update_by_path.call_count)
@mock.patch('oslo_concurrency.lockutils.lock')
def test_remove_vlan_from_nb(self, mock_lock):
"""Happy path testing of the remove VLAN from NB."""
# Mock Data
self.adpt.read.return_value = self.mgr_nbr_resp
def validate_update(*kargs, **kwargs):
# Make sure the load groups are down to just 1 now.
nb = kargs[0]
self.assertEqual(1, len(nb.load_grps))
return nb.entry
self.adpt.update_by_path.side_effect = validate_update
net_br.remove_vlan_from_nb(self.adpt, self.host_uuid, self.nb_uuid,
1000)
self.assertEqual(1, self.adpt.update_by_path.call_count)
self.assertEqual(1, mock_lock.call_count)
@mock.patch('pypowervm.tasks.network_bridger.NetworkBridgerVNET.'
'_find_vnet_uri_from_lg')
def test_remove_vlan_from_nb_lb(self, mock_find_vnet):
"""Validates a load balance leaves two total LoadGroups."""
# Mock Data
mock_find_vnet.return_value = (
'https://9.1.2.3:12443/rest/api/uom/ManagedSystem/'
'c5d782c7-44e4-3086-ad15-b16fb039d63b/VirtualNetwork/'
'e6c0be9f-b974-35f4-855e-2b7192034fae')
net_bridge = pvm_net.NetBridge.wrap(self.mgr_nbr_resp)[0]
net_bridge.load_balance = True
# Run the remove
bridger = net_br.NetworkBridgerVNET(self.adpt, self.host_uuid)
bridger._remove_vlan_from_nb(net_bridge, 1000)
# Validate that we still have two load groups
self.assertEqual(2, len(net_bridge.load_grps))
self.assertEqual(0, len(net_bridge.load_grps[1].vnet_uri_list))
def test_find_or_create_vnet(self):
"""Validates that a vnet is created (and deleted) as part of find."""
# Load the data
vnets = pvm_net.VNet.wrap(self.mgr_vnet_resp)
vsw = pvm_net.VSwitch.wrap(self.mgr_vsw_resp)[0]
# Set up the mock create
resp = pvm_net.VNet.bld(self.adpt, 'FakeName', 4094, vsw.href, True)
mock_resp = adpt.Response('rm', 'rp', 200, 'reason', {})
mock_resp.entry = resp.entry
self.adpt.create.return_value = mock_resp
# Run the code
bridger = net_br.NetworkBridgerVNET(self.adpt, self.host_uuid)
ret_val = bridger._find_or_create_vnet(vnets, 4094, vsw)
# Equality check
self.assertEqual(4094, ret_val.vlan)
self.assertTrue(ret_val.tagged)
# Make sure the delete was called
self.assertEqual(1, self.adpt.delete_by_href.call_count)
def test_find_available_lg(self):
nb = pvm_net.NetBridge.wrap(self.mgr_nbr_resp)[0]
bridger = net_br.NetworkBridgerVNET(self.adpt, self.host_uuid)
lg = bridger._find_available_ld_grp(nb)
self.assertIsNotNone(lg)
def test_find_available_lg_load_balance(self):
"""Tests finding the Load Group with load balancing enabled."""
# Set load balancing to True
nb = pvm_net.NetBridge.wrap(self.mgr_nbr_fo_resp)[0]
nb.load_balance = True
bridger = net_br.NetworkBridgerVNET(self.adpt, self.host_uuid)
# Even though there is a free VEA, it should come back as None. This
# is because there is only one free VEA, but we need to balance across
# two.
lg = bridger._find_available_ld_grp(nb)
self.assertIsNone(lg)
def test_find_available_min_lg(self):
nb = mock.MagicMock()
lg_main = mock.MagicMock()
lg_first_addl = mock.MagicMock()
lg_first_addl.vnet_uri_list = ['a', 'b', 'c']
lg_second_addl = mock.MagicMock()
lg_second_addl.vnet_uri_list = ['e', 'f']
nb.load_grps = [lg_main, lg_first_addl, lg_second_addl]
bridger = net_br.NetworkBridgerVNET(self.adpt, self.host_uuid)
self.assertEqual(lg_second_addl, bridger._find_available_ld_grp(nb))
class TestNetworkBridgerTA(TestNetworkBridger):
"""General tests for the network bridge super class and the VNet impl."""
def setUp(self):
super(TestNetworkBridgerTA, self).setUp()
self.adptfx.set_traits(fx.LocalPVMTraits)
@mock.patch('pypowervm.tasks.network_bridger.NetworkBridger.'
'_get_orphan_vlans')
@mock.patch('pypowervm.tasks.network_bridger.NetworkBridger.'
'_validate_orphan_on_ensure')
@mock.patch('pypowervm.tasks.network_bridger.NetworkBridgerTA.'
'_reassign_arbitrary_vid')
@mock.patch('pypowervm.wrappers.network.NetBridge.supports_vlan')
def test_ensure_vlan_on_nb_reassign(
self, mock_support_vlan, mock_reassign, mock_orphan_validate,
mock_orphan_vlans):
"""Validates that after update, we support the VLAN."""
# Have the response
self.adpt.read.return_value = self.mgr_nbr_resp
# First call, say that we don't support the VLAN (which is true).
# Second call, fake out that we now do.
# Need pairs, as there are two VLANs we are passing in.
mock_support_vlan.side_effect = [False, False, True, True]
mock_orphan_vlans.return_value = []
# Invoke
net_br.ensure_vlans_on_nb(self.adpt, self.host_uuid, self.nb_uuid,
['4093', 4094])
self.assertEqual(2, self.adpt.read.call_count)
self.assertEqual(1, mock_reassign.call_count)
# Should be called re-assigning 4094 (old) to 4092. Shouldn't be
# 4093 as that is also an additional VLAN.
mock_reassign.assert_called_once_with(4094, 4092, mock.ANY)
@mock.patch('pypowervm.tasks.network_bridger.NetworkBridger.'
'_validate_orphan_on_ensure')
@mock.patch('pypowervm.tasks.network_bridger.NetworkBridgerTA.'
'_is_arbitrary_vid')
def test_ensure_vlan_on_nb_new_vlan(self, mock_arb_vid,
mock_orphan_validate):
"""Validates new VLAN on existing Trunk Adapter."""
# Build the responses
self.adpt.read.side_effect = [self.mgr_nbr_resp, self.mgr_vsw_resp,
self.mgr_vnet_resp]
mock_arb_vid.return_value = False
def validate_of_update_nb(*kargs, **kwargs):
# Validate args
nb = kargs[0]
self.assertIsNotNone(nb)
self.assertEqual(0,
len(nb.seas[0].primary_adpt.tagged_vlans))
self.assertEqual(2,
len(nb.seas[0].addl_adpts[0].tagged_vlans))
self.assertEqual(self.nb_uuid, nb.uuid)
return nb.entry
self.adpt.update_by_path.side_effect = validate_of_update_nb
# Invoke
net_br.ensure_vlan_on_nb(self.adpt, self.host_uuid, self.nb_uuid, 2000)
# Validate the calls
self.assertEqual(1, self.adpt.update_by_path.call_count)
@mock.patch('pypowervm.tasks.network_bridger.NetworkBridger.'
'_validate_orphan_on_ensure')
@mock.patch('pypowervm.tasks.network_bridger.NetworkBridgerTA.'
'_is_arbitrary_vid')
def test_ensure_vlans_on_nb_new_vlan(self, mock_arb_vid,
mock_orphan_validate):
"""Validates new VLAN on existing Load Group."""
# Build the responses
self.adpt.read.side_effect = [self.mgr_nbr_resp, self.mgr_vsw_resp,
self.mgr_vnet_resp]
mock_arb_vid.return_value = False
def validate_of_update_nb(*kargs, **kwargs):
# Validate args
nb = kargs[0]
self.assertEqual(0, len(nb.seas[0].primary_adpt.tagged_vlans))
self.assertEqual(2, len(nb.seas[0].addl_adpts[0].tagged_vlans))
self.assertEqual(self.nb_uuid, nb.uuid)
return nb.entry
self.adpt.update_by_path.side_effect = validate_of_update_nb
# Invoke. VLAN 2227 should be on there already.
net_br.ensure_vlans_on_nb(self.adpt, self.host_uuid,
self.nb_uuid, [2227, 2000])
# Validate the calls
self.assertEqual(1, self.adpt.update_by_path.call_count)
@mock.patch('pypowervm.tasks.network_bridger.NetworkBridger.'
'_get_orphan_vlans')
@mock.patch('pypowervm.tasks.network_bridger.NetworkBridger.'
'_validate_orphan_on_ensure')
@mock.patch('pypowervm.tasks.network_bridger.NetworkBridgerTA.'
'_find_available_trunks')
@mock.patch('pypowervm.tasks.network_bridger.NetworkBridgerTA.'
'_is_arbitrary_vid')
def test_ensure_vlan_on_nb_new_trunk(
self, mock_arb_vid, mock_avail_trunks, mock_orphan_validate,
mock_orphan_vlans):
"""Validates new VLAN on new Load Group."""
# Build the responses
self.adpt.read.side_effect = [self.mgr_nbr_resp, self.mgr_vsw_resp,
self.mgr_vnet_resp]
mock_arb_vid.return_value = False
mock_avail_trunks.return_value = None
mock_orphan_vlans.return_value = []
def validate_of_update_nb(*kargs, **kwargs):
# Validate args
nb = kargs[0]
self.assertIsNotNone(nb)
self.assertEqual(0, len(nb.seas[0].primary_adpt.tagged_vlans))
self.assertEqual(2, len(nb.seas[0].addl_adpts))
self.assertEqual(self.nb_uuid, nb.uuid)
return nb.entry
self.adpt.update_by_path.side_effect = validate_of_update_nb
# Invoke
net_br.ensure_vlan_on_nb(self.adpt, self.host_uuid, self.nb_uuid, 2000)
# Validate the calls
self.assertEqual(1, self.adpt.update_by_path.call_count)
def test_reassign_arbitrary_vid(self):
nb = self._setup_reassign_arbitrary_vid()
# Make this function return itself.
def return_self(*kargs, **kwargs):
nb_wrap = pvm_net.NetBridge.wrap(kargs[0].entry)
self.assertEqual(4093,
nb_wrap.seas[0].addl_adpts[0].pvid)
return kargs[0].entry
self.adpt.update_by_path.side_effect = return_self
bridger = net_br.NetworkBridgerTA(self.adpt, self.host_uuid)
bridger._reassign_arbitrary_vid(4094, 4093, nb)
# Make sure the mocks were called. Only one update needed.
self.assertEqual(1, self.adpt.update_by_path.call_count)
def test_remove_vlan_from_nb(self):
"""Happy path testing of the remove VLAN from NB."""
# Mock Data
self.adpt.read.return_value = self.mgr_nbr_resp
def validate_update(*kargs, **kwargs):
# Make sure the load groups are down to just 1 now.
nb = kargs[0]
self.assertEqual(0, len(nb.seas[0].addl_adpts))
return nb.entry
self.adpt.update_by_path.side_effect = validate_update
net_br.remove_vlan_from_nb(self.adpt, self.host_uuid, self.nb_uuid,
1000)
self.assertEqual(1, self.adpt.update_by_path.call_count)
def test_find_available_trunks(self):
nb = pvm_net.NetBridge.wrap(self.mgr_nbr_resp)[0]
bridger = net_br.NetworkBridgerTA(self.adpt, self.host_uuid)
trunks = bridger._find_available_trunks(nb)
self.assertIsNotNone(trunks)
def test_find_available_trunks_load_balance(self):
"""Tests finding the trunk with load balancing enabled."""
# Set load balancing to True
nb = pvm_net.NetBridge.wrap(self.mgr_nbr_fo_resp)[0]
nb.load_balance = True
bridger = net_br.NetworkBridgerTA(self.adpt, self.host_uuid)
# Even though there is a free VEA, it should come back as None. This
# is because there is only one free VEA, but we need to balance across
# two.
trunks = bridger._find_available_trunks(nb)
self.assertIsNone(trunks)
@mock.patch('pypowervm.tasks.network_bridger.NetworkBridgerTA._trunk_list')
def test_find_available_min_trunk(self, mock_trunk_list):
nb = mock.MagicMock()
trunk_addl = mock.MagicMock()
trunk_addl.tagged_vlans = ['a', 'b', 'c']
trunk_addl2 = mock.MagicMock()
trunk_addl2.tagged_vlans = ['e', 'f']
trunk_addl3 = mock.MagicMock()
trunk_addl3.tagged_vlans = ['g', 'h', 'i']
sea = mock.MagicMock()
sea.addl_adpts = [trunk_addl, trunk_addl2, trunk_addl3]
nb.seas = [sea]
bridger = net_br.NetworkBridgerTA(self.adpt, self.host_uuid)
bridger._find_available_trunks(nb)
# Validate the trunk list is called with the second additional adapter
mock_trunk_list.assert_called_with(nb, trunk_addl2)
def test_find_peer_trunk(self):
bridger = net_br.NetworkBridgerTA(self.adpt, self.host_uuid)
# No failover, shouldn't have a peer
nbs = pvm_net.NetBridge.wrap(self.mgr_nbr_resp)
resp = bridger._find_peer_trunk(nbs[0], nbs[0].seas[0].primary_adpt)
self.assertIsNone(resp)
# Failover, should have a peer
nbs = pvm_net.NetBridge.wrap(self.mgr_nbr_fo_resp)
resp = bridger._find_peer_trunk(nbs[0], nbs[0].seas[0].primary_adpt)
self.assertEqual(nbs[0].seas[1].primary_adpt, resp)
@mock.patch('pypowervm.tasks.network_bridger.NetworkBridgerTA.'
'_reassign_arbitrary_vid')
def test_remove_vlan_from_nb_arb_vid(self, mock_reassign):
"""Attempt to remove an arbitrary VID off the network bridge."""
# Mock Data
self.adpt.read.return_value = self.mgr_nbr_fo_resp
# Run the remove of the VLAN. Make sure it is invoked with a new
# valid arbitrary PVID.
net_br.remove_vlan_from_nb(self.adpt, self.host_uuid, self.nb_uuid,
'4094')
self.assertEqual(1, mock_reassign.call_count)
mock_reassign.assert_called_with(4094, 4093, mock.ANY)
def test_remove_vlan_from_nb_lb(self):
"""Validates a load balance remove leaves an additional adpt."""
# Mock Data
net_bridge = pvm_net.NetBridge.wrap(self.mgr_nbr_resp)[0]
net_bridge.load_balance = True
# Run the remove
bridger = net_br.NetworkBridgerTA(self.adpt, self.host_uuid)
bridger._remove_vlan_from_nb(net_bridge, 1000)
# Validate that we left the trunk but no new additional VLANs
self.assertEqual(1, len(net_bridge.seas[0].addl_adpts))
self.assertEqual(0, len(net_bridge.seas[0].addl_adpts[0].tagged_vlans))
|