1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
|
# Copyright 2015, 2018 IBM Corp.
#
# All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License. You may obtain
# a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
import mock
import testtools
import pypowervm.entities as ent
from pypowervm import exceptions as pexc
from pypowervm.tasks.hdisk import _iscsi as iscsi
import pypowervm.tests.test_fixtures as fx
from pypowervm.wrappers import job
class TestIscsi(testtools.TestCase):
def setUp(self):
super(TestIscsi, self).setUp()
entry = ent.Entry({}, ent.Element('Dummy', None), None)
self.mock_job = job.Job(entry)
self.adpt = self.useFixture(fx.AdapterFx()).adpt
@mock.patch('pypowervm.wrappers.job.Job.create_job_parameter')
def test_add_parameter(self, mock_create):
def create_param(name, value):
return (name, value)
mock_create.side_effect = create_param
parm_array = []
final_array = [("true", "True"), ("false", "False"), ("zero", "0"),
("int", "1"), ("int list", "[0,1]"), ("str", "str"),
("str list", "[str1,str2]")]
iscsi._add_parameter(parm_array, "None", None)
iscsi._add_parameter(parm_array, "true", True)
iscsi._add_parameter(parm_array, "false", False)
iscsi._add_parameter(parm_array, "zero", 0)
iscsi._add_parameter(parm_array, "int", 1)
iscsi._add_parameter(parm_array, "int list", [0, 1])
iscsi._add_parameter(parm_array, "str", "str")
iscsi._add_parameter(parm_array, "str list", ["str1", u'str2'])
self.assertEqual(parm_array, final_array)
@mock.patch('pypowervm.wrappers.job.Job.wrap')
@mock.patch('pypowervm.wrappers.job.Job.run_job')
@mock.patch('pypowervm.wrappers.job.Job.create_job_parameter')
@mock.patch('pypowervm.wrappers.job.Job.get_job_results_as_dict')
def test_discover_iscsi(self, mock_job_res, mock_job_p, mock_run_job,
mock_job_w):
mock_job_w.return_value = self.mock_job
mock_host_ip = '10.0.0.1:3290'
mock_user = 'username'
mock_pass = 'password'
mock_iqn = 'fake_iqn'
mock_uuid = 'uuid'
mock_iface_name = 'iface_name'
args = ['VirtualIOServer', mock_uuid]
kwargs = {'suffix_type': 'do', 'suffix_parm': 'ISCSIDiscovery'}
mock_job_res.return_value = {'DEV_OUTPUT': '["fake_iqn devName udid"]',
'RETURN_CODE': '0'}
device_name, udid = iscsi.discover_iscsi(
self.adpt, mock_host_ip, mock_user, mock_pass, mock_iqn, mock_uuid,
iface_name=mock_iface_name)
self.adpt.read.assert_called_once_with(*args, **kwargs)
self.assertEqual('devName', device_name)
self.assertEqual('udid', udid)
self.assertEqual(1, mock_run_job.call_count)
mock_job_p.assert_has_calls([
mock.call('hostIP', mock_host_ip), mock.call('user', mock_user),
mock.call('password', mock_pass), mock.call('targetIQN', mock_iqn),
mock.call('ifaceName', mock_iface_name),
mock.call('multipath', str(False))], any_order=True)
self.assertEqual(6, mock_job_p.call_count)
# Test for lunid
mock_job_p.reset_mock()
mock_lunid = 2
mock_job_res.return_value = {'DEV_OUTPUT': '["fake_iqn devName udid"]',
'RETURN_CODE': '15'}
device_name, udid = iscsi.discover_iscsi(
self.adpt, mock_host_ip, mock_user, mock_pass, mock_iqn, mock_uuid,
iface_name=mock_iface_name, lunid=mock_lunid)
self.assertEqual(7, mock_job_p.call_count)
mock_job_p.assert_any_call('targetLUN', str(mock_lunid))
mock_job_res.return_value = {'DEV_OUTPUT': '["fake_iqn devName udid"]',
'RETURN_CODE': '8'}
self.assertRaises(pexc.ISCSIDiscoveryFailed, iscsi.discover_iscsi,
self.adpt, mock_host_ip, mock_user, mock_pass,
mock_iqn, mock_uuid, iface_name=mock_iface_name)
# Check named args
mock_job_p.reset_mock()
mock_arg = mock.MagicMock()
mock_job_res.return_value = {'DEV_OUTPUT': '["fake_iqn devName udid"]',
'RETURN_CODE': '0'}
device_name, udid = iscsi.discover_iscsi(
self.adpt, mock_host_ip, mock_user, mock_pass, mock_iqn, mock_uuid,
iface_name=mock_iface_name, lunid=mock_lunid, auth=mock_arg,
discovery_auth=mock_arg, discovery_username=mock_arg,
discovery_password=mock_arg, multipath=True)
self.assertEqual('devName', device_name)
self.assertEqual('udid', udid)
# Check JobRequestFailed exception
mock_run_job.side_effect = pexc.JobRequestFailed(
operation_name='iscsi-discover', error='error')
mock_job_res.return_value = {}
self.assertRaises(pexc.JobRequestFailed, iscsi.discover_iscsi,
self.adpt, mock_host_ip, mock_user, mock_pass,
mock_iqn, mock_uuid, iface_name=mock_iface_name)
@mock.patch('pypowervm.tasks.hdisk._iscsi.remove_iscsi')
@mock.patch('pypowervm.tasks.hdisk._iscsi._discover_iscsi')
@mock.patch('pypowervm.utils.transaction.FeedTask')
@mock.patch('pypowervm.tasks.storage.add_lpar_storage_scrub_tasks')
@mock.patch('pypowervm.tasks.storage.find_stale_lpars')
@mock.patch('pypowervm.wrappers.entry_wrapper.EntryWrapper.get',
new=mock.Mock())
def test_discover_iscsi_scrub(self, mock_fsl, mock_alsst,
mock_ftsk, mock_discover, mock_remove):
def set_discover_side_effect(_stat, _dev):
"""Set up the iscsi discovery mock's side effect.
The first return will be (_stat, _dev, "udid"), per the params.
The second return will always be the same - used to verify that we
really called twice when appropriate.
"""
mock_discover.reset_mock()
mock_discover.side_effect = [(_stat, _dev, 'udid'),
(iscsi.ISCSIStatus.ISCSI_SUCCESS,
'ok_h', 'ok_u')]
stale_lpar_ids = [12, 34]
arg = mock.MagicMock()
host_ip = '10.0.0.1:3290'
lunid = 2
user = 'username'
pwd = 'password'
iqn = 'fake_iqn'
uuid = 'uuid'
iface_name = 'iface_name'
mock_fsl.return_value = stale_lpar_ids
# should cause a scrub-and-retry
set_discover_side_effect(iscsi.ISCSIStatus.ISCSI_ERR_ODM_QUERY,
'dev1')
device_name, udid = iscsi.discover_iscsi(
self.adpt, host_ip, user, pwd, iqn, uuid, iface_name=iface_name,
lunid=lunid, auth=arg, discovery_auth=arg, discovery_username=arg,
discovery_password=arg, multipath=True)
self.assertEqual('ok_h', device_name)
self.assertEqual('ok_u', udid)
self.assertEqual(1, mock_fsl.call_count)
mock_ftsk.assert_called_with('scrub_vios_uuid', mock.ANY)
self.assertEqual(1, mock_alsst.call_count)
self.assertEqual(1, mock_remove.call_count)
# Check in the case of good discovery no retry
mock_fsl.reset_mock()
mock_alsst.reset_mock()
mock_ftsk.reset_mock()
mock_remove.reset_mock()
set_discover_side_effect(iscsi.ISCSIStatus.ISCSI_SUCCESS,
'dev1')
device_name, udid = iscsi.discover_iscsi(
self.adpt, host_ip, user, pwd, iqn, uuid, iface_name=iface_name,
lunid=lunid, auth=arg, discovery_auth=arg, discovery_username=arg,
discovery_password=arg, multipath=True)
self.assertEqual('dev1', device_name)
self.assertEqual('udid', udid)
mock_fsl.assert_not_called()
mock_ftsk.assert_not_called()
mock_alsst.assert_not_called()
mock_remove.assert_not_called()
@mock.patch('pypowervm.wrappers.job.Job.wrap')
@mock.patch('pypowervm.wrappers.job.Job.run_job')
@mock.patch('pypowervm.wrappers.job.Job.get_job_results_as_dict')
def test_discover_initiator(self, mock_job_res, mock_run_job, mock_job_w):
mock_job_w.return_value = self.mock_job
mock_uuid = 'uuid'
args = ['VirtualIOServer', mock_uuid]
kwargs = {'suffix_type': 'do', 'suffix_parm': ('ISCSIDiscovery')}
mock_job_res.return_value = {'InitiatorName': 'fake_iqn',
'RETURN_CODE': '0'}
initiator = iscsi.discover_iscsi_initiator(self.adpt, mock_uuid)
self.adpt.read.assert_called_once_with(*args, **kwargs)
self.assertEqual('fake_iqn', initiator)
self.assertEqual(1, mock_run_job.call_count)
mock_job_res.return_value = {'InitiatorName': '',
'RETURN_CODE': '8'}
self.assertRaises(pexc.ISCSIDiscoveryFailed,
iscsi.discover_iscsi_initiator, self.adpt, mock_uuid)
@mock.patch('pypowervm.wrappers.job.Job.create_job_parameter')
@mock.patch('pypowervm.wrappers.job.Job.wrap')
@mock.patch('pypowervm.wrappers.job.Job.run_job')
@mock.patch('pypowervm.wrappers.job.Job.get_job_results_as_dict')
def test_remove_iscsi(self, mock_job_res, mock_run_job, mock_job_w,
mock_job_p):
mock_job_w.return_value = self.mock_job
mock_uuid = 'uuid'
mock_iqn = 'fake_iqn'
mock_parm = mock.MagicMock()
mock_job_p.return_value = mock_parm
args = ['VirtualIOServer', mock_uuid]
kwargs = {'suffix_type': 'do', 'suffix_parm': ('ISCSIRemove')}
mock_job_res.return_value = {'RETURN_CODE': '0'}
iscsi.remove_iscsi(self.adpt, mock_iqn, mock_uuid)
self.adpt.read.assert_called_once_with(*args, **kwargs)
mock_run_job.assert_called_once_with(
mock_uuid, job_parms=[mock_parm] * 2, timeout=120)
mock_job_p.assert_any_call('targetIQN', mock_iqn)
self.assertEqual(1, mock_run_job.call_count)
# Test to check the ISCSIRemoveFailed
mock_run_job.reset_mock()
mock_job_res.return_value = {'RETURN_CODE': '2'}
self.assertRaises(pexc.ISCSIRemoveFailed,
iscsi.remove_iscsi, self.adpt, mock_iqn, mock_uuid)
# Test the Return Code 21
mock_run_job.reset_mock()
mock_job_res.return_value = {'RETURN_CODE': '21'}
iscsi.remove_iscsi(self.adpt, mock_iqn, mock_uuid)
mock_run_job.assert_called_once_with(
mock_uuid, job_parms=[mock_parm] * 2, timeout=120)
# Check named params
mock_run_job.reset_mock()
mock_arg = mock.MagicMock()
iscsi.remove_iscsi(self.adpt, mock_iqn, mock_uuid, iface_name=mock_arg,
lun=mock_arg, portal=mock_arg, multipath=mock_arg)
mock_run_job.assert_called_once_with(
mock_uuid, job_parms=[mock_parm] * 5, timeout=120)
@mock.patch('pypowervm.tasks.hdisk._iscsi.LOG')
def test_log_iscsi_status(self, mock_log):
"""This tests the branches of log_iscsi_status."""
status_list = [iscsi.ISCSIStatus.ISCSI_ERR_ODM_QUERY,
iscsi.ISCSIStatus.ISCSI_COMMAND_NOT_FOUND,
iscsi.ISCSIStatus.ISCSI_ERR_NO_OBJS_FOUND,
iscsi.ISCSIStatus.ISCSI_ERR_SESS_NOT_FOUND]
for status in status_list:
mock_log.reset_mock()
iscsi._log_iscsi_status(status)
self.assertEqual(1, mock_log.warning.call_count)
status_list = [iscsi.ISCSIStatus.ISCSI_ERR_SESS_EXISTS,
iscsi.ISCSIStatus.ISCSI_SUCCESS]
for status in status_list:
mock_log.reset_mock()
iscsi._log_iscsi_status(status)
self.assertEqual(1, mock_log.info.call_count)
status_list = [iscsi.ISCSIStatus.ISCSI_ERR_LOGIN,
iscsi.ISCSIStatus.ISCSI_ERR_INVAL,
iscsi.ISCSIStatus.ISCSI_ERR_TRANS_TIMEOUT,
iscsi.ISCSIStatus.ISCSI_ERR_INTERNAL,
iscsi.ISCSIStatus.ISCSI_ERR_LOGOUT,
iscsi.ISCSIStatus.ISCSI_ERR_LOGIN_AUTH_FAILED,
iscsi.ISCSIStatus.ISCSI_ERR_HOST_NOT_FOUND]
for status in status_list:
mock_log.reset_mock()
iscsi._log_iscsi_status(status)
self.assertEqual(1, mock_log.error.call_count)
|
