File: no_redundant_assign.py

package info (click to toggle)
python-refurb 1.27.0-1
  • links: PTS, VCS
  • area: main
  • in suites: sid
  • size: 1,700 kB
  • sloc: python: 9,468; makefile: 40; sh: 6
file content (42 lines) | stat: -rw-r--r-- 1,023 bytes parent folder | download
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
from dataclasses import dataclass

from mypy.nodes import AssignmentStmt, NameExpr

from refurb.checks.common import unmangle_name
from refurb.error import Error


@dataclass
class ErrorInfo(Error):
    """
    Sometimes when you are debugging (or copy-pasting code) you will end up
    with a variable that is assigning itself to itself. These lines can be
    removed.

    Bad:

    ```
    name = input("What is your name? ")
    name = name
    ```

    Good:

    ```
    name = input("What is your name? ")
    ```
    """

    code = 160
    name = "no-redundant-assignment"
    categories = ("readability",)
    msg: str = "Remove redundant assignment of variable to itself"


def check(node: AssignmentStmt, errors: list[Error]) -> None:
    match node:
        case AssignmentStmt(
            lvalues=[NameExpr(fullname=lhs_name)],
            rvalue=NameExpr(fullname=rhs_name),
        ) if lhs_name and unmangle_name(lhs_name) == unmangle_name(rhs_name):
            errors.append(ErrorInfo.from_node(node))