1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594
|
from unittest import TextTestResult
import pytest
from twisted.internet import defer
from twisted.python import failure
from twisted.trial import unittest
from scrapy import FormRequest
from scrapy.contracts import Contract, ContractsManager
from scrapy.contracts.default import (
CallbackKeywordArgumentsContract,
MetadataContract,
ReturnsContract,
ScrapesContract,
UrlContract,
)
from scrapy.http import Request
from scrapy.item import Field, Item
from scrapy.spidermiddlewares.httperror import HttpError
from scrapy.spiders import Spider
from scrapy.utils.test import get_crawler
from tests.mockserver import MockServer
class DemoItem(Item):
name = Field()
url = Field()
class ResponseMock:
url = "http://scrapy.org"
class ResponseMetaMock(ResponseMock):
meta = None
class CustomSuccessContract(Contract):
name = "custom_success_contract"
def adjust_request_args(self, args):
args["url"] = "http://scrapy.org"
return args
class CustomFailContract(Contract):
name = "custom_fail_contract"
def adjust_request_args(self, args):
raise TypeError("Error in adjust_request_args")
class CustomFormContract(Contract):
name = "custom_form"
request_cls = FormRequest
def adjust_request_args(self, args):
args["formdata"] = {"name": "scrapy"}
return args
class DemoSpider(Spider):
name = "demo_spider"
def returns_request(self, response):
"""method which returns request
@url http://scrapy.org
@returns requests 1
"""
return Request("http://scrapy.org", callback=self.returns_item)
async def returns_request_async(self, response):
"""async method which returns request
@url http://scrapy.org
@returns requests 1
"""
return Request("http://scrapy.org", callback=self.returns_item)
def returns_item(self, response):
"""method which returns item
@url http://scrapy.org
@returns items 1 1
"""
return DemoItem(url=response.url)
def returns_request_cb_kwargs(self, response, url):
"""method which returns request
@url https://example.org
@cb_kwargs {"url": "http://scrapy.org"}
@returns requests 1
"""
return Request(url, callback=self.returns_item_cb_kwargs)
def returns_item_cb_kwargs(self, response, name):
"""method which returns item
@url http://scrapy.org
@cb_kwargs {"name": "Scrapy"}
@returns items 1 1
"""
return DemoItem(name=name, url=response.url)
def returns_item_cb_kwargs_error_unexpected_keyword(self, response):
"""method which returns item
@url http://scrapy.org
@cb_kwargs {"arg": "value"}
@returns items 1 1
"""
return DemoItem(url=response.url)
def returns_item_cb_kwargs_error_missing_argument(self, response, arg):
"""method which returns item
@url http://scrapy.org
@returns items 1 1
"""
return DemoItem(url=response.url)
def returns_dict_item(self, response):
"""method which returns item
@url http://scrapy.org
@returns items 1 1
"""
return {"url": response.url}
def returns_fail(self, response):
"""method which returns item
@url http://scrapy.org
@returns items 0 0
"""
return DemoItem(url=response.url)
def returns_dict_fail(self, response):
"""method which returns item
@url http://scrapy.org
@returns items 0 0
"""
return {"url": response.url}
def scrapes_item_ok(self, response):
"""returns item with name and url
@url http://scrapy.org
@returns items 1 1
@scrapes name url
"""
return DemoItem(name="test", url=response.url)
def scrapes_dict_item_ok(self, response):
"""returns item with name and url
@url http://scrapy.org
@returns items 1 1
@scrapes name url
"""
return {"name": "test", "url": response.url}
def scrapes_item_fail(self, response):
"""returns item with no name
@url http://scrapy.org
@returns items 1 1
@scrapes name url
"""
return DemoItem(url=response.url)
def scrapes_dict_item_fail(self, response):
"""returns item with no name
@url http://scrapy.org
@returns items 1 1
@scrapes name url
"""
return {"url": response.url}
def scrapes_multiple_missing_fields(self, response):
"""returns item with no name
@url http://scrapy.org
@returns items 1 1
@scrapes name url
"""
return {}
def parse_no_url(self, response):
"""method with no url
@returns items 1 1
"""
def custom_form(self, response):
"""
@url http://scrapy.org
@custom_form
"""
def invalid_regex(self, response):
"""method with invalid regex
@ Scrapy is awsome
"""
def invalid_regex_with_valid_contract(self, response):
"""method with invalid regex
@ scrapy is awsome
@url http://scrapy.org
"""
def returns_request_meta(self, response):
"""method which returns request
@url https://example.org
@meta {"cookiejar": "session1"}
@returns requests 1
"""
return Request(
"https://example.org", meta=response.meta, callback=self.returns_item_meta
)
def returns_item_meta(self, response):
"""method which returns item
@url http://scrapy.org
@meta {"key": "example"}
@returns items 1 1
"""
return DemoItem(name="example", url=response.url)
def returns_error_missing_meta(self, response):
"""method which depends of metadata be defined
@url http://scrapy.org
@returns items 1
"""
key = response.meta["key"]
yield {key: "value"}
class CustomContractSuccessSpider(Spider):
name = "custom_contract_success_spider"
def parse(self, response):
"""
@custom_success_contract
"""
class CustomContractFailSpider(Spider):
name = "custom_contract_fail_spider"
def parse(self, response):
"""
@custom_fail_contract
"""
class InheritsDemoSpider(DemoSpider):
name = "inherits_demo_spider"
class TestContractsManager(unittest.TestCase):
contracts = [
UrlContract,
CallbackKeywordArgumentsContract,
MetadataContract,
ReturnsContract,
ScrapesContract,
CustomFormContract,
CustomSuccessContract,
CustomFailContract,
]
def setUp(self):
self.conman = ContractsManager(self.contracts)
self.results = TextTestResult(stream=None, descriptions=False, verbosity=0)
def should_succeed(self):
assert not self.results.failures
assert not self.results.errors
def should_fail(self):
assert self.results.failures
assert not self.results.errors
def should_error(self):
assert self.results.errors
def test_contracts(self):
spider = DemoSpider()
# extract contracts correctly
contracts = self.conman.extract_contracts(spider.returns_request)
assert len(contracts) == 2
assert frozenset(type(x) for x in contracts) == frozenset(
[UrlContract, ReturnsContract]
)
# returns request for valid method
request = self.conman.from_method(spider.returns_request, self.results)
assert request is not None
# no request for missing url
request = self.conman.from_method(spider.parse_no_url, self.results)
assert request is None
def test_cb_kwargs(self):
spider = DemoSpider()
response = ResponseMock()
# extract contracts correctly
contracts = self.conman.extract_contracts(spider.returns_request_cb_kwargs)
assert len(contracts) == 3
assert frozenset(type(x) for x in contracts) == frozenset(
[UrlContract, CallbackKeywordArgumentsContract, ReturnsContract]
)
contracts = self.conman.extract_contracts(spider.returns_item_cb_kwargs)
assert len(contracts) == 3
assert frozenset(type(x) for x in contracts) == frozenset(
[UrlContract, CallbackKeywordArgumentsContract, ReturnsContract]
)
contracts = self.conman.extract_contracts(
spider.returns_item_cb_kwargs_error_unexpected_keyword
)
assert len(contracts) == 3
assert frozenset(type(x) for x in contracts) == frozenset(
[UrlContract, CallbackKeywordArgumentsContract, ReturnsContract]
)
contracts = self.conman.extract_contracts(
spider.returns_item_cb_kwargs_error_missing_argument
)
assert len(contracts) == 2
assert frozenset(type(x) for x in contracts) == frozenset(
[UrlContract, ReturnsContract]
)
# returns_request
request = self.conman.from_method(
spider.returns_request_cb_kwargs, self.results
)
request.callback(response, **request.cb_kwargs)
self.should_succeed()
# returns_item
request = self.conman.from_method(spider.returns_item_cb_kwargs, self.results)
request.callback(response, **request.cb_kwargs)
self.should_succeed()
# returns_item (error, callback doesn't take keyword arguments)
request = self.conman.from_method(
spider.returns_item_cb_kwargs_error_unexpected_keyword, self.results
)
request.callback(response, **request.cb_kwargs)
self.should_error()
# returns_item (error, contract doesn't provide keyword arguments)
request = self.conman.from_method(
spider.returns_item_cb_kwargs_error_missing_argument, self.results
)
request.callback(response, **request.cb_kwargs)
self.should_error()
def test_meta(self):
spider = DemoSpider()
# extract contracts correctly
contracts = self.conman.extract_contracts(spider.returns_request_meta)
assert len(contracts) == 3
assert frozenset(type(x) for x in contracts) == frozenset(
[UrlContract, MetadataContract, ReturnsContract]
)
contracts = self.conman.extract_contracts(spider.returns_item_meta)
assert len(contracts) == 3
assert frozenset(type(x) for x in contracts) == frozenset(
[UrlContract, MetadataContract, ReturnsContract]
)
response = ResponseMetaMock()
# returns_request
request = self.conman.from_method(spider.returns_request_meta, self.results)
assert request.meta["cookiejar"] == "session1"
response.meta = request.meta
request.callback(response)
assert response.meta["cookiejar"] == "session1"
self.should_succeed()
response = ResponseMetaMock()
# returns_item
request = self.conman.from_method(spider.returns_item_meta, self.results)
assert request.meta["key"] == "example"
response.meta = request.meta
request.callback(ResponseMetaMock)
assert response.meta["key"] == "example"
self.should_succeed()
response = ResponseMetaMock()
request = self.conman.from_method(
spider.returns_error_missing_meta, self.results
)
request.callback(response)
self.should_error()
def test_returns(self):
spider = DemoSpider()
response = ResponseMock()
# returns_item
request = self.conman.from_method(spider.returns_item, self.results)
request.callback(response)
self.should_succeed()
# returns_dict_item
request = self.conman.from_method(spider.returns_dict_item, self.results)
request.callback(response)
self.should_succeed()
# returns_request
request = self.conman.from_method(spider.returns_request, self.results)
request.callback(response)
self.should_succeed()
# returns_fail
request = self.conman.from_method(spider.returns_fail, self.results)
request.callback(response)
self.should_fail()
# returns_dict_fail
request = self.conman.from_method(spider.returns_dict_fail, self.results)
request.callback(response)
self.should_fail()
def test_returns_async(self):
spider = DemoSpider()
response = ResponseMock()
request = self.conman.from_method(spider.returns_request_async, self.results)
request.callback(response)
self.should_error()
def test_scrapes(self):
spider = DemoSpider()
response = ResponseMock()
# scrapes_item_ok
request = self.conman.from_method(spider.scrapes_item_ok, self.results)
request.callback(response)
self.should_succeed()
# scrapes_dict_item_ok
request = self.conman.from_method(spider.scrapes_dict_item_ok, self.results)
request.callback(response)
self.should_succeed()
# scrapes_item_fail
request = self.conman.from_method(spider.scrapes_item_fail, self.results)
request.callback(response)
self.should_fail()
# scrapes_dict_item_fail
request = self.conman.from_method(spider.scrapes_dict_item_fail, self.results)
request.callback(response)
self.should_fail()
# scrapes_multiple_missing_fields
request = self.conman.from_method(
spider.scrapes_multiple_missing_fields, self.results
)
request.callback(response)
self.should_fail()
message = "ContractFail: Missing fields: name, url"
assert message in self.results.failures[-1][-1]
def test_regex(self):
spider = DemoSpider()
response = ResponseMock()
# invalid regex
request = self.conman.from_method(spider.invalid_regex, self.results)
self.should_succeed()
# invalid regex with valid contract
request = self.conman.from_method(
spider.invalid_regex_with_valid_contract, self.results
)
self.should_succeed()
request.callback(response)
def test_custom_contracts(self):
self.conman.from_spider(CustomContractSuccessSpider(), self.results)
self.should_succeed()
self.conman.from_spider(CustomContractFailSpider(), self.results)
self.should_error()
def test_errback(self):
spider = DemoSpider()
response = ResponseMock()
try:
raise HttpError(response, "Ignoring non-200 response")
except HttpError:
failure_mock = failure.Failure()
request = self.conman.from_method(spider.returns_request, self.results)
request.errback(failure_mock)
assert not self.results.failures
assert self.results.errors
@defer.inlineCallbacks
def test_same_url(self):
class TestSameUrlSpider(Spider):
name = "test_same_url"
def __init__(self, *args, **kwargs):
super().__init__(*args, **kwargs)
self.visited = 0
async def start(self_): # pylint: disable=no-self-argument
for item_or_request in self.conman.from_spider(self_, self.results):
yield item_or_request
def parse_first(self, response):
self.visited += 1
return DemoItem()
def parse_second(self, response):
self.visited += 1
return DemoItem()
with MockServer() as mockserver:
contract_doc = f"@url {mockserver.url('/status?n=200')}"
TestSameUrlSpider.parse_first.__doc__ = contract_doc
TestSameUrlSpider.parse_second.__doc__ = contract_doc
crawler = get_crawler(TestSameUrlSpider)
yield crawler.crawl()
assert crawler.spider.visited == 2
def test_form_contract(self):
spider = DemoSpider()
request = self.conman.from_method(spider.custom_form, self.results)
assert request.method == "POST"
assert isinstance(request, FormRequest)
def test_inherited_contracts(self):
spider = InheritsDemoSpider()
requests = self.conman.from_spider(spider, self.results)
assert requests
class CustomFailContractPreProcess(Contract):
name = "test_contract"
def pre_process(self, response):
raise KeyboardInterrupt("Pre-process exception")
class CustomFailContractPostProcess(Contract):
name = "test_contract"
def post_process(self, response):
raise KeyboardInterrupt("Post-process exception")
class TestCustomContractPrePostProcess:
def setup_method(self):
self.results = TextTestResult(stream=None, descriptions=False, verbosity=0)
def test_pre_hook_keyboard_interrupt(self):
spider = DemoSpider()
response = ResponseMock()
contract = CustomFailContractPreProcess(spider.returns_request)
conman = ContractsManager([contract])
request = conman.from_method(spider.returns_request, self.results)
contract.add_pre_hook(request, self.results)
with pytest.raises(KeyboardInterrupt, match="Pre-process exception"):
request.callback(response, **request.cb_kwargs)
assert not self.results.failures
assert not self.results.errors
def test_post_hook_keyboard_interrupt(self):
spider = DemoSpider()
response = ResponseMock()
contract = CustomFailContractPostProcess(spider.returns_request)
conman = ContractsManager([contract])
request = conman.from_method(spider.returns_request, self.results)
contract.add_post_hook(request, self.results)
with pytest.raises(KeyboardInterrupt, match="Post-process exception"):
request.callback(response, **request.cb_kwargs)
assert not self.results.failures
assert not self.results.errors
|