1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232
|
# ruff: noqa: SIM300
from __future__ import annotations
from textwrap import dedent
from typing import TYPE_CHECKING, Iterable, Sequence
import pytest
from semantic_release.commit_parser.conventional import (
ConventionalCommitParser,
ConventionalCommitParserOptions,
)
from semantic_release.commit_parser.token import ParsedCommit, ParseError
from semantic_release.enums import LevelBump
from tests.const import SUPPORTED_ISSUE_CLOSURE_PREFIXES
if TYPE_CHECKING:
from tests.conftest import MakeCommitObjFn
# NOTE: GitLab squash commits are not tested because by default
# they don't have any unique attributes of them and they are also
# fully customizable.
# See https://docs.gitlab.com/ee/user/project/merge_requests/commit_templates.html
# It also depends if Fast-Forward merge is enabled because that will
# define if there is a merge commit or not and with that likely no
# Merge Request Number included unless the user adds it.
# TODO: add the recommendation in the PSR documentation is to set your GitLab templates
# to mirror GitHub like references in the first subject line. Will Not matter
# if fast-forward merge is enabled or not.
@pytest.mark.parametrize(
"commit_message", ["", "feat(parser\n): Add new parser pattern"]
)
def test_parser_raises_unknown_message_style(
default_conventional_parser: ConventionalCommitParser,
make_commit_obj: MakeCommitObjFn,
commit_message: str,
):
parsed_results = default_conventional_parser.parse(make_commit_obj(commit_message))
assert isinstance(parsed_results, Iterable)
for result in parsed_results:
assert isinstance(result, ParseError)
@pytest.mark.parametrize(
"commit_message, expected_commit_details",
[
pytest.param(
commit_message,
expected_commit_details,
id=test_id,
)
for test_id, commit_message, expected_commit_details in [
(
"Single commit squashed via BitBucket PR resolution",
dedent(
"""\
Merged in feat/my-awesome-stuff (pull request #10)
fix(release-config): some commit subject
An additional description
Second paragraph with multiple lines
that will be condensed
Resolves: #12
Signed-off-by: author <author@not-an-email.com>
"""
),
[
None,
{
"bump": LevelBump.PATCH,
"type": "bug fixes",
"scope": "release-config",
"descriptions": [
"some commit subject",
"An additional description",
"Second paragraph with multiple lines that will be condensed",
"Signed-off-by: author <author@not-an-email.com>",
],
"linked_issues": ("#12",),
"linked_merge_request": "#10",
},
],
),
(
"Multiple commits squashed via BitBucket PR resolution",
dedent(
"""\
Merged in feat/my-awesome-stuff (pull request #10)
fix(release-config): some commit subject
An additional description
Second paragraph with multiple lines
that will be condensed
Resolves: #12
Signed-off-by: author <author@not-an-email.com>
feat: implemented searching gizmos by keyword
docs(parser): add new parser pattern
fix(cli)!: changed option name
BREAKING CHANGE: A breaking change description
Closes: #555
invalid non-conventional formatted commit
"""
),
[
None,
{
"bump": LevelBump.PATCH,
"type": "bug fixes",
"scope": "release-config",
"descriptions": [
"some commit subject",
"An additional description",
"Second paragraph with multiple lines that will be condensed",
"Signed-off-by: author <author@not-an-email.com>",
],
"linked_issues": ("#12",),
"linked_merge_request": "#10",
},
{
"bump": LevelBump.MINOR,
"type": "features",
"descriptions": ["implemented searching gizmos by keyword"],
"linked_merge_request": "#10",
},
{
"bump": LevelBump.NO_RELEASE,
"type": "documentation",
"scope": "parser",
"descriptions": [
"add new parser pattern",
],
"linked_merge_request": "#10",
},
{
"bump": LevelBump.MAJOR,
"type": "bug fixes",
"scope": "cli",
"descriptions": [
"changed option name",
# This is a bit unusual but its because there is no identifier that will
# identify this as a separate commit so it gets included in the previous commit
"invalid non-conventional formatted commit",
],
"breaking_descriptions": [
"A breaking change description",
],
"linked_issues": ("#555",),
"linked_merge_request": "#10",
},
],
),
]
],
)
def test_parser_squashed_commit_bitbucket_squash_style(
default_conventional_parser: ConventionalCommitParser,
make_commit_obj: MakeCommitObjFn,
commit_message: str,
expected_commit_details: Sequence[dict | None],
):
# Setup: Enable squash commit parsing
parser = ConventionalCommitParser(
options=ConventionalCommitParserOptions(
**{
**default_conventional_parser.options.__dict__,
"parse_squash_commits": True,
}
)
)
# Build the commit object and parse it
the_commit = make_commit_obj(commit_message)
parsed_results = parser.parse(the_commit)
# Validate the results
assert isinstance(parsed_results, Iterable)
assert (
len(expected_commit_details) == len(parsed_results)
), f"Expected {len(expected_commit_details)} parsed results, but got {len(parsed_results)}"
for result, expected in zip(parsed_results, expected_commit_details):
if expected is None:
assert isinstance(result, ParseError)
continue
assert isinstance(result, ParsedCommit)
# Required
assert expected["bump"] == result.bump
assert expected["type"] == result.type
# Optional
assert expected.get("scope", "") == result.scope
# TODO: v11 change to tuples
assert expected.get("descriptions", []) == result.descriptions
assert expected.get("breaking_descriptions", []) == result.breaking_descriptions
assert expected.get("linked_issues", ()) == result.linked_issues
assert expected.get("linked_merge_request", "") == result.linked_merge_request
@pytest.mark.parametrize(
"commit_message, expected_commit_details",
[
pytest.param(
commit_message,
expected_commit_details,
id=test_id,
)
for test_id, commit_message, expected_commit_details in [
(
"Single commit squashed via manual Git squash merge",
dedent(
"""\
Squashed commit of the following:
commit 63ec09b9e844e616dcaa7bae35a0b66671b59fbb
Author: author <author@not-an-email.com>
Date: Sun Jan 19 12:05:23 2025 +0000
fix(release-config): some commit subject
An additional description
Second paragraph with multiple lines
that will be condensed
Resolves: #12
Signed-off-by: author <author@not-an-email.com>
"""
),
[
{
"bump": LevelBump.PATCH,
"type": "bug fixes",
"scope": "release-config",
"descriptions": [
"some commit subject",
"An additional description",
"Second paragraph with multiple lines that will be condensed",
"Signed-off-by: author <author@not-an-email.com>",
],
"linked_issues": ("#12",),
}
],
),
(
"Multiple commits squashed via manual Git squash merge",
dedent(
"""\
Squashed commit of the following:
commit 63ec09b9e844e616dcaa7bae35a0b66671b59fbb
Author: author <author@not-an-email.com>
Date: Sun Jan 19 12:05:23 2025 +0000
fix(release-config): some commit subject
An additional description
Second paragraph with multiple lines
that will be condensed
Resolves: #12
Signed-off-by: author <author@not-an-email.com>
commit 1f34769bf8352131ad6f4879b8c47becf3c7aa69
Author: author <author@not-an-email.com>
Date: Sat Jan 18 10:13:53 2025 +0000
feat: implemented searching gizmos by keyword
commit b2334a64a11ef745a17a2a4034f651e08e8c45a6
Author: author <author@not-an-email.com>
Date: Sat Jan 18 10:13:53 2025 +0000
docs(parser): add new parser pattern
commit 5f0292fb5a88c3a46e4a02bec35b85f5228e8e51
Author: author <author@not-an-email.com>
Date: Sat Jan 18 10:13:53 2025 +0000
fix(cli)!: changed option name
BREAKING CHANGE: A breaking change description
Closes: #555
commit 2f314e7924be161cfbf220d3b6e2a6189a3b5609
Author: author <author@not-an-email.com>
Date: Sat Jan 18 10:13:53 2025 +0000
invalid non-conventional formatted commit
"""
),
[
{
"bump": LevelBump.PATCH,
"type": "bug fixes",
"scope": "release-config",
"descriptions": [
"some commit subject",
"An additional description",
"Second paragraph with multiple lines that will be condensed",
"Signed-off-by: author <author@not-an-email.com>",
],
"linked_issues": ("#12",),
},
{
"bump": LevelBump.MINOR,
"type": "features",
"descriptions": ["implemented searching gizmos by keyword"],
},
{
"bump": LevelBump.NO_RELEASE,
"type": "documentation",
"scope": "parser",
"descriptions": [
"add new parser pattern",
],
},
{
"bump": LevelBump.MAJOR,
"type": "bug fixes",
"scope": "cli",
"descriptions": [
"changed option name",
],
"breaking_descriptions": [
"A breaking change description",
],
"linked_issues": ("#555",),
},
None,
],
),
]
],
)
def test_parser_squashed_commit_git_squash_style(
default_conventional_parser: ConventionalCommitParser,
make_commit_obj: MakeCommitObjFn,
commit_message: str,
expected_commit_details: Sequence[dict | None],
):
# Setup: Enable squash commit parsing
parser = ConventionalCommitParser(
options=ConventionalCommitParserOptions(
**{
**default_conventional_parser.options.__dict__,
"parse_squash_commits": True,
}
)
)
# Build the commit object and parse it
the_commit = make_commit_obj(commit_message)
parsed_results = parser.parse(the_commit)
# Validate the results
assert isinstance(parsed_results, Iterable)
assert (
len(expected_commit_details) == len(parsed_results)
), f"Expected {len(expected_commit_details)} parsed results, but got {len(parsed_results)}"
for result, expected in zip(parsed_results, expected_commit_details):
if expected is None:
assert isinstance(result, ParseError)
continue
assert isinstance(result, ParsedCommit)
# Required
assert expected["bump"] == result.bump
assert expected["type"] == result.type
# Optional
assert expected.get("scope", "") == result.scope
# TODO: v11 change to tuples
assert expected.get("descriptions", []) == result.descriptions
assert expected.get("breaking_descriptions", []) == result.breaking_descriptions
assert expected.get("linked_issues", ()) == result.linked_issues
assert expected.get("linked_merge_request", "") == result.linked_merge_request
@pytest.mark.parametrize(
"commit_message, expected_commit_details",
[
pytest.param(
commit_message,
expected_commit_details,
id=test_id,
)
for test_id, commit_message, expected_commit_details in [
(
"Single commit squashed via GitHub PR resolution",
dedent(
"""\
fix(release-config): some commit subject (#10)
An additional description
Second paragraph with multiple lines
that will be condensed
Resolves: #12
Signed-off-by: author <author@not-an-email.com>
"""
),
[
{
"bump": LevelBump.PATCH,
"type": "bug fixes",
"scope": "release-config",
"descriptions": [
"some commit subject",
"An additional description",
"Second paragraph with multiple lines that will be condensed",
"Signed-off-by: author <author@not-an-email.com>",
],
"linked_issues": ("#12",),
"linked_merge_request": "#10",
},
],
),
(
"Multiple commits squashed via GitHub PR resolution",
dedent(
"""\
fix(release-config): some commit subject (#10)
An additional description
Second paragraph with multiple lines
that will be condensed
Resolves: #12
Signed-off-by: author <author@not-an-email.com>
* feat: implemented searching gizmos by keyword
* docs(parser): add new parser pattern
* fix(cli)!: changed option name
BREAKING CHANGE: A breaking change description
Closes: #555
* invalid non-conventional formatted commit
"""
),
[
{
"bump": LevelBump.PATCH,
"type": "bug fixes",
"scope": "release-config",
"descriptions": [
"some commit subject",
"An additional description",
"Second paragraph with multiple lines that will be condensed",
"Signed-off-by: author <author@not-an-email.com>",
],
"linked_issues": ("#12",),
"linked_merge_request": "#10",
},
{
"bump": LevelBump.MINOR,
"type": "features",
"descriptions": ["implemented searching gizmos by keyword"],
"linked_merge_request": "#10",
},
{
"bump": LevelBump.NO_RELEASE,
"type": "documentation",
"scope": "parser",
"descriptions": [
"add new parser pattern",
],
"linked_merge_request": "#10",
},
{
"bump": LevelBump.MAJOR,
"type": "bug fixes",
"scope": "cli",
"descriptions": [
"changed option name",
# This is a bit unusual but its because there is no identifier that will
# identify this as a separate commit so it gets included in the previous commit
"* invalid non-conventional formatted commit",
],
"breaking_descriptions": [
"A breaking change description",
],
"linked_issues": ("#555",),
"linked_merge_request": "#10",
},
],
),
]
],
)
def test_parser_squashed_commit_github_squash_style(
default_conventional_parser: ConventionalCommitParser,
make_commit_obj: MakeCommitObjFn,
commit_message: str,
expected_commit_details: Sequence[dict | None],
):
# Setup: Enable squash commit parsing
parser = ConventionalCommitParser(
options=ConventionalCommitParserOptions(
**{
**default_conventional_parser.options.__dict__,
"parse_squash_commits": True,
}
)
)
# Build the commit object and parse it
the_commit = make_commit_obj(commit_message)
parsed_results = parser.parse(the_commit)
# Validate the results
assert isinstance(parsed_results, Iterable)
assert (
len(expected_commit_details) == len(parsed_results)
), f"Expected {len(expected_commit_details)} parsed results, but got {len(parsed_results)}"
for result, expected in zip(parsed_results, expected_commit_details):
if expected is None:
assert isinstance(result, ParseError)
continue
assert isinstance(result, ParsedCommit)
# Required
assert expected["bump"] == result.bump
assert expected["type"] == result.type
# Optional
assert expected.get("scope", "") == result.scope
# TODO: v11 change to tuples
assert expected.get("descriptions", []) == result.descriptions
assert expected.get("breaking_descriptions", []) == result.breaking_descriptions
assert expected.get("linked_issues", ()) == result.linked_issues
assert expected.get("linked_merge_request", "") == result.linked_merge_request
@pytest.mark.parametrize(
"commit_message, bump",
[
(
"feat(parsers): add new parser pattern\n\nBREAKING CHANGE: change",
LevelBump.MAJOR,
),
("feat(parsers)!: add new parser pattern", LevelBump.MAJOR),
(
"feat(parsers): add new parser pattern\n\nNew pattern is awesome\n\n"
"BREAKING CHANGE: change \n",
LevelBump.MAJOR,
),
(
"feat(parsers): add new parser pattern\n\nBREAKING-CHANGE: change !",
LevelBump.MAJOR,
),
("feat(parser): add emoji parser", LevelBump.MINOR),
("fix(parser): fix regex in conventional parser", LevelBump.PATCH),
("test(parser): add a test for conventional parser", LevelBump.NO_RELEASE),
("feat(parser)!: edit data parsing stuff", LevelBump.MAJOR),
("fix!: edit data parsing stuff again", LevelBump.MAJOR),
("fix: superfix", LevelBump.PATCH),
],
)
def test_parser_returns_correct_bump_level(
default_conventional_parser: ConventionalCommitParser,
commit_message: str,
bump: LevelBump,
make_commit_obj: MakeCommitObjFn,
):
parsed_results = default_conventional_parser.parse(make_commit_obj(commit_message))
assert isinstance(parsed_results, Iterable)
assert len(parsed_results) == 1
result = next(iter(parsed_results))
assert isinstance(result, ParsedCommit)
assert result.bump is bump
@pytest.mark.parametrize(
"message, type_",
[
("feat(parser): ...", "features"),
("fix(parser): ...", "bug fixes"),
("test(parser): ...", "testing"),
("docs(parser): ...", "documentation"),
("style(parser): ...", "code style"),
("refactor(parser): ...", "refactoring"),
("chore(parser): ...", "chores"),
],
)
def test_parser_return_type_from_commit_message(
default_conventional_parser: ConventionalCommitParser,
message: str,
type_: str,
make_commit_obj: MakeCommitObjFn,
):
parsed_results = default_conventional_parser.parse(make_commit_obj(message))
assert isinstance(parsed_results, Iterable)
assert len(parsed_results) == 1
result = next(iter(parsed_results))
assert isinstance(result, ParsedCommit)
assert result.type == type_
@pytest.mark.parametrize(
"message, scope",
[
("chore(parser): ...", "parser"),
("chore(a part): ...", "a part"),
("chore(a_part): ...", "a_part"),
("chore(a-part): ...", "a-part"),
("chore(a.part): ...", "a.part"),
("chore(a+part): ...", "a+part"),
("chore(a&part): ...", "a&part"),
("chore((part)): ...", "(part)"),
("chore((p):rt): ...", "(p):rt"),
],
)
def test_parser_return_scope_from_commit_message(
default_conventional_parser: ConventionalCommitParser,
message: str,
scope: str,
make_commit_obj: MakeCommitObjFn,
):
parsed_results = default_conventional_parser.parse(make_commit_obj(message))
assert isinstance(parsed_results, Iterable)
assert len(parsed_results) == 1
result = next(iter(parsed_results))
assert isinstance(result, ParsedCommit)
assert result.scope == scope
_long_text = (
"This is an long explanatory part of a commit message. It should give "
"some insight to the fix this commit adds to the codebase."
)
_footer = "Closes: #400"
@pytest.mark.parametrize(
"message, descriptions",
[
("feat(parser): add emoji parser", ["add emoji parser"]),
(
"fix(parser): fix regex in conventional parser",
["fix regex in conventional parser"],
),
(
"test(parser): add a test for conventional parser",
["add a test for conventional parser"],
),
(
f"fix(tox): fix env \n\n{_long_text}\n\n{_footer}",
["fix env ", _long_text],
),
("fix: superfix", ["superfix"]),
],
)
def test_parser_return_subject_from_commit_message(
default_conventional_parser: ConventionalCommitParser,
message: str,
descriptions: list[str],
make_commit_obj: MakeCommitObjFn,
):
parsed_results = default_conventional_parser.parse(make_commit_obj(message))
assert isinstance(parsed_results, Iterable)
assert len(parsed_results) == 1
result = next(iter(parsed_results))
assert isinstance(result, ParsedCommit)
assert result.descriptions == descriptions
@pytest.mark.parametrize(
"message, subject, merge_request_number",
[
# GitHub, Gitea style
(
"feat(parser): add emoji parser (#123)",
"add emoji parser",
"#123",
),
# GitLab style
(
"fix(parser): fix regex in conventional parser (!456)",
"fix regex in conventional parser",
"!456",
),
# BitBucket style
(
"feat(parser): add emoji parser (pull request #123)",
"add emoji parser",
"#123",
),
# Both a linked merge request and an issue footer (should return the linked merge request)
("fix: superfix (#123)\n\nCloses: #400", "superfix", "#123"),
# None
("fix: superfix", "superfix", ""),
# None but includes an issue footer it should not be considered a linked merge request
("fix: superfix\n\nCloses: #400", "superfix", ""),
],
)
def test_parser_return_linked_merge_request_from_commit_message(
default_conventional_parser: ConventionalCommitParser,
message: str,
subject: str,
merge_request_number: str,
make_commit_obj: MakeCommitObjFn,
):
parsed_results = default_conventional_parser.parse(make_commit_obj(message))
assert isinstance(parsed_results, Iterable)
assert len(parsed_results) == 1
result = next(iter(parsed_results))
assert isinstance(result, ParsedCommit)
assert merge_request_number == result.linked_merge_request
assert subject == result.descriptions[0]
@pytest.mark.parametrize(
"message, linked_issues",
[
*[
# GitHub, Gitea, GitLab style
(
f"feat(parser): add magic parser\n\n{footer}",
linked_issues,
)
for footer_prefix in SUPPORTED_ISSUE_CLOSURE_PREFIXES
for footer, linked_issues in [
# Single issue
(
f"{footer_prefix.capitalize()}: #555",
["#555"],
), # Git Footer style (capitalized)
(f"{footer_prefix.lower()}: #555", ["#555"]), # lowercase prefix
(f"{footer_prefix.upper()}: #555", ["#555"]), # uppercase prefix
# Mulitple issues (variant 1: list with one prefix, not supported by GitHub)
(
f"{footer_prefix}: #555,#444",
["#444", "#555"],
), # Comma separated (w/o space)
(
f"{footer_prefix}: #555, #444",
["#444", "#555"],
), # Comma separated (w/ space)
(
f"{footer_prefix}: #555 , #444",
["#444", "#555"],
), # Comma separated (w/ extra space)
(f"{footer_prefix}: #555 #444", ["#444", "#555"]), # Space separated
(
f"{footer_prefix}: #555;#444",
["#444", "#555"],
), # semicolon separated (w/o space)
(
f"{footer_prefix}: #555; #444",
["#444", "#555"],
), # semicolon separated (w/ space)
(
f"{footer_prefix}: #555 ; #444",
["#444", "#555"],
), # semicolon separated (w/ extra space)
(
f"{footer_prefix}: #555/#444",
["#444", "#555"],
), # slash separated (w/o space)
(
f"{footer_prefix}: #555/ #444",
["#444", "#555"],
), # slash separated (w/ space)
(
f"{footer_prefix}: #555 / #444",
["#444", "#555"],
), # slash separated (w/ extra space)
(
f"{footer_prefix}: #555Ƽ",
["#444", "#555"],
), # ampersand separated (w/o space)
(
f"{footer_prefix}: #555& #444",
["#444", "#555"],
), # ampersand separated (w/ space)
(
f"{footer_prefix}: #555 & #444",
["#444", "#555"],
), # ampersand separated (w/ extra space)
(f"{footer_prefix}: #555 and #444", ["#444", "#555"]), # and separated
(
f"{footer_prefix}: #555, #444, and #333",
["#333", "#444", "#555"],
), # and separated
# Mulitple issues (variant 2: multiple footers, supported by GitHub)
(f"{footer_prefix}: #555\n{footer_prefix}: #444", ["#444", "#555"]),
# More than 2 issues
(
f"{footer_prefix}: #555, #444, #333",
["#333", "#444", "#555"],
),
# More than 2 issues (force numerical sort)
(
f"{footer_prefix}: #555, #3333, #444",
["#444", "#555", "#3333"],
),
# Single issue listed multiple times
(f"{footer_prefix}: #555, #555", ["#555"]),
# Multiple footers with the same issue
(f"{footer_prefix}: #555\n{footer_prefix}: #555", ["#555"]),
# Multiple issues via multiple inline git footers
(f"{footer_prefix}: #555, {footer_prefix}: #444", ["#444", "#555"]),
# Multiple valid footers
(
str.join(
"\n",
[
f"{footer_prefix}: #555",
"Signed-off-by: johndoe <johndoe@mail.com>",
f"{footer_prefix}: #444",
],
),
["#444", "#555"],
),
# ----------------------------------------- Invalid Sets ----------------------------------------- #
# Must have colon because it is a git footer, these will not return a linked issue
(f"{footer_prefix} #666", []),
(f"{footer_prefix} #666, #777", []),
# Invalid Multiple issues (although it is supported by GitHub, it is not supported by the parser)
(f"{footer_prefix} #666, {footer_prefix} #777", []),
# Invalid 'and' separation
(f"{footer_prefix}: #666and#777", ["#666and#777"]),
# Invalid prefix
("ref: #666", []),
# body mentions an issue and has a different git footer
(
"In #666, the devils in the details...\n\nSigned-off-by: johndoe <johndoe@mail.com>",
[],
),
]
],
*[
# JIRA style
(
f"feat(parser): add magic parser\n\n{footer}",
linked_issues,
)
for footer_prefix in SUPPORTED_ISSUE_CLOSURE_PREFIXES
for footer, linked_issues in [
# Single issue
(
f"{footer_prefix.capitalize()}: ABC-555",
["ABC-555"],
), # Git Footer style (capitalized)
(f"{footer_prefix.lower()}: ABC-555", ["ABC-555"]), # lowercase prefix
(f"{footer_prefix.upper()}: ABC-555", ["ABC-555"]), # uppercase prefix
# Mulitple issues (variant 1: list with one prefix, not supported by GitHub)
(
f"{footer_prefix}: ABC-555,ABC-444",
["ABC-444", "ABC-555"],
), # Comma separated (w/o space)
(
f"{footer_prefix}: ABC-555, ABC-444",
["ABC-444", "ABC-555"],
), # Comma separated (w/ space)
(
f"{footer_prefix}: ABC-555 , ABC-444",
["ABC-444", "ABC-555"],
), # Comma separated (w/ extra space)
(
f"{footer_prefix}: ABC-555 ABC-444",
["ABC-444", "ABC-555"],
), # Space separated
(
f"{footer_prefix}: ABC-555;ABC-444",
["ABC-444", "ABC-555"],
), # semicolon separated (w/o space)
(
f"{footer_prefix}: ABC-555; ABC-444",
["ABC-444", "ABC-555"],
), # semicolon separated (w/ space)
(
f"{footer_prefix}: ABC-555 ; ABC-444",
["ABC-444", "ABC-555"],
), # semicolon separated (w/ extra space)
(
f"{footer_prefix}: ABC-555/ABC-444",
["ABC-444", "ABC-555"],
), # slash separated (w/o space)
(
f"{footer_prefix}: ABC-555/ ABC-444",
["ABC-444", "ABC-555"],
), # slash separated (w/ space)
(
f"{footer_prefix}: ABC-555 / ABC-444",
["ABC-444", "ABC-555"],
), # slash separated (w/ extra space)
(
f"{footer_prefix}: ABC-555&ABC-444",
["ABC-444", "ABC-555"],
), # ampersand separated (w/o space)
(
f"{footer_prefix}: ABC-555& ABC-444",
["ABC-444", "ABC-555"],
), # ampersand separated (w/ space)
(
f"{footer_prefix}: ABC-555 & ABC-444",
["ABC-444", "ABC-555"],
), # ampersand separated (w/ extra space)
(
f"{footer_prefix}: ABC-555 and ABC-444",
["ABC-444", "ABC-555"],
), # and separated
(
f"{footer_prefix}: ABC-555, ABC-444, and ABC-333",
["ABC-333", "ABC-444", "ABC-555"],
), # and separated
# Mulitple issues (variant 2: multiple footers, supported by GitHub)
(
f"{footer_prefix}: ABC-555\n{footer_prefix}: ABC-444",
["ABC-444", "ABC-555"],
),
# More than 2 issues
(
f"{footer_prefix}: ABC-555, ABC-444, ABC-333",
["ABC-333", "ABC-444", "ABC-555"],
),
# More than 2 issues (force numerical sort)
(
f"{footer_prefix}: ABC-555, ABC-3333, ABC-444",
["ABC-444", "ABC-555", "ABC-3333"],
),
# Single issue listed multiple times
(f"{footer_prefix}: ABC-555, ABC-555", ["ABC-555"]),
# Multiple footers with the same issue
(f"{footer_prefix}: ABC-555\n{footer_prefix}: ABC-555", ["ABC-555"]),
# Multiple issues via multiple inline git footers
(
f"{footer_prefix}: ABC-666, {footer_prefix}: ABC-777",
["ABC-666", "ABC-777"],
),
# Multiple valid footers
(
str.join(
"\n",
[
f"{footer_prefix}: ABC-555",
"Signed-off-by: johndoe <johndoe@mail.com>",
f"{footer_prefix}: ABC-444",
],
),
["ABC-444", "ABC-555"],
),
# ----------------------------------------- Invalid Sets ----------------------------------------- #
# Must have colon because it is a git footer, these will not return a linked issue
(f"{footer_prefix} ABC-666", []),
(f"{footer_prefix} ABC-666, ABC-777", []),
# Invalid Multiple issues (although it is supported by GitHub, it is not supported by the parser)
(f"{footer_prefix} ABC-666, {footer_prefix} ABC-777", []),
# Invalid 'and' separation
(f"{footer_prefix}: ABC-666andABC-777", ["ABC-666andABC-777"]),
# Invalid prefix
("ref: ABC-666", []),
# body mentions an issue and has a different git footer
(
"In ABC-666, the devils in the details...\n\nSigned-off-by: johndoe <johndoe@mail.com>",
[],
),
]
],
*[
(
f"feat(parser): add magic parser\n\n{footer}",
linked_issues,
)
for footer, linked_issues in [
# Multiple footers with the same issue but different prefixes
("Resolves: #555\nfix: #444", ["#444", "#555"]),
# Whitespace padded footer
(" Resolves: #555\n", ["#555"]),
]
],
(
# Only grabs the issue reference when there is a GitHub PR reference in the subject
"feat(parser): add magic parser (#123)\n\nCloses: #555",
["#555"],
),
# Does not grab an issue when there is only a GitHub PR reference in the subject
("feat(parser): add magic parser (#123)", []),
# Does not grab an issue when there is only a Bitbucket PR reference in the subject
("feat(parser): add magic parser (pull request #123)", []),
],
)
def test_parser_return_linked_issues_from_commit_message(
default_conventional_parser: ConventionalCommitParser,
message: str,
linked_issues: Sequence[str],
make_commit_obj: MakeCommitObjFn,
):
parsed_results = default_conventional_parser.parse(make_commit_obj(message))
assert isinstance(parsed_results, Iterable)
assert 1 == len(parsed_results)
result = next(iter(parsed_results))
assert isinstance(result, ParsedCommit)
assert tuple(linked_issues) == result.linked_issues
@pytest.mark.parametrize(
"message, notices",
[
pytest.param(
message,
notices,
id=test_id,
)
for test_id, message, notices in [
(
"single notice",
dedent(
"""\
fix(parser): fix regex in conventional parser
NOTICE: This is a notice
"""
),
["This is a notice"],
),
(
"multiline notice",
dedent(
"""\
fix(parser): fix regex in conventional parser
NOTICE: This is a notice that is longer than
other notices
"""
),
["This is a notice that is longer than other notices"],
),
(
"multiple notices",
dedent(
"""\
fix(parser): fix regex in conventional parser
NOTICE: This is a notice
NOTICE: This is a second notice
"""
),
["This is a notice", "This is a second notice"],
),
(
"notice with other footer",
dedent(
"""\
fix(parser): fix regex in conventional parser
BREAKING CHANGE: This is a breaking change
NOTICE: This is a notice
"""
),
["This is a notice"],
),
]
],
)
def test_parser_return_release_notices_from_commit_message(
default_conventional_parser: ConventionalCommitParser,
message: str,
notices: Sequence[str],
make_commit_obj: MakeCommitObjFn,
):
parsed_results = default_conventional_parser.parse(make_commit_obj(message))
assert isinstance(parsed_results, Iterable)
assert len(parsed_results) == 1
result = next(iter(parsed_results))
assert isinstance(result, ParsedCommit)
assert tuple(notices) == result.release_notices
full_description = str.join("\n\n", result.descriptions)
full_notice = str.join("\n\n", result.release_notices)
assert full_notice not in full_description
##############################
# test custom parser options #
##############################
def test_parser_custom_default_level(make_commit_obj: MakeCommitObjFn):
options = ConventionalCommitParserOptions(default_bump_level=LevelBump.MINOR)
parsed_results = ConventionalCommitParser(options).parse(
make_commit_obj("test(parser): add a test for conventional parser")
)
assert isinstance(parsed_results, Iterable)
result = next(iter(parsed_results))
assert isinstance(result, ParsedCommit)
assert result.bump is LevelBump.MINOR
def test_parser_custom_allowed_types(
default_conventional_parser: ConventionalCommitParser,
make_commit_obj: MakeCommitObjFn,
):
new_tag = "custom"
custom_allowed_tags = [*default_conventional_parser.options.allowed_tags, new_tag]
parser = ConventionalCommitParser(
options=ConventionalCommitParserOptions(
allowed_tags=tuple(custom_allowed_tags),
)
)
for commit_type, commit_msg in [
(new_tag, f"{new_tag}: ..."), # no scope
(new_tag, f"{new_tag}(parser): ..."), # with scope
("chores", "chore(parser): ..."), # existing, non-release tag
]:
parsed_results = parser.parse(make_commit_obj(commit_msg))
assert isinstance(parsed_results, Iterable)
result = next(iter(parsed_results))
assert isinstance(result, ParsedCommit)
assert result.type == commit_type
assert result.bump is LevelBump.NO_RELEASE
def test_parser_custom_allowed_types_ignores_non_types(
default_conventional_parser: ConventionalCommitParser,
make_commit_obj: MakeCommitObjFn,
):
banned_tag = "feat"
custom_allowed_tags = [*default_conventional_parser.options.allowed_tags]
custom_allowed_tags.remove(banned_tag)
parser = ConventionalCommitParser(
options=ConventionalCommitParserOptions(
allowed_tags=tuple(custom_allowed_tags),
)
)
parsed_results = parser.parse(make_commit_obj(f"{banned_tag}(parser): ..."))
assert isinstance(parsed_results, Iterable)
result = next(iter(parsed_results))
assert isinstance(result, ParseError)
def test_parser_custom_minor_tags(make_commit_obj: MakeCommitObjFn):
custom_minor_tag = "docs"
parser = ConventionalCommitParser(
options=ConventionalCommitParserOptions(minor_tags=(custom_minor_tag,))
)
parsed_results = parser.parse(make_commit_obj(f"{custom_minor_tag}: ..."))
assert isinstance(parsed_results, Iterable)
result = next(iter(parsed_results))
assert isinstance(result, ParsedCommit)
assert result.bump is LevelBump.MINOR
def test_parser_custom_patch_tags(make_commit_obj: MakeCommitObjFn):
custom_patch_tag = "test"
parser = ConventionalCommitParser(
options=ConventionalCommitParserOptions(patch_tags=(custom_patch_tag,))
)
parsed_results = parser.parse(make_commit_obj(f"{custom_patch_tag}: ..."))
assert isinstance(parsed_results, Iterable)
result = next(iter(parsed_results))
assert isinstance(result, ParsedCommit)
assert result.bump is LevelBump.PATCH
def test_parser_ignore_merge_commit(
default_conventional_parser: ConventionalCommitParser,
make_commit_obj: MakeCommitObjFn,
):
# Setup: Enable parsing of linked issues
parser = ConventionalCommitParser(
options=ConventionalCommitParserOptions(
**{
**default_conventional_parser.options.__dict__,
"ignore_merge_commits": True,
}
)
)
base_commit = make_commit_obj("Merge branch 'fix/fix-feature' into 'main'")
incomming_commit = make_commit_obj("feat: add a new feature")
# Setup: Create a merge commit
merge_commit = make_commit_obj("Merge branch 'feat/add-new-feature' into 'main'")
merge_commit.parents = [base_commit, incomming_commit]
# Action
parsed_result = parser.parse(merge_commit)
assert isinstance(parsed_result, ParseError)
assert "Ignoring merge commit" in parsed_result.error
|